Skip to content

Conversation

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Sep 30, 2024

Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/apidiff.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/18.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903849: Scrape off Apache Ant remnants from APIDiff

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2024
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to apidiff.

Yes, less in more.

I encourage you to look at adding appropriate text and files for working on the code in an IDE, and being able to run tests there.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2024
@pavelrappo
Copy link
Member Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Sep 30, 2024

Webrevs

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@pavelrappo
Your change (at version da473d2) is now ready to be sponsored by a Committer.

@jonathan-gibbons
Copy link
Contributor

jonathan-gibbons commented Sep 30, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

Going to push as commit e0b049a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2024
@openjdk openjdk bot closed this Sep 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@jonathan-gibbons @pavelrappo Pushed as commit e0b049a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants