-
Notifications
You must be signed in to change notification settings - Fork 9
7903849: Scrape off Apache Ant remnants from APIDiff #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prappo! A progress list of the required criteria for merging this PR into |
|
@pavelrappo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to apidiff.
Yes, less in more.
I encourage you to look at adding appropriate text and files for working on the code in an IDE, and being able to run tests there.
|
/integrate |
|
@pavelrappo |
|
/sponsor |
|
Going to push as commit e0b049a. |
|
@jonathan-gibbons @pavelrappo Pushed as commit e0b049a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/18/head:pull/18$ git checkout pull/18Update a local copy of the PR:
$ git checkout pull/18$ git pull https://git.openjdk.org/apidiff.git pull/18/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18View PR using the GUI difftool:
$ git pr show -t 18Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/18.diff
Webrev
Link to Webrev Comment