Skip to content

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Oct 1, 2024

Please review a fix for a trivial typo in a comment in a test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/apidiff.git pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/21.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903851: apidiff: typo in comment for HtmlDiffBuilderTest

Reviewed-by: prappo, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 10a494c: 7903830: apidiff: Review glyphs used to indicate same/difference
  • e0b049a: 7903849: Scrape off Apache Ant remnants from APIDiff
  • dbaa7ac: 7903846: apidiff: test issues on Windows
  • bb3eb15: 7903838: apidiff: Update Vintage JUnit test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title CODETOOLS-7903851: apidiff: typo in comment for HtmlDiffBuilderTest 7903851: apidiff: typo in comment for HtmlDiffBuilderTest Oct 1, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024
@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented Oct 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

Going to push as commit 8974473.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1884101: 7903852: apidiff: IllegalArgumentException for RECORD_COMPONENT
  • 10a494c: 7903830: apidiff: Review glyphs used to indicate same/difference
  • e0b049a: 7903849: Scrape off Apache Ant remnants from APIDiff
  • dbaa7ac: 7903846: apidiff: test issues on Windows
  • bb3eb15: 7903838: apidiff: Update Vintage JUnit test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2024
@openjdk openjdk bot closed this Oct 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2024
@jonathan-gibbons jonathan-gibbons deleted the apidiff.7903851.htmldiffbuildertest branch October 1, 2024 18:33
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@jonathan-gibbons Pushed as commit 8974473.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants