-
Notifications
You must be signed in to change notification settings - Fork 9
7903856: apidiff: 7903837 breaks some builds #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903856: apidiff: 7903837 breaks some builds #22
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on Windows
|
/integrate |
|
Going to push as commit db3c474. |
|
@jonathan-gibbons Pushed as commit db3c474. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a small but important fix for an issue handling EQUINOX_JAR in some build environments.
The underlying issue is that EQUINOX_JAR may or may not be required, depending on the configuration for DAISYDIFF.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/22/head:pull/22$ git checkout pull/22Update a local copy of the PR:
$ git checkout pull/22$ git pull https://git.openjdk.org/apidiff.git pull/22/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22View PR using the GUI difftool:
$ git pr show -t 22Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/22.diff
Webrev
Link to Webrev Comment