-
Notifications
You must be signed in to change notification settings - Fork 9
7903857: apidiff: Include test run in GitHub Actions workflow #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903857: apidiff: Include test run in GitHub Actions workflow #23
Conversation
|
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
How did you verify that the updated workflow works? |
They did not! See latest failed runs at https://github.com/sormuras/apidiff/actions/workflows/test.yml |
Please review this change to actually run ApiDiff's self-tests on all three major platforms.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/23/head:pull/23$ git checkout pull/23Update a local copy of the PR:
$ git checkout pull/23$ git pull https://git.openjdk.org/apidiff.git pull/23/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23View PR using the GUI difftool:
$ git pr show -t 23Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/23.diff
Webrev
Link to Webrev Comment