Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Oct 2, 2024

Please review this change to actually run ApiDiff's self-tests on all three major platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue CODETOOLS-7903857

Issue

  • CODETOOLS-7903857: Include test run in GitHub Actions workflow (Enhancement - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/apidiff.git pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/23.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903857: apidiff: Include test run in GitHub Actions workflow 7903857: apidiff: Include test run in GitHub Actions workflow Oct 2, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2024

Webrevs

@pavelrappo
Copy link
Member

How did you verify that the updated workflow works?

@sormuras
Copy link
Member Author

sormuras commented Oct 2, 2024

How did you verify that the updated workflow works?

They did not! See latest failed runs at https://github.com/sormuras/apidiff/actions/workflows/test.yml

@sormuras sormuras marked this pull request as draft October 2, 2024 14:28
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 2, 2024
@sormuras sormuras closed this Oct 10, 2024
@sormuras sormuras deleted the CODETOOLS-7903857-run-tests-on-windows branch October 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants