-
Notifications
You must be signed in to change notification settings - Fork 9
7903876: Improve the man page, with (more) examples #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903876: Improve the man page, with (more) examples #28
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great man page expansion! I like the additional examples (particularly the one for CSRs). I'm sure there are several other common cases which could use examples.
|
/integrate |
|
Going to push as commit 1dbbcb5. |
|
@jonathan-gibbons Pushed as commit 1dbbcb5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review an update to the main documentation page for the
apidifftool. The updates are primarily clarifications and examples, intended to reduce some of the recent confusion about using the tool. As well as clarification and examples throughout the page, two more full examples are given at the end. These examples have been tested with scripts. They are meant to be indicative of what one might use to create a diff report for a CSR submission.The generated HTML for the page can be seen here: https://cr.openjdk.org/~jjg/7903876/doc/apidiff.html
For the record, the scripts used to test the examples are as follows:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/28/head:pull/28$ git checkout pull/28Update a local copy of the PR:
$ git checkout pull/28$ git pull https://git.openjdk.org/apidiff.git pull/28/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28View PR using the GUI difftool:
$ git pr show -t 28Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/28.diff
Webrev
Link to Webrev Comment