Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Aug 27, 2025

Please review this change updating to use JUnit 5.13.4


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/apidiff.git pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/30.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2025

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7904068: Update to use JUnit 5.13

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@sormuras
Copy link
Member Author

Want to see the build fail due to a checksum error.

So it did:

[build.sh][INFO] Downloading https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.4/junit-platform-console-standalone-1.13.4.jar to /home/runner/work/apidiff/apidiff/build/deps/junit/junit-platform-console-standalone-1.13.4.jar
Error: sh][ERROR] Checksum mismatch for /home/runner/work/apidiff/apidiff/build/deps/junit/junit-platform-console-standalone-1.13.4.jar:
Error: sh][ERROR] Expected: bb856bc86a6e6cd48080546afcaf7a210713ea21
Error: sh][ERROR] Actual  : 62734191af1bfc78ee17181ca38b94dbb5eb7737
Error: Process completed with exit code 1.

@sormuras sormuras changed the title Update to use JUnit 5.13 7904068: Update to use JUnit 5.13 Aug 28, 2025
@sormuras sormuras marked this pull request as ready for review August 28, 2025 06:50
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 28, 2025
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

Going to push as commit 7b0a1ee.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2025
@openjdk openjdk bot closed this Aug 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2025
@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@sormuras Pushed as commit 7b0a1ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the update-junit-to-5.13 branch August 29, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants