Skip to content

7904080: APIDiff does not detect javadoc (and changes to javadoc) for methods with varargs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

7904080: APIDiff does not detect javadoc (and changes to javadoc) for methods with varargs #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/share/classes/jdk/codetools/apidiff/model/APIReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ protected void startElement(String name, Map<String, String> attrs, boolean isSe
blockDepth = 0;
}
debugPrintln(() -> "!! set id for TYPE member " + id);
descriptionId = id;
descriptionId = id.replace("...)", "[])");
}
break;
}
Expand Down
10 changes: 9 additions & 1 deletion test/junit/apitest/APIReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,14 @@ public void m1() { }
* @see "See Text"
*/
public void m2() { }
/**
* This is first method with varagrs.
*/
public void varargs1(Integer i, String... texts) { }
/**
* This is second method with varagrs.
*/
public void varargs2(Integer i, int... texts) { }
/**
* This is nested class N. This is more test for N.
* @see "See Text"
Expand Down Expand Up @@ -367,7 +375,7 @@ private void checkFile(Log log, Path file) {

case "C.html" -> {
checkDescription(docs.getDescription(), null, null, "This is class C. This is more");
checkMemberDescriptions(docs.getMemberDescriptions(), "<init>()", "<init>(int)", "f1", "f2", "m1()", "m2()");
checkMemberDescriptions(docs.getMemberDescriptions(), "<init>()", "<init>(int)", "f1", "f2", "m1()", "m2()", "varargs1(java.lang.Integer,java.lang.String[])", "varargs2(java.lang.Integer,int[])");
checkDescription(docs.getDescription("<init>()"),
"<init>()", "C", "This is the no-args constructor. This is more");
}
Expand Down