Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Sep 25, 2024

Please review this test workflow for building ApiDiff on every pull request.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/apidiff.git pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/9.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903836: apidiff: Add GitHub Actions test workflow

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b8685ae: 7903829: apidiff: update TestNG reference to JUnit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@sormuras sormuras changed the title Add GitHub Actions test workflow 7903836: Add GitHub Actions test workflow Sep 25, 2024
@sormuras sormuras marked this pull request as ready for review September 25, 2024 16:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2024

Webrevs

@sormuras sormuras changed the title 7903836: Add GitHub Actions test workflow 7903836: apidiff: Add GitHub Actions test workflow Sep 25, 2024
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Provisional" approval, to enable the workflow

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2024
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

Going to push as commit a1bacee.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b8685ae: 7903829: apidiff: update TestNG reference to JUnit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2024
@openjdk openjdk bot closed this Sep 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@sormuras Pushed as commit a1bacee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the add-github-workflow branch September 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants