Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7902913: jasm incorrectly processes the instruction pair: ldc MethodHandle #18

Closed
wants to merge 1 commit into from

Conversation

lkuskov
Copy link
Collaborator

@lkuskov lkuskov commented May 1, 2021

This fix is for https://bugs.openjdk.java.net/browse/CODETOOLS-7902913
that is the regression of the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902892
The fix adds the token SEMICOLON to the list of alllowed which was missed in the metod checkReferenceIndex that checks a token that follows reference_kind:[reference_index | [class|interface] | method]


Progress

  • Change must not contain extraneous whitespace

Issue

  • CODETOOLS-7902913: jasm incorrectly processes the instruction pair: ldc MethodHandle

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/asmtools pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.java.net/asmtools pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/asmtools/pull/18.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 1, 2021

👋 Welcome back lkuskov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 1, 2021

@lkuskov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7902913: jasm incorrectly processes the instruction pair: ldc MethodHandle

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels May 1, 2021
@lkuskov
Copy link
Collaborator Author

@lkuskov lkuskov commented May 1, 2021

/integrate

@openjdk openjdk bot closed this May 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 1, 2021

@lkuskov Pushed as commit 9e36237.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lkuskov lkuskov deleted the CODETOOLS-7902913 branch May 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 1, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
1 participant