Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

988: Skara webrev is empty if patch has deleted files #14

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -501,10 +501,7 @@
patchFile.innerHTML = "Patch";
code.append(patchFile, " ");

const rawFile = create("a");
rawFile.href = "https://raw.githubusercontent.com/" + metadata.head.repo.full_name + "/" + metadata.head.sha + "/" + file.filename;
rawFile.innerHTML = "Raw";
code.append(rawFile, " ");
code.append("--- ");
erikj79 marked this conversation as resolved.
Show resolved Hide resolved

p.append(code);

@@ -1521,7 +1518,9 @@
dstLines.push(line);
} else if (line.startsWith("\\ No newline at end of file")) {
continue;
} else {
} else if (line === "") {
continue;
} else {
throw "Unexpected content on line " + i + ": '" + line + "'";
}
}
@@ -1621,7 +1620,7 @@
const index = state.index;
const file = state.comparison.files[index];
if (file.status === "deleted") {
return;
return Promise.resolve([]);
}

const raw_url = "https://raw.githubusercontent.com";