Skip to content

8344647: Make java.se participate in the preview language feature requires transitive java.base #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented Apr 22, 2025

CRaC trunk (6471053) fails to compile for me the same way as jdk-25+2:

=== Output from failing command(s) repeated here ===
* For target buildtools_depend__the.COMPILE_DEPEND_batch:
error: cannot access module-info
  bad class file: /modules/java.se/module-info.class
    bad requires flag: ACC_TRANSITIVE (0x0020
    Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error
* For target buildtools_jdk_tools_classes__the.BUILD_TOOLS_JDK_batch:
error: cannot access module-info
  bad class file: /modules/java.se/module-info.class
    bad requires flag: ACC_TRANSITIVE (0x0020
    Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error

It has been fixed upstream which is what I am backporting.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8344647: Make java.se participate in the preview language feature requires transitive java.base (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.org/crac.git pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/226.diff

Using Webrev

Link to Webrev Comment

…quires transitive java.base`

Reviewed-by: asotona, darcy
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344647: Make java.se participate in the preview language feature `requires transitive java.base`

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d50b725ac0f228f5b04dd68c123c7f6b263c0d02 8344647: Make java.se participate in the preview language feature requires transitive java.base Apr 22, 2025
@openjdk
Copy link

openjdk bot commented Apr 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2025

Webrevs

@jankratochvil
Copy link
Contributor Author

jankratochvil commented Apr 22, 2025

It would get also fixed by #224.

@jankratochvil
Copy link
Contributor Author

Superseded by #224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants