Skip to content

Conversation

@TimPushkin
Copy link
Collaborator

@TimPushkin TimPushkin commented May 23, 2025

Adds updates of cached PID on restore.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8357641: [CRaC] Support PID change during checkpoint-restore (Enhancement - P4)

Reviewers

Contributors

  • Radim Vansa <rvansa@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/229/head:pull/229
$ git checkout pull/229

Update a local copy of the PR:
$ git checkout pull/229
$ git pull https://git.openjdk.org/crac.git pull/229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 229

View PR using the GUI difftool:
$ git pr show -t 229

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/229.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357641: [CRaC] Support PID change during checkpoint-restore

Co-authored-by: Radim Vansa <rvansa@openjdk.org>
Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2025
@TimPushkin
Copy link
Collaborator Author

/contributor add rvansa

@openjdk
Copy link

openjdk bot commented May 23, 2025

@TimPushkin
Contributor Radim Vansa <rvansa@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

Copy link
Collaborator

@rvansa rvansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TimPushkin
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 23, 2025
@openjdk
Copy link

openjdk bot commented May 23, 2025

@TimPushkin
Your change (at version d6a0cac) is now ready to be sponsored by a Committer.

@rvansa
Copy link
Collaborator

rvansa commented May 26, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented May 26, 2025

Going to push as commit d5191e5.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2025
@openjdk openjdk bot closed this May 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 26, 2025
@openjdk
Copy link

openjdk bot commented May 26, 2025

@rvansa @TimPushkin Pushed as commit d5191e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TimPushkin TimPushkin deleted the getpid branch May 29, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants