Skip to content

Conversation

@TimPushkin
Copy link
Collaborator

@TimPushkin TimPushkin commented Jul 24, 2025

Fixes the issue by reducing the scope of the NoSuchMethodException's try-catch statement.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8364078: [CRaC] CracTest mishandles NoSuchMethodException (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/249/head:pull/249
$ git checkout pull/249

Update a local copy of the PR:
$ git checkout pull/249
$ git pull https://git.openjdk.org/crac.git pull/249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 249

View PR using the GUI difftool:
$ git pr show -t 249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/249.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364078: [CRaC] CracTest mishandles NoSuchMethodException

Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the crac branch:

  • 9a1ab26: 8362837: [CRaC] jdk/crac/MXBean.java can fail on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2025

Webrevs

@TimPushkin
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

Going to push as commit 5ceee7d.
Since your change was applied there has been 1 commit pushed to the crac branch:

  • 9a1ab26: 8362837: [CRaC] jdk/crac/MXBean.java can fail on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2025
@openjdk openjdk bot closed this Jul 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@TimPushkin Pushed as commit 5ceee7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TimPushkin TimPushkin deleted the fix-crac-test branch July 25, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants