Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7902823: RepGen fails with IllegalFormatArgumentIndexException if started by JDK 16 and above #7

Closed
wants to merge 12 commits into from

Conversation

lkuskov
Copy link
Collaborator

@lkuskov lkuskov commented Jan 28, 2021

This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902823
The fix corrects the improper usage of the Formatter that only allows argument indexes starting from 1 (not 0)
Also the fix updates a percentage rounding - the floor operation is used insted of the round.


Progress

  • Change must not contain extraneous whitespace

Issue

  • CODETOOLS-7902823: RepGen fails with IllegalFormatArgumentIndexException if started by JDK 16 and above

Download

$ git fetch https://git.openjdk.java.net/jcov pull/7/head:pull/7
$ git checkout pull/7

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back lkuskov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@lkuskov this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout CODETOOLS-7902823
git fetch https://git.openjdk.java.net/jcov master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

⚠️ @lkuskov This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added merge-conflict The pull request has a merge conflict with the target branch rfr Ready for review labels Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@lkuskov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7902823: RepGen fails with IllegalFormatArgumentIndexException if started by JDK 16 and above

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated and removed merge-conflict The pull request has a merge conflict with the target branch labels Jan 29, 2021
@lkuskov
Copy link
Collaborator Author

lkuskov commented Jan 29, 2021

/integrate

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@lkuskov Pushed as commit 808a935.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lkuskov lkuskov deleted the CODETOOLS-7902823 branch January 29, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
1 participant