Skip to content
Permalink
Browse files
8277303: Terminology mismatch between JLS17-3.9 and SE17's javax.lang…
….model.SourceVersion method specs

Reviewed-by: iris, jjg
  • Loading branch information
jddarcy committed Nov 17, 2021
1 parent 8881f29 commit 007ad7c77c6277ce733386b4402b787d81dd41cf
Showing 1 changed file with 10 additions and 10 deletions.
@@ -312,8 +312,8 @@ public static SourceVersion latestSupported() {
* Character#isJavaIdentifierStart(int)} returns {@code true},
* followed only by characters for which {@link
* Character#isJavaIdentifierPart(int)} returns {@code true}.
* This pattern matches regular identifiers, keywords, restricted
* keywords, restricted identifiers and the literals {@code "true"},
* This pattern matches regular identifiers, keywords, contextual
* keywords, and the literals {@code "true"},
* {@code "false"}, {@code "null"}.
*
* The method returns {@code false} for all other strings.
@@ -359,8 +359,8 @@ public static boolean isIdentifier(CharSequence name) {
* {@code false} for keywords, boolean literals, and the null
* literal in any segment.
*
* This method returns {@code true} for <i>restricted
* keywords</i> and <i>restricted identifiers</i>.
* This method returns {@code true} for <i>contextual
* keywords</i>.
*
* @param name the string to check
* @return {@code true} if this string is a
@@ -385,8 +385,8 @@ public static boolean isName(CharSequence name) {
* {@code false} for keywords, boolean literals, and the null
* literal in any segment.
*
* This method returns {@code true} for <i>restricted
* keywords</i> and <i>restricted identifiers</i>.
* This method returns {@code true} for <i>contextual
* keywords</i>.
*
* @param name the string to check
* @param version the version to use
@@ -409,8 +409,8 @@ public static boolean isName(CharSequence name, SourceVersion version) {
/**
* Returns whether or not {@code s} is a keyword, boolean literal,
* or null literal in the latest source version.
* This method returns {@code false} for <i>restricted
* keywords</i> and <i>restricted identifiers</i>.
* This method returns {@code false} for <i>contextual
* keywords</i>.
*
* @param s the string to check
* @return {@code true} if {@code s} is a keyword, or boolean
@@ -426,8 +426,8 @@ public static boolean isKeyword(CharSequence s) {
/**
* Returns whether or not {@code s} is a keyword, boolean literal,
* or null literal in the given source version.
* This method returns {@code false} for <i>restricted
* keywords</i> and <i>restricted identifiers</i>.
* This method returns {@code false} for <i>contextual
* keywords</i>.
*
* @param s the string to check
* @param version the version to use

1 comment on commit 007ad7c

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 007ad7c Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.