Skip to content

Commit

Permalink
8316947: Write a test to check textArea triggers MouseEntered/MouseEx…
Browse files Browse the repository at this point in the history
…ited events properly

Reviewed-by: tr, honkar, aivanov
  • Loading branch information
Ravi Gupta authored and aivanov-jdk committed Oct 12, 2023
1 parent 77dc891 commit 00ef9f9
Showing 1 changed file with 132 additions and 0 deletions.
132 changes: 132 additions & 0 deletions test/jdk/java/awt/event/MouseEvent/MouseEnterExitTest.java
@@ -0,0 +1,132 @@
/*
* Copyright (c) 2007, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import java.awt.Dimension;
import java.awt.EventQueue;
import java.awt.FlowLayout;
import java.awt.Frame;
import java.awt.List;
import java.awt.Point;
import java.awt.Robot;
import java.awt.TextArea;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;

/*
* @test
* @key headful
* @bug 4454304
* @summary On Solaris, TextArea triggers MouseEntered when the mouse is inside the component
* @run main MouseEnterExitTest
*/
public class MouseEnterExitTest {

private static Frame frame;

private volatile static boolean entered = false;
private volatile static boolean exited = false;
private volatile static boolean passed = true;

private volatile static Point compAt;
private volatile static Dimension compSize;

private static final MouseListener mouseListener = new MouseAdapter() {
@Override
public void mouseEntered(MouseEvent e) {
System.out.println(
"MouseEntered component " + e.getSource().getClass().getName());
if (entered) {
passed = false;
}
entered = true;
exited = false;
}

@Override
public void mouseExited(MouseEvent e) {
System.out.println(
"MouseExited component " + e.getSource().getClass().getName());
if (exited) {
passed = false;
}
entered = false;
exited = true;
}
};

private static void initializeGUI() {
frame = new Frame("MouseEnterExitTest");
frame.setLayout(new FlowLayout());
List list = new List(4);
for (int i = 0; i < 10; i++) {
list.add("item " + i);
}
list.addMouseListener(mouseListener);
frame.add(list);

TextArea textArea = new TextArea("TextArea", 10, 20);
textArea.addMouseListener(mouseListener);
frame.add(textArea);

frame.pack();
frame.setLocationRelativeTo(null);
frame.setVisible(true);
}

public static void main(String[] args) throws Exception {
try {
Robot robot = new Robot();
robot.setAutoDelay(100);
robot.setAutoWaitForIdle(true);

EventQueue.invokeAndWait(MouseEnterExitTest::initializeGUI);
robot.waitForIdle();

EventQueue.invokeAndWait(() -> {
compAt = frame.getLocationOnScreen();
compSize = frame.getSize();
});
compAt.y += compSize.getHeight() / 2;
int xr = compAt.x + compSize.width + 1;
for (int i = compAt.x - 5; (i < xr) && passed; i++) {
robot.mouseMove(i, compAt.y);
}

if (!passed || entered || !exited) {
throw new RuntimeException(
"MouseEnterExitTest FAILED. MouseEntered/MouseExited "
+ "not properly triggered. Please see the log");
}
System.out.println("Test PASSED");
} finally {
EventQueue.invokeAndWait(MouseEnterExitTest::disposeFrame);
}
}

private static void disposeFrame() {
if (frame != null) {
frame.dispose();
}
}
}

7 comments on commit 00ef9f9

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 00ef9f9 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin the backport was successfully created on the branch backport-luchenlin-00ef9f9c in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 00ef9f9c from the openjdk/jdk repository.

The commit being backported was authored by Ravi Gupta on 12 Oct 2023 and was reviewed by Tejesh R, Harshitha Onkar and Alexey Ivanov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-luchenlin-00ef9f9c:backport-luchenlin-00ef9f9c
$ git checkout backport-luchenlin-00ef9f9c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-luchenlin-00ef9f9c

@luchenlin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 00ef9f9 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin the backport was successfully created on the branch backport-luchenlin-00ef9f9c in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 00ef9f9c from the openjdk/jdk repository.

The commit being backported was authored by Ravi Gupta on 12 Oct 2023 and was reviewed by Tejesh R, Harshitha Onkar and Alexey Ivanov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-luchenlin-00ef9f9c:backport-luchenlin-00ef9f9c
$ git checkout backport-luchenlin-00ef9f9c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-luchenlin-00ef9f9c

@luchenlin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 00ef9f9 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luchenlin the backport was successfully created on the branch backport-luchenlin-00ef9f9c in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 00ef9f9c from the openjdk/jdk repository.

The commit being backported was authored by Ravi Gupta on 12 Oct 2023 and was reviewed by Tejesh R, Harshitha Onkar and Alexey Ivanov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git backport-luchenlin-00ef9f9c:backport-luchenlin-00ef9f9c
$ git checkout backport-luchenlin-00ef9f9c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git backport-luchenlin-00ef9f9c

Please sign in to comment.