8354791: Use Hashtable.putIfAbsent in CSS constructor

Andrey Turbanov · Andrey Turbanov · commit 0110acaa9086 · 2025-04-30T11:29:06.000Z
Reviewed-by: serb, aivanov
diff --git a/src/java.desktop/share/classes/javax/swing/text/html/CSS.java b/src/java.desktop/share/classes/javax/swing/text/html/CSS.java
@@ -735,12 +735,8 @@ public CSS() {
         valueConvertor.put(CSS.Attribute.BACKGROUND_ATTACHMENT,
                            valueMapper);
         Object generic = new CssValue();
-        int n = CSS.Attribute.allAttributes.length;
-        for (int i = 0; i < n; i++) {
-            CSS.Attribute key = CSS.Attribute.allAttributes[i];
-            if (valueConvertor.get(key) == null) {
-                valueConvertor.put(key, generic);
-            }
+        for (CSS.Attribute key : CSS.Attribute.allAttributes) {
+            valueConvertor.putIfAbsent(key, generic);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -735,12 +735,8 @@ public CSS() {`
`735`	`735`	`valueConvertor.put(CSS.Attribute.BACKGROUND_ATTACHMENT,`
`736`	`736`	`valueMapper);`
`737`	`737`	`Object generic = new CssValue();`
`738`		`- int n = CSS.Attribute.allAttributes.length;`
`739`		`- for (int i = 0; i < n; i++) {`
`740`		`- CSS.Attribute key = CSS.Attribute.allAttributes[i];`
`741`		`- if (valueConvertor.get(key) == null) {`
`742`		`- valueConvertor.put(key, generic);`
`743`		`- }`
	`738`	`+ for (CSS.Attribute key : CSS.Attribute.allAttributes) {`
	`739`	`+ valueConvertor.putIfAbsent(key, generic);`
`744`	`740`	`}`
`745`	`741`	`}`
`746`	`742`