Skip to content

Commit

Permalink
8268852: AsyncLogWriter should not overide is_Named_thread()
Browse files Browse the repository at this point in the history
Reviewed-by: dholmes, ysuenaga
  • Loading branch information
Xin Liu authored and David Holmes committed Jun 16, 2021
1 parent b836b83 commit 02c9bf0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/hotspot/share/logging/logAsyncWriter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ class AsyncLogWriter : public NonJavaThread {
log_debug(logging, thread)("starting AsyncLog Thread tid = " INTX_FORMAT, os::current_thread_id());
}
char* name() const override { return (char*)"AsyncLog Thread"; }
bool is_Named_thread() const override { return true; }
void print_on(outputStream* st) const override {
st->print("\"%s\" ", name());
Thread::print_on(st);
Expand Down
4 changes: 3 additions & 1 deletion src/hotspot/share/runtime/thread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,9 @@ void Thread::print_on_error(outputStream* st, char* buf, int buflen) const {
else if (is_GC_task_thread()) { st->print("GCTaskThread"); }
else if (is_Watcher_thread()) { st->print("WatcherThread"); }
else if (is_ConcurrentGC_thread()) { st->print("ConcurrentGCThread"); }
else { st->print("Thread"); }
else if (this == AsyncLogWriter::instance()) {
st->print("%s", this->name());
} else { st->print("Thread"); }

if (is_Named_thread()) {
st->print(" \"%s\"", name());
Expand Down

1 comment on commit 02c9bf0

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.