Skip to content

Commit

Permalink
8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized…
Browse files Browse the repository at this point in the history 
… warning in libfdlibm k_rem_pio2.c

Reviewed-by: erikj, shade, ihse
  • Loading branch information
Hao Sun authored and Ningsheng Jian committed Sep 27, 2022
1 parent 49a7347 commit 02ea338
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions make/modules/java.base/lib/CoreLibraries.gmk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ $(eval $(call SetupNativeCompilation, BUILD_LIBFDLIBM, \
CFLAGS_windows_debug := -DLOGGING, \
CFLAGS_aix := -qfloat=nomaf, \
DISABLED_WARNINGS_gcc := sign-compare misleading-indentation array-bounds, \
DISABLED_WARNINGS_gcc_k_rem_pio2.c := maybe-uninitialized, \
DISABLED_WARNINGS_clang := sign-compare misleading-indentation, \
DISABLED_WARNINGS_microsoft := 4146 4244 4018, \
ARFLAGS := $(ARFLAGS), \
Expand Down

3 comments on commit 02ea338

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 02ea338 May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan Could not automatically backport 02ea3381 to openjdk/jdk11u-dev due to conflicts in the following files:

  • make/lib/CoreLibraries.gmk

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-sendaoYan-02ea3381

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 02ea338177df781912dc782e32200eaf4731a0da

# Backport the commit
$ git cherry-pick --no-commit 02ea338177df781912dc782e32200eaf4731a0da
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 02ea338177df781912dc782e32200eaf4731a0da'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport 02ea338177df781912dc782e32200eaf4731a0da.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 02ea3381 from the openjdk/jdk repository.

The commit being backported was authored by Hao Sun on 27 Sep 2022 and was reviewed by Erik Joelsson, Aleksey Shipilev and Magnus Ihse Bursie.

Thanks!

Please sign in to comment.