Skip to content

Commit

Permalink
8285445: cannot open file "NUL:"
Browse files Browse the repository at this point in the history 
Reviewed-by: mikael
  • Loading branch information
Brian Burkhalter committed Apr 23, 2022
1 parent e9d604a commit 03cbb48
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/java.base/windows/classes/java/io/WinNTFileSystem.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,15 @@ class WinNTFileSystem extends FileSystem {

// Whether to enable alternative data streams (ADS) by suppressing
// checking the path for invalid characters, in particular ":".
// ADS support will be enabled if and only if the property is set and
// is the empty string or is equal, ignoring case, to the string "true".
// By default ADS support is disabled.
// By default, ADS support is enabled and will be disabled if and
// only if the property is set, ignoring case, to the string "false".
private static final boolean ENABLE_ADS;
static {
String enableADS = GetPropertyAction.privilegedGetProperty("jdk.io.File.enableADS");
if (enableADS != null) {
ENABLE_ADS = "".equals(enableADS) || Boolean.parseBoolean(enableADS);
ENABLE_ADS = !enableADS.equalsIgnoreCase(Boolean.FALSE.toString());
} else {
ENABLE_ADS = false;
ENABLE_ADS = true;
}
}

Expand Down
52 changes: 52 additions & 0 deletions test/jdk/java/io/FileOutputStream/OpenNUL.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8285445
* @requires (os.family == "windows")
* @summary Verify behavior of opening "NUL:" with ADS enabled and disabled.
* @run main/othervm -Djdk.io.File.enableADS OpenNUL
* @run main/othervm -Djdk.io.File.enableADS=true OpenNUL
*/

import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;

public class OpenNUL {
public static void main(String args[]) throws IOException {
String enableADS = System.getProperty("jdk.io.File.enableADS");
boolean fails = enableADS.equalsIgnoreCase(Boolean.FALSE.toString());

FileOutputStream fos;
try {
fos = new FileOutputStream("NUL:");
if (fails)
throw new RuntimeException("Should have failed");
} catch (FileNotFoundException fnfe) {
if (!fails)
throw new RuntimeException("Should not have failed");
}
}
}

19 comments on commit 03cbb48

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@bplb
Copy link
Member

@bplb bplb commented on 03cbb48 Apr 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk18u

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bplb the backport was successfully created on the branch bplb-backport-03cbb48e in my personal fork of openjdk/jdk18u. To create a pull request with this backport targeting openjdk/jdk18u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 03cbb48e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 23 Apr 2022 and was reviewed by Mikael Vidstedt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk18u:

$ git fetch https://github.com/openjdk-bots/jdk18u bplb-backport-03cbb48e:bplb-backport-03cbb48e
$ git checkout bplb-backport-03cbb48e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk18u bplb-backport-03cbb48e

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk15u-dev

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk8u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb Could not automatically backport 03cbb48e to openjdk/jdk17u-dev due to conflicts in the following files:

  • src/java.base/windows/classes/java/io/WinNTFileSystem.java

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk17u-dev:

$ git checkout -b mrserb-backport-03cbb48e
$ git fetch --no-tags https://git.openjdk.java.net/jdk 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ git cherry-pick --no-commit 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41.

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-03cbb48e in my personal fork of openjdk/jdk15u-dev. To create a pull request with this backport targeting openjdk/jdk15u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 03cbb48e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 23 Apr 2022 and was reviewed by Mikael Vidstedt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk15u-dev:

$ git fetch https://github.com/openjdk-bots/jdk15u-dev mrserb-backport-03cbb48e:mrserb-backport-03cbb48e
$ git checkout mrserb-backport-03cbb48e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk15u-dev mrserb-backport-03cbb48e

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb Could not automatically backport 03cbb48e to openjdk/jdk8u-dev due to conflicts in the following files:

  • jdk/src/windows/classes/java/io/WinNTFileSystem.java
  • jdk/test/java/io/FileOutputStream/OpenNUL.java

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk8u-dev:

$ git checkout -b mrserb-backport-03cbb48e
$ git fetch --no-tags https://git.openjdk.java.net/jdk 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ git cherry-pick --no-commit 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk8u-dev with the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41.

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb Could not automatically backport 03cbb48e to openjdk/jdk11u-dev due to conflicts in the following files:

  • src/java.base/windows/classes/java/io/WinNTFileSystem.java

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk11u-dev:

$ git checkout -b mrserb-backport-03cbb48e
$ git fetch --no-tags https://git.openjdk.java.net/jdk 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ git cherry-pick --no-commit 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41.

@MBaesken
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken Could not automatically backport 03cbb48e to openjdk/jdk17u-dev due to conflicts in the following files:

  • src/java.base/windows/classes/java/io/WinNTFileSystem.java

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk17u-dev:

$ git checkout -b MBaesken-backport-03cbb48e
$ git fetch --no-tags https://git.openjdk.java.net/jdk 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ git cherry-pick --no-commit 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41.

@MBaesken
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-03cbb48e in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 03cbb48e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 23 Apr 2022 and was reviewed by Mikael Vidstedt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-03cbb48e:MBaesken-backport-03cbb48e
$ git checkout MBaesken-backport-03cbb48e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-03cbb48e

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-03cbb48e in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 03cbb48e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 23 Apr 2022 and was reviewed by Mikael Vidstedt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-03cbb48e:mrserb-backport-03cbb48e
$ git checkout mrserb-backport-03cbb48e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev mrserb-backport-03cbb48e

@mrserb
Copy link
Member

@mrserb mrserb commented on 03cbb48 Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk8u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 03cbb48 Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb Could not automatically backport 03cbb48e to openjdk/jdk8u-dev due to conflicts in the following files:

  • jdk/test/java/io/FileOutputStream/OpenNUL.java

To manually resolve these conflicts run the following commands in your personal fork of openjdk/jdk8u-dev:

$ git checkout -b mrserb-backport-03cbb48e
$ git fetch --no-tags https://git.openjdk.java.net/jdk 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ git cherry-pick --no-commit 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41
$ # Resolve conflicts
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk8u-dev with the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41.

Please sign in to comment.