8351999: JFR: Incorrect scaling of throttled values

egahlin · egahlin · commit 0450ba9b65d0 · 2025-03-17T10:32:11.000Z
Reviewed-by: shade
diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/settings/ThrottleSetting.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/settings/ThrottleSetting.java
@@ -94,7 +94,7 @@ public void setValue(String value) {
             // if unit is less than 1 s, scale samples
             if (unit.nanos < SECONDS.nanos) {
                 long perSecond = SECONDS.nanos / unit.nanos;
-                samples *= Utils.multiplyOverflow(samples, perSecond, Long.MAX_VALUE);
+                samples = Utils.multiplyOverflow(samples, perSecond, Long.MAX_VALUE);
             }
             eventType.setThrottle(samples, millis);
             this.value = value;

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public void setValue(String value) {`
`94`	`94`	`// if unit is less than 1 s, scale samples`
`95`	`95`	`if (unit.nanos < SECONDS.nanos) {`
`96`	`96`	`long perSecond = SECONDS.nanos / unit.nanos;`
`97`		`- samples *= Utils.multiplyOverflow(samples, perSecond, Long.MAX_VALUE);`
	`97`	`+ samples = Utils.multiplyOverflow(samples, perSecond, Long.MAX_VALUE);`
`98`	`98`	`}`
`99`	`99`	`eventType.setThrottle(samples, millis);`
`100`	`100`	`this.value = value;`