Skip to content

Commit

Permalink
8319548: Unexpected internal name for Filler array klass causes error…
Browse files Browse the repository at this point in the history 
… in VisualVM

Co-authored-by: Tomáš Hůrka <tomas.hurka@oracle.com>
Reviewed-by: ayang, dholmes
  • Loading branch information
@thurka
Thomas Schatzl and thurka committed Dec 21, 2023
1 parent e8768ae commit 05745e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/hotspot/share/memory/universe.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ void Universe::genesis(TRAPS) {
// Initialization of the fillerArrayKlass must come before regular
// int-TypeArrayKlass so that the int-Array mirror points to the
// int-TypeArrayKlass.
_fillerArrayKlassObj = TypeArrayKlass::create_klass(T_INT, "Ljdk/internal/vm/FillerArray;", CHECK);
_fillerArrayKlassObj = TypeArrayKlass::create_klass(T_INT, "[Ljdk/internal/vm/FillerElement;", CHECK);
for (int i = T_BOOLEAN; i < T_LONG+1; i++) {
_typeArrayKlassObjs[i] = TypeArrayKlass::create_klass((BasicType)i, CHECK);
}
Expand Down
2 changes: 1 addition & 1 deletion test/hotspot/jtreg/gc/TestFillerObjectInstantiation.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ private static void testInstantiationFails(String classname) throws Exception {

public static void main(String[] args) throws Exception {
testInstantiationFails("jdk.internal.vm.FillerObject");
testInstantiationFails("jdk.internal.vm.FillerArray");
testInstantiationFails("jdk.internal.vm.FillerElement");
}
}

5 comments on commit 05745e3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@JesperIRL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag jdk-23+3

@openjdk
Copy link

@openjdk openjdk bot commented on 05745e3 Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperIRL The tag jdk-23+3 was successfully created.

@ChrisHegarty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on 05745e3 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHegarty the backport was successfully created on the branch backport-ChrisHegarty-05745e3f in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 05745e3f from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 21 Dec 2023 and was reviewed by Albert Mingkun Yang and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-ChrisHegarty-05745e3f:backport-ChrisHegarty-05745e3f
$ git checkout backport-ChrisHegarty-05745e3f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-ChrisHegarty-05745e3f

⚠️ @ChrisHegarty You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.