Skip to content

Commit 05f9509

Browse files
fthevenetmagicus
authored andcommitted
8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll
Reviewed-by: erikj, ihse
1 parent 701bc3b commit 05f9509

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

make/autoconf/jdk-version.m4

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,15 @@ AC_DEFUN_ONCE([JDKVER_SETUP_JDK_VERSION_NUMBERS],
110110
CHECK_VALUE: [UTIL_CHECK_STRING_NON_EMPTY_PRINTABLE])
111111
AC_SUBST(COMPANY_NAME)
112112
113+
# Set the JDK RC Company name
114+
# Otherwise uses the value set for "vendor-name".
115+
UTIL_ARG_WITH(NAME: jdk-rc-company-name, TYPE: string,
116+
DEFAULT: $COMPANY_NAME,
117+
DESC: [Set JDK RC company name. This is used for CompanyName properties of MS Windows binaries.],
118+
DEFAULT_DESC: [from branding.conf],
119+
CHECK_VALUE: [UTIL_CHECK_STRING_NON_EMPTY_PRINTABLE])
120+
AC_SUBST(JDK_RC_COMPANY_NAME)
121+
113122
# The vendor URL, if any
114123
# Only set VENDOR_URL if '--with-vendor-url' was used and is not empty.
115124
# Otherwise we will use the value from "branding.conf" included above.

make/autoconf/spec.gmk.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ PRODUCT_NAME := @PRODUCT_NAME@
191191
PRODUCT_SUFFIX := @PRODUCT_SUFFIX@
192192
JDK_RC_PLATFORM_NAME := @JDK_RC_PLATFORM_NAME@
193193
JDK_RC_NAME := @JDK_RC_NAME@
194+
JDK_RC_COMPANY_NAME:=@JDK_RC_COMPANY_NAME@
194195
COMPANY_NAME := @COMPANY_NAME@
195196
HOTSPOT_VM_DISTRO := @HOTSPOT_VM_DISTRO@
196197
MACOSX_BUNDLE_NAME_BASE := @MACOSX_BUNDLE_NAME_BASE@

make/common/JdkNativeCompilation.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ GLOBAL_VERSION_INFO_RESOURCE := $(TOPDIR)/src/java.base/windows/native/common/ve
9898

9999
JDK_RCFLAGS=$(RCFLAGS) \
100100
-D"JDK_VERSION_STRING=$(VERSION_STRING)" \
101-
-D"JDK_COMPANY=$(COMPANY_NAME)" \
101+
-D"JDK_COMPANY=$(JDK_RC_COMPANY_NAME)" \
102102
-D"JDK_VER=$(VERSION_NUMBER_FOUR_POSITIONS)" \
103103
-D"JDK_COPYRIGHT=Copyright \xA9 $(COPYRIGHT_YEAR)" \
104104
-D"JDK_NAME=$(JDK_RC_NAME) $(VERSION_SHORT)" \

0 commit comments

Comments
 (0)