Permalink
Show file tree
Hide file tree
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
8274548: (fc) FileChannel gathering write fails with IOException "Inv…
…alid argument" on macOS 11.6 Reviewed-by: alanb
- Loading branch information
Brian Burkhalter
committed
Oct 12, 2021
1 parent
f623460
commit 07b1f1c282ee0a7df6a6b0f240962a032ea3a413
Showing
4 changed files
with
172 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -0,0 +1,125 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8274548 | ||
* @summary Test gathering write of more than INT_MAX bytes | ||
* @library .. | ||
* @library /test/lib | ||
* @build jdk.test.lib.RandomFactory | ||
* @run main/othervm -Xmx4G LargeGatheringWrite | ||
* @key randomness | ||
*/ | ||
import java.io.IOException; | ||
import java.nio.ByteBuffer; | ||
import java.nio.channels.FileChannel; | ||
import java.nio.file.Files; | ||
import java.nio.file.Path; | ||
import java.util.Arrays; | ||
import java.util.Random; | ||
|
||
import jdk.test.lib.RandomFactory; | ||
|
||
import static java.nio.file.StandardOpenOption.CREATE; | ||
import static java.nio.file.StandardOpenOption.READ; | ||
import static java.nio.file.StandardOpenOption.WRITE; | ||
|
||
public class LargeGatheringWrite { | ||
private static final int GB = 1024*1024*1024; | ||
|
||
private static final Random RND = RandomFactory.getRandom(); | ||
|
||
public static void main(String[] args) throws IOException { | ||
// Create direct and heap buffers | ||
ByteBuffer direct = ByteBuffer.allocateDirect(GB); | ||
ByteBuffer heap = ByteBuffer.allocate(GB); | ||
|
||
// Load buffers with random values | ||
assert heap.hasArray(); | ||
RND.nextBytes(heap.array()); | ||
direct.put(0, heap, 0, heap.capacity()); | ||
|
||
// Create an array of buffers derived from direct and heap | ||
ByteBuffer[] bigBuffers = new ByteBuffer[] { | ||
direct, | ||
heap, | ||
direct.slice(0, GB/2), | ||
heap.slice(0, GB/2), | ||
direct.slice(GB/2, GB/2), | ||
heap.slice(GB/2, GB/2), | ||
direct.slice(GB/4, GB/2), | ||
heap.slice(GB/4, GB/2), | ||
direct.slice(0, 1), | ||
heap.slice(GB - 2, 1) | ||
}; | ||
|
||
// Calculate the sum of all buffer capacities | ||
long totalLength = 0L; | ||
for(ByteBuffer buf : bigBuffers) | ||
totalLength += buf.capacity(); | ||
|
||
// Write the data to a temporary file | ||
Path tempFile = Files.createTempFile("LargeGatheringWrite", ".dat"); | ||
|
||
System.out.printf("Writing %d bytes of data...%n", totalLength); | ||
try (FileChannel fcw = FileChannel.open(tempFile, CREATE, WRITE);) { | ||
// Print size of individual writes and total number written | ||
long bytesWritten = 0; | ||
long n; | ||
while ((n = fcw.write(bigBuffers)) > 0) { | ||
System.out.printf("Wrote %d bytes\n", n); | ||
bytesWritten += n; | ||
} | ||
System.out.printf("Total of %d bytes written\n", bytesWritten); | ||
|
||
// Verify the content written | ||
try (FileChannel fcr = FileChannel.open(tempFile, READ);) { | ||
byte[] bytes = null; | ||
for (ByteBuffer buf : bigBuffers) { | ||
// For each buffer read the corresponding number of bytes | ||
buf.rewind(); | ||
int length = buf.remaining(); | ||
System.out.printf("Checking length %d%n", length); | ||
if (bytes == null || bytes.length < length) | ||
bytes = new byte[length]; | ||
ByteBuffer dst = ByteBuffer.wrap(bytes).slice(0, length); | ||
if (dst.remaining() != length) | ||
throw new RuntimeException("remaining"); | ||
if (fcr.read(dst) != length) | ||
throw new RuntimeException("length"); | ||
dst.rewind(); | ||
|
||
// Verify that the bytes read from the file match the buffer | ||
int mismatch; | ||
if ((mismatch = dst.mismatch(buf)) != -1) { | ||
String msg = String.format("mismatch: %d%n", mismatch); | ||
throw new RuntimeException(msg); | ||
} | ||
} | ||
} | ||
} finally { | ||
Files.delete(tempFile); | ||
} | ||
} | ||
} |
07b1f1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues