Skip to content

Commit 096e9e5

Browse files
committed
8266318: Switch to macos prefix for macOS bundles
Reviewed-by: prr, erikj, iris
1 parent 0544a73 commit 096e9e5

File tree

3 files changed

+17
-19
lines changed

3 files changed

+17
-19
lines changed

.github/workflows/submit.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1361,8 +1361,8 @@ jobs:
13611361
with:
13621362
name: transient_jdk-macos-x64${{ matrix.artifact }}_${{ needs.prerequisites.outputs.bundle_id }}
13631363
path: |
1364-
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}.tar.gz
1365-
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}.tar.gz
1364+
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}.tar.gz
1365+
jdk/build/macos-x64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}.tar.gz
13661366
13671367
macos_aarch64_build:
13681368
name: macOS aarch64
@@ -1464,8 +1464,8 @@ jobs:
14641464
with:
14651465
name: transient_jdk-macos-aarch64${{ matrix.artifact }}_${{ needs.prerequisites.outputs.bundle_id }}
14661466
path: |
1467-
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-aarch64_bin${{ matrix.artifact }}.tar.gz
1468-
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_osx-aarch64_bin-tests${{ matrix.artifact }}.tar.gz
1467+
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-aarch64_bin${{ matrix.artifact }}.tar.gz
1468+
jdk/build/macos-aarch64/bundles/jdk-${{ env.JDK_VERSION }}-internal+0_macos-aarch64_bin-tests${{ matrix.artifact }}.tar.gz
14691469
14701470
14711471
macos_x64_test:
@@ -1572,13 +1572,13 @@ jobs:
15721572

15731573
- name: Unpack jdk
15741574
run: |
1575-
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}"
1576-
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }}"
1575+
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}"
1576+
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }}"
15771577
15781578
- name: Unpack tests
15791579
run: |
1580-
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}"
1581-
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}"
1580+
mkdir -p "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}"
1581+
tar -xf "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}.tar.gz" -C "${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}"
15821582
15831583
- name: Install dependencies
15841584
run: brew install make
@@ -1588,13 +1588,13 @@ jobs:
15881588

15891589
- name: Find root of jdk image dir
15901590
run: |
1591-
imageroot=`find ${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin${{ matrix.artifact }} -name release -type f`
1591+
imageroot=`find ${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin${{ matrix.artifact }} -name release -type f`
15921592
echo "imageroot=`dirname ${imageroot}`" >> $GITHUB_ENV
15931593
15941594
- name: Run tests
15951595
run: >
15961596
JDK_IMAGE_DIR=${{ env.imageroot }}
1597-
TEST_IMAGE_DIR=${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_osx-x64_bin-tests${{ matrix.artifact }}
1597+
TEST_IMAGE_DIR=${HOME}/jdk-macos-x64${{ matrix.artifact }}/jdk-${{ env.JDK_VERSION }}-internal+0_macos-x64_bin-tests${{ matrix.artifact }}
15981598
BOOT_JDK=${HOME}/bootjdk/${BOOT_JDK_VERSION}/Contents/Home
15991599
JT_HOME=${HOME}/jtreg
16001600
gmake test-prebuilt

make/autoconf/platform.m4

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2011, 2021, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -480,9 +480,11 @@ AC_DEFUN([PLATFORM_SETUP_LEGACY_VARS_HELPER],
480480
fi
481481
482482
# The new version string in JDK 9 also defined new naming of OS and ARCH for bundles
483-
# Macosx is osx and x86_64 is x64
483+
# The macOS bundle name was revised in JDK 17
484+
#
485+
# macosx is macos and x86_64 is x64
484486
if test "x$OPENJDK_$1_OS" = xmacosx; then
485-
OPENJDK_$1_OS_BUNDLE="osx"
487+
OPENJDK_$1_OS_BUNDLE="macos"
486488
else
487489
OPENJDK_$1_OS_BUNDLE="$OPENJDK_TARGET_OS"
488490
fi

make/conf/jib-profiles.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -672,11 +672,7 @@ var getJibProfilesProfiles = function (input, common, data) {
672672
["--with-jcov-input-jdk=" + input.get(name + ".jdk", "home_path")]);
673673
});
674674

675-
//
676675
// Define artifacts for profiles
677-
//
678-
// Macosx bundles are named osx
679-
// tar.gz.
680676
var artifactData = {
681677
"linux-x64": {
682678
platform: "linux-x64",
@@ -685,11 +681,11 @@ var getJibProfilesProfiles = function (input, common, data) {
685681
platform: "linux-x86",
686682
},
687683
"macosx-x64": {
688-
platform: "osx-x64",
684+
platform: "macos-x64",
689685
jdk_subdir: "jdk-" + data.version + ".jdk/Contents/Home",
690686
},
691687
"macosx-aarch64": {
692-
platform: "osx-aarch64",
688+
platform: "macos-aarch64",
693689
jdk_subdir: "jdk-" + data.version + ".jdk/Contents/Home",
694690
},
695691
"windows-x64": {

0 commit comments

Comments
 (0)