From 73f5415363232804bd1904c1a80b0a724eabe63f Mon Sep 17 00:00:00 2001 From: Chris Hegarty Date: Sat, 2 Jan 2021 19:29:50 +0000 Subject: [PATCH 001/129] 8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size Reviewed-by: alanb --- .../java/nio/Direct-X-Buffer.java.template | 5 +-- test/jdk/java/nio/Buffer/ByteBufferViews.java | 34 +++++++++++++++++-- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template b/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template index 81a40c8bd404f..f3e1c8b224889 100644 --- a/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template +++ b/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -237,7 +237,8 @@ class Direct$Type$Buffer$RW$$BO$ 0, length, length, - index, segment); + index << $LG_BYTES_PER_VALUE$, + segment); } public $Type$Buffer duplicate() { diff --git a/test/jdk/java/nio/Buffer/ByteBufferViews.java b/test/jdk/java/nio/Buffer/ByteBufferViews.java index 18a3ac55c86f3..f0136939d53f5 100644 --- a/test/jdk/java/nio/Buffer/ByteBufferViews.java +++ b/test/jdk/java/nio/Buffer/ByteBufferViews.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,7 +23,7 @@ /* @test * @summary Binary data and view tests for byte buffers - * @bug 8159257 + * @bug 8159257 8258955 * @run testng ByteBufferViews */ @@ -174,6 +174,11 @@ public static Object[][] shortViewProvider() { bb -> bb.asShortBuffer()), Map.entry("bb.asShortBuffer().slice()", bb -> bb.asShortBuffer().slice()), + Map.entry("bb.asShortBuffer().slice(index,length)", + bb -> { var sb = bb.asShortBuffer(); + sb = sb.slice(1, sb.limit() - 1); + bb.position(bb.position() + 2); + return sb; }), Map.entry("bb.asShortBuffer().slice().duplicate()", bb -> bb.asShortBuffer().slice().duplicate()) ); @@ -273,6 +278,11 @@ public static Object[][] charViewProvider() { bb -> bb.asCharBuffer()), Map.entry("bb.asCharBuffer().slice()", bb -> bb.asCharBuffer().slice()), + Map.entry("bb.asCharBuffer().slice(index,length)", + bb -> { var cb = bb.asCharBuffer(); + cb = cb.slice(1, cb.limit() - 1); + bb.position(bb.position() + 2); + return cb; }), Map.entry("bb.asCharBuffer().slice().duplicate()", bb -> bb.asCharBuffer().slice().duplicate()) ); @@ -365,6 +375,11 @@ public static Object[][] intViewProvider() { bb -> bb.asIntBuffer()), Map.entry("bb.asIntBuffer().slice()", bb -> bb.asIntBuffer().slice()), + Map.entry("bb.asIntBuffer().slice(index,length)", + bb -> { var ib = bb.asIntBuffer(); + ib = ib.slice(1, ib.limit() - 1); + bb.position(bb.position() + 4); + return ib; }), Map.entry("bb.asIntBuffer().slice().duplicate()", bb -> bb.asIntBuffer().slice().duplicate()) ); @@ -467,6 +482,11 @@ public static Object[][] longViewProvider() { bb -> bb.asLongBuffer()), Map.entry("bb.asLongBuffer().slice()", bb -> bb.asLongBuffer().slice()), + Map.entry("bb.asLongBuffer().slice(index,length)", + bb -> { var lb = bb.asLongBuffer(); + lb = lb.slice(1, lb.limit() - 1); + bb.position(bb.position() + 8); + return lb; }), Map.entry("bb.asLongBuffer().slice().duplicate()", bb -> bb.asLongBuffer().slice().duplicate()) ); @@ -575,6 +595,11 @@ public static Object[][] floatViewProvider() { bb -> bb.asFloatBuffer()), Map.entry("bb.asFloatBuffer().slice()", bb -> bb.asFloatBuffer().slice()), + Map.entry("bb.asFloatBuffer().slice(index,length)", + bb -> { var fb = bb.asFloatBuffer(); + fb = fb.slice(1, fb.limit() - 1); + bb.position(bb.position() + 4); + return fb; }), Map.entry("bb.asFloatBuffer().slice().duplicate()", bb -> bb.asFloatBuffer().slice().duplicate()) ); @@ -668,6 +693,11 @@ public static Object[][] doubleViewProvider() { bb -> bb.asDoubleBuffer()), Map.entry("bb.asDoubleBuffer().slice()", bb -> bb.asDoubleBuffer().slice()), + Map.entry("bb.asDoubleBuffer().slice(index,length)", + bb -> { var db = bb.asDoubleBuffer(); + db = db.slice(1, db.limit() - 1); + bb.position(bb.position() + 8); + return db; }), Map.entry("bb.asDoubleBuffer().slice().duplicate()", bb -> bb.asDoubleBuffer().slice().duplicate()) ); From 7f04d23be4273f32f40672e9f9f9c1c5d4ac02cf Mon Sep 17 00:00:00 2001 From: Coleen Phillimore Date: Mon, 4 Jan 2021 16:44:39 +0000 Subject: [PATCH 002/129] 8258800: Deprecate -XX:+AlwaysLockClassLoader Reviewed-by: hseigel --- src/hotspot/share/runtime/arguments.cpp | 3 ++- src/hotspot/share/runtime/globals.hpp | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp index 5b262f6cffff4..dbf730a493a84 100644 --- a/src/hotspot/share/runtime/arguments.cpp +++ b/src/hotspot/share/runtime/arguments.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -521,6 +521,7 @@ static SpecialFlag const special_jvm_flags[] = { { "AllowRedefinitionToAddDeleteMethods", JDK_Version::jdk(13), JDK_Version::undefined(), JDK_Version::undefined() }, { "FlightRecorder", JDK_Version::jdk(13), JDK_Version::undefined(), JDK_Version::undefined() }, { "CriticalJNINatives", JDK_Version::jdk(16), JDK_Version::jdk(17), JDK_Version::jdk(18) }, + { "AlwaysLockClassLoader", JDK_Version::jdk(17), JDK_Version::jdk(18), JDK_Version::jdk(19) }, { "UseBiasedLocking", JDK_Version::jdk(15), JDK_Version::jdk(18), JDK_Version::jdk(19) }, { "BiasedLockingStartupDelay", JDK_Version::jdk(15), JDK_Version::jdk(18), JDK_Version::jdk(19) }, { "PrintBiasedLockingStatistics", JDK_Version::jdk(15), JDK_Version::jdk(18), JDK_Version::jdk(19) }, diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp index ab324da78dd62..2c3a4f25db5bd 100644 --- a/src/hotspot/share/runtime/globals.hpp +++ b/src/hotspot/share/runtime/globals.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -707,8 +707,8 @@ const intx ObjectAlignmentInBytes = 8; "Dynamically resize system dictionaries as needed") \ \ product(bool, AlwaysLockClassLoader, false, \ - "Require the VM to acquire the class loader lock before calling " \ - "loadClass() even for class loaders registering " \ + "(Deprecated) Require the VM to acquire the class loader lock " \ + "before calling loadClass() even for class loaders registering " \ "as parallel capable") \ \ product(bool, AllowParallelDefineClass, false, \ From f80c63b38035f6b6969cca08cfc534d0476105af Mon Sep 17 00:00:00 2001 From: Zhengyu Gu Date: Mon, 4 Jan 2021 18:10:36 +0000 Subject: [PATCH 003/129] 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers Reviewed-by: shade --- .../shenandoah/shenandoahConcurrentMark.cpp | 52 +++++++++++-------- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp b/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp index 7000cdc8ef194..f19f9e7f0636c 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp @@ -225,6 +225,18 @@ void ShenandoahProcessConcurrentRootsTask::work(uint worker_id) { _rs.oops_do(&cl, worker_id); } +class ShenandoahClaimThreadClosure : public ThreadClosure { +private: + const uintx _claim_token; +public: + ShenandoahClaimThreadClosure() : + _claim_token(Threads::thread_claim_token()) {} + + virtual void do_thread(Thread* thread) { + thread->claim_threads_do(false /*is_par*/, _claim_token); + } +}; + class ShenandoahFinalMarkingTask : public AbstractGangTask { private: ShenandoahConcurrentMark* _cm; @@ -234,6 +246,13 @@ class ShenandoahFinalMarkingTask : public AbstractGangTask { public: ShenandoahFinalMarkingTask(ShenandoahConcurrentMark* cm, TaskTerminator* terminator, bool dedup_string) : AbstractGangTask("Shenandoah Final Mark"), _cm(cm), _terminator(terminator), _dedup_string(dedup_string) { + + // Full GC does not need to remark threads and drain SATB buffers, but we need to claim the + // threads - it requires a StrongRootsScope around the task. + if (ShenandoahHeap::heap()->is_full_gc_in_progress()) { + ShenandoahClaimThreadClosure tc; + Threads::threads_do(&tc); + } } void work(uint worker_id) { @@ -242,33 +261,20 @@ class ShenandoahFinalMarkingTask : public AbstractGangTask { ShenandoahParallelWorkerSession worker_session(worker_id); ShenandoahReferenceProcessor* rp = heap->ref_processor(); - // First drain remaining SATB buffers. - // Notice that this is not strictly necessary for mark-compact. But since - // it requires a StrongRootsScope around the task, we need to claim the - // threads, and performance-wise it doesn't really matter. Adds about 1ms to - // full-gc. - { + if (!heap->is_full_gc_in_progress()) { ShenandoahObjToScanQueue* q = _cm->get_queue(worker_id); - ShenandoahSATBBufferClosure cl(q); SATBMarkQueueSet& satb_mq_set = ShenandoahBarrierSet::satb_mark_queue_set(); - while (satb_mq_set.apply_closure_to_completed_buffer(&cl)); + while (satb_mq_set.apply_closure_to_completed_buffer(&cl)) {} + + assert(!heap->has_forwarded_objects(), "Not expected"); bool do_nmethods = heap->unload_classes() && !ShenandoahConcurrentRoots::can_do_concurrent_class_unloading(); - if (heap->has_forwarded_objects()) { - ShenandoahMarkResolveRefsClosure resolve_mark_cl(q, rp); - MarkingCodeBlobClosure blobsCl(&resolve_mark_cl, !CodeBlobToOopClosure::FixRelocations); - ShenandoahSATBAndRemarkCodeRootsThreadsClosure tc(&cl, - ShenandoahStoreValEnqueueBarrier ? &resolve_mark_cl : NULL, - do_nmethods ? &blobsCl : NULL); - Threads::threads_do(&tc); - } else { - ShenandoahMarkRefsClosure mark_cl(q, rp); - MarkingCodeBlobClosure blobsCl(&mark_cl, !CodeBlobToOopClosure::FixRelocations); - ShenandoahSATBAndRemarkCodeRootsThreadsClosure tc(&cl, - ShenandoahStoreValEnqueueBarrier ? &mark_cl : NULL, - do_nmethods ? &blobsCl : NULL); - Threads::threads_do(&tc); - } + ShenandoahMarkRefsClosure mark_cl(q, rp); + MarkingCodeBlobClosure blobsCl(&mark_cl, !CodeBlobToOopClosure::FixRelocations); + ShenandoahSATBAndRemarkCodeRootsThreadsClosure tc(&cl, + ShenandoahStoreValEnqueueBarrier ? &mark_cl : NULL, + do_nmethods ? &blobsCl : NULL); + Threads::threads_do(&tc); } _cm->mark_loop(worker_id, _terminator, rp, From 9d160aa1b7ca0260a6e42c554b3afb1e34513c96 Mon Sep 17 00:00:00 2001 From: Claes Redestad Date: Mon, 4 Jan 2021 21:01:25 +0000 Subject: [PATCH 004/129] 8257815: Replace global log2 functions with efficient implementations Reviewed-by: kbarrett, stefank --- .../cpu/aarch64/c1_LIRAssembler_aarch64.cpp | 2 +- .../cpu/aarch64/gc/z/zGlobals_aarch64.cpp | 2 +- .../cpu/aarch64/macroAssembler_aarch64.cpp | 4 +- src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp | 2 +- src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp | 4 +- src/hotspot/cpu/ppc/assembler_ppc.cpp | 6 +- src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp | 2 +- src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp | 4 +- .../cpu/ppc/macroAssembler_ppc.inline.hpp | 2 +- src/hotspot/cpu/ppc/ppc.ad | 39 ++++++------ src/hotspot/cpu/ppc/templateTable_ppc_64.cpp | 6 +- src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp | 4 +- src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp | 4 +- src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp | 2 +- src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp | 4 +- src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp | 2 +- src/hotspot/cpu/x86/interp_masm_x86.cpp | 2 +- src/hotspot/cpu/x86/vm_version_x86.cpp | 2 +- src/hotspot/cpu/x86/x86_64.ad | 8 +-- .../share/compiler/compilationPolicy.cpp | 2 +- .../share/compiler/compilerDefinitions.cpp | 9 +-- .../share/compiler/tieredThresholdPolicy.cpp | 4 +- src/hotspot/share/gc/g1/g1BiasedArray.hpp | 2 +- src/hotspot/share/gc/g1/g1FreeIdSet.cpp | 3 +- src/hotspot/share/gc/g1/g1RemSet.cpp | 5 +- src/hotspot/share/gc/g1/heapRegion.cpp | 4 +- src/hotspot/share/gc/g1/heapRegionRemSet.cpp | 3 +- .../gc/shared/partialArrayTaskStepper.cpp | 3 +- .../shenandoahConcurrentMark.inline.hpp | 3 +- .../gc/shenandoah/shenandoahHeapRegion.cpp | 3 +- .../gc/shenandoah/shenandoahNumberSeq.cpp | 2 +- src/hotspot/share/gc/z/zHeuristics.cpp | 2 +- src/hotspot/share/opto/divnode.cpp | 16 ++--- src/hotspot/share/opto/mulnode.cpp | 32 +++++----- src/hotspot/share/opto/parse2.cpp | 2 +- src/hotspot/share/opto/vectorIntrinsics.cpp | 2 +- .../share/utilities/globalDefinitions.hpp | 53 ----------------- src/hotspot/share/utilities/hashtable.cpp | 3 +- src/hotspot/share/utilities/powerOfTwo.hpp | 59 +++++++++++++------ .../utilities/test_globalDefinitions.cpp | 35 ----------- .../gtest/utilities/test_powerOfTwo.cpp | 42 +++++++++++++ 41 files changed, 182 insertions(+), 208 deletions(-) diff --git a/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp index 550f7f18a06f5..19d20dde9a449 100644 --- a/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp @@ -1772,7 +1772,7 @@ void LIR_Assembler::arith_op(LIR_Code code, LIR_Opr left, LIR_Opr right, LIR_Opr // move lreg_lo to dreg if divisor is 1 __ mov(dreg, lreg_lo); } else { - unsigned int shift = exact_log2_long(c); + unsigned int shift = log2i_exact(c); // use rscratch1 as intermediate result register __ asr(rscratch1, lreg_lo, 63); __ add(rscratch1, lreg_lo, rscratch1, Assembler::LSR, 64 - shift); diff --git a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp index e579594ae33e1..d887717913836 100644 --- a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp @@ -200,7 +200,7 @@ size_t ZPlatformAddressOffsetBits() { const size_t max_address_offset_bits = valid_max_address_offset_bits - 3; const size_t min_address_offset_bits = max_address_offset_bits - 2; const size_t address_offset = round_up_power_of_2(MaxHeapSize * ZVirtualToPhysicalRatio); - const size_t address_offset_bits = log2_intptr(address_offset); + const size_t address_offset_bits = log2i_exact(address_offset); return clamp(address_offset_bits, min_address_offset_bits, max_address_offset_bits); } diff --git a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp index 31435b1b50f1b..7de5f870f51ba 100644 --- a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp @@ -302,7 +302,7 @@ void MacroAssembler::safepoint_poll(Label& slow_path, bool at_return, bool acqui cmp(in_nmethod ? sp : rfp, rscratch1); br(Assembler::HI, slow_path); } else { - tbnz(rscratch1, exact_log2(SafepointMechanism::poll_bit()), slow_path); + tbnz(rscratch1, log2i_exact(SafepointMechanism::poll_bit()), slow_path); } } @@ -3996,7 +3996,7 @@ MacroAssembler::KlassDecodeMode MacroAssembler::klass_decode_mode() { if (operand_valid_for_logical_immediate( /*is32*/false, (uint64_t)CompressedKlassPointers::base())) { const uint64_t range_mask = - (1ULL << log2_intptr(CompressedKlassPointers::range())) - 1; + (1ULL << log2i(CompressedKlassPointers::range())) - 1; if (((uint64_t)CompressedKlassPointers::base() & range_mask) == 0) { return (_klass_decode_mode = KlassDecodeXor); } diff --git a/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp b/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp index f2b64263aa107..9026cf4256dc3 100644 --- a/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp +++ b/src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp @@ -848,7 +848,7 @@ void LIR_Assembler::emit_op3(LIR_Op3* op) { __ add_32(dest, left, AsmOperand(left, lsr, 31)); __ asr_32(dest, dest, 1); } else if (c != (int) 0x80000000) { - int power = log2_intptr(c); + int power = log2i_exact(c); __ asr_32(Rtemp, left, 31); __ add_32(dest, left, AsmOperand(Rtemp, lsr, 32-power)); // dest = left + (left < 0 ? 2^power - 1 : 0); __ asr_32(dest, dest, power); // dest = dest >>> power; diff --git a/src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp b/src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp index 9932e3a44e54b..5cba07805b9bf 100644 --- a/src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp +++ b/src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp @@ -329,12 +329,12 @@ void LIRGenerator::cmp_reg_mem(LIR_Condition condition, LIR_Opr reg, LIR_Opr bas bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result, LIR_Opr tmp) { assert(left != result, "should be different registers"); if (is_power_of_2(c + 1)) { - LIR_Address::Scale scale = (LIR_Address::Scale) log2_intptr(c + 1); + LIR_Address::Scale scale = (LIR_Address::Scale) log2i_exact(c + 1); LIR_Address* addr = new LIR_Address(left, left, scale, 0, T_INT); __ sub(LIR_OprFact::address(addr), left, result); // rsb with shifted register return true; } else if (is_power_of_2(c - 1)) { - LIR_Address::Scale scale = (LIR_Address::Scale) log2_intptr(c - 1); + LIR_Address::Scale scale = (LIR_Address::Scale) log2i_exact(c - 1); LIR_Address* addr = new LIR_Address(left, left, scale, 0, T_INT); __ add(left, LIR_OprFact::address(addr), result); // add with shifted register return true; diff --git a/src/hotspot/cpu/ppc/assembler_ppc.cpp b/src/hotspot/cpu/ppc/assembler_ppc.cpp index 105790c604722..6a6be870991b8 100644 --- a/src/hotspot/cpu/ppc/assembler_ppc.cpp +++ b/src/hotspot/cpu/ppc/assembler_ppc.cpp @@ -81,13 +81,13 @@ int Assembler::branch_destination(int inst, int pos) { void Assembler::andi(Register a, Register s, const long ui16) { if (is_power_of_2(((jlong) ui16)+1)) { // pow2minus1 - clrldi(a, s, 64-log2_long((((jlong) ui16)+1))); + clrldi(a, s, 64 - log2i_exact((((jlong) ui16)+1))); } else if (is_power_of_2((jlong) ui16)) { // pow2 - rlwinm(a, s, 0, 31-log2_long((jlong) ui16), 31-log2_long((jlong) ui16)); + rlwinm(a, s, 0, 31 - log2i_exact((jlong) ui16), 31 - log2i_exact((jlong) ui16)); } else if (is_power_of_2((jlong)-ui16)) { // negpow2 - clrrdi(a, s, log2_long((jlong)-ui16)); + clrrdi(a, s, log2i_exact((jlong)-ui16)); } else { assert(is_uimm(ui16, 16), "must be 16-bit unsigned immediate"); andi_(a, s, ui16); diff --git a/src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp b/src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp index 6b28ba99d65f1..af014b6a023ef 100644 --- a/src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp +++ b/src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp @@ -341,7 +341,7 @@ void LIR_Assembler::arithmetic_idiv(LIR_Code code, LIR_Opr left, LIR_Opr right, } else if (is_power_of_2(divisor)) { // Convert division by a power of two into some shifts and logical operations. - int log2 = log2_intptr(divisor); + int log2 = log2i_exact(divisor); // Round towards 0. if (divisor == 2) { diff --git a/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp b/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp index 8ed404b9e3ba8..9a4dc0a32c273 100644 --- a/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp +++ b/src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp @@ -293,11 +293,11 @@ void LIRGenerator::cmp_reg_mem(LIR_Condition condition, LIR_Opr reg, LIR_Opr bas bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result, LIR_Opr tmp) { assert(left != result, "should be different registers"); if (is_power_of_2(c + 1)) { - __ shift_left(left, log2_int(c + 1), result); + __ shift_left(left, log2i_exact(c + 1), result); __ sub(result, left, result); return true; } else if (is_power_of_2(c - 1)) { - __ shift_left(left, log2_int(c - 1), result); + __ shift_left(left, log2i_exact(c - 1), result); __ add(result, left, result); return true; } diff --git a/src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp b/src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp index eaa7aa0fcb2bd..c16741e1bd562 100644 --- a/src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp +++ b/src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp @@ -59,7 +59,7 @@ inline int MacroAssembler::get_ld_largeoffset_offset(address a) { inline void MacroAssembler::round_to(Register r, int modulus) { assert(is_power_of_2((jlong)modulus), "must be power of 2"); addi(r, r, modulus-1); - clrrdi(r, r, log2_long((jlong)modulus)); + clrrdi(r, r, log2i_exact((jlong)modulus)); } // Move register if destination register and target register are different. diff --git a/src/hotspot/cpu/ppc/ppc.ad b/src/hotspot/cpu/ppc/ppc.ad index 8f6fc83b594f2..028e7c702c635 100644 --- a/src/hotspot/cpu/ppc/ppc.ad +++ b/src/hotspot/cpu/ppc/ppc.ad @@ -4042,7 +4042,7 @@ operand immIhi16() %{ %} operand immInegpow2() %{ - predicate(is_power_of_2((jlong) (julong) (juint) (-(n->get_int())))); + predicate(is_power_of_2(-(juint)(n->get_int()))); match(ConI); op_cost(0); format %{ %} @@ -4050,7 +4050,7 @@ operand immInegpow2() %{ %} operand immIpow2minus1() %{ - predicate(is_power_of_2((((jlong) (n->get_int()))+1))); + predicate(is_power_of_2((juint)(n->get_int()) + 1u)); match(ConI); op_cost(0); format %{ %} @@ -4058,7 +4058,7 @@ operand immIpow2minus1() %{ %} operand immIpowerOf2() %{ - predicate(is_power_of_2((((jlong) (julong) (juint) (n->get_int()))))); + predicate(is_power_of_2((juint)(n->get_int()))); match(ConI); op_cost(0); format %{ %} @@ -4292,7 +4292,7 @@ operand immLhighest16() %{ %} operand immLnegpow2() %{ - predicate(is_power_of_2((jlong)-(n->get_long()))); + predicate(is_power_of_2(-(julong)(n->get_long()))); match(ConL); op_cost(0); format %{ %} @@ -4300,8 +4300,7 @@ operand immLnegpow2() %{ %} operand immLpow2minus1() %{ - predicate(is_power_of_2((((jlong) (n->get_long()))+1)) && - (n->get_long() != (jlong)0xffffffffffffffffL)); + predicate(is_power_of_2((julong)(n->get_long()) + 1ull)); match(ConL); op_cost(0); format %{ %} @@ -9076,9 +9075,8 @@ instruct lShiftI_andI_immInegpow2_imm5(iRegIdst dst, iRegIsrc src1, immInegpow2 format %{ "RLWINM $dst, lShiftI(AndI($src1, $src2), $src3)" %} size(4); ins_encode %{ - long src2 = $src2$$constant; long src3 = $src3$$constant; - long maskbits = src3 + log2_long((jlong) (julong) (juint) -src2); + long maskbits = src3 + log2i_exact(-(juint)$src2$$constant); if (maskbits >= 32) { __ li($dst$$Register, 0); // addi } else { @@ -9096,9 +9094,8 @@ instruct lShiftI_andI_immInegpow2_rShiftI_imm5(iRegIdst dst, iRegIsrc src1, immI format %{ "RLWINM $dst, lShiftI(AndI(RShiftI($src1, $src3), $src2), $src3)" %} size(4); ins_encode %{ - long src2 = $src2$$constant; long src3 = $src3$$constant; - long maskbits = src3 + log2_long((jlong) (julong) (juint) -src2); + long maskbits = src3 + log2i_exact(-(juint)$src2$$constant); if (maskbits >= 32) { __ li($dst$$Register, 0); // addi } else { @@ -9366,7 +9363,7 @@ instruct andI_urShiftI_regI_immI_immIpow2minus1(iRegIdst dst, iRegIsrc src1, imm size(4); ins_encode %{ int rshift = ($src2$$constant) & 0x1f; - int length = log2_long(((jlong) $src3$$constant) + 1); + int length = log2i_exact((juint)$src3$$constant + 1u); if (rshift + length > 32) { // if necessary, adjust mask to omit rotated bits. length = 32 - rshift; @@ -9384,7 +9381,7 @@ instruct andL_urShiftL_regL_immI_immLpow2minus1(iRegLdst dst, iRegLsrc src1, imm size(4); ins_encode %{ int rshift = ($src2$$constant) & 0x3f; - int length = log2_long(((jlong) $src3$$constant) + 1); + int length = log2i_exact((julong)$src3$$constant + 1ull); if (rshift + length > 64) { // if necessary, adjust mask to omit rotated bits. length = 64 - rshift; @@ -9788,7 +9785,7 @@ instruct andI_reg_immInegpow2(iRegIdst dst, iRegIsrc src1, immInegpow2 src2) %{ format %{ "ANDWI $dst, $src1, $src2" %} size(4); ins_encode %{ - __ clrrdi($dst$$Register, $src1$$Register, log2_long((jlong)(julong)(juint)-($src2$$constant))); + __ clrrdi($dst$$Register, $src1$$Register, log2i_exact(-(juint)$src2$$constant)); %} ins_pipe(pipe_class_default); %} @@ -9798,7 +9795,7 @@ instruct andI_reg_immIpow2minus1(iRegIdst dst, iRegIsrc src1, immIpow2minus1 src format %{ "ANDWI $dst, $src1, $src2" %} size(4); ins_encode %{ - __ clrldi($dst$$Register, $src1$$Register, 64-log2_long((((jlong) $src2$$constant)+1))); + __ clrldi($dst$$Register, $src1$$Register, 64 - log2i_exact((juint)$src2$$constant + 1u)); %} ins_pipe(pipe_class_default); %} @@ -9809,8 +9806,8 @@ instruct andI_reg_immIpowerOf2(iRegIdst dst, iRegIsrc src1, immIpowerOf2 src2) % format %{ "ANDWI $dst, $src1, $src2" %} size(4); ins_encode %{ - __ rlwinm($dst$$Register, $src1$$Register, 0, - (31-log2_long((jlong) $src2$$constant)) & 0x1f, (31-log2_long((jlong) $src2$$constant)) & 0x1f); + int bitpos = 31 - log2i_exact((juint)$src2$$constant); + __ rlwinm($dst$$Register, $src1$$Register, 0, bitpos, bitpos); %} ins_pipe(pipe_class_default); %} @@ -9848,7 +9845,7 @@ instruct andL_reg_immLnegpow2(iRegLdst dst, iRegLsrc src1, immLnegpow2 src2) %{ format %{ "ANDDI $dst, $src1, $src2" %} size(4); ins_encode %{ - __ clrrdi($dst$$Register, $src1$$Register, log2_long((jlong)-$src2$$constant)); + __ clrrdi($dst$$Register, $src1$$Register, log2i_exact(-(julong)$src2$$constant)); %} ins_pipe(pipe_class_default); %} @@ -9858,7 +9855,7 @@ instruct andL_reg_immLpow2minus1(iRegLdst dst, iRegLsrc src1, immLpow2minus1 src format %{ "ANDDI $dst, $src1, $src2" %} size(4); ins_encode %{ - __ clrldi($dst$$Register, $src1$$Register, 64-log2_long((((jlong) $src2$$constant)+1))); + __ clrldi($dst$$Register, $src1$$Register, 64 - log2i_exact((julong)$src2$$constant + 1ull)); %} ins_pipe(pipe_class_default); %} @@ -9871,7 +9868,7 @@ instruct convL2I_andL_reg_immLpow2minus1(iRegIdst dst, iRegLsrc src1, immLpow2mi format %{ "ANDDI $dst, $src1, $src2 \t// long + l2i" %} size(4); ins_encode %{ - __ clrldi($dst$$Register, $src1$$Register, 64-log2_long((((jlong) $src2$$constant)+1))); + __ clrldi($dst$$Register, $src1$$Register, 64 - log2i_exact((julong)$src2$$constant + 1ull)); %} ins_pipe(pipe_class_default); %} @@ -10459,7 +10456,7 @@ instruct convI2Bool_andI_reg_immIpowerOf2(iRegIdst dst, iRegIsrc src, immIpowerO format %{ "RLWINM $dst, $src, $mask \t// convI2B(AndI($src, $mask))" %} size(4); ins_encode %{ - __ rlwinm($dst$$Register, $src$$Register, (32-log2_long((jlong)$mask$$constant)) & 0x1f, 31, 31); + __ rlwinm($dst$$Register, $src$$Register, 32 - log2i_exact((juint)($mask$$constant)), 31, 31); %} ins_pipe(pipe_class_default); %} @@ -12154,7 +12151,7 @@ instruct align_addr(iRegPdst dst, iRegPsrc src, immLnegpow2 mask) %{ format %{ "ANDDI $dst, $src, $mask \t// next aligned address" %} size(4); ins_encode %{ - __ clrrdi($dst$$Register, $src$$Register, log2_long((jlong)-$mask$$constant)); + __ clrrdi($dst$$Register, $src$$Register, log2i_exact(-(julong)$mask$$constant)); %} ins_pipe(pipe_class_default); %} diff --git a/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp b/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp index 97794d85dc233..0e2e1c29135d7 100644 --- a/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp +++ b/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp @@ -1897,7 +1897,7 @@ void TemplateTable::tableswitch() { // Align bcp. __ addi(Rdef_offset_addr, R14_bcp, BytesPerInt); - __ clrrdi(Rdef_offset_addr, Rdef_offset_addr, log2_long((jlong)BytesPerInt)); + __ clrrdi(Rdef_offset_addr, Rdef_offset_addr, LogBytesPerInt); // Load lo & hi. __ get_u4(Rlow_byte, Rdef_offset_addr, BytesPerInt, InterpreterMacroAssembler::Unsigned); @@ -1956,7 +1956,7 @@ void TemplateTable::fast_linearswitch() { // Align bcp. __ addi(Rdef_offset_addr, R14_bcp, BytesPerInt); - __ clrrdi(Rdef_offset_addr, Rdef_offset_addr, log2_long((jlong)BytesPerInt)); + __ clrrdi(Rdef_offset_addr, Rdef_offset_addr, LogBytesPerInt); // Setup loop counter and limit. __ get_u4(Rcount, Rdef_offset_addr, BytesPerInt, InterpreterMacroAssembler::Unsigned); @@ -2044,7 +2044,7 @@ void TemplateTable::fast_binaryswitch() { // Find Array start, __ addi(Rarray, R14_bcp, 3 * BytesPerInt); - __ clrrdi(Rarray, Rarray, log2_long((jlong)BytesPerInt)); + __ clrrdi(Rarray, Rarray, LogBytesPerInt); // initialize i & j __ li(Ri,0); diff --git a/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp b/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp index fb99fca8cf267..70c92551f6262 100644 --- a/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp +++ b/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp @@ -1802,7 +1802,7 @@ void LIR_Assembler::arithmetic_idiv(LIR_Code code, LIR_Opr left, LIR_Opr right, Register treg1 = Z_R0_scratch; Register treg2 = Z_R1_scratch; jlong divisor = right->as_jlong(); - jlong log_divisor = log2_long(right->as_jlong()); + jlong log_divisor = log2i_exact(right->as_jlong()); if (divisor == min_jlong) { // Min_jlong is special. Result is '0' except for min_jlong/min_jlong = 1. @@ -1890,7 +1890,7 @@ void LIR_Assembler::arithmetic_idiv(LIR_Code code, LIR_Opr left, LIR_Opr right, Register treg1 = Z_R0_scratch; Register treg2 = Z_R1_scratch; jlong divisor = right->as_jint(); - jlong log_divisor = log2_long(right->as_jint()); + jlong log_divisor = log2i_exact(right->as_jint()); __ move_reg_if_needed(dreg, T_LONG, lreg, T_INT); // sign extend if (divisor == 2) { __ z_srlg(treg2, dreg, 63); // dividend < 0 ? 1 : 0 diff --git a/src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp b/src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp index 7224426d56e56..ff4fd48672b1d 100644 --- a/src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp +++ b/src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp @@ -228,12 +228,12 @@ bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result if (tmp->is_valid()) { if (is_power_of_2(c + 1)) { __ move(left, tmp); - __ shift_left(left, log2_int(c + 1), left); + __ shift_left(left, log2i_exact(c + 1), left); __ sub(left, tmp, result); return true; } else if (is_power_of_2(c - 1)) { __ move(left, tmp); - __ shift_left(left, log2_int(c - 1), left); + __ shift_left(left, log2i_exact(c - 1), left); __ add(left, tmp, result); return true; } diff --git a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp index f7a0ffce1e99a..8caff08e52fb3 100644 --- a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp +++ b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp @@ -2630,7 +2630,7 @@ void LIR_Assembler::arithmetic_idiv(LIR_Code code, LIR_Opr left, LIR_Opr right, __ andl(rdx, divisor - 1); __ addl(lreg, rdx); } - __ sarl(lreg, log2_jint(divisor)); + __ sarl(lreg, log2i_exact(divisor)); move_regs(lreg, dreg); } else if (code == lir_irem) { Label done; diff --git a/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp b/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp index f8cb7bb70e64e..77c49237ff997 100644 --- a/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp +++ b/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp @@ -249,12 +249,12 @@ bool LIRGenerator::strength_reduce_multiply(LIR_Opr left, jint c, LIR_Opr result if (tmp->is_valid() && c > 0 && c < max_jint) { if (is_power_of_2(c + 1)) { __ move(left, tmp); - __ shift_left(left, log2_jint(c + 1), left); + __ shift_left(left, log2i_exact(c + 1), left); __ sub(left, tmp, result); return true; } else if (is_power_of_2(c - 1)) { __ move(left, tmp); - __ shift_left(left, log2_jint(c - 1), left); + __ shift_left(left, log2i_exact(c - 1), left); __ add(left, tmp, result); return true; } diff --git a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp index 78afbda693ba7..896bcb1ac1611 100644 --- a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp +++ b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp @@ -139,7 +139,7 @@ size_t ZPlatformAddressOffsetBits() { const size_t min_address_offset_bits = 42; // 4TB const size_t max_address_offset_bits = 44; // 16TB const size_t address_offset = round_up_power_of_2(MaxHeapSize * ZVirtualToPhysicalRatio); - const size_t address_offset_bits = log2_intptr(address_offset); + const size_t address_offset_bits = log2i_exact(address_offset); return clamp(address_offset_bits, min_address_offset_bits, max_address_offset_bits); } diff --git a/src/hotspot/cpu/x86/interp_masm_x86.cpp b/src/hotspot/cpu/x86/interp_masm_x86.cpp index e7b0df3d675ba..efd41b32c3160 100644 --- a/src/hotspot/cpu/x86/interp_masm_x86.cpp +++ b/src/hotspot/cpu/x86/interp_masm_x86.cpp @@ -153,7 +153,7 @@ void InterpreterMacroAssembler::profile_arguments_type(Register mdp, Register ca // CallTypeData/VirtualCallTypeData to reach its end. Non null // if there's a return to profile. assert(ReturnTypeEntry::static_cell_count() < TypeStackSlotEntries::per_arg_count(), "can't move past ret type"); - shll(tmp, exact_log2(DataLayout::cell_size)); + shll(tmp, log2i_exact((int)DataLayout::cell_size)); addptr(mdp, tmp); } movptr(Address(rbp, frame::interpreter_frame_mdp_offset * wordSize), mdp); diff --git a/src/hotspot/cpu/x86/vm_version_x86.cpp b/src/hotspot/cpu/x86/vm_version_x86.cpp index eac8c54367e80..3212a0fee0962 100644 --- a/src/hotspot/cpu/x86/vm_version_x86.cpp +++ b/src/hotspot/cpu/x86/vm_version_x86.cpp @@ -782,7 +782,7 @@ void VM_Version::get_processor_features() { cores_per_cpu(), threads_per_core(), cpu_family(), _model, _stepping, os::cpu_microcode_revision()); assert(res > 0, "not enough temporary space allocated"); - assert(exact_log2_long(CPU_MAX_FEATURE) + 1 == sizeof(_features_names) / sizeof(char*), "wrong size features_names"); + assert(log2i_exact((uint64_t)CPU_MAX_FEATURE) + 1 == sizeof(_features_names) / sizeof(char*), "wrong size features_names"); insert_features_names(buf + res, sizeof(buf) - res, _features_names); _features_string = os::strdup(buf); diff --git a/src/hotspot/cpu/x86/x86_64.ad b/src/hotspot/cpu/x86/x86_64.ad index 73fe153752806..7b23b45ef1ead 100644 --- a/src/hotspot/cpu/x86/x86_64.ad +++ b/src/hotspot/cpu/x86/x86_64.ad @@ -9592,7 +9592,7 @@ instruct btrL_mem_imm(memory dst, immL_NotPow2 con, rFlagsReg cr) %{ // con should be a pure 64-bit immediate given that not(con) is a power of 2 // because AND/OR works well enough for 8/32-bit values. - predicate(log2_long(~n->in(3)->in(2)->get_long()) > 30); + predicate(log2i_graceful(~n->in(3)->in(2)->get_long()) > 30); match(Set dst (StoreL dst (AndL (LoadL dst) con))); effect(KILL cr); @@ -9600,7 +9600,7 @@ instruct btrL_mem_imm(memory dst, immL_NotPow2 con, rFlagsReg cr) ins_cost(125); format %{ "btrq $dst, log2(not($con))\t# long" %} ins_encode %{ - __ btrq($dst$$Address, log2_long(~$con$$constant)); + __ btrq($dst$$Address, log2i_exact(~$con$$constant)); %} ins_pipe(ialu_mem_imm); %} @@ -9802,7 +9802,7 @@ instruct btsL_mem_imm(memory dst, immL_Pow2 con, rFlagsReg cr) %{ // con should be a pure 64-bit power of 2 immediate // because AND/OR works well enough for 8/32-bit values. - predicate(log2_long(n->in(3)->in(2)->get_long()) > 31); + predicate(log2i_graceful(n->in(3)->in(2)->get_long()) > 31); match(Set dst (StoreL dst (OrL (LoadL dst) con))); effect(KILL cr); @@ -9810,7 +9810,7 @@ instruct btsL_mem_imm(memory dst, immL_Pow2 con, rFlagsReg cr) ins_cost(125); format %{ "btsq $dst, log2($con)\t# long" %} ins_encode %{ - __ btsq($dst$$Address, log2_long((julong)$con$$constant)); + __ btsq($dst$$Address, log2i_exact((julong)$con$$constant)); %} ins_pipe(ialu_mem_imm); %} diff --git a/src/hotspot/share/compiler/compilationPolicy.cpp b/src/hotspot/share/compiler/compilationPolicy.cpp index 030357f3d5902..777f1f534cf8f 100644 --- a/src/hotspot/share/compiler/compilationPolicy.cpp +++ b/src/hotspot/share/compiler/compilationPolicy.cpp @@ -251,7 +251,7 @@ void SimpleCompPolicy::initialize() { // Example: if CICompilerCountPerCPU is true, then we get // max(log2(8)-1,1) = 2 compiler threads on an 8-way machine. // May help big-app startup time. - _compiler_count = MAX2(log2_int(os::active_processor_count())-1,1); + _compiler_count = MAX2(log2i_graceful(os::active_processor_count()) - 1, 1); // Make sure there is enough space in the code cache to hold all the compiler buffers size_t buffer_size = 1; #ifdef COMPILER1 diff --git a/src/hotspot/share/compiler/compilerDefinitions.cpp b/src/hotspot/share/compiler/compilerDefinitions.cpp index 5e3c2ef9052cd..4aa2512982b7a 100644 --- a/src/hotspot/share/compiler/compilerDefinitions.cpp +++ b/src/hotspot/share/compiler/compilerDefinitions.cpp @@ -117,19 +117,14 @@ intx CompilerConfig::scaled_freq_log(intx freq_log, double scale) { // of length InvocationCounter::number_of_count_bits. Mask values are always // one bit shorter then the value of the notification frequency. Set // max_freq_bits accordingly. - intx max_freq_bits = InvocationCounter::number_of_count_bits + 1; + int max_freq_bits = InvocationCounter::number_of_count_bits + 1; intx scaled_freq = scaled_compile_threshold((intx)1 << freq_log, scale); if (scaled_freq == 0) { // Return 0 right away to avoid calculating log2 of 0. return 0; } else { - intx res = log2_intptr(scaled_freq); - if (res > max_freq_bits) { - return max_freq_bits; - } else { - return res; - } + return MIN2(log2i(scaled_freq), max_freq_bits); } } diff --git a/src/hotspot/share/compiler/tieredThresholdPolicy.cpp b/src/hotspot/share/compiler/tieredThresholdPolicy.cpp index b72d604e1d51f..f076a36a082cc 100644 --- a/src/hotspot/share/compiler/tieredThresholdPolicy.cpp +++ b/src/hotspot/share/compiler/tieredThresholdPolicy.cpp @@ -253,8 +253,8 @@ void TieredThresholdPolicy::initialize() { } if (CICompilerCountPerCPU) { // Simple log n seems to grow too slowly for tiered, try something faster: log n * log log n - int log_cpu = log2_int(os::active_processor_count()); - int loglog_cpu = log2_int(MAX2(log_cpu, 1)); + int log_cpu = log2i(os::active_processor_count()); + int loglog_cpu = log2i(MAX2(log_cpu, 1)); count = MAX2(log_cpu * loglog_cpu * 3 / 2, 2); // Make sure there is enough space in the code cache to hold all the compiler buffers size_t c1_size = Compiler::code_buffer_size(); diff --git a/src/hotspot/share/gc/g1/g1BiasedArray.hpp b/src/hotspot/share/gc/g1/g1BiasedArray.hpp index 7c6047065666e..8080b76fe5788 100644 --- a/src/hotspot/share/gc/g1/g1BiasedArray.hpp +++ b/src/hotspot/share/gc/g1/g1BiasedArray.hpp @@ -82,7 +82,7 @@ class G1BiasedMappedArrayBase : public CHeapObj { size_t num_target_elems = pointer_delta(end, bottom, mapping_granularity_in_bytes); idx_t bias = (uintptr_t)bottom / mapping_granularity_in_bytes; address base = create_new_base_array(num_target_elems, target_elem_size_in_bytes); - initialize_base(base, num_target_elems, bias, target_elem_size_in_bytes, log2_intptr(mapping_granularity_in_bytes)); + initialize_base(base, num_target_elems, bias, target_elem_size_in_bytes, log2i_exact(mapping_granularity_in_bytes)); } size_t bias() const { return _bias; } diff --git a/src/hotspot/share/gc/g1/g1FreeIdSet.cpp b/src/hotspot/share/gc/g1/g1FreeIdSet.cpp index 6b78ab7432608..37e663b9e6b1d 100644 --- a/src/hotspot/share/gc/g1/g1FreeIdSet.cpp +++ b/src/hotspot/share/gc/g1/g1FreeIdSet.cpp @@ -29,6 +29,7 @@ #include "utilities/debug.hpp" #include "utilities/globalDefinitions.hpp" #include "utilities/macros.hpp" +#include "utilities/powerOfTwo.hpp" G1FreeIdSet::G1FreeIdSet(uint start, uint size) : _sem(size), // counting semaphore for available ids @@ -43,7 +44,7 @@ G1FreeIdSet::G1FreeIdSet(uint start, uint size) : "start (%u) + size (%u) overflow: ", start, size); // 2^shift must be greater than size. Equal is not permitted, because // size is the "end of list" value, and can be the index part of _head. - uint shift = log2_intptr((uintptr_t)size) + 1; + uint shift = log2i(size) + 1; assert(shift <= (BitsPerWord / 2), "excessive size %u", size); _head_index_mask = (uintx(1) << shift) - 1; assert(size <= _head_index_mask, "invariant"); diff --git a/src/hotspot/share/gc/g1/g1RemSet.cpp b/src/hotspot/share/gc/g1/g1RemSet.cpp index 9c9a699938b84..a737da25ceabc 100644 --- a/src/hotspot/share/gc/g1/g1RemSet.cpp +++ b/src/hotspot/share/gc/g1/g1RemSet.cpp @@ -57,6 +57,7 @@ #include "runtime/os.hpp" #include "utilities/align.hpp" #include "utilities/globalDefinitions.hpp" +#include "utilities/powerOfTwo.hpp" #include "utilities/stack.inline.hpp" #include "utilities/ticks.hpp" @@ -289,7 +290,7 @@ class G1RemSetScanState : public CHeapObj { _collection_set_iter_state(NULL), _card_table_scan_state(NULL), _scan_chunks_per_region(get_chunks_per_region(HeapRegion::LogOfHRGrainBytes)), - _log_scan_chunks_per_region(log2_uint(_scan_chunks_per_region)), + _log_scan_chunks_per_region(log2i(_scan_chunks_per_region)), _region_scan_chunks(NULL), _num_total_scan_chunks(0), _scan_chunks_shift(0), @@ -313,7 +314,7 @@ class G1RemSetScanState : public CHeapObj { _num_total_scan_chunks = max_reserved_regions * _scan_chunks_per_region; _region_scan_chunks = NEW_C_HEAP_ARRAY(bool, _num_total_scan_chunks, mtGC); - _scan_chunks_shift = (uint8_t)log2_intptr(HeapRegion::CardsPerRegion / _scan_chunks_per_region); + _scan_chunks_shift = (uint8_t)log2i(HeapRegion::CardsPerRegion / _scan_chunks_per_region); _scan_top = NEW_C_HEAP_ARRAY(HeapWord*, max_reserved_regions, mtGC); } diff --git a/src/hotspot/share/gc/g1/heapRegion.cpp b/src/hotspot/share/gc/g1/heapRegion.cpp index d954d1603176a..d856b6d4b26dd 100644 --- a/src/hotspot/share/gc/g1/heapRegion.cpp +++ b/src/hotspot/share/gc/g1/heapRegion.cpp @@ -78,7 +78,7 @@ void HeapRegion::setup_heap_region_size(size_t max_heap_size) { region_size = clamp(region_size, HeapRegionBounds::min_size(), HeapRegionBounds::max_size()); // Calculate the log for the region size. - int region_size_log = exact_log2_long((jlong)region_size); + int region_size_log = log2i_exact(region_size); // Now, set up the globals. guarantee(LogOfHRGrainBytes == 0, "we should only set it once"); @@ -99,7 +99,7 @@ void HeapRegion::setup_heap_region_size(size_t max_heap_size) { guarantee(CardsPerRegion == 0, "we should only set it once"); CardsPerRegion = GrainBytes >> G1CardTable::card_shift; - LogCardsPerRegion = log2_long((jlong) CardsPerRegion); + LogCardsPerRegion = log2i(CardsPerRegion); if (G1HeapRegionSize != GrainBytes) { FLAG_SET_ERGO(G1HeapRegionSize, GrainBytes); diff --git a/src/hotspot/share/gc/g1/heapRegionRemSet.cpp b/src/hotspot/share/gc/g1/heapRegionRemSet.cpp index f23932b9d0e97..4c122ab41bd0f 100644 --- a/src/hotspot/share/gc/g1/heapRegionRemSet.cpp +++ b/src/hotspot/share/gc/g1/heapRegionRemSet.cpp @@ -39,6 +39,7 @@ #include "utilities/formatBuffer.hpp" #include "utilities/globalDefinitions.hpp" #include "utilities/growableArray.hpp" +#include "utilities/powerOfTwo.hpp" const char* HeapRegionRemSet::_state_strings[] = {"Untracked", "Updating", "Complete"}; const char* HeapRegionRemSet::_short_state_strings[] = {"UNTRA", "UPDAT", "CMPLT"}; @@ -83,7 +84,7 @@ OtherRegionsTable::OtherRegionsTable(Mutex* m) : if (_max_fine_entries == 0) { assert(_mod_max_fine_entries_mask == 0, "Both or none."); - size_t max_entries_log = (size_t)log2_long((jlong)G1RSetRegionEntries); + size_t max_entries_log = (size_t)log2i(G1RSetRegionEntries); _max_fine_entries = (size_t)1 << max_entries_log; _mod_max_fine_entries_mask = _max_fine_entries - 1; diff --git a/src/hotspot/share/gc/shared/partialArrayTaskStepper.cpp b/src/hotspot/share/gc/shared/partialArrayTaskStepper.cpp index 7b60e1b0e1185..ed52d7abff18c 100644 --- a/src/hotspot/share/gc/shared/partialArrayTaskStepper.cpp +++ b/src/hotspot/share/gc/shared/partialArrayTaskStepper.cpp @@ -26,6 +26,7 @@ #include "gc/shared/partialArrayTaskStepper.hpp" #include "oops/arrayOop.hpp" #include "utilities/globalDefinitions.hpp" +#include "utilities/powerOfTwo.hpp" static uint compute_task_limit(uint n_workers) { // Don't need more than n_workers tasks at a time. But allowing up to @@ -39,7 +40,7 @@ static uint compute_task_fanout(uint task_limit) { // number of enqueued tasks. A constant fanout may be too slow when // parallelism (and so task_limit) is large. A constant fraction might // be overly eager. Using log2 attempts to balance between those. - uint result = log2_uint(task_limit); + uint result = log2i(task_limit); // result must be > 0. result should be > 1 if task_limit > 1, to // provide some potentially parallel tasks. But don't just +1 to // avoid otherwise increasing rate of task generation. diff --git a/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp b/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp index 40e0957fa72e1..f9872b04fdaaf 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp @@ -36,6 +36,7 @@ #include "oops/compressedOops.inline.hpp" #include "oops/oop.inline.hpp" #include "runtime/prefetch.inline.hpp" +#include "utilities/powerOfTwo.hpp" template void ShenandoahConcurrentMark::do_task(ShenandoahObjToScanQueue* q, T* cl, ShenandoahLiveData* live_data, ShenandoahMarkTask* task) { @@ -120,7 +121,7 @@ inline void ShenandoahConcurrentMark::do_chunked_array_start(ShenandoahObjToScan // A few slices only, process directly array->oop_iterate_range(cl, 0, len); } else { - int bits = log2_long((size_t) len); + int bits = log2i_graceful(len); // Compensate for non-power-of-two arrays, cover the array in excess: if (len != (1 << bits)) bits++; diff --git a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp index 2dd5f161d1df4..2ba5fa01a1604 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp @@ -40,6 +40,7 @@ #include "runtime/mutexLocker.hpp" #include "runtime/os.hpp" #include "runtime/safepoint.hpp" +#include "utilities/powerOfTwo.hpp" size_t ShenandoahHeapRegion::RegionCount = 0; size_t ShenandoahHeapRegion::RegionSizeBytes = 0; @@ -548,7 +549,7 @@ void ShenandoahHeapRegion::setup_sizes(size_t max_heap_size) { region_size = MAX2(region_size, os::large_page_size()); } - int region_size_log = log2_long((jlong) region_size); + int region_size_log = log2i(region_size); // Recalculate the region size to make sure it's a power of // 2. This means that region_size is the largest power of 2 that's // <= what we've calculated so far. diff --git a/src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp b/src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp index b55d50e9bb6e2..33d5df425b35b 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp @@ -139,7 +139,7 @@ void BinaryMagnitudeSeq::clear() { void BinaryMagnitudeSeq::add(size_t val) { Atomic::add(&_sum, val); - int mag = log2_intptr(val) + 1; + int mag = log2i_graceful(val) + 1; // Defensively saturate for product bits: if (mag < 0) { diff --git a/src/hotspot/share/gc/z/zHeuristics.cpp b/src/hotspot/share/gc/z/zHeuristics.cpp index ca704962ae76b..6f67c93536771 100644 --- a/src/hotspot/share/gc/z/zHeuristics.cpp +++ b/src/hotspot/share/gc/z/zHeuristics.cpp @@ -45,7 +45,7 @@ void ZHeuristics::set_medium_page_size() { if (size > ZPageSizeSmall) { // Enable medium pages ZPageSizeMedium = size; - ZPageSizeMediumShift = log2_intptr(ZPageSizeMedium); + ZPageSizeMediumShift = log2i_exact(ZPageSizeMedium); ZObjectSizeLimitMedium = ZPageSizeMedium / 8; ZObjectAlignmentMediumShift = (int)ZPageSizeMediumShift - 13; ZObjectAlignmentMedium = 1 << ZObjectAlignmentMediumShift; diff --git a/src/hotspot/share/opto/divnode.cpp b/src/hotspot/share/opto/divnode.cpp index 2e5d65682707d..7f7d6e5ea013f 100644 --- a/src/hotspot/share/opto/divnode.cpp +++ b/src/hotspot/share/opto/divnode.cpp @@ -134,7 +134,7 @@ static Node *transform_int_divide( PhaseGVN *phase, Node *dividend, jint divisor } // Add rounding to the shift to handle the sign bit - int l = log2_jint(d-1)+1; + int l = log2i_graceful(d - 1) + 1; if (needs_rounding) { // Divide-by-power-of-2 can be made into a shift, but you have to do // more math for the rounding. You need to add 0 for positive @@ -380,7 +380,7 @@ static Node *transform_long_divide( PhaseGVN *phase, Node *dividend, jlong divis } // Add rounding to the shift to handle the sign bit - int l = log2_long(d-1)+1; + int l = log2i_graceful(d - 1) + 1; if (needs_rounding) { // Divide-by-power-of-2 can be made into a shift, but you have to do // more math for the rounding. You need to add 0 for positive @@ -929,8 +929,8 @@ Node *ModINode::Ideal(PhaseGVN *phase, bool can_reshape) { int log2_con = -1; // If this is a power of two, they maybe we can mask it - if( is_power_of_2(pos_con) ) { - log2_con = log2_intptr((intptr_t)pos_con); + if (is_power_of_2(pos_con)) { + log2_con = log2i_exact(pos_con); const Type *dt = phase->type(in(1)); const TypeInt *dti = dt->isa_int(); @@ -1036,8 +1036,8 @@ Node *ModLNode::Ideal(PhaseGVN *phase, bool can_reshape) { Node *hook = new Node(1); // Expand mod - if( con >= 0 && con < max_jlong && is_power_of_2(con+1) ) { - uint k = exact_log2_long(con+1); // Extract k + if(con >= 0 && con < max_jlong && is_power_of_2(con + 1)) { + uint k = log2i_exact(con + 1); // Extract k // Basic algorithm by David Detlefs. See fastmod_long.java for gory details. // Used to help a popular random number generator which does a long-mod @@ -1096,8 +1096,8 @@ Node *ModLNode::Ideal(PhaseGVN *phase, bool can_reshape) { int log2_con = -1; // If this is a power of two, then maybe we can mask it - if( is_power_of_2(pos_con) ) { - log2_con = exact_log2_long(pos_con); + if (is_power_of_2(pos_con)) { + log2_con = log2i_exact(pos_con); const Type *dt = phase->type(in(1)); const TypeLong *dtl = dt->isa_long(); diff --git a/src/hotspot/share/opto/mulnode.cpp b/src/hotspot/share/opto/mulnode.cpp index 734cd2f131932..14cc03f58df0a 100644 --- a/src/hotspot/share/opto/mulnode.cpp +++ b/src/hotspot/share/opto/mulnode.cpp @@ -201,21 +201,19 @@ Node *MulINode::Ideal(PhaseGVN *phase, bool can_reshape) { Node *res = NULL; unsigned int bit1 = abs_con & (0-abs_con); // Extract low bit if (bit1 == abs_con) { // Found a power of 2? - res = new LShiftINode(in(1), phase->intcon(log2_uint(bit1))); + res = new LShiftINode(in(1), phase->intcon(log2i_exact(bit1))); } else { - // Check for constant with 2 bits set - unsigned int bit2 = abs_con-bit1; - bit2 = bit2 & (0-bit2); // Extract 2nd bit + unsigned int bit2 = abs_con - bit1; + bit2 = bit2 & (0 - bit2); // Extract 2nd bit if (bit2 + bit1 == abs_con) { // Found all bits in con? - Node *n1 = phase->transform( new LShiftINode(in(1), phase->intcon(log2_uint(bit1)))); - Node *n2 = phase->transform( new LShiftINode(in(1), phase->intcon(log2_uint(bit2)))); + Node *n1 = phase->transform(new LShiftINode(in(1), phase->intcon(log2i_exact(bit1)))); + Node *n2 = phase->transform(new LShiftINode(in(1), phase->intcon(log2i_exact(bit2)))); res = new AddINode(n2, n1); - - } else if (is_power_of_2(abs_con+1)) { - // Sleezy: power-of-2 -1. Next time be generic. + } else if (is_power_of_2(abs_con + 1)) { + // Sleezy: power-of-2 - 1. Next time be generic. unsigned int temp = abs_con + 1; - Node *n1 = phase->transform(new LShiftINode(in(1), phase->intcon(log2_uint(temp)))); + Node *n1 = phase->transform(new LShiftINode(in(1), phase->intcon(log2i_exact(temp)))); res = new SubINode(n1, in(1)); } else { return MulNode::Ideal(phase, can_reshape); @@ -297,21 +295,21 @@ Node *MulLNode::Ideal(PhaseGVN *phase, bool can_reshape) { Node *res = NULL; julong bit1 = abs_con & (0-abs_con); // Extract low bit if (bit1 == abs_con) { // Found a power of 2? - res = new LShiftLNode(in(1), phase->intcon(log2_long(bit1))); + res = new LShiftLNode(in(1), phase->intcon(log2i_exact(bit1))); } else { // Check for constant with 2 bits set julong bit2 = abs_con-bit1; bit2 = bit2 & (0-bit2); // Extract 2nd bit if (bit2 + bit1 == abs_con) { // Found all bits in con? - Node *n1 = phase->transform(new LShiftLNode(in(1), phase->intcon(log2_long(bit1)))); - Node *n2 = phase->transform(new LShiftLNode(in(1), phase->intcon(log2_long(bit2)))); + Node *n1 = phase->transform(new LShiftLNode(in(1), phase->intcon(log2i_exact(bit1)))); + Node *n2 = phase->transform(new LShiftLNode(in(1), phase->intcon(log2i_exact(bit2)))); res = new AddLNode(n2, n1); } else if (is_power_of_2(abs_con+1)) { // Sleezy: power-of-2 -1. Next time be generic. julong temp = abs_con + 1; - Node *n1 = phase->transform( new LShiftLNode(in(1), phase->intcon(log2_long(temp)))); + Node *n1 = phase->transform( new LShiftLNode(in(1), phase->intcon(log2i_exact(temp)))); res = new SubLNode(n1, in(1)); } else { return MulNode::Ideal(phase, can_reshape); @@ -447,9 +445,9 @@ Node* AndINode::Identity(PhaseGVN* phase) { if (t2 && t2->is_con()) { int con = t2->get_con(); // Masking off high bits which are always zero is useless. - const TypeInt* t1 = phase->type( in(1) )->isa_int(); + const TypeInt* t1 = phase->type(in(1))->isa_int(); if (t1 != NULL && t1->_lo >= 0) { - jint t1_support = right_n_bits(1 + log2_jint(t1->_hi)); + jint t1_support = right_n_bits(1 + log2i_graceful(t1->_hi)); if ((t1_support & con) == t1_support) return in1; } @@ -572,7 +570,7 @@ Node* AndLNode::Identity(PhaseGVN* phase) { // Masking off high bits which are always zero is useless. const TypeLong* t1 = phase->type( in(1) )->isa_long(); if (t1 != NULL && t1->_lo >= 0) { - int bit_count = log2_long(t1->_hi) + 1; + int bit_count = log2i_graceful(t1->_hi) + 1; jlong t1_support = jlong(max_julong >> (BitsPerJavaLong - bit_count)); if ((t1_support & con) == t1_support) return usr; diff --git a/src/hotspot/share/opto/parse2.cpp b/src/hotspot/share/opto/parse2.cpp index c006de2ae5acb..17dee7032e80e 100644 --- a/src/hotspot/share/opto/parse2.cpp +++ b/src/hotspot/share/opto/parse2.cpp @@ -975,7 +975,7 @@ void Parse::jump_switch_ranges(Node* key_val, SwitchRange *lo, SwitchRange *hi, #ifndef PRODUCT if (switch_depth == 0) { _max_switch_depth = 0; - _est_switch_depth = log2_intptr((hi-lo+1)-1)+1; + _est_switch_depth = log2i_graceful((hi - lo + 1) - 1) + 1; } #endif diff --git a/src/hotspot/share/opto/vectorIntrinsics.cpp b/src/hotspot/share/opto/vectorIntrinsics.cpp index 76cfc71239fc5..d5006a510b2eb 100644 --- a/src/hotspot/share/opto/vectorIntrinsics.cpp +++ b/src/hotspot/share/opto/vectorIntrinsics.cpp @@ -368,7 +368,7 @@ bool LibraryCallKit::inline_vector_shuffle_iota() { Node* bcast_step = gvn().transform(VectorNode::scalar2vector(step, num_elem, type_bt)); res = gvn().transform(VectorNode::make(Op_MulI, res, bcast_step, num_elem, elem_bt)); } else if (step_val->get_con() > 1) { - Node* cnt = gvn().makecon(TypeInt::make(log2_int(step_val->get_con()))); + Node* cnt = gvn().makecon(TypeInt::make(log2i_exact(step_val->get_con()))); res = gvn().transform(VectorNode::make(Op_LShiftVB, res, cnt, vt)); } diff --git a/src/hotspot/share/utilities/globalDefinitions.hpp b/src/hotspot/share/utilities/globalDefinitions.hpp index fd691e02d9b40..b7f8b1a4b0bce 100644 --- a/src/hotspot/share/utilities/globalDefinitions.hpp +++ b/src/hotspot/share/utilities/globalDefinitions.hpp @@ -1042,59 +1042,6 @@ inline T clamp(T value, T min, T max) { return MIN2(MAX2(value, min), max); } -// Returns largest i such that 2^i <= x. -// If x == 0, the function returns -1. -inline int log2_intptr(uintptr_t x) { - int i = -1; - uintptr_t p = 1; - while (p != 0 && p <= x) { - // p = 2^(i+1) && p <= x (i.e., 2^(i+1) <= x) - i++; p *= 2; - } - // p = 2^(i+1) && x < p (i.e., 2^i <= x < 2^(i+1)) - // If p = 0, overflow has occurred and i = 31 or i = 63 (depending on the machine word size). - return i; -} - -//* largest i such that 2^i <= x -inline int log2_long(julong x) { - int i = -1; - julong p = 1; - while (p != 0 && p <= x) { - // p = 2^(i+1) && p <= x (i.e., 2^(i+1) <= x) - i++; p *= 2; - } - // p = 2^(i+1) && x < p (i.e., 2^i <= x < 2^(i+1)) - // (if p = 0 then overflow occurred and i = 63) - return i; -} - -// If x < 0, the function returns 31 on a 32-bit machine and 63 on a 64-bit machine. -inline int log2_intptr(intptr_t x) { - return log2_intptr((uintptr_t)x); -} - -inline int log2_int(int x) { - STATIC_ASSERT(sizeof(int) <= sizeof(uintptr_t)); - return log2_intptr((uintptr_t)(unsigned int)x); -} - -inline int log2_jint(jint x) { - STATIC_ASSERT(sizeof(jint) <= sizeof(uintptr_t)); - return log2_intptr((uintptr_t)(juint)x); -} - -inline int log2_uint(uint x) { - STATIC_ASSERT(sizeof(uint) <= sizeof(uintptr_t)); - return log2_intptr((uintptr_t)x); -} - -// A negative value of 'x' will return '63' -inline int log2_jlong(jlong x) { - STATIC_ASSERT(sizeof(jlong) <= sizeof(julong)); - return log2_long((julong)x); -} - inline bool is_odd (intx x) { return x & 1; } inline bool is_even(intx x) { return !is_odd(x); } diff --git a/src/hotspot/share/utilities/hashtable.cpp b/src/hotspot/share/utilities/hashtable.cpp index 682bb97d5d5d5..b7fa6481adffc 100644 --- a/src/hotspot/share/utilities/hashtable.cpp +++ b/src/hotspot/share/utilities/hashtable.cpp @@ -64,8 +64,7 @@ template BasicHashtableEntry* BasicHashtable::new_entry(unsig if (_first_free_entry + _entry_size >= _end_block) { int block_size = MAX2((int)_table_size / 2, (int)_number_of_entries); // pick a reasonable value block_size = clamp(block_size, 2, 512); // but never go out of this range - int len = _entry_size * block_size; - len = 1 << log2_int(len); // round down to power of 2 + int len = round_down_power_of_2(_entry_size * block_size); assert(len >= _entry_size, ""); _first_free_entry = NEW_C_HEAP_ARRAY2(char, len, F, CURRENT_PC); _entry_blocks.append(_first_free_entry); diff --git a/src/hotspot/share/utilities/powerOfTwo.hpp b/src/hotspot/share/utilities/powerOfTwo.hpp index 3fb10dbc3ca71..a98b81e803709 100644 --- a/src/hotspot/share/utilities/powerOfTwo.hpp +++ b/src/hotspot/share/utilities/powerOfTwo.hpp @@ -27,6 +27,7 @@ #include "metaprogramming/enableIf.hpp" #include "utilities/count_leading_zeros.hpp" +#include "utilities/count_trailing_zeros.hpp" #include "utilities/debug.hpp" #include "utilities/globalDefinitions.hpp" #include @@ -40,26 +41,52 @@ constexpr T max_power_of_2() { return max_val - (max_val >> 1); } -// Returns true iff there exists integer i such that (T(1) << i) == x. +// Returns true iff there exists integer i such that (T(1) << i) == value. template ::value)> -constexpr bool is_power_of_2(T x) { - return (x > T(0)) && ((x & (x - 1)) == T(0)); +constexpr bool is_power_of_2(T value) { + return (value > T(0)) && ((value & (value - 1)) == T(0)); } -// Log2 of a power of 2 -inline int exact_log2(intptr_t x) { - assert(is_power_of_2((uintptr_t)x), "x must be a power of 2: " INTPTR_FORMAT, x); +// Log2 of a positive, integral value, i.e., largest i such that 2^i <= value +// Precondition: value > 0 +template::value)> +inline int log2i(T value) { + assert(value > T(0), "value must be > 0"); + const int bits = sizeof(value) * BitsPerByte; + return bits - count_leading_zeros(value) - 1; +} + +// Log2 of positive, integral value, i.e., largest i such that 2^i <= value +// Returns -1 if value is zero +// For negative values this will return 63 for 64-bit types, 31 for +// 32-bit types, and so on. +template::value)> +inline int log2i_graceful(T value) { + if (value == 0) { + return -1; + } + const int bits = sizeof(value) * BitsPerByte; + return bits - count_leading_zeros(value) - 1; +} - const int bits = sizeof x * BitsPerByte; - return bits - count_leading_zeros(x) - 1; +// Log2 of a power of 2, i.e., i such that 2^i == value +// Preconditions: value > 0, value is a power of two +template::value)> +inline int log2i_exact(T value) { + assert(is_power_of_2(value), + "value must be a power of 2: " UINT64_FORMAT_X, + static_cast(value)); + return count_trailing_zeros(value); } -// Log2 of a power of 2 -inline int exact_log2_long(jlong x) { - assert(is_power_of_2((julong)x), "x must be a power of 2: " JLONG_FORMAT, x); +// Preconditions: value != 0, and the unsigned representation of value is a power of two +inline int exact_log2(intptr_t value) { + return log2i_exact((uintptr_t)value); +} - const int bits = sizeof x * BitsPerByte; - return bits - count_leading_zeros(x) - 1; +// Preconditions: value != 0, and the unsigned representation of value is a power of two +inline int exact_log2_long(jlong value) { + return log2i_exact((julong)value); } // Round down to the closest power of two less than or equal to the given value. @@ -67,8 +94,7 @@ inline int exact_log2_long(jlong x) { template::value)> inline T round_down_power_of_2(T value) { assert(value > 0, "Invalid value"); - uint32_t lz = count_leading_zeros(value); - return T(1) << (sizeof(T) * BitsPerByte - 1 - lz); + return T(1) << log2i(value); } // Round up to the closest power of two greater to or equal to the given value. @@ -81,8 +107,7 @@ inline T round_up_power_of_2(T value) { if (is_power_of_2(value)) { return value; } - uint32_t lz = count_leading_zeros(value); - return T(1) << (sizeof(T) * BitsPerByte - lz); + return T(1) << (log2i(value) + 1); } // Calculate the next power of two greater than the given value. diff --git a/test/hotspot/gtest/utilities/test_globalDefinitions.cpp b/test/hotspot/gtest/utilities/test_globalDefinitions.cpp index e82eea051aed3..503bd2d3eead7 100644 --- a/test/hotspot/gtest/utilities/test_globalDefinitions.cpp +++ b/test/hotspot/gtest/utilities/test_globalDefinitions.cpp @@ -190,41 +190,6 @@ TEST(globalDefinitions, byte_size_in_exact_unit) { #endif } -#define EXPECT_EQ_LOG2(fn, type) \ -{ \ - int limit = sizeof (type) * BitsPerByte; \ - if (std::is_signed::value) { \ - EXPECT_EQ(limit - 1, fn(std::numeric_limits::min())); \ - EXPECT_EQ(limit - 1, fn((type)-1)); \ - limit--; \ - } \ - { \ - /* Test the all-1s bit patterns */ \ - type var = 1; \ - for (int i = 0; i < limit; i++, var = (var << 1) | 1) { \ - EXPECT_EQ(i, fn(var)); \ - } \ - } \ - { \ - /* Test the powers of 2 and powers + 1*/ \ - type var = 1; \ - for (int i = 0; i < limit; i++, var <<= 1) { \ - EXPECT_EQ(i, fn(var)); \ - EXPECT_EQ(i, fn(var | 1)); \ - } \ - } \ -} - -TEST(globalDefinitions, log2) { - EXPECT_EQ_LOG2(log2_intptr, uintptr_t); - EXPECT_EQ_LOG2(log2_intptr, intptr_t); - EXPECT_EQ_LOG2(log2_long, julong); - EXPECT_EQ_LOG2(log2_int, int); - EXPECT_EQ_LOG2(log2_jint, jint); - EXPECT_EQ_LOG2(log2_uint, uint); - EXPECT_EQ_LOG2(log2_jlong, jlong); -} - TEST(globalDefinitions, array_size) { const size_t test_size = 10; diff --git a/test/hotspot/gtest/utilities/test_powerOfTwo.cpp b/test/hotspot/gtest/utilities/test_powerOfTwo.cpp index 3cf22fb032ab4..3830c6301092b 100644 --- a/test/hotspot/gtest/utilities/test_powerOfTwo.cpp +++ b/test/hotspot/gtest/utilities/test_powerOfTwo.cpp @@ -262,3 +262,45 @@ TEST(power_of_2, max) { EXPECT_EQ(max_power_of_2(), 0x80000000u); EXPECT_EQ(max_power_of_2(), UCONST64(0x8000000000000000)); } + +template ::value)> +void check_log2i_variants_for(T dummy) { + int limit = sizeof(T) * BitsPerByte; + if (std::is_signed::value) { + T min = std::numeric_limits::min(); + EXPECT_EQ(limit - 1, log2i_graceful(min)); + EXPECT_EQ(limit - 1, log2i_graceful((T)-1)); + limit--; + } + { + // Test log2i_graceful handles 0 input + EXPECT_EQ(-1, log2i_graceful(T(0))); + } + { + // Test the all-1s bit patterns + T var = 1; + for (int i = 0; i < limit; i++, var = (var << 1) | 1) { + EXPECT_EQ(i, log2i(var)); + } + } + { + // Test the powers of 2 and powers + 1 + T var = 1; + for (int i = 0; i < limit; i++, var <<= 1) { + EXPECT_EQ(i, log2i(var)); + EXPECT_EQ(i, log2i_graceful(var)); + EXPECT_EQ(i, log2i_exact(var)); + EXPECT_EQ(i, log2i(var | 1)); + } + } +} + +TEST(power_of_2, log2i) { + check_log2i_variants_for((uintptr_t)0); + check_log2i_variants_for((intptr_t)0); + check_log2i_variants_for((julong)0); + check_log2i_variants_for((int)0); + check_log2i_variants_for((jint)0); + check_log2i_variants_for((uint)0); + check_log2i_variants_for((jlong)0); +} From e6f9926009be24144290cd1ec731f1c7c7796434 Mon Sep 17 00:00:00 2001 From: Phil Race Date: Mon, 4 Jan 2021 21:09:01 +0000 Subject: [PATCH 005/129] 8257809: JNI warnings from Toolkit JPEG image decoding Reviewed-by: serb --- .../share/native/libjavajpeg/jpegdecoder.c | 20 +++--- .../GetImageJNICheck/GetImageJNICheck.java | 42 ++++++++++++ .../GetImageJNICheck/GetImageJNICheck.sh | 64 ++++++++++++++++++ .../java/awt/image/GetImageJNICheck/duke.jpg | Bin 0 -> 6031 bytes 4 files changed, 116 insertions(+), 10 deletions(-) create mode 100644 test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.java create mode 100644 test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.sh create mode 100644 test/jdk/java/awt/image/GetImageJNICheck/duke.jpg diff --git a/src/java.desktop/share/native/libjavajpeg/jpegdecoder.c b/src/java.desktop/share/native/libjavajpeg/jpegdecoder.c index 419c4a94b60cd..61ea804906f1f 100644 --- a/src/java.desktop/share/native/libjavajpeg/jpegdecoder.c +++ b/src/java.desktop/share/native/libjavajpeg/jpegdecoder.c @@ -221,27 +221,27 @@ static void RELEASE_ARRAYS(JNIEnv *env, sun_jpeg_source_ptr src) static int GET_ARRAYS(JNIEnv *env, sun_jpeg_source_ptr src) { + if (src->hOutputBuffer) { + assert(src->outbuf.ip == 0); + src->outbufSize = (*env)->GetArrayLength(env, src->hOutputBuffer); + src->outbuf.ip = (int *)(*env)->GetPrimitiveArrayCritical + (env, src->hOutputBuffer, 0); + if (src->outbuf.ip == 0) { + return 0; + } + } if (src->hInputBuffer) { assert(src->inbuf == 0); src->inbuf = (JOCTET *)(*env)->GetPrimitiveArrayCritical (env, src->hInputBuffer, 0); if (src->inbuf == 0) { + RELEASE_ARRAYS(env, src); return 0; } if ((int)(src->inbufoffset) >= 0) { src->pub.next_input_byte = src->inbuf + src->inbufoffset; } } - if (src->hOutputBuffer) { - assert(src->outbuf.ip == 0); - src->outbufSize = (*env)->GetArrayLength(env, src->hOutputBuffer); - src->outbuf.ip = (int *)(*env)->GetPrimitiveArrayCritical - (env, src->hOutputBuffer, 0); - if (src->outbuf.ip == 0) { - RELEASE_ARRAYS(env, src); - return 0; - } - } return 1; } diff --git a/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.java b/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.java new file mode 100644 index 0000000000000..3780fa46ba798 --- /dev/null +++ b/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.java @@ -0,0 +1,42 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.awt.Component; +import java.awt.Image; +import java.awt.MediaTracker; +import java.awt.Toolkit; + +public class GetImageJNICheck extends Component { + + public static void main(String[] args) throws Exception { + System.setProperty("java.awt.headless", "true"); + Toolkit tk = Toolkit.getDefaultToolkit(); + String testPath = System.getProperty("test.src", "."); + String imgFile = testPath + java.io.File.separator + "duke.jpg"; + Image image = tk.getImage(imgFile); + MediaTracker mt = new MediaTracker(new GetImageJNICheck() ); + mt.addImage(image, 0); + mt.waitForAll(); + System.exit(0); + } +} diff --git a/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.sh b/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.sh new file mode 100644 index 0000000000000..31b43744b89e8 --- /dev/null +++ b/test/jdk/java/awt/image/GetImageJNICheck/GetImageJNICheck.sh @@ -0,0 +1,64 @@ +#!/bin/ksh -p +# +# Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# +# +# @test +# @bug 8257809 +# @summary Tests that there are no JNI warnings. +# @compile GetImageJNICheck.java +# @run shell/timeout=300 GetImageJNICheck.sh +# +OS=`uname` + +if [ "${TESTJAVA}" = "" ] +then + echo "TESTJAVA not set. Test cannot execute. Failed." + exit 1 +fi + +# pick up the compiled class files. +if [ -z "${TESTCLASSES}" ]; then + CP="." + $TESTJAVA/bin/javac GetImageJNICheck.java +else + CP="${TESTCLASSES}" +fi + +$TESTJAVA/bin/java ${TESTVMOPTS} \ + -cp "${CP}" -Xcheck:jni GetImageJNICheck | grep ReleasePrimitiveArrayCritical > "${CP}"/log.txt + +#if [ $? -ne 0 ] +# then +# echo "Test fails: exception thrown!" +# exit 1 +#fi + +# any messages logged indicate a failure. +if [ -s "${CP}"/log.txt ]; then + echo "Test failed" + cat "${CP}"/log.txt + exit 1 +fi + +echo "Test passed" +exit 0 diff --git a/test/jdk/java/awt/image/GetImageJNICheck/duke.jpg b/test/jdk/java/awt/image/GetImageJNICheck/duke.jpg new file mode 100644 index 0000000000000000000000000000000000000000..3bdf9a4fc648afda6a083f90767ba4363b1c24a7 GIT binary patch literal 6031 zcmbVQcT`hbvp)eLfFJ^b3TmztMGz4is6Z41L@q=?sY)&)VnDh;Xo-pvs$8XcQHV^PR5AaEV_$5HxRsh07BEa+4FPHs8AU^&*0z8X&cJKsn`+4T`^YihH z71+ab1SpjE9@rxxAbDKlx}cP~BUs-1z`5sdJ_#x4l{QIR^sOnLf8g^%SVZRFp~JFD zCr&D#Qn_&PlBU+>EBZGK42^CY-?F@O*UH+)*3Rjn^COqX2v^^ye*OW-z@V^~ufj1A zkx_5s6B3h>-~E;HIXxpYD?2AQudKWRS6NkEQ`_9q+D2^e=4i*P)4d0@fWlg6};F?0Q>=gEiL@ghqNqc|j z>D5CQ_3CI1XFrQgG zZ7(p4_L+s46in-M3|_NeO)2zE#gtORv}%B`Y=>2g}^Rv{b?O5+Z*W!0-;Z{d4O&lpOKeYt4 z9Ncgi;sSeW*x71^sXQ>#M9b5bk;mo?-n{3#-CCc-X+7GDuX`8d(%QT*Sb8Y#;Y@-< z?>K>Rk`U9W;^;LsWL%?0zER&G{*?NM+OaT|K~6k$IXSo>7R1?Cd7DTJ}~ z+04ZhMMgXg)U`j5CNTPg3%ILxqez?{4~8J*yj7A80j15kad#jStXN|`;SyOuG40fe z%Rup=hIF+C)FDhKBI?W#&OFCv!p`1dnQVDIP}D~wZDPK+d4}j?s3FHcT!h5XlW6!j zm)X5;>T<{ugIsu|`}Lup4kpTp(bzLqq2t#yh#D=d_Ow%60KDlgv(Y&0`5QRD>TI-xa^ zGl8!U`fmfGo5#{xy#{leI-3yRLi~RBbKM$L(4=1VWTS6x6q?ZM8M%HrrfP&%LWD$m zjdJd+T;l<$M!*b zpm<({5l{b2`x4^M&JBO%v9c@vJZ_XOUZ*w+bT3Y#Y}l1mg`w$lFbRVh0(iNW_=%H# zvpi)Tw(X?1xGBB!gL$r9x1?%}SUKhXGgozjbbNXJs*DpO-r?Z>2S-j3qnP%)>I~?c z&3l@dyDDb&_}*yVC)ju%>KgIhVxardocx96=Pa$F^YmbL5(`GNzm2izx4M7Qq~g!> zuA~}C8B6TMn=r+&63eD#gV3Z1%_(+oc(Z48}?doZDSDcF6 z>S;3NLTh0Y*N>bXx6zOI7|D0znO9z3HQ-WG)Sdt8W3IM`uGLHHi%Ilb+n%2*8%TeV zSl9CH4~t@zvPpIsLl<^^jdOA`wmrq1@^)X%5m}4_&A*hQW3n=(^7Y}sJQqmw?b1gtNkdoQwB`00nM~inP|qV| zYee`Pa?)gH(<+RefxmK+NRpDvf1GIObF;VwiD~;VtwFq%C6V`ZpzL05XJ&bPKpo2J z{>4&GGSYGL3I%nndEm>&%IQ+egag_3W4-%hja9oYd;-f|*O7Xk@V>r+pn`4TDC207 ziJ0ziuX7LL!{Y8LywFV~vvfxAXUlC<-(LPe?9PAt@%6`m;-hQ$^jdw7qFk@^(0U9* zkw30+Q=z&TvS!4Rc2!fDbx%v2L-WI1F5)vPeN3H^N>+}_dV2M4)9gI9W*D;Ta*t5G zbGn6^L+9wuP9V06a1*-6iBkDsF2R@twmRp%fantQl-XQ>cWqa0?PWbumAcKXr9SKNKrT<_exd4hFz+s6 zMJc(vgK#F^C27-+YjknC65e<}*oYVI{aF?? zdQH`>{?kt%z7|N<4W*7fGI=@{sQQb% z&|S`$%vm~XzZ~RWJN7U##{gMwj6O2flbm?u@iS$h{_!W@=B;-AUg#q#LvwM)r5P&3 z2yTSnFzq#)yyS#BKF~kEsdj0XD2@BG$nI(|A~CB*BDJwYXyR^(K*&B#Ic;~dz#v6b zZ1T+U4t}v6BIvgl9XT!RUYLRGAz@Mrekufv*O)m-{RoGggiIFM&k`a|*Mrxl zcC<|t?c64fk5(A|zJRd1yWV#vzNB)PRQ7Ggk}#8rE?sOTFce+dBmTe*QwA@1?!UJF zxR#v(SxV^!V!x91dI+mHn;05%)>9aJ=K|WH(jm??*@=*AgFRo%J1WB!Z5*pe7Ns8n zsn;-g&~DHNm>J&swBjr~Jq#0Xc1CkL*v-u&jLG4n;pO0t zyPGY}ZTbfND>JnM^dv}P|U-qNYQPb+>I`Ww#yMBHHUTO>`j={lD~)4J$84W z3LuPSM&5~$s#ku1Y!9L<+uPOR?Nv=7Hc4C4U+kZjC3JNoiC=4a(3(!??A`?x-jdy} zjN_$72c%QmJsIC*VkKmMN?EP@$)lIv;$uT6ElUZr#j;1w^xC@5JF0|LxlFS(;I>G0 z%9--DxRzaq_cT4CDfITh=8|IKiSO};+#5H43*v+fVoT60DHOF?14bj!H>#@E2+y>E z=mLX`<@gMB^trR^X=|meXY=2Yl28Fx4JW(;#m9^|B0DqG*U85etJbpVYTe1AL{m$P z>T78?l|GD**Ye9k5=3R5_@JEDIpdTQw@Rc{oVWTAY&S%_Nt%OtD4&vPcE!JgGexxg;V zj&^@mjW9~;IevTu9U$Gx>BSy6jruJ_uuof`qKa^=81CsFo~LMFguN9{FYoiwZ2JxJ zb9nQ8#v_F8BaaO7%IIqs;r{t_rISke_VygPpU{}Xh3o7e6j{%kIO^q-p&pg6 zVtfB7u@?k$E>I<2`~#jmE{4Kz0gpH;FCamC4>oPE#mVOi16SvFvEYzf?CnpB(q@+ zgyQO*g7Je}BGRQt@2)Oy!XvAg2FP*qGIlh}(}QfCe5v+g!j;|8NSoFkM?V1?==^I` z_k{I)9P0p@j;&{BqFvFlEJSSz6GpDTTU1$`u9@Og+o$H_by_|)VL>zM5alF-$&3w6 z<^lrBj1^ru)?t{K?ZnP`#=^{)S>A|eN%NlMLv-{+YiL$+B>Ew2WV#K$W-%R?9OU`Z zVnKZGlE@jqR6Qlp2Qig0%GW6iA!iLXtvte{*FQL6S}3&Tw4+Kt^E3N4cgEU>7`_q2 z2R_->hsNu%svfI_XQ<;T^o`oF_GS3$z+9+4M?``bY=j0l^2iY*?^$uNrCM~9U1+t& zWV`&>Wa6fzYPUD1pF9s=;pfTy$@tDQT9;O)&(vh-{oqJUL%-l@Ryl=;&xmJ7G=h`B z-OjwEcso*&3%DF1Z-z4YINetSF>4pK`RCvQ%~O0OC6)c3`*0%yJ-C&#>oUl1;GQo6 z{z_h^p#l{2XcZAE{ba6;(J-sbx;#_u?uf%Qr%6TF*sbW-V8#?$+K;OtXZH(y$}vhO{p?Yzgpa)h^d z0RCdYcz1T#jkT&qdt+S{BoiL)OiPY?L6kC%l|KAOxMb_NeMfiZS(~nd{@>5?g}$GG zkC?#92MHCd>z=hgIJSn??Atmd!g_J&nt01maY_+J5IgfjsNl(J!k!zC9(Y}P(fh3; z1|Tjdl3@nY7N=_8)`eC&nB;GvlfnZN?;W)zYN?o=jlzASo~ow)0I?vs2%h{IAq9dRpfcE z>Q2EBVI~z_AybYPD~?1-v+lXyqW8_eRwao~@trVivYL7adcnf63#Q>}c~U2@-y2%U z&6>XFQT<}r8l3-8dpP^R!&%e;F3_Y-n2CoQA;jlMmXlqoP&Z$`XuGu(JafPV)Bk3uQB1;LR>;@#IEvF@@oKXJHk>057tft>eXI;XTl%`y2%19q%Y&uH$RR z&Om#0uK{H6UggB{=*Jsz`bm<0U6M4-^GHFmrQd**(Nk@K)~o|^^yK>f zp@I-iufEBNn|=E7e$l{TMN9VlzE7dwI_6a=3u+27$=*(#C-9ilok?e~xV)8Go1J>H zHc}<6E2?gJT7MZfHoy_N>`MzasQs#YU~Cdm>pXVojHkz;z0naQ(TKd8F`9Zl#z(y2 zsx!N?@s8<^#rZ9c2*=}{#oCjd65^y#tExBfmtp0A@ou%pj8aL z#DqY$|F&NH#;VEN6SSnrpwpZXcYFQ=?mp8*&+A77BwsO{t{`3z&K83$$T+l zmuzj!#6={1|IE_wU)BAZr5&wLGI&-}$Zwd7Y({uJ+ZCSb= zqI$e=U?3fz>*q2$7M@c|Z1+QASLJBOpF;NC$8+xP12;Gf>7KLe%nFRYLW#dT2|tJG zgB&W{`Vkr1Ix_GCR9%CnTfYV87HJuDj;fh`$4UE#1TZa-Z?>pW7W(H)nR|rgAk?dz zEz;m&4K4sG*2>2#l9gzh5$ZTO>K1vUq2+m>iN*u);+_1>dL2l9f2?k&!g{wUx?m{L zVYTFQl&TYug?1CCqM>WqWM0Zx8Jcy0u2UCxj}4pCIq=-NPaP-vo=gU53mMIRE+GGj zfY6rE)0`KDgZf(YQE?}x&}(~>%zGzlw%2*VD46dD89Rz_RGMtDQ4II1+_3Mm6>9RT zA$k*CbtdNBI+lu7pi;M9-qT4-t7MCxlxsdfOO%EqT*~{m;ekKYNUA$l*f5q~9s_)b z>GG0#0{1RP>qtgEn{3$xv7=p4mEGC&7S6Tk+a$2~^MzZ=nnsD`wWDLC4PC+julOSd zW6G_J(UYn~34W_TQzYW_GBh`eRA-Ia#Vlvl;zmXlN(QQ^kL4fyp5Y@J6EwFZ5c0zy zu!45T&XWFTO9tB?Wp}L2?oihtJAo!vyjE!a=x0!-^!!t67dnZ3m4%);0w0;)+*sp5 z{rkB&yPOM{aRCSe#E#_xFsL}=WS%uIGc;R*S)0)9PF~HdkXP$ER>lRY(TR@Myc5$_ VFWi5aU|9?f+s)Q&2*z?p{|oOZ3DE!m literal 0 HcmV?d00001 From 216c2ec077447718ae912831647250561a969f4e Mon Sep 17 00:00:00 2001 From: Jie Fu Date: Mon, 4 Jan 2021 23:41:51 +0000 Subject: [PATCH 006/129] 8258703: Incorrect 512-bit vector registers restore on x86_32 Reviewed-by: kvn, sviswanathan --- src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp index 812b56f6b5166..5c1056e8e0268 100644 --- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp @@ -314,18 +314,19 @@ void RegisterSaver::restore_live_registers(MacroAssembler* masm, bool restore_ve } if (restore_vectors) { + off = additional_frame_bytes - ymm_bytes; + // Restore upper half of YMM registers. + for (int n = 0; n < num_xmm_regs; n++) { + __ vinsertf128_high(as_XMMRegister(n), Address(rsp, n*16+off)); + } + if (UseAVX > 2) { // Restore upper half of ZMM registers. for (int n = 0; n < num_xmm_regs; n++) { __ vinsertf64x4_high(as_XMMRegister(n), Address(rsp, n*32)); } - __ addptr(rsp, zmm_bytes); - } - // Restore upper half of YMM registers. - for (int n = 0; n < num_xmm_regs; n++) { - __ vinsertf128_high(as_XMMRegister(n), Address(rsp, n*16)); } - __ addptr(rsp, ymm_bytes); + __ addptr(rsp, additional_frame_bytes); } __ pop_FPU_state(); From f0aae81ed553303131c84fec3f37ca6c3e981222 Mon Sep 17 00:00:00 2001 From: Xin Liu Date: Mon, 4 Jan 2021 23:58:53 +0000 Subject: [PATCH 007/129] 8259020: null-check of g1 write_ref_field_pre_entry is not necessary Reviewed-by: kbarrett, ayang, phh --- src/hotspot/share/gc/g1/g1BarrierSetRuntime.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/hotspot/share/gc/g1/g1BarrierSetRuntime.cpp b/src/hotspot/share/gc/g1/g1BarrierSetRuntime.cpp index fbb2c492a15cd..81fb5c0cc2ec8 100644 --- a/src/hotspot/share/gc/g1/g1BarrierSetRuntime.cpp +++ b/src/hotspot/share/gc/g1/g1BarrierSetRuntime.cpp @@ -45,11 +45,8 @@ void G1BarrierSetRuntime::write_ref_array_post_entry(HeapWord* dst, size_t lengt } // G1 pre write barrier slowpath -JRT_LEAF(void, G1BarrierSetRuntime::write_ref_field_pre_entry(oopDesc* orig, JavaThread *thread)) - if (orig == NULL) { - assert(false, "should be optimized out"); - return; - } +JRT_LEAF(void, G1BarrierSetRuntime::write_ref_field_pre_entry(oopDesc* orig, JavaThread* thread)) + assert(orig != nullptr, "should be optimized out"); assert(oopDesc::is_oop(orig, true /* ignore mark word */), "Error"); // store the original value that was in the field reference SATBMarkQueue& queue = G1ThreadLocalData::satb_mark_queue(thread); From 2499ac3db5c4a336059263a929031b4eef2d0f0a Mon Sep 17 00:00:00 2001 From: Xue-Lei Andrew Fan Date: Tue, 5 Jan 2021 00:11:55 +0000 Subject: [PATCH 008/129] 8259069: Fields could be final Reviewed-by: wetmore --- .../sun/security/ssl/DHClientKeyExchange.java | 2 +- .../sun/security/ssl/EphemeralKeyManager.java | 2 +- .../sun/security/ssl/HelloCookieManager.java | 6 ++-- .../security/ssl/SSLAlgorithmConstraints.java | 2 +- .../classes/sun/security/ssl/SSLCipher.java | 6 ++-- .../sun/security/ssl/SSLConfiguration.java | 4 +-- .../security/ssl/SSLEngineOutputRecord.java | 3 +- .../sun/security/ssl/SSLExtensions.java | 2 +- .../sun/security/ssl/SSLKeyExchange.java | 30 +++++++++---------- .../sun/security/ssl/SSLSessionImpl.java | 2 +- .../classes/sun/security/ssl/SunJSSE.java | 2 +- .../security/ssl/SunX509KeyManagerImpl.java | 2 +- .../sun/security/ssl/TrustStoreManager.java | 2 +- 13 files changed, 33 insertions(+), 32 deletions(-) diff --git a/src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java b/src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java index 36bdce58faf73..f9753ffe078b6 100644 --- a/src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java +++ b/src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java @@ -67,7 +67,7 @@ final class DHClientKeyExchange { */ private static final class DHClientKeyExchangeMessage extends HandshakeMessage { - private byte[] y; // 1 to 2^16 - 1 bytes + private final byte[] y; // 1 to 2^16 - 1 bytes DHClientKeyExchangeMessage( HandshakeContext handshakeContext) throws IOException { diff --git a/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java b/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java index b116004996948..2e5540f1f59d6 100644 --- a/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java +++ b/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java @@ -109,7 +109,7 @@ private static class EphemeralKeyPair { private KeyPair keyPair; private int uses; - private long expirationTime; + private final long expirationTime; private EphemeralKeyPair(KeyPair keyPair) { this.keyPair = keyPair; diff --git a/src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java b/src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java index b878c7039895d..6880c929ab6fa 100644 --- a/src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java +++ b/src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java @@ -122,9 +122,9 @@ abstract boolean isCookieValid(ServerHandshakeContext context, class D10HelloCookieManager extends HelloCookieManager { final SecureRandom secureRandom; - private int cookieVersion; // allow to wrap, version + sequence - private byte[] cookieSecret; - private byte[] legacySecret; + private int cookieVersion; // allow to wrap, version + sequence + private final byte[] cookieSecret; + private final byte[] legacySecret; private final ReentrantLock d10ManagerLock = new ReentrantLock(); diff --git a/src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java b/src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java index e827247b792d9..e85b1b53ba8bc 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java @@ -225,7 +225,7 @@ public boolean permits(Set primitives, private static class SupportedSignatureAlgorithmConstraints implements AlgorithmConstraints { // supported signature algorithms - private String[] supportedAlgorithms; + private final String[] supportedAlgorithms; SupportedSignatureAlgorithmConstraints(String[] supportedAlgorithms) { if (supportedAlgorithms != null) { diff --git a/src/java.base/share/classes/sun/security/ssl/SSLCipher.java b/src/java.base/share/classes/sun/security/ssl/SSLCipher.java index 866c99263fd5a..bb9b53cce2fcf 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLCipher.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLCipher.java @@ -411,7 +411,7 @@ enum SSLCipher { private static final HashMap cipherLimits = new HashMap<>(); // Keywords found on the jdk.tls.keyLimits security property. - final static String tag[] = {"KEYUPDATE"}; + final static String[] tag = {"KEYUPDATE"}; static { final long max = 4611686018427387904L; // 2^62 @@ -424,12 +424,12 @@ public String run() { }); if (prop != null) { - String propvalue[] = prop.split(","); + String[] propvalue = prop.split(","); for (String entry : propvalue) { int index; // If this is not a UsageLimit, goto to next entry. - String values[] = entry.trim().toUpperCase().split(" "); + String[] values = entry.trim().toUpperCase().split(" "); if (values[1].contains(tag[0])) { index = 0; diff --git a/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java b/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java index f32a9a1a6b03b..f9a7c64e506c2 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java @@ -434,7 +434,7 @@ public Object clone() { // // See Effective Java Second Edition: Item 71. private static final class CustomizedClientSignatureSchemes { - private static List signatureSchemes = + private static final List signatureSchemes = getCustomizedSignatureScheme("jdk.tls.client.SignatureSchemes"); } @@ -442,7 +442,7 @@ private static final class CustomizedClientSignatureSchemes { // // See Effective Java Second Edition: Item 71. private static final class CustomizedServerSignatureSchemes { - private static List signatureSchemes = + private static final List signatureSchemes = getCustomizedSignatureScheme("jdk.tls.server.SignatureSchemes"); } diff --git a/src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java b/src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java index 67a0f393359f7..2f1bd6ffd113c 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java @@ -371,7 +371,8 @@ private static class HandshakeMemo extends RecordMemo { } final class HandshakeFragment { - private LinkedList handshakeMemos = new LinkedList<>(); + private final LinkedList handshakeMemos = + new LinkedList<>(); void queueUpFragment(byte[] source, int offset, int length) throws IOException { diff --git a/src/java.base/share/classes/sun/security/ssl/SSLExtensions.java b/src/java.base/share/classes/sun/security/ssl/SSLExtensions.java index aabac0675738b..3787e21caa9eb 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLExtensions.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLExtensions.java @@ -38,7 +38,7 @@ */ final class SSLExtensions { private final HandshakeMessage handshakeMessage; - private Map extMap = new LinkedHashMap<>(); + private final Map extMap = new LinkedHashMap<>(); private int encodedLength; // Extension map for debug logging diff --git a/src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java b/src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java index e9657de057eb7..5f0c5107e0510 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java @@ -265,78 +265,78 @@ static SSLKeyExchange valueOf(NamedGroup namedGroup) { } private static class SSLKeyExRSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA), T12KeyAgreement.RSA); } private static class SSLKeyExRSAExport { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA), T12KeyAgreement.RSA_EXPORT); } private static class SSLKeyExDHEDSS { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.DSA), T12KeyAgreement.DHE); } private static class SSLKeyExDHEDSSExport { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.DSA), T12KeyAgreement.DHE_EXPORT); } private static class SSLKeyExDHERSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA), T12KeyAgreement.DHE); } private static class SSLKeyExDHERSAOrPSS { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA_OR_PSS), T12KeyAgreement.DHE); } private static class SSLKeyExDHERSAExport { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA), T12KeyAgreement.DHE_EXPORT); } private static class SSLKeyExDHANON { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( null, T12KeyAgreement.DHE); } private static class SSLKeyExDHANONExport { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( null, T12KeyAgreement.DHE_EXPORT); } private static class SSLKeyExECDHECDSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.EC), T12KeyAgreement.ECDH); } private static class SSLKeyExECDHRSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.EC), T12KeyAgreement.ECDH); } private static class SSLKeyExECDHEECDSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.EC, X509Authentication.EDDSA), T12KeyAgreement.ECDHE); } private static class SSLKeyExECDHERSA { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA), T12KeyAgreement.ECDHE); } private static class SSLKeyExECDHERSAOrPSS { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( List.of(X509Authentication.RSA_OR_PSS), T12KeyAgreement.ECDHE); } private static class SSLKeyExECDHANON { - private static SSLKeyExchange KE = new SSLKeyExchange( + private static final SSLKeyExchange KE = new SSLKeyExchange( null, T12KeyAgreement.ECDHE); } diff --git a/src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java b/src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java index 19b19cb36fc15..d93c892f57529 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java @@ -125,7 +125,7 @@ final class SSLSessionImpl extends ExtendedSSLSession { /* * Use of session caches is globally enabled/disabled. */ - private static boolean defaultRejoinable = true; + private static final boolean defaultRejoinable = true; // server name indication final SNIServerName serverNameIndication; diff --git a/src/java.base/share/classes/sun/security/ssl/SunJSSE.java b/src/java.base/share/classes/sun/security/ssl/SunJSSE.java index 6a9ecb5a31645..d4e1f2079e5e1 100644 --- a/src/java.base/share/classes/sun/security/ssl/SunJSSE.java +++ b/src/java.base/share/classes/sun/security/ssl/SunJSSE.java @@ -56,7 +56,7 @@ public class SunJSSE extends java.security.Provider { @java.io.Serial private static final long serialVersionUID = 3231825739635378733L; - private static String info = "Sun JSSE provider" + + private static final String info = "Sun JSSE provider" + "(PKCS12, SunX509/PKIX key/trust factories, " + "SSLv3/TLSv1/TLSv1.1/TLSv1.2/TLSv1.3/DTLSv1.0/DTLSv1.2)"; diff --git a/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java b/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java index 914017e02d2a4..115a683cddd43 100644 --- a/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java @@ -87,7 +87,7 @@ final class SunX509KeyManagerImpl extends X509ExtendedKeyManager { * The credentials from the KeyStore as * Map: String(alias) -> X509Credentials(credentials) */ - private Map credentialsMap; + private final Map credentialsMap; /* * Cached server aliases for the case issuers == null. diff --git a/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java b/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java index 670d0c37150a3..2b00c3c93b136 100644 --- a/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java +++ b/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java @@ -149,7 +149,7 @@ public TrustStoreDescriptor run() { for (String fileName : fileNames) { File f = new File(fileName); if (f.isFile() && f.canRead()) { - temporaryName = fileName;; + temporaryName = fileName; temporaryFile = f; temporaryTime = f.lastModified(); From 5ea960728c5616373c986ae1343b44043c0db487 Mon Sep 17 00:00:00 2001 From: Ioi Lam Date: Tue, 5 Jan 2021 05:57:08 +0000 Subject: [PATCH 009/129] 8258459: Decouple gc_globals.hpp from globals.hpp Reviewed-by: lfoltan, coleenp --- .../cpu/aarch64/c1_LIRAssembler_aarch64.cpp | 3 +- .../cpu/aarch64/c1_MacroAssembler_aarch64.cpp | 3 +- .../cpu/aarch64/c1_Runtime1_aarch64.cpp | 3 +- .../cardTableBarrierSetAssembler_aarch64.cpp | 3 +- .../cpu/aarch64/gc/z/zGlobals_aarch64.cpp | 3 +- src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad | 3 +- .../cpu/aarch64/macroAssembler_aarch64.cpp | 3 +- .../cpu/aarch64/stubGenerator_aarch64.cpp | 4 +- .../cpu/aarch64/templateTable_aarch64.cpp | 3 +- src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp | 3 +- src/hotspot/cpu/arm/c1_Runtime1_arm.cpp | 3 +- src/hotspot/cpu/arm/templateTable_arm.cpp | 3 +- src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp | 3 +- src/hotspot/cpu/ppc/templateTable_ppc_64.cpp | 3 +- .../cpu/s390/c1_MacroAssembler_s390.cpp | 3 +- src/hotspot/cpu/s390/templateTable_s390.cpp | 3 +- src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp | 3 +- src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp | 3 +- src/hotspot/cpu/x86/c1_Runtime1_x86.cpp | 3 +- .../cardTableBarrierSetAssembler_x86.cpp | 3 +- .../c1/shenandoahBarrierSetC1_x86.cpp | 1 + src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp | 3 +- src/hotspot/cpu/x86/gc/z/z_x86_64.ad | 3 +- src/hotspot/cpu/x86/macroAssembler_x86.cpp | 3 +- src/hotspot/cpu/x86/stubGenerator_x86_64.cpp | 3 +- src/hotspot/cpu/x86/templateTable_x86.cpp | 3 +- src/hotspot/share/aot/aotCodeHeap.cpp | 6 +- .../share/gc/epsilon/epsilonArguments.cpp | 1 + .../share/gc/epsilon/epsilonInitLogger.cpp | 1 + .../gc/epsilon/epsilonThreadLocalData.hpp | 1 + src/hotspot/share/gc/g1/g1AllocRegion.cpp | 3 +- src/hotspot/share/gc/g1/g1Allocator.cpp | 3 +- src/hotspot/share/gc/g1/g1Analytics.cpp | 3 +- src/hotspot/share/gc/g1/g1CollectedHeap.cpp | 3 +- src/hotspot/share/gc/g1/g1EvacStats.cpp | 3 +- src/hotspot/share/gc/g1/g1FromCardCache.cpp | 3 +- src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp | 3 +- src/hotspot/share/gc/g1/g1HeapVerifier.cpp | 3 +- src/hotspot/share/gc/g1/g1InitLogger.cpp | 3 +- src/hotspot/share/gc/g1/g1ThreadLocalData.hpp | 3 +- .../parallel/jvmFlagConstraintsParallel.cpp | 3 +- .../share/gc/parallel/mutableNUMASpace.cpp | 3 +- .../gc/parallel/psPromotionManager.inline.hpp | 3 +- .../share/gc/serial/defNewGeneration.hpp | 3 +- src/hotspot/share/gc/serial/markSweep.cpp | 3 +- src/hotspot/share/gc/shared/ageTable.cpp | 5 +- .../share/gc/shared/blockOffsetTable.hpp | 3 +- .../gc/shared/c1/cardTableBarrierSetC1.cpp | 3 +- .../share/gc/shared/c2/barrierSetC2.cpp | 3 +- .../gc/shared/c2/cardTableBarrierSetC2.cpp | 3 +- src/hotspot/share/gc/shared/collectedHeap.cpp | 4 +- .../share/gc/shared/gcConfiguration.cpp | 6 +- src/hotspot/share/gc/shared/gcInitLogger.cpp | 3 +- .../share/gc/shared/gcOverheadChecker.hpp | 3 +- .../share/gc/shared/gcPolicyCounters.cpp | 3 +- src/hotspot/share/gc/shared/gcStats.cpp | 3 +- .../share/gc/shared/gcVMOperations.cpp | 3 +- src/hotspot/share/gc/shared/gc_globals.hpp | 50 +--------- .../share/gc/shared/jvmFlagConstraintsGC.cpp | 3 +- src/hotspot/share/gc/shared/memAllocator.cpp | 3 +- src/hotspot/share/gc/shared/plab.cpp | 4 +- src/hotspot/share/gc/shared/pretouchTask.cpp | 3 +- .../share/gc/shared/referencePolicy.cpp | 3 +- .../share/gc/shared/referenceProcessor.cpp | 3 +- .../shared/stringdedup/stringDedupTable.cpp | 3 +- .../share/gc/shared/suspendibleThreadSet.cpp | 3 +- .../share/gc/shared/taskTerminator.cpp | 6 +- .../gc/shared/threadLocalAllocBuffer.cpp | 7 +- .../gc/shared/threadLocalAllocBuffer.hpp | 8 +- .../shared/threadLocalAllocBuffer.inline.hpp | 3 +- src/hotspot/share/gc/shared/tlab_globals.hpp | 93 +++++++++++++++++++ src/hotspot/share/gc/shared/weakProcessor.cpp | 3 +- src/hotspot/share/gc/shared/workerManager.hpp | 3 +- src/hotspot/share/gc/shared/workgroup.cpp | 13 ++- src/hotspot/share/gc/shared/workgroup.hpp | 13 +-- .../gc/shenandoah/shenandoahArguments.cpp | 1 + .../share/gc/shenandoah/shenandoahFreeSet.cpp | 2 +- .../share/gc/shenandoah/shenandoahHeap.cpp | 1 + .../gc/shenandoah/shenandoahHeap.inline.hpp | 1 + .../gc/shenandoah/shenandoahHeapRegion.cpp | 5 +- .../gc/shenandoah/shenandoahHeapRegion.hpp | 1 + .../gc/shenandoah/shenandoahMarkCompact.cpp | 2 +- .../shenandoah/shenandoahThreadLocalData.hpp | 1 + .../gc/shenandoah/shenandoahVerifier.cpp | 2 +- .../gc/shenandoah/shenandoahWorkerPolicy.cpp | 1 + src/hotspot/share/gc/z/zAddressSpaceLimit.cpp | 3 +- src/hotspot/share/gc/z/zDirector.cpp | 3 +- src/hotspot/share/gc/z/zHeap.cpp | 3 +- src/hotspot/share/gc/z/zHeapIterator.cpp | 3 +- src/hotspot/share/gc/z/zHeuristics.cpp | 3 +- .../share/gc/z/zMarkStackAllocator.cpp | 3 +- src/hotspot/share/gc/z/zRelocate.cpp | 3 +- .../share/gc/z/zRelocationSetSelector.cpp | 3 +- src/hotspot/share/gc/z/zRuntimeWorkers.cpp | 3 +- src/hotspot/share/gc/z/zStat.cpp | 3 +- .../share/gc/z/zThreadLocalAllocBuffer.cpp | 3 +- src/hotspot/share/gc/z/zUncommitter.cpp | 3 +- src/hotspot/share/gc/z/zUnmapper.cpp | 3 +- src/hotspot/share/gc/z/zValue.inline.hpp | 3 +- src/hotspot/share/gc/z/zVerify.cpp | 3 +- src/hotspot/share/gc/z/zWorkers.inline.hpp | 3 +- .../interpreter/zero/bytecodeInterpreter.cpp | 3 +- .../chains/pathToGcRootsOperation.cpp | 3 +- .../jfr/support/jfrObjectAllocationSample.cpp | 3 +- .../share/jvmci/jvmciCompilerToVMInit.cpp | 4 +- src/hotspot/share/memory/dynamicArchive.cpp | 3 +- src/hotspot/share/memory/heapShared.hpp | 3 +- .../memory/metaspace/virtualSpaceNode.cpp | 3 +- src/hotspot/share/memory/universe.cpp | 3 +- src/hotspot/share/oops/oop.cpp | 5 +- src/hotspot/share/oops/oop.hpp | 6 +- src/hotspot/share/oops/oop.inline.hpp | 4 +- src/hotspot/share/opto/arraycopynode.cpp | 3 +- src/hotspot/share/opto/lcm.cpp | 3 +- src/hotspot/share/opto/macro.cpp | 3 +- src/hotspot/share/opto/macroArrayCopy.cpp | 3 +- src/hotspot/share/opto/memnode.cpp | 3 +- src/hotspot/share/runtime/arguments.cpp | 1 + src/hotspot/share/runtime/flags/allFlags.hpp | 13 ++- src/hotspot/share/runtime/globals.hpp | 1 - .../share/runtime/interfaceSupport.inline.hpp | 3 +- src/hotspot/share/runtime/mutexLocker.cpp | 3 +- src/hotspot/share/runtime/thread.cpp | 10 +- src/hotspot/share/runtime/thread.hpp | 8 +- src/hotspot/share/runtime/thread.inline.hpp | 4 +- .../share/runtime/threadSMR.inline.hpp | 4 +- test/hotspot/gtest/runtime/test_globals.cpp | 3 +- 127 files changed, 375 insertions(+), 192 deletions(-) create mode 100644 src/hotspot/share/gc/shared/tlab_globals.hpp diff --git a/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp index 19d20dde9a449..79e6e7f2e1786 100644 --- a/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, 2020, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -36,6 +36,7 @@ #include "ci/ciInstance.hpp" #include "code/compiledIC.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "nativeInst_aarch64.hpp" #include "oops/objArrayKlass.hpp" #include "runtime/frame.inline.hpp" diff --git a/src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp index 48759ca7122c8..535312a94f162 100644 --- a/src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -29,6 +29,7 @@ #include "classfile/systemDictionary.hpp" #include "gc/shared/barrierSetAssembler.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "oops/arrayOop.hpp" #include "oops/markWord.hpp" diff --git a/src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp b/src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp index 2126695d673b9..dcf7351493591 100644 --- a/src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -32,6 +32,7 @@ #include "compiler/disassembler.hpp" #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/universe.hpp" #include "nativeInst_aarch64.hpp" diff --git a/src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp index 30dfa5df55c55..9c0a66b255adc 100644 --- a/src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" #include "gc/shared/cardTableBarrierSetAssembler.hpp" +#include "gc/shared/gc_globals.hpp" #include "interpreter/interp_masm.hpp" #define __ masm-> diff --git a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp index d887717913836..6aa6d41fee7c5 100644 --- a/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zGlobals.hpp" #include "runtime/globals.hpp" #include "runtime/os.hpp" diff --git a/src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad b/src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad index f88deb84d4c6d..bd1c2cc9f938a 100644 --- a/src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad +++ b/src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad @@ -1,5 +1,5 @@ // -// Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. +// Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. // DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. // // This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ source_hpp %{ +#include "gc/shared/gc_globals.hpp" #include "gc/z/c2/zBarrierSetC2.hpp" #include "gc/z/zThreadLocalData.hpp" diff --git a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp index 7de5f870f51ba..423eb12cd4d57 100644 --- a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, 2020, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -33,6 +33,7 @@ #include "gc/shared/cardTable.hpp" #include "gc/shared/barrierSetAssembler.hpp" #include "gc/shared/cardTableBarrierSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "compiler/disassembler.hpp" #include "memory/resourceArea.hpp" diff --git a/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp b/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp index 6bb9ca308d535..afbeb39c96b0a 100644 --- a/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, 2020, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -28,6 +28,8 @@ #include "asm/macroAssembler.inline.hpp" #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetAssembler.hpp" +#include "gc/shared/gc_globals.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/universe.hpp" #include "nativeInst_aarch64.hpp" diff --git a/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp b/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp index 79e1971edde04..2179f91f5ae7b 100644 --- a/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, Red Hat Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -26,6 +26,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.inline.hpp" #include "gc/shared/barrierSetAssembler.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/interpreterRuntime.hpp" #include "interpreter/interp_masm.hpp" diff --git a/src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp b/src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp index 9d5c82dceb9f1..40956f09dc7ae 100644 --- a/src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp +++ b/src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ #include "c1/c1_Runtime1.hpp" #include "classfile/systemDictionary.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "oops/arrayOop.hpp" #include "oops/markWord.hpp" diff --git a/src/hotspot/cpu/arm/c1_Runtime1_arm.cpp b/src/hotspot/cpu/arm/c1_Runtime1_arm.cpp index f823660fa2565..ce928e9bcfdbf 100644 --- a/src/hotspot/cpu/arm/c1_Runtime1_arm.cpp +++ b/src/hotspot/cpu/arm/c1_Runtime1_arm.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -31,6 +31,7 @@ #include "ci/ciUtilities.hpp" #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/universe.hpp" #include "nativeInst_arm.hpp" diff --git a/src/hotspot/cpu/arm/templateTable_arm.cpp b/src/hotspot/cpu/arm/templateTable_arm.cpp index ccfd7a6f166b2..a09324f777a2e 100644 --- a/src/hotspot/cpu/arm/templateTable_arm.cpp +++ b/src/hotspot/cpu/arm/templateTable_arm.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.inline.hpp" #include "gc/shared/barrierSetAssembler.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interp_masm.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/interpreterRuntime.hpp" diff --git a/src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp b/src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp index 1dd18861dea95..aa31a26d7b3ea 100644 --- a/src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp +++ b/src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2012, 2018 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -29,6 +29,7 @@ #include "c1/c1_Runtime1.hpp" #include "classfile/systemDictionary.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "oops/arrayOop.hpp" #include "oops/markWord.hpp" diff --git a/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp b/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp index 0e2e1c29135d7..2d67de784b955 100644 --- a/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp +++ b/src/hotspot/cpu/ppc/templateTable_ppc_64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2013, 2020 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -26,6 +26,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.inline.hpp" #include "gc/shared/barrierSetAssembler.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/interpreterRuntime.hpp" #include "interpreter/interp_masm.hpp" diff --git a/src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp b/src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp index 6c040e0bbcbac..003ee3c376fcb 100644 --- a/src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp +++ b/src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2016 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -29,6 +29,7 @@ #include "c1/c1_Runtime1.hpp" #include "classfile/systemDictionary.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "oops/arrayOop.hpp" #include "oops/markWord.hpp" diff --git a/src/hotspot/cpu/s390/templateTable_s390.cpp b/src/hotspot/cpu/s390/templateTable_s390.cpp index 485d6d962e898..8e9e9163e064e 100644 --- a/src/hotspot/cpu/s390/templateTable_s390.cpp +++ b/src/hotspot/cpu/s390/templateTable_s390.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2016, 2020 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -26,6 +26,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.inline.hpp" #include "gc/shared/barrierSetAssembler.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/interpreterRuntime.hpp" #include "interpreter/interp_masm.hpp" diff --git a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp index 8caff08e52fb3..e32e882e60f8d 100644 --- a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp +++ b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,6 +34,7 @@ #include "ci/ciArrayKlass.hpp" #include "ci/ciInstance.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "nativeInst_x86.hpp" #include "oops/objArrayKlass.hpp" #include "runtime/frame.inline.hpp" diff --git a/src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp b/src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp index 687a33b253e39..1ef26701ac14a 100644 --- a/src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp +++ b/src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,6 +29,7 @@ #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetAssembler.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "oops/arrayOop.hpp" #include "oops/markWord.hpp" diff --git a/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp b/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp index 90b5b0ff913e6..b9ac8274acf97 100644 --- a/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp +++ b/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,6 +30,7 @@ #include "ci/ciUtilities.hpp" #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/universe.hpp" #include "nativeInst_x86.hpp" diff --git a/src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp b/src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp index eb0717f2c30a3..c00ea223f00dc 100644 --- a/src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp +++ b/src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" #include "gc/shared/cardTableBarrierSetAssembler.hpp" +#include "gc/shared/gc_globals.hpp" #define __ masm-> diff --git a/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp b/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp index 65599ccddf641..64ccaa8c15ad5 100644 --- a/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp +++ b/src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "c1/c1_LIRAssembler.hpp" #include "c1/c1_MacroAssembler.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shenandoah/shenandoahBarrierSet.hpp" #include "gc/shenandoah/shenandoahBarrierSetAssembler.hpp" #include "gc/shenandoah/c1/shenandoahBarrierSetC1.hpp" diff --git a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp index 896bcb1ac1611..875eb8855ddca 100644 --- a/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp +++ b/src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zGlobals.hpp" #include "runtime/globals.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad index b7d63e2439b25..f3e19b41733fd 100644 --- a/src/hotspot/cpu/x86/gc/z/z_x86_64.ad +++ b/src/hotspot/cpu/x86/gc/z/z_x86_64.ad @@ -1,5 +1,5 @@ // -// Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. +// Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. // DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. // // This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ source_hpp %{ +#include "gc/shared/gc_globals.hpp" #include "gc/z/c2/zBarrierSetC2.hpp" #include "gc/z/zThreadLocalData.hpp" diff --git a/src/hotspot/cpu/x86/macroAssembler_x86.cpp b/src/hotspot/cpu/x86/macroAssembler_x86.cpp index f1000eb32397d..b6371fab853b4 100644 --- a/src/hotspot/cpu/x86/macroAssembler_x86.cpp +++ b/src/hotspot/cpu/x86/macroAssembler_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -31,6 +31,7 @@ #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetAssembler.hpp" #include "gc/shared/collectedHeap.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/resourceArea.hpp" #include "memory/universe.hpp" diff --git a/src/hotspot/cpu/x86/stubGenerator_x86_64.cpp b/src/hotspot/cpu/x86/stubGenerator_x86_64.cpp index 7cd48bd9583ec..be8377cde0d70 100644 --- a/src/hotspot/cpu/x86/stubGenerator_x86_64.cpp +++ b/src/hotspot/cpu/x86/stubGenerator_x86_64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,6 +29,7 @@ #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetAssembler.hpp" #include "gc/shared/barrierSetNMethod.hpp" +#include "gc/shared/gc_globals.hpp" #include "interpreter/interpreter.hpp" #include "memory/universe.hpp" #include "nativeInst_x86.hpp" diff --git a/src/hotspot/cpu/x86/templateTable_x86.cpp b/src/hotspot/cpu/x86/templateTable_x86.cpp index 95e0cd89c4440..13a895375238c 100644 --- a/src/hotspot/cpu/x86/templateTable_x86.cpp +++ b/src/hotspot/cpu/x86/templateTable_x86.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.hpp" #include "compiler/disassembler.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/interpreterRuntime.hpp" #include "interpreter/interp_masm.hpp" diff --git a/src/hotspot/share/aot/aotCodeHeap.cpp b/src/hotspot/share/aot/aotCodeHeap.cpp index fb60aa73e27e9..d5e124137c84a 100644 --- a/src/hotspot/share/aot/aotCodeHeap.cpp +++ b/src/hotspot/share/aot/aotCodeHeap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,8 +22,6 @@ */ #include "precompiled.hpp" -#include "runtime/stubRoutines.hpp" - #include "aot/aotCodeHeap.hpp" #include "aot/aotLoader.hpp" #include "ci/ciUtilities.inline.hpp" @@ -32,6 +30,7 @@ #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" #include "gc/shared/gcConfig.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/g1/heapRegion.hpp" #include "interpreter/abstractInterpreter.hpp" #include "jvmci/compilerRuntime.hpp" @@ -49,6 +48,7 @@ #include "runtime/java.hpp" #include "runtime/safepointVerifiers.hpp" #include "runtime/sharedRuntime.hpp" +#include "runtime/stubRoutines.hpp" #include "runtime/vmOperations.hpp" #include "utilities/powerOfTwo.hpp" #include "utilities/sizes.hpp" diff --git a/src/hotspot/share/gc/epsilon/epsilonArguments.cpp b/src/hotspot/share/gc/epsilon/epsilonArguments.cpp index 17cac8d86bf7a..d80154bcaddca 100644 --- a/src/hotspot/share/gc/epsilon/epsilonArguments.cpp +++ b/src/hotspot/share/gc/epsilon/epsilonArguments.cpp @@ -26,6 +26,7 @@ #include "gc/epsilon/epsilonArguments.hpp" #include "gc/epsilon/epsilonHeap.hpp" #include "gc/shared/gcArguments.hpp" +#include "gc/shared/tlab_globals.hpp" #include "runtime/globals.hpp" #include "runtime/globals_extension.hpp" #include "utilities/macros.hpp" diff --git a/src/hotspot/share/gc/epsilon/epsilonInitLogger.cpp b/src/hotspot/share/gc/epsilon/epsilonInitLogger.cpp index 1006e848b5db4..a75e9e7679da7 100644 --- a/src/hotspot/share/gc/epsilon/epsilonInitLogger.cpp +++ b/src/hotspot/share/gc/epsilon/epsilonInitLogger.cpp @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/epsilon/epsilonHeap.hpp" #include "gc/epsilon/epsilonInitLogger.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "runtime/globals.hpp" #include "runtime/globals_extension.hpp" diff --git a/src/hotspot/share/gc/epsilon/epsilonThreadLocalData.hpp b/src/hotspot/share/gc/epsilon/epsilonThreadLocalData.hpp index 24f1e987d4a6b..3c0a2ab067806 100644 --- a/src/hotspot/share/gc/epsilon/epsilonThreadLocalData.hpp +++ b/src/hotspot/share/gc/epsilon/epsilonThreadLocalData.hpp @@ -25,6 +25,7 @@ #ifndef SHARE_GC_EPSILON_EPSILONTHREADLOCALDATA_HPP #define SHARE_GC_EPSILON_EPSILONTHREADLOCALDATA_HPP +#include "gc/shared/gc_globals.hpp" #include "runtime/thread.hpp" #include "utilities/debug.hpp" diff --git a/src/hotspot/share/gc/g1/g1AllocRegion.cpp b/src/hotspot/share/gc/g1/g1AllocRegion.cpp index a45a11358b244..b3834c96c065a 100644 --- a/src/hotspot/share/gc/g1/g1AllocRegion.cpp +++ b/src/hotspot/share/gc/g1/g1AllocRegion.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #include "gc/g1/g1AllocRegion.inline.hpp" #include "gc/g1/g1EvacStats.inline.hpp" #include "gc/g1/g1CollectedHeap.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/resourceArea.hpp" diff --git a/src/hotspot/share/gc/g1/g1Allocator.cpp b/src/hotspot/share/gc/g1/g1Allocator.cpp index 1bf55c51579fc..6b93b0cc84b57 100644 --- a/src/hotspot/share/gc/g1/g1Allocator.cpp +++ b/src/hotspot/share/gc/g1/g1Allocator.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -33,6 +33,7 @@ #include "gc/g1/heapRegion.inline.hpp" #include "gc/g1/heapRegionSet.inline.hpp" #include "gc/g1/heapRegionType.hpp" +#include "gc/shared/tlab_globals.hpp" #include "utilities/align.hpp" G1Allocator::G1Allocator(G1CollectedHeap* heap) : diff --git a/src/hotspot/share/gc/g1/g1Analytics.cpp b/src/hotspot/share/gc/g1/g1Analytics.cpp index db8c1384fb452..537224853fa62 100644 --- a/src/hotspot/share/gc/g1/g1Analytics.cpp +++ b/src/hotspot/share/gc/g1/g1Analytics.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/g1/g1Analytics.hpp" #include "gc/g1/g1Predictions.hpp" +#include "gc/shared/gc_globals.hpp" #include "runtime/globals.hpp" #include "runtime/os.hpp" #include "utilities/debug.hpp" diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp index 43b969df45c54..379ab145d0e8d 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -86,6 +86,7 @@ #include "gc/shared/referenceProcessor.inline.hpp" #include "gc/shared/taskTerminator.hpp" #include "gc/shared/taskqueue.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/weakProcessor.inline.hpp" #include "gc/shared/workerPolicy.hpp" #include "logging/log.hpp" diff --git a/src/hotspot/share/gc/g1/g1EvacStats.cpp b/src/hotspot/share/gc/g1/g1EvacStats.cpp index 42b57de220a87..f8acabf6be658 100644 --- a/src/hotspot/share/gc/g1/g1EvacStats.cpp +++ b/src/hotspot/share/gc/g1/g1EvacStats.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/g1/g1EvacStats.hpp" #include "gc/shared/gcId.hpp" +#include "gc/shared/gc_globals.hpp" #include "logging/log.hpp" #include "memory/allocation.inline.hpp" #include "runtime/globals.hpp" diff --git a/src/hotspot/share/gc/g1/g1FromCardCache.cpp b/src/hotspot/share/gc/g1/g1FromCardCache.cpp index e677f04e6de6b..0a566af9d13e0 100644 --- a/src/hotspot/share/gc/g1/g1FromCardCache.cpp +++ b/src/hotspot/share/gc/g1/g1FromCardCache.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #include "gc/g1/g1ConcurrentRefine.hpp" #include "gc/g1/g1DirtyCardQueue.hpp" #include "gc/g1/g1FromCardCache.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/padded.inline.hpp" #include "runtime/globals.hpp" #include "utilities/debug.hpp" diff --git a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp index 9ff4d0887fed4..1cefd9cce673b 100644 --- a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp +++ b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -31,6 +31,7 @@ #include "gc/g1/g1StringDedup.hpp" #include "gc/shared/gcTimer.hpp" #include "gc/shared/oopStorage.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/workerDataArray.inline.hpp" #include "memory/resourceArea.hpp" #include "logging/log.hpp" diff --git a/src/hotspot/share/gc/g1/g1HeapVerifier.cpp b/src/hotspot/share/gc/g1/g1HeapVerifier.cpp index 80d49da1667d9..84b76c7ba4dbe 100644 --- a/src/hotspot/share/gc/g1/g1HeapVerifier.cpp +++ b/src/hotspot/share/gc/g1/g1HeapVerifier.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,6 +34,7 @@ #include "gc/g1/heapRegion.inline.hpp" #include "gc/g1/heapRegionRemSet.hpp" #include "gc/g1/g1StringDedup.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/iterator.inline.hpp" diff --git a/src/hotspot/share/gc/g1/g1InitLogger.cpp b/src/hotspot/share/gc/g1/g1InitLogger.cpp index 6a6fd14657cdf..2f5753f9ff6a5 100644 --- a/src/hotspot/share/gc/g1/g1InitLogger.cpp +++ b/src/hotspot/share/gc/g1/g1InitLogger.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/g1/g1InitLogger.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "runtime/globals.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/gc/g1/g1ThreadLocalData.hpp b/src/hotspot/share/gc/g1/g1ThreadLocalData.hpp index 4a23b0eb7203e..d531f8ac56a3e 100644 --- a/src/hotspot/share/gc/g1/g1ThreadLocalData.hpp +++ b/src/hotspot/share/gc/g1/g1ThreadLocalData.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #include "gc/g1/g1BarrierSet.hpp" #include "gc/g1/g1DirtyCardQueue.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/satbMarkQueue.hpp" #include "runtime/thread.hpp" #include "utilities/debug.hpp" diff --git a/src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.cpp b/src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.cpp index e951014fd965c..8630f57a7a768 100644 --- a/src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.cpp +++ b/src/hotspot/share/gc/parallel/jvmFlagConstraintsParallel.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/parallel/jvmFlagConstraintsParallel.hpp" +#include "gc/shared/gc_globals.hpp" #include "runtime/globals.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/gc/parallel/mutableNUMASpace.cpp b/src/hotspot/share/gc/parallel/mutableNUMASpace.cpp index ce7b215265912..271b39ff0e99a 100644 --- a/src/hotspot/share/gc/parallel/mutableNUMASpace.cpp +++ b/src/hotspot/share/gc/parallel/mutableNUMASpace.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/parallel/mutableNUMASpace.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/spaceDecorator.hpp" #include "gc/shared/workgroup.hpp" #include "memory/allocation.inline.hpp" diff --git a/src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp b/src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp index d97694466d53e..be8ddd55a6eda 100644 --- a/src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp +++ b/src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -32,6 +32,7 @@ #include "gc/parallel/psPromotionManager.hpp" #include "gc/parallel/psScavenge.inline.hpp" #include "gc/shared/taskqueue.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "memory/iterator.inline.hpp" #include "oops/access.inline.hpp" diff --git a/src/hotspot/share/gc/serial/defNewGeneration.hpp b/src/hotspot/share/gc/serial/defNewGeneration.hpp index 139d8d5449841..ac8d834782a2c 100644 --- a/src/hotspot/share/gc/serial/defNewGeneration.hpp +++ b/src/hotspot/share/gc/serial/defNewGeneration.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -31,6 +31,7 @@ #include "gc/shared/generation.hpp" #include "gc/shared/generationCounters.hpp" #include "gc/shared/preservedMarks.hpp" +#include "gc/shared/tlab_globals.hpp" #include "utilities/align.hpp" #include "utilities/stack.hpp" diff --git a/src/hotspot/share/gc/serial/markSweep.cpp b/src/hotspot/share/gc/serial/markSweep.cpp index 5ed5df58a5c6e..ca8a9fe80a4be 100644 --- a/src/hotspot/share/gc/serial/markSweep.cpp +++ b/src/hotspot/share/gc/serial/markSweep.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "gc/shared/collectedHeap.inline.hpp" #include "gc/shared/gcTimer.hpp" #include "gc/shared/gcTrace.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/iterator.inline.hpp" #include "memory/universe.hpp" #include "oops/access.inline.hpp" diff --git a/src/hotspot/share/gc/shared/ageTable.cpp b/src/hotspot/share/gc/shared/ageTable.cpp index d09139c2efc80..cefa8a5223db5 100644 --- a/src/hotspot/share/gc/shared/ageTable.cpp +++ b/src/hotspot/share/gc/shared/ageTable.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,12 +27,13 @@ #include "gc/shared/ageTable.inline.hpp" #include "gc/shared/ageTableTracer.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/resourceArea.hpp" #include "logging/log.hpp" #include "oops/oop.inline.hpp" #include "utilities/copy.hpp" -/* Copyright (c) 1992, 2016, Oracle and/or its affiliates, and Stanford University. +/* Copyright (c) 1992, 2021, Oracle and/or its affiliates, and Stanford University. See the LICENSE file for license information. */ AgeTable::AgeTable(bool global) { diff --git a/src/hotspot/share/gc/shared/blockOffsetTable.hpp b/src/hotspot/share/gc/shared/blockOffsetTable.hpp index 6383000192cbf..f7db2d47d77f1 100644 --- a/src/hotspot/share/gc/shared/blockOffsetTable.hpp +++ b/src/hotspot/share/gc/shared/blockOffsetTable.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #ifndef SHARE_GC_SHARED_BLOCKOFFSETTABLE_HPP #define SHARE_GC_SHARED_BLOCKOFFSETTABLE_HPP +#include "gc/shared/gc_globals.hpp" #include "gc/shared/memset_with_concurrent_readers.hpp" #include "memory/allocation.hpp" #include "memory/memRegion.hpp" diff --git a/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp b/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp index 5909d442b959b..106412d90b48a 100644 --- a/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp +++ b/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #include "gc/shared/c1/cardTableBarrierSetC1.hpp" #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" +#include "gc/shared/gc_globals.hpp" #include "utilities/macros.hpp" #ifdef ASSERT diff --git a/src/hotspot/share/gc/shared/c2/barrierSetC2.cpp b/src/hotspot/share/gc/shared/c2/barrierSetC2.cpp index 377391e24aa91..f06c4d460aed2 100644 --- a/src/hotspot/share/gc/shared/c2/barrierSetC2.cpp +++ b/src/hotspot/share/gc/shared/c2/barrierSetC2.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/c2/barrierSetC2.hpp" #include "opto/arraycopynode.hpp" #include "opto/convertnode.hpp" diff --git a/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp b/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp index 3b59faddce565..b39bec32ecd84 100644 --- a/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp +++ b/src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ #include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" #include "gc/shared/c2/cardTableBarrierSetC2.hpp" +#include "gc/shared/gc_globals.hpp" #include "opto/arraycopynode.hpp" #include "opto/graphKit.hpp" #include "opto/idealKit.hpp" diff --git a/src/hotspot/share/gc/shared/collectedHeap.cpp b/src/hotspot/share/gc/shared/collectedHeap.cpp index dd3c5e273168b..1e1160ab54e20 100644 --- a/src/hotspot/share/gc/shared/collectedHeap.cpp +++ b/src/hotspot/share/gc/shared/collectedHeap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -34,7 +34,9 @@ #include "gc/shared/gcTraceTime.inline.hpp" #include "gc/shared/gcVMOperations.hpp" #include "gc/shared/gcWhen.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/memAllocator.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/classLoaderMetaspace.hpp" diff --git a/src/hotspot/share/gc/shared/gcConfiguration.cpp b/src/hotspot/share/gc/shared/gcConfiguration.cpp index 195b64dcc3c94..9a26adf9b2f4c 100644 --- a/src/hotspot/share/gc/shared/gcConfiguration.cpp +++ b/src/hotspot/share/gc/shared/gcConfiguration.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,15 +22,15 @@ * */ #include "precompiled.hpp" -#include "runtime/globals_extension.hpp" - #include "gc/shared/collectedHeap.hpp" #include "gc/shared/gcArguments.hpp" #include "gc/shared/gcConfiguration.hpp" +#include "gc/shared/tlab_globals.hpp" #include "memory/universe.hpp" #include "oops/compressedOops.hpp" #include "runtime/arguments.hpp" #include "runtime/globals.hpp" +#include "runtime/globals_extension.hpp" #include "utilities/debug.hpp" GCName GCConfiguration::young_collector() const { diff --git a/src/hotspot/share/gc/shared/gcInitLogger.cpp b/src/hotspot/share/gc/shared/gcInitLogger.cpp index 106304890df0e..ec9bd60a83faa 100644 --- a/src/hotspot/share/gc/shared/gcInitLogger.cpp +++ b/src/hotspot/share/gc/shared/gcInitLogger.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/shared/gcInitLogger.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "logging/log.hpp" #include "oops/compressedOops.hpp" #include "runtime/globals.hpp" diff --git a/src/hotspot/share/gc/shared/gcOverheadChecker.hpp b/src/hotspot/share/gc/shared/gcOverheadChecker.hpp index 28cb799ec35f6..52e51d5809ce0 100644 --- a/src/hotspot/share/gc/shared/gcOverheadChecker.hpp +++ b/src/hotspot/share/gc/shared/gcOverheadChecker.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2019, Google and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -28,6 +28,7 @@ #include "memory/allocation.hpp" #include "gc/shared/gcCause.hpp" +#include "gc/shared/gc_globals.hpp" #include "runtime/globals.hpp" class SoftRefPolicy; diff --git a/src/hotspot/share/gc/shared/gcPolicyCounters.cpp b/src/hotspot/share/gc/shared/gcPolicyCounters.cpp index b6ce0afcf11c5..dba53e9ee3193 100644 --- a/src/hotspot/share/gc/shared/gcPolicyCounters.cpp +++ b/src/hotspot/share/gc/shared/gcPolicyCounters.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/gcPolicyCounters.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/resourceArea.hpp" GCPolicyCounters::GCPolicyCounters(const char* name, int collectors, diff --git a/src/hotspot/share/gc/shared/gcStats.cpp b/src/hotspot/share/gc/shared/gcStats.cpp index 55514d91fd0dd..a90f0f01a5cb4 100644 --- a/src/hotspot/share/gc/shared/gcStats.cpp +++ b/src/hotspot/share/gc/shared/gcStats.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,5 +25,6 @@ #include "precompiled.hpp" #include "gc/shared/gcStats.hpp" #include "gc/shared/gcUtil.inline.hpp" +#include "gc/shared/gc_globals.hpp" GCStats::GCStats() : _avg_promoted(new AdaptivePaddedNoZeroDevAverage(AdaptiveSizePolicyWeight, PromotedPadding)) {} diff --git a/src/hotspot/share/gc/shared/gcVMOperations.cpp b/src/hotspot/share/gc/shared/gcVMOperations.cpp index d5fd095cf850c..cee546b267bb4 100644 --- a/src/hotspot/share/gc/shared/gcVMOperations.cpp +++ b/src/hotspot/share/gc/shared/gcVMOperations.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,6 +29,7 @@ #include "gc/shared/gcId.hpp" #include "gc/shared/gcLocker.hpp" #include "gc/shared/gcVMOperations.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/genCollectedHeap.hpp" #include "interpreter/oopMapCache.hpp" #include "logging/log.hpp" diff --git a/src/hotspot/share/gc/shared/gc_globals.hpp b/src/hotspot/share/gc/shared/gc_globals.hpp index cc8372221a7f5..402409161a8ea 100644 --- a/src/hotspot/share/gc/shared/gc_globals.hpp +++ b/src/hotspot/share/gc/shared/gc_globals.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -290,18 +290,6 @@ develop(uintx, MetadataAllocationFailALotInterval, 1000, \ "Metadata allocation failure a lot interval") \ \ - product(bool, UseTLAB, true, \ - "Use thread-local object allocation") \ - \ - product(bool, ResizeTLAB, true, \ - "Dynamically resize TLAB size for threads") \ - \ - product(bool, ZeroTLAB, false, \ - "Zero out the newly created TLAB") \ - \ - product(bool, TLABStats, true, \ - "Provide more detailed and expensive TLAB statistics.") \ - \ product_pd(bool, NeverActAsServerClassMachine, \ "Never act like a server-class machine") \ \ @@ -634,42 +622,6 @@ "generation; zero means no maximum") \ range(0, max_uintx) \ \ - product(size_t, MinTLABSize, 2*K, \ - "Minimum allowed TLAB size (in bytes)") \ - range(1, max_uintx/2) \ - constraint(MinTLABSizeConstraintFunc,AfterMemoryInit) \ - \ - product(size_t, TLABSize, 0, \ - "Starting TLAB size (in bytes); zero means set ergonomically") \ - constraint(TLABSizeConstraintFunc,AfterMemoryInit) \ - \ - product(size_t, YoungPLABSize, 4096, \ - "Size of young gen promotion LAB's (in HeapWords)") \ - constraint(YoungPLABSizeConstraintFunc,AfterMemoryInit) \ - \ - product(size_t, OldPLABSize, 1024, \ - "Size of old gen promotion LAB's (in HeapWords)") \ - constraint(OldPLABSizeConstraintFunc,AfterMemoryInit) \ - \ - product(uintx, TLABAllocationWeight, 35, \ - "Allocation averaging weight") \ - range(0, 100) \ - \ - /* Limit the lower bound of this flag to 1 as it is used */ \ - /* in a division expression. */ \ - product(uintx, TLABWasteTargetPercent, 1, \ - "Percentage of Eden that can be wasted") \ - range(1, 100) \ - \ - product(uintx, TLABRefillWasteFraction, 64, \ - "Maximum TLAB waste at a refill (internal fragmentation)") \ - range(1, max_juint) \ - \ - product(uintx, TLABWasteIncrement, 4, \ - "Increment allowed waste at slow allocation") \ - range(0, max_jint) \ - constraint(TLABWasteIncrementConstraintFunc,AfterMemoryInit) \ - \ product(uintx, SurvivorRatio, 8, \ "Ratio of eden/survivor space size") \ range(1, max_uintx-2) \ diff --git a/src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp b/src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp index 70043c430b4e5..83f0f8e43ca93 100644 --- a/src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp +++ b/src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,6 +30,7 @@ #include "gc/shared/jvmFlagConstraintsGC.hpp" #include "gc/shared/plab.hpp" #include "gc/shared/threadLocalAllocBuffer.hpp" +#include "gc/shared/tlab_globals.hpp" #include "runtime/arguments.hpp" #include "runtime/globals.hpp" #include "runtime/globals_extension.hpp" diff --git a/src/hotspot/share/gc/shared/memAllocator.cpp b/src/hotspot/share/gc/shared/memAllocator.cpp index f35a29334c529..73c77a43d6fbf 100644 --- a/src/hotspot/share/gc/shared/memAllocator.cpp +++ b/src/hotspot/share/gc/shared/memAllocator.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "gc/shared/collectedHeap.hpp" #include "gc/shared/memAllocator.hpp" #include "gc/shared/threadLocalAllocBuffer.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "memory/universe.hpp" #include "oops/arrayOop.hpp" #include "oops/oop.inline.hpp" diff --git a/src/hotspot/share/gc/shared/plab.cpp b/src/hotspot/share/gc/shared/plab.cpp index e1a3c2b181209..ccfb8760f2344 100644 --- a/src/hotspot/share/gc/shared/plab.cpp +++ b/src/hotspot/share/gc/shared/plab.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,8 +24,10 @@ #include "precompiled.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/plab.inline.hpp" #include "gc/shared/threadLocalAllocBuffer.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "memory/universe.hpp" #include "oops/oop.inline.hpp" diff --git a/src/hotspot/share/gc/shared/pretouchTask.cpp b/src/hotspot/share/gc/shared/pretouchTask.cpp index 4398d3924cc11..d802e827fe370 100644 --- a/src/hotspot/share/gc/shared/pretouchTask.cpp +++ b/src/hotspot/share/gc/shared/pretouchTask.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/pretouchTask.hpp" #include "runtime/atomic.hpp" #include "runtime/globals.hpp" diff --git a/src/hotspot/share/gc/shared/referencePolicy.cpp b/src/hotspot/share/gc/shared/referencePolicy.cpp index 795a5379b6ac6..e3d9e81a8d1fb 100644 --- a/src/hotspot/share/gc/shared/referencePolicy.cpp +++ b/src/hotspot/share/gc/shared/referencePolicy.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "classfile/javaClasses.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/referencePolicy.hpp" #include "memory/universe.hpp" #include "runtime/arguments.hpp" diff --git a/src/hotspot/share/gc/shared/referenceProcessor.cpp b/src/hotspot/share/gc/shared/referenceProcessor.cpp index 394b3741c21a9..c4ba975cfeacf 100644 --- a/src/hotspot/share/gc/shared/referenceProcessor.cpp +++ b/src/hotspot/share/gc/shared/referenceProcessor.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,6 +29,7 @@ #include "gc/shared/collectedHeap.inline.hpp" #include "gc/shared/gcTimer.hpp" #include "gc/shared/gcTraceTime.inline.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/referencePolicy.hpp" #include "gc/shared/referenceProcessor.inline.hpp" #include "gc/shared/referenceProcessorPhaseTimes.hpp" diff --git a/src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp b/src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp index 5e8ebf54d0183..b1b6a7a15197b 100644 --- a/src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp +++ b/src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "classfile/altHashing.hpp" #include "classfile/javaClasses.inline.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/stringdedup/stringDedup.hpp" #include "gc/shared/stringdedup/stringDedupTable.hpp" #include "gc/shared/suspendibleThreadSet.hpp" diff --git a/src/hotspot/share/gc/shared/suspendibleThreadSet.cpp b/src/hotspot/share/gc/shared/suspendibleThreadSet.cpp index cc77435124105..e91b1b4980209 100644 --- a/src/hotspot/share/gc/shared/suspendibleThreadSet.cpp +++ b/src/hotspot/share/gc/shared/suspendibleThreadSet.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/suspendibleThreadSet.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/semaphore.hpp" diff --git a/src/hotspot/share/gc/shared/taskTerminator.cpp b/src/hotspot/share/gc/shared/taskTerminator.cpp index 9d84150c56aa2..0bf1bc61d4532 100644 --- a/src/hotspot/share/gc/shared/taskTerminator.cpp +++ b/src/hotspot/share/gc/shared/taskTerminator.cpp @@ -1,6 +1,6 @@ /* - * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved. - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2020, Red Hat, Inc. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,7 +24,7 @@ */ #include "precompiled.hpp" - +#include "gc/shared/gc_globals.hpp" #include "gc/shared/taskTerminator.hpp" #include "gc/shared/taskqueue.hpp" #include "logging/log.hpp" diff --git a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp index 8cda596e31621..19504d96e90c2 100644 --- a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp +++ b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "gc/shared/collectedHeap.hpp" #include "gc/shared/threadLocalAllocBuffer.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "memory/resourceArea.hpp" #include "memory/universe.hpp" @@ -58,6 +59,10 @@ ThreadLocalAllocBuffer::ThreadLocalAllocBuffer() : // do nothing. TLABs must be inited by initialize() calls } +size_t ThreadLocalAllocBuffer::initial_refill_waste_limit() { return desired_size() / TLABRefillWasteFraction; } +size_t ThreadLocalAllocBuffer::min_size() { return align_object_size(MinTLABSize / HeapWordSize) + alignment_reserve(); } +size_t ThreadLocalAllocBuffer::refill_waste_limit_increment() { return TLABWasteIncrement; } + size_t ThreadLocalAllocBuffer::remaining() { if (end() == NULL) { return 0; diff --git a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp index 51d9727085061..a4c38ccd4edca 100644 --- a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp +++ b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -80,7 +80,7 @@ class ThreadLocalAllocBuffer: public CHeapObj { void set_desired_size(size_t desired_size) { _desired_size = desired_size; } void set_refill_waste_limit(size_t waste) { _refill_waste_limit = waste; } - size_t initial_refill_waste_limit() { return desired_size() / TLABRefillWasteFraction; } + size_t initial_refill_waste_limit(); static int target_refills() { return _target_refills; } size_t initial_desired_size(); @@ -113,7 +113,7 @@ class ThreadLocalAllocBuffer: public CHeapObj { public: ThreadLocalAllocBuffer(); - static size_t min_size() { return align_object_size(MinTLABSize / HeapWordSize) + alignment_reserve(); } + static size_t min_size(); static size_t max_size() { assert(_max_size != 0, "max_size not set up"); return _max_size; } static size_t max_size_in_bytes() { return max_size() * BytesPerWord; } static void set_max_size(size_t max_size) { _max_size = max_size; } @@ -171,7 +171,7 @@ class ThreadLocalAllocBuffer: public CHeapObj { void set_back_allocation_end(); void set_sample_end(bool reset_byte_accumulation); - static size_t refill_waste_limit_increment() { return TLABWasteIncrement; } + static size_t refill_waste_limit_increment(); template void addresses_do(T f) { f(&_start); diff --git a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp index 0bef051496e91..bc8991248c02d 100644 --- a/src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp +++ b/src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #define SHARE_GC_SHARED_THREADLOCALALLOCBUFFER_INLINE_HPP #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/threadLocalAllocBuffer.hpp" #include "memory/universe.hpp" #include "logging/log.hpp" diff --git a/src/hotspot/share/gc/shared/tlab_globals.hpp b/src/hotspot/share/gc/shared/tlab_globals.hpp new file mode 100644 index 0000000000000..8ecc5283642ba --- /dev/null +++ b/src/hotspot/share/gc/shared/tlab_globals.hpp @@ -0,0 +1,93 @@ +/* + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + * + */ + +#ifndef SHARE_GC_SHARED_TLAB_GLOBALS_HPP +#define SHARE_GC_SHARED_TLAB_GLOBALS_HPP + +#include "runtime/globals_shared.hpp" + +#define TLAB_FLAGS(develop, \ + develop_pd, \ + product, \ + product_pd, \ + notproduct, \ + range, \ + constraint) \ + \ + /* Thread Local Allocation Buffer */ \ + \ + product(bool, UseTLAB, true, \ + "Use thread-local object allocation") \ + \ + product(bool, ResizeTLAB, true, \ + "Dynamically resize TLAB size for threads") \ + \ + product(bool, ZeroTLAB, false, \ + "Zero out the newly created TLAB") \ + \ + product(bool, TLABStats, true, \ + "Provide more detailed and expensive TLAB statistics.") \ + \ + product(size_t, MinTLABSize, 2*K, \ + "Minimum allowed TLAB size (in bytes)") \ + range(1, max_uintx/2) \ + constraint(MinTLABSizeConstraintFunc,AfterMemoryInit) \ + \ + product(size_t, TLABSize, 0, \ + "Starting TLAB size (in bytes); zero means set ergonomically") \ + constraint(TLABSizeConstraintFunc,AfterMemoryInit) \ + \ + product(size_t, YoungPLABSize, 4096, \ + "Size of young gen promotion LAB's (in HeapWords)") \ + constraint(YoungPLABSizeConstraintFunc,AfterMemoryInit) \ + \ + product(size_t, OldPLABSize, 1024, \ + "Size of old gen promotion LAB's (in HeapWords)") \ + constraint(OldPLABSizeConstraintFunc,AfterMemoryInit) \ + \ + product(uintx, TLABAllocationWeight, 35, \ + "Allocation averaging weight") \ + range(0, 100) \ + \ + /* Limit the lower bound of this flag to 1 as it is used */ \ + /* in a division expression. */ \ + product(uintx, TLABWasteTargetPercent, 1, \ + "Percentage of Eden that can be wasted") \ + range(1, 100) \ + \ + product(uintx, TLABRefillWasteFraction, 64, \ + "Maximum TLAB waste at a refill (internal fragmentation)") \ + range(1, max_juint) \ + \ + product(uintx, TLABWasteIncrement, 4, \ + "Increment allowed waste at slow allocation") \ + range(0, max_jint) \ + constraint(TLABWasteIncrementConstraintFunc,AfterMemoryInit) \ + \ + +// end of TLAB_FLAGS + +DECLARE_FLAGS(TLAB_FLAGS) + +#endif // SHARE_GC_SHARED_TLAB_GLOBALS_HPP diff --git a/src/hotspot/share/gc/shared/weakProcessor.cpp b/src/hotspot/share/gc/shared/weakProcessor.cpp index 4d1db7e46ad09..f8a6e123682d8 100644 --- a/src/hotspot/share/gc/shared/weakProcessor.cpp +++ b/src/hotspot/share/gc/shared/weakProcessor.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "classfile/stringTable.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/oopStorage.inline.hpp" #include "gc/shared/oopStorageParState.inline.hpp" #include "gc/shared/oopStorageSet.hpp" diff --git a/src/hotspot/share/gc/shared/workerManager.hpp b/src/hotspot/share/gc/shared/workerManager.hpp index 2502506387aad..4ae3920fd25ab 100644 --- a/src/hotspot/share/gc/shared/workerManager.hpp +++ b/src/hotspot/share/gc/shared/workerManager.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #ifndef SHARE_GC_SHARED_WORKERMANAGER_HPP #define SHARE_GC_SHARED_WORKERMANAGER_HPP +#include "gc/shared/gc_globals.hpp" #include "logging/log.hpp" #include "memory/allocation.hpp" #include "runtime/os.hpp" diff --git a/src/hotspot/share/gc/shared/workgroup.cpp b/src/hotspot/share/gc/shared/workgroup.cpp index 6a125af3b36cf..138713ec07eb9 100644 --- a/src/hotspot/share/gc/shared/workgroup.cpp +++ b/src/hotspot/share/gc/shared/workgroup.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -36,6 +36,17 @@ // Definitions of WorkGang methods. +AbstractWorkGang::AbstractWorkGang(const char* name, uint workers, bool are_GC_task_threads, bool are_ConcurrentGC_threads) : + _workers(NULL), + _total_workers(workers), + _active_workers(UseDynamicNumberOfGCThreads ? 1U : workers), + _created_workers(0), + _name(name), + _are_GC_task_threads(are_GC_task_threads), + _are_ConcurrentGC_threads(are_ConcurrentGC_threads) + { } + + // The current implementation will exit if the allocation // of any worker fails. void AbstractWorkGang::initialize_workers() { diff --git a/src/hotspot/share/gc/shared/workgroup.hpp b/src/hotspot/share/gc/shared/workgroup.hpp index da2049a9223a9..9799d3c45f4f7 100644 --- a/src/hotspot/share/gc/shared/workgroup.hpp +++ b/src/hotspot/share/gc/shared/workgroup.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -109,16 +109,7 @@ class AbstractWorkGang : public CHeapObj { } public: - AbstractWorkGang(const char* name, uint workers, bool are_GC_task_threads, bool are_ConcurrentGC_threads) : - _workers(NULL), - _total_workers(workers), - _active_workers(UseDynamicNumberOfGCThreads ? 1U : workers), - _created_workers(0), - _name(name), - _are_GC_task_threads(are_GC_task_threads), - _are_ConcurrentGC_threads(are_ConcurrentGC_threads) - { } - + AbstractWorkGang(const char* name, uint workers, bool are_GC_task_threads, bool are_ConcurrentGC_threads); // Initialize workers in the gang. Return true if initialization succeeded. void initialize_workers(); diff --git a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp index f0733a6fa453d..938a84c29b069 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/gcArguments.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/workerPolicy.hpp" #include "gc/shenandoah/shenandoahArguments.hpp" #include "gc/shenandoah/shenandoahCollectorPolicy.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp b/src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp index bf63bf05a3ef8..2c7ecd69250b4 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp @@ -23,7 +23,7 @@ */ #include "precompiled.hpp" - +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahFreeSet.hpp" #include "gc/shenandoah/shenandoahHeap.inline.hpp" #include "gc/shenandoah/shenandoahHeapRegionSet.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp b/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp index f7d65771034f5..cc0b775129c74 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp @@ -32,6 +32,7 @@ #include "gc/shared/locationPrinter.inline.hpp" #include "gc/shared/memAllocator.hpp" #include "gc/shared/plab.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahBarrierSet.hpp" #include "gc/shenandoah/shenandoahClosures.inline.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp b/src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp index 0891da8336d39..a5c8bb14b839b 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp @@ -29,6 +29,7 @@ #include "gc/shared/markBitMap.inline.hpp" #include "gc/shared/threadLocalAllocBuffer.inline.hpp" #include "gc/shared/suspendibleThreadSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahAsserts.hpp" #include "gc/shenandoah/shenandoahBarrierSet.inline.hpp" #include "gc/shenandoah/shenandoahCollectionSet.inline.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp index 2ba5fa01a1604..6adc450e46c7d 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp @@ -23,13 +23,14 @@ */ #include "precompiled.hpp" -#include "memory/allocation.hpp" +#include "gc/shared/space.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahHeapRegionSet.inline.hpp" #include "gc/shenandoah/shenandoahHeap.inline.hpp" #include "gc/shenandoah/shenandoahHeapRegion.hpp" #include "gc/shenandoah/shenandoahMarkingContext.inline.hpp" -#include "gc/shared/space.inline.hpp" #include "jfr/jfrEvents.hpp" +#include "memory/allocation.hpp" #include "memory/iterator.inline.hpp" #include "memory/resourceArea.hpp" #include "memory/universe.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp index 766ab496c446e..21eaf71dca1eb 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp @@ -25,6 +25,7 @@ #ifndef SHARE_GC_SHENANDOAH_SHENANDOAHHEAPREGION_HPP #define SHARE_GC_SHENANDOAH_SHENANDOAHHEAPREGION_HPP +#include "gc/shared/gc_globals.hpp" #include "gc/shared/spaceDecorator.hpp" #include "gc/shenandoah/shenandoahAllocRequest.hpp" #include "gc/shenandoah/shenandoahAsserts.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp b/src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp index dfdf3fe698c08..22cad0c5f06c4 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp @@ -23,10 +23,10 @@ */ #include "precompiled.hpp" - #include "code/codeCache.hpp" #include "gc/shared/gcTraceTime.inline.hpp" #include "gc/shared/preservedMarks.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahForwarding.inline.hpp" #include "gc/shenandoah/shenandoahConcurrentMark.inline.hpp" #include "gc/shenandoah/shenandoahConcurrentRoots.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp b/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp index 212483510a392..74aab55b94f5d 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp @@ -27,6 +27,7 @@ #include "gc/shared/plab.hpp" #include "gc/shared/gcThreadLocalData.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shenandoah/shenandoahBarrierSet.hpp" #include "gc/shenandoah/shenandoahCodeRoots.hpp" #include "gc/shenandoah/shenandoahSATBMarkQueueSet.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp index 4e4ba4c696d14..5fd3dbfd90ab5 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp @@ -23,7 +23,7 @@ */ #include "precompiled.hpp" - +#include "gc/shared/tlab_globals.hpp" #include "gc/shenandoah/shenandoahAsserts.hpp" #include "gc/shenandoah/shenandoahConcurrentRoots.hpp" #include "gc/shenandoah/shenandoahForwarding.inline.hpp" diff --git a/src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp b/src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp index 867dbc6aa8c7e..2c9c0a8aacc5b 100644 --- a/src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp @@ -24,6 +24,7 @@ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/workerPolicy.hpp" #include "gc/shenandoah/shenandoahWorkerPolicy.hpp" #include "runtime/thread.hpp" diff --git a/src/hotspot/share/gc/z/zAddressSpaceLimit.cpp b/src/hotspot/share/gc/z/zAddressSpaceLimit.cpp index b81d7a29a87e6..518fa07e0d4d5 100644 --- a/src/hotspot/share/gc/z/zAddressSpaceLimit.cpp +++ b/src/hotspot/share/gc/z/zAddressSpaceLimit.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zAddressSpaceLimit.hpp" #include "gc/z/zGlobals.hpp" #include "runtime/globals.hpp" diff --git a/src/hotspot/share/gc/z/zDirector.cpp b/src/hotspot/share/gc/z/zDirector.cpp index 8263d7a6b3e68..1a39d828e5437 100644 --- a/src/hotspot/share/gc/z/zDirector.cpp +++ b/src/hotspot/share/gc/z/zDirector.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zCollectedHeap.hpp" #include "gc/z/zDirector.hpp" #include "gc/z/zHeap.inline.hpp" diff --git a/src/hotspot/share/gc/z/zHeap.cpp b/src/hotspot/share/gc/z/zHeap.cpp index 1e1032e2a856f..89b99181b0f0a 100644 --- a/src/hotspot/share/gc/z/zHeap.cpp +++ b/src/hotspot/share/gc/z/zHeap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "gc/shared/locationPrinter.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/z/zAddress.inline.hpp" #include "gc/z/zArray.inline.hpp" #include "gc/z/zGlobals.hpp" diff --git a/src/hotspot/share/gc/z/zHeapIterator.cpp b/src/hotspot/share/gc/z/zHeapIterator.cpp index 7fdadba7b8528..c95963e2c661f 100644 --- a/src/hotspot/share/gc/z/zHeapIterator.cpp +++ b/src/hotspot/share/gc/z/zHeapIterator.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "classfile/classLoaderData.hpp" #include "gc/shared/barrierSetNMethod.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shared/taskqueue.inline.hpp" #include "gc/z/zAddress.inline.hpp" #include "gc/z/zGlobals.hpp" diff --git a/src/hotspot/share/gc/z/zHeuristics.cpp b/src/hotspot/share/gc/z/zHeuristics.cpp index 6f67c93536771..c6ae14f7604ee 100644 --- a/src/hotspot/share/gc/z/zHeuristics.cpp +++ b/src/hotspot/share/gc/z/zHeuristics.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zCPU.inline.hpp" #include "gc/z/zGlobals.hpp" #include "gc/z/zHeuristics.hpp" diff --git a/src/hotspot/share/gc/z/zMarkStackAllocator.cpp b/src/hotspot/share/gc/z/zMarkStackAllocator.cpp index dbb4e7f4711d1..2c3feabe105f1 100644 --- a/src/hotspot/share/gc/z/zMarkStackAllocator.cpp +++ b/src/hotspot/share/gc/z/zMarkStackAllocator.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zLock.inline.hpp" #include "gc/z/zMarkStack.inline.hpp" #include "gc/z/zMarkStackAllocator.hpp" diff --git a/src/hotspot/share/gc/z/zRelocate.cpp b/src/hotspot/share/gc/z/zRelocate.cpp index f956e2026e345..d3158e52a94aa 100644 --- a/src/hotspot/share/gc/z/zRelocate.cpp +++ b/src/hotspot/share/gc/z/zRelocate.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zAddress.inline.hpp" #include "gc/z/zBarrier.inline.hpp" #include "gc/z/zForwarding.inline.hpp" diff --git a/src/hotspot/share/gc/z/zRelocationSetSelector.cpp b/src/hotspot/share/gc/z/zRelocationSetSelector.cpp index 65d5fc57d3596..04160480fe8d8 100644 --- a/src/hotspot/share/gc/z/zRelocationSetSelector.cpp +++ b/src/hotspot/share/gc/z/zRelocationSetSelector.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zArray.inline.hpp" #include "gc/z/zForwarding.inline.hpp" #include "gc/z/zPage.inline.hpp" diff --git a/src/hotspot/share/gc/z/zRuntimeWorkers.cpp b/src/hotspot/share/gc/z/zRuntimeWorkers.cpp index 27c70b02aadf9..33c2847b5b342 100644 --- a/src/hotspot/share/gc/z/zRuntimeWorkers.cpp +++ b/src/hotspot/share/gc/z/zRuntimeWorkers.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "gc/shared/gcLogPrecious.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zLock.inline.hpp" #include "gc/z/zRuntimeWorkers.hpp" #include "gc/z/zTask.hpp" diff --git a/src/hotspot/share/gc/z/zStat.cpp b/src/hotspot/share/gc/z/zStat.cpp index 7b029cc8b6e21..afba6a9db3095 100644 --- a/src/hotspot/share/gc/z/zStat.cpp +++ b/src/hotspot/share/gc/z/zStat.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zCollectedHeap.hpp" #include "gc/z/zCPU.inline.hpp" #include "gc/z/zGlobals.hpp" diff --git a/src/hotspot/share/gc/z/zThreadLocalAllocBuffer.cpp b/src/hotspot/share/gc/z/zThreadLocalAllocBuffer.cpp index 5fd3a07c78ad4..97ff123412319 100644 --- a/src/hotspot/share/gc/z/zThreadLocalAllocBuffer.cpp +++ b/src/hotspot/share/gc/z/zThreadLocalAllocBuffer.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/z/zAddress.inline.hpp" #include "gc/z/zStackWatermark.hpp" #include "gc/z/zThreadLocalAllocBuffer.hpp" diff --git a/src/hotspot/share/gc/z/zUncommitter.cpp b/src/hotspot/share/gc/z/zUncommitter.cpp index 42fe602ca8bee..27ca4f4c19313 100644 --- a/src/hotspot/share/gc/z/zUncommitter.cpp +++ b/src/hotspot/share/gc/z/zUncommitter.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zHeap.inline.hpp" #include "gc/z/zLock.inline.hpp" #include "gc/z/zStat.hpp" diff --git a/src/hotspot/share/gc/z/zUnmapper.cpp b/src/hotspot/share/gc/z/zUnmapper.cpp index eae5b5dbeab6f..1997449fd5d28 100644 --- a/src/hotspot/share/gc/z/zUnmapper.cpp +++ b/src/hotspot/share/gc/z/zUnmapper.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -22,6 +22,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zList.inline.hpp" #include "gc/z/zLock.inline.hpp" #include "gc/z/zPage.inline.hpp" diff --git a/src/hotspot/share/gc/z/zValue.inline.hpp b/src/hotspot/share/gc/z/zValue.inline.hpp index 587f2976f897f..6e5783048bf28 100644 --- a/src/hotspot/share/gc/z/zValue.inline.hpp +++ b/src/hotspot/share/gc/z/zValue.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #ifndef SHARE_GC_Z_ZVALUE_INLINE_HPP #define SHARE_GC_Z_ZVALUE_INLINE_HPP +#include "gc/shared/gc_globals.hpp" #include "gc/z/zCPU.inline.hpp" #include "gc/z/zGlobals.hpp" #include "gc/z/zNUMA.hpp" diff --git a/src/hotspot/share/gc/z/zVerify.cpp b/src/hotspot/share/gc/z/zVerify.cpp index fc1bff711c712..83cec9c6882c1 100644 --- a/src/hotspot/share/gc/z/zVerify.cpp +++ b/src/hotspot/share/gc/z/zVerify.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "classfile/classLoaderData.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/z/zAddress.inline.hpp" #include "gc/z/zHeap.inline.hpp" #include "gc/z/zNMethod.hpp" diff --git a/src/hotspot/share/gc/z/zWorkers.inline.hpp b/src/hotspot/share/gc/z/zWorkers.inline.hpp index 7b79682e800e7..cdfa7b862d84f 100644 --- a/src/hotspot/share/gc/z/zWorkers.inline.hpp +++ b/src/hotspot/share/gc/z/zWorkers.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #ifndef SHARE_GC_Z_ZWORKERS_INLINE_HPP #define SHARE_GC_Z_ZWORKERS_INLINE_HPP +#include "gc/shared/gc_globals.hpp" #include "gc/z/zWorkers.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp b/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp index 8acab4b13303f..89116d7177406 100644 --- a/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp +++ b/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ #include "classfile/vmSymbols.hpp" #include "gc/shared/collectedHeap.hpp" #include "gc/shared/threadLocalAllocBuffer.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "interpreter/bytecodeHistogram.hpp" #include "interpreter/zero/bytecodeInterpreter.inline.hpp" #include "interpreter/interpreter.hpp" diff --git a/src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp b/src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp index 98f6c907e8c86..7710481dd7fc1 100644 --- a/src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp +++ b/src/hotspot/share/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" #include "jfr/leakprofiler/leakProfiler.hpp" #include "jfr/leakprofiler/chains/bfsClosure.hpp" #include "jfr/leakprofiler/chains/bitset.inline.hpp" diff --git a/src/hotspot/share/jfr/support/jfrObjectAllocationSample.cpp b/src/hotspot/share/jfr/support/jfrObjectAllocationSample.cpp index ae45a8f124f44..412c35229b452 100644 --- a/src/hotspot/share/jfr/support/jfrObjectAllocationSample.cpp +++ b/src/hotspot/share/jfr/support/jfrObjectAllocationSample.cpp @@ -1,5 +1,5 @@ /* -* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. +* Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/threadLocalAllocBuffer.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "jfr/jfrEvents.hpp" #include "jfr/support/jfrObjectAllocationSample.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp index b6300db91306e..55b734156775c 100644 --- a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp +++ b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,8 @@ #include "gc/shared/barrierSet.hpp" #include "gc/shared/cardTable.hpp" #include "gc/shared/collectedHeap.hpp" +#include "gc/shared/gc_globals.hpp" +#include "gc/shared/tlab_globals.hpp" #include "jvmci/jvmciEnv.hpp" #include "jvmci/jvmciCompilerToVM.hpp" #include "jvmci/vmStructs_jvmci.hpp" diff --git a/src/hotspot/share/memory/dynamicArchive.cpp b/src/hotspot/share/memory/dynamicArchive.cpp index a8c357a16d639..1c828f74faa31 100644 --- a/src/hotspot/share/memory/dynamicArchive.cpp +++ b/src/hotspot/share/memory/dynamicArchive.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "classfile/symbolTable.hpp" #include "classfile/systemDictionaryShared.hpp" #include "gc/shared/gcVMOperations.hpp" +#include "gc/shared/gc_globals.hpp" #include "logging/log.hpp" #include "memory/archiveBuilder.hpp" #include "memory/archiveUtils.inline.hpp" diff --git a/src/hotspot/share/memory/heapShared.hpp b/src/hotspot/share/memory/heapShared.hpp index 76861666d2cb3..429613c2af712 100644 --- a/src/hotspot/share/memory/heapShared.hpp +++ b/src/hotspot/share/memory/heapShared.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,6 +28,7 @@ #include "classfile/compactHashtable.hpp" #include "classfile/javaClasses.hpp" #include "classfile/systemDictionary.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/allocation.hpp" #include "memory/metaspaceShared.hpp" #include "oops/compressedOops.hpp" diff --git a/src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp b/src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp index 88a6b9fe27c5d..eb6e45a1b5e1f 100644 --- a/src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp +++ b/src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2018, 2020 SAP SE. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -24,6 +24,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "logging/log.hpp" #include "memory/metaspace.hpp" #include "memory/metaspace/chunkHeaderPool.hpp" diff --git a/src/hotspot/share/memory/universe.cpp b/src/hotspot/share/memory/universe.cpp index 855b1cf9931f5..e69d34ef94acc 100644 --- a/src/hotspot/share/memory/universe.cpp +++ b/src/hotspot/share/memory/universe.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -39,6 +39,7 @@ #include "gc/shared/gcLogPrecious.hpp" #include "gc/shared/gcTraceTime.inline.hpp" #include "gc/shared/oopStorageSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "logging/logStream.hpp" #include "memory/heapShared.hpp" diff --git a/src/hotspot/share/oops/oop.cpp b/src/hotspot/share/oops/oop.cpp index bbea8fd4cd627..c560932b3479f 100644 --- a/src/hotspot/share/oops/oop.cpp +++ b/src/hotspot/share/oops/oop.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -214,4 +214,7 @@ void oopDesc::verify_forwardee(oop forwardee) { "forwarding archive object"); #endif } + +bool oopDesc::get_UseParallelGC() { return UseParallelGC; } +bool oopDesc::get_UseG1GC() { return UseG1GC; } #endif diff --git a/src/hotspot/share/oops/oop.hpp b/src/hotspot/share/oops/oop.hpp index f395d72b3188a..c37d4852e7977 100644 --- a/src/hotspot/share/oops/oop.hpp +++ b/src/hotspot/share/oops/oop.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -311,6 +311,10 @@ class oopDesc { // for error reporting static void* load_klass_raw(oop obj); static void* load_oop_raw(oop obj, int offset); + + // Avoid include gc_globals.hpp in oop.inline.hpp + DEBUG_ONLY(bool get_UseParallelGC();) + DEBUG_ONLY(bool get_UseG1GC();) }; #endif // SHARE_OOPS_OOP_HPP diff --git a/src/hotspot/share/oops/oop.inline.hpp b/src/hotspot/share/oops/oop.inline.hpp index da8421f34406f..cab2264309b49 100644 --- a/src/hotspot/share/oops/oop.inline.hpp +++ b/src/hotspot/share/oops/oop.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -185,7 +185,7 @@ int oopDesc::size_given_klass(Klass* klass) { // disjunct below to fail if the two comparands are computed across such // a concurrent change. assert((s == klass->oop_size(this)) || - (Universe::heap()->is_gc_active() && is_objArray() && is_forwarded() && (UseParallelGC || UseG1GC)), + (Universe::heap()->is_gc_active() && is_objArray() && is_forwarded() && (get_UseParallelGC() || get_UseG1GC())), "wrong array object size"); } else { // Must be zero, so bite the bullet and take the virtual call. diff --git a/src/hotspot/share/opto/arraycopynode.cpp b/src/hotspot/share/opto/arraycopynode.cpp index 4fc21c9ac1f0d..e5be140901d83 100644 --- a/src/hotspot/share/opto/arraycopynode.cpp +++ b/src/hotspot/share/opto/arraycopynode.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ #include "gc/shared/barrierSet.hpp" #include "gc/shared/c2/barrierSetC2.hpp" #include "gc/shared/c2/cardTableBarrierSetC2.hpp" +#include "gc/shared/gc_globals.hpp" #include "opto/arraycopynode.hpp" #include "opto/graphKit.hpp" #include "runtime/sharedRuntime.hpp" diff --git a/src/hotspot/share/opto/lcm.cpp b/src/hotspot/share/opto/lcm.cpp index f2e52cb9bf6bc..cf45ff971f7d4 100644 --- a/src/hotspot/share/opto/lcm.cpp +++ b/src/hotspot/share/opto/lcm.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "asm/macroAssembler.inline.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/allocation.inline.hpp" #include "oops/compressedOops.hpp" #include "opto/ad.hpp" diff --git a/src/hotspot/share/opto/macro.cpp b/src/hotspot/share/opto/macro.cpp index 58dc422a3c0ce..5eb07da817d1c 100644 --- a/src/hotspot/share/opto/macro.cpp +++ b/src/hotspot/share/opto/macro.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "compiler/compileLog.hpp" #include "gc/shared/collectedHeap.inline.hpp" +#include "gc/shared/tlab_globals.hpp" #include "libadt/vectset.hpp" #include "memory/universe.hpp" #include "opto/addnode.hpp" diff --git a/src/hotspot/share/opto/macroArrayCopy.cpp b/src/hotspot/share/opto/macroArrayCopy.cpp index a8f26010d11bf..bf53050a0eacc 100644 --- a/src/hotspot/share/opto/macroArrayCopy.cpp +++ b/src/hotspot/share/opto/macroArrayCopy.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/barrierSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "opto/arraycopynode.hpp" #include "oops/objArrayKlass.hpp" #include "opto/convertnode.hpp" diff --git a/src/hotspot/share/opto/memnode.cpp b/src/hotspot/share/opto/memnode.cpp index 67347f10b8155..00610e10ce8c1 100644 --- a/src/hotspot/share/opto/memnode.cpp +++ b/src/hotspot/share/opto/memnode.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ #include "compiler/compileLog.hpp" #include "gc/shared/barrierSet.hpp" #include "gc/shared/c2/barrierSetC2.hpp" +#include "gc/shared/tlab_globals.hpp" #include "memory/allocation.inline.hpp" #include "memory/resourceArea.hpp" #include "oops/objArrayKlass.hpp" diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp index dbf730a493a84..a10e418d8a955 100644 --- a/src/hotspot/share/runtime/arguments.cpp +++ b/src/hotspot/share/runtime/arguments.cpp @@ -31,6 +31,7 @@ #include "classfile/symbolTable.hpp" #include "gc/shared/gcArguments.hpp" #include "gc/shared/gcConfig.hpp" +#include "gc/shared/tlab_globals.hpp" #include "logging/log.hpp" #include "logging/logConfiguration.hpp" #include "logging/logStream.hpp" diff --git a/src/hotspot/share/runtime/flags/allFlags.hpp b/src/hotspot/share/runtime/flags/allFlags.hpp index cd62753cca664..9d655e02a1c43 100644 --- a/src/hotspot/share/runtime/flags/allFlags.hpp +++ b/src/hotspot/share/runtime/flags/allFlags.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,8 @@ #define SHARE_RUNTIME_FLAGS_ALLFLAGS_HPP #include "compiler/compiler_globals.hpp" +#include "gc/shared/gc_globals.hpp" +#include "gc/shared/tlab_globals.hpp" #include "runtime/globals.hpp" // Put LP64/ARCH/JVMCI/COMPILER1/COMPILER2 at the top, @@ -111,6 +113,15 @@ constraint) \ \ GC_FLAGS( \ + develop, \ + develop_pd, \ + product, \ + product_pd, \ + notproduct, \ + range, \ + constraint) \ + \ + TLAB_FLAGS( \ develop, \ develop_pd, \ product, \ diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp index 2c3a4f25db5bd..2bd40302863a2 100644 --- a/src/hotspot/share/runtime/globals.hpp +++ b/src/hotspot/share/runtime/globals.hpp @@ -26,7 +26,6 @@ #define SHARE_RUNTIME_GLOBALS_HPP #include "compiler/compiler_globals_pd.hpp" -#include "gc/shared/gc_globals.hpp" #include "runtime/globals_shared.hpp" #include "utilities/align.hpp" #include "utilities/globalDefinitions.hpp" diff --git a/src/hotspot/share/runtime/interfaceSupport.inline.hpp b/src/hotspot/share/runtime/interfaceSupport.inline.hpp index 4af8c2b8fa8a1..1372589756160 100644 --- a/src/hotspot/share/runtime/interfaceSupport.inline.hpp +++ b/src/hotspot/share/runtime/interfaceSupport.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #ifndef SHARE_RUNTIME_INTERFACESUPPORT_INLINE_HPP #define SHARE_RUNTIME_INTERFACESUPPORT_INLINE_HPP +#include "gc/shared/gc_globals.hpp" #include "runtime/handles.inline.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/orderAccess.hpp" diff --git a/src/hotspot/share/runtime/mutexLocker.cpp b/src/hotspot/share/runtime/mutexLocker.cpp index fea5e23cf43cd..140ff4f10b93a 100644 --- a/src/hotspot/share/runtime/mutexLocker.cpp +++ b/src/hotspot/share/runtime/mutexLocker.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ */ #include "precompiled.hpp" +#include "gc/shared/gc_globals.hpp" #include "memory/universe.hpp" #include "runtime/mutexLocker.hpp" #include "runtime/os.inline.hpp" diff --git a/src/hotspot/share/runtime/thread.cpp b/src/hotspot/share/runtime/thread.cpp index 5b9449ccc96a3..980cd730afad3 100644 --- a/src/hotspot/share/runtime/thread.cpp +++ b/src/hotspot/share/runtime/thread.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,7 +23,6 @@ */ #include "precompiled.hpp" -#include "runtime/thread.inline.hpp" #include "jvm.h" #include "aot/aotLoader.hpp" #include "classfile/classLoader.hpp" @@ -42,6 +41,7 @@ #include "gc/shared/gcVMOperations.hpp" #include "gc/shared/oopStorage.hpp" #include "gc/shared/oopStorageSet.hpp" +#include "gc/shared/tlab_globals.hpp" #include "gc/shared/workgroup.hpp" #include "interpreter/interpreter.hpp" #include "interpreter/linkResolver.hpp" @@ -326,6 +326,12 @@ Thread::Thread() { } } +void Thread::initialize_tlab() { + if (UseTLAB) { + tlab().initialize(); + } +} + void Thread::initialize_thread_current() { #ifndef USE_LIBRARY_BASED_TLS_ONLY assert(_thr_current == NULL, "Thread::current already initialized"); diff --git a/src/hotspot/share/runtime/thread.hpp b/src/hotspot/share/runtime/thread.hpp index 32faa694cc13f..08e36e0a48429 100644 --- a/src/hotspot/share/runtime/thread.hpp +++ b/src/hotspot/share/runtime/thread.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -598,11 +598,7 @@ class Thread: public ThreadShadow { // Thread-Local Allocation Buffer (TLAB) support ThreadLocalAllocBuffer& tlab() { return _tlab; } - void initialize_tlab() { - if (UseTLAB) { - tlab().initialize(); - } - } + void initialize_tlab(); jlong allocated_bytes() { return _allocated_bytes; } void set_allocated_bytes(jlong value) { _allocated_bytes = value; } diff --git a/src/hotspot/share/runtime/thread.inline.hpp b/src/hotspot/share/runtime/thread.inline.hpp index 2a485547b57bd..e072ce90d5ae2 100644 --- a/src/hotspot/share/runtime/thread.inline.hpp +++ b/src/hotspot/share/runtime/thread.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,8 +25,8 @@ #ifndef SHARE_RUNTIME_THREAD_INLINE_HPP #define SHARE_RUNTIME_THREAD_INLINE_HPP +#include "gc/shared/tlab_globals.hpp" #include "runtime/atomic.hpp" -#include "runtime/globals.hpp" #include "runtime/orderAccess.hpp" #include "runtime/os.inline.hpp" #include "runtime/safepoint.hpp" diff --git a/src/hotspot/share/runtime/threadSMR.inline.hpp b/src/hotspot/share/runtime/threadSMR.inline.hpp index fb5f9105ca182..22230ec139cd1 100644 --- a/src/hotspot/share/runtime/threadSMR.inline.hpp +++ b/src/hotspot/share/runtime/threadSMR.inline.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,8 @@ #ifndef SHARE_RUNTIME_THREADSMR_INLINE_HPP #define SHARE_RUNTIME_THREADSMR_INLINE_HPP +#include "gc/shared/gc_globals.hpp" +#include "gc/shared/tlab_globals.hpp" #include "runtime/atomic.hpp" #include "memory/iterator.hpp" #include "runtime/prefetch.inline.hpp" diff --git a/test/hotspot/gtest/runtime/test_globals.cpp b/test/hotspot/gtest/runtime/test_globals.cpp index bf44a6ce653e0..529e5d2557081 100644 --- a/test/hotspot/gtest/runtime/test_globals.cpp +++ b/test/hotspot/gtest/runtime/test_globals.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2016, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ #include "precompiled.hpp" #include "compiler/compiler_globals.hpp" +#include "gc/shared/gc_globals.hpp" #include "runtime/globals.hpp" #include "runtime/flags/flagSetting.hpp" #include "runtime/flags/jvmFlag.hpp" From dd8996c5f5784b18a01a86354e3ccaae1f86adae Mon Sep 17 00:00:00 2001 From: Hao Sun Date: Tue, 5 Jan 2021 07:31:44 +0000 Subject: [PATCH 010/129] 8258946: Fix optimization-unstable code involving signed integer overflow Reviewed-by: thartmann, kvn --- src/hotspot/share/opto/ifnode.cpp | 6 +++--- src/hotspot/share/opto/loopTransform.cpp | 10 +++++----- src/hotspot/share/opto/parse2.cpp | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/hotspot/share/opto/ifnode.cpp b/src/hotspot/share/opto/ifnode.cpp index 4d1ef3cf8651f..9f4c7f700cc00 100644 --- a/src/hotspot/share/opto/ifnode.cpp +++ b/src/hotspot/share/opto/ifnode.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -631,7 +631,7 @@ const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node* val, Node* if_proj return cmp2_t; case BoolTest::lt: lo = TypeInt::INT->_lo; - if (hi - 1 < hi) { + if (hi != min_jint) { hi = hi - 1; } break; @@ -639,7 +639,7 @@ const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node* val, Node* if_proj lo = TypeInt::INT->_lo; break; case BoolTest::gt: - if (lo + 1 > lo) { + if (lo != max_jint) { lo = lo + 1; } hi = TypeInt::INT->_hi; diff --git a/src/hotspot/share/opto/loopTransform.cpp b/src/hotspot/share/opto/loopTransform.cpp index e43b1a10defe1..a4486df9afd40 100644 --- a/src/hotspot/share/opto/loopTransform.cpp +++ b/src/hotspot/share/opto/loopTransform.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -912,12 +912,12 @@ bool IdealLoopTree::policy_unroll(PhaseIdealLoop *phase) { const TypeInt* iv_type = phase->_igvn.type(phi)->is_int(); int next_stride = stride_con * 2; // stride after this unroll if (next_stride > 0) { - if (iv_type->_lo + next_stride <= iv_type->_lo || // overflow + if (iv_type->_lo > max_jint - next_stride || // overflow iv_type->_lo + next_stride > iv_type->_hi) { return false; // over-unrolling } } else if (next_stride < 0) { - if (iv_type->_hi + next_stride >= iv_type->_hi || // overflow + if (iv_type->_hi < min_jint - next_stride || // overflow iv_type->_hi + next_stride < iv_type->_lo) { return false; // over-unrolling } @@ -928,8 +928,8 @@ bool IdealLoopTree::policy_unroll(PhaseIdealLoop *phase) { // After unroll limit will be adjusted: new_limit = limit-stride. // Bailout if adjustment overflow. const TypeInt* limit_type = phase->_igvn.type(limit_n)->is_int(); - if ((stride_con > 0 && ((limit_type->_hi - stride_con) >= limit_type->_hi)) || - (stride_con < 0 && ((limit_type->_lo - stride_con) <= limit_type->_lo))) + if ((stride_con > 0 && ((min_jint + stride_con) > limit_type->_hi)) || + (stride_con < 0 && ((max_jint + stride_con) < limit_type->_lo))) return false; // overflow // Adjust body_size to determine if we unroll or not diff --git a/src/hotspot/share/opto/parse2.cpp b/src/hotspot/share/opto/parse2.cpp index 17dee7032e80e..4258c228a1c00 100644 --- a/src/hotspot/share/opto/parse2.cpp +++ b/src/hotspot/share/opto/parse2.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -536,7 +536,7 @@ void Parse::do_lookupswitch() { } prev = match_int+1; } - if (prev-1 != max_jint) { + if (prev != min_jint) { defaults += (float)max_jint - prev + 1; } float default_cnt = 1; From 17d1645ecee778f55c132b70baf34a494002cb8d Mon Sep 17 00:00:00 2001 From: Hao Sun Date: Tue, 5 Jan 2021 08:29:41 +0000 Subject: [PATCH 011/129] 8258751: Improve ExceptionHandlerTable dump Reviewed-by: thartmann, chagedorn, njian --- .../share/code/exceptionHandlerTable.cpp | 22 ++++++++++++++----- .../share/code/exceptionHandlerTable.hpp | 6 ++--- src/hotspot/share/code/nmethod.cpp | 4 ++-- 3 files changed, 21 insertions(+), 11 deletions(-) diff --git a/src/hotspot/share/code/exceptionHandlerTable.cpp b/src/hotspot/share/code/exceptionHandlerTable.cpp index 86161e9e37159..f3c2a78704458 100644 --- a/src/hotspot/share/code/exceptionHandlerTable.cpp +++ b/src/hotspot/share/code/exceptionHandlerTable.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -120,22 +120,32 @@ HandlerTableEntry* ExceptionHandlerTable::entry_for(int catch_pco, int handler_b } -void ExceptionHandlerTable::print_subtable(HandlerTableEntry* t) const { +void ExceptionHandlerTable::print_subtable(HandlerTableEntry* t, address base) const { int l = t->len(); - tty->print_cr("catch_pco = %d (%d entries)", t->pco(), l); + bool have_base_addr = (base != NULL); + if (have_base_addr) { + tty->print_cr("catch_pco = %d (pc=" INTPTR_FORMAT ", %d entries)", t->pco(), p2i(base + t->pco()), l); + } else { + tty->print_cr("catch_pco = %d (%d entries)", t->pco(), l); + } while (l-- > 0) { t++; - tty->print_cr(" bci %d at scope depth %d -> pco %d", t->bci(), t->scope_depth(), t->pco()); + if (have_base_addr) { + tty->print_cr(" bci %d at scope depth %d -> pco %d (pc=" INTPTR_FORMAT ")", + t->bci(), t->scope_depth(), t->pco(), p2i(base + t->pco())); + } else { + tty->print_cr(" bci %d at scope depth %d -> pco %d", t->bci(), t->scope_depth(), t->pco()); + } } } -void ExceptionHandlerTable::print() const { +void ExceptionHandlerTable::print(address base) const { tty->print_cr("ExceptionHandlerTable (size = %d bytes)", size_in_bytes()); int i = 0; while (i < _length) { HandlerTableEntry* t = _table + i; - print_subtable(t); + print_subtable(t, base); // advance to next subtable i += t->len() + 1; // +1 for header } diff --git a/src/hotspot/share/code/exceptionHandlerTable.hpp b/src/hotspot/share/code/exceptionHandlerTable.hpp index d9f88e4a53959..d563e9492c5bd 100644 --- a/src/hotspot/share/code/exceptionHandlerTable.hpp +++ b/src/hotspot/share/code/exceptionHandlerTable.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -123,8 +123,8 @@ class ExceptionHandlerTable { HandlerTableEntry* entry_for(int catch_pco, int handler_bci, int scope_depth) const; // debugging - void print_subtable(HandlerTableEntry* t) const; - void print() const; + void print_subtable(HandlerTableEntry* t, address base = NULL) const; + void print(address base = NULL) const; void print_subtable_for(int catch_pco) const; }; diff --git a/src/hotspot/share/code/nmethod.cpp b/src/hotspot/share/code/nmethod.cpp index 351a1bb7e2ba5..b05ef488ba2c2 100644 --- a/src/hotspot/share/code/nmethod.cpp +++ b/src/hotspot/share/code/nmethod.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -2700,7 +2700,7 @@ void nmethod::print_native_invokers() { } void nmethod::print_handler_table() { - ExceptionHandlerTable(this).print(); + ExceptionHandlerTable(this).print(code_begin()); } void nmethod::print_nul_chk_table() { From 3817c32fd1dba46ff1ee1831aa5efb03c6546ace Mon Sep 17 00:00:00 2001 From: Lehua Ding Date: Tue, 5 Jan 2021 08:34:11 +0000 Subject: [PATCH 012/129] 8258534: Epsilon: clean up unused includes Reviewed-by: shade, jiefu --- src/hotspot/share/gc/epsilon/epsilonArguments.cpp | 1 - src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/hotspot/share/gc/epsilon/epsilonArguments.cpp b/src/hotspot/share/gc/epsilon/epsilonArguments.cpp index d80154bcaddca..17c4783d5c8f5 100644 --- a/src/hotspot/share/gc/epsilon/epsilonArguments.cpp +++ b/src/hotspot/share/gc/epsilon/epsilonArguments.cpp @@ -29,7 +29,6 @@ #include "gc/shared/tlab_globals.hpp" #include "runtime/globals.hpp" #include "runtime/globals_extension.hpp" -#include "utilities/macros.hpp" size_t EpsilonArguments::conservative_max_heap_alignment() { return UseLargePages ? os::large_page_size() : os::vm_page_size(); diff --git a/src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp b/src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp index b039a949dcfaa..84b76f75d5e0c 100644 --- a/src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp +++ b/src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp @@ -28,7 +28,6 @@ #include "gc/epsilon/epsilonThreadLocalData.hpp" #include "gc/shared/barrierSet.hpp" #include "gc/shared/barrierSetAssembler.hpp" -#include "utilities/macros.hpp" #ifdef COMPILER1 #include "gc/shared/c1/barrierSetC1.hpp" #endif From db6f39302b972a468452e2c2b7200039b2c23556 Mon Sep 17 00:00:00 2001 From: Aleksey Shipilev Date: Tue, 5 Jan 2021 08:37:06 +0000 Subject: [PATCH 013/129] 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java Reviewed-by: rkennke, adityam --- .../gcbarriers/UnsafeIntrinsicsTest.java | 26 +++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java b/test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java index 04b8db184aab4..f6d579053814a 100644 --- a/test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java +++ b/test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java @@ -22,14 +22,36 @@ */ /* - * @test + * @test id=z * @key randomness * @bug 8059022 * @modules java.base/jdk.internal.misc:+open * @summary Validate barriers after Unsafe getReference, CAS and swap (GetAndSet) * @requires vm.gc.Z * @library /test/lib - * @run main/othervm -XX:+UseZGC -XX:+UnlockDiagnosticVMOptions -XX:+ZVerifyViews -XX:ZCollectionInterval=1 -XX:-CreateCoredumpOnCrash -XX:CompileCommand=dontinline,*::mergeImpl* compiler.gcbarriers.UnsafeIntrinsicsTest + * @run main/othervm -XX:+UseZGC + * -XX:+UnlockDiagnosticVMOptions + * -XX:+ZVerifyViews -XX:ZCollectionInterval=1 + * -XX:-CreateCoredumpOnCrash + * -XX:CompileCommand=dontinline,*::mergeImpl* + * compiler.gcbarriers.UnsafeIntrinsicsTest + */ + +/* + * @test id=shenandoah + * @key randomness + * @bug 8255401 8251944 + * @modules java.base/jdk.internal.misc:+open + * @summary Validate barriers after Unsafe getReference, CAS and swap (GetAndSet) + * @requires vm.gc.Shenandoah + * @library /test/lib + * @run main/othervm -XX:+UseShenandoahGC + * -XX:+UnlockDiagnosticVMOptions + * -XX:-CreateCoredumpOnCrash + * -XX:+ShenandoahVerify + * -XX:+IgnoreUnrecognizedVMOptions -XX:+ShenandoahVerifyOptoBarriers + * -XX:CompileCommand=dontinline,*::mergeImpl* + * compiler.gcbarriers.UnsafeIntrinsicsTest */ package compiler.gcbarriers; From 9f1516492c20f52f249d7389f4058d8978faed9f Mon Sep 17 00:00:00 2001 From: Christian Hagedorn Date: Tue, 5 Jan 2021 09:54:18 +0000 Subject: [PATCH 014/129] 8259049: Uninitialized variable after JDK-8257513 Reviewed-by: kvn, thartmann --- src/hotspot/share/opto/constantTable.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hotspot/share/opto/constantTable.cpp b/src/hotspot/share/opto/constantTable.cpp index ce73cdcf2f5ba..285c273bb22cc 100644 --- a/src/hotspot/share/opto/constantTable.cpp +++ b/src/hotspot/share/opto/constantTable.cpp @@ -150,7 +150,7 @@ bool ConstantTable::emit(CodeBuffer& cb) const { "must be: %d == %d", (int)(constant_addr - _masm.code()->consts()->start()), (int)(con.offset())); // Expand jump-table - address last_addr; + address last_addr = NULL; for (uint j = 1; j < n->outcnt(); j++) { last_addr = _masm.address_constant(dummy + j); if (last_addr == NULL) { From 4ffbe841fca706f5b42fba2aedd872bd63473e50 Mon Sep 17 00:00:00 2001 From: Jan Lahoda Date: Tue, 5 Jan 2021 11:40:25 +0000 Subject: [PATCH 015/129] 8256266: Binding variables don't correctly support declaration annotations and the final modifier Reviewed-by: mcimadamore --- .../com/sun/tools/javac/code/Symbol.java | 4 +- .../sun/tools/javac/code/TypeAnnotations.java | 8 +- .../com/sun/tools/javac/comp/Attr.java | 5 +- .../sun/tools/javac/parser/JavacParser.java | 29 +++- .../tools/javac/patterns/Annotations.java | 152 ++++++++++++++++++ .../tools/javac/patterns/BindingsTest1.java | 15 ++ .../tools/javac/patterns/BindingsTest2.java | 6 + .../tools/javac/patterns/BindingsTest2.out | 3 +- .../javac/patterns/NoModifiersOnBinding.java | 24 +++ .../javac/patterns/NoModifiersOnBinding.out | 3 + 10 files changed, 237 insertions(+), 12 deletions(-) create mode 100644 test/langtools/tools/javac/patterns/Annotations.java create mode 100644 test/langtools/tools/javac/patterns/NoModifiersOnBinding.java create mode 100644 test/langtools/tools/javac/patterns/NoModifiersOnBinding.out diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java index d3472f72ccb53..660f5776705ad 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java @@ -1865,8 +1865,8 @@ public Name getSimpleName() { public static class BindingSymbol extends VarSymbol { - public BindingSymbol(Name name, Type type, Symbol owner) { - super(Flags.HASINIT | Flags.MATCH_BINDING, name, type, owner); + public BindingSymbol(long flags, Name name, Type type, Symbol owner) { + super(flags | Flags.HASINIT | Flags.MATCH_BINDING, name, type, owner); } public boolean isAliasFor(BindingSymbol b) { diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java index a3976984824ed..f88fbace54118 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java @@ -389,7 +389,8 @@ private void separateAnnotationsKinds(JCTree typetree, Type type, if (sym.getKind() == ElementKind.PARAMETER || sym.getKind() == ElementKind.LOCAL_VARIABLE || sym.getKind() == ElementKind.RESOURCE_VARIABLE || - sym.getKind() == ElementKind.EXCEPTION_PARAMETER) { + sym.getKind() == ElementKind.EXCEPTION_PARAMETER || + sym.getKind() == ElementKind.BINDING_VARIABLE) { appendTypeAnnotationsToOwner(sym, typeAnnotations); } } @@ -1264,6 +1265,11 @@ public void visitVarDef(final JCVariableDecl tree) { if (!tree.isImplicitlyTyped()) { separateAnnotationsKinds(tree.vartype, tree.sym.type, tree.sym, pos); } + } else if (tree.sym.getKind() == ElementKind.BINDING_VARIABLE) { + final TypeAnnotationPosition pos = + TypeAnnotationPosition.localVariable(currentLambda, + tree.pos); + separateAnnotationsKinds(tree.vartype, tree.sym.type, tree.sym, pos); } else if (tree.sym.getKind() == ElementKind.EXCEPTION_PARAMETER) { final TypeAnnotationPosition pos = TypeAnnotationPosition.exceptionParameter(currentLambda, diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java index 30c1c4102e935..733c20f8f4606 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java @@ -4000,12 +4000,13 @@ public void visitTypeTest(JCInstanceOf tree) { public void visitBindingPattern(JCBindingPattern tree) { ResultInfo varInfo = new ResultInfo(KindSelector.TYP, resultInfo.pt, resultInfo.checkContext); tree.type = tree.var.type = attribTree(tree.var.vartype, env, varInfo); - BindingSymbol v = new BindingSymbol(tree.var.name, tree.var.vartype.type, env.info.scope.owner); + BindingSymbol v = new BindingSymbol(tree.var.mods.flags, tree.var.name, tree.var.vartype.type, env.info.scope.owner); v.pos = tree.pos; tree.var.sym = v; if (chk.checkUnique(tree.var.pos(), v, env.info.scope)) { chk.checkTransparentVar(tree.var.pos(), v, env.info.scope); } + annotate.annotateLater(tree.var.mods.annotations, env, v, tree.pos()); annotate.queueScanTreeAndTypeAnnotate(tree.var.vartype, env, v, tree.var.pos()); annotate.flush(); result = tree.type; @@ -5761,7 +5762,7 @@ public void visitVarDef(JCVariableDecl that) { @Override public void visitBindingPattern(JCBindingPattern that) { if (that.var.sym == null) { - that.var.sym = new BindingSymbol(that.var.name, that.var.type, syms.noSymbol); + that.var.sym = new BindingSymbol(0, that.var.name, that.var.type, syms.noSymbol); that.var.sym.adr = 0; } super.visitBindingPattern(that); diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java index d03fbd52e52ad..c4911dbe2d57e 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java @@ -490,9 +490,13 @@ JCExpression illegal() { /** Diagnose a modifier flag from the set, if any. */ protected void checkNoMods(long mods) { + checkNoMods(token.pos, mods); + } + + protected void checkNoMods(int pos, long mods) { if (mods != 0) { long lowestMod = mods & -mods; - log.error(DiagnosticFlag.SYNTAX, token.pos, Errors.ModNotAllowedHere(Flags.asFlagSet(lowestMod))); + log.error(DiagnosticFlag.SYNTAX, pos, Errors.ModNotAllowedHere(Flags.asFlagSet(lowestMod))); } } @@ -932,17 +936,30 @@ JCExpression term2Rest(JCExpression t, int minprec) { if (token.kind == INSTANCEOF) { int pos = token.pos; nextToken(); + int patternPos = token.pos; + JCModifiers mods = optFinal(0); int typePos = token.pos; - JCExpression type = parseType(); + JCExpression type = unannotatedType(false); JCTree pattern; if (token.kind == IDENTIFIER) { checkSourceLevel(token.pos, Feature.PATTERN_MATCHING_IN_INSTANCEOF); - JCModifiers mods = F.at(Position.NOPOS).Modifiers(0); JCVariableDecl var = toP(F.at(token.pos).VarDef(mods, ident(), type, null)); - TreeInfo.getStartPos(var); - pattern = toP(F.at(typePos).BindingPattern(var)); - TreeInfo.getStartPos(pattern); + pattern = toP(F.at(patternPos).BindingPattern(var)); } else { + checkNoMods(typePos, mods.flags & ~Flags.DEPRECATED); + if (mods.annotations.nonEmpty()) { + checkSourceLevel(mods.annotations.head.pos, Feature.TYPE_ANNOTATIONS); + List typeAnnos = + mods.annotations + .map(decl -> { + JCAnnotation typeAnno = F.at(decl.pos) + .TypeAnnotation(decl.annotationType, + decl.args); + endPosTable.replaceTree(decl, typeAnno); + return typeAnno; + }); + type = insertAnnotationsToMostInner(type, typeAnnos, false); + } pattern = type; } odStack[top] = F.at(pos).TypeTest(odStack[top], pattern); diff --git a/test/langtools/tools/javac/patterns/Annotations.java b/test/langtools/tools/javac/patterns/Annotations.java new file mode 100644 index 0000000000000..94cc9631eeb6e --- /dev/null +++ b/test/langtools/tools/javac/patterns/Annotations.java @@ -0,0 +1,152 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8256266 + * @summary Verify annotations work correctly on binding variables + * @library /tools/javac/lib + * @modules java.compiler + * jdk.compiler + * jdk.jdeps/com.sun.tools.classfile + * @build JavacTestingAbstractProcessor + * @compile Annotations.java + * @compile -processor Annotations -proc:only Annotations.java + * @run main Annotations + */ + +import com.sun.source.tree.InstanceOfTree; +import com.sun.source.util.TreePath; +import java.lang.annotation.ElementType; +import java.lang.annotation.Target; +import java.util.Set; +import javax.annotation.processing.RoundEnvironment; +import javax.lang.model.element.Element; +import javax.lang.model.element.TypeElement; +import javax.lang.model.type.TypeMirror; + +import com.sun.source.tree.BindingPatternTree; +import com.sun.source.tree.VariableTree; +import com.sun.source.util.TreePathScanner; +import com.sun.source.util.Trees; +import com.sun.tools.classfile.*; +import java.io.InputStream; +import java.util.Arrays; + +public class Annotations extends JavacTestingAbstractProcessor { + public static void main(String... args) throws Exception { + new Annotations().run(); + } + + void run() throws Exception { + InputStream annotationsClass = + Annotations.class.getResourceAsStream("Annotations.class"); + ClassFile cf = ClassFile.read(annotationsClass); + for (Method m : cf.methods) { + if ("test".equals(cf.constant_pool.getUTF8Value(m.name_index))) { + Code_attribute codeAttr = + (Code_attribute) m.attributes.map.get(Attribute.Code); + Attribute annoAttr = + codeAttr.attributes.map.get(Attribute.RuntimeInvisibleTypeAnnotations); + RuntimeInvisibleTypeAnnotations_attribute annotations = + (RuntimeInvisibleTypeAnnotations_attribute) annoAttr; + String expected = "[@Annotations$DTA; pos: [LOCAL_VARIABLE, {start_pc = 35, length = 7, index = 1}, pos = -1], " + + "@Annotations$TA; pos: [LOCAL_VARIABLE, {start_pc = 56, length = 7, index = 1}, pos = -1]]"; + String actual = Arrays.toString(annotations.annotations); + if (!expected.equals(actual)) { + throw new AssertionError("Unexpected type annotations: " + + actual); + } + } + } + } + + private static void test(Object o) { + if (o instanceof @DA String da) { + System.err.println(da); + } + if (o instanceof @DTA String dta) { + System.err.println(dta); + } + if (o instanceof @TA String ta) { + System.err.println(ta); + } + } + + @Override + public boolean process(Set annotations, RoundEnvironment roundEnv) { + Trees trees = Trees.instance(processingEnv); + + for (Element root : roundEnv.getRootElements()) { + TreePath tp = trees.getPath(root); + new TreePathScanner() { + @Override + public Void visitInstanceOf(InstanceOfTree node, Void p) { + BindingPatternTree bpt = (BindingPatternTree) node.getPattern(); + VariableTree var = bpt.getVariable(); + Element varEl = trees.getElement(new TreePath(getCurrentPath(), var)); + String expectedDeclAnnos; + String expectedType; + switch (var.getName().toString()) { + case "da" -> { + expectedDeclAnnos = "@Annotations.DA"; + expectedType = "java.lang.String"; + } + case "dta" -> { + expectedDeclAnnos = "@Annotations.DTA"; + expectedType = "@Annotations.DTA java.lang.String"; + } + case "ta" -> { + expectedDeclAnnos = ""; + expectedType = "@Annotations.TA java.lang.String"; + } + default -> { + throw new AssertionError("Unexpected variable: " + var); + } + } + String declAnnos = varEl.getAnnotationMirrors().toString(); + if (!expectedDeclAnnos.equals(declAnnos)) { + throw new AssertionError("Unexpected modifiers: " + declAnnos + + " for: " + var.getName()); + } + TypeMirror varType = varEl.asType(); + String type = varType.toString(); + if (!expectedType.equals(type)) { + throw new AssertionError("Unexpected type: " + type + + " for: " + var.getName()); + } + return super.visitInstanceOf(node, p); + } + }.scan(tp.getCompilationUnit(), null); + } + return false; + } + + @Target(ElementType.LOCAL_VARIABLE) + @interface DA {} + @Target({ElementType.TYPE_USE, ElementType.LOCAL_VARIABLE}) + @interface DTA {} + @Target(ElementType.TYPE_USE) + @interface TA {} +} + diff --git a/test/langtools/tools/javac/patterns/BindingsTest1.java b/test/langtools/tools/javac/patterns/BindingsTest1.java index 018084a98e716..8faf4add7ed84 100644 --- a/test/langtools/tools/javac/patterns/BindingsTest1.java +++ b/test/langtools/tools/javac/patterns/BindingsTest1.java @@ -185,6 +185,21 @@ public void run() { String s2 = s; } + if (o1 instanceof final String s) { + Runnable r1 = new Runnable() { + @Override + public void run() { + s.length(); + } + }; + r1.run(); + Runnable r2 = () -> { + s.length(); + }; + r2.run(); + String s2 = s; + } + boolean result = (o1 instanceof String a1) ? (o1 instanceof String a2) : (!(o1 instanceof String a3)); boolean result2 = (o1 instanceof String a1) ? (o1 instanceof String a2) : (!(switch (0) { default -> false; })); diff --git a/test/langtools/tools/javac/patterns/BindingsTest2.java b/test/langtools/tools/javac/patterns/BindingsTest2.java index 4bbd5f3f532ca..d3247ea427321 100644 --- a/test/langtools/tools/javac/patterns/BindingsTest2.java +++ b/test/langtools/tools/javac/patterns/BindingsTest2.java @@ -241,5 +241,11 @@ public static void main(String[] args) { s.length(); } } + + { + if (o1 instanceof final String s) { + s = ""; + } + } } } diff --git a/test/langtools/tools/javac/patterns/BindingsTest2.out b/test/langtools/tools/javac/patterns/BindingsTest2.out index e52e9db234277..9f22871d39297 100644 --- a/test/langtools/tools/javac/patterns/BindingsTest2.out +++ b/test/langtools/tools/javac/patterns/BindingsTest2.out @@ -46,7 +46,8 @@ BindingsTest2.java:212:13: compiler.err.cant.resolve.location: kindname.variable BindingsTest2.java:221:17: compiler.err.cant.resolve.location: kindname.variable, s, , , (compiler.misc.location: kindname.class, BindingsTest2, null) BindingsTest2.java:231:17: compiler.err.cant.resolve.location: kindname.variable, s, , , (compiler.misc.location: kindname.class, BindingsTest2, null) BindingsTest2.java:241:17: compiler.err.cant.resolve.location: kindname.variable, s, , , (compiler.misc.location: kindname.class, BindingsTest2, null) +BindingsTest2.java:247:17: compiler.err.cant.assign.val.to.final.var: s BindingsTest2.java:135:17: compiler.err.unreachable.stmt BindingsTest2.java:160:17: compiler.err.unreachable.stmt BindingsTest2.java:185:17: compiler.err.unreachable.stmt -51 errors \ No newline at end of file +52 errors diff --git a/test/langtools/tools/javac/patterns/NoModifiersOnBinding.java b/test/langtools/tools/javac/patterns/NoModifiersOnBinding.java new file mode 100644 index 0000000000000..85bbb211d3ec7 --- /dev/null +++ b/test/langtools/tools/javac/patterns/NoModifiersOnBinding.java @@ -0,0 +1,24 @@ +/* @test /nodynamiccopyright/ + * @bug 8256266 + * @summary Binding variables cannot have (non-annotation) modifiers. + * @compile/fail/ref=NoModifiersOnBinding.out -XDrawDiagnostics NoModifiersOnBinding.java + */ + +public class NoModifiersOnBinding { + + private static void test(Object o) { + if (o instanceof final String) { + System.err.println(s); + } + if (o instanceof /**@deprecated*/ String) { + System.err.println(s); + } + if (o instanceof static String s) { + System.err.println(s); + } + if (o instanceof /**@deprecated*/ String s) { + System.err.println(s); + } + } + +} diff --git a/test/langtools/tools/javac/patterns/NoModifiersOnBinding.out b/test/langtools/tools/javac/patterns/NoModifiersOnBinding.out new file mode 100644 index 0000000000000..94c1f2a656615 --- /dev/null +++ b/test/langtools/tools/javac/patterns/NoModifiersOnBinding.out @@ -0,0 +1,3 @@ +NoModifiersOnBinding.java:10:32: compiler.err.mod.not.allowed.here: final +NoModifiersOnBinding.java:16:33: compiler.err.mod.not.allowed.here: static +2 errors From a6c088131bfeec1ce44e43b513ce3f857fa6e44f Mon Sep 17 00:00:00 2001 From: Sergey Bylokhov Date: Tue, 5 Jan 2021 12:47:33 +0000 Subject: [PATCH 016/129] 8256321: Some "inactive" color profiles use the wrong profile class Reviewed-by: prr --- .../classes/java/awt/color/ICC_Profile.java | 4 +- .../awt/color/CheckDefaultProperties.java | 85 +++++++++++++++++++ 2 files changed, 87 insertions(+), 2 deletions(-) create mode 100644 test/jdk/java/awt/color/CheckDefaultProperties.java diff --git a/src/java.desktop/share/classes/java/awt/color/ICC_Profile.java b/src/java.desktop/share/classes/java/awt/color/ICC_Profile.java index b4e38a25c7ea6..969696ceadcff 100644 --- a/src/java.desktop/share/classes/java/awt/color/ICC_Profile.java +++ b/src/java.desktop/share/classes/java/awt/color/ICC_Profile.java @@ -857,7 +857,7 @@ public static ICC_Profile getInstance (int cspace) { ProfileDeferralInfo pInfo = new ProfileDeferralInfo("CIEXYZ.pf", ColorSpace.TYPE_XYZ, 3, - CLASS_DISPLAY); + CLASS_ABSTRACT); XYZprofile = getDeferredInstance(pInfo); } thisProfile = XYZprofile; @@ -871,7 +871,7 @@ public static ICC_Profile getInstance (int cspace) { ProfileDeferralInfo pInfo = new ProfileDeferralInfo("PYCC.pf", ColorSpace.TYPE_3CLR, 3, - CLASS_DISPLAY); + CLASS_COLORSPACECONVERSION); PYCCprofile = getDeferredInstance(pInfo); } thisProfile = PYCCprofile; diff --git a/test/jdk/java/awt/color/CheckDefaultProperties.java b/test/jdk/java/awt/color/CheckDefaultProperties.java new file mode 100644 index 0000000000000..583c46da7e10e --- /dev/null +++ b/test/jdk/java/awt/color/CheckDefaultProperties.java @@ -0,0 +1,85 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.awt.color.ColorSpace; +import java.awt.color.ICC_Profile; + +import static java.awt.color.ColorSpace.TYPE_3CLR; +import static java.awt.color.ColorSpace.TYPE_GRAY; +import static java.awt.color.ColorSpace.TYPE_RGB; +import static java.awt.color.ColorSpace.TYPE_XYZ; +import static java.awt.color.ICC_Profile.CLASS_ABSTRACT; +import static java.awt.color.ICC_Profile.CLASS_COLORSPACECONVERSION; +import static java.awt.color.ICC_Profile.CLASS_DISPLAY; + +/** + * @test + * @bug 8256321 + * @summary Verifies profile properties are the same before/after activation + */ +public final class CheckDefaultProperties { + + public static void main(String[] args) { + ICC_Profile srgb = ICC_Profile.getInstance(ColorSpace.CS_sRGB); + ICC_Profile gray = ICC_Profile.getInstance(ColorSpace.CS_GRAY); + ICC_Profile xyz = ICC_Profile.getInstance(ColorSpace.CS_CIEXYZ); + ICC_Profile lrgb = ICC_Profile.getInstance(ColorSpace.CS_LINEAR_RGB); + ICC_Profile pycc = ICC_Profile.getInstance(ColorSpace.CS_PYCC); + + // check default values, before profile activation + test(srgb, TYPE_RGB, 3, CLASS_DISPLAY); + test(gray, TYPE_GRAY, 1, CLASS_DISPLAY); + test(xyz, TYPE_XYZ, 3, CLASS_ABSTRACT); + test(lrgb, TYPE_RGB, 3, CLASS_DISPLAY); + test(pycc, TYPE_3CLR, 3, CLASS_COLORSPACECONVERSION); + + // activate profiles + srgb.getData(); + gray.getData(); + xyz.getData(); + lrgb.getData(); + pycc.getData(); + + // check default values, after profile activation + test(srgb, TYPE_RGB, 3, CLASS_DISPLAY); + test(gray, TYPE_GRAY, 1, CLASS_DISPLAY); + test(xyz, TYPE_XYZ, 3, CLASS_ABSTRACT); + test(lrgb, TYPE_RGB, 3, CLASS_DISPLAY); + test(pycc, TYPE_3CLR, 3, CLASS_COLORSPACECONVERSION); + } + + private static void test(ICC_Profile profile, int type, int num, int pcls) { + int profileClass = profile.getProfileClass(); + int colorSpaceType = profile.getColorSpaceType(); + int numComponents = profile.getNumComponents(); + if (profileClass != pcls) { + throw new RuntimeException("Wrong profile class: " + profileClass); + } + if (colorSpaceType != type) { + throw new RuntimeException("Wrong profile type: " + colorSpaceType); + } + if (numComponents != num) { + throw new RuntimeException("Wrong profile comps: " + numComponents); + } + } +} From 6775113ce88cc819e7c3242730837e4afd7733b0 Mon Sep 17 00:00:00 2001 From: Roland Westrelin Date: Tue, 5 Jan 2021 13:06:54 +0000 Subject: [PATCH 017/129] 8258393: Shenandoah: "graph should be schedulable" assert failure Reviewed-by: rkennke, thartmann --- .../gc/shenandoah/c2/shenandoahSupport.cpp | 15 ++++ src/hotspot/share/opto/loopnode.cpp | 30 ++++++-- .../compiler/TestBadRawMemoryAfterCall.java | 74 +++++++++++++++++++ 3 files changed, 112 insertions(+), 7 deletions(-) create mode 100644 test/hotspot/jtreg/gc/shenandoah/compiler/TestBadRawMemoryAfterCall.java diff --git a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp index 6fef738e70c5c..e5c426d2f3dbe 100644 --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp @@ -2459,6 +2459,21 @@ bool MemoryGraphFixer::mem_is_valid(Node* m, Node* c) const { Node* MemoryGraphFixer::find_mem(Node* ctrl, Node* n) const { assert(n == NULL || _phase->ctrl_or_self(n) == ctrl, ""); + assert(!ctrl->is_Call() || ctrl == n, "projection expected"); +#ifdef ASSERT + if ((ctrl->is_Proj() && ctrl->in(0)->is_Call()) || + (ctrl->is_Catch() && ctrl->in(0)->in(0)->is_Call())) { + CallNode* call = ctrl->is_Proj() ? ctrl->in(0)->as_Call() : ctrl->in(0)->in(0)->as_Call(); + int mems = 0; + for (DUIterator_Fast imax, i = call->fast_outs(imax); i < imax; i++) { + Node* u = call->fast_out(i); + if (u->bottom_type() == Type::MEMORY) { + mems++; + } + } + assert(mems <= 1, "No node right after call if multiple mem projections"); + } +#endif Node* mem = _memory_nodes[ctrl->_idx]; Node* c = ctrl; while (!mem_is_valid(mem, c) && diff --git a/src/hotspot/share/opto/loopnode.cpp b/src/hotspot/share/opto/loopnode.cpp index 66c63f4a7d850..bc0da1902b5ee 100644 --- a/src/hotspot/share/opto/loopnode.cpp +++ b/src/hotspot/share/opto/loopnode.cpp @@ -4968,18 +4968,18 @@ Node *PhaseIdealLoop::get_late_ctrl( Node *n, Node *early ) { if (n->is_Load() && LCA != early) { int load_alias_idx = C->get_alias_index(n->adr_type()); if (C->alias_type(load_alias_idx)->is_rewritable()) { + Unique_Node_List worklist; - Node_List worklist; - - Node *mem = n->in(MemNode::Memory); + Node* mem = n->in(MemNode::Memory); for (DUIterator_Fast imax, i = mem->fast_outs(imax); i < imax; i++) { Node* s = mem->fast_out(i); worklist.push(s); } - while(worklist.size() != 0 && LCA != early) { - Node* s = worklist.pop(); + for (uint i = 0; i < worklist.size() && LCA != early; i++) { + Node* s = worklist.at(i); if (s->is_Load() || s->Opcode() == Op_SafePoint || - (s->is_CallStaticJava() && s->as_CallStaticJava()->uncommon_trap_request() != 0)) { + (s->is_CallStaticJava() && s->as_CallStaticJava()->uncommon_trap_request() != 0) || + s->is_Phi()) { continue; } else if (s->is_MergeMem()) { for (DUIterator_Fast imax, i = s->fast_outs(imax); i < imax; i++) { @@ -4987,7 +4987,7 @@ Node *PhaseIdealLoop::get_late_ctrl( Node *n, Node *early ) { worklist.push(s1); } } else { - Node *sctrl = has_ctrl(s) ? get_ctrl(s) : s->in(0); + Node* sctrl = has_ctrl(s) ? get_ctrl(s) : s->in(0); assert(sctrl != NULL || !s->is_reachable_from_root(), "must have control"); if (sctrl != NULL && !sctrl->is_top() && is_dominator(early, sctrl)) { const TypePtr* adr_type = s->adr_type(); @@ -5011,6 +5011,22 @@ Node *PhaseIdealLoop::get_late_ctrl( Node *n, Node *early ) { } } } + // For Phis only consider Region's inputs that were reached by following the memory edges + if (LCA != early) { + for (uint i = 0; i < worklist.size(); i++) { + Node* s = worklist.at(i); + if (s->is_Phi() && C->can_alias(s->adr_type(), load_alias_idx)) { + Node* r = s->in(0); + for (uint j = 1; j < s->req(); j++) { + Node* in = s->in(j); + Node* r_in = r->in(j); + if (worklist.member(in) && is_dominator(early, r_in)) { + LCA = dom_lca_for_get_late_ctrl(LCA, r_in, n); + } + } + } + } + } } } diff --git a/test/hotspot/jtreg/gc/shenandoah/compiler/TestBadRawMemoryAfterCall.java b/test/hotspot/jtreg/gc/shenandoah/compiler/TestBadRawMemoryAfterCall.java new file mode 100644 index 0000000000000..099400cc70f94 --- /dev/null +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestBadRawMemoryAfterCall.java @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2021, Red Hat, Inc. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @bug 8258393 + * @summary Shenandoah: "graph should be schedulable" assert failure + * @requires vm.flavor == "server" + * @requires vm.gc.Shenandoah + * + * @run main/othervm -XX:+UseShenandoahGC -XX:-BackgroundCompilation TestBadRawMemoryAfterCall + * + */ + +public class TestBadRawMemoryAfterCall { + public static void main(String[] args) { + A a = new A(); + B b = new B(); + C c = new C(); + for (int i = 0; i < 20_000; i++) { + test(a); + test(b); + test(c); + } + } + + private static Object test(A a) { + if (a.getClass() == A.class) { + } + + Object o = null; + try { + a.m(); + o = a.getClass(); + } catch (Exception e) { + + } + return o; + } + + private static class A { + void m() throws Exception { + throw new Exception(); + } + } + private static class B extends A { + void m() { + } + } + private static class C extends B { + void m() { + } + } +} From bbc2e9510bb32d69d823bd572b6c0c02bd2335af Mon Sep 17 00:00:00 2001 From: Erik Gahlin Date: Tue, 5 Jan 2021 13:39:57 +0000 Subject: [PATCH 018/129] 8257906: JFR: RecordingStream leaks memory Reviewed-by: mgronlun Backport-of: 3c6648501589bf36945340cb1e82c833ebd7485d --- .../jdk/jfr/consumer/RecordingStream.java | 43 +++++++++++++++++-- .../jfr/internal/consumer/ChunkParser.java | 12 ++++++ .../consumer/EventDirectoryStream.java | 1 + .../internal/consumer/EventFileStream.java | 1 + 4 files changed, 54 insertions(+), 3 deletions(-) diff --git a/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java b/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java index 78fe38d6d34bc..7938fc22831c2 100644 --- a/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java +++ b/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java @@ -45,7 +45,6 @@ import jdk.jfr.internal.SecuritySupport; import jdk.jfr.internal.Utils; import jdk.jfr.internal.consumer.EventDirectoryStream; -import jdk.jfr.internal.consumer.JdkJfrConsumer; /** * A recording stream produces events from the current JVM (Java Virtual @@ -68,9 +67,27 @@ */ public final class RecordingStream implements AutoCloseable, EventStream { + final static class ChunkConsumer implements Consumer { + + private final Recording recording; + + ChunkConsumer(Recording recording) { + this.recording = recording; + } + + @Override + public void accept(Long endNanos) { + Instant t = Utils.epochNanosToInstant(endNanos); + PlatformRecording p = PrivateAccess.getInstance().getPlatformRecording(recording); + p.removeBefore(t); + } + } + private final Recording recording; private final Instant creationTime; private final EventDirectoryStream directoryStream; + private long maxSize; + private Duration maxAge; /** * Creates an event stream for the current JVM (Java Virtual Machine). @@ -247,7 +264,11 @@ public EventSettings disable(Class eventClass) { * state */ public void setMaxAge(Duration maxAge) { - recording.setMaxAge(maxAge); + synchronized (directoryStream) { + recording.setMaxAge(maxAge); + this.maxAge = maxAge; + updateOnCompleteHandler(); + } } /** @@ -270,7 +291,11 @@ public void setMaxAge(Duration maxAge) { * @throws IllegalStateException if the recording is in {@code CLOSED} state */ public void setMaxSize(long maxSize) { - recording.setMaxSize(maxSize); + synchronized (directoryStream) { + recording.setMaxSize(maxSize); + this.maxSize = maxSize; + updateOnCompleteHandler(); + } } @Override @@ -320,6 +345,7 @@ public void onError(Consumer action) { @Override public void close() { + directoryStream.setChunkCompleteHandler(null); recording.close(); directoryStream.close(); } @@ -333,6 +359,7 @@ public boolean remove(Object action) { public void start() { PlatformRecording pr = PrivateAccess.getInstance().getPlatformRecording(recording); long startNanos = pr.start(); + updateOnCompleteHandler(); directoryStream.start(startNanos); } @@ -363,6 +390,7 @@ public void start() { public void startAsync() { PlatformRecording pr = PrivateAccess.getInstance().getPlatformRecording(recording); long startNanos = pr.start(); + updateOnCompleteHandler(); directoryStream.startAsync(startNanos); } @@ -380,4 +408,13 @@ public void awaitTermination() throws InterruptedException { public void onMetadata(Consumer action) { directoryStream.onMetadata(action); } + + private void updateOnCompleteHandler() { + if (maxAge != null || maxSize != 0) { + // User has set a chunk removal policy + directoryStream.setChunkCompleteHandler(null); + } else { + directoryStream.setChunkCompleteHandler(new ChunkConsumer(recording)); + } + } } diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java index 043bac38589ce..4d2d94d5dcbde 100644 --- a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java +++ b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java @@ -488,4 +488,16 @@ public void setStaleMetadata(boolean stale) { public boolean hasStaleMetadata() { return staleMetadata; } + + public void resetCache() { + LongMap ps = this.parsers; + if (ps != null) { + ps.forEach(p -> { + if (p instanceof EventParser) { + EventParser ep = (EventParser) p; + ep.resetCache(); + } + }); + } + } } diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java index 192dabd81381d..9a71c5c145ce9 100644 --- a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java +++ b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java @@ -159,6 +159,7 @@ protected void processRecursionSafe() throws IOException { } else { processUnordered(disp); } + currentParser.resetCache(); if (currentParser.getStartNanos() + currentParser.getChunkDuration() > filterEnd) { close(); return; diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java index 6db1d7ae1bf7b..91c70973464d6 100644 --- a/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java +++ b/src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java @@ -102,6 +102,7 @@ protected void process() throws IOException { } else { processUnordered(disp); } + currentParser.resetCache(); if (isClosed() || currentParser.isLastChunk()) { return; } From fc3b45c068cf6393d16c254cf9080213f9d592ab Mon Sep 17 00:00:00 2001 From: Alexander Zuev Date: Tue, 5 Jan 2021 14:46:03 +0000 Subject: [PATCH 019/129] 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button" Reviewed-by: psadhukhan --- .../swing/JComponent/7154030/bug7154030.java | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/test/jdk/javax/swing/JComponent/7154030/bug7154030.java b/test/jdk/javax/swing/JComponent/7154030/bug7154030.java index 4835c07bf94f1..4856671727601 100644 --- a/test/jdk/javax/swing/JComponent/7154030/bug7154030.java +++ b/test/jdk/javax/swing/JComponent/7154030/bug7154030.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,14 +30,9 @@ import javax.swing.JFrame; import javax.swing.SwingUtilities; -import java.awt.AWTException; -import java.awt.AlphaComposite; import java.awt.Color; -import java.awt.Graphics; -import java.awt.Graphics2D; +import java.awt.Insets; import java.awt.Rectangle; -import java.awt.Robot; -import java.awt.Toolkit; import java.awt.image.BufferedImage; import javax.imageio.ImageIO; import java.io.File; @@ -98,10 +93,11 @@ public void run() { robot.waitForIdle(1000); Rectangle bounds = frame.getBounds(); - locx = bounds.x; - locy = bounds.y; - frw = bounds.width; - frh = bounds.height; + Insets insets = frame.getInsets(); + locx = bounds.x + insets.left; + locy = bounds.y + insets.top; + frw = bounds.width - insets.left - insets.right; + frh = bounds.height - insets.top - insets.bottom; imageInit = robot.createScreenCapture(new Rectangle(locx, locy, frw, frh)); From f4122d6aa21fc589cd0f75ea29998447e0f1ea36 Mon Sep 17 00:00:00 2001 From: Harold Seigel Date: Tue, 5 Jan 2021 16:14:58 +0000 Subject: [PATCH 020/129] 8258896: Remove the JVM ForceFloatExceptions option Reviewed-by: lfoltan, iklam, coleenp --- src/hotspot/os/windows/os_windows.cpp | 23 ++++++++--------------- src/hotspot/share/runtime/globals.hpp | 3 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/hotspot/os/windows/os_windows.cpp b/src/hotspot/os/windows/os_windows.cpp index e8d936f76828d..9eed244f3f559 100644 --- a/src/hotspot/os/windows/os_windows.cpp +++ b/src/hotspot/os/windows/os_windows.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -4183,21 +4183,14 @@ jint os::init_2(void) { #endif // for debugging float code generation bugs - if (ForceFloatExceptions) { -#ifndef _WIN64 - static long fp_control_word = 0; - __asm { fstcw fp_control_word } - // see Intel PPro Manual, Vol. 2, p 7-16 - const long precision = 0x20; - const long underflow = 0x10; - const long overflow = 0x08; - const long zero_div = 0x04; - const long denorm = 0x02; - const long invalid = 0x01; - fp_control_word |= invalid; - __asm { fldcw fp_control_word } +#if defined(ASSERT) && !defined(_WIN64) + static long fp_control_word = 0; + __asm { fstcw fp_control_word } + // see Intel PPro Manual, Vol. 2, p 7-16 + const long invalid = 0x01; + fp_control_word |= invalid; + __asm { fldcw fp_control_word } #endif - } // If stack_commit_size is 0, windows will reserve the default size, // but only commit a small portion of it. diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp index 2bd40302863a2..b79332fed6b20 100644 --- a/src/hotspot/share/runtime/globals.hpp +++ b/src/hotspot/share/runtime/globals.hpp @@ -461,9 +461,6 @@ const intx ObjectAlignmentInBytes = 8; product(bool, BytecodeVerificationLocal, false, DIAGNOSTIC, \ "Enable the Java bytecode verifier for local classes") \ \ - develop(bool, ForceFloatExceptions, trueInDebug, \ - "Force exceptions on FP stack under/overflow") \ - \ develop(bool, VerifyStackAtCalls, false, \ "Verify that the stack pointer is unchanged after calls") \ \ From b7940aa1c4952e206162d4d46e0aca08adae52b9 Mon Sep 17 00:00:00 2001 From: Maurizio Cimadamore Date: Tue, 5 Jan 2021 16:15:28 +0000 Subject: [PATCH 021/129] 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0 Reviewed-by: chegar, uschindler --- .../foreign/MappedMemorySegmentImpl.java | 38 +++++++++++++++++-- test/jdk/java/foreign/TestByteBuffer.java | 18 +++++++++ 2 files changed, 53 insertions(+), 3 deletions(-) diff --git a/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MappedMemorySegmentImpl.java b/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MappedMemorySegmentImpl.java index 8df08047d74e6..62e4007282401 100644 --- a/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MappedMemorySegmentImpl.java +++ b/src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MappedMemorySegmentImpl.java @@ -116,13 +116,17 @@ public static MemorySegment makeMappedSegment(Path path, long bytesOffset, long if (bytesOffset < 0) throw new IllegalArgumentException("Requested bytes offset must be >= 0."); try (FileChannelImpl channelImpl = (FileChannelImpl)FileChannel.open(path, openOptions(mapMode))) { UnmapperProxy unmapperProxy = channelImpl.mapInternal(mapMode, bytesOffset, bytesSize); - MemoryScope scope = MemoryScope.createConfined(null, unmapperProxy::unmap, null); int modes = defaultAccessModes(bytesSize); if (mapMode == FileChannel.MapMode.READ_ONLY) { modes &= ~WRITE; } - return new MappedMemorySegmentImpl(unmapperProxy.address(), unmapperProxy, bytesSize, - modes, scope); + if (unmapperProxy != null) { + MemoryScope scope = MemoryScope.createConfined(null, unmapperProxy::unmap, null); + return new MappedMemorySegmentImpl(unmapperProxy.address(), unmapperProxy, bytesSize, + modes, scope); + } else { + return new EmptyMappedMemorySegmentImpl(modes); + } } } @@ -135,4 +139,32 @@ private static OpenOption[] openOptions(FileChannel.MapMode mapMode) { throw new UnsupportedOperationException("Unsupported map mode: " + mapMode); } } + + static class EmptyMappedMemorySegmentImpl extends MappedMemorySegmentImpl { + + public EmptyMappedMemorySegmentImpl(int modes) { + super(0, null, 0, modes, + MemoryScope.createConfined(null, MemoryScope.DUMMY_CLEANUP_ACTION, null)); + } + + @Override + public void load() { + // do nothing + } + + @Override + public void unload() { + // do nothing + } + + @Override + public boolean isLoaded() { + return true; + } + + @Override + public void force() { + // do nothing + } + }; } diff --git a/test/jdk/java/foreign/TestByteBuffer.java b/test/jdk/java/foreign/TestByteBuffer.java index 8c71aeb0d1af5..241a7eefed50a 100644 --- a/test/jdk/java/foreign/TestByteBuffer.java +++ b/test/jdk/java/foreign/TestByteBuffer.java @@ -464,12 +464,30 @@ public void testBadMapNegativeOffset() throws IOException { MemorySegment.mapFile(f.toPath(), -1, 1, FileChannel.MapMode.READ_WRITE); } + @Test public void testMapZeroSize() throws IOException { File f = new File("testPos1.out"); f.createNewFile(); f.deleteOnExit(); + //RW try (MemorySegment segment = MemorySegment.mapFile(f.toPath(), 0L, 0L, FileChannel.MapMode.READ_WRITE)) { assertEquals(segment.byteSize(), 0); + assertEquals(segment.isMapped(), true); + assertTrue((segment.accessModes() & (READ | WRITE)) == (READ | WRITE)); + MappedMemorySegments.force(segment); + MappedMemorySegments.load(segment); + MappedMemorySegments.isLoaded(segment); + MappedMemorySegments.unload(segment); + } + //RO + try (MemorySegment segment = MemorySegment.mapFile(f.toPath(), 0L, 0L, FileChannel.MapMode.READ_ONLY)) { + assertEquals(segment.byteSize(), 0); + assertEquals(segment.isMapped(), true); + assertTrue((segment.accessModes() & (READ | WRITE)) == READ); + MappedMemorySegments.force(segment); + MappedMemorySegments.load(segment); + MappedMemorySegments.isLoaded(segment); + MappedMemorySegments.unload(segment); } } From 82bdbfd7fa7a01564745b05237e21fd9dc328547 Mon Sep 17 00:00:00 2001 From: Hao Sun Date: Tue, 5 Jan 2021 16:28:28 +0000 Subject: [PATCH 022/129] 8258857: Zero: non-PCH release build fails after JDK-8258074 Reviewed-by: jiefu, shade, iklam --- src/hotspot/share/compiler/compiler_globals.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/hotspot/share/compiler/compiler_globals.hpp b/src/hotspot/share/compiler/compiler_globals.hpp index 9cb81a44bd4e6..e3aa20c4f1540 100644 --- a/src/hotspot/share/compiler/compiler_globals.hpp +++ b/src/hotspot/share/compiler/compiler_globals.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #ifndef SHARE_COMPILER_COMPILER_GLOBALS_HPP #define SHARE_COMPILER_COMPILER_GLOBALS_HPP +#include "compiler/compiler_globals_pd.hpp" #include "runtime/globals_shared.hpp" #ifdef COMPILER1 #include "c1/c1_globals.hpp" From d5aa49d15417b72bd9a87cdfd5c3fcdf3704b5cf Mon Sep 17 00:00:00 2001 From: Claes Redestad Date: Tue, 5 Jan 2021 16:41:17 +0000 Subject: [PATCH 023/129] 8259236: C2 compilation fails with assert(is_power_of_2(value)) failed: value must be a power of 2: 8000000000000000 Reviewed-by: thartmann --- src/hotspot/cpu/x86/x86_64.ad | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hotspot/cpu/x86/x86_64.ad b/src/hotspot/cpu/x86/x86_64.ad index 7b23b45ef1ead..13b8125ad108f 100644 --- a/src/hotspot/cpu/x86/x86_64.ad +++ b/src/hotspot/cpu/x86/x86_64.ad @@ -9600,7 +9600,7 @@ instruct btrL_mem_imm(memory dst, immL_NotPow2 con, rFlagsReg cr) ins_cost(125); format %{ "btrq $dst, log2(not($con))\t# long" %} ins_encode %{ - __ btrq($dst$$Address, log2i_exact(~$con$$constant)); + __ btrq($dst$$Address, log2i_exact((julong)~$con$$constant)); %} ins_pipe(ialu_mem_imm); %} From 85bac8c415070992a9807599fe1ec07e4ed0c562 Mon Sep 17 00:00:00 2001 From: Peter Levart Date: Tue, 5 Jan 2021 17:41:50 +0000 Subject: [PATCH 024/129] 8259021: SharedSecrets should avoid double racy reads from non-volatile fields Reviewed-by: shade, redestad, rriggs, mchung, rrich, alanb --- .../jdk/internal/access/SharedSecrets.java | 138 ++++++++++++------ 1 file changed, 93 insertions(+), 45 deletions(-) diff --git a/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java b/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java index 1111afcf88315..5a1a59898e000 100644 --- a/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java +++ b/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -83,21 +83,25 @@ public static void setJavaUtilCollectionAccess(JavaUtilCollectionAccess juca) { } public static JavaUtilCollectionAccess getJavaUtilCollectionAccess() { - if (javaUtilCollectionAccess == null) { + var access = javaUtilCollectionAccess; + if (access == null) { try { Class.forName("java.util.ImmutableCollections$Access", true, null); + access = javaUtilCollectionAccess; } catch (ClassNotFoundException e) {}; } - return javaUtilCollectionAccess; + return access; } public static JavaUtilJarAccess javaUtilJarAccess() { - if (javaUtilJarAccess == null) { + var access = javaUtilJarAccess; + if (access == null) { // Ensure JarFile is initialized; we know that this class // provides the shared secret ensureClassInitialized(JarFile.class); + access = javaUtilJarAccess; } - return javaUtilJarAccess; + return access; } public static void setJavaUtilJarAccess(JavaUtilJarAccess access) { @@ -117,12 +121,14 @@ public static void setJavaLangInvokeAccess(JavaLangInvokeAccess jlia) { } public static JavaLangInvokeAccess getJavaLangInvokeAccess() { - if (javaLangInvokeAccess == null) { + var access = javaLangInvokeAccess; + if (access == null) { try { Class.forName("java.lang.invoke.MethodHandleImpl", true, null); + access = javaLangInvokeAccess; } catch (ClassNotFoundException e) {}; } - return javaLangInvokeAccess; + return access; } public static void setJavaLangModuleAccess(JavaLangModuleAccess jlrma) { @@ -130,10 +136,12 @@ public static void setJavaLangModuleAccess(JavaLangModuleAccess jlrma) { } public static JavaLangModuleAccess getJavaLangModuleAccess() { - if (javaLangModuleAccess == null) { + var access = javaLangModuleAccess; + if (access == null) { ensureClassInitialized(ModuleDescriptor.class); + access = javaLangModuleAccess; } - return javaLangModuleAccess; + return access; } public static void setJavaLangRefAccess(JavaLangRefAccess jlra) { @@ -157,9 +165,12 @@ public static void setJavaNetUriAccess(JavaNetUriAccess jnua) { } public static JavaNetUriAccess getJavaNetUriAccess() { - if (javaNetUriAccess == null) + var access = javaNetUriAccess; + if (access == null) { ensureClassInitialized(java.net.URI.class); - return javaNetUriAccess; + access = javaNetUriAccess; + } + return access; } public static void setJavaNetURLAccess(JavaNetURLAccess jnua) { @@ -167,9 +178,12 @@ public static void setJavaNetURLAccess(JavaNetURLAccess jnua) { } public static JavaNetURLAccess getJavaNetURLAccess() { - if (javaNetURLAccess == null) + var access = javaNetURLAccess; + if (access == null) { ensureClassInitialized(java.net.URL.class); - return javaNetURLAccess; + access = javaNetURLAccess; + } + return access; } public static void setJavaNetInetAddressAccess(JavaNetInetAddressAccess jna) { @@ -177,9 +191,12 @@ public static void setJavaNetInetAddressAccess(JavaNetInetAddressAccess jna) { } public static JavaNetInetAddressAccess getJavaNetInetAddressAccess() { - if (javaNetInetAddressAccess == null) + var access = javaNetInetAddressAccess; + if (access == null) { ensureClassInitialized(java.net.InetAddress.class); - return javaNetInetAddressAccess; + access = javaNetInetAddressAccess; + } + return access; } public static void setJavaNetHttpCookieAccess(JavaNetHttpCookieAccess a) { @@ -187,9 +204,12 @@ public static void setJavaNetHttpCookieAccess(JavaNetHttpCookieAccess a) { } public static JavaNetHttpCookieAccess getJavaNetHttpCookieAccess() { - if (javaNetHttpCookieAccess == null) + var access = javaNetHttpCookieAccess; + if (access == null) { ensureClassInitialized(java.net.HttpCookie.class); - return javaNetHttpCookieAccess; + access = javaNetHttpCookieAccess; + } + return access; } public static void setJavaNioAccess(JavaNioAccess jna) { @@ -197,12 +217,14 @@ public static void setJavaNioAccess(JavaNioAccess jna) { } public static JavaNioAccess getJavaNioAccess() { - if (javaNioAccess == null) { + var access = javaNioAccess; + if (access == null) { // Ensure java.nio.Buffer is initialized, which provides the // shared secret. ensureClassInitialized(java.nio.Buffer.class); + access = javaNioAccess; } - return javaNioAccess; + return access; } public static void setJavaIOAccess(JavaIOAccess jia) { @@ -210,10 +232,12 @@ public static void setJavaIOAccess(JavaIOAccess jia) { } public static JavaIOAccess getJavaIOAccess() { - if (javaIOAccess == null) { + var access = javaIOAccess; + if (access == null) { ensureClassInitialized(Console.class); + access = javaIOAccess; } - return javaIOAccess; + return access; } public static void setJavaIOFileDescriptorAccess(JavaIOFileDescriptorAccess jiofda) { @@ -221,10 +245,12 @@ public static void setJavaIOFileDescriptorAccess(JavaIOFileDescriptorAccess jiof } public static JavaIOFilePermissionAccess getJavaIOFilePermissionAccess() { - if (javaIOFilePermissionAccess == null) + var access = javaIOFilePermissionAccess; + if (access == null) { ensureClassInitialized(FilePermission.class); - - return javaIOFilePermissionAccess; + access = javaIOFilePermissionAccess; + } + return access; } public static void setJavaIOFilePermissionAccess(JavaIOFilePermissionAccess jiofpa) { @@ -232,10 +258,12 @@ public static void setJavaIOFilePermissionAccess(JavaIOFilePermissionAccess jiof } public static JavaIOFileDescriptorAccess getJavaIOFileDescriptorAccess() { - if (javaIOFileDescriptorAccess == null) + var access = javaIOFileDescriptorAccess; + if (access == null) { ensureClassInitialized(FileDescriptor.class); - - return javaIOFileDescriptorAccess; + access = javaIOFileDescriptorAccess; + } + return access; } public static void setJavaSecurityAccess(JavaSecurityAccess jsa) { @@ -243,16 +271,21 @@ public static void setJavaSecurityAccess(JavaSecurityAccess jsa) { } public static JavaSecurityAccess getJavaSecurityAccess() { - if (javaSecurityAccess == null) { + var access = javaSecurityAccess; + if (access == null) { ensureClassInitialized(ProtectionDomain.class); + access = javaSecurityAccess; } - return javaSecurityAccess; + return access; } public static JavaUtilZipFileAccess getJavaUtilZipFileAccess() { - if (javaUtilZipFileAccess == null) + var access = javaUtilZipFileAccess; + if (access == null) { ensureClassInitialized(java.util.zip.ZipFile.class); - return javaUtilZipFileAccess; + access = javaUtilZipFileAccess; + } + return access; } public static void setJavaUtilZipFileAccess(JavaUtilZipFileAccess access) { @@ -288,9 +321,12 @@ public static void setJavaBeansAccess(JavaBeansAccess access) { } public static JavaUtilResourceBundleAccess getJavaUtilResourceBundleAccess() { - if (javaUtilResourceBundleAccess == null) + var access = javaUtilResourceBundleAccess; + if (access == null) { ensureClassInitialized(ResourceBundle.class); - return javaUtilResourceBundleAccess; + access = javaUtilResourceBundleAccess; + } + return access; } public static void setJavaUtilResourceBundleAccess(JavaUtilResourceBundleAccess access) { @@ -298,10 +334,12 @@ public static void setJavaUtilResourceBundleAccess(JavaUtilResourceBundleAccess } public static JavaObjectInputStreamReadString getJavaObjectInputStreamReadString() { - if (javaObjectInputStreamReadString == null) { + var access = javaObjectInputStreamReadString; + if (access == null) { ensureClassInitialized(ObjectInputStream.class); + access = javaObjectInputStreamReadString; } - return javaObjectInputStreamReadString; + return access; } public static void setJavaObjectInputStreamReadString(JavaObjectInputStreamReadString access) { @@ -309,10 +347,12 @@ public static void setJavaObjectInputStreamReadString(JavaObjectInputStreamReadS } public static JavaObjectInputStreamAccess getJavaObjectInputStreamAccess() { - if (javaObjectInputStreamAccess == null) { + var access = javaObjectInputStreamAccess; + if (access == null) { ensureClassInitialized(ObjectInputStream.class); + access = javaObjectInputStreamAccess; } - return javaObjectInputStreamAccess; + return access; } public static void setJavaObjectInputStreamAccess(JavaObjectInputStreamAccess access) { @@ -320,10 +360,12 @@ public static void setJavaObjectInputStreamAccess(JavaObjectInputStreamAccess ac } public static JavaObjectInputFilterAccess getJavaObjectInputFilterAccess() { - if (javaObjectInputFilterAccess == null) { + var access = javaObjectInputFilterAccess; + if (access == null) { ensureClassInitialized(ObjectInputFilter.Config.class); + access = javaObjectInputFilterAccess; } - return javaObjectInputFilterAccess; + return access; } public static void setJavaObjectInputFilterAccess(JavaObjectInputFilterAccess access) { @@ -335,10 +377,12 @@ public static void setJavaIORandomAccessFileAccess(JavaIORandomAccessFileAccess } public static JavaIORandomAccessFileAccess getJavaIORandomAccessFileAccess() { - if (javaIORandomAccessFileAccess == null) { + var access = javaIORandomAccessFileAccess; + if (access == null) { ensureClassInitialized(RandomAccessFile.class); + access = javaIORandomAccessFileAccess; } - return javaIORandomAccessFileAccess; + return access; } public static void setJavaSecuritySignatureAccess(JavaSecuritySignatureAccess jssa) { @@ -346,10 +390,12 @@ public static void setJavaSecuritySignatureAccess(JavaSecuritySignatureAccess js } public static JavaSecuritySignatureAccess getJavaSecuritySignatureAccess() { - if (javaSecuritySignatureAccess == null) { + var access = javaSecuritySignatureAccess; + if (access == null) { ensureClassInitialized(Signature.class); + access = javaSecuritySignatureAccess; } - return javaSecuritySignatureAccess; + return access; } public static void setJavaxCryptoSealedObjectAccess(JavaxCryptoSealedObjectAccess jcsoa) { @@ -357,10 +403,12 @@ public static void setJavaxCryptoSealedObjectAccess(JavaxCryptoSealedObjectAcces } public static JavaxCryptoSealedObjectAccess getJavaxCryptoSealedObjectAccess() { - if (javaxCryptoSealedObjectAccess == null) { + var access = javaxCryptoSealedObjectAccess; + if (access == null) { ensureClassInitialized(SealedObject.class); + access = javaxCryptoSealedObjectAccess; } - return javaxCryptoSealedObjectAccess; + return access; } private static void ensureClassInitialized(Class c) { From 50bf4330302174322bf04cf31d905dd9558a1334 Mon Sep 17 00:00:00 2001 From: Sandhya Viswanathan Date: Tue, 5 Jan 2021 17:42:22 +0000 Subject: [PATCH 025/129] 8259213: Vector conversion with part > 0 is not getting intrinsic implementation Reviewed-by: psandoz --- .../classes/jdk/incubator/vector/AbstractShuffle.java | 5 ++++- .../classes/jdk/incubator/vector/AbstractVector.java | 9 ++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java index 21f722b5d168e..4d9e714263b5e 100644 --- a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java +++ b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -120,6 +120,9 @@ public int[] toArray() { @ForceInline public final VectorShuffle checkIndexes() { + if (VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK == 0) { + return this; + } // FIXME: vectorize this for (int index : reorder()) { if (index < 0) { diff --git a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java index 3b882a67503da..1ffdb058a273c 100644 --- a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java +++ b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -312,7 +312,7 @@ AbstractVector reinterpretShapeTemplate(VectorSpecies toSpecies, int part) int origin = shapeChangeOrigin(vsp, rsp, false, part); //System.out.println("*** origin = "+origin+", part = "+part+", reinterpret"); if (part > 0) { // Expansion: slice first then cast. - return slice(origin, vsp.zero()).convert0('X', rsp); + return slice(origin).convert0('X', rsp); } else { // Contraction: cast first then unslice. return rsp.zero().slice(rsp.laneCount() - origin, convert0('X', rsp)); @@ -323,6 +323,9 @@ AbstractVector reinterpretShapeTemplate(VectorSpecies toSpecies, int part) @Override public abstract AbstractVector slice(int origin, Vector v1); + @Override + public abstract AbstractVector slice(int origin); + /** * This is the template for Vector::convertShape, to be * specialized by each distinct vector class. @@ -365,7 +368,7 @@ AbstractVector convertShapeTemplate(Conversion conv, VectorSpecies to int origin = shapeChangeOrigin(vsp, rsp, true, part); //System.out.println("*** origin = "+origin+", part = "+part+", lanewise"); if (part > 0) { // Expansion: slice first then cast. - return slice(origin, vsp.zero()).convert0(kind, rsp); + return slice(origin).convert0(kind, rsp); } else { // Contraction: cast first then unslice. return rsp.zero().slice(rsp.laneCount() - origin, convert0(kind, rsp)); From 7ddc2b5606cd5353a3c25dde476ff0e6ccc2ed23 Mon Sep 17 00:00:00 2001 From: Xue-Lei Andrew Fan Date: Tue, 5 Jan 2021 18:29:35 +0000 Subject: [PATCH 026/129] 8258852: Arrays.asList() for single item could be replaced with List.of() Reviewed-by: mullan --- .../share/classes/sun/security/ssl/ClientHello.java | 6 +++--- .../classes/sun/security/ssl/KeyShareExtension.java | 12 ++++-------- .../classes/sun/security/ssl/SSLConfiguration.java | 10 ++++------ 3 files changed, 11 insertions(+), 17 deletions(-) diff --git a/src/java.base/share/classes/sun/security/ssl/ClientHello.java b/src/java.base/share/classes/sun/security/ssl/ClientHello.java index 3d7733a158fbe..967f8f469a4af 100644 --- a/src/java.base/share/classes/sun/security/ssl/ClientHello.java +++ b/src/java.base/share/classes/sun/security/ssl/ClientHello.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -558,7 +558,7 @@ public byte[] produce(ConnectionContext context) throws IOException { cipherSuites = Arrays.asList(sessionSuite, CipherSuite.TLS_EMPTY_RENEGOTIATION_INFO_SCSV); } else { // otherwise, use renegotiation_info extension - cipherSuites = Arrays.asList(sessionSuite); + cipherSuites = List.of(sessionSuite); } if (SSLLogger.isOn && @@ -1076,7 +1076,7 @@ public void consume(ConnectionContext context, // Check and launch ClientHello extensions. SSLExtension[] extTypes = shc.sslConfig.getExclusiveExtensions( SSLHandshake.CLIENT_HELLO, - Arrays.asList(SSLExtension.CH_SESSION_TICKET)); + List.of(SSLExtension.CH_SESSION_TICKET)); clientHello.extensions.consumeOnLoad(shc, extTypes); // diff --git a/src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java b/src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java index 4097f64cfe17d..a0d9b98a77a36 100644 --- a/src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java +++ b/src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ import java.nio.ByteBuffer; import java.security.GeneralSecurityException; import java.text.MessageFormat; -import java.util.Arrays; import java.util.Collections; import java.util.EnumSet; import java.util.LinkedList; @@ -236,7 +235,7 @@ public byte[] produce(ConnectionContext context, List namedGroups; if (chc.serverSelectedNamedGroup != null) { // Response to HelloRetryRequest - namedGroups = Arrays.asList(chc.serverSelectedNamedGroup); + namedGroups = List.of(chc.serverSelectedNamedGroup); } else { namedGroups = chc.clientRequestedNamedGroups; if (namedGroups == null || namedGroups.isEmpty()) { @@ -289,7 +288,6 @@ public byte[] produce(ConnectionContext context, private static byte[] getShare(ClientHandshakeContext chc, NamedGroup ng) { - byte[] share = null; SSLKeyExchange ke = SSLKeyExchange.valueOf(ng); if (ke == null) { if (SSLLogger.isOn && SSLLogger.isOn("ssl,handshake")) { @@ -307,7 +305,7 @@ private static byte[] getShare(ClientHandshakeContext chc, } } } - return share; + return null; } } @@ -836,12 +834,10 @@ public byte[] produce(ConnectionContext context, spec.clientShares.size() == 1) { int namedGroupId = spec.clientShares.get(0).namedGroupId; - byte[] extdata = new byte[] { + return new byte[] { (byte)((namedGroupId >> 8) & 0xFF), (byte)(namedGroupId & 0xFF) }; - - return extdata; } return null; diff --git a/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java b/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java index f9a7c64e506c2..37d6562dc1781 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,7 +30,6 @@ import java.security.AlgorithmConstraints; import java.security.NoSuchAlgorithmException; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.HashMap; @@ -139,8 +138,8 @@ final class SSLConfiguration implements Cloneable { this.clientAuthType = ClientAuthType.CLIENT_AUTH_NONE; this.identificationProtocol = null; - this.serverNames = Collections.emptyList(); - this.sniMatchers = Collections.emptyList(); + this.serverNames = Collections.emptyList(); + this.sniMatchers = Collections.emptyList(); this.preferLocalCipherSuites = true; this.applicationProtocols = new String[0]; @@ -368,8 +367,7 @@ SSLExtension[] getExclusiveExtensions(SSLHandshake handshakeType, */ SSLExtension[] getEnabledExtensions( SSLHandshake handshakeType, ProtocolVersion protocolVersion) { - return getEnabledExtensions( - handshakeType, Arrays.asList(protocolVersion)); + return getEnabledExtensions(handshakeType, List.of(protocolVersion)); } /** From 1b60acd8aa9cbf9aed9deaf16a8eb6c09b44ee55 Mon Sep 17 00:00:00 2001 From: Zhengyu Gu Date: Tue, 5 Jan 2021 18:33:41 +0000 Subject: [PATCH 027/129] 8259252: Shenandoah: Shenandoah build failed on AArch64 after JDK-8258459 Reviewed-by: rkennke, shade --- .../gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp b/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp index c05b5f9952477..1347241a7600c 100644 --- a/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp +++ b/src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Red Hat, Inc. All rights reserved. + * Copyright (c) 2018, 2021, Red Hat, Inc. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ #include "precompiled.hpp" #include "c1/c1_LIRAssembler.hpp" #include "c1/c1_MacroAssembler.hpp" +#include "gc/shared/gc_globals.hpp" #include "gc/shenandoah/shenandoahBarrierSet.hpp" #include "gc/shenandoah/shenandoahBarrierSetAssembler.hpp" #include "gc/shenandoah/c1/shenandoahBarrierSetC1.hpp" From 4d3d59912d71a05865b87bb2579571fbda74b668 Mon Sep 17 00:00:00 2001 From: Xue-Lei Andrew Fan Date: Tue, 5 Jan 2021 19:32:46 +0000 Subject: [PATCH 028/129] 8259223: Simplify boolean expression in the SunJSSE provider Reviewed-by: mullan --- .../classes/sun/security/ssl/CipherSuite.java | 4 ++-- .../sun/security/ssl/EphemeralKeyManager.java | 4 ++-- .../share/classes/sun/security/ssl/Finished.java | 4 ++-- .../sun/security/ssl/HandshakeContext.java | 4 ++-- .../sun/security/ssl/KeyManagerFactoryImpl.java | 4 ++-- .../sun/security/ssl/ProtocolVersion.java | 8 ++++---- .../classes/sun/security/ssl/SSLSocketImpl.java | 6 +++--- .../sun/security/ssl/SignatureScheme.java | 6 +++--- .../sun/security/ssl/SunX509KeyManagerImpl.java | 8 ++++---- .../security/ssl/TrustManagerFactoryImpl.java | 6 +++--- .../sun/security/ssl/X509KeyManagerImpl.java | 16 ++++++++-------- 11 files changed, 35 insertions(+), 35 deletions(-) diff --git a/src/java.base/share/classes/sun/security/ssl/CipherSuite.java b/src/java.base/share/classes/sun/security/ssl/CipherSuite.java index 24d7e1ded8157..95246513a3051 100644 --- a/src/java.base/share/classes/sun/security/ssl/CipherSuite.java +++ b/src/java.base/share/classes/sun/security/ssl/CipherSuite.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -890,7 +890,7 @@ private CipherSuite(int id, boolean isDefaultEnabled, this.macAlg = macAlg; this.hashAlg = hashAlg; - this.exportable = (cipher == null ? false : cipher.exportable); + this.exportable = (cipher != null && cipher.exportable); } static CipherSuite nameOf(String ciperSuiteName) { diff --git a/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java b/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java index 2e5540f1f59d6..ab3e35dc83ae3 100644 --- a/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java +++ b/src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -128,7 +128,7 @@ private boolean isValid() { * Return the KeyPair or null if it is invalid. */ private KeyPair getKeyPair() { - if (isValid() == false) { + if (!isValid()) { keyPair = null; return null; } diff --git a/src/java.base/share/classes/sun/security/ssl/Finished.java b/src/java.base/share/classes/sun/security/ssl/Finished.java index 60c0abe314a34..01fdf4766415e 100644 --- a/src/java.base/share/classes/sun/security/ssl/Finished.java +++ b/src/java.base/share/classes/sun/security/ssl/Finished.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -325,7 +325,7 @@ public byte[] createVerifyData(HandshakeContext context, } } - // TLS 1.2 + // TLS 1.3 private static final class T13VerifyDataGenerator implements VerifyDataGenerator { private static final byte[] hkdfLabel = "tls13 finished".getBytes(); diff --git a/src/java.base/share/classes/sun/security/ssl/HandshakeContext.java b/src/java.base/share/classes/sun/security/ssl/HandshakeContext.java index 50ee421bae251..af713f8422536 100644 --- a/src/java.base/share/classes/sun/security/ssl/HandshakeContext.java +++ b/src/java.base/share/classes/sun/security/ssl/HandshakeContext.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -576,7 +576,7 @@ private static boolean isActivatable(CipherSuite suite, retval |= groupAvailable; } else { - retval |= true; + retval = true; } } diff --git a/src/java.base/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java b/src/java.base/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java index 7256466033f10..b97b41bf1d1eb 100644 --- a/src/java.base/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -99,7 +99,7 @@ protected void engineInit(KeyStore ks, char[] password) throws @Override protected void engineInit(ManagerFactoryParameters params) throws InvalidAlgorithmParameterException { - if (params instanceof KeyStoreBuilderParameters == false) { + if (!(params instanceof KeyStoreBuilderParameters)) { throw new InvalidAlgorithmParameterException( "Parameters must be instance of KeyStoreBuilderParameters"); } diff --git a/src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java b/src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java index 58ed9acd8c793..e4cb5637c60e1 100644 --- a/src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java +++ b/src/java.base/share/classes/sun/security/ssl/ProtocolVersion.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -356,7 +356,7 @@ boolean useTLS12PlusSpec() { * TLS 1.1/DTLS 1.0 or newer version. */ boolean useTLS11PlusSpec() { - return isDTLS ? true : (this.id >= TLS11.id); + return isDTLS || (this.id >= TLS11.id); } /** @@ -364,7 +364,7 @@ boolean useTLS11PlusSpec() { * newer version. */ boolean useTLS10PlusSpec() { - return isDTLS ? true : (this.id >= TLS10.id); + return isDTLS || (this.id >= TLS10.id); } /** @@ -372,7 +372,7 @@ boolean useTLS10PlusSpec() { * newer version. */ static boolean useTLS10PlusSpec(int id, boolean isDTLS) { - return isDTLS ? true : (id >= TLS10.id); + return isDTLS || (id >= TLS10.id); } /** diff --git a/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java b/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java index 8b28a49eba634..91a7822958727 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -837,7 +837,7 @@ private void shutdownInput( @Override public boolean isInputShutdown() { return conContext.isInboundClosed() && - ((autoClose || !isLayered()) ? super.isInputShutdown(): true); + (!autoClose && isLayered() || super.isInputShutdown()); } // Please don't synchronized this method. Otherwise, the read and close @@ -861,7 +861,7 @@ public void shutdownOutput() throws IOException { @Override public boolean isOutputShutdown() { return conContext.isOutboundClosed() && - ((autoClose || !isLayered()) ? super.isOutputShutdown(): true); + (!autoClose && isLayered() || super.isOutputShutdown()); } @Override diff --git a/src/java.base/share/classes/sun/security/ssl/SignatureScheme.java b/src/java.base/share/classes/sun/security/ssl/SignatureScheme.java index fe089b1403a9a..ec34aa13c0e12 100644 --- a/src/java.base/share/classes/sun/security/ssl/SignatureScheme.java +++ b/src/java.base/share/classes/sun/security/ssl/SignatureScheme.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -364,8 +364,8 @@ private boolean isPermitted(AlgorithmConstraints constraints) { constraints.permits(SIGNATURE_PRIMITIVE_SET, this.algorithm, (signAlgParams != null ? signAlgParams.parameters : null)) && - (namedGroup != null ? - namedGroup.isPermitted(constraints) : true); + (namedGroup == null || + namedGroup.isPermitted(constraints)); } // Get local supported algorithm collection complying to algorithm diff --git a/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java b/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java index 115a683cddd43..22a4d68ed85ad 100644 --- a/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -139,7 +139,7 @@ Set getIssuerX500Principals() { continue; } Key key = ks.getKey(alias, password); - if (key instanceof PrivateKey == false) { + if (!(key instanceof PrivateKey)) { continue; } Certificate[] certs = ks.getCertificateChain(alias); @@ -334,7 +334,7 @@ private String[] getAliases(String keyType, Principal[] issuers) { if (issuers == null) { issuers = new X500Principal[0]; } - if (issuers instanceof X500Principal[] == false) { + if (!(issuers instanceof X500Principal[])) { // normally, this will never happen but try to recover if it does issuers = convertPrincipals(issuers); } @@ -375,7 +375,7 @@ private String[] getAliases(String keyType, Principal[] issuers) { certs[0].getSigAlgName().toUpperCase(Locale.ENGLISH); String pattern = "WITH" + sigType.toUpperCase(Locale.ENGLISH); - if (sigAlgName.contains(pattern) == false) { + if (!sigAlgName.contains(pattern)) { continue; } } diff --git a/src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java b/src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java index 1eab2e6363ad2..3830cb693e390 100644 --- a/src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -155,13 +155,13 @@ X509TrustManager getInstance( @Override X509TrustManager getInstance(ManagerFactoryParameters spec) throws InvalidAlgorithmParameterException { - if (spec instanceof CertPathTrustManagerParameters == false) { + if (!(spec instanceof CertPathTrustManagerParameters)) { throw new InvalidAlgorithmParameterException ("Parameters must be CertPathTrustManagerParameters"); } CertPathParameters params = ((CertPathTrustManagerParameters)spec).getParameters(); - if (params instanceof PKIXBuilderParameters == false) { + if (!(params instanceof PKIXBuilderParameters)) { throw new InvalidAlgorithmParameterException ("Encapsulated parameters must be PKIXBuilderParameters"); } diff --git a/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java b/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java index 4ab78a4586856..c2bd09e00da17 100644 --- a/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java +++ b/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2004, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -271,7 +271,7 @@ private PrivateKeyEntry getEntry(String alias) { KeyStore ks = builder.getKeyStore(); Entry newEntry = ks.getEntry (keyStoreAlias, builder.getProtectionParameter(alias)); - if (newEntry instanceof PrivateKeyEntry == false) { + if (!(newEntry instanceof PrivateKeyEntry)) { // unexpected type of entry return null; } @@ -581,7 +581,7 @@ CheckResult check(X509Certificate cert, Date date, // require either signature bit // or if server also allow key encipherment bit if (!supportsDigitalSignature) { - if (this == CLIENT || getBit(ku, 2) == false) { + if (this == CLIENT || !getBit(ku, 2)) { return CheckResult.EXTENSION_MISMATCH; } } @@ -599,7 +599,7 @@ CheckResult check(X509Certificate cert, Date date, break; case "DH": // require keyagreement bit - if (getBit(ku, 4) == false) { + if (!getBit(ku, 4)) { return CheckResult.EXTENSION_MISMATCH; } break; @@ -614,7 +614,7 @@ CheckResult check(X509Certificate cert, Date date, // exchange and not ephemeral ECDH. We leave it in // for now until there are signs that this check // causes problems for real world EC certificates. - if ((this == SERVER) && (getBit(ku, 4) == false)) { + if (this == SERVER && !getBit(ku, 4)) { return CheckResult.EXTENSION_MISMATCH; } break; @@ -748,7 +748,7 @@ private List getAliases(int builderIndex, boolean incompatible = false; for (Certificate cert : chain) { - if (cert instanceof X509Certificate == false) { + if (!(cert instanceof X509Certificate)) { // not an X509Certificate, ignore this alias incompatible = true; break; @@ -785,7 +785,7 @@ private List getAliases(int builderIndex, break; } } - if (found == false) { + if (!found) { if (SSLLogger.isOn && SSLLogger.isOn("keymanager")) { SSLLogger.fine( "Ignore alias " + alias @@ -820,7 +820,7 @@ private List getAliases(int builderIndex, if (!preferred && checkResult == CheckResult.OK && keyIndex == 0) { preferred = true; } - if (preferred && (findAll == false)) { + if (preferred && !findAll) { // if we have a good match and do not need all matches, // return immediately return Collections.singletonList(status); From cf9908b437cb3847c1e813f6eccdc1d3326742ff Mon Sep 17 00:00:00 2001 From: Harold Seigel Date: Tue, 5 Jan 2021 21:15:13 +0000 Subject: [PATCH 029/129] 8258937: Remove JVM IgnoreRewrites flag Reviewed-by: coleenp --- src/hotspot/share/oops/generateOopMap.cpp | 27 ++--------------------- src/hotspot/share/runtime/globals.hpp | 4 ---- 2 files changed, 2 insertions(+), 29 deletions(-) diff --git a/src/hotspot/share/oops/generateOopMap.cpp b/src/hotspot/share/oops/generateOopMap.cpp index 6ca4dce1ff71b..83d7539242dab 100644 --- a/src/hotspot/share/oops/generateOopMap.cpp +++ b/src/hotspot/share/oops/generateOopMap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -2263,34 +2263,11 @@ void GenerateOopMap::rewrite_refval_conflicts() return; // Check if rewrites are allowed in this parse. - if (!allow_rewrites() && !IgnoreRewrites) { + if (!allow_rewrites()) { fatal("Rewriting method not allowed at this stage"); } - // This following flag is to tempoary supress rewrites. The locals that might conflict will - // all be set to contain values. This is UNSAFE - however, until the rewriting has been completely - // tested it is nice to have. - if (IgnoreRewrites) { - if (Verbose) { - tty->print("rewrites suppressed for local no. "); - for (int l = 0; l < _max_locals; l++) { - if (_new_var_map[l] != l) { - tty->print("%d ", l); - vars()[l] = CellTypeState::value; - } - } - tty->cr(); - } - - // That was that... - _new_var_map = NULL; - _nof_refval_conflicts = 0; - _conflict = false; - - return; - } - // Tracing flag _did_rewriting = true; diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp index b79332fed6b20..096f1943d6f32 100644 --- a/src/hotspot/share/runtime/globals.hpp +++ b/src/hotspot/share/runtime/globals.hpp @@ -674,10 +674,6 @@ const intx ObjectAlignmentInBytes = 8; "Tell whether the VM should register soft/weak/final/phantom " \ "references") \ \ - develop(bool, IgnoreRewrites, false, \ - "Suppress rewrites of bytecodes in the oopmap generator. " \ - "This is unsafe!") \ - \ develop(bool, PrintCodeCacheExtension, false, \ "Print extension of code cache") \ \ From d5293067226011a96f97cd5e8efe0dd2dff521b2 Mon Sep 17 00:00:00 2001 From: Vicente Romero Date: Tue, 5 Jan 2021 21:35:47 +0000 Subject: [PATCH 030/129] 8213032: program fails with LambdaConversionException at execution time Reviewed-by: jlahoda --- .../sun/tools/javac/comp/LambdaToMethod.java | 17 ++++--- .../MethodReferenceIntersection4.java | 45 +++++++++++++++++++ 2 files changed, 56 insertions(+), 6 deletions(-) create mode 100644 test/langtools/tools/javac/lambda/methodReferenceExecution/MethodReferenceIntersection4.java diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java index 9e8a083eea3f8..4a6ae3a184614 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java @@ -968,14 +968,19 @@ VarSymbol addParametersReturnReceiver() { for (int i = 0; implPTypes.nonEmpty() && i < last; ++i) { // By default use the implementation method parameter type Type parmType = implPTypes.head; - // If the unerased parameter type is a type variable whose - // bound is an intersection (eg. ) then - // use the SAM parameter type - if (checkForIntersection && descPTypes.head.getKind() == TypeKind.TYPEVAR) { - TypeVar tv = (TypeVar) descPTypes.head; - if (tv.getUpperBound().getKind() == TypeKind.INTERSECTION) { + if (checkForIntersection) { + if (descPTypes.head.getKind() == TypeKind.INTERSECTION) { parmType = samPTypes.head; } + // If the unerased parameter type is a type variable whose + // bound is an intersection (eg. ) then + // use the SAM parameter type + if (descPTypes.head.getKind() == TypeKind.TYPEVAR) { + TypeVar tv = (TypeVar) descPTypes.head; + if (tv.getUpperBound().getKind() == TypeKind.INTERSECTION) { + parmType = samPTypes.head; + } + } } addParameter("x$" + i, parmType, true); diff --git a/test/langtools/tools/javac/lambda/methodReferenceExecution/MethodReferenceIntersection4.java b/test/langtools/tools/javac/lambda/methodReferenceExecution/MethodReferenceIntersection4.java new file mode 100644 index 0000000000000..36d7c1410ff1b --- /dev/null +++ b/test/langtools/tools/javac/lambda/methodReferenceExecution/MethodReferenceIntersection4.java @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @bug 8213032 + * @summary program fails with LambdaConversionException at execution time + */ + +import java.util.stream.*; + +public class MethodReferenceIntersection4 { + interface I {} + static abstract class C { } + static class A extends C implements I { } + static class B extends C implements I { } + + static String f(I i) { return null; } + + public static void main(String[] args) { + Stream.of(new A(), new B()) + .map(MethodReferenceIntersection4::f) + .forEach(System.out::println); + } +} From 7d769663b3a7da0db64a6bb4d2aaee595afe3242 Mon Sep 17 00:00:00 2001 From: Guoxiong Li Date: Tue, 5 Jan 2021 22:21:19 +0000 Subject: [PATCH 031/129] 8255757: Javac emits duplicate pool entries on array::clone Reviewed-by: vromero --- .../classes/com/sun/tools/javac/jvm/Gen.java | 20 +++- .../javac/classfiles/T8255757/T8255757.java | 103 ++++++++++++++++++ 2 files changed, 120 insertions(+), 3 deletions(-) create mode 100644 test/langtools/tools/javac/classfiles/T8255757/T8255757.java diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java index d93d85746cd5b..f206270f960f9 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,9 @@ package com.sun.tools.javac.jvm; +import java.util.HashMap; +import java.util.Map; + import com.sun.tools.javac.jvm.PoolConstant.LoadableConstant; import com.sun.tools.javac.tree.TreeInfo.PosKind; import com.sun.tools.javac.util.*; @@ -127,6 +130,7 @@ protected Gen(Context context) { // ignore cldc because we cannot have both stackmap formats this.stackMap = StackMapFormat.JSR202; annotate = Annotate.instance(context); + qualifiedSymbolCache = new HashMap<>(); } /** Switches @@ -168,6 +172,12 @@ protected Gen(Context context) { List stackBeforeSwitchExpression; LocalItem switchResult; + /** Cache the symbol to reflect the qualifying type. + * key: corresponding type + * value: qualified symbol + */ + Map qualifiedSymbolCache; + /** Generate code to load an integer constant. * @param n The integer to be loaded. */ @@ -230,8 +240,11 @@ Symbol binaryQualifier(Symbol sym, Type site) { sym.owner != syms.arrayClass) return sym; // array clone can be qualified by the array type in later targets - Symbol qualifier = new ClassSymbol(Flags.PUBLIC, site.tsym.name, - site, syms.noSymbol); + Symbol qualifier; + if ((qualifier = qualifiedSymbolCache.get(site)) == null) { + qualifier = new ClassSymbol(Flags.PUBLIC, site.tsym.name, site, syms.noSymbol); + qualifiedSymbolCache.put(site, qualifier); + } return sym.clone(qualifier); } @@ -2414,6 +2427,7 @@ public boolean genClass(Env env, JCClassDecl cdef) { toplevel = null; endPosTable = null; nerrs = 0; + qualifiedSymbolCache.clear(); } } diff --git a/test/langtools/tools/javac/classfiles/T8255757/T8255757.java b/test/langtools/tools/javac/classfiles/T8255757/T8255757.java new file mode 100644 index 0000000000000..4b1b740b94c19 --- /dev/null +++ b/test/langtools/tools/javac/classfiles/T8255757/T8255757.java @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8255757 + * @summary Javac shouldn't emit duplicate pool entries on array::clone + * @library /tools/lib + * @modules jdk.compiler/com.sun.tools.javac.api + * jdk.compiler/com.sun.tools.javac.main + * jdk.jdeps/com.sun.tools.classfile + * @build toolbox.ToolBox toolbox.JavacTask + * @run main T8255757 + */ + +import java.nio.file.Path; + +import com.sun.tools.classfile.ClassFile; +import com.sun.tools.classfile.ConstantPool; +import com.sun.tools.classfile.ConstantPool.*; + +import toolbox.JavacTask; +import toolbox.ToolBox; +import toolbox.TestRunner; + +public class T8255757 extends TestRunner { + ToolBox tb; + + T8255757() { + super(System.err); + tb = new ToolBox(); + } + + public static void main(String[] args) throws Exception { + T8255757 t = new T8255757(); + t.runTests(); + } + + @Test + public void testDuplicatePoolEntries() throws Exception { + String code = """ + public class Test { + void test(Object[] o) { + o.clone(); + o.clone(); + } + void test2(Object[] o) { + o.clone(); + o.clone(); + } + }"""; + Path curPath = Path.of("."); + new JavacTask(tb) + .sources(code) + .outdir(curPath) + .run(); + + ClassFile cf = ClassFile.read(curPath.resolve("Test.class")); + ConstantPool cp = cf.constant_pool; + int num = 0; + for (CPInfo cpInfo : cp.entries()) { + if (cpInfo instanceof CONSTANT_Methodref_info) { + int class_index = ((CONSTANT_Methodref_info) cpInfo).class_index; + int name_and_type_index = ((CONSTANT_Methodref_info) cpInfo).name_and_type_index; + int class_name_index = ((CONSTANT_Class_info) + cp.getClassInfo(class_index)).name_index; + int method_name_index = ((CONSTANT_NameAndType_info) + cp.getNameAndTypeInfo(name_and_type_index)).name_index; + int method_type_name_index = ((CONSTANT_NameAndType_info) + cp.getNameAndTypeInfo(name_and_type_index)).type_index; + if ("[Ljava/lang/Object;".equals(cp.getUTF8Value(class_name_index)) && + "clone".equals(cp.getUTF8Value(method_name_index)) && + "()Ljava/lang/Object;".equals(cp.getUTF8Value(method_type_name_index))) { + ++num; + } + } + } + if (num != 1) { + throw new AssertionError("The number of the pool entries on array::clone is not right. " + + "Expected number: 1, actual number: " + num); + } + } +} From 8b4549773b649a33f8f6795cd054b4bb2ec607ec Mon Sep 17 00:00:00 2001 From: Yasumasa Suenaga Date: Tue, 5 Jan 2021 22:36:09 +0000 Subject: [PATCH 032/129] 8259037: livenmethods cannot find hsdis library Reviewed-by: cjplummer, sspitsyn --- .../sun/jvm/hotspot/asm/Disassembler.java | 89 ++++++++++++------- .../share/native/libsaproc/sadis.c | 23 +---- 2 files changed, 58 insertions(+), 54 deletions(-) diff --git a/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/asm/Disassembler.java b/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/asm/Disassembler.java index a95227734714d..925a3bedba120 100644 --- a/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/asm/Disassembler.java +++ b/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/asm/Disassembler.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,9 +25,14 @@ package sun.jvm.hotspot.asm; import java.io.PrintStream; +import java.nio.file.Path; +import java.util.List; +import java.util.Iterator; +import java.util.Properties; import sun.jvm.hotspot.code.CodeBlob; import sun.jvm.hotspot.code.NMethod; import sun.jvm.hotspot.debugger.Address; +import sun.jvm.hotspot.debugger.DebuggerException; import sun.jvm.hotspot.runtime.VM; public class Disassembler { @@ -59,44 +64,60 @@ private Disassembler(long startPc, byte[] code) { // Lazily load hsdis if (decode_function == 0) { - StringBuilder path = new StringBuilder(System.getProperty("java.home")); - String sep = System.getProperty("file.separator"); - String os = System.getProperty("os.name"); - String libname = "hsdis"; - String arch = System.getProperty("os.arch"); - if (os.lastIndexOf("Windows", 0) != -1) { - if (arch.equals("x86")) { - libname += "-i386"; - } else if (arch.equals("amd64")) { - libname += "-amd64"; - } else { - libname += "-" + arch; - } - path.append(sep + "bin" + sep); - libname += ".dll"; - } else if (os.lastIndexOf("Linux", 0) != -1) { - if (arch.equals("x86") || arch.equals("i386")) { - path.append(sep + "lib" + sep + "i386" + sep); - libname += "-i386.so"; - } else if (arch.equals("amd64") || arch.equals("x86_64")) { - path.append(sep + "lib" + sep + "amd64" + sep); - libname += "-amd64.so"; - } else { - path.append(sep + "lib" + sep + arch + sep); - libname += "-" + arch + ".so"; + // Search for hsdis library in the following 4 locations: + // 1. /lib//libhsdis-.so + // 2. /lib//hsdis-.so + // 3. /lib/hsdis-.so + // 4. hsdis-.so (using LD_LIBRARY_PATH) + Properties targetSysProps = VM.getVM().getSystemProperties(); + String os = targetSysProps.getProperty("os.name"); + String ext = ".so"; + if (os.contains("Windows")) { + ext = ".dll"; + } else if (os.contains("Mac OS")) { + ext = ".dylib"; + } + + // Find the full path to libjvm.so (jvm.dll and libjvm.dylib on Windows and OSX). + String jvmPattern = "^(lib)?jvm\\" + ext + "$"; + Path jvmPath = VM.getVM() + .getDebugger() + .getCDebugger() + .getLoadObjectList() + .stream() + .map(o -> Path.of(o.getName())) + .filter(p -> p.getFileName().toString().matches(jvmPattern)) + .findAny() + .get(); + + String arch = targetSysProps.getProperty("os.arch"); + String libname = "hsdis-" + arch + ext; + + List libs = List.of( + // 1. /lib//libhsdis-.so + jvmPath.resolveSibling("lib" + libname).toString(), + // 2. /lib//hsdis-.so + jvmPath.resolveSibling(libname).toString(), + // 3. /lib/hsdis-.so + jvmPath.getParent().resolveSibling(libname).toString(), + // 4. hsdis-.so (using LD_LIBRARY_PATH) + libname + ); + + var itr = libs.iterator(); + while (itr.hasNext() && (decode_function == 0L)) { + try { + decode_function = load_library(itr.next()); + } catch (DebuggerException e) { + if (!itr.hasNext()) { + throw e; + } } - } else if (os.lastIndexOf("Mac OS X", 0) != -1) { - path.append(sep + "lib" + sep); - libname += "-amd64" + ".dylib"; // x86_64 => amd64 - } else { - path.append(sep + "lib" + sep + "arch" + sep); - libname += "-" + arch + ".so"; } - decode_function = load_library(path.toString(), libname); } } - private static native long load_library(String installed_jrepath, String hsdis_library_name); + private static native long load_library(String hsdis_library_name); private native void decode(InstructionVisitor visitor, long pc, byte[] code, String options, long decode_function); diff --git a/src/jdk.hotspot.agent/share/native/libsaproc/sadis.c b/src/jdk.hotspot.agent/share/native/libsaproc/sadis.c index 540f13ad5b6f0..9210f78ab2a89 100644 --- a/src/jdk.hotspot.agent/share/native/libsaproc/sadis.c +++ b/src/jdk.hotspot.agent/share/native/libsaproc/sadis.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -110,42 +110,30 @@ static int getLastErrorString(char *buf, size_t len) /* * Class: sun_jvm_hotspot_asm_Disassembler * Method: load_library - * Signature: (Ljava/lang/String;)L + * Signature: (Ljava/lang/String;)J */ JNIEXPORT jlong JNICALL Java_sun_jvm_hotspot_asm_Disassembler_load_1library(JNIEnv * env, jclass disclass, - jstring jrepath_s, jstring libname_s) { uintptr_t func = 0; const char *error_message = NULL; - const char *jrepath = NULL; const char *libname = NULL; - char buffer[JVM_MAXPATHLEN]; #ifdef _WINDOWS + char buffer[JVM_MAXPATHLEN]; HINSTANCE hsdis_handle = (HINSTANCE) NULL; #else void* hsdis_handle = NULL; #endif - jrepath = (*env)->GetStringUTFChars(env, jrepath_s, NULL); // like $JAVA_HOME/jre/lib/sparc/ - if (jrepath == NULL || (*env)->ExceptionOccurred(env)) { - return 0; - } - libname = (*env)->GetStringUTFChars(env, libname_s, NULL); if (libname == NULL || (*env)->ExceptionOccurred(env)) { - (*env)->ReleaseStringUTFChars(env, jrepath_s, jrepath); return 0; } /* Load the hsdis library */ #ifdef _WINDOWS hsdis_handle = LoadLibrary(libname); - if (hsdis_handle == NULL) { - snprintf(buffer, sizeof(buffer), "%s%s", jrepath, libname); - hsdis_handle = LoadLibrary(buffer); - } if (hsdis_handle != NULL) { func = (uintptr_t)GetProcAddress(hsdis_handle, "decode_instructions_virtual"); } @@ -155,10 +143,6 @@ JNIEXPORT jlong JNICALL Java_sun_jvm_hotspot_asm_Disassembler_load_1library(JNIE } #else hsdis_handle = dlopen(libname, RTLD_LAZY | RTLD_GLOBAL); - if (hsdis_handle == NULL) { - snprintf(buffer, sizeof(buffer), "%s%s", jrepath, libname); - hsdis_handle = dlopen(buffer, RTLD_LAZY | RTLD_GLOBAL); - } if (hsdis_handle != NULL) { func = (uintptr_t)dlsym(hsdis_handle, "decode_instructions_virtual"); } @@ -168,7 +152,6 @@ JNIEXPORT jlong JNICALL Java_sun_jvm_hotspot_asm_Disassembler_load_1library(JNIE #endif (*env)->ReleaseStringUTFChars(env, libname_s, libname); - (*env)->ReleaseStringUTFChars(env, jrepath_s, jrepath); if (func == 0) { /* Couldn't find entry point. error_message should contain some From 52d3feec412f4bafdf16c248c4b31014a8d9d72f Mon Sep 17 00:00:00 2001 From: Xiaohong Gong Date: Wed, 6 Jan 2021 01:40:34 +0000 Subject: [PATCH 033/129] 8258813: [TESTBUG] Fix incorrect Vector API test output message Reviewed-by: psandoz, njian --- .../incubator/vector/AbstractVectorTest.java | 4 +- .../vector/Byte128VectorLoadStoreTests.java | 54 +-- .../incubator/vector/Byte128VectorTests.java | 450 +++++++++--------- .../vector/Byte256VectorLoadStoreTests.java | 54 +-- .../incubator/vector/Byte256VectorTests.java | 450 +++++++++--------- .../vector/Byte512VectorLoadStoreTests.java | 54 +-- .../incubator/vector/Byte512VectorTests.java | 450 +++++++++--------- .../vector/Byte64VectorLoadStoreTests.java | 54 +-- .../incubator/vector/Byte64VectorTests.java | 450 +++++++++--------- .../vector/ByteMaxVectorLoadStoreTests.java | 54 +-- .../incubator/vector/ByteMaxVectorTests.java | 450 +++++++++--------- .../vector/Double128VectorLoadStoreTests.java | 60 +-- .../vector/Double128VectorTests.java | 404 ++++++++-------- .../vector/Double256VectorLoadStoreTests.java | 60 +-- .../vector/Double256VectorTests.java | 404 ++++++++-------- .../vector/Double512VectorLoadStoreTests.java | 60 +-- .../vector/Double512VectorTests.java | 404 ++++++++-------- .../vector/Double64VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Double64VectorTests.java | 404 ++++++++-------- .../vector/DoubleMaxVectorLoadStoreTests.java | 60 +-- .../vector/DoubleMaxVectorTests.java | 404 ++++++++-------- .../vector/Float128VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Float128VectorTests.java | 410 ++++++++-------- .../vector/Float256VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Float256VectorTests.java | 410 ++++++++-------- .../vector/Float512VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Float512VectorTests.java | 410 ++++++++-------- .../vector/Float64VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Float64VectorTests.java | 410 ++++++++-------- .../vector/FloatMaxVectorLoadStoreTests.java | 60 +-- .../incubator/vector/FloatMaxVectorTests.java | 410 ++++++++-------- .../vector/Int128VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Int128VectorTests.java | 446 ++++++++--------- .../vector/Int256VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Int256VectorTests.java | 446 ++++++++--------- .../vector/Int512VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Int512VectorTests.java | 446 ++++++++--------- .../vector/Int64VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Int64VectorTests.java | 446 ++++++++--------- .../vector/IntMaxVectorLoadStoreTests.java | 60 +-- .../incubator/vector/IntMaxVectorTests.java | 446 ++++++++--------- .../vector/Long128VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Long128VectorTests.java | 422 ++++++++-------- .../vector/Long256VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Long256VectorTests.java | 422 ++++++++-------- .../vector/Long512VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Long512VectorTests.java | 422 ++++++++-------- .../vector/Long64VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Long64VectorTests.java | 422 ++++++++-------- .../vector/LongMaxVectorLoadStoreTests.java | 60 +-- .../incubator/vector/LongMaxVectorTests.java | 422 ++++++++-------- .../vector/Short128VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Short128VectorTests.java | 446 ++++++++--------- .../vector/Short256VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Short256VectorTests.java | 446 ++++++++--------- .../vector/Short512VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Short512VectorTests.java | 446 ++++++++--------- .../vector/Short64VectorLoadStoreTests.java | 60 +-- .../incubator/vector/Short64VectorTests.java | 446 ++++++++--------- .../vector/ShortMaxVectorLoadStoreTests.java | 60 +-- .../incubator/vector/ShortMaxVectorTests.java | 446 ++++++++--------- .../incubator/vector/VectorReshapeTests.java | 4 +- .../Unit-Binary-Broadcast-Long-op.template | 2 +- ...t-Binary-Broadcast-Masked-Long-op.template | 2 +- .../Unit-Binary-Broadcast-Masked-op.template | 2 +- .../Unit-Binary-Broadcast-op-math.template | 2 +- .../Unit-Binary-Broadcast-op.template | 2 +- .../templates/Unit-Binary-Masked-op.template | 2 +- .../templates/Unit-Binary-op-math.template | 2 +- .../vector/templates/Unit-Binary-op.template | 2 +- .../vector/templates/Unit-Blend-op.template | 2 +- .../templates/Unit-BoolReduction-op.template | 2 +- .../vector/templates/Unit-Broadcast.template | 2 +- .../templates/Unit-Gather-Masked-op.template | 2 +- .../vector/templates/Unit-Gather-op.template | 2 +- .../vector/templates/Unit-Get-op.template | 2 +- .../vector/templates/Unit-Masked-op.template | 2 +- .../templates/Unit-Miscellaneous.template | 32 +- .../vector/templates/Unit-Rearrange.template | 4 +- .../Unit-Reduction-Masked-Max-op.template | 2 +- .../Unit-Reduction-Masked-Min-op.template | 2 +- .../Unit-Reduction-Masked-op.template | 2 +- .../templates/Unit-Reduction-Max-op.template | 2 +- .../templates/Unit-Reduction-Min-op.template | 2 +- .../templates/Unit-Reduction-op.template | 2 +- .../templates/Unit-Scatter-Masked-op.template | 2 +- .../vector/templates/Unit-Scatter-op.template | 2 +- .../templates/Unit-Shift-Masked-op.template | 2 +- .../vector/templates/Unit-Shift-op.template | 2 +- .../vector/templates/Unit-Single-op.template | 2 +- .../templates/Unit-Slice-Masked-bop.template | 2 +- .../vector/templates/Unit-Slice-bop.template | 2 +- .../vector/templates/Unit-Slice-op.template | 2 +- .../Unit-Ternary-Broadcast-Masked-op.template | 4 +- .../Unit-Ternary-Broadcast-op.template | 4 +- ...ernary-Double-Broadcast-Masked-op.template | 2 +- .../Unit-Ternary-Double-Broadcast-op.template | 2 +- .../templates/Unit-Ternary-Masked-op.template | 2 +- .../vector/templates/Unit-Ternary-op.template | 2 +- .../templates/Unit-Unary-Masked-op.template | 2 +- .../templates/Unit-Unary-op-math.template | 2 +- .../vector/templates/Unit-Unary-op.template | 2 +- .../Unit-Unslice-Masked-bop.template | 2 +- .../templates/Unit-Unslice-bop.template | 2 +- .../vector/templates/Unit-Unslice-op.template | 2 +- .../vector/templates/Unit-With-Op.template | 2 +- .../vector/templates/Unit-header.template | 186 ++++---- .../templates/X-LoadStoreTest.java.template | 60 +-- 108 files changed, 7178 insertions(+), 7860 deletions(-) diff --git a/test/jdk/jdk/incubator/vector/AbstractVectorTest.java b/test/jdk/jdk/incubator/vector/AbstractVectorTest.java index c09ff33758601..cf1c8eff20a1b 100644 --- a/test/jdk/jdk/incubator/vector/AbstractVectorTest.java +++ b/test/jdk/jdk/incubator/vector/AbstractVectorTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -251,7 +251,7 @@ interface FBooleanBinOp { boolean apply(boolean a, boolean b); } - static void assertArraysEquals(boolean[] a, boolean[] b, boolean[] r, FBooleanBinOp f) { + static void assertArraysEquals(boolean[] r, boolean[] a, boolean[] b, FBooleanBinOp f) { int i = 0; try { for (; i < a.length; i++) { diff --git a/test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java index 52108fd34cb5c..39a053e657d36 100644 --- a/test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -57,36 +57,14 @@ public class Byte128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -390,7 +368,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "byteProviderForIOOBE") @@ -461,7 +439,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteMaskProviderForIOOBE") @@ -545,7 +523,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -569,7 +547,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -656,7 +634,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -671,7 +649,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -787,7 +765,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -868,7 +846,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -956,7 +934,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -967,7 +945,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Byte128VectorTests.java b/test/jdk/jdk/incubator/vector/Byte128VectorTests.java index e2f25b76e0cf2..a7d006daec318 100644 --- a/test/jdk/jdk/incubator/vector/Byte128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Byte128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { byte apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { byte[] apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a[i]); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { byte apply(byte[] a); } - static void assertReductionArraysEquals(byte[] a, byte[] b, byte c, + static void assertReductionArraysEquals(byte[] r, byte rc, byte[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { byte apply(byte[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(byte[] a, byte[] b, byte c, boolean[] mask, + static void assertReductionArraysEqualsMasked(byte[] r, byte rc, byte[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(byte[] a); } - static void assertReductionLongArraysEquals(byte[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, byte[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(byte[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(byte[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, byte[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(byte[] a, byte[] b, byte element, int index) { + static void assertInsertArraysEquals(byte[] r, byte[] a, byte element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int v } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boole } } - static void assertBroadcastArraysEquals(byte[]a, byte[]r) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolea } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { byte apply(byte[] a, int b); } - static void assertArraysEquals(byte[] a, byte[] r, FBinArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { byte[] apply(byte[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, FGatherScatterOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { byte[] apply(byte[] r, byte[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } catch (AssertionError e) { byte[] ref = f.apply(a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FSca } catch (AssertionError e) { byte[] ref = f.apply(r, a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { byte[] apply(byte[] a, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { byte[] apply(byte[] a, byte[] b, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBo } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { byte[] apply(byte[] a, byte[] b, int origin, int part, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } - static void assertArraysEquals(byte[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -802,7 +802,7 @@ static void assertArraysEquals(byte[] a, int[] r, int offs) { } - static void assertArraysEquals(byte[] a, byte[] r, int offs) { + static void assertArraysEquals(byte[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -813,7 +813,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int offs) { } } - static void assertArraysEquals(byte[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -824,7 +824,7 @@ static void assertArraysEquals(byte[] a, long[] r, int offs) { } } - static void assertArraysEquals(byte[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1288,7 +1288,7 @@ static void ADDByte128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::ADD); + assertArraysEquals(r, a, b, Byte128VectorTests::ADD); } static byte add(byte a, byte b) { return (byte)(a + b); @@ -1306,7 +1306,7 @@ static void addByte128VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::add); + assertArraysEquals(r, a, b, Byte128VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1326,7 +1326,7 @@ static void ADDByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::SUB); + assertArraysEquals(r, a, b, Byte128VectorTests::SUB); } static byte sub(byte a, byte b) { return (byte)(a - b); @@ -1382,7 +1382,7 @@ static void subByte128VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::sub); + assertArraysEquals(r, a, b, Byte128VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1402,7 +1402,7 @@ static void SUBByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::MUL); + assertArraysEquals(r, a, b, Byte128VectorTests::MUL); } static byte mul(byte a, byte b) { return (byte)(a * b); @@ -1458,7 +1458,7 @@ static void mulByte128VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::mul); + assertArraysEquals(r, a, b, Byte128VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1478,7 +1478,7 @@ static void MULByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::DIV); + assertArraysEquals(r, a, b, Byte128VectorTests::DIV); } static byte div(byte a, byte b) { return (byte)(a / b); @@ -1543,7 +1543,7 @@ static void divByte128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::div); + assertArraysEquals(r, a, b, Byte128VectorTests::div); } @@ -1567,7 +1567,7 @@ static void DIVByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Byte128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Byte128VectorTests::FIRST_NONZERO); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1630,7 +1630,7 @@ static void FIRST_NONZEROByte128VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Byte128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Byte128VectorTests::FIRST_NONZERO); } static byte AND(byte a, byte b) { @@ -1651,7 +1651,7 @@ static void ANDByte128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::AND); + assertArraysEquals(r, a, b, Byte128VectorTests::AND); } static byte and(byte a, byte b) { return (byte)(a & b); @@ -1669,7 +1669,7 @@ static void andByte128VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::and); + assertArraysEquals(r, a, b, Byte128VectorTests::and); } @@ -1691,7 +1691,7 @@ static void ANDByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte128VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Byte128VectorTests::AND_NOT); } @@ -1757,7 +1757,7 @@ static void ORByte128VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte128VectorTests::OR); + assertArraysEquals(r, a, b, Byte128VectorTests::OR); } static byte or(byte a, byte b) { return (byte)(a | b); @@ -1775,7 +1775,7 @@ static void orByte128VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::or); + assertArraysEquals(r, a, b, Byte128VectorTests::or); } @@ -1797,7 +1797,7 @@ static void ORByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::XOR); + assertArraysEquals(r, a, b, Byte128VectorTests::XOR); } @@ -1841,7 +1841,7 @@ static void XORByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1873,7 +1873,7 @@ static void addByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::add); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1887,7 +1887,7 @@ static void subByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1904,7 +1904,7 @@ static void subByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::sub); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1918,7 +1918,7 @@ static void mulByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1935,7 +1935,7 @@ static void mulByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::mul); } @@ -1954,7 +1954,7 @@ static void divByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::div); } @@ -1975,7 +1975,7 @@ static void divByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::div); } @@ -1991,7 +1991,7 @@ static void ORByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::OR); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2005,7 +2005,7 @@ static void orByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::or); } @@ -2024,7 +2024,7 @@ static void ORByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::OR); } @@ -2040,7 +2040,7 @@ static void ANDByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::AND); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2054,7 +2054,7 @@ static void andByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::and); } @@ -2073,7 +2073,7 @@ static void ANDByte128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Byte128VectorTests::AND); } @@ -2089,7 +2089,7 @@ static void ORByte128VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Byte128VectorTests::OR); } @@ -2108,7 +2108,7 @@ static void ORByte128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte128VectorTests::OR); } @@ -2123,7 +2123,7 @@ static void ADDByte128VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Byte128VectorTests::ADD); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -2140,7 +2140,7 @@ static void ADDByte128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte128VectorTests::LSHL); + assertArraysEquals(r, a, b, Byte128VectorTests::LSHL); } @@ -2185,7 +2185,7 @@ static void LSHLByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte128VectorTests::ASHR); + assertArraysEquals(r, a, b, Byte128VectorTests::ASHR); } @@ -2233,7 +2233,7 @@ static void ASHRByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte128VectorTests::LSHR); + assertArraysEquals(r, a, b, Byte128VectorTests::LSHR); } @@ -2281,7 +2281,7 @@ static void LSHRByte128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::MIN); + assertArraysEquals(r, a, b, Byte128VectorTests::MIN); } static byte min(byte a, byte b) { return (byte)(Math.min(a, b)); @@ -2460,7 +2460,7 @@ static void minByte128VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::min); + assertArraysEquals(r, a, b, Byte128VectorTests::min); } static byte MAX(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2480,7 +2480,7 @@ static void MAXByte128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte128VectorTests::MAX); + assertArraysEquals(r, a, b, Byte128VectorTests::MAX); } static byte max(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2498,7 +2498,7 @@ static void maxByte128VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::max); + assertArraysEquals(r, a, b, Byte128VectorTests::max); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2512,7 +2512,7 @@ static void MINByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::MIN); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2526,7 +2526,7 @@ static void minByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::min); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2540,7 +2540,7 @@ static void MAXByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::MAX); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2554,7 +2554,7 @@ static void maxByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Byte128VectorTests::max); } static byte ANDReduce(byte[] a, int idx) { @@ -2597,7 +2597,7 @@ static void ANDReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::ANDReduce, Byte128VectorTests::ANDReduceAll); } @@ -2645,7 +2645,7 @@ static void ANDReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::ANDReduceMasked, Byte128VectorTests::ANDReduceAllMasked); } @@ -2690,7 +2690,7 @@ static void ORReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::ORReduce, Byte128VectorTests::ORReduceAll); } @@ -2738,7 +2738,7 @@ static void ORReduceByte128VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::ORReduceMasked, Byte128VectorTests::ORReduceAllMasked); } @@ -2783,7 +2783,7 @@ static void XORReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::XORReduce, Byte128VectorTests::XORReduceAll); } @@ -2831,7 +2831,7 @@ static void XORReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::XORReduceMasked, Byte128VectorTests::XORReduceAllMasked); } @@ -2873,7 +2873,7 @@ static void ADDReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::ADDReduce, Byte128VectorTests::ADDReduceAll); } static byte ADDReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -2917,7 +2917,7 @@ static void ADDReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::ADDReduceMasked, Byte128VectorTests::ADDReduceAllMasked); } static byte MULReduce(byte[] a, int idx) { @@ -2958,7 +2958,7 @@ static void MULReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::MULReduce, Byte128VectorTests::MULReduceAll); } static byte MULReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3002,7 +3002,7 @@ static void MULReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::MULReduceMasked, Byte128VectorTests::MULReduceAllMasked); } static byte MINReduce(byte[] a, int idx) { @@ -3043,7 +3043,7 @@ static void MINReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::MINReduce, Byte128VectorTests::MINReduceAll); } static byte MINReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3088,7 +3088,7 @@ static void MINReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::MINReduceMasked, Byte128VectorTests::MINReduceAllMasked); } static byte MAXReduce(byte[] a, int idx) { @@ -3129,7 +3129,7 @@ static void MAXReduceByte128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte128VectorTests::MAXReduce, Byte128VectorTests::MAXReduceAll); } static byte MAXReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3174,7 +3174,7 @@ static void MAXReduceByte128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::MAXReduceMasked, Byte128VectorTests::MAXReduceAllMasked); } @@ -3200,7 +3200,7 @@ static void anyTrueByte128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte128VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Byte128VectorTests::anyTrue); } @@ -3226,7 +3226,7 @@ static void allTrueByte128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte128VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Byte128VectorTests::allTrue); } @@ -3242,7 +3242,7 @@ static void withByte128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (byte)4, 0); + assertInsertArraysEquals(r, a, (byte)4, 0); } static boolean testIS_DEFAULT(byte a) { return bits(a)==0; @@ -3791,7 +3791,7 @@ static void blendByte128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Byte128VectorTests::blend); + assertArraysEquals(r, a, b, mask, Byte128VectorTests::blend); } @Test(dataProvider = "byteUnaryOpShuffleProvider") @@ -3808,7 +3808,7 @@ static void RearrangeByte128VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpShuffleMaskProvider") @@ -3826,7 +3826,7 @@ static void RearrangeByte128VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpProvider") static void getByte128VectorTests(IntFunction fa) { @@ -3981,7 +3981,7 @@ static void getByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::get); + assertArraysEquals(r, a, Byte128VectorTests::get); } @Test(dataProvider = "byteUnaryOpProvider") @@ -3995,7 +3995,7 @@ static void BroadcastByte128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4042,7 +4042,7 @@ static void sliceUnaryByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Byte128VectorTests::sliceUnary); } static byte[] sliceBinary(byte[] a, byte[] b, int origin, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4071,7 +4071,7 @@ static void sliceBinaryByte128VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Byte128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Byte128VectorTests::sliceBinary); } static byte[] slice(byte[] a, byte[] b, int origin, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4104,7 +4104,7 @@ static void sliceByte128VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Byte128VectorTests::unsliceUnary); } static byte[] unsliceBinary(byte[] a, byte[] b, int origin, int part, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4170,7 +4170,7 @@ static void unsliceBinaryByte128VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Byte128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Byte128VectorTests::unsliceBinary); } static byte[] unslice(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4226,7 +4226,7 @@ static void unsliceByte128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Byte128VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Byte128VectorTests::unslice); } @@ -4275,7 +4275,7 @@ static void BITWISE_BLENDByte128VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Byte128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Byte128VectorTests::BITWISE_BLEND); } @Test(dataProvider = "byteTernaryOpProvider") static void bitwiseBlendByte128VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4291,7 +4291,7 @@ static void bitwiseBlendByte128VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Byte128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Byte128VectorTests::BITWISE_BLEND); } @@ -4332,7 +4332,7 @@ static void BITWISE_BLENDByte128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4361,7 +4361,7 @@ static void bitwiseBlendByte128VectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Byte128VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Byte128VectorTests::bitwiseBlend); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4376,7 +4376,7 @@ static void bitwiseBlendByte128VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4447,7 +4447,7 @@ static void bitwiseBlendByte128VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::NEG); + assertArraysEquals(r, a, Byte128VectorTests::NEG); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4505,7 +4505,7 @@ static void negByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::neg); + assertArraysEquals(r, a, Byte128VectorTests::neg); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4523,7 +4523,7 @@ static void NEGMaskedByte128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte128VectorTests::NEG); + assertArraysEquals(r, a, mask, Byte128VectorTests::NEG); } static byte ABS(byte a) { @@ -4546,7 +4546,7 @@ static void ABSByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::ABS); + assertArraysEquals(r, a, Byte128VectorTests::ABS); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4561,7 +4561,7 @@ static void absByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::abs); + assertArraysEquals(r, a, Byte128VectorTests::abs); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4579,7 +4579,7 @@ static void ABSMaskedByte128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte128VectorTests::ABS); + assertArraysEquals(r, a, mask, Byte128VectorTests::ABS); } @@ -4605,7 +4605,7 @@ static void NOTByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::NOT); + assertArraysEquals(r, a, Byte128VectorTests::NOT); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4620,7 +4620,7 @@ static void notByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::not); + assertArraysEquals(r, a, Byte128VectorTests::not); } @@ -4640,7 +4640,7 @@ static void NOTMaskedByte128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte128VectorTests::NOT); + assertArraysEquals(r, a, mask, Byte128VectorTests::NOT); } @@ -4663,7 +4663,7 @@ static void ZOMOByte128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte128VectorTests::ZOMO); + assertArraysEquals(r, a, Byte128VectorTests::ZOMO); } @@ -4683,7 +4683,7 @@ static void ZOMOMaskedByte128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte128VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Byte128VectorTests::ZOMO); } @@ -4711,7 +4711,7 @@ static void gatherByte128VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte128VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Byte128VectorTests::scatterMasked); } @@ -4844,8 +4844,8 @@ static void toIntArrayByte128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4855,8 +4855,8 @@ static void toLongArrayByte128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4866,8 +4866,8 @@ static void toDoubleArrayByte128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4907,7 +4907,7 @@ static void reinterpretAsBytesByte128VectorTestsSmokeTest(IntFunction fa ByteVector av = ByteVector.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } static long ADDReduceLong(byte[] a, int idx) { @@ -4944,7 +4944,7 @@ static void ADDReduceLongByte128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Byte128VectorTests::ADDReduceLong, Byte128VectorTests::ADDReduceAllLong); } @@ -4985,7 +4985,7 @@ static void ADDReduceLongByte128VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Byte128VectorTests::ADDReduceLongMasked, Byte128VectorTests::ADDReduceAllLongMasked); } @@ -4997,7 +4997,7 @@ static void BroadcastLongByte128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -5015,7 +5015,7 @@ static void blendByte128VectorTestsBroadcastLongSmokeTest(IntFunction fa av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte128VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte128VectorTests::blend); } @@ -5032,7 +5032,7 @@ static void SelectFromByte128VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpSelectFromMaskProvider") @@ -5051,7 +5051,7 @@ static void SelectFromByte128VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5128,7 +5128,7 @@ static void maskEqByte128VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Byte128VectorTests::beq); + assertArraysEquals(r, a, b, Byte128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Byte256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Byte256VectorLoadStoreTests.java index 84d7dc6f853a4..c7acbc97f0b94 100644 --- a/test/jdk/jdk/incubator/vector/Byte256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Byte256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -57,36 +57,14 @@ public class Byte256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -390,7 +368,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "byteProviderForIOOBE") @@ -461,7 +439,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteMaskProviderForIOOBE") @@ -545,7 +523,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -569,7 +547,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -656,7 +634,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -671,7 +649,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -787,7 +765,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -868,7 +846,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -956,7 +934,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -967,7 +945,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Byte256VectorTests.java b/test/jdk/jdk/incubator/vector/Byte256VectorTests.java index 0d7dabb6517d6..7b68b9a4fefdf 100644 --- a/test/jdk/jdk/incubator/vector/Byte256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Byte256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { byte apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { byte[] apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a[i]); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { byte apply(byte[] a); } - static void assertReductionArraysEquals(byte[] a, byte[] b, byte c, + static void assertReductionArraysEquals(byte[] r, byte rc, byte[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { byte apply(byte[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(byte[] a, byte[] b, byte c, boolean[] mask, + static void assertReductionArraysEqualsMasked(byte[] r, byte rc, byte[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(byte[] a); } - static void assertReductionLongArraysEquals(byte[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, byte[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(byte[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(byte[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, byte[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(byte[] a, byte[] b, byte element, int index) { + static void assertInsertArraysEquals(byte[] r, byte[] a, byte element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int v } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boole } } - static void assertBroadcastArraysEquals(byte[]a, byte[]r) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolea } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { byte apply(byte[] a, int b); } - static void assertArraysEquals(byte[] a, byte[] r, FBinArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { byte[] apply(byte[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, FGatherScatterOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { byte[] apply(byte[] r, byte[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } catch (AssertionError e) { byte[] ref = f.apply(a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FSca } catch (AssertionError e) { byte[] ref = f.apply(r, a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { byte[] apply(byte[] a, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { byte[] apply(byte[] a, byte[] b, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBo } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { byte[] apply(byte[] a, byte[] b, int origin, int part, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } - static void assertArraysEquals(byte[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -802,7 +802,7 @@ static void assertArraysEquals(byte[] a, int[] r, int offs) { } - static void assertArraysEquals(byte[] a, byte[] r, int offs) { + static void assertArraysEquals(byte[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -813,7 +813,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int offs) { } } - static void assertArraysEquals(byte[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -824,7 +824,7 @@ static void assertArraysEquals(byte[] a, long[] r, int offs) { } } - static void assertArraysEquals(byte[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1288,7 +1288,7 @@ static void ADDByte256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::ADD); + assertArraysEquals(r, a, b, Byte256VectorTests::ADD); } static byte add(byte a, byte b) { return (byte)(a + b); @@ -1306,7 +1306,7 @@ static void addByte256VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::add); + assertArraysEquals(r, a, b, Byte256VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1326,7 +1326,7 @@ static void ADDByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::SUB); + assertArraysEquals(r, a, b, Byte256VectorTests::SUB); } static byte sub(byte a, byte b) { return (byte)(a - b); @@ -1382,7 +1382,7 @@ static void subByte256VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::sub); + assertArraysEquals(r, a, b, Byte256VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1402,7 +1402,7 @@ static void SUBByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::MUL); + assertArraysEquals(r, a, b, Byte256VectorTests::MUL); } static byte mul(byte a, byte b) { return (byte)(a * b); @@ -1458,7 +1458,7 @@ static void mulByte256VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::mul); + assertArraysEquals(r, a, b, Byte256VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1478,7 +1478,7 @@ static void MULByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::DIV); + assertArraysEquals(r, a, b, Byte256VectorTests::DIV); } static byte div(byte a, byte b) { return (byte)(a / b); @@ -1543,7 +1543,7 @@ static void divByte256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::div); + assertArraysEquals(r, a, b, Byte256VectorTests::div); } @@ -1567,7 +1567,7 @@ static void DIVByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Byte256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Byte256VectorTests::FIRST_NONZERO); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1630,7 +1630,7 @@ static void FIRST_NONZEROByte256VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Byte256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Byte256VectorTests::FIRST_NONZERO); } static byte AND(byte a, byte b) { @@ -1651,7 +1651,7 @@ static void ANDByte256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::AND); + assertArraysEquals(r, a, b, Byte256VectorTests::AND); } static byte and(byte a, byte b) { return (byte)(a & b); @@ -1669,7 +1669,7 @@ static void andByte256VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::and); + assertArraysEquals(r, a, b, Byte256VectorTests::and); } @@ -1691,7 +1691,7 @@ static void ANDByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte256VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Byte256VectorTests::AND_NOT); } @@ -1757,7 +1757,7 @@ static void ORByte256VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte256VectorTests::OR); + assertArraysEquals(r, a, b, Byte256VectorTests::OR); } static byte or(byte a, byte b) { return (byte)(a | b); @@ -1775,7 +1775,7 @@ static void orByte256VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::or); + assertArraysEquals(r, a, b, Byte256VectorTests::or); } @@ -1797,7 +1797,7 @@ static void ORByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::XOR); + assertArraysEquals(r, a, b, Byte256VectorTests::XOR); } @@ -1841,7 +1841,7 @@ static void XORByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1873,7 +1873,7 @@ static void addByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::add); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1887,7 +1887,7 @@ static void subByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1904,7 +1904,7 @@ static void subByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::sub); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1918,7 +1918,7 @@ static void mulByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1935,7 +1935,7 @@ static void mulByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::mul); } @@ -1954,7 +1954,7 @@ static void divByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::div); } @@ -1975,7 +1975,7 @@ static void divByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::div); } @@ -1991,7 +1991,7 @@ static void ORByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::OR); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2005,7 +2005,7 @@ static void orByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::or); } @@ -2024,7 +2024,7 @@ static void ORByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::OR); } @@ -2040,7 +2040,7 @@ static void ANDByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::AND); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2054,7 +2054,7 @@ static void andByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::and); } @@ -2073,7 +2073,7 @@ static void ANDByte256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Byte256VectorTests::AND); } @@ -2089,7 +2089,7 @@ static void ORByte256VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Byte256VectorTests::OR); } @@ -2108,7 +2108,7 @@ static void ORByte256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte256VectorTests::OR); } @@ -2123,7 +2123,7 @@ static void ADDByte256VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Byte256VectorTests::ADD); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -2140,7 +2140,7 @@ static void ADDByte256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte256VectorTests::LSHL); + assertArraysEquals(r, a, b, Byte256VectorTests::LSHL); } @@ -2185,7 +2185,7 @@ static void LSHLByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte256VectorTests::ASHR); + assertArraysEquals(r, a, b, Byte256VectorTests::ASHR); } @@ -2233,7 +2233,7 @@ static void ASHRByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte256VectorTests::LSHR); + assertArraysEquals(r, a, b, Byte256VectorTests::LSHR); } @@ -2281,7 +2281,7 @@ static void LSHRByte256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::MIN); + assertArraysEquals(r, a, b, Byte256VectorTests::MIN); } static byte min(byte a, byte b) { return (byte)(Math.min(a, b)); @@ -2460,7 +2460,7 @@ static void minByte256VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::min); + assertArraysEquals(r, a, b, Byte256VectorTests::min); } static byte MAX(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2480,7 +2480,7 @@ static void MAXByte256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte256VectorTests::MAX); + assertArraysEquals(r, a, b, Byte256VectorTests::MAX); } static byte max(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2498,7 +2498,7 @@ static void maxByte256VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::max); + assertArraysEquals(r, a, b, Byte256VectorTests::max); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2512,7 +2512,7 @@ static void MINByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::MIN); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2526,7 +2526,7 @@ static void minByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::min); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2540,7 +2540,7 @@ static void MAXByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::MAX); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2554,7 +2554,7 @@ static void maxByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Byte256VectorTests::max); } static byte ANDReduce(byte[] a, int idx) { @@ -2597,7 +2597,7 @@ static void ANDReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::ANDReduce, Byte256VectorTests::ANDReduceAll); } @@ -2645,7 +2645,7 @@ static void ANDReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::ANDReduceMasked, Byte256VectorTests::ANDReduceAllMasked); } @@ -2690,7 +2690,7 @@ static void ORReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::ORReduce, Byte256VectorTests::ORReduceAll); } @@ -2738,7 +2738,7 @@ static void ORReduceByte256VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::ORReduceMasked, Byte256VectorTests::ORReduceAllMasked); } @@ -2783,7 +2783,7 @@ static void XORReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::XORReduce, Byte256VectorTests::XORReduceAll); } @@ -2831,7 +2831,7 @@ static void XORReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::XORReduceMasked, Byte256VectorTests::XORReduceAllMasked); } @@ -2873,7 +2873,7 @@ static void ADDReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::ADDReduce, Byte256VectorTests::ADDReduceAll); } static byte ADDReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -2917,7 +2917,7 @@ static void ADDReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::ADDReduceMasked, Byte256VectorTests::ADDReduceAllMasked); } static byte MULReduce(byte[] a, int idx) { @@ -2958,7 +2958,7 @@ static void MULReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::MULReduce, Byte256VectorTests::MULReduceAll); } static byte MULReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3002,7 +3002,7 @@ static void MULReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::MULReduceMasked, Byte256VectorTests::MULReduceAllMasked); } static byte MINReduce(byte[] a, int idx) { @@ -3043,7 +3043,7 @@ static void MINReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::MINReduce, Byte256VectorTests::MINReduceAll); } static byte MINReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3088,7 +3088,7 @@ static void MINReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::MINReduceMasked, Byte256VectorTests::MINReduceAllMasked); } static byte MAXReduce(byte[] a, int idx) { @@ -3129,7 +3129,7 @@ static void MAXReduceByte256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte256VectorTests::MAXReduce, Byte256VectorTests::MAXReduceAll); } static byte MAXReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3174,7 +3174,7 @@ static void MAXReduceByte256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::MAXReduceMasked, Byte256VectorTests::MAXReduceAllMasked); } @@ -3200,7 +3200,7 @@ static void anyTrueByte256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte256VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Byte256VectorTests::anyTrue); } @@ -3226,7 +3226,7 @@ static void allTrueByte256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte256VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Byte256VectorTests::allTrue); } @@ -3242,7 +3242,7 @@ static void withByte256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (byte)4, 0); + assertInsertArraysEquals(r, a, (byte)4, 0); } static boolean testIS_DEFAULT(byte a) { return bits(a)==0; @@ -3791,7 +3791,7 @@ static void blendByte256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Byte256VectorTests::blend); + assertArraysEquals(r, a, b, mask, Byte256VectorTests::blend); } @Test(dataProvider = "byteUnaryOpShuffleProvider") @@ -3808,7 +3808,7 @@ static void RearrangeByte256VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpShuffleMaskProvider") @@ -3826,7 +3826,7 @@ static void RearrangeByte256VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpProvider") static void getByte256VectorTests(IntFunction fa) { @@ -3981,7 +3981,7 @@ static void getByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::get); + assertArraysEquals(r, a, Byte256VectorTests::get); } @Test(dataProvider = "byteUnaryOpProvider") @@ -3995,7 +3995,7 @@ static void BroadcastByte256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4042,7 +4042,7 @@ static void sliceUnaryByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Byte256VectorTests::sliceUnary); } static byte[] sliceBinary(byte[] a, byte[] b, int origin, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4071,7 +4071,7 @@ static void sliceBinaryByte256VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Byte256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Byte256VectorTests::sliceBinary); } static byte[] slice(byte[] a, byte[] b, int origin, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4104,7 +4104,7 @@ static void sliceByte256VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Byte256VectorTests::unsliceUnary); } static byte[] unsliceBinary(byte[] a, byte[] b, int origin, int part, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4170,7 +4170,7 @@ static void unsliceBinaryByte256VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Byte256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Byte256VectorTests::unsliceBinary); } static byte[] unslice(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4226,7 +4226,7 @@ static void unsliceByte256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Byte256VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Byte256VectorTests::unslice); } @@ -4275,7 +4275,7 @@ static void BITWISE_BLENDByte256VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Byte256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Byte256VectorTests::BITWISE_BLEND); } @Test(dataProvider = "byteTernaryOpProvider") static void bitwiseBlendByte256VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4291,7 +4291,7 @@ static void bitwiseBlendByte256VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Byte256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Byte256VectorTests::BITWISE_BLEND); } @@ -4332,7 +4332,7 @@ static void BITWISE_BLENDByte256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4361,7 +4361,7 @@ static void bitwiseBlendByte256VectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Byte256VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Byte256VectorTests::bitwiseBlend); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4376,7 +4376,7 @@ static void bitwiseBlendByte256VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4447,7 +4447,7 @@ static void bitwiseBlendByte256VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::NEG); + assertArraysEquals(r, a, Byte256VectorTests::NEG); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4505,7 +4505,7 @@ static void negByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::neg); + assertArraysEquals(r, a, Byte256VectorTests::neg); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4523,7 +4523,7 @@ static void NEGMaskedByte256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte256VectorTests::NEG); + assertArraysEquals(r, a, mask, Byte256VectorTests::NEG); } static byte ABS(byte a) { @@ -4546,7 +4546,7 @@ static void ABSByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::ABS); + assertArraysEquals(r, a, Byte256VectorTests::ABS); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4561,7 +4561,7 @@ static void absByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::abs); + assertArraysEquals(r, a, Byte256VectorTests::abs); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4579,7 +4579,7 @@ static void ABSMaskedByte256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte256VectorTests::ABS); + assertArraysEquals(r, a, mask, Byte256VectorTests::ABS); } @@ -4605,7 +4605,7 @@ static void NOTByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::NOT); + assertArraysEquals(r, a, Byte256VectorTests::NOT); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4620,7 +4620,7 @@ static void notByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::not); + assertArraysEquals(r, a, Byte256VectorTests::not); } @@ -4640,7 +4640,7 @@ static void NOTMaskedByte256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte256VectorTests::NOT); + assertArraysEquals(r, a, mask, Byte256VectorTests::NOT); } @@ -4663,7 +4663,7 @@ static void ZOMOByte256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte256VectorTests::ZOMO); + assertArraysEquals(r, a, Byte256VectorTests::ZOMO); } @@ -4683,7 +4683,7 @@ static void ZOMOMaskedByte256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte256VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Byte256VectorTests::ZOMO); } @@ -4711,7 +4711,7 @@ static void gatherByte256VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte256VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Byte256VectorTests::scatterMasked); } @@ -4844,8 +4844,8 @@ static void toIntArrayByte256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4855,8 +4855,8 @@ static void toLongArrayByte256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4866,8 +4866,8 @@ static void toDoubleArrayByte256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4907,7 +4907,7 @@ static void reinterpretAsBytesByte256VectorTestsSmokeTest(IntFunction fa ByteVector av = ByteVector.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } static long ADDReduceLong(byte[] a, int idx) { @@ -4944,7 +4944,7 @@ static void ADDReduceLongByte256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Byte256VectorTests::ADDReduceLong, Byte256VectorTests::ADDReduceAllLong); } @@ -4985,7 +4985,7 @@ static void ADDReduceLongByte256VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Byte256VectorTests::ADDReduceLongMasked, Byte256VectorTests::ADDReduceAllLongMasked); } @@ -4997,7 +4997,7 @@ static void BroadcastLongByte256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -5015,7 +5015,7 @@ static void blendByte256VectorTestsBroadcastLongSmokeTest(IntFunction fa av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte256VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte256VectorTests::blend); } @@ -5032,7 +5032,7 @@ static void SelectFromByte256VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpSelectFromMaskProvider") @@ -5051,7 +5051,7 @@ static void SelectFromByte256VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5128,7 +5128,7 @@ static void maskEqByte256VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Byte256VectorTests::beq); + assertArraysEquals(r, a, b, Byte256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Byte512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Byte512VectorLoadStoreTests.java index fc73193c180d5..7068d8c7d8380 100644 --- a/test/jdk/jdk/incubator/vector/Byte512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Byte512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -57,36 +57,14 @@ public class Byte512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -390,7 +368,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "byteProviderForIOOBE") @@ -461,7 +439,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteMaskProviderForIOOBE") @@ -545,7 +523,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -569,7 +547,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -656,7 +634,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -671,7 +649,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -787,7 +765,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -868,7 +846,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -956,7 +934,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -967,7 +945,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Byte512VectorTests.java b/test/jdk/jdk/incubator/vector/Byte512VectorTests.java index c0177d1164471..61e4aa5008ddd 100644 --- a/test/jdk/jdk/incubator/vector/Byte512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Byte512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { byte apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { byte[] apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a[i]); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { byte apply(byte[] a); } - static void assertReductionArraysEquals(byte[] a, byte[] b, byte c, + static void assertReductionArraysEquals(byte[] r, byte rc, byte[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { byte apply(byte[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(byte[] a, byte[] b, byte c, boolean[] mask, + static void assertReductionArraysEqualsMasked(byte[] r, byte rc, byte[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(byte[] a); } - static void assertReductionLongArraysEquals(byte[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, byte[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(byte[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(byte[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, byte[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(byte[] a, byte[] b, byte element, int index) { + static void assertInsertArraysEquals(byte[] r, byte[] a, byte element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int v } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boole } } - static void assertBroadcastArraysEquals(byte[]a, byte[]r) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolea } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { byte apply(byte[] a, int b); } - static void assertArraysEquals(byte[] a, byte[] r, FBinArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { byte[] apply(byte[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, FGatherScatterOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { byte[] apply(byte[] r, byte[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } catch (AssertionError e) { byte[] ref = f.apply(a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FSca } catch (AssertionError e) { byte[] ref = f.apply(r, a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { byte[] apply(byte[] a, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { byte[] apply(byte[] a, byte[] b, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBo } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { byte[] apply(byte[] a, byte[] b, int origin, int part, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } - static void assertArraysEquals(byte[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -802,7 +802,7 @@ static void assertArraysEquals(byte[] a, int[] r, int offs) { } - static void assertArraysEquals(byte[] a, byte[] r, int offs) { + static void assertArraysEquals(byte[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -813,7 +813,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int offs) { } } - static void assertArraysEquals(byte[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -824,7 +824,7 @@ static void assertArraysEquals(byte[] a, long[] r, int offs) { } } - static void assertArraysEquals(byte[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1288,7 +1288,7 @@ static void ADDByte512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::ADD); + assertArraysEquals(r, a, b, Byte512VectorTests::ADD); } static byte add(byte a, byte b) { return (byte)(a + b); @@ -1306,7 +1306,7 @@ static void addByte512VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::add); + assertArraysEquals(r, a, b, Byte512VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1326,7 +1326,7 @@ static void ADDByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::SUB); + assertArraysEquals(r, a, b, Byte512VectorTests::SUB); } static byte sub(byte a, byte b) { return (byte)(a - b); @@ -1382,7 +1382,7 @@ static void subByte512VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::sub); + assertArraysEquals(r, a, b, Byte512VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1402,7 +1402,7 @@ static void SUBByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::MUL); + assertArraysEquals(r, a, b, Byte512VectorTests::MUL); } static byte mul(byte a, byte b) { return (byte)(a * b); @@ -1458,7 +1458,7 @@ static void mulByte512VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::mul); + assertArraysEquals(r, a, b, Byte512VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1478,7 +1478,7 @@ static void MULByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::DIV); + assertArraysEquals(r, a, b, Byte512VectorTests::DIV); } static byte div(byte a, byte b) { return (byte)(a / b); @@ -1543,7 +1543,7 @@ static void divByte512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::div); + assertArraysEquals(r, a, b, Byte512VectorTests::div); } @@ -1567,7 +1567,7 @@ static void DIVByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Byte512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Byte512VectorTests::FIRST_NONZERO); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1630,7 +1630,7 @@ static void FIRST_NONZEROByte512VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Byte512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Byte512VectorTests::FIRST_NONZERO); } static byte AND(byte a, byte b) { @@ -1651,7 +1651,7 @@ static void ANDByte512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::AND); + assertArraysEquals(r, a, b, Byte512VectorTests::AND); } static byte and(byte a, byte b) { return (byte)(a & b); @@ -1669,7 +1669,7 @@ static void andByte512VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::and); + assertArraysEquals(r, a, b, Byte512VectorTests::and); } @@ -1691,7 +1691,7 @@ static void ANDByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte512VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Byte512VectorTests::AND_NOT); } @@ -1757,7 +1757,7 @@ static void ORByte512VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte512VectorTests::OR); + assertArraysEquals(r, a, b, Byte512VectorTests::OR); } static byte or(byte a, byte b) { return (byte)(a | b); @@ -1775,7 +1775,7 @@ static void orByte512VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::or); + assertArraysEquals(r, a, b, Byte512VectorTests::or); } @@ -1797,7 +1797,7 @@ static void ORByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::XOR); + assertArraysEquals(r, a, b, Byte512VectorTests::XOR); } @@ -1841,7 +1841,7 @@ static void XORByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1873,7 +1873,7 @@ static void addByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::add); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1887,7 +1887,7 @@ static void subByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1904,7 +1904,7 @@ static void subByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::sub); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1918,7 +1918,7 @@ static void mulByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1935,7 +1935,7 @@ static void mulByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::mul); } @@ -1954,7 +1954,7 @@ static void divByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::div); } @@ -1975,7 +1975,7 @@ static void divByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::div); } @@ -1991,7 +1991,7 @@ static void ORByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::OR); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2005,7 +2005,7 @@ static void orByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::or); } @@ -2024,7 +2024,7 @@ static void ORByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::OR); } @@ -2040,7 +2040,7 @@ static void ANDByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::AND); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2054,7 +2054,7 @@ static void andByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::and); } @@ -2073,7 +2073,7 @@ static void ANDByte512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Byte512VectorTests::AND); } @@ -2089,7 +2089,7 @@ static void ORByte512VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Byte512VectorTests::OR); } @@ -2108,7 +2108,7 @@ static void ORByte512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte512VectorTests::OR); } @@ -2123,7 +2123,7 @@ static void ADDByte512VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Byte512VectorTests::ADD); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -2140,7 +2140,7 @@ static void ADDByte512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte512VectorTests::LSHL); + assertArraysEquals(r, a, b, Byte512VectorTests::LSHL); } @@ -2185,7 +2185,7 @@ static void LSHLByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte512VectorTests::ASHR); + assertArraysEquals(r, a, b, Byte512VectorTests::ASHR); } @@ -2233,7 +2233,7 @@ static void ASHRByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Byte512VectorTests::LSHR); + assertArraysEquals(r, a, b, Byte512VectorTests::LSHR); } @@ -2281,7 +2281,7 @@ static void LSHRByte512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::MIN); + assertArraysEquals(r, a, b, Byte512VectorTests::MIN); } static byte min(byte a, byte b) { return (byte)(Math.min(a, b)); @@ -2460,7 +2460,7 @@ static void minByte512VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::min); + assertArraysEquals(r, a, b, Byte512VectorTests::min); } static byte MAX(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2480,7 +2480,7 @@ static void MAXByte512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte512VectorTests::MAX); + assertArraysEquals(r, a, b, Byte512VectorTests::MAX); } static byte max(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2498,7 +2498,7 @@ static void maxByte512VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::max); + assertArraysEquals(r, a, b, Byte512VectorTests::max); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2512,7 +2512,7 @@ static void MINByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::MIN); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2526,7 +2526,7 @@ static void minByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::min); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2540,7 +2540,7 @@ static void MAXByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::MAX); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2554,7 +2554,7 @@ static void maxByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Byte512VectorTests::max); } static byte ANDReduce(byte[] a, int idx) { @@ -2597,7 +2597,7 @@ static void ANDReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::ANDReduce, Byte512VectorTests::ANDReduceAll); } @@ -2645,7 +2645,7 @@ static void ANDReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::ANDReduceMasked, Byte512VectorTests::ANDReduceAllMasked); } @@ -2690,7 +2690,7 @@ static void ORReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::ORReduce, Byte512VectorTests::ORReduceAll); } @@ -2738,7 +2738,7 @@ static void ORReduceByte512VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::ORReduceMasked, Byte512VectorTests::ORReduceAllMasked); } @@ -2783,7 +2783,7 @@ static void XORReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::XORReduce, Byte512VectorTests::XORReduceAll); } @@ -2831,7 +2831,7 @@ static void XORReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::XORReduceMasked, Byte512VectorTests::XORReduceAllMasked); } @@ -2873,7 +2873,7 @@ static void ADDReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::ADDReduce, Byte512VectorTests::ADDReduceAll); } static byte ADDReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -2917,7 +2917,7 @@ static void ADDReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::ADDReduceMasked, Byte512VectorTests::ADDReduceAllMasked); } static byte MULReduce(byte[] a, int idx) { @@ -2958,7 +2958,7 @@ static void MULReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::MULReduce, Byte512VectorTests::MULReduceAll); } static byte MULReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3002,7 +3002,7 @@ static void MULReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::MULReduceMasked, Byte512VectorTests::MULReduceAllMasked); } static byte MINReduce(byte[] a, int idx) { @@ -3043,7 +3043,7 @@ static void MINReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::MINReduce, Byte512VectorTests::MINReduceAll); } static byte MINReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3088,7 +3088,7 @@ static void MINReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::MINReduceMasked, Byte512VectorTests::MINReduceAllMasked); } static byte MAXReduce(byte[] a, int idx) { @@ -3129,7 +3129,7 @@ static void MAXReduceByte512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte512VectorTests::MAXReduce, Byte512VectorTests::MAXReduceAll); } static byte MAXReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3174,7 +3174,7 @@ static void MAXReduceByte512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::MAXReduceMasked, Byte512VectorTests::MAXReduceAllMasked); } @@ -3200,7 +3200,7 @@ static void anyTrueByte512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte512VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Byte512VectorTests::anyTrue); } @@ -3226,7 +3226,7 @@ static void allTrueByte512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte512VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Byte512VectorTests::allTrue); } @@ -3242,7 +3242,7 @@ static void withByte512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (byte)4, 0); + assertInsertArraysEquals(r, a, (byte)4, 0); } static boolean testIS_DEFAULT(byte a) { return bits(a)==0; @@ -3791,7 +3791,7 @@ static void blendByte512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Byte512VectorTests::blend); + assertArraysEquals(r, a, b, mask, Byte512VectorTests::blend); } @Test(dataProvider = "byteUnaryOpShuffleProvider") @@ -3808,7 +3808,7 @@ static void RearrangeByte512VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpShuffleMaskProvider") @@ -3826,7 +3826,7 @@ static void RearrangeByte512VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpProvider") static void getByte512VectorTests(IntFunction fa) { @@ -3981,7 +3981,7 @@ static void getByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::get); + assertArraysEquals(r, a, Byte512VectorTests::get); } @Test(dataProvider = "byteUnaryOpProvider") @@ -3995,7 +3995,7 @@ static void BroadcastByte512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4042,7 +4042,7 @@ static void sliceUnaryByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Byte512VectorTests::sliceUnary); } static byte[] sliceBinary(byte[] a, byte[] b, int origin, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4071,7 +4071,7 @@ static void sliceBinaryByte512VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Byte512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Byte512VectorTests::sliceBinary); } static byte[] slice(byte[] a, byte[] b, int origin, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4104,7 +4104,7 @@ static void sliceByte512VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Byte512VectorTests::unsliceUnary); } static byte[] unsliceBinary(byte[] a, byte[] b, int origin, int part, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4170,7 +4170,7 @@ static void unsliceBinaryByte512VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Byte512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Byte512VectorTests::unsliceBinary); } static byte[] unslice(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4226,7 +4226,7 @@ static void unsliceByte512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Byte512VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Byte512VectorTests::unslice); } @@ -4275,7 +4275,7 @@ static void BITWISE_BLENDByte512VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Byte512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Byte512VectorTests::BITWISE_BLEND); } @Test(dataProvider = "byteTernaryOpProvider") static void bitwiseBlendByte512VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4291,7 +4291,7 @@ static void bitwiseBlendByte512VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Byte512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Byte512VectorTests::BITWISE_BLEND); } @@ -4332,7 +4332,7 @@ static void BITWISE_BLENDByte512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4361,7 +4361,7 @@ static void bitwiseBlendByte512VectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Byte512VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Byte512VectorTests::bitwiseBlend); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4376,7 +4376,7 @@ static void bitwiseBlendByte512VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4447,7 +4447,7 @@ static void bitwiseBlendByte512VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::NEG); + assertArraysEquals(r, a, Byte512VectorTests::NEG); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4505,7 +4505,7 @@ static void negByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::neg); + assertArraysEquals(r, a, Byte512VectorTests::neg); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4523,7 +4523,7 @@ static void NEGMaskedByte512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte512VectorTests::NEG); + assertArraysEquals(r, a, mask, Byte512VectorTests::NEG); } static byte ABS(byte a) { @@ -4546,7 +4546,7 @@ static void ABSByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::ABS); + assertArraysEquals(r, a, Byte512VectorTests::ABS); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4561,7 +4561,7 @@ static void absByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::abs); + assertArraysEquals(r, a, Byte512VectorTests::abs); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4579,7 +4579,7 @@ static void ABSMaskedByte512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte512VectorTests::ABS); + assertArraysEquals(r, a, mask, Byte512VectorTests::ABS); } @@ -4605,7 +4605,7 @@ static void NOTByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::NOT); + assertArraysEquals(r, a, Byte512VectorTests::NOT); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4620,7 +4620,7 @@ static void notByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::not); + assertArraysEquals(r, a, Byte512VectorTests::not); } @@ -4640,7 +4640,7 @@ static void NOTMaskedByte512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte512VectorTests::NOT); + assertArraysEquals(r, a, mask, Byte512VectorTests::NOT); } @@ -4663,7 +4663,7 @@ static void ZOMOByte512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte512VectorTests::ZOMO); + assertArraysEquals(r, a, Byte512VectorTests::ZOMO); } @@ -4683,7 +4683,7 @@ static void ZOMOMaskedByte512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte512VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Byte512VectorTests::ZOMO); } @@ -4711,7 +4711,7 @@ static void gatherByte512VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Byte512VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Byte512VectorTests::scatterMasked); } @@ -4844,8 +4844,8 @@ static void toIntArrayByte512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4855,8 +4855,8 @@ static void toLongArrayByte512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4866,8 +4866,8 @@ static void toDoubleArrayByte512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4907,7 +4907,7 @@ static void reinterpretAsBytesByte512VectorTestsSmokeTest(IntFunction fa ByteVector av = ByteVector.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } static long ADDReduceLong(byte[] a, int idx) { @@ -4944,7 +4944,7 @@ static void ADDReduceLongByte512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Byte512VectorTests::ADDReduceLong, Byte512VectorTests::ADDReduceAllLong); } @@ -4985,7 +4985,7 @@ static void ADDReduceLongByte512VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Byte512VectorTests::ADDReduceLongMasked, Byte512VectorTests::ADDReduceAllLongMasked); } @@ -4997,7 +4997,7 @@ static void BroadcastLongByte512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -5015,7 +5015,7 @@ static void blendByte512VectorTestsBroadcastLongSmokeTest(IntFunction fa av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte512VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte512VectorTests::blend); } @@ -5032,7 +5032,7 @@ static void SelectFromByte512VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpSelectFromMaskProvider") @@ -5051,7 +5051,7 @@ static void SelectFromByte512VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5128,7 +5128,7 @@ static void maskEqByte512VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Byte512VectorTests::beq); + assertArraysEquals(r, a, b, Byte512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Byte64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Byte64VectorLoadStoreTests.java index 6805cb2ba2675..48e280b358550 100644 --- a/test/jdk/jdk/incubator/vector/Byte64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Byte64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -57,36 +57,14 @@ public class Byte64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -390,7 +368,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "byteProviderForIOOBE") @@ -461,7 +439,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteMaskProviderForIOOBE") @@ -545,7 +523,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -569,7 +547,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -656,7 +634,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -671,7 +649,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -787,7 +765,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -868,7 +846,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -956,7 +934,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -967,7 +945,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Byte64VectorTests.java b/test/jdk/jdk/incubator/vector/Byte64VectorTests.java index aae22e79ae309..affeea486e412 100644 --- a/test/jdk/jdk/incubator/vector/Byte64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Byte64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { byte apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { byte[] apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a[i]); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { byte apply(byte[] a); } - static void assertReductionArraysEquals(byte[] a, byte[] b, byte c, + static void assertReductionArraysEquals(byte[] r, byte rc, byte[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { byte apply(byte[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(byte[] a, byte[] b, byte c, boolean[] mask, + static void assertReductionArraysEqualsMasked(byte[] r, byte rc, byte[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(byte[] a); } - static void assertReductionLongArraysEquals(byte[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, byte[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(byte[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(byte[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, byte[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(byte[] a, byte[] b, byte element, int index) { + static void assertInsertArraysEquals(byte[] r, byte[] a, byte element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int v } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boole } } - static void assertBroadcastArraysEquals(byte[]a, byte[]r) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolea } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { byte apply(byte[] a, int b); } - static void assertArraysEquals(byte[] a, byte[] r, FBinArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { byte[] apply(byte[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, FGatherScatterOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { byte[] apply(byte[] r, byte[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } catch (AssertionError e) { byte[] ref = f.apply(a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FSca } catch (AssertionError e) { byte[] ref = f.apply(r, a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { byte[] apply(byte[] a, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { byte[] apply(byte[] a, byte[] b, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBo } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { byte[] apply(byte[] a, byte[] b, int origin, int part, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } - static void assertArraysEquals(byte[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -802,7 +802,7 @@ static void assertArraysEquals(byte[] a, int[] r, int offs) { } - static void assertArraysEquals(byte[] a, byte[] r, int offs) { + static void assertArraysEquals(byte[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -813,7 +813,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int offs) { } } - static void assertArraysEquals(byte[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -824,7 +824,7 @@ static void assertArraysEquals(byte[] a, long[] r, int offs) { } } - static void assertArraysEquals(byte[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1288,7 +1288,7 @@ static void ADDByte64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::ADD); + assertArraysEquals(r, a, b, Byte64VectorTests::ADD); } static byte add(byte a, byte b) { return (byte)(a + b); @@ -1306,7 +1306,7 @@ static void addByte64VectorTests(IntFunction fa, IntFunction fb) av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::add); + assertArraysEquals(r, a, b, Byte64VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1326,7 +1326,7 @@ static void ADDByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::SUB); + assertArraysEquals(r, a, b, Byte64VectorTests::SUB); } static byte sub(byte a, byte b) { return (byte)(a - b); @@ -1382,7 +1382,7 @@ static void subByte64VectorTests(IntFunction fa, IntFunction fb) av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::sub); + assertArraysEquals(r, a, b, Byte64VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1402,7 +1402,7 @@ static void SUBByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::MUL); + assertArraysEquals(r, a, b, Byte64VectorTests::MUL); } static byte mul(byte a, byte b) { return (byte)(a * b); @@ -1458,7 +1458,7 @@ static void mulByte64VectorTests(IntFunction fa, IntFunction fb) av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::mul); + assertArraysEquals(r, a, b, Byte64VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1478,7 +1478,7 @@ static void MULByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::DIV); + assertArraysEquals(r, a, b, Byte64VectorTests::DIV); } static byte div(byte a, byte b) { return (byte)(a / b); @@ -1543,7 +1543,7 @@ static void divByte64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::div); + assertArraysEquals(r, a, b, Byte64VectorTests::div); } @@ -1567,7 +1567,7 @@ static void DIVByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, mask, Byte64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Byte64VectorTests::FIRST_NONZERO); } static byte AND(byte a, byte b) { @@ -1651,7 +1651,7 @@ static void ANDByte64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::AND); + assertArraysEquals(r, a, b, Byte64VectorTests::AND); } static byte and(byte a, byte b) { return (byte)(a & b); @@ -1669,7 +1669,7 @@ static void andByte64VectorTests(IntFunction fa, IntFunction fb) av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::and); + assertArraysEquals(r, a, b, Byte64VectorTests::and); } @@ -1691,7 +1691,7 @@ static void ANDByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Byte64VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Byte64VectorTests::AND_NOT); } @@ -1735,7 +1735,7 @@ static void AND_NOTByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::OR); + assertArraysEquals(r, a, b, Byte64VectorTests::OR); } static byte or(byte a, byte b) { return (byte)(a | b); @@ -1775,7 +1775,7 @@ static void orByte64VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::or); + assertArraysEquals(r, a, b, Byte64VectorTests::or); } @@ -1797,7 +1797,7 @@ static void ORByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::XOR); + assertArraysEquals(r, a, b, Byte64VectorTests::XOR); } @@ -1841,7 +1841,7 @@ static void XORByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFu av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1873,7 +1873,7 @@ static void addByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::add); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1887,7 +1887,7 @@ static void subByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1904,7 +1904,7 @@ static void subByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::sub); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1918,7 +1918,7 @@ static void mulByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1935,7 +1935,7 @@ static void mulByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::mul); } @@ -1954,7 +1954,7 @@ static void divByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::div); } @@ -1975,7 +1975,7 @@ static void divByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::div); } @@ -1991,7 +1991,7 @@ static void ORByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::OR); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2005,7 +2005,7 @@ static void orByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::or); } @@ -2024,7 +2024,7 @@ static void ORByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::OR); } @@ -2040,7 +2040,7 @@ static void ANDByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::AND); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2054,7 +2054,7 @@ static void andByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::and); } @@ -2073,7 +2073,7 @@ static void ANDByte64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Byte64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Byte64VectorTests::AND); } @@ -2089,7 +2089,7 @@ static void ORByte64VectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Byte64VectorTests::OR); } @@ -2108,7 +2108,7 @@ static void ORByte64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte64VectorTests::OR); } @@ -2123,7 +2123,7 @@ static void ADDByte64VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Byte64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Byte64VectorTests::ADD); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -2140,7 +2140,7 @@ static void ADDByte64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte64VectorTests::ADD); } @@ -2163,7 +2163,7 @@ static void LSHLByte64VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte64VectorTests::LSHL); + assertArraysEquals(r, a, b, Byte64VectorTests::LSHL); } @@ -2185,7 +2185,7 @@ static void LSHLByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte64VectorTests::ASHR); + assertArraysEquals(r, a, b, Byte64VectorTests::ASHR); } @@ -2233,7 +2233,7 @@ static void ASHRByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Byte64VectorTests::LSHR); + assertArraysEquals(r, a, b, Byte64VectorTests::LSHR); } @@ -2281,7 +2281,7 @@ static void LSHRByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::MIN); + assertArraysEquals(r, a, b, Byte64VectorTests::MIN); } static byte min(byte a, byte b) { return (byte)(Math.min(a, b)); @@ -2460,7 +2460,7 @@ static void minByte64VectorTests(IntFunction fa, IntFunction fb) av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::min); + assertArraysEquals(r, a, b, Byte64VectorTests::min); } static byte MAX(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2480,7 +2480,7 @@ static void MAXByte64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Byte64VectorTests::MAX); + assertArraysEquals(r, a, b, Byte64VectorTests::MAX); } static byte max(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2498,7 +2498,7 @@ static void maxByte64VectorTests(IntFunction fa, IntFunction fb) av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::max); + assertArraysEquals(r, a, b, Byte64VectorTests::max); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2512,7 +2512,7 @@ static void MINByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::MIN); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2526,7 +2526,7 @@ static void minByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::min); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2540,7 +2540,7 @@ static void MAXByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::MAX); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2554,7 +2554,7 @@ static void maxByte64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Byte64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Byte64VectorTests::max); } static byte ANDReduce(byte[] a, int idx) { @@ -2597,7 +2597,7 @@ static void ANDReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::ANDReduce, Byte64VectorTests::ANDReduceAll); } @@ -2645,7 +2645,7 @@ static void ANDReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::ANDReduceMasked, Byte64VectorTests::ANDReduceAllMasked); } @@ -2690,7 +2690,7 @@ static void ORReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::ORReduce, Byte64VectorTests::ORReduceAll); } @@ -2738,7 +2738,7 @@ static void ORReduceByte64VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::ORReduceMasked, Byte64VectorTests::ORReduceAllMasked); } @@ -2783,7 +2783,7 @@ static void XORReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::XORReduce, Byte64VectorTests::XORReduceAll); } @@ -2831,7 +2831,7 @@ static void XORReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::XORReduceMasked, Byte64VectorTests::XORReduceAllMasked); } @@ -2873,7 +2873,7 @@ static void ADDReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::ADDReduce, Byte64VectorTests::ADDReduceAll); } static byte ADDReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -2917,7 +2917,7 @@ static void ADDReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::ADDReduceMasked, Byte64VectorTests::ADDReduceAllMasked); } static byte MULReduce(byte[] a, int idx) { @@ -2958,7 +2958,7 @@ static void MULReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::MULReduce, Byte64VectorTests::MULReduceAll); } static byte MULReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3002,7 +3002,7 @@ static void MULReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::MULReduceMasked, Byte64VectorTests::MULReduceAllMasked); } static byte MINReduce(byte[] a, int idx) { @@ -3043,7 +3043,7 @@ static void MINReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::MINReduce, Byte64VectorTests::MINReduceAll); } static byte MINReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3088,7 +3088,7 @@ static void MINReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::MINReduceMasked, Byte64VectorTests::MINReduceAllMasked); } static byte MAXReduce(byte[] a, int idx) { @@ -3129,7 +3129,7 @@ static void MAXReduceByte64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Byte64VectorTests::MAXReduce, Byte64VectorTests::MAXReduceAll); } static byte MAXReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3174,7 +3174,7 @@ static void MAXReduceByte64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::MAXReduceMasked, Byte64VectorTests::MAXReduceAllMasked); } @@ -3200,7 +3200,7 @@ static void anyTrueByte64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte64VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Byte64VectorTests::anyTrue); } @@ -3226,7 +3226,7 @@ static void allTrueByte64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Byte64VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Byte64VectorTests::allTrue); } @@ -3242,7 +3242,7 @@ static void withByte64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (byte)4, 0); + assertInsertArraysEquals(r, a, (byte)4, 0); } static boolean testIS_DEFAULT(byte a) { return bits(a)==0; @@ -3791,7 +3791,7 @@ static void blendByte64VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, mask, Byte64VectorTests::blend); + assertArraysEquals(r, a, b, mask, Byte64VectorTests::blend); } @Test(dataProvider = "byteUnaryOpShuffleProvider") @@ -3808,7 +3808,7 @@ static void RearrangeByte64VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpShuffleMaskProvider") @@ -3826,7 +3826,7 @@ static void RearrangeByte64VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpProvider") static void getByte64VectorTests(IntFunction fa) { @@ -3981,7 +3981,7 @@ static void getByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::get); + assertArraysEquals(r, a, Byte64VectorTests::get); } @Test(dataProvider = "byteUnaryOpProvider") @@ -3995,7 +3995,7 @@ static void BroadcastByte64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4042,7 +4042,7 @@ static void sliceUnaryByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Byte64VectorTests::sliceUnary); } static byte[] sliceBinary(byte[] a, byte[] b, int origin, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4071,7 +4071,7 @@ static void sliceBinaryByte64VectorTestsBinary(IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, origin, Byte64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Byte64VectorTests::sliceBinary); } static byte[] slice(byte[] a, byte[] b, int origin, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4104,7 +4104,7 @@ static void sliceByte64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Byte64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Byte64VectorTests::unsliceUnary); } static byte[] unsliceBinary(byte[] a, byte[] b, int origin, int part, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4170,7 +4170,7 @@ static void unsliceBinaryByte64VectorTestsBinary(IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, origin, part, Byte64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Byte64VectorTests::unsliceBinary); } static byte[] unslice(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4226,7 +4226,7 @@ static void unsliceByte64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4291,7 +4291,7 @@ static void bitwiseBlendByte64VectorTests(IntFunction fa, IntFunction fa, IntFunc } } - assertArraysEquals(a, b, c, r, mask, Byte64VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Byte64VectorTests::BITWISE_BLEND); } @@ -4332,7 +4332,7 @@ static void BITWISE_BLENDByte64VectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Byte64VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Byte64VectorTests::BITWISE_BLEND); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4347,7 +4347,7 @@ static void BITWISE_BLENDByte64VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4361,7 +4361,7 @@ static void bitwiseBlendByte64VectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Byte64VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Byte64VectorTests::bitwiseBlend); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4376,7 +4376,7 @@ static void bitwiseBlendByte64VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4447,7 +4447,7 @@ static void bitwiseBlendByte64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::NEG); + assertArraysEquals(r, a, Byte64VectorTests::NEG); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4505,7 +4505,7 @@ static void negByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::neg); + assertArraysEquals(r, a, Byte64VectorTests::neg); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4523,7 +4523,7 @@ static void NEGMaskedByte64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte64VectorTests::NEG); + assertArraysEquals(r, a, mask, Byte64VectorTests::NEG); } static byte ABS(byte a) { @@ -4546,7 +4546,7 @@ static void ABSByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::ABS); + assertArraysEquals(r, a, Byte64VectorTests::ABS); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4561,7 +4561,7 @@ static void absByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::abs); + assertArraysEquals(r, a, Byte64VectorTests::abs); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4579,7 +4579,7 @@ static void ABSMaskedByte64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte64VectorTests::ABS); + assertArraysEquals(r, a, mask, Byte64VectorTests::ABS); } @@ -4605,7 +4605,7 @@ static void NOTByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::NOT); + assertArraysEquals(r, a, Byte64VectorTests::NOT); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4620,7 +4620,7 @@ static void notByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::not); + assertArraysEquals(r, a, Byte64VectorTests::not); } @@ -4640,7 +4640,7 @@ static void NOTMaskedByte64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte64VectorTests::NOT); + assertArraysEquals(r, a, mask, Byte64VectorTests::NOT); } @@ -4663,7 +4663,7 @@ static void ZOMOByte64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Byte64VectorTests::ZOMO); + assertArraysEquals(r, a, Byte64VectorTests::ZOMO); } @@ -4683,7 +4683,7 @@ static void ZOMOMaskedByte64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Byte64VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Byte64VectorTests::ZOMO); } @@ -4711,7 +4711,7 @@ static void gatherByte64VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4855,8 +4855,8 @@ static void toLongArrayByte64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4866,8 +4866,8 @@ static void toDoubleArrayByte64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4907,7 +4907,7 @@ static void reinterpretAsBytesByte64VectorTestsSmokeTest(IntFunction fa) ByteVector av = ByteVector.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } static long ADDReduceLong(byte[] a, int idx) { @@ -4944,7 +4944,7 @@ static void ADDReduceLongByte64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Byte64VectorTests::ADDReduceLong, Byte64VectorTests::ADDReduceAllLong); } @@ -4985,7 +4985,7 @@ static void ADDReduceLongByte64VectorTestsMasked(IntFunction fa, IntFunc ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Byte64VectorTests::ADDReduceLongMasked, Byte64VectorTests::ADDReduceAllLongMasked); } @@ -4997,7 +4997,7 @@ static void BroadcastLongByte64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -5015,7 +5015,7 @@ static void blendByte64VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Byte64VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Byte64VectorTests::blend); } @@ -5032,7 +5032,7 @@ static void SelectFromByte64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpSelectFromMaskProvider") @@ -5051,7 +5051,7 @@ static void SelectFromByte64VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5128,7 +5128,7 @@ static void maskEqByte64VectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Byte64VectorTests::beq); + assertArraysEquals(r, a, b, Byte64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java index 50cc6e3c08c05..e642f4d780c69 100644 --- a/test/jdk/jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -66,36 +66,14 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -399,7 +377,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "byteProviderForIOOBE") @@ -470,7 +448,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteMaskProviderForIOOBE") @@ -554,7 +532,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -578,7 +556,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -665,7 +643,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -680,7 +658,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -796,7 +774,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "byteByteProviderForIOOBE") @@ -877,7 +855,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "byteByteMaskProviderForIOOBE") @@ -965,7 +943,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -976,7 +954,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java b/test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java index c1c216f8db501..d6dd82af7ae04 100644 --- a/test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/ByteMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { byte apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { byte[] apply(byte a); } - static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(byte[] a, byte[] r, FUnArrayOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a[i]); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { byte apply(byte[] a); } - static void assertReductionArraysEquals(byte[] a, byte[] b, byte c, + static void assertReductionArraysEquals(byte[] r, byte rc, byte[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { byte apply(byte[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(byte[] a, byte[] b, byte c, boolean[] mask, + static void assertReductionArraysEqualsMasked(byte[] r, byte rc, byte[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -167,17 +167,17 @@ interface FReductionAllOpLong { long apply(byte[] a); } - static void assertReductionLongArraysEquals(byte[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, byte[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -189,17 +189,17 @@ interface FReductionAllMaskedOpLong { long apply(byte[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(byte[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, byte[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -207,37 +207,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(byte[] a, byte[] b, byte element, int index) { + static void assertInsertArraysEquals(byte[] r, byte[] a, byte element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -251,7 +251,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -265,7 +265,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, int v } } - static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(byte[] r, byte[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -285,7 +285,7 @@ static void assertRearrangeArraysEquals(byte[] a, byte[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(byte[] r, byte[] a, byte[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -305,7 +305,7 @@ static void assertSelectFromArraysEquals(byte[] a, byte[] r, byte[] order, boole } } - static void assertBroadcastArraysEquals(byte[]a, byte[]r) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -334,7 +334,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -345,7 +345,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -357,7 +357,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -369,11 +369,11 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -384,11 +384,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -402,11 +402,11 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -420,7 +420,7 @@ static void assertBroadcastLongArraysEquals(byte[] a, byte[] b, byte[] r, boolea } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -434,11 +434,11 @@ static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, FBinOp f) { } } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(byte[] a, byte[] b, byte[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(byte[] r, byte[] a, byte[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -464,7 +464,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -475,11 +475,11 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f } } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -491,7 +491,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -504,7 +504,7 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,12 +517,12 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -538,12 +538,12 @@ static void assertBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, } } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ static void assertAltBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,12 +574,12 @@ static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte } } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(byte[] a, byte[] b, byte[] c, byte[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(byte[] r, byte[] a, byte[] b, byte[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -602,7 +602,7 @@ interface FBinArrayOp { byte apply(byte[] a, int b); } - static void assertArraysEquals(byte[] a, byte[] r, FBinArrayOp f) { + static void assertArraysEquals(byte[] r, byte[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -617,7 +617,7 @@ interface FGatherScatterOp { byte[] apply(byte[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, FGatherScatterOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -644,7 +644,7 @@ interface FScatterMaskedOp { byte[] apply(byte[] r, byte[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } catch (AssertionError e) { byte[] ref = f.apply(a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -665,7 +665,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FGat } } - static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -675,7 +675,7 @@ static void assertArraysEquals(byte[] a, int[] b, byte[] r, boolean[] mask, FSca } catch (AssertionError e) { byte[] ref = f.apply(r, a, i, mask, b, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -692,7 +692,7 @@ interface FLaneOp { byte[] apply(byte[] a, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { + static void assertArraysEquals(byte[] r, byte[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -702,7 +702,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int origin, FLaneOp f) { } catch (AssertionError e) { byte[] ref = f.apply(a, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -712,7 +712,7 @@ interface FLaneBop { byte[] apply(byte[] a, byte[] b, int origin, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -722,7 +722,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, FLaneBo } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -733,7 +733,7 @@ interface FLaneMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -743,7 +743,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, boolean } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -754,7 +754,7 @@ interface FLanePartBop { byte[] apply(byte[] a, byte[] b, int origin, int part, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -764,7 +764,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -776,7 +776,7 @@ interface FLanePartMaskedBop { byte[] apply(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(byte[] r, byte[] a, byte[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -786,7 +786,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } catch (AssertionError e) { byte[] ref = f.apply(a, b, origin, part, mask, i); byte[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -795,7 +795,7 @@ static void assertArraysEquals(byte[] a, byte[] b, byte[] r, int origin, int par } - static void assertArraysEquals(byte[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -807,7 +807,7 @@ static void assertArraysEquals(byte[] a, int[] r, int offs) { } - static void assertArraysEquals(byte[] a, byte[] r, int offs) { + static void assertArraysEquals(byte[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -818,7 +818,7 @@ static void assertArraysEquals(byte[] a, byte[] r, int offs) { } } - static void assertArraysEquals(byte[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -829,7 +829,7 @@ static void assertArraysEquals(byte[] a, long[] r, int offs) { } } - static void assertArraysEquals(byte[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, byte[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1293,7 +1293,7 @@ static void ADDByteMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::ADD); + assertArraysEquals(r, a, b, ByteMaxVectorTests::ADD); } static byte add(byte a, byte b) { return (byte)(a + b); @@ -1311,7 +1311,7 @@ static void addByteMaxVectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::add); + assertArraysEquals(r, a, b, ByteMaxVectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1331,7 +1331,7 @@ static void ADDByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::SUB); + assertArraysEquals(r, a, b, ByteMaxVectorTests::SUB); } static byte sub(byte a, byte b) { return (byte)(a - b); @@ -1387,7 +1387,7 @@ static void subByteMaxVectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::sub); + assertArraysEquals(r, a, b, ByteMaxVectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1407,7 +1407,7 @@ static void SUBByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::MUL); + assertArraysEquals(r, a, b, ByteMaxVectorTests::MUL); } static byte mul(byte a, byte b) { return (byte)(a * b); @@ -1463,7 +1463,7 @@ static void mulByteMaxVectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::mul); + assertArraysEquals(r, a, b, ByteMaxVectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1483,7 +1483,7 @@ static void MULByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::DIV); + assertArraysEquals(r, a, b, ByteMaxVectorTests::DIV); } static byte div(byte a, byte b) { return (byte)(a / b); @@ -1548,7 +1548,7 @@ static void divByteMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::div); + assertArraysEquals(r, a, b, ByteMaxVectorTests::div); } @@ -1572,7 +1572,7 @@ static void DIVByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, ByteMaxVectorTests::FIRST_NONZERO); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1635,7 +1635,7 @@ static void FIRST_NONZEROByteMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, ByteMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, ByteMaxVectorTests::FIRST_NONZERO); } static byte AND(byte a, byte b) { @@ -1656,7 +1656,7 @@ static void ANDByteMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::AND); + assertArraysEquals(r, a, b, ByteMaxVectorTests::AND); } static byte and(byte a, byte b) { return (byte)(a & b); @@ -1674,7 +1674,7 @@ static void andByteMaxVectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::and); + assertArraysEquals(r, a, b, ByteMaxVectorTests::and); } @@ -1696,7 +1696,7 @@ static void ANDByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, ByteMaxVectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, ByteMaxVectorTests::AND_NOT); } @@ -1762,7 +1762,7 @@ static void ORByteMaxVectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::OR); + assertArraysEquals(r, a, b, ByteMaxVectorTests::OR); } static byte or(byte a, byte b) { return (byte)(a | b); @@ -1780,7 +1780,7 @@ static void orByteMaxVectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::or); + assertArraysEquals(r, a, b, ByteMaxVectorTests::or); } @@ -1802,7 +1802,7 @@ static void ORByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::XOR); + assertArraysEquals(r, a, b, ByteMaxVectorTests::XOR); } @@ -1846,7 +1846,7 @@ static void XORByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::add); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1878,7 +1878,7 @@ static void addByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::add); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1892,7 +1892,7 @@ static void subByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::sub); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1909,7 +1909,7 @@ static void subByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::sub); } @Test(dataProvider = "byteBinaryOpProvider") @@ -1923,7 +1923,7 @@ static void mulByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::mul); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -1940,7 +1940,7 @@ static void mulByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::mul); } @@ -1959,7 +1959,7 @@ static void divByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::div); } @@ -1980,7 +1980,7 @@ static void divByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::div); } @@ -1996,7 +1996,7 @@ static void ORByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::OR); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2010,7 +2010,7 @@ static void orByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::or); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::or); } @@ -2029,7 +2029,7 @@ static void ORByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::OR); } @@ -2045,7 +2045,7 @@ static void ANDByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::AND); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2059,7 +2059,7 @@ static void andByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::and); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::and); } @@ -2078,7 +2078,7 @@ static void ANDByteMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ByteMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, ByteMaxVectorTests::AND); } @@ -2094,7 +2094,7 @@ static void ORByteMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, ByteMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, ByteMaxVectorTests::OR); } @@ -2113,7 +2113,7 @@ static void ORByteMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, ByteMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, ByteMaxVectorTests::OR); } @@ -2128,7 +2128,7 @@ static void ADDByteMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, ByteMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, ByteMaxVectorTests::ADD); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -2145,7 +2145,7 @@ static void ADDByteMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::LSHL); + assertArraysEquals(r, a, b, ByteMaxVectorTests::LSHL); } @@ -2190,7 +2190,7 @@ static void LSHLByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::ASHR); + assertArraysEquals(r, a, b, ByteMaxVectorTests::ASHR); } @@ -2238,7 +2238,7 @@ static void ASHRByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::LSHR); + assertArraysEquals(r, a, b, ByteMaxVectorTests::LSHR); } @@ -2286,7 +2286,7 @@ static void LSHRByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::MIN); + assertArraysEquals(r, a, b, ByteMaxVectorTests::MIN); } static byte min(byte a, byte b) { return (byte)(Math.min(a, b)); @@ -2465,7 +2465,7 @@ static void minByteMaxVectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::min); + assertArraysEquals(r, a, b, ByteMaxVectorTests::min); } static byte MAX(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2485,7 +2485,7 @@ static void MAXByteMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, ByteMaxVectorTests::MAX); + assertArraysEquals(r, a, b, ByteMaxVectorTests::MAX); } static byte max(byte a, byte b) { return (byte)(Math.max(a, b)); @@ -2503,7 +2503,7 @@ static void maxByteMaxVectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::max); + assertArraysEquals(r, a, b, ByteMaxVectorTests::max); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2517,7 +2517,7 @@ static void MINByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::MIN); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2531,7 +2531,7 @@ static void minByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::min); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2545,7 +2545,7 @@ static void MAXByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::MAX); } @Test(dataProvider = "byteBinaryOpProvider") @@ -2559,7 +2559,7 @@ static void maxByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ByteMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, ByteMaxVectorTests::max); } static byte ANDReduce(byte[] a, int idx) { @@ -2602,7 +2602,7 @@ static void ANDReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::ANDReduce, ByteMaxVectorTests::ANDReduceAll); } @@ -2650,7 +2650,7 @@ static void ANDReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::ANDReduceMasked, ByteMaxVectorTests::ANDReduceAllMasked); } @@ -2695,7 +2695,7 @@ static void ORReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::ORReduce, ByteMaxVectorTests::ORReduceAll); } @@ -2743,7 +2743,7 @@ static void ORReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::ORReduceMasked, ByteMaxVectorTests::ORReduceAllMasked); } @@ -2788,7 +2788,7 @@ static void XORReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::XORReduce, ByteMaxVectorTests::XORReduceAll); } @@ -2836,7 +2836,7 @@ static void XORReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::XORReduceMasked, ByteMaxVectorTests::XORReduceAllMasked); } @@ -2878,7 +2878,7 @@ static void ADDReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::ADDReduce, ByteMaxVectorTests::ADDReduceAll); } static byte ADDReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -2922,7 +2922,7 @@ static void ADDReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::ADDReduceMasked, ByteMaxVectorTests::ADDReduceAllMasked); } static byte MULReduce(byte[] a, int idx) { @@ -2963,7 +2963,7 @@ static void MULReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::MULReduce, ByteMaxVectorTests::MULReduceAll); } static byte MULReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3007,7 +3007,7 @@ static void MULReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::MULReduceMasked, ByteMaxVectorTests::MULReduceAllMasked); } static byte MINReduce(byte[] a, int idx) { @@ -3048,7 +3048,7 @@ static void MINReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::MINReduce, ByteMaxVectorTests::MINReduceAll); } static byte MINReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3093,7 +3093,7 @@ static void MINReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::MINReduceMasked, ByteMaxVectorTests::MINReduceAllMasked); } static byte MAXReduce(byte[] a, int idx) { @@ -3134,7 +3134,7 @@ static void MAXReduceByteMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ByteMaxVectorTests::MAXReduce, ByteMaxVectorTests::MAXReduceAll); } static byte MAXReduceMasked(byte[] a, int idx, boolean[] mask) { @@ -3179,7 +3179,7 @@ static void MAXReduceByteMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::MAXReduceMasked, ByteMaxVectorTests::MAXReduceAllMasked); } @@ -3205,7 +3205,7 @@ static void anyTrueByteMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, ByteMaxVectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, ByteMaxVectorTests::anyTrue); } @@ -3231,7 +3231,7 @@ static void allTrueByteMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, ByteMaxVectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, ByteMaxVectorTests::allTrue); } @@ -3247,7 +3247,7 @@ static void withByteMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (byte)4, 0); + assertInsertArraysEquals(r, a, (byte)4, 0); } static boolean testIS_DEFAULT(byte a) { return bits(a)==0; @@ -3796,7 +3796,7 @@ static void blendByteMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, ByteMaxVectorTests::blend); + assertArraysEquals(r, a, b, mask, ByteMaxVectorTests::blend); } @Test(dataProvider = "byteUnaryOpShuffleProvider") @@ -3813,7 +3813,7 @@ static void RearrangeByteMaxVectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpShuffleMaskProvider") @@ -3831,7 +3831,7 @@ static void RearrangeByteMaxVectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpProvider") static void getByteMaxVectorTests(IntFunction fa) { @@ -3986,7 +3986,7 @@ static void getByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::get); + assertArraysEquals(r, a, ByteMaxVectorTests::get); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4000,7 +4000,7 @@ static void BroadcastByteMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4047,7 +4047,7 @@ static void sliceUnaryByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, ByteMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, ByteMaxVectorTests::sliceUnary); } static byte[] sliceBinary(byte[] a, byte[] b, int origin, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4076,7 +4076,7 @@ static void sliceBinaryByteMaxVectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, ByteMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, ByteMaxVectorTests::sliceBinary); } static byte[] slice(byte[] a, byte[] b, int origin, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4109,7 +4109,7 @@ static void sliceByteMaxVectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, ByteMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, ByteMaxVectorTests::unsliceUnary); } static byte[] unsliceBinary(byte[] a, byte[] b, int origin, int part, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4175,7 +4175,7 @@ static void unsliceBinaryByteMaxVectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, ByteMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, ByteMaxVectorTests::unsliceBinary); } static byte[] unslice(byte[] a, byte[] b, int origin, int part, boolean[] mask, int idx) { byte[] res = new byte[SPECIES.length()]; @@ -4231,7 +4231,7 @@ static void unsliceByteMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, ByteMaxVectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, ByteMaxVectorTests::unslice); } @@ -4280,7 +4280,7 @@ static void BITWISE_BLENDByteMaxVectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, ByteMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, ByteMaxVectorTests::BITWISE_BLEND); } @Test(dataProvider = "byteTernaryOpProvider") static void bitwiseBlendByteMaxVectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4296,7 +4296,7 @@ static void bitwiseBlendByteMaxVectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, ByteMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, ByteMaxVectorTests::BITWISE_BLEND); } @@ -4337,7 +4337,7 @@ static void BITWISE_BLENDByteMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4366,7 +4366,7 @@ static void bitwiseBlendByteMaxVectorTestsBroadcastSmokeTest(IntFunction ByteVector bv = ByteVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, ByteMaxVectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, ByteMaxVectorTests::bitwiseBlend); } @Test(dataProvider = "byteTernaryOpProvider") @@ -4381,7 +4381,7 @@ static void bitwiseBlendByteMaxVectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4452,7 +4452,7 @@ static void bitwiseBlendByteMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::NEG); + assertArraysEquals(r, a, ByteMaxVectorTests::NEG); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4510,7 +4510,7 @@ static void negByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::neg); + assertArraysEquals(r, a, ByteMaxVectorTests::neg); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4528,7 +4528,7 @@ static void NEGMaskedByteMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ByteMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, ByteMaxVectorTests::NEG); } static byte ABS(byte a) { @@ -4551,7 +4551,7 @@ static void ABSByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::ABS); + assertArraysEquals(r, a, ByteMaxVectorTests::ABS); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4566,7 +4566,7 @@ static void absByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::abs); + assertArraysEquals(r, a, ByteMaxVectorTests::abs); } @Test(dataProvider = "byteUnaryOpMaskProvider") @@ -4584,7 +4584,7 @@ static void ABSMaskedByteMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ByteMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, ByteMaxVectorTests::ABS); } @@ -4610,7 +4610,7 @@ static void NOTByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::NOT); + assertArraysEquals(r, a, ByteMaxVectorTests::NOT); } @Test(dataProvider = "byteUnaryOpProvider") @@ -4625,7 +4625,7 @@ static void notByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::not); + assertArraysEquals(r, a, ByteMaxVectorTests::not); } @@ -4645,7 +4645,7 @@ static void NOTMaskedByteMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ByteMaxVectorTests::NOT); + assertArraysEquals(r, a, mask, ByteMaxVectorTests::NOT); } @@ -4668,7 +4668,7 @@ static void ZOMOByteMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ByteMaxVectorTests::ZOMO); + assertArraysEquals(r, a, ByteMaxVectorTests::ZOMO); } @@ -4688,7 +4688,7 @@ static void ZOMOMaskedByteMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ByteMaxVectorTests::ZOMO); + assertArraysEquals(r, a, mask, ByteMaxVectorTests::ZOMO); } @@ -4716,7 +4716,7 @@ static void gatherByteMaxVectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, ByteMaxVectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, ByteMaxVectorTests::scatterMasked); } @@ -4849,8 +4849,8 @@ static void toIntArrayByteMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4860,8 +4860,8 @@ static void toLongArrayByteMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4871,8 +4871,8 @@ static void toDoubleArrayByteMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector av = ByteVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4912,7 +4912,7 @@ static void reinterpretAsBytesByteMaxVectorTestsSmokeTest(IntFunction fa ByteVector av = ByteVector.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } static long ADDReduceLong(byte[] a, int idx) { @@ -4949,7 +4949,7 @@ static void ADDReduceLongByteMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, ByteMaxVectorTests::ADDReduceLong, ByteMaxVectorTests::ADDReduceAllLong); } @@ -4990,7 +4990,7 @@ static void ADDReduceLongByteMaxVectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, ByteMaxVectorTests::ADDReduceLongMasked, ByteMaxVectorTests::ADDReduceAllLongMasked); } @@ -5002,7 +5002,7 @@ static void BroadcastLongByteMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ByteVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "byteBinaryOpMaskProvider") @@ -5020,7 +5020,7 @@ static void blendByteMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, ByteMaxVectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, ByteMaxVectorTests::blend); } @@ -5037,7 +5037,7 @@ static void SelectFromByteMaxVectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "byteUnaryOpSelectFromMaskProvider") @@ -5056,7 +5056,7 @@ static void SelectFromByteMaxVectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5133,7 +5133,7 @@ static void maskEqByteMaxVectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, ByteMaxVectorTests::beq); + assertArraysEquals(r, a, b, ByteMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Double128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Double128VectorLoadStoreTests.java index f1f09b98eccb2..3e5d6f07c4e17 100644 --- a/test/jdk/jdk/incubator/vector/Double128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Double128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Double128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(double[] a, double[] r, boolean[] mask) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0, "at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(double[] a, double[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "doubleProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new double[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Double128VectorTests.java b/test/jdk/jdk/incubator/vector/Double128VectorTests.java index 1f22bd2fb6153..b1faaf7ced180 100644 --- a/test/jdk/jdk/incubator/vector/Double128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Double128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { double apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { double[] apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { } catch (AssertionError e) { double[] ref = f.apply(a[i]); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { double apply(double[] a); } - static void assertReductionArraysEquals(double[] a, double[] b, double c, + static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { double apply(double[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(double[] a, double[] b, double c, boolean[] mask, + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(double[] a); } - static void assertReductionLongArraysEquals(double[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, double[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(double[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(double[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, double[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(double[] a, double[] b, double element, int index) { + static void assertInsertArraysEquals(double[] r, double[] a, double element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boo } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertBroadcastArraysEquals(double[]a, double[]r) { + static void assertBroadcastArraysEquals(double[] r, double[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBin } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, bool } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, F } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, b } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(double actual, double expected) { return true; } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, } } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, F } } - static void assertBroadcastArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { double apply(double[] a, int b); } - static void assertArraysEquals(double[] a, double[] r, FBinArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { double[] apply(double[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, FGatherScatterOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { double[] apply(double[] r, double[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(r, a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { double[] apply(double[] a, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { + static void assertArraysEquals(double[] r, double[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { } catch (AssertionError e) { double[] ref = f.apply(a, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { double[] apply(double[] a, double[] b, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, FLaneBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, F } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { double[] apply(double[] a, double[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, b } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { double[] apply(double[] a, double[] b, int origin, int part, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { double[] apply(double[] a, double[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(double[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(double[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1396,7 +1396,7 @@ static void ADDDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Double128VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1452,7 +1452,7 @@ static void addDouble128VectorTestsMasked(IntFunction fa, IntFunction< av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double128VectorTests::add); + assertArraysEquals(r, a, b, mask, Double128VectorTests::add); } static double SUB(double a, double b) { return (double)(a - b); @@ -1472,7 +1472,7 @@ static void SUBDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Double128VectorTests::SUB); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1528,7 +1528,7 @@ static void subDouble128VectorTestsMasked(IntFunction fa, IntFunction< av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double128VectorTests::sub); + assertArraysEquals(r, a, b, mask, Double128VectorTests::sub); } static double MUL(double a, double b) { return (double)(a * b); @@ -1548,7 +1548,7 @@ static void MULDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Double128VectorTests::MUL); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1604,7 +1604,7 @@ static void mulDouble128VectorTestsMasked(IntFunction fa, IntFunction< av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double128VectorTests::mul); + assertArraysEquals(r, a, b, mask, Double128VectorTests::mul); } static double DIV(double a, double b) { @@ -1625,7 +1625,7 @@ static void DIVDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Double128VectorTests::DIV); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1683,7 +1683,7 @@ static void divDouble128VectorTestsMasked(IntFunction fa, IntFunction< av.div(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double128VectorTests::div); + assertArraysEquals(r, a, b, mask, Double128VectorTests::div); } @@ -1706,7 +1706,7 @@ static void FIRST_NONZERODouble128VectorTests(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, Double128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Double128VectorTests::FIRST_NONZERO); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1726,7 +1726,7 @@ static void FIRST_NONZERODouble128VectorTestsMasked(IntFunction fa, In } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Double128VectorTests::FIRST_NONZERO); } @@ -1748,7 +1748,7 @@ static void addDouble128VectorTestsBroadcastSmokeTest(IntFunction fa, av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::add); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1765,7 +1765,7 @@ static void addDouble128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::sub); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1796,7 +1796,7 @@ static void subDouble128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::mul); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1827,7 +1827,7 @@ static void mulDouble128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::div); } @@ -1861,7 +1861,7 @@ static void divDouble128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Double128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Double128VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void ADDDouble128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::MIN); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void minDouble128VectorTestsBroadcastSmokeTest(IntFunction fa, av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::min); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2055,7 +2055,7 @@ static void MAXDouble128VectorTestsBroadcastSmokeTest(IntFunction fa, av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::MAX); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2069,7 +2069,7 @@ static void maxDouble128VectorTestsBroadcastSmokeTest(IntFunction fa, av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Double128VectorTests::max); } @@ -2121,7 +2121,7 @@ static void ADDReduceDouble128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double128VectorTests::ADDReduce, Double128VectorTests::ADDReduceAll); } static double ADDReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2165,7 +2165,7 @@ static void ADDReduceDouble128VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double128VectorTests::ADDReduceMasked, Double128VectorTests::ADDReduceAllMasked); } static double MULReduce(double[] a, int idx) { @@ -2206,7 +2206,7 @@ static void MULReduceDouble128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double128VectorTests::MULReduce, Double128VectorTests::MULReduceAll); } static double MULReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2250,7 +2250,7 @@ static void MULReduceDouble128VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double128VectorTests::MULReduceMasked, Double128VectorTests::MULReduceAllMasked); } static double MINReduce(double[] a, int idx) { @@ -2291,7 +2291,7 @@ static void MINReduceDouble128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double128VectorTests::MINReduce, Double128VectorTests::MINReduceAll); } static double MINReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2336,7 +2336,7 @@ static void MINReduceDouble128VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double128VectorTests::MINReduceMasked, Double128VectorTests::MINReduceAllMasked); } static double MAXReduce(double[] a, int idx) { @@ -2377,7 +2377,7 @@ static void MAXReduceDouble128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double128VectorTests::MAXReduce, Double128VectorTests::MAXReduceAll); } static double MAXReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2422,7 +2422,7 @@ static void MAXReduceDouble128VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double128VectorTests::MAXReduceMasked, Double128VectorTests::MAXReduceAllMasked); } @@ -2442,7 +2442,7 @@ static void withDouble128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (double)4, 0); + assertInsertArraysEquals(r, a, (double)4, 0); } static boolean testIS_DEFAULT(double a) { return bits(a)==0; @@ -3108,7 +3108,7 @@ static void blendDouble128VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpShuffleMaskProvider") @@ -3143,7 +3143,7 @@ static void RearrangeDouble128VectorTestsMaskedSmokeTest(IntFunction f av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpProvider") static void getDouble128VectorTests(IntFunction fa) { @@ -3298,7 +3298,7 @@ static void getDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::get); + assertArraysEquals(r, a, Double128VectorTests::get); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -3312,7 +3312,7 @@ static void BroadcastDouble128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3359,7 +3359,7 @@ static void sliceUnaryDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Double128VectorTests::sliceUnary); } static double[] sliceBinary(double[] a, double[] b, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3388,7 +3388,7 @@ static void sliceBinaryDouble128VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, Double128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Double128VectorTests::sliceBinary); } static double[] slice(double[] a, double[] b, int origin, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3421,7 +3421,7 @@ static void sliceDouble128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, mask, Double128VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Double128VectorTests::slice); } static double[] unsliceUnary(double[] a, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3448,7 +3448,7 @@ static void unsliceUnaryDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Double128VectorTests::unsliceUnary); } static double[] unsliceBinary(double[] a, double[] b, int origin, int part, int idx) { double[] res = new double[SPECIES.length()]; @@ -3487,7 +3487,7 @@ static void unsliceBinaryDouble128VectorTestsBinary(IntFunction fa, In } } - assertArraysEquals(a, b, r, origin, part, Double128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Double128VectorTests::unsliceBinary); } static double[] unslice(double[] a, double[] b, int origin, int part, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3543,7 +3543,7 @@ static void unsliceDouble128VectorTestsMasked(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, mask, Double128VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Double128VectorTests::unslice); } static double SIN(double a) { @@ -3566,7 +3566,7 @@ static void SINDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::SIN, Double128VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::SIN, Double128VectorTests::strictSIN); } @@ -3590,7 +3590,7 @@ static void EXPDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::EXP, Double128VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::EXP, Double128VectorTests::strictEXP); } @@ -3614,7 +3614,7 @@ static void LOG1PDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::LOG1P, Double128VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::LOG1P, Double128VectorTests::strictLOG1P); } @@ -3638,7 +3638,7 @@ static void LOGDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::LOG, Double128VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::LOG, Double128VectorTests::strictLOG); } @@ -3662,7 +3662,7 @@ static void LOG10Double128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::LOG10, Double128VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::LOG10, Double128VectorTests::strictLOG10); } @@ -3686,7 +3686,7 @@ static void EXPM1Double128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::EXPM1, Double128VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::EXPM1, Double128VectorTests::strictEXPM1); } @@ -3710,7 +3710,7 @@ static void COSDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::COS, Double128VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::COS, Double128VectorTests::strictCOS); } @@ -3734,7 +3734,7 @@ static void TANDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::TAN, Double128VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::TAN, Double128VectorTests::strictTAN); } @@ -3758,7 +3758,7 @@ static void SINHDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::SINH, Double128VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::SINH, Double128VectorTests::strictSINH); } @@ -3782,7 +3782,7 @@ static void COSHDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::COSH, Double128VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::COSH, Double128VectorTests::strictCOSH); } @@ -3806,7 +3806,7 @@ static void TANHDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::TANH, Double128VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::TANH, Double128VectorTests::strictTANH); } @@ -3830,7 +3830,7 @@ static void ASINDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::ASIN, Double128VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::ASIN, Double128VectorTests::strictASIN); } @@ -3854,7 +3854,7 @@ static void ACOSDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::ACOS, Double128VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::ACOS, Double128VectorTests::strictACOS); } @@ -3878,7 +3878,7 @@ static void ATANDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::ATAN, Double128VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::ATAN, Double128VectorTests::strictATAN); } @@ -3902,7 +3902,7 @@ static void CBRTDouble128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double128VectorTests::CBRT, Double128VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Double128VectorTests::CBRT, Double128VectorTests::strictCBRT); } @@ -3928,7 +3928,7 @@ static void HYPOTDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double128VectorTests::POW, Double128VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double128VectorTests::POW, Double128VectorTests::strictPOW); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -4037,7 +4037,7 @@ static void powDouble128VectorTestsBroadcastSmokeTest(IntFunction fa, av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double128VectorTests::pow, Double128VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double128VectorTests::pow, Double128VectorTests::strictpow); } @@ -4073,7 +4073,7 @@ static void FMADouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4096,7 +4096,7 @@ static void fmaDouble128VectorTests(IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, mask, Double128VectorTests::FMA); + assertArraysEquals(r, a, b, c, mask, Double128VectorTests::FMA); } @@ -4145,7 +4145,7 @@ static void FMADouble128VectorTestsBroadcastSmokeTest(IntFunction fa, DoubleVector bv = DoubleVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Double128VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Double128VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") @@ -4160,7 +4160,7 @@ static void FMADouble128VectorTestsAltBroadcastSmokeTest(IntFunction f DoubleVector cv = DoubleVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Double128VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Double128VectorTests::FMA); } @@ -4180,7 +4180,7 @@ static void FMADouble128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4245,7 +4245,7 @@ static void fmaDouble128VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::NEG); + assertArraysEquals(r, a, Double128VectorTests::NEG); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4312,7 +4312,7 @@ static void negDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::neg); + assertArraysEquals(r, a, Double128VectorTests::neg); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4330,7 +4330,7 @@ static void NEGMaskedDouble128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double128VectorTests::NEG); + assertArraysEquals(r, a, mask, Double128VectorTests::NEG); } static double ABS(double a) { @@ -4353,7 +4353,7 @@ static void ABSDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::ABS); + assertArraysEquals(r, a, Double128VectorTests::ABS); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4368,7 +4368,7 @@ static void absDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::abs); + assertArraysEquals(r, a, Double128VectorTests::abs); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4386,7 +4386,7 @@ static void ABSMaskedDouble128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double128VectorTests::ABS); + assertArraysEquals(r, a, mask, Double128VectorTests::ABS); } @@ -4418,7 +4418,7 @@ static void SQRTDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::SQRT); + assertArraysEquals(r, a, Double128VectorTests::SQRT); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4433,7 +4433,7 @@ static void sqrtDouble128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double128VectorTests::sqrt); + assertArraysEquals(r, a, Double128VectorTests::sqrt); } @@ -4453,7 +4453,7 @@ static void SQRTMaskedDouble128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double128VectorTests::SQRT); + assertArraysEquals(r, a, mask, Double128VectorTests::SQRT); } static double[] gather(double a[], int ix, int[] b, int iy) { @@ -4478,7 +4478,7 @@ static void gatherDouble128VectorTests(IntFunction fa, BiFunction fa, BiFunctio } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Double128VectorTests::gatherMasked); } static double[] scatter(double a[], int ix, int[] b, int iy) { @@ -4531,7 +4531,7 @@ static void scatterDouble128VectorTests(IntFunction fa, BiFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Double128VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Double128VectorTests::scatterMasked); } @@ -4611,8 +4611,8 @@ static void toIntArrayDouble128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4622,8 +4622,8 @@ static void toLongArrayDouble128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4690,7 +4690,7 @@ static void ADDReduceLongDouble128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Double128VectorTests::ADDReduceLong, Double128VectorTests::ADDReduceAllLong); } @@ -4731,7 +4731,7 @@ static void ADDReduceLongDouble128VectorTestsMasked(IntFunction fa, In ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Double128VectorTests::ADDReduceLongMasked, Double128VectorTests::ADDReduceAllLongMasked); } @@ -4743,7 +4743,7 @@ static void BroadcastLongDouble128VectorTestsSmokeTest(IntFunction fa) for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -4761,7 +4761,7 @@ static void blendDouble128VectorTestsBroadcastLongSmokeTest(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpSelectFromMaskProvider") @@ -4797,7 +4797,7 @@ static void SelectFromDouble128VectorTestsMaskedSmokeTest(IntFunction bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4874,7 +4874,7 @@ static void maskEqDouble128VectorTestsSmokeTest(IntFunction fa, IntFu var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Double128VectorTests::beq); + assertArraysEquals(r, a, b, Double128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Double256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Double256VectorLoadStoreTests.java index 0491aa04da973..84da6e4648eeb 100644 --- a/test/jdk/jdk/incubator/vector/Double256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Double256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Double256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(double[] a, double[] r, boolean[] mask) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0, "at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(double[] a, double[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "doubleProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new double[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Double256VectorTests.java b/test/jdk/jdk/incubator/vector/Double256VectorTests.java index 8833300666b05..1e1a1a851f5d3 100644 --- a/test/jdk/jdk/incubator/vector/Double256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Double256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { double apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { double[] apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { } catch (AssertionError e) { double[] ref = f.apply(a[i]); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { double apply(double[] a); } - static void assertReductionArraysEquals(double[] a, double[] b, double c, + static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { double apply(double[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(double[] a, double[] b, double c, boolean[] mask, + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(double[] a); } - static void assertReductionLongArraysEquals(double[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, double[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(double[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(double[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, double[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(double[] a, double[] b, double element, int index) { + static void assertInsertArraysEquals(double[] r, double[] a, double element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boo } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertBroadcastArraysEquals(double[]a, double[]r) { + static void assertBroadcastArraysEquals(double[] r, double[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBin } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, bool } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, F } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, b } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(double actual, double expected) { return true; } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, } } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, F } } - static void assertBroadcastArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { double apply(double[] a, int b); } - static void assertArraysEquals(double[] a, double[] r, FBinArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { double[] apply(double[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, FGatherScatterOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { double[] apply(double[] r, double[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(r, a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { double[] apply(double[] a, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { + static void assertArraysEquals(double[] r, double[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { } catch (AssertionError e) { double[] ref = f.apply(a, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { double[] apply(double[] a, double[] b, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, FLaneBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, F } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { double[] apply(double[] a, double[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, b } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { double[] apply(double[] a, double[] b, int origin, int part, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { double[] apply(double[] a, double[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(double[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(double[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1396,7 +1396,7 @@ static void ADDDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Double256VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1452,7 +1452,7 @@ static void addDouble256VectorTestsMasked(IntFunction fa, IntFunction< av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double256VectorTests::add); + assertArraysEquals(r, a, b, mask, Double256VectorTests::add); } static double SUB(double a, double b) { return (double)(a - b); @@ -1472,7 +1472,7 @@ static void SUBDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Double256VectorTests::SUB); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1528,7 +1528,7 @@ static void subDouble256VectorTestsMasked(IntFunction fa, IntFunction< av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double256VectorTests::sub); + assertArraysEquals(r, a, b, mask, Double256VectorTests::sub); } static double MUL(double a, double b) { return (double)(a * b); @@ -1548,7 +1548,7 @@ static void MULDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Double256VectorTests::MUL); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1604,7 +1604,7 @@ static void mulDouble256VectorTestsMasked(IntFunction fa, IntFunction< av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double256VectorTests::mul); + assertArraysEquals(r, a, b, mask, Double256VectorTests::mul); } static double DIV(double a, double b) { @@ -1625,7 +1625,7 @@ static void DIVDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Double256VectorTests::DIV); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1683,7 +1683,7 @@ static void divDouble256VectorTestsMasked(IntFunction fa, IntFunction< av.div(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double256VectorTests::div); + assertArraysEquals(r, a, b, mask, Double256VectorTests::div); } @@ -1706,7 +1706,7 @@ static void FIRST_NONZERODouble256VectorTests(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, Double256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Double256VectorTests::FIRST_NONZERO); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1726,7 +1726,7 @@ static void FIRST_NONZERODouble256VectorTestsMasked(IntFunction fa, In } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Double256VectorTests::FIRST_NONZERO); } @@ -1748,7 +1748,7 @@ static void addDouble256VectorTestsBroadcastSmokeTest(IntFunction fa, av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::add); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1765,7 +1765,7 @@ static void addDouble256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::sub); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1796,7 +1796,7 @@ static void subDouble256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::mul); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1827,7 +1827,7 @@ static void mulDouble256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::div); } @@ -1861,7 +1861,7 @@ static void divDouble256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Double256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Double256VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void ADDDouble256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::MIN); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void minDouble256VectorTestsBroadcastSmokeTest(IntFunction fa, av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::min); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2055,7 +2055,7 @@ static void MAXDouble256VectorTestsBroadcastSmokeTest(IntFunction fa, av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::MAX); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2069,7 +2069,7 @@ static void maxDouble256VectorTestsBroadcastSmokeTest(IntFunction fa, av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Double256VectorTests::max); } @@ -2121,7 +2121,7 @@ static void ADDReduceDouble256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double256VectorTests::ADDReduce, Double256VectorTests::ADDReduceAll); } static double ADDReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2165,7 +2165,7 @@ static void ADDReduceDouble256VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double256VectorTests::ADDReduceMasked, Double256VectorTests::ADDReduceAllMasked); } static double MULReduce(double[] a, int idx) { @@ -2206,7 +2206,7 @@ static void MULReduceDouble256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double256VectorTests::MULReduce, Double256VectorTests::MULReduceAll); } static double MULReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2250,7 +2250,7 @@ static void MULReduceDouble256VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double256VectorTests::MULReduceMasked, Double256VectorTests::MULReduceAllMasked); } static double MINReduce(double[] a, int idx) { @@ -2291,7 +2291,7 @@ static void MINReduceDouble256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double256VectorTests::MINReduce, Double256VectorTests::MINReduceAll); } static double MINReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2336,7 +2336,7 @@ static void MINReduceDouble256VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double256VectorTests::MINReduceMasked, Double256VectorTests::MINReduceAllMasked); } static double MAXReduce(double[] a, int idx) { @@ -2377,7 +2377,7 @@ static void MAXReduceDouble256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double256VectorTests::MAXReduce, Double256VectorTests::MAXReduceAll); } static double MAXReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2422,7 +2422,7 @@ static void MAXReduceDouble256VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double256VectorTests::MAXReduceMasked, Double256VectorTests::MAXReduceAllMasked); } @@ -2442,7 +2442,7 @@ static void withDouble256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (double)4, 0); + assertInsertArraysEquals(r, a, (double)4, 0); } static boolean testIS_DEFAULT(double a) { return bits(a)==0; @@ -3108,7 +3108,7 @@ static void blendDouble256VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpShuffleMaskProvider") @@ -3143,7 +3143,7 @@ static void RearrangeDouble256VectorTestsMaskedSmokeTest(IntFunction f av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpProvider") static void getDouble256VectorTests(IntFunction fa) { @@ -3298,7 +3298,7 @@ static void getDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::get); + assertArraysEquals(r, a, Double256VectorTests::get); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -3312,7 +3312,7 @@ static void BroadcastDouble256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3359,7 +3359,7 @@ static void sliceUnaryDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Double256VectorTests::sliceUnary); } static double[] sliceBinary(double[] a, double[] b, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3388,7 +3388,7 @@ static void sliceBinaryDouble256VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, Double256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Double256VectorTests::sliceBinary); } static double[] slice(double[] a, double[] b, int origin, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3421,7 +3421,7 @@ static void sliceDouble256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, mask, Double256VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Double256VectorTests::slice); } static double[] unsliceUnary(double[] a, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3448,7 +3448,7 @@ static void unsliceUnaryDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Double256VectorTests::unsliceUnary); } static double[] unsliceBinary(double[] a, double[] b, int origin, int part, int idx) { double[] res = new double[SPECIES.length()]; @@ -3487,7 +3487,7 @@ static void unsliceBinaryDouble256VectorTestsBinary(IntFunction fa, In } } - assertArraysEquals(a, b, r, origin, part, Double256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Double256VectorTests::unsliceBinary); } static double[] unslice(double[] a, double[] b, int origin, int part, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3543,7 +3543,7 @@ static void unsliceDouble256VectorTestsMasked(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, mask, Double256VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Double256VectorTests::unslice); } static double SIN(double a) { @@ -3566,7 +3566,7 @@ static void SINDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::SIN, Double256VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::SIN, Double256VectorTests::strictSIN); } @@ -3590,7 +3590,7 @@ static void EXPDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::EXP, Double256VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::EXP, Double256VectorTests::strictEXP); } @@ -3614,7 +3614,7 @@ static void LOG1PDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::LOG1P, Double256VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::LOG1P, Double256VectorTests::strictLOG1P); } @@ -3638,7 +3638,7 @@ static void LOGDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::LOG, Double256VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::LOG, Double256VectorTests::strictLOG); } @@ -3662,7 +3662,7 @@ static void LOG10Double256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::LOG10, Double256VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::LOG10, Double256VectorTests::strictLOG10); } @@ -3686,7 +3686,7 @@ static void EXPM1Double256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::EXPM1, Double256VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::EXPM1, Double256VectorTests::strictEXPM1); } @@ -3710,7 +3710,7 @@ static void COSDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::COS, Double256VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::COS, Double256VectorTests::strictCOS); } @@ -3734,7 +3734,7 @@ static void TANDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::TAN, Double256VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::TAN, Double256VectorTests::strictTAN); } @@ -3758,7 +3758,7 @@ static void SINHDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::SINH, Double256VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::SINH, Double256VectorTests::strictSINH); } @@ -3782,7 +3782,7 @@ static void COSHDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::COSH, Double256VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::COSH, Double256VectorTests::strictCOSH); } @@ -3806,7 +3806,7 @@ static void TANHDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::TANH, Double256VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::TANH, Double256VectorTests::strictTANH); } @@ -3830,7 +3830,7 @@ static void ASINDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::ASIN, Double256VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::ASIN, Double256VectorTests::strictASIN); } @@ -3854,7 +3854,7 @@ static void ACOSDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::ACOS, Double256VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::ACOS, Double256VectorTests::strictACOS); } @@ -3878,7 +3878,7 @@ static void ATANDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::ATAN, Double256VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::ATAN, Double256VectorTests::strictATAN); } @@ -3902,7 +3902,7 @@ static void CBRTDouble256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double256VectorTests::CBRT, Double256VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Double256VectorTests::CBRT, Double256VectorTests::strictCBRT); } @@ -3928,7 +3928,7 @@ static void HYPOTDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double256VectorTests::POW, Double256VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double256VectorTests::POW, Double256VectorTests::strictPOW); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -4037,7 +4037,7 @@ static void powDouble256VectorTestsBroadcastSmokeTest(IntFunction fa, av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double256VectorTests::pow, Double256VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double256VectorTests::pow, Double256VectorTests::strictpow); } @@ -4073,7 +4073,7 @@ static void FMADouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4096,7 +4096,7 @@ static void fmaDouble256VectorTests(IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, mask, Double256VectorTests::FMA); + assertArraysEquals(r, a, b, c, mask, Double256VectorTests::FMA); } @@ -4145,7 +4145,7 @@ static void FMADouble256VectorTestsBroadcastSmokeTest(IntFunction fa, DoubleVector bv = DoubleVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Double256VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Double256VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") @@ -4160,7 +4160,7 @@ static void FMADouble256VectorTestsAltBroadcastSmokeTest(IntFunction f DoubleVector cv = DoubleVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Double256VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Double256VectorTests::FMA); } @@ -4180,7 +4180,7 @@ static void FMADouble256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4245,7 +4245,7 @@ static void fmaDouble256VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::NEG); + assertArraysEquals(r, a, Double256VectorTests::NEG); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4312,7 +4312,7 @@ static void negDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::neg); + assertArraysEquals(r, a, Double256VectorTests::neg); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4330,7 +4330,7 @@ static void NEGMaskedDouble256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double256VectorTests::NEG); + assertArraysEquals(r, a, mask, Double256VectorTests::NEG); } static double ABS(double a) { @@ -4353,7 +4353,7 @@ static void ABSDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::ABS); + assertArraysEquals(r, a, Double256VectorTests::ABS); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4368,7 +4368,7 @@ static void absDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::abs); + assertArraysEquals(r, a, Double256VectorTests::abs); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4386,7 +4386,7 @@ static void ABSMaskedDouble256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double256VectorTests::ABS); + assertArraysEquals(r, a, mask, Double256VectorTests::ABS); } @@ -4418,7 +4418,7 @@ static void SQRTDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::SQRT); + assertArraysEquals(r, a, Double256VectorTests::SQRT); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4433,7 +4433,7 @@ static void sqrtDouble256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double256VectorTests::sqrt); + assertArraysEquals(r, a, Double256VectorTests::sqrt); } @@ -4453,7 +4453,7 @@ static void SQRTMaskedDouble256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double256VectorTests::SQRT); + assertArraysEquals(r, a, mask, Double256VectorTests::SQRT); } static double[] gather(double a[], int ix, int[] b, int iy) { @@ -4478,7 +4478,7 @@ static void gatherDouble256VectorTests(IntFunction fa, BiFunction fa, BiFunctio } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Double256VectorTests::gatherMasked); } static double[] scatter(double a[], int ix, int[] b, int iy) { @@ -4531,7 +4531,7 @@ static void scatterDouble256VectorTests(IntFunction fa, BiFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Double256VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Double256VectorTests::scatterMasked); } @@ -4611,8 +4611,8 @@ static void toIntArrayDouble256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4622,8 +4622,8 @@ static void toLongArrayDouble256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4690,7 +4690,7 @@ static void ADDReduceLongDouble256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Double256VectorTests::ADDReduceLong, Double256VectorTests::ADDReduceAllLong); } @@ -4731,7 +4731,7 @@ static void ADDReduceLongDouble256VectorTestsMasked(IntFunction fa, In ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Double256VectorTests::ADDReduceLongMasked, Double256VectorTests::ADDReduceAllLongMasked); } @@ -4743,7 +4743,7 @@ static void BroadcastLongDouble256VectorTestsSmokeTest(IntFunction fa) for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -4761,7 +4761,7 @@ static void blendDouble256VectorTestsBroadcastLongSmokeTest(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpSelectFromMaskProvider") @@ -4797,7 +4797,7 @@ static void SelectFromDouble256VectorTestsMaskedSmokeTest(IntFunction bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4874,7 +4874,7 @@ static void maskEqDouble256VectorTestsSmokeTest(IntFunction fa, IntFu var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Double256VectorTests::beq); + assertArraysEquals(r, a, b, Double256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Double512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Double512VectorLoadStoreTests.java index 50a74c78d2e86..f2b75b847e0f8 100644 --- a/test/jdk/jdk/incubator/vector/Double512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Double512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Double512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(double[] a, double[] r, boolean[] mask) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0, "at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(double[] a, double[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "doubleProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new double[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Double512VectorTests.java b/test/jdk/jdk/incubator/vector/Double512VectorTests.java index 280582e050f7a..86975ef14ee8e 100644 --- a/test/jdk/jdk/incubator/vector/Double512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Double512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { double apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { double[] apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { } catch (AssertionError e) { double[] ref = f.apply(a[i]); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { double apply(double[] a); } - static void assertReductionArraysEquals(double[] a, double[] b, double c, + static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { double apply(double[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(double[] a, double[] b, double c, boolean[] mask, + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(double[] a); } - static void assertReductionLongArraysEquals(double[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, double[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(double[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(double[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, double[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(double[] a, double[] b, double element, int index) { + static void assertInsertArraysEquals(double[] r, double[] a, double element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boo } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertBroadcastArraysEquals(double[]a, double[]r) { + static void assertBroadcastArraysEquals(double[] r, double[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBin } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, bool } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, F } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, b } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(double actual, double expected) { return true; } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, } } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, F } } - static void assertBroadcastArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { double apply(double[] a, int b); } - static void assertArraysEquals(double[] a, double[] r, FBinArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { double[] apply(double[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, FGatherScatterOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { double[] apply(double[] r, double[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(r, a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { double[] apply(double[] a, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { + static void assertArraysEquals(double[] r, double[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { } catch (AssertionError e) { double[] ref = f.apply(a, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { double[] apply(double[] a, double[] b, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, FLaneBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, F } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { double[] apply(double[] a, double[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, b } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { double[] apply(double[] a, double[] b, int origin, int part, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { double[] apply(double[] a, double[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(double[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(double[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1396,7 +1396,7 @@ static void ADDDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Double512VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1452,7 +1452,7 @@ static void addDouble512VectorTestsMasked(IntFunction fa, IntFunction< av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double512VectorTests::add); + assertArraysEquals(r, a, b, mask, Double512VectorTests::add); } static double SUB(double a, double b) { return (double)(a - b); @@ -1472,7 +1472,7 @@ static void SUBDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Double512VectorTests::SUB); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1528,7 +1528,7 @@ static void subDouble512VectorTestsMasked(IntFunction fa, IntFunction< av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double512VectorTests::sub); + assertArraysEquals(r, a, b, mask, Double512VectorTests::sub); } static double MUL(double a, double b) { return (double)(a * b); @@ -1548,7 +1548,7 @@ static void MULDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Double512VectorTests::MUL); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1604,7 +1604,7 @@ static void mulDouble512VectorTestsMasked(IntFunction fa, IntFunction< av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double512VectorTests::mul); + assertArraysEquals(r, a, b, mask, Double512VectorTests::mul); } static double DIV(double a, double b) { @@ -1625,7 +1625,7 @@ static void DIVDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Double512VectorTests::DIV); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1683,7 +1683,7 @@ static void divDouble512VectorTestsMasked(IntFunction fa, IntFunction< av.div(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Double512VectorTests::div); + assertArraysEquals(r, a, b, mask, Double512VectorTests::div); } @@ -1706,7 +1706,7 @@ static void FIRST_NONZERODouble512VectorTests(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, Double512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Double512VectorTests::FIRST_NONZERO); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1726,7 +1726,7 @@ static void FIRST_NONZERODouble512VectorTestsMasked(IntFunction fa, In } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Double512VectorTests::FIRST_NONZERO); } @@ -1748,7 +1748,7 @@ static void addDouble512VectorTestsBroadcastSmokeTest(IntFunction fa, av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::add); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1765,7 +1765,7 @@ static void addDouble512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::sub); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1796,7 +1796,7 @@ static void subDouble512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::mul); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1827,7 +1827,7 @@ static void mulDouble512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::div); } @@ -1861,7 +1861,7 @@ static void divDouble512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Double512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Double512VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void ADDDouble512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::MIN); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void minDouble512VectorTestsBroadcastSmokeTest(IntFunction fa, av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::min); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2055,7 +2055,7 @@ static void MAXDouble512VectorTestsBroadcastSmokeTest(IntFunction fa, av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::MAX); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2069,7 +2069,7 @@ static void maxDouble512VectorTestsBroadcastSmokeTest(IntFunction fa, av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Double512VectorTests::max); } @@ -2121,7 +2121,7 @@ static void ADDReduceDouble512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double512VectorTests::ADDReduce, Double512VectorTests::ADDReduceAll); } static double ADDReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2165,7 +2165,7 @@ static void ADDReduceDouble512VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double512VectorTests::ADDReduceMasked, Double512VectorTests::ADDReduceAllMasked); } static double MULReduce(double[] a, int idx) { @@ -2206,7 +2206,7 @@ static void MULReduceDouble512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double512VectorTests::MULReduce, Double512VectorTests::MULReduceAll); } static double MULReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2250,7 +2250,7 @@ static void MULReduceDouble512VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double512VectorTests::MULReduceMasked, Double512VectorTests::MULReduceAllMasked); } static double MINReduce(double[] a, int idx) { @@ -2291,7 +2291,7 @@ static void MINReduceDouble512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double512VectorTests::MINReduce, Double512VectorTests::MINReduceAll); } static double MINReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2336,7 +2336,7 @@ static void MINReduceDouble512VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double512VectorTests::MINReduceMasked, Double512VectorTests::MINReduceAllMasked); } static double MAXReduce(double[] a, int idx) { @@ -2377,7 +2377,7 @@ static void MAXReduceDouble512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double512VectorTests::MAXReduce, Double512VectorTests::MAXReduceAll); } static double MAXReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2422,7 +2422,7 @@ static void MAXReduceDouble512VectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double512VectorTests::MAXReduceMasked, Double512VectorTests::MAXReduceAllMasked); } @@ -2442,7 +2442,7 @@ static void withDouble512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (double)4, 0); + assertInsertArraysEquals(r, a, (double)4, 0); } static boolean testIS_DEFAULT(double a) { return bits(a)==0; @@ -3108,7 +3108,7 @@ static void blendDouble512VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpShuffleMaskProvider") @@ -3143,7 +3143,7 @@ static void RearrangeDouble512VectorTestsMaskedSmokeTest(IntFunction f av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpProvider") static void getDouble512VectorTests(IntFunction fa) { @@ -3298,7 +3298,7 @@ static void getDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::get); + assertArraysEquals(r, a, Double512VectorTests::get); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -3312,7 +3312,7 @@ static void BroadcastDouble512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3359,7 +3359,7 @@ static void sliceUnaryDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Double512VectorTests::sliceUnary); } static double[] sliceBinary(double[] a, double[] b, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3388,7 +3388,7 @@ static void sliceBinaryDouble512VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, Double512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Double512VectorTests::sliceBinary); } static double[] slice(double[] a, double[] b, int origin, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3421,7 +3421,7 @@ static void sliceDouble512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, mask, Double512VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Double512VectorTests::slice); } static double[] unsliceUnary(double[] a, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3448,7 +3448,7 @@ static void unsliceUnaryDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Double512VectorTests::unsliceUnary); } static double[] unsliceBinary(double[] a, double[] b, int origin, int part, int idx) { double[] res = new double[SPECIES.length()]; @@ -3487,7 +3487,7 @@ static void unsliceBinaryDouble512VectorTestsBinary(IntFunction fa, In } } - assertArraysEquals(a, b, r, origin, part, Double512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Double512VectorTests::unsliceBinary); } static double[] unslice(double[] a, double[] b, int origin, int part, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3543,7 +3543,7 @@ static void unsliceDouble512VectorTestsMasked(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, mask, Double512VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Double512VectorTests::unslice); } static double SIN(double a) { @@ -3566,7 +3566,7 @@ static void SINDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::SIN, Double512VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::SIN, Double512VectorTests::strictSIN); } @@ -3590,7 +3590,7 @@ static void EXPDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::EXP, Double512VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::EXP, Double512VectorTests::strictEXP); } @@ -3614,7 +3614,7 @@ static void LOG1PDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::LOG1P, Double512VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::LOG1P, Double512VectorTests::strictLOG1P); } @@ -3638,7 +3638,7 @@ static void LOGDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::LOG, Double512VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::LOG, Double512VectorTests::strictLOG); } @@ -3662,7 +3662,7 @@ static void LOG10Double512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::LOG10, Double512VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::LOG10, Double512VectorTests::strictLOG10); } @@ -3686,7 +3686,7 @@ static void EXPM1Double512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::EXPM1, Double512VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::EXPM1, Double512VectorTests::strictEXPM1); } @@ -3710,7 +3710,7 @@ static void COSDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::COS, Double512VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::COS, Double512VectorTests::strictCOS); } @@ -3734,7 +3734,7 @@ static void TANDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::TAN, Double512VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::TAN, Double512VectorTests::strictTAN); } @@ -3758,7 +3758,7 @@ static void SINHDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::SINH, Double512VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::SINH, Double512VectorTests::strictSINH); } @@ -3782,7 +3782,7 @@ static void COSHDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::COSH, Double512VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::COSH, Double512VectorTests::strictCOSH); } @@ -3806,7 +3806,7 @@ static void TANHDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::TANH, Double512VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::TANH, Double512VectorTests::strictTANH); } @@ -3830,7 +3830,7 @@ static void ASINDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::ASIN, Double512VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::ASIN, Double512VectorTests::strictASIN); } @@ -3854,7 +3854,7 @@ static void ACOSDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::ACOS, Double512VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::ACOS, Double512VectorTests::strictACOS); } @@ -3878,7 +3878,7 @@ static void ATANDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::ATAN, Double512VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::ATAN, Double512VectorTests::strictATAN); } @@ -3902,7 +3902,7 @@ static void CBRTDouble512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double512VectorTests::CBRT, Double512VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Double512VectorTests::CBRT, Double512VectorTests::strictCBRT); } @@ -3928,7 +3928,7 @@ static void HYPOTDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double512VectorTests::POW, Double512VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double512VectorTests::POW, Double512VectorTests::strictPOW); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -4037,7 +4037,7 @@ static void powDouble512VectorTestsBroadcastSmokeTest(IntFunction fa, av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double512VectorTests::pow, Double512VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double512VectorTests::pow, Double512VectorTests::strictpow); } @@ -4073,7 +4073,7 @@ static void FMADouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4096,7 +4096,7 @@ static void fmaDouble512VectorTests(IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, mask, Double512VectorTests::FMA); + assertArraysEquals(r, a, b, c, mask, Double512VectorTests::FMA); } @@ -4145,7 +4145,7 @@ static void FMADouble512VectorTestsBroadcastSmokeTest(IntFunction fa, DoubleVector bv = DoubleVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Double512VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Double512VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") @@ -4160,7 +4160,7 @@ static void FMADouble512VectorTestsAltBroadcastSmokeTest(IntFunction f DoubleVector cv = DoubleVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Double512VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Double512VectorTests::FMA); } @@ -4180,7 +4180,7 @@ static void FMADouble512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4245,7 +4245,7 @@ static void fmaDouble512VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::NEG); + assertArraysEquals(r, a, Double512VectorTests::NEG); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4312,7 +4312,7 @@ static void negDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::neg); + assertArraysEquals(r, a, Double512VectorTests::neg); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4330,7 +4330,7 @@ static void NEGMaskedDouble512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double512VectorTests::NEG); + assertArraysEquals(r, a, mask, Double512VectorTests::NEG); } static double ABS(double a) { @@ -4353,7 +4353,7 @@ static void ABSDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::ABS); + assertArraysEquals(r, a, Double512VectorTests::ABS); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4368,7 +4368,7 @@ static void absDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::abs); + assertArraysEquals(r, a, Double512VectorTests::abs); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4386,7 +4386,7 @@ static void ABSMaskedDouble512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double512VectorTests::ABS); + assertArraysEquals(r, a, mask, Double512VectorTests::ABS); } @@ -4418,7 +4418,7 @@ static void SQRTDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::SQRT); + assertArraysEquals(r, a, Double512VectorTests::SQRT); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4433,7 +4433,7 @@ static void sqrtDouble512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double512VectorTests::sqrt); + assertArraysEquals(r, a, Double512VectorTests::sqrt); } @@ -4453,7 +4453,7 @@ static void SQRTMaskedDouble512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double512VectorTests::SQRT); + assertArraysEquals(r, a, mask, Double512VectorTests::SQRT); } static double[] gather(double a[], int ix, int[] b, int iy) { @@ -4478,7 +4478,7 @@ static void gatherDouble512VectorTests(IntFunction fa, BiFunction fa, BiFunctio } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Double512VectorTests::gatherMasked); } static double[] scatter(double a[], int ix, int[] b, int iy) { @@ -4531,7 +4531,7 @@ static void scatterDouble512VectorTests(IntFunction fa, BiFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Double512VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Double512VectorTests::scatterMasked); } @@ -4611,8 +4611,8 @@ static void toIntArrayDouble512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4622,8 +4622,8 @@ static void toLongArrayDouble512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4690,7 +4690,7 @@ static void ADDReduceLongDouble512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Double512VectorTests::ADDReduceLong, Double512VectorTests::ADDReduceAllLong); } @@ -4731,7 +4731,7 @@ static void ADDReduceLongDouble512VectorTestsMasked(IntFunction fa, In ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Double512VectorTests::ADDReduceLongMasked, Double512VectorTests::ADDReduceAllLongMasked); } @@ -4743,7 +4743,7 @@ static void BroadcastLongDouble512VectorTestsSmokeTest(IntFunction fa) for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -4761,7 +4761,7 @@ static void blendDouble512VectorTestsBroadcastLongSmokeTest(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpSelectFromMaskProvider") @@ -4797,7 +4797,7 @@ static void SelectFromDouble512VectorTestsMaskedSmokeTest(IntFunction bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4874,7 +4874,7 @@ static void maskEqDouble512VectorTestsSmokeTest(IntFunction fa, IntFu var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Double512VectorTests::beq); + assertArraysEquals(r, a, b, Double512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Double64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Double64VectorLoadStoreTests.java index 50804258349ba..2716064a7815c 100644 --- a/test/jdk/jdk/incubator/vector/Double64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Double64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Double64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(double[] a, double[] r, boolean[] mask) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0, "at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(double[] a, double[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "doubleProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new double[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Double64VectorTests.java b/test/jdk/jdk/incubator/vector/Double64VectorTests.java index 91cb65bf84bb1..a4c21b5ff9862 100644 --- a/test/jdk/jdk/incubator/vector/Double64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Double64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { double apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { double[] apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { } catch (AssertionError e) { double[] ref = f.apply(a[i]); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { double apply(double[] a); } - static void assertReductionArraysEquals(double[] a, double[] b, double c, + static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { double apply(double[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(double[] a, double[] b, double c, boolean[] mask, + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(double[] a); } - static void assertReductionLongArraysEquals(double[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, double[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(double[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(double[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, double[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(double[] a, double[] b, double element, int index) { + static void assertInsertArraysEquals(double[] r, double[] a, double element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boo } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertBroadcastArraysEquals(double[]a, double[]r) { + static void assertBroadcastArraysEquals(double[] r, double[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBin } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, bool } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, F } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, b } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(double actual, double expected) { return true; } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, } } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, F } } - static void assertBroadcastArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { double apply(double[] a, int b); } - static void assertArraysEquals(double[] a, double[] r, FBinArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { double[] apply(double[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, FGatherScatterOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { double[] apply(double[] r, double[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(r, a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { double[] apply(double[] a, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { + static void assertArraysEquals(double[] r, double[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { } catch (AssertionError e) { double[] ref = f.apply(a, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { double[] apply(double[] a, double[] b, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, FLaneBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, F } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { double[] apply(double[] a, double[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, b } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { double[] apply(double[] a, double[] b, int origin, int part, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { double[] apply(double[] a, double[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(double[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(double[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1396,7 +1396,7 @@ static void ADDDouble64VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, Double64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Double64VectorTests::FIRST_NONZERO); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1726,7 +1726,7 @@ static void FIRST_NONZERODouble64VectorTestsMasked(IntFunction fa, Int } } - assertArraysEquals(a, b, r, mask, Double64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Double64VectorTests::FIRST_NONZERO); } @@ -1748,7 +1748,7 @@ static void addDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::add); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1765,7 +1765,7 @@ static void addDouble64VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Double64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Double64VectorTests::add); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -1779,7 +1779,7 @@ static void subDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::sub); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1796,7 +1796,7 @@ static void subDouble64VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Double64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Double64VectorTests::sub); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -1810,7 +1810,7 @@ static void mulDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::mul); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1827,7 +1827,7 @@ static void mulDouble64VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Double64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Double64VectorTests::mul); } @@ -1842,7 +1842,7 @@ static void divDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::div); } @@ -1861,7 +1861,7 @@ static void divDouble64VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Double64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Double64VectorTests::div); } @@ -1884,7 +1884,7 @@ static void ADDDouble64VectorTestsBroadcastLongSmokeTest(IntFunction f av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Double64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Double64VectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void ADDDouble64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, I av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::MIN); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void minDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::min); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2055,7 +2055,7 @@ static void MAXDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::MAX); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2069,7 +2069,7 @@ static void maxDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Double64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Double64VectorTests::max); } @@ -2121,7 +2121,7 @@ static void ADDReduceDouble64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double64VectorTests::ADDReduce, Double64VectorTests::ADDReduceAll); } static double ADDReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2165,7 +2165,7 @@ static void ADDReduceDouble64VectorTestsMasked(IntFunction fa, IntFunc } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double64VectorTests::ADDReduceMasked, Double64VectorTests::ADDReduceAllMasked); } static double MULReduce(double[] a, int idx) { @@ -2206,7 +2206,7 @@ static void MULReduceDouble64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double64VectorTests::MULReduce, Double64VectorTests::MULReduceAll); } static double MULReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2250,7 +2250,7 @@ static void MULReduceDouble64VectorTestsMasked(IntFunction fa, IntFunc } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double64VectorTests::MULReduceMasked, Double64VectorTests::MULReduceAllMasked); } static double MINReduce(double[] a, int idx) { @@ -2291,7 +2291,7 @@ static void MINReduceDouble64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double64VectorTests::MINReduce, Double64VectorTests::MINReduceAll); } static double MINReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2336,7 +2336,7 @@ static void MINReduceDouble64VectorTestsMasked(IntFunction fa, IntFunc } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double64VectorTests::MINReduceMasked, Double64VectorTests::MINReduceAllMasked); } static double MAXReduce(double[] a, int idx) { @@ -2377,7 +2377,7 @@ static void MAXReduceDouble64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Double64VectorTests::MAXReduce, Double64VectorTests::MAXReduceAll); } static double MAXReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2422,7 +2422,7 @@ static void MAXReduceDouble64VectorTestsMasked(IntFunction fa, IntFunc } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Double64VectorTests::MAXReduceMasked, Double64VectorTests::MAXReduceAllMasked); } @@ -2442,7 +2442,7 @@ static void withDouble64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (double)4, 0); + assertInsertArraysEquals(r, a, (double)4, 0); } static boolean testIS_DEFAULT(double a) { return bits(a)==0; @@ -3108,7 +3108,7 @@ static void blendDouble64VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpShuffleMaskProvider") @@ -3143,7 +3143,7 @@ static void RearrangeDouble64VectorTestsMaskedSmokeTest(IntFunction fa av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpProvider") static void getDouble64VectorTests(IntFunction fa) { @@ -3298,7 +3298,7 @@ static void getDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::get); + assertArraysEquals(r, a, Double64VectorTests::get); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -3312,7 +3312,7 @@ static void BroadcastDouble64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3359,7 +3359,7 @@ static void sliceUnaryDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Double64VectorTests::sliceUnary); } static double[] sliceBinary(double[] a, double[] b, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3388,7 +3388,7 @@ static void sliceBinaryDouble64VectorTestsBinary(IntFunction fa, IntFu } } - assertArraysEquals(a, b, r, origin, Double64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Double64VectorTests::sliceBinary); } static double[] slice(double[] a, double[] b, int origin, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3421,7 +3421,7 @@ static void sliceDouble64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, origin, mask, Double64VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Double64VectorTests::slice); } static double[] unsliceUnary(double[] a, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3448,7 +3448,7 @@ static void unsliceUnaryDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Double64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Double64VectorTests::unsliceUnary); } static double[] unsliceBinary(double[] a, double[] b, int origin, int part, int idx) { double[] res = new double[SPECIES.length()]; @@ -3487,7 +3487,7 @@ static void unsliceBinaryDouble64VectorTestsBinary(IntFunction fa, Int } } - assertArraysEquals(a, b, r, origin, part, Double64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Double64VectorTests::unsliceBinary); } static double[] unslice(double[] a, double[] b, int origin, int part, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3543,7 +3543,7 @@ static void unsliceDouble64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, origin, part, mask, Double64VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Double64VectorTests::unslice); } static double SIN(double a) { @@ -3566,7 +3566,7 @@ static void SINDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::SIN, Double64VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::SIN, Double64VectorTests::strictSIN); } @@ -3590,7 +3590,7 @@ static void EXPDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::EXP, Double64VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::EXP, Double64VectorTests::strictEXP); } @@ -3614,7 +3614,7 @@ static void LOG1PDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::LOG1P, Double64VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::LOG1P, Double64VectorTests::strictLOG1P); } @@ -3638,7 +3638,7 @@ static void LOGDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::LOG, Double64VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::LOG, Double64VectorTests::strictLOG); } @@ -3662,7 +3662,7 @@ static void LOG10Double64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::LOG10, Double64VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::LOG10, Double64VectorTests::strictLOG10); } @@ -3686,7 +3686,7 @@ static void EXPM1Double64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::EXPM1, Double64VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::EXPM1, Double64VectorTests::strictEXPM1); } @@ -3710,7 +3710,7 @@ static void COSDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::COS, Double64VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::COS, Double64VectorTests::strictCOS); } @@ -3734,7 +3734,7 @@ static void TANDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::TAN, Double64VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::TAN, Double64VectorTests::strictTAN); } @@ -3758,7 +3758,7 @@ static void SINHDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::SINH, Double64VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::SINH, Double64VectorTests::strictSINH); } @@ -3782,7 +3782,7 @@ static void COSHDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::COSH, Double64VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::COSH, Double64VectorTests::strictCOSH); } @@ -3806,7 +3806,7 @@ static void TANHDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::TANH, Double64VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::TANH, Double64VectorTests::strictTANH); } @@ -3830,7 +3830,7 @@ static void ASINDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::ASIN, Double64VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::ASIN, Double64VectorTests::strictASIN); } @@ -3854,7 +3854,7 @@ static void ACOSDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::ACOS, Double64VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::ACOS, Double64VectorTests::strictACOS); } @@ -3878,7 +3878,7 @@ static void ATANDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::ATAN, Double64VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::ATAN, Double64VectorTests::strictATAN); } @@ -3902,7 +3902,7 @@ static void CBRTDouble64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Double64VectorTests::CBRT, Double64VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Double64VectorTests::CBRT, Double64VectorTests::strictCBRT); } @@ -3928,7 +3928,7 @@ static void HYPOTDouble64VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, I av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double64VectorTests::POW, Double64VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double64VectorTests::POW, Double64VectorTests::strictPOW); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -4037,7 +4037,7 @@ static void powDouble64VectorTestsBroadcastSmokeTest(IntFunction fa, I av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Double64VectorTests::pow, Double64VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Double64VectorTests::pow, Double64VectorTests::strictpow); } @@ -4073,7 +4073,7 @@ static void FMADouble64VectorTests(IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4096,7 +4096,7 @@ static void fmaDouble64VectorTests(IntFunction fa, IntFunction fa, IntFunction fa, I DoubleVector bv = DoubleVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Double64VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Double64VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") @@ -4160,7 +4160,7 @@ static void FMADouble64VectorTestsAltBroadcastSmokeTest(IntFunction fa DoubleVector cv = DoubleVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Double64VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Double64VectorTests::FMA); } @@ -4180,7 +4180,7 @@ static void FMADouble64VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, Double64VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, Double64VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpMaskProvider") @@ -4199,7 +4199,7 @@ static void FMADouble64VectorTestsAltBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Double64VectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, Double64VectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") static void fmaDouble64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4245,7 +4245,7 @@ static void fmaDouble64VectorTestsDoubleBroadcastSmokeTest(IntFunction av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Double64VectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, Double64VectorTests::fma); } @@ -4271,7 +4271,7 @@ static void FMADouble64VectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::NEG); + assertArraysEquals(r, a, Double64VectorTests::NEG); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4312,7 +4312,7 @@ static void negDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::neg); + assertArraysEquals(r, a, Double64VectorTests::neg); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4330,7 +4330,7 @@ static void NEGMaskedDouble64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double64VectorTests::NEG); + assertArraysEquals(r, a, mask, Double64VectorTests::NEG); } static double ABS(double a) { @@ -4353,7 +4353,7 @@ static void ABSDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::ABS); + assertArraysEquals(r, a, Double64VectorTests::ABS); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4368,7 +4368,7 @@ static void absDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::abs); + assertArraysEquals(r, a, Double64VectorTests::abs); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4386,7 +4386,7 @@ static void ABSMaskedDouble64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double64VectorTests::ABS); + assertArraysEquals(r, a, mask, Double64VectorTests::ABS); } @@ -4418,7 +4418,7 @@ static void SQRTDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::SQRT); + assertArraysEquals(r, a, Double64VectorTests::SQRT); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4433,7 +4433,7 @@ static void sqrtDouble64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Double64VectorTests::sqrt); + assertArraysEquals(r, a, Double64VectorTests::sqrt); } @@ -4453,7 +4453,7 @@ static void SQRTMaskedDouble64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Double64VectorTests::SQRT); + assertArraysEquals(r, a, mask, Double64VectorTests::SQRT); } static double[] gather(double a[], int ix, int[] b, int iy) { @@ -4478,7 +4478,7 @@ static void gatherDouble64VectorTests(IntFunction fa, BiFunction fa, BiFunction } } - assertArraysEquals(a, b, r, mask, Double64VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Double64VectorTests::gatherMasked); } static double[] scatter(double a[], int ix, int[] b, int iy) { @@ -4531,7 +4531,7 @@ static void scatterDouble64VectorTests(IntFunction fa, BiFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, mask, Double64VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Double64VectorTests::scatterMasked); } @@ -4611,8 +4611,8 @@ static void toIntArrayDouble64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4622,8 +4622,8 @@ static void toLongArrayDouble64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4690,7 +4690,7 @@ static void ADDReduceLongDouble64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Double64VectorTests::ADDReduceLong, Double64VectorTests::ADDReduceAllLong); } @@ -4731,7 +4731,7 @@ static void ADDReduceLongDouble64VectorTestsMasked(IntFunction fa, Int ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Double64VectorTests::ADDReduceLongMasked, Double64VectorTests::ADDReduceAllLongMasked); } @@ -4743,7 +4743,7 @@ static void BroadcastLongDouble64VectorTestsSmokeTest(IntFunction fa) for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -4761,7 +4761,7 @@ static void blendDouble64VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Double64VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Double64VectorTests::blend); } @@ -4778,7 +4778,7 @@ static void SelectFromDouble64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpSelectFromMaskProvider") @@ -4797,7 +4797,7 @@ static void SelectFromDouble64VectorTestsMaskedSmokeTest(IntFunction f bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4874,7 +4874,7 @@ static void maskEqDouble64VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Double64VectorTests::beq); + assertArraysEquals(r, a, b, Double64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java index bfe58bb29a0c5..0e0a66f2bd74c 100644 --- a/test/jdk/jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -67,47 +67,25 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(double[] a, double[] r, boolean[] mask) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (double) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (double) 0, "at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(double[] a, double[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (double) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -410,7 +388,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "doubleProviderForIOOBE") @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new double[a.length]; @@ -492,7 +470,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleMaskProviderForIOOBE") @@ -565,7 +543,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -589,7 +567,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -676,7 +654,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -691,7 +669,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -807,7 +785,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "doubleByteProviderForIOOBE") @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -899,7 +877,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "doubleByteMaskProviderForIOOBE") @@ -976,7 +954,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -987,7 +965,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java b/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java index 55a69ab1416c2..dbe35d51b2219 100644 --- a/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { double apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { double[] apply(double a); } - static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(double[] a, double[] r, FUnArrayOp f) { } catch (AssertionError e) { double[] ref = f.apply(a[i]); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(double[] a, double[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(double[] r, double[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { double apply(double[] a); } - static void assertReductionArraysEquals(double[] a, double[] b, double c, + static void assertReductionArraysEquals(double[] r, double rc, double[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { double apply(double[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(double[] a, double[] b, double c, boolean[] mask, + static void assertReductionArraysEqualsMasked(double[] r, double rc, double[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -167,17 +167,17 @@ interface FReductionAllOpLong { long apply(double[] a); } - static void assertReductionLongArraysEquals(double[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, double[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -189,17 +189,17 @@ interface FReductionAllMaskedOpLong { long apply(double[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(double[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, double[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -207,37 +207,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(double[] a, double[] b, double element, int index) { + static void assertInsertArraysEquals(double[] r, double[] a, double element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -251,7 +251,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, int } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -265,7 +265,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(double[] r, double[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -285,7 +285,7 @@ static void assertRearrangeArraysEquals(double[] a, double[] r, int[] order, boo } } - static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(double[] r, double[] a, double[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -305,7 +305,7 @@ static void assertSelectFromArraysEquals(double[] a, double[] r, double[] order, } } - static void assertBroadcastArraysEquals(double[]a, double[]r) { + static void assertBroadcastArraysEquals(double[] r, double[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -334,7 +334,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -345,7 +345,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -357,7 +357,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, FBin } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -369,11 +369,11 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -384,11 +384,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -402,11 +402,11 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] r, bool } } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -420,7 +420,7 @@ static void assertBroadcastLongArraysEquals(double[] a, double[] b, double[] r, } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -434,11 +434,11 @@ static void assertShiftArraysEquals(double[] a, double[] b, double[] r, FBinOp f } } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(double[] a, double[] b, double[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(double[] r, double[] a, double[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -464,7 +464,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -475,11 +475,11 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, F } } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -491,7 +491,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] c, double[] r, b } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -504,7 +504,7 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,12 +517,12 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -538,12 +538,12 @@ static void assertBroadcastArraysEquals(double[] a, double[] b, double[] c, doub } } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ static void assertAltBroadcastArraysEquals(double[] a, double[] b, double[] c, d } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,12 +574,12 @@ static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c } } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(double[] a, double[] b, double[] c, double[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(double[] r, double[] a, double[] b, double[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -618,7 +618,7 @@ static boolean isWithin1Ulp(double actual, double expected) { return true; } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -632,7 +632,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] r, FUnOp mathf, } } - static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -646,7 +646,7 @@ static void assertArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, F } } - static void assertBroadcastArraysEqualsWithinOneUlp(double[] a, double[] b, double[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(double[] r, double[] a, double[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -676,7 +676,7 @@ interface FBinArrayOp { double apply(double[] a, int b); } - static void assertArraysEquals(double[] a, double[] r, FBinArrayOp f) { + static void assertArraysEquals(double[] r, double[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -691,7 +691,7 @@ interface FGatherScatterOp { double[] apply(double[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, FGatherScatterOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -718,7 +718,7 @@ interface FScatterMaskedOp { double[] apply(double[] r, double[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -728,7 +728,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -739,7 +739,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } } - static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(double[] r, double[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -749,7 +749,7 @@ static void assertArraysEquals(double[] a, int[] b, double[] r, boolean[] mask, } catch (AssertionError e) { double[] ref = f.apply(r, a, i, mask, b, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -766,7 +766,7 @@ interface FLaneOp { double[] apply(double[] a, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { + static void assertArraysEquals(double[] r, double[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -776,7 +776,7 @@ static void assertArraysEquals(double[] a, double[] r, int origin, FLaneOp f) { } catch (AssertionError e) { double[] ref = f.apply(a, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -786,7 +786,7 @@ interface FLaneBop { double[] apply(double[] a, double[] b, int origin, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, FLaneBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -796,7 +796,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, F } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -807,7 +807,7 @@ interface FLaneMaskedBop { double[] apply(double[] a, double[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -817,7 +817,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, b } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -828,7 +828,7 @@ interface FLanePartBop { double[] apply(double[] a, double[] b, int origin, int part, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -838,7 +838,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -850,7 +850,7 @@ interface FLanePartMaskedBop { double[] apply(double[] a, double[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(double[] r, double[] a, double[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -860,7 +860,7 @@ static void assertArraysEquals(double[] a, double[] b, double[] r, int origin, i } catch (AssertionError e) { double[] ref = f.apply(a, b, origin, part, mask, i); double[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -902,7 +902,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(double[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -948,7 +948,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(double[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, double[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1401,7 +1401,7 @@ static void ADDDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::ADD); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1457,7 +1457,7 @@ static void addDoubleMaxVectorTestsMasked(IntFunction fa, IntFunction< av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::add); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::add); } static double SUB(double a, double b) { return (double)(a - b); @@ -1477,7 +1477,7 @@ static void SUBDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::SUB); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::SUB); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1533,7 +1533,7 @@ static void subDoubleMaxVectorTestsMasked(IntFunction fa, IntFunction< av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::sub); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::sub); } static double MUL(double a, double b) { return (double)(a * b); @@ -1553,7 +1553,7 @@ static void MULDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::MUL); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::MUL); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1609,7 +1609,7 @@ static void mulDoubleMaxVectorTestsMasked(IntFunction fa, IntFunction< av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::mul); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::mul); } static double DIV(double a, double b) { @@ -1630,7 +1630,7 @@ static void DIVDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::DIV); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::DIV); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1688,7 +1688,7 @@ static void divDoubleMaxVectorTestsMasked(IntFunction fa, IntFunction< av.div(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::div); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::div); } @@ -1711,7 +1711,7 @@ static void FIRST_NONZERODoubleMaxVectorTests(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, DoubleMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, DoubleMaxVectorTests::FIRST_NONZERO); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1731,7 +1731,7 @@ static void FIRST_NONZERODoubleMaxVectorTestsMasked(IntFunction fa, In } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::FIRST_NONZERO); } @@ -1753,7 +1753,7 @@ static void addDoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::add); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1770,7 +1770,7 @@ static void addDoubleMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::sub); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1801,7 +1801,7 @@ static void subDoubleMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::mul); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1832,7 +1832,7 @@ static void mulDoubleMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::div); } @@ -1866,7 +1866,7 @@ static void divDoubleMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, DoubleMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, DoubleMaxVectorTests::ADD); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -1906,7 +1906,7 @@ static void ADDDoubleMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::MIN); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2046,7 +2046,7 @@ static void minDoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::min); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2060,7 +2060,7 @@ static void MAXDoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::MAX); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -2074,7 +2074,7 @@ static void maxDoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, DoubleMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, DoubleMaxVectorTests::max); } @@ -2126,7 +2126,7 @@ static void ADDReduceDoubleMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, DoubleMaxVectorTests::ADDReduce, DoubleMaxVectorTests::ADDReduceAll); } static double ADDReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2170,7 +2170,7 @@ static void ADDReduceDoubleMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, DoubleMaxVectorTests::ADDReduceMasked, DoubleMaxVectorTests::ADDReduceAllMasked); } static double MULReduce(double[] a, int idx) { @@ -2211,7 +2211,7 @@ static void MULReduceDoubleMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, DoubleMaxVectorTests::MULReduce, DoubleMaxVectorTests::MULReduceAll); } static double MULReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2255,7 +2255,7 @@ static void MULReduceDoubleMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, DoubleMaxVectorTests::MULReduceMasked, DoubleMaxVectorTests::MULReduceAllMasked); } static double MINReduce(double[] a, int idx) { @@ -2296,7 +2296,7 @@ static void MINReduceDoubleMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, DoubleMaxVectorTests::MINReduce, DoubleMaxVectorTests::MINReduceAll); } static double MINReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2341,7 +2341,7 @@ static void MINReduceDoubleMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, DoubleMaxVectorTests::MINReduceMasked, DoubleMaxVectorTests::MINReduceAllMasked); } static double MAXReduce(double[] a, int idx) { @@ -2382,7 +2382,7 @@ static void MAXReduceDoubleMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, DoubleMaxVectorTests::MAXReduce, DoubleMaxVectorTests::MAXReduceAll); } static double MAXReduceMasked(double[] a, int idx, boolean[] mask) { @@ -2427,7 +2427,7 @@ static void MAXReduceDoubleMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, DoubleMaxVectorTests::MAXReduceMasked, DoubleMaxVectorTests::MAXReduceAllMasked); } @@ -2447,7 +2447,7 @@ static void withDoubleMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (double)4, 0); + assertInsertArraysEquals(r, a, (double)4, 0); } static boolean testIS_DEFAULT(double a) { return bits(a)==0; @@ -3113,7 +3113,7 @@ static void blendDoubleMaxVectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpShuffleMaskProvider") @@ -3148,7 +3148,7 @@ static void RearrangeDoubleMaxVectorTestsMaskedSmokeTest(IntFunction f av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpProvider") static void getDoubleMaxVectorTests(IntFunction fa) { @@ -3303,7 +3303,7 @@ static void getDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::get); + assertArraysEquals(r, a, DoubleMaxVectorTests::get); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -3317,7 +3317,7 @@ static void BroadcastDoubleMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3364,7 +3364,7 @@ static void sliceUnaryDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, DoubleMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, DoubleMaxVectorTests::sliceUnary); } static double[] sliceBinary(double[] a, double[] b, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3393,7 +3393,7 @@ static void sliceBinaryDoubleMaxVectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, DoubleMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, DoubleMaxVectorTests::sliceBinary); } static double[] slice(double[] a, double[] b, int origin, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3426,7 +3426,7 @@ static void sliceDoubleMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, mask, DoubleMaxVectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, DoubleMaxVectorTests::slice); } static double[] unsliceUnary(double[] a, int origin, int idx) { double[] res = new double[SPECIES.length()]; @@ -3453,7 +3453,7 @@ static void unsliceUnaryDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, DoubleMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, DoubleMaxVectorTests::unsliceUnary); } static double[] unsliceBinary(double[] a, double[] b, int origin, int part, int idx) { double[] res = new double[SPECIES.length()]; @@ -3492,7 +3492,7 @@ static void unsliceBinaryDoubleMaxVectorTestsBinary(IntFunction fa, In } } - assertArraysEquals(a, b, r, origin, part, DoubleMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, DoubleMaxVectorTests::unsliceBinary); } static double[] unslice(double[] a, double[] b, int origin, int part, boolean[] mask, int idx) { double[] res = new double[SPECIES.length()]; @@ -3548,7 +3548,7 @@ static void unsliceDoubleMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, mask, DoubleMaxVectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, DoubleMaxVectorTests::unslice); } static double SIN(double a) { @@ -3571,7 +3571,7 @@ static void SINDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::SIN, DoubleMaxVectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::SIN, DoubleMaxVectorTests::strictSIN); } @@ -3595,7 +3595,7 @@ static void EXPDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::EXP, DoubleMaxVectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::EXP, DoubleMaxVectorTests::strictEXP); } @@ -3619,7 +3619,7 @@ static void LOG1PDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::LOG1P, DoubleMaxVectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::LOG1P, DoubleMaxVectorTests::strictLOG1P); } @@ -3643,7 +3643,7 @@ static void LOGDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::LOG, DoubleMaxVectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::LOG, DoubleMaxVectorTests::strictLOG); } @@ -3667,7 +3667,7 @@ static void LOG10DoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::LOG10, DoubleMaxVectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::LOG10, DoubleMaxVectorTests::strictLOG10); } @@ -3691,7 +3691,7 @@ static void EXPM1DoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::EXPM1, DoubleMaxVectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::EXPM1, DoubleMaxVectorTests::strictEXPM1); } @@ -3715,7 +3715,7 @@ static void COSDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::COS, DoubleMaxVectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::COS, DoubleMaxVectorTests::strictCOS); } @@ -3739,7 +3739,7 @@ static void TANDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::TAN, DoubleMaxVectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::TAN, DoubleMaxVectorTests::strictTAN); } @@ -3763,7 +3763,7 @@ static void SINHDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::SINH, DoubleMaxVectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::SINH, DoubleMaxVectorTests::strictSINH); } @@ -3787,7 +3787,7 @@ static void COSHDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::COSH, DoubleMaxVectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::COSH, DoubleMaxVectorTests::strictCOSH); } @@ -3811,7 +3811,7 @@ static void TANHDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::TANH, DoubleMaxVectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::TANH, DoubleMaxVectorTests::strictTANH); } @@ -3835,7 +3835,7 @@ static void ASINDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::ASIN, DoubleMaxVectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::ASIN, DoubleMaxVectorTests::strictASIN); } @@ -3859,7 +3859,7 @@ static void ACOSDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::ACOS, DoubleMaxVectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::ACOS, DoubleMaxVectorTests::strictACOS); } @@ -3883,7 +3883,7 @@ static void ATANDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::ATAN, DoubleMaxVectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::ATAN, DoubleMaxVectorTests::strictATAN); } @@ -3907,7 +3907,7 @@ static void CBRTDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, DoubleMaxVectorTests::CBRT, DoubleMaxVectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, DoubleMaxVectorTests::CBRT, DoubleMaxVectorTests::strictCBRT); } @@ -3933,7 +3933,7 @@ static void HYPOTDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, DoubleMaxVectorTests::POW, DoubleMaxVectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, DoubleMaxVectorTests::POW, DoubleMaxVectorTests::strictPOW); } @Test(dataProvider = "doubleBinaryOpProvider") @@ -4042,7 +4042,7 @@ static void powDoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, DoubleMaxVectorTests::pow, DoubleMaxVectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, DoubleMaxVectorTests::pow, DoubleMaxVectorTests::strictpow); } @@ -4078,7 +4078,7 @@ static void FMADoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4101,7 +4101,7 @@ static void fmaDoubleMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, mask, DoubleMaxVectorTests::FMA); + assertArraysEquals(r, a, b, c, mask, DoubleMaxVectorTests::FMA); } @@ -4150,7 +4150,7 @@ static void FMADoubleMaxVectorTestsBroadcastSmokeTest(IntFunction fa, DoubleVector bv = DoubleVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, DoubleMaxVectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, DoubleMaxVectorTests::FMA); } @Test(dataProvider = "doubleTernaryOpProvider") @@ -4165,7 +4165,7 @@ static void FMADoubleMaxVectorTestsAltBroadcastSmokeTest(IntFunction f DoubleVector cv = DoubleVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, DoubleMaxVectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, DoubleMaxVectorTests::FMA); } @@ -4185,7 +4185,7 @@ static void FMADoubleMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4250,7 +4250,7 @@ static void fmaDoubleMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::NEG); + assertArraysEquals(r, a, DoubleMaxVectorTests::NEG); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4317,7 +4317,7 @@ static void negDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::neg); + assertArraysEquals(r, a, DoubleMaxVectorTests::neg); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4335,7 +4335,7 @@ static void NEGMaskedDoubleMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, DoubleMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, DoubleMaxVectorTests::NEG); } static double ABS(double a) { @@ -4358,7 +4358,7 @@ static void ABSDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::ABS); + assertArraysEquals(r, a, DoubleMaxVectorTests::ABS); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4373,7 +4373,7 @@ static void absDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::abs); + assertArraysEquals(r, a, DoubleMaxVectorTests::abs); } @Test(dataProvider = "doubleUnaryOpMaskProvider") @@ -4391,7 +4391,7 @@ static void ABSMaskedDoubleMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, DoubleMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, DoubleMaxVectorTests::ABS); } @@ -4423,7 +4423,7 @@ static void SQRTDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::SQRT); + assertArraysEquals(r, a, DoubleMaxVectorTests::SQRT); } @Test(dataProvider = "doubleUnaryOpProvider") @@ -4438,7 +4438,7 @@ static void sqrtDoubleMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, DoubleMaxVectorTests::sqrt); + assertArraysEquals(r, a, DoubleMaxVectorTests::sqrt); } @@ -4458,7 +4458,7 @@ static void SQRTMaskedDoubleMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, DoubleMaxVectorTests::SQRT); + assertArraysEquals(r, a, mask, DoubleMaxVectorTests::SQRT); } static double[] gather(double a[], int ix, int[] b, int iy) { @@ -4483,7 +4483,7 @@ static void gatherDoubleMaxVectorTests(IntFunction fa, BiFunction fa, BiFunctio } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::gatherMasked); } static double[] scatter(double a[], int ix, int[] b, int iy) { @@ -4536,7 +4536,7 @@ static void scatterDoubleMaxVectorTests(IntFunction fa, BiFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, DoubleMaxVectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, DoubleMaxVectorTests::scatterMasked); } @@ -4616,8 +4616,8 @@ static void toIntArrayDoubleMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4627,8 +4627,8 @@ static void toLongArrayDoubleMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector av = DoubleVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4695,7 +4695,7 @@ static void ADDReduceLongDoubleMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, DoubleMaxVectorTests::ADDReduceLong, DoubleMaxVectorTests::ADDReduceAllLong); } @@ -4736,7 +4736,7 @@ static void ADDReduceLongDoubleMaxVectorTestsMasked(IntFunction fa, In ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, DoubleMaxVectorTests::ADDReduceLongMasked, DoubleMaxVectorTests::ADDReduceAllLongMasked); } @@ -4748,7 +4748,7 @@ static void BroadcastLongDoubleMaxVectorTestsSmokeTest(IntFunction fa) for (int i = 0; i < a.length; i += SPECIES.length()) { DoubleVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "doubleBinaryOpMaskProvider") @@ -4766,7 +4766,7 @@ static void blendDoubleMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "doubleUnaryOpSelectFromMaskProvider") @@ -4802,7 +4802,7 @@ static void SelectFromDoubleMaxVectorTestsMaskedSmokeTest(IntFunction bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4879,7 +4879,7 @@ static void maskEqDoubleMaxVectorTestsSmokeTest(IntFunction fa, IntFu var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, DoubleMaxVectorTests::beq); + assertArraysEquals(r, a, b, DoubleMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Float128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Float128VectorLoadStoreTests.java index 714cc88b8814e..c8b847b3fbe67 100644 --- a/test/jdk/jdk/incubator/vector/Float128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Float128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Float128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(float[] a, float[] r, boolean[] mask) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0, "at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(float[] a, float[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "floatProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new float[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Float128VectorTests.java b/test/jdk/jdk/incubator/vector/Float128VectorTests.java index 2ae24435f9d22..3f2e01c0343d6 100644 --- a/test/jdk/jdk/incubator/vector/Float128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Float128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { float apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { float[] apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { } catch (AssertionError e) { float[] ref = f.apply(a[i]); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { float apply(float[] a); } - static void assertReductionArraysEquals(float[] a, float[] b, float c, + static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { float apply(float[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(float[] a, float[] b, float c, boolean[] mask, + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(float[] a); } - static void assertReductionLongArraysEquals(float[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, float[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(float[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(float[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, float[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(float[] a, float[] b, float element, int index) { + static void assertInsertArraysEquals(float[] r, float[] a, float element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, in } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, bo } } - static void assertBroadcastArraysEquals(float[]a, float[]r) { + static void assertBroadcastArraysEquals(float[] r, float[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBi } } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boo } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTern } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boole } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, f } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(float actual, float expected) { return true; } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FU } } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBin } } - static void assertBroadcastArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { float apply(float[] a, int b); } - static void assertArraysEquals(float[] a, float[] r, FBinArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { float[] apply(float[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, FGatherScatterOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { float[] apply(float[] r, float[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } catch (AssertionError e) { float[] ref = f.apply(a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FS } catch (AssertionError e) { float[] ref = f.apply(r, a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { float[] apply(float[] a, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { + static void assertArraysEquals(float[] r, float[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { } catch (AssertionError e) { float[] ref = f.apply(a, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { float[] apply(float[] a, float[] b, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLaneBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLan } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { float[] apply(float[] a, float[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, bool } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { float[] apply(float[] a, float[] b, int origin, int part, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { float[] apply(float[] a, float[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(float[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(float[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -954,7 +954,7 @@ static void assertArraysEquals(float[] a, long[] r, int offs) { } } - static void assertArraysEquals(float[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1406,7 +1406,7 @@ static void ADDFloat128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::ADD); + assertArraysEquals(r, a, b, Float128VectorTests::ADD); } static float add(float a, float b) { return (float)(a + b); @@ -1424,7 +1424,7 @@ static void addFloat128VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::add); + assertArraysEquals(r, a, b, Float128VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void ADDFloat128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::SUB); + assertArraysEquals(r, a, b, Float128VectorTests::SUB); } static float sub(float a, float b) { return (float)(a - b); @@ -1500,7 +1500,7 @@ static void subFloat128VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::sub); + assertArraysEquals(r, a, b, Float128VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1520,7 +1520,7 @@ static void SUBFloat128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::MUL); + assertArraysEquals(r, a, b, Float128VectorTests::MUL); } static float mul(float a, float b) { return (float)(a * b); @@ -1576,7 +1576,7 @@ static void mulFloat128VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::mul); + assertArraysEquals(r, a, b, Float128VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1596,7 +1596,7 @@ static void MULFloat128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::DIV); + assertArraysEquals(r, a, b, Float128VectorTests::DIV); } static float div(float a, float b) { return (float)(a / b); @@ -1653,7 +1653,7 @@ static void divFloat128VectorTests(IntFunction fa, IntFunction av.div(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::div); + assertArraysEquals(r, a, b, Float128VectorTests::div); } @@ -1675,7 +1675,7 @@ static void DIVFloat128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Float128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Float128VectorTests::FIRST_NONZERO); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1736,7 +1736,7 @@ static void FIRST_NONZEROFloat128VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Float128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Float128VectorTests::FIRST_NONZERO); } @@ -1758,7 +1758,7 @@ static void addFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1775,7 +1775,7 @@ static void addFloat128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Float128VectorTests::add); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1789,7 +1789,7 @@ static void subFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1806,7 +1806,7 @@ static void subFloat128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Float128VectorTests::sub); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1820,7 +1820,7 @@ static void mulFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1837,7 +1837,7 @@ static void mulFloat128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Float128VectorTests::mul); } @@ -1852,7 +1852,7 @@ static void divFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::div); } @@ -1871,7 +1871,7 @@ static void divFloat128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Float128VectorTests::div); } @@ -1894,7 +1894,7 @@ static void ADDFloat128VectorTestsBroadcastLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Float128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Float128VectorTests::ADD); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1911,7 +1911,7 @@ static void ADDFloat128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::MIN); + assertArraysEquals(r, a, b, Float128VectorTests::MIN); } static float min(float a, float b) { return (float)(Math.min(a, b)); @@ -1985,7 +1985,7 @@ static void minFloat128VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::min); + assertArraysEquals(r, a, b, Float128VectorTests::min); } static float MAX(float a, float b) { return (float)(Math.max(a, b)); @@ -2005,7 +2005,7 @@ static void MAXFloat128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float128VectorTests::MAX); + assertArraysEquals(r, a, b, Float128VectorTests::MAX); } static float max(float a, float b) { return (float)(Math.max(a, b)); @@ -2023,7 +2023,7 @@ static void maxFloat128VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::max); + assertArraysEquals(r, a, b, Float128VectorTests::max); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2037,7 +2037,7 @@ static void MINFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::MIN); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2051,7 +2051,7 @@ static void minFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::min); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2065,7 +2065,7 @@ static void MAXFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::MAX); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2079,7 +2079,7 @@ static void maxFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Float128VectorTests::max); } @@ -2131,7 +2131,7 @@ static void ADDReduceFloat128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float128VectorTests::ADDReduce, Float128VectorTests::ADDReduceAll); } static float ADDReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2175,7 +2175,7 @@ static void ADDReduceFloat128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float128VectorTests::ADDReduceMasked, Float128VectorTests::ADDReduceAllMasked); } static float MULReduce(float[] a, int idx) { @@ -2216,7 +2216,7 @@ static void MULReduceFloat128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float128VectorTests::MULReduce, Float128VectorTests::MULReduceAll); } static float MULReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2260,7 +2260,7 @@ static void MULReduceFloat128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float128VectorTests::MULReduceMasked, Float128VectorTests::MULReduceAllMasked); } static float MINReduce(float[] a, int idx) { @@ -2301,7 +2301,7 @@ static void MINReduceFloat128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float128VectorTests::MINReduce, Float128VectorTests::MINReduceAll); } static float MINReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2346,7 +2346,7 @@ static void MINReduceFloat128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float128VectorTests::MINReduceMasked, Float128VectorTests::MINReduceAllMasked); } static float MAXReduce(float[] a, int idx) { @@ -2387,7 +2387,7 @@ static void MAXReduceFloat128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float128VectorTests::MAXReduce, Float128VectorTests::MAXReduceAll); } static float MAXReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2432,7 +2432,7 @@ static void MAXReduceFloat128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float128VectorTests::MAXReduceMasked, Float128VectorTests::MAXReduceAllMasked); } @@ -2452,7 +2452,7 @@ static void withFloat128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (float)4, 0); + assertInsertArraysEquals(r, a, (float)4, 0); } static boolean testIS_DEFAULT(float a) { return bits(a)==0; @@ -3118,7 +3118,7 @@ static void blendFloat128VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpShuffleMaskProvider") @@ -3153,7 +3153,7 @@ static void RearrangeFloat128VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpProvider") static void getFloat128VectorTests(IntFunction fa) { @@ -3308,7 +3308,7 @@ static void getFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::get); + assertArraysEquals(r, a, Float128VectorTests::get); } @Test(dataProvider = "floatUnaryOpProvider") @@ -3322,7 +3322,7 @@ static void BroadcastFloat128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3369,7 +3369,7 @@ static void sliceUnaryFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Float128VectorTests::sliceUnary); } static float[] sliceBinary(float[] a, float[] b, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3398,7 +3398,7 @@ static void sliceBinaryFloat128VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Float128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Float128VectorTests::sliceBinary); } static float[] slice(float[] a, float[] b, int origin, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3431,7 +3431,7 @@ static void sliceFloat128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Float128VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Float128VectorTests::slice); } static float[] unsliceUnary(float[] a, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3458,7 +3458,7 @@ static void unsliceUnaryFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Float128VectorTests::unsliceUnary); } static float[] unsliceBinary(float[] a, float[] b, int origin, int part, int idx) { float[] res = new float[SPECIES.length()]; @@ -3497,7 +3497,7 @@ static void unsliceBinaryFloat128VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Float128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Float128VectorTests::unsliceBinary); } static float[] unslice(float[] a, float[] b, int origin, int part, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3553,7 +3553,7 @@ static void unsliceFloat128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Float128VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Float128VectorTests::unslice); } static float SIN(float a) { @@ -3576,7 +3576,7 @@ static void SINFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::SIN, Float128VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::SIN, Float128VectorTests::strictSIN); } @@ -3600,7 +3600,7 @@ static void EXPFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::EXP, Float128VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::EXP, Float128VectorTests::strictEXP); } @@ -3624,7 +3624,7 @@ static void LOG1PFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::LOG1P, Float128VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::LOG1P, Float128VectorTests::strictLOG1P); } @@ -3648,7 +3648,7 @@ static void LOGFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::LOG, Float128VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::LOG, Float128VectorTests::strictLOG); } @@ -3672,7 +3672,7 @@ static void LOG10Float128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::LOG10, Float128VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::LOG10, Float128VectorTests::strictLOG10); } @@ -3696,7 +3696,7 @@ static void EXPM1Float128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::EXPM1, Float128VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::EXPM1, Float128VectorTests::strictEXPM1); } @@ -3720,7 +3720,7 @@ static void COSFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::COS, Float128VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::COS, Float128VectorTests::strictCOS); } @@ -3744,7 +3744,7 @@ static void TANFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::TAN, Float128VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::TAN, Float128VectorTests::strictTAN); } @@ -3768,7 +3768,7 @@ static void SINHFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::SINH, Float128VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::SINH, Float128VectorTests::strictSINH); } @@ -3792,7 +3792,7 @@ static void COSHFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::COSH, Float128VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::COSH, Float128VectorTests::strictCOSH); } @@ -3816,7 +3816,7 @@ static void TANHFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::TANH, Float128VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::TANH, Float128VectorTests::strictTANH); } @@ -3840,7 +3840,7 @@ static void ASINFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::ASIN, Float128VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::ASIN, Float128VectorTests::strictASIN); } @@ -3864,7 +3864,7 @@ static void ACOSFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::ACOS, Float128VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::ACOS, Float128VectorTests::strictACOS); } @@ -3888,7 +3888,7 @@ static void ATANFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::ATAN, Float128VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::ATAN, Float128VectorTests::strictATAN); } @@ -3912,7 +3912,7 @@ static void CBRTFloat128VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float128VectorTests::CBRT, Float128VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Float128VectorTests::CBRT, Float128VectorTests::strictCBRT); } @@ -3938,7 +3938,7 @@ static void HYPOTFloat128VectorTests(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float128VectorTests::POW, Float128VectorTests::strictPOW); + assertArraysEqualsWithinOneUlp(r, a, b, Float128VectorTests::POW, Float128VectorTests::strictPOW); } static float pow(float a, float b) { @@ -3990,7 +3990,7 @@ static void powFloat128VectorTests(IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float128VectorTests::pow, Float128VectorTests::strictpow); + assertArraysEqualsWithinOneUlp(r, a, b, Float128VectorTests::pow, Float128VectorTests::strictpow); } @@ -4017,7 +4017,7 @@ static void ATAN2Float128VectorTests(IntFunction fa, IntFunction fa, In av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float128VectorTests::POW, Float128VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float128VectorTests::POW, Float128VectorTests::strictPOW); } @Test(dataProvider = "floatBinaryOpProvider") @@ -4047,7 +4047,7 @@ static void powFloat128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float128VectorTests::pow, Float128VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float128VectorTests::pow, Float128VectorTests::strictpow); } @@ -4076,7 +4076,7 @@ static void FMAFloat128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, Float128VectorTests::FMA); + assertArraysEquals(r, a, b, c, Float128VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat128VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4092,7 +4092,7 @@ static void fmaFloat128VectorTests(IntFunction fa, IntFunction av.fma(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Float128VectorTests::fma); + assertArraysEquals(r, a, b, c, Float128VectorTests::fma); } @@ -4115,7 +4115,7 @@ static void FMAFloat128VectorTestsMasked(IntFunction fa, IntFunction fa, In FloatVector bv = FloatVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Float128VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Float128VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") @@ -4149,7 +4149,7 @@ static void FMAFloat128VectorTestsAltBroadcastSmokeTest(IntFunction fa, FloatVector cv = FloatVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Float128VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Float128VectorTests::FMA); } @@ -4169,7 +4169,7 @@ static void FMAFloat128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, Float128VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, Float128VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpMaskProvider") @@ -4188,7 +4188,7 @@ static void FMAFloat128VectorTestsAltBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float128VectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float128VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat128VectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4220,7 +4220,7 @@ static void fmaFloat128VectorTestsDoubleBroadcastSmokeTest(IntFunction av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float128VectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float128VectorTests::fma); } @@ -4239,7 +4239,7 @@ static void FMAFloat128VectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::NEG); + assertArraysEquals(r, a, Float128VectorTests::NEG); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4280,7 +4280,7 @@ static void negFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::neg); + assertArraysEquals(r, a, Float128VectorTests::neg); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4298,7 +4298,7 @@ static void NEGMaskedFloat128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float128VectorTests::NEG); + assertArraysEquals(r, a, mask, Float128VectorTests::NEG); } static float ABS(float a) { @@ -4321,7 +4321,7 @@ static void ABSFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::ABS); + assertArraysEquals(r, a, Float128VectorTests::ABS); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4336,7 +4336,7 @@ static void absFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::abs); + assertArraysEquals(r, a, Float128VectorTests::abs); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4354,7 +4354,7 @@ static void ABSMaskedFloat128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float128VectorTests::ABS); + assertArraysEquals(r, a, mask, Float128VectorTests::ABS); } @@ -4386,7 +4386,7 @@ static void SQRTFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::SQRT); + assertArraysEquals(r, a, Float128VectorTests::SQRT); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4401,7 +4401,7 @@ static void sqrtFloat128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float128VectorTests::sqrt); + assertArraysEquals(r, a, Float128VectorTests::sqrt); } @@ -4421,7 +4421,7 @@ static void SQRTMaskedFloat128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float128VectorTests::SQRT); + assertArraysEquals(r, a, mask, Float128VectorTests::SQRT); } static float[] gather(float a[], int ix, int[] b, int iy) { @@ -4446,7 +4446,7 @@ static void gatherFloat128VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Float128VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Float128VectorTests::gatherMasked); } static float[] scatter(float a[], int ix, int[] b, int iy) { @@ -4499,7 +4499,7 @@ static void scatterFloat128VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Float128VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Float128VectorTests::scatterMasked); } @@ -4579,8 +4579,8 @@ static void toIntArrayFloat128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4590,8 +4590,8 @@ static void toLongArrayFloat128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4601,8 +4601,8 @@ static void toDoubleArrayFloat128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4668,7 +4668,7 @@ static void ADDReduceLongFloat128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Float128VectorTests::ADDReduceLong, Float128VectorTests::ADDReduceAllLong); } @@ -4709,7 +4709,7 @@ static void ADDReduceLongFloat128VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Float128VectorTests::ADDReduceLongMasked, Float128VectorTests::ADDReduceAllLongMasked); } @@ -4721,7 +4721,7 @@ static void BroadcastLongFloat128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -4739,7 +4739,7 @@ static void blendFloat128VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Float128VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Float128VectorTests::blend); } @@ -4756,7 +4756,7 @@ static void SelectFromFloat128VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpSelectFromMaskProvider") @@ -4775,7 +4775,7 @@ static void SelectFromFloat128VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4852,7 +4852,7 @@ static void maskEqFloat128VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Float128VectorTests::beq); + assertArraysEquals(r, a, b, Float128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Float256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Float256VectorLoadStoreTests.java index ed2cf47548538..5b504a31fd2a3 100644 --- a/test/jdk/jdk/incubator/vector/Float256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Float256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Float256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(float[] a, float[] r, boolean[] mask) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0, "at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(float[] a, float[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "floatProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new float[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Float256VectorTests.java b/test/jdk/jdk/incubator/vector/Float256VectorTests.java index 777e2989d1ff0..40a561c5260b5 100644 --- a/test/jdk/jdk/incubator/vector/Float256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Float256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { float apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { float[] apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { } catch (AssertionError e) { float[] ref = f.apply(a[i]); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { float apply(float[] a); } - static void assertReductionArraysEquals(float[] a, float[] b, float c, + static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { float apply(float[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(float[] a, float[] b, float c, boolean[] mask, + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(float[] a); } - static void assertReductionLongArraysEquals(float[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, float[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(float[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(float[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, float[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(float[] a, float[] b, float element, int index) { + static void assertInsertArraysEquals(float[] r, float[] a, float element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, in } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, bo } } - static void assertBroadcastArraysEquals(float[]a, float[]r) { + static void assertBroadcastArraysEquals(float[] r, float[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBi } } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boo } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTern } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boole } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, f } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(float actual, float expected) { return true; } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FU } } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBin } } - static void assertBroadcastArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { float apply(float[] a, int b); } - static void assertArraysEquals(float[] a, float[] r, FBinArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { float[] apply(float[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, FGatherScatterOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { float[] apply(float[] r, float[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } catch (AssertionError e) { float[] ref = f.apply(a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FS } catch (AssertionError e) { float[] ref = f.apply(r, a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { float[] apply(float[] a, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { + static void assertArraysEquals(float[] r, float[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { } catch (AssertionError e) { float[] ref = f.apply(a, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { float[] apply(float[] a, float[] b, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLaneBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLan } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { float[] apply(float[] a, float[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, bool } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { float[] apply(float[] a, float[] b, int origin, int part, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { float[] apply(float[] a, float[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(float[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(float[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -954,7 +954,7 @@ static void assertArraysEquals(float[] a, long[] r, int offs) { } } - static void assertArraysEquals(float[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1406,7 +1406,7 @@ static void ADDFloat256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::ADD); + assertArraysEquals(r, a, b, Float256VectorTests::ADD); } static float add(float a, float b) { return (float)(a + b); @@ -1424,7 +1424,7 @@ static void addFloat256VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::add); + assertArraysEquals(r, a, b, Float256VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void ADDFloat256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::SUB); + assertArraysEquals(r, a, b, Float256VectorTests::SUB); } static float sub(float a, float b) { return (float)(a - b); @@ -1500,7 +1500,7 @@ static void subFloat256VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::sub); + assertArraysEquals(r, a, b, Float256VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1520,7 +1520,7 @@ static void SUBFloat256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::MUL); + assertArraysEquals(r, a, b, Float256VectorTests::MUL); } static float mul(float a, float b) { return (float)(a * b); @@ -1576,7 +1576,7 @@ static void mulFloat256VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::mul); + assertArraysEquals(r, a, b, Float256VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1596,7 +1596,7 @@ static void MULFloat256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::DIV); + assertArraysEquals(r, a, b, Float256VectorTests::DIV); } static float div(float a, float b) { return (float)(a / b); @@ -1653,7 +1653,7 @@ static void divFloat256VectorTests(IntFunction fa, IntFunction av.div(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::div); + assertArraysEquals(r, a, b, Float256VectorTests::div); } @@ -1675,7 +1675,7 @@ static void DIVFloat256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Float256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Float256VectorTests::FIRST_NONZERO); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1736,7 +1736,7 @@ static void FIRST_NONZEROFloat256VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Float256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Float256VectorTests::FIRST_NONZERO); } @@ -1758,7 +1758,7 @@ static void addFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1775,7 +1775,7 @@ static void addFloat256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Float256VectorTests::add); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1789,7 +1789,7 @@ static void subFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1806,7 +1806,7 @@ static void subFloat256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Float256VectorTests::sub); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1820,7 +1820,7 @@ static void mulFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1837,7 +1837,7 @@ static void mulFloat256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Float256VectorTests::mul); } @@ -1852,7 +1852,7 @@ static void divFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::div); } @@ -1871,7 +1871,7 @@ static void divFloat256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Float256VectorTests::div); } @@ -1894,7 +1894,7 @@ static void ADDFloat256VectorTestsBroadcastLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Float256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Float256VectorTests::ADD); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1911,7 +1911,7 @@ static void ADDFloat256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::MIN); + assertArraysEquals(r, a, b, Float256VectorTests::MIN); } static float min(float a, float b) { return (float)(Math.min(a, b)); @@ -1985,7 +1985,7 @@ static void minFloat256VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::min); + assertArraysEquals(r, a, b, Float256VectorTests::min); } static float MAX(float a, float b) { return (float)(Math.max(a, b)); @@ -2005,7 +2005,7 @@ static void MAXFloat256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float256VectorTests::MAX); + assertArraysEquals(r, a, b, Float256VectorTests::MAX); } static float max(float a, float b) { return (float)(Math.max(a, b)); @@ -2023,7 +2023,7 @@ static void maxFloat256VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::max); + assertArraysEquals(r, a, b, Float256VectorTests::max); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2037,7 +2037,7 @@ static void MINFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::MIN); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2051,7 +2051,7 @@ static void minFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::min); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2065,7 +2065,7 @@ static void MAXFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::MAX); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2079,7 +2079,7 @@ static void maxFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Float256VectorTests::max); } @@ -2131,7 +2131,7 @@ static void ADDReduceFloat256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float256VectorTests::ADDReduce, Float256VectorTests::ADDReduceAll); } static float ADDReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2175,7 +2175,7 @@ static void ADDReduceFloat256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float256VectorTests::ADDReduceMasked, Float256VectorTests::ADDReduceAllMasked); } static float MULReduce(float[] a, int idx) { @@ -2216,7 +2216,7 @@ static void MULReduceFloat256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float256VectorTests::MULReduce, Float256VectorTests::MULReduceAll); } static float MULReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2260,7 +2260,7 @@ static void MULReduceFloat256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float256VectorTests::MULReduceMasked, Float256VectorTests::MULReduceAllMasked); } static float MINReduce(float[] a, int idx) { @@ -2301,7 +2301,7 @@ static void MINReduceFloat256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float256VectorTests::MINReduce, Float256VectorTests::MINReduceAll); } static float MINReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2346,7 +2346,7 @@ static void MINReduceFloat256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float256VectorTests::MINReduceMasked, Float256VectorTests::MINReduceAllMasked); } static float MAXReduce(float[] a, int idx) { @@ -2387,7 +2387,7 @@ static void MAXReduceFloat256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float256VectorTests::MAXReduce, Float256VectorTests::MAXReduceAll); } static float MAXReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2432,7 +2432,7 @@ static void MAXReduceFloat256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float256VectorTests::MAXReduceMasked, Float256VectorTests::MAXReduceAllMasked); } @@ -2452,7 +2452,7 @@ static void withFloat256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (float)4, 0); + assertInsertArraysEquals(r, a, (float)4, 0); } static boolean testIS_DEFAULT(float a) { return bits(a)==0; @@ -3118,7 +3118,7 @@ static void blendFloat256VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpShuffleMaskProvider") @@ -3153,7 +3153,7 @@ static void RearrangeFloat256VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpProvider") static void getFloat256VectorTests(IntFunction fa) { @@ -3308,7 +3308,7 @@ static void getFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::get); + assertArraysEquals(r, a, Float256VectorTests::get); } @Test(dataProvider = "floatUnaryOpProvider") @@ -3322,7 +3322,7 @@ static void BroadcastFloat256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3369,7 +3369,7 @@ static void sliceUnaryFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Float256VectorTests::sliceUnary); } static float[] sliceBinary(float[] a, float[] b, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3398,7 +3398,7 @@ static void sliceBinaryFloat256VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Float256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Float256VectorTests::sliceBinary); } static float[] slice(float[] a, float[] b, int origin, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3431,7 +3431,7 @@ static void sliceFloat256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Float256VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Float256VectorTests::slice); } static float[] unsliceUnary(float[] a, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3458,7 +3458,7 @@ static void unsliceUnaryFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Float256VectorTests::unsliceUnary); } static float[] unsliceBinary(float[] a, float[] b, int origin, int part, int idx) { float[] res = new float[SPECIES.length()]; @@ -3497,7 +3497,7 @@ static void unsliceBinaryFloat256VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Float256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Float256VectorTests::unsliceBinary); } static float[] unslice(float[] a, float[] b, int origin, int part, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3553,7 +3553,7 @@ static void unsliceFloat256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Float256VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Float256VectorTests::unslice); } static float SIN(float a) { @@ -3576,7 +3576,7 @@ static void SINFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::SIN, Float256VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::SIN, Float256VectorTests::strictSIN); } @@ -3600,7 +3600,7 @@ static void EXPFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::EXP, Float256VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::EXP, Float256VectorTests::strictEXP); } @@ -3624,7 +3624,7 @@ static void LOG1PFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::LOG1P, Float256VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::LOG1P, Float256VectorTests::strictLOG1P); } @@ -3648,7 +3648,7 @@ static void LOGFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::LOG, Float256VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::LOG, Float256VectorTests::strictLOG); } @@ -3672,7 +3672,7 @@ static void LOG10Float256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::LOG10, Float256VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::LOG10, Float256VectorTests::strictLOG10); } @@ -3696,7 +3696,7 @@ static void EXPM1Float256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::EXPM1, Float256VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::EXPM1, Float256VectorTests::strictEXPM1); } @@ -3720,7 +3720,7 @@ static void COSFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::COS, Float256VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::COS, Float256VectorTests::strictCOS); } @@ -3744,7 +3744,7 @@ static void TANFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::TAN, Float256VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::TAN, Float256VectorTests::strictTAN); } @@ -3768,7 +3768,7 @@ static void SINHFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::SINH, Float256VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::SINH, Float256VectorTests::strictSINH); } @@ -3792,7 +3792,7 @@ static void COSHFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::COSH, Float256VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::COSH, Float256VectorTests::strictCOSH); } @@ -3816,7 +3816,7 @@ static void TANHFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::TANH, Float256VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::TANH, Float256VectorTests::strictTANH); } @@ -3840,7 +3840,7 @@ static void ASINFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::ASIN, Float256VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::ASIN, Float256VectorTests::strictASIN); } @@ -3864,7 +3864,7 @@ static void ACOSFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::ACOS, Float256VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::ACOS, Float256VectorTests::strictACOS); } @@ -3888,7 +3888,7 @@ static void ATANFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::ATAN, Float256VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::ATAN, Float256VectorTests::strictATAN); } @@ -3912,7 +3912,7 @@ static void CBRTFloat256VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float256VectorTests::CBRT, Float256VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Float256VectorTests::CBRT, Float256VectorTests::strictCBRT); } @@ -3938,7 +3938,7 @@ static void HYPOTFloat256VectorTests(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float256VectorTests::POW, Float256VectorTests::strictPOW); + assertArraysEqualsWithinOneUlp(r, a, b, Float256VectorTests::POW, Float256VectorTests::strictPOW); } static float pow(float a, float b) { @@ -3990,7 +3990,7 @@ static void powFloat256VectorTests(IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float256VectorTests::pow, Float256VectorTests::strictpow); + assertArraysEqualsWithinOneUlp(r, a, b, Float256VectorTests::pow, Float256VectorTests::strictpow); } @@ -4017,7 +4017,7 @@ static void ATAN2Float256VectorTests(IntFunction fa, IntFunction fa, In av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float256VectorTests::POW, Float256VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float256VectorTests::POW, Float256VectorTests::strictPOW); } @Test(dataProvider = "floatBinaryOpProvider") @@ -4047,7 +4047,7 @@ static void powFloat256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float256VectorTests::pow, Float256VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float256VectorTests::pow, Float256VectorTests::strictpow); } @@ -4076,7 +4076,7 @@ static void FMAFloat256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, Float256VectorTests::FMA); + assertArraysEquals(r, a, b, c, Float256VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat256VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4092,7 +4092,7 @@ static void fmaFloat256VectorTests(IntFunction fa, IntFunction av.fma(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Float256VectorTests::fma); + assertArraysEquals(r, a, b, c, Float256VectorTests::fma); } @@ -4115,7 +4115,7 @@ static void FMAFloat256VectorTestsMasked(IntFunction fa, IntFunction fa, In FloatVector bv = FloatVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Float256VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Float256VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") @@ -4149,7 +4149,7 @@ static void FMAFloat256VectorTestsAltBroadcastSmokeTest(IntFunction fa, FloatVector cv = FloatVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Float256VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Float256VectorTests::FMA); } @@ -4169,7 +4169,7 @@ static void FMAFloat256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, Float256VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, Float256VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpMaskProvider") @@ -4188,7 +4188,7 @@ static void FMAFloat256VectorTestsAltBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float256VectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float256VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat256VectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4220,7 +4220,7 @@ static void fmaFloat256VectorTestsDoubleBroadcastSmokeTest(IntFunction av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float256VectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float256VectorTests::fma); } @@ -4239,7 +4239,7 @@ static void FMAFloat256VectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::NEG); + assertArraysEquals(r, a, Float256VectorTests::NEG); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4280,7 +4280,7 @@ static void negFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::neg); + assertArraysEquals(r, a, Float256VectorTests::neg); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4298,7 +4298,7 @@ static void NEGMaskedFloat256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float256VectorTests::NEG); + assertArraysEquals(r, a, mask, Float256VectorTests::NEG); } static float ABS(float a) { @@ -4321,7 +4321,7 @@ static void ABSFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::ABS); + assertArraysEquals(r, a, Float256VectorTests::ABS); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4336,7 +4336,7 @@ static void absFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::abs); + assertArraysEquals(r, a, Float256VectorTests::abs); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4354,7 +4354,7 @@ static void ABSMaskedFloat256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float256VectorTests::ABS); + assertArraysEquals(r, a, mask, Float256VectorTests::ABS); } @@ -4386,7 +4386,7 @@ static void SQRTFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::SQRT); + assertArraysEquals(r, a, Float256VectorTests::SQRT); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4401,7 +4401,7 @@ static void sqrtFloat256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float256VectorTests::sqrt); + assertArraysEquals(r, a, Float256VectorTests::sqrt); } @@ -4421,7 +4421,7 @@ static void SQRTMaskedFloat256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float256VectorTests::SQRT); + assertArraysEquals(r, a, mask, Float256VectorTests::SQRT); } static float[] gather(float a[], int ix, int[] b, int iy) { @@ -4446,7 +4446,7 @@ static void gatherFloat256VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Float256VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Float256VectorTests::gatherMasked); } static float[] scatter(float a[], int ix, int[] b, int iy) { @@ -4499,7 +4499,7 @@ static void scatterFloat256VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Float256VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Float256VectorTests::scatterMasked); } @@ -4579,8 +4579,8 @@ static void toIntArrayFloat256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4590,8 +4590,8 @@ static void toLongArrayFloat256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4601,8 +4601,8 @@ static void toDoubleArrayFloat256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4668,7 +4668,7 @@ static void ADDReduceLongFloat256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Float256VectorTests::ADDReduceLong, Float256VectorTests::ADDReduceAllLong); } @@ -4709,7 +4709,7 @@ static void ADDReduceLongFloat256VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Float256VectorTests::ADDReduceLongMasked, Float256VectorTests::ADDReduceAllLongMasked); } @@ -4721,7 +4721,7 @@ static void BroadcastLongFloat256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -4739,7 +4739,7 @@ static void blendFloat256VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Float256VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Float256VectorTests::blend); } @@ -4756,7 +4756,7 @@ static void SelectFromFloat256VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpSelectFromMaskProvider") @@ -4775,7 +4775,7 @@ static void SelectFromFloat256VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4852,7 +4852,7 @@ static void maskEqFloat256VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Float256VectorTests::beq); + assertArraysEquals(r, a, b, Float256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Float512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Float512VectorLoadStoreTests.java index 958b364528512..0aa356dd9c8e9 100644 --- a/test/jdk/jdk/incubator/vector/Float512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Float512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Float512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(float[] a, float[] r, boolean[] mask) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0, "at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(float[] a, float[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "floatProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new float[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Float512VectorTests.java b/test/jdk/jdk/incubator/vector/Float512VectorTests.java index bec251d800f88..91556d5d9dffc 100644 --- a/test/jdk/jdk/incubator/vector/Float512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Float512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { float apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { float[] apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { } catch (AssertionError e) { float[] ref = f.apply(a[i]); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { float apply(float[] a); } - static void assertReductionArraysEquals(float[] a, float[] b, float c, + static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { float apply(float[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(float[] a, float[] b, float c, boolean[] mask, + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(float[] a); } - static void assertReductionLongArraysEquals(float[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, float[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(float[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(float[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, float[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(float[] a, float[] b, float element, int index) { + static void assertInsertArraysEquals(float[] r, float[] a, float element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, in } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, bo } } - static void assertBroadcastArraysEquals(float[]a, float[]r) { + static void assertBroadcastArraysEquals(float[] r, float[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBi } } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boo } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTern } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boole } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, f } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(float actual, float expected) { return true; } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FU } } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBin } } - static void assertBroadcastArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { float apply(float[] a, int b); } - static void assertArraysEquals(float[] a, float[] r, FBinArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { float[] apply(float[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, FGatherScatterOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { float[] apply(float[] r, float[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } catch (AssertionError e) { float[] ref = f.apply(a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FS } catch (AssertionError e) { float[] ref = f.apply(r, a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { float[] apply(float[] a, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { + static void assertArraysEquals(float[] r, float[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { } catch (AssertionError e) { float[] ref = f.apply(a, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { float[] apply(float[] a, float[] b, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLaneBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLan } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { float[] apply(float[] a, float[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, bool } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { float[] apply(float[] a, float[] b, int origin, int part, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { float[] apply(float[] a, float[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(float[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(float[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -954,7 +954,7 @@ static void assertArraysEquals(float[] a, long[] r, int offs) { } } - static void assertArraysEquals(float[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1406,7 +1406,7 @@ static void ADDFloat512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::ADD); + assertArraysEquals(r, a, b, Float512VectorTests::ADD); } static float add(float a, float b) { return (float)(a + b); @@ -1424,7 +1424,7 @@ static void addFloat512VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::add); + assertArraysEquals(r, a, b, Float512VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void ADDFloat512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::SUB); + assertArraysEquals(r, a, b, Float512VectorTests::SUB); } static float sub(float a, float b) { return (float)(a - b); @@ -1500,7 +1500,7 @@ static void subFloat512VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::sub); + assertArraysEquals(r, a, b, Float512VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1520,7 +1520,7 @@ static void SUBFloat512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::MUL); + assertArraysEquals(r, a, b, Float512VectorTests::MUL); } static float mul(float a, float b) { return (float)(a * b); @@ -1576,7 +1576,7 @@ static void mulFloat512VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::mul); + assertArraysEquals(r, a, b, Float512VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1596,7 +1596,7 @@ static void MULFloat512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::DIV); + assertArraysEquals(r, a, b, Float512VectorTests::DIV); } static float div(float a, float b) { return (float)(a / b); @@ -1653,7 +1653,7 @@ static void divFloat512VectorTests(IntFunction fa, IntFunction av.div(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::div); + assertArraysEquals(r, a, b, Float512VectorTests::div); } @@ -1675,7 +1675,7 @@ static void DIVFloat512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Float512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Float512VectorTests::FIRST_NONZERO); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1736,7 +1736,7 @@ static void FIRST_NONZEROFloat512VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Float512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Float512VectorTests::FIRST_NONZERO); } @@ -1758,7 +1758,7 @@ static void addFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1775,7 +1775,7 @@ static void addFloat512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Float512VectorTests::add); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1789,7 +1789,7 @@ static void subFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1806,7 +1806,7 @@ static void subFloat512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Float512VectorTests::sub); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1820,7 +1820,7 @@ static void mulFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1837,7 +1837,7 @@ static void mulFloat512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Float512VectorTests::mul); } @@ -1852,7 +1852,7 @@ static void divFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::div); } @@ -1871,7 +1871,7 @@ static void divFloat512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Float512VectorTests::div); } @@ -1894,7 +1894,7 @@ static void ADDFloat512VectorTestsBroadcastLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Float512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Float512VectorTests::ADD); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1911,7 +1911,7 @@ static void ADDFloat512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::MIN); + assertArraysEquals(r, a, b, Float512VectorTests::MIN); } static float min(float a, float b) { return (float)(Math.min(a, b)); @@ -1985,7 +1985,7 @@ static void minFloat512VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::min); + assertArraysEquals(r, a, b, Float512VectorTests::min); } static float MAX(float a, float b) { return (float)(Math.max(a, b)); @@ -2005,7 +2005,7 @@ static void MAXFloat512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float512VectorTests::MAX); + assertArraysEquals(r, a, b, Float512VectorTests::MAX); } static float max(float a, float b) { return (float)(Math.max(a, b)); @@ -2023,7 +2023,7 @@ static void maxFloat512VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::max); + assertArraysEquals(r, a, b, Float512VectorTests::max); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2037,7 +2037,7 @@ static void MINFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::MIN); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2051,7 +2051,7 @@ static void minFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::min); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2065,7 +2065,7 @@ static void MAXFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::MAX); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2079,7 +2079,7 @@ static void maxFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Float512VectorTests::max); } @@ -2131,7 +2131,7 @@ static void ADDReduceFloat512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float512VectorTests::ADDReduce, Float512VectorTests::ADDReduceAll); } static float ADDReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2175,7 +2175,7 @@ static void ADDReduceFloat512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float512VectorTests::ADDReduceMasked, Float512VectorTests::ADDReduceAllMasked); } static float MULReduce(float[] a, int idx) { @@ -2216,7 +2216,7 @@ static void MULReduceFloat512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float512VectorTests::MULReduce, Float512VectorTests::MULReduceAll); } static float MULReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2260,7 +2260,7 @@ static void MULReduceFloat512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float512VectorTests::MULReduceMasked, Float512VectorTests::MULReduceAllMasked); } static float MINReduce(float[] a, int idx) { @@ -2301,7 +2301,7 @@ static void MINReduceFloat512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float512VectorTests::MINReduce, Float512VectorTests::MINReduceAll); } static float MINReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2346,7 +2346,7 @@ static void MINReduceFloat512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float512VectorTests::MINReduceMasked, Float512VectorTests::MINReduceAllMasked); } static float MAXReduce(float[] a, int idx) { @@ -2387,7 +2387,7 @@ static void MAXReduceFloat512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float512VectorTests::MAXReduce, Float512VectorTests::MAXReduceAll); } static float MAXReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2432,7 +2432,7 @@ static void MAXReduceFloat512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float512VectorTests::MAXReduceMasked, Float512VectorTests::MAXReduceAllMasked); } @@ -2452,7 +2452,7 @@ static void withFloat512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (float)4, 0); + assertInsertArraysEquals(r, a, (float)4, 0); } static boolean testIS_DEFAULT(float a) { return bits(a)==0; @@ -3118,7 +3118,7 @@ static void blendFloat512VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpShuffleMaskProvider") @@ -3153,7 +3153,7 @@ static void RearrangeFloat512VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpProvider") static void getFloat512VectorTests(IntFunction fa) { @@ -3308,7 +3308,7 @@ static void getFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::get); + assertArraysEquals(r, a, Float512VectorTests::get); } @Test(dataProvider = "floatUnaryOpProvider") @@ -3322,7 +3322,7 @@ static void BroadcastFloat512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3369,7 +3369,7 @@ static void sliceUnaryFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Float512VectorTests::sliceUnary); } static float[] sliceBinary(float[] a, float[] b, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3398,7 +3398,7 @@ static void sliceBinaryFloat512VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Float512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Float512VectorTests::sliceBinary); } static float[] slice(float[] a, float[] b, int origin, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3431,7 +3431,7 @@ static void sliceFloat512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Float512VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Float512VectorTests::slice); } static float[] unsliceUnary(float[] a, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3458,7 +3458,7 @@ static void unsliceUnaryFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Float512VectorTests::unsliceUnary); } static float[] unsliceBinary(float[] a, float[] b, int origin, int part, int idx) { float[] res = new float[SPECIES.length()]; @@ -3497,7 +3497,7 @@ static void unsliceBinaryFloat512VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Float512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Float512VectorTests::unsliceBinary); } static float[] unslice(float[] a, float[] b, int origin, int part, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3553,7 +3553,7 @@ static void unsliceFloat512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Float512VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Float512VectorTests::unslice); } static float SIN(float a) { @@ -3576,7 +3576,7 @@ static void SINFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::SIN, Float512VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::SIN, Float512VectorTests::strictSIN); } @@ -3600,7 +3600,7 @@ static void EXPFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::EXP, Float512VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::EXP, Float512VectorTests::strictEXP); } @@ -3624,7 +3624,7 @@ static void LOG1PFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::LOG1P, Float512VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::LOG1P, Float512VectorTests::strictLOG1P); } @@ -3648,7 +3648,7 @@ static void LOGFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::LOG, Float512VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::LOG, Float512VectorTests::strictLOG); } @@ -3672,7 +3672,7 @@ static void LOG10Float512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::LOG10, Float512VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::LOG10, Float512VectorTests::strictLOG10); } @@ -3696,7 +3696,7 @@ static void EXPM1Float512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::EXPM1, Float512VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::EXPM1, Float512VectorTests::strictEXPM1); } @@ -3720,7 +3720,7 @@ static void COSFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::COS, Float512VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::COS, Float512VectorTests::strictCOS); } @@ -3744,7 +3744,7 @@ static void TANFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::TAN, Float512VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::TAN, Float512VectorTests::strictTAN); } @@ -3768,7 +3768,7 @@ static void SINHFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::SINH, Float512VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::SINH, Float512VectorTests::strictSINH); } @@ -3792,7 +3792,7 @@ static void COSHFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::COSH, Float512VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::COSH, Float512VectorTests::strictCOSH); } @@ -3816,7 +3816,7 @@ static void TANHFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::TANH, Float512VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::TANH, Float512VectorTests::strictTANH); } @@ -3840,7 +3840,7 @@ static void ASINFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::ASIN, Float512VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::ASIN, Float512VectorTests::strictASIN); } @@ -3864,7 +3864,7 @@ static void ACOSFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::ACOS, Float512VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::ACOS, Float512VectorTests::strictACOS); } @@ -3888,7 +3888,7 @@ static void ATANFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::ATAN, Float512VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::ATAN, Float512VectorTests::strictATAN); } @@ -3912,7 +3912,7 @@ static void CBRTFloat512VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float512VectorTests::CBRT, Float512VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Float512VectorTests::CBRT, Float512VectorTests::strictCBRT); } @@ -3938,7 +3938,7 @@ static void HYPOTFloat512VectorTests(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float512VectorTests::POW, Float512VectorTests::strictPOW); + assertArraysEqualsWithinOneUlp(r, a, b, Float512VectorTests::POW, Float512VectorTests::strictPOW); } static float pow(float a, float b) { @@ -3990,7 +3990,7 @@ static void powFloat512VectorTests(IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float512VectorTests::pow, Float512VectorTests::strictpow); + assertArraysEqualsWithinOneUlp(r, a, b, Float512VectorTests::pow, Float512VectorTests::strictpow); } @@ -4017,7 +4017,7 @@ static void ATAN2Float512VectorTests(IntFunction fa, IntFunction fa, In av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float512VectorTests::POW, Float512VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float512VectorTests::POW, Float512VectorTests::strictPOW); } @Test(dataProvider = "floatBinaryOpProvider") @@ -4047,7 +4047,7 @@ static void powFloat512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float512VectorTests::pow, Float512VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float512VectorTests::pow, Float512VectorTests::strictpow); } @@ -4076,7 +4076,7 @@ static void FMAFloat512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, Float512VectorTests::FMA); + assertArraysEquals(r, a, b, c, Float512VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat512VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4092,7 +4092,7 @@ static void fmaFloat512VectorTests(IntFunction fa, IntFunction av.fma(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Float512VectorTests::fma); + assertArraysEquals(r, a, b, c, Float512VectorTests::fma); } @@ -4115,7 +4115,7 @@ static void FMAFloat512VectorTestsMasked(IntFunction fa, IntFunction fa, In FloatVector bv = FloatVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Float512VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Float512VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") @@ -4149,7 +4149,7 @@ static void FMAFloat512VectorTestsAltBroadcastSmokeTest(IntFunction fa, FloatVector cv = FloatVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Float512VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Float512VectorTests::FMA); } @@ -4169,7 +4169,7 @@ static void FMAFloat512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, Float512VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, Float512VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpMaskProvider") @@ -4188,7 +4188,7 @@ static void FMAFloat512VectorTestsAltBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float512VectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float512VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat512VectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4220,7 +4220,7 @@ static void fmaFloat512VectorTestsDoubleBroadcastSmokeTest(IntFunction av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float512VectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float512VectorTests::fma); } @@ -4239,7 +4239,7 @@ static void FMAFloat512VectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::NEG); + assertArraysEquals(r, a, Float512VectorTests::NEG); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4280,7 +4280,7 @@ static void negFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::neg); + assertArraysEquals(r, a, Float512VectorTests::neg); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4298,7 +4298,7 @@ static void NEGMaskedFloat512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float512VectorTests::NEG); + assertArraysEquals(r, a, mask, Float512VectorTests::NEG); } static float ABS(float a) { @@ -4321,7 +4321,7 @@ static void ABSFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::ABS); + assertArraysEquals(r, a, Float512VectorTests::ABS); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4336,7 +4336,7 @@ static void absFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::abs); + assertArraysEquals(r, a, Float512VectorTests::abs); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4354,7 +4354,7 @@ static void ABSMaskedFloat512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float512VectorTests::ABS); + assertArraysEquals(r, a, mask, Float512VectorTests::ABS); } @@ -4386,7 +4386,7 @@ static void SQRTFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::SQRT); + assertArraysEquals(r, a, Float512VectorTests::SQRT); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4401,7 +4401,7 @@ static void sqrtFloat512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float512VectorTests::sqrt); + assertArraysEquals(r, a, Float512VectorTests::sqrt); } @@ -4421,7 +4421,7 @@ static void SQRTMaskedFloat512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float512VectorTests::SQRT); + assertArraysEquals(r, a, mask, Float512VectorTests::SQRT); } static float[] gather(float a[], int ix, int[] b, int iy) { @@ -4446,7 +4446,7 @@ static void gatherFloat512VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Float512VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Float512VectorTests::gatherMasked); } static float[] scatter(float a[], int ix, int[] b, int iy) { @@ -4499,7 +4499,7 @@ static void scatterFloat512VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Float512VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Float512VectorTests::scatterMasked); } @@ -4579,8 +4579,8 @@ static void toIntArrayFloat512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4590,8 +4590,8 @@ static void toLongArrayFloat512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4601,8 +4601,8 @@ static void toDoubleArrayFloat512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4668,7 +4668,7 @@ static void ADDReduceLongFloat512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Float512VectorTests::ADDReduceLong, Float512VectorTests::ADDReduceAllLong); } @@ -4709,7 +4709,7 @@ static void ADDReduceLongFloat512VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Float512VectorTests::ADDReduceLongMasked, Float512VectorTests::ADDReduceAllLongMasked); } @@ -4721,7 +4721,7 @@ static void BroadcastLongFloat512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -4739,7 +4739,7 @@ static void blendFloat512VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Float512VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Float512VectorTests::blend); } @@ -4756,7 +4756,7 @@ static void SelectFromFloat512VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpSelectFromMaskProvider") @@ -4775,7 +4775,7 @@ static void SelectFromFloat512VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4852,7 +4852,7 @@ static void maskEqFloat512VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Float512VectorTests::beq); + assertArraysEquals(r, a, b, Float512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Float64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Float64VectorLoadStoreTests.java index 9f8a5dd45e3f3..166a171582d25 100644 --- a/test/jdk/jdk/incubator/vector/Float64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Float64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Float64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(float[] a, float[] r, boolean[] mask) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0, "at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(float[] a, float[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "floatProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new float[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Float64VectorTests.java b/test/jdk/jdk/incubator/vector/Float64VectorTests.java index f25193c86fbcc..9e00b5bfc3642 100644 --- a/test/jdk/jdk/incubator/vector/Float64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Float64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { float apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { float[] apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { } catch (AssertionError e) { float[] ref = f.apply(a[i]); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { float apply(float[] a); } - static void assertReductionArraysEquals(float[] a, float[] b, float c, + static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { float apply(float[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(float[] a, float[] b, float c, boolean[] mask, + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(float[] a); } - static void assertReductionLongArraysEquals(float[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, float[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(float[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(float[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, float[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(float[] a, float[] b, float element, int index) { + static void assertInsertArraysEquals(float[] r, float[] a, float element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, in } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, bo } } - static void assertBroadcastArraysEquals(float[]a, float[]r) { + static void assertBroadcastArraysEquals(float[] r, float[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBi } } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boo } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTern } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boole } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, f } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -613,7 +613,7 @@ static boolean isWithin1Ulp(float actual, float expected) { return true; } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -627,7 +627,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FU } } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -641,7 +641,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBin } } - static void assertBroadcastArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -671,7 +671,7 @@ interface FBinArrayOp { float apply(float[] a, int b); } - static void assertArraysEquals(float[] a, float[] r, FBinArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -686,7 +686,7 @@ interface FGatherScatterOp { float[] apply(float[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, FGatherScatterOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -713,7 +713,7 @@ interface FScatterMaskedOp { float[] apply(float[] r, float[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -723,7 +723,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } catch (AssertionError e) { float[] ref = f.apply(a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -734,7 +734,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -744,7 +744,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FS } catch (AssertionError e) { float[] ref = f.apply(r, a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -761,7 +761,7 @@ interface FLaneOp { float[] apply(float[] a, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { + static void assertArraysEquals(float[] r, float[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -771,7 +771,7 @@ static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { } catch (AssertionError e) { float[] ref = f.apply(a, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -781,7 +781,7 @@ interface FLaneBop { float[] apply(float[] a, float[] b, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLaneBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -791,7 +791,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLan } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -802,7 +802,7 @@ interface FLaneMaskedBop { float[] apply(float[] a, float[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -812,7 +812,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, bool } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -823,7 +823,7 @@ interface FLanePartBop { float[] apply(float[] a, float[] b, int origin, int part, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -833,7 +833,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -845,7 +845,7 @@ interface FLanePartMaskedBop { float[] apply(float[] a, float[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -855,7 +855,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -897,7 +897,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(float[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -943,7 +943,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(float[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -954,7 +954,7 @@ static void assertArraysEquals(float[] a, long[] r, int offs) { } } - static void assertArraysEquals(float[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1406,7 +1406,7 @@ static void ADDFloat64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::ADD); + assertArraysEquals(r, a, b, Float64VectorTests::ADD); } static float add(float a, float b) { return (float)(a + b); @@ -1424,7 +1424,7 @@ static void addFloat64VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::add); + assertArraysEquals(r, a, b, Float64VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void ADDFloat64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::SUB); + assertArraysEquals(r, a, b, Float64VectorTests::SUB); } static float sub(float a, float b) { return (float)(a - b); @@ -1500,7 +1500,7 @@ static void subFloat64VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::sub); + assertArraysEquals(r, a, b, Float64VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1520,7 +1520,7 @@ static void SUBFloat64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::MUL); + assertArraysEquals(r, a, b, Float64VectorTests::MUL); } static float mul(float a, float b) { return (float)(a * b); @@ -1576,7 +1576,7 @@ static void mulFloat64VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::mul); + assertArraysEquals(r, a, b, Float64VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1596,7 +1596,7 @@ static void MULFloat64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::DIV); + assertArraysEquals(r, a, b, Float64VectorTests::DIV); } static float div(float a, float b) { return (float)(a / b); @@ -1653,7 +1653,7 @@ static void divFloat64VectorTests(IntFunction fa, IntFunction av.div(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::div); + assertArraysEquals(r, a, b, Float64VectorTests::div); } @@ -1675,7 +1675,7 @@ static void DIVFloat64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Float64VectorTests::FIRST_NONZERO); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1736,7 +1736,7 @@ static void FIRST_NONZEROFloat64VectorTestsMasked(IntFunction fa, IntFu } } - assertArraysEquals(a, b, r, mask, Float64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Float64VectorTests::FIRST_NONZERO); } @@ -1758,7 +1758,7 @@ static void addFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1775,7 +1775,7 @@ static void addFloat64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Float64VectorTests::add); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1789,7 +1789,7 @@ static void subFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1806,7 +1806,7 @@ static void subFloat64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Float64VectorTests::sub); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1820,7 +1820,7 @@ static void mulFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1837,7 +1837,7 @@ static void mulFloat64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Float64VectorTests::mul); } @@ -1852,7 +1852,7 @@ static void divFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::div); } @@ -1871,7 +1871,7 @@ static void divFloat64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Float64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Float64VectorTests::div); } @@ -1894,7 +1894,7 @@ static void ADDFloat64VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Float64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Float64VectorTests::ADD); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1911,7 +1911,7 @@ static void ADDFloat64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::MIN); + assertArraysEquals(r, a, b, Float64VectorTests::MIN); } static float min(float a, float b) { return (float)(Math.min(a, b)); @@ -1985,7 +1985,7 @@ static void minFloat64VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::min); + assertArraysEquals(r, a, b, Float64VectorTests::min); } static float MAX(float a, float b) { return (float)(Math.max(a, b)); @@ -2005,7 +2005,7 @@ static void MAXFloat64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Float64VectorTests::MAX); + assertArraysEquals(r, a, b, Float64VectorTests::MAX); } static float max(float a, float b) { return (float)(Math.max(a, b)); @@ -2023,7 +2023,7 @@ static void maxFloat64VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::max); + assertArraysEquals(r, a, b, Float64VectorTests::max); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2037,7 +2037,7 @@ static void MINFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::MIN); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2051,7 +2051,7 @@ static void minFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::min); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2065,7 +2065,7 @@ static void MAXFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::MAX); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2079,7 +2079,7 @@ static void maxFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Float64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Float64VectorTests::max); } @@ -2131,7 +2131,7 @@ static void ADDReduceFloat64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float64VectorTests::ADDReduce, Float64VectorTests::ADDReduceAll); } static float ADDReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2175,7 +2175,7 @@ static void ADDReduceFloat64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float64VectorTests::ADDReduceMasked, Float64VectorTests::ADDReduceAllMasked); } static float MULReduce(float[] a, int idx) { @@ -2216,7 +2216,7 @@ static void MULReduceFloat64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float64VectorTests::MULReduce, Float64VectorTests::MULReduceAll); } static float MULReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2260,7 +2260,7 @@ static void MULReduceFloat64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float64VectorTests::MULReduceMasked, Float64VectorTests::MULReduceAllMasked); } static float MINReduce(float[] a, int idx) { @@ -2301,7 +2301,7 @@ static void MINReduceFloat64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float64VectorTests::MINReduce, Float64VectorTests::MINReduceAll); } static float MINReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2346,7 +2346,7 @@ static void MINReduceFloat64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float64VectorTests::MINReduceMasked, Float64VectorTests::MINReduceAllMasked); } static float MAXReduce(float[] a, int idx) { @@ -2387,7 +2387,7 @@ static void MAXReduceFloat64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Float64VectorTests::MAXReduce, Float64VectorTests::MAXReduceAll); } static float MAXReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2432,7 +2432,7 @@ static void MAXReduceFloat64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Float64VectorTests::MAXReduceMasked, Float64VectorTests::MAXReduceAllMasked); } @@ -2452,7 +2452,7 @@ static void withFloat64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (float)4, 0); + assertInsertArraysEquals(r, a, (float)4, 0); } static boolean testIS_DEFAULT(float a) { return bits(a)==0; @@ -3118,7 +3118,7 @@ static void blendFloat64VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpShuffleMaskProvider") @@ -3153,7 +3153,7 @@ static void RearrangeFloat64VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpProvider") static void getFloat64VectorTests(IntFunction fa) { @@ -3308,7 +3308,7 @@ static void getFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::get); + assertArraysEquals(r, a, Float64VectorTests::get); } @Test(dataProvider = "floatUnaryOpProvider") @@ -3322,7 +3322,7 @@ static void BroadcastFloat64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3369,7 +3369,7 @@ static void sliceUnaryFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Float64VectorTests::sliceUnary); } static float[] sliceBinary(float[] a, float[] b, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3398,7 +3398,7 @@ static void sliceBinaryFloat64VectorTestsBinary(IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, origin, Float64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Float64VectorTests::sliceBinary); } static float[] slice(float[] a, float[] b, int origin, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3431,7 +3431,7 @@ static void sliceFloat64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Float64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Float64VectorTests::unsliceUnary); } static float[] unsliceBinary(float[] a, float[] b, int origin, int part, int idx) { float[] res = new float[SPECIES.length()]; @@ -3497,7 +3497,7 @@ static void unsliceBinaryFloat64VectorTestsBinary(IntFunction fa, IntFu } } - assertArraysEquals(a, b, r, origin, part, Float64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Float64VectorTests::unsliceBinary); } static float[] unslice(float[] a, float[] b, int origin, int part, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3553,7 +3553,7 @@ static void unsliceFloat64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, origin, part, mask, Float64VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Float64VectorTests::unslice); } static float SIN(float a) { @@ -3576,7 +3576,7 @@ static void SINFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::SIN, Float64VectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::SIN, Float64VectorTests::strictSIN); } @@ -3600,7 +3600,7 @@ static void EXPFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::EXP, Float64VectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::EXP, Float64VectorTests::strictEXP); } @@ -3624,7 +3624,7 @@ static void LOG1PFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::LOG1P, Float64VectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::LOG1P, Float64VectorTests::strictLOG1P); } @@ -3648,7 +3648,7 @@ static void LOGFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::LOG, Float64VectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::LOG, Float64VectorTests::strictLOG); } @@ -3672,7 +3672,7 @@ static void LOG10Float64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::LOG10, Float64VectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::LOG10, Float64VectorTests::strictLOG10); } @@ -3696,7 +3696,7 @@ static void EXPM1Float64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::EXPM1, Float64VectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::EXPM1, Float64VectorTests::strictEXPM1); } @@ -3720,7 +3720,7 @@ static void COSFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::COS, Float64VectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::COS, Float64VectorTests::strictCOS); } @@ -3744,7 +3744,7 @@ static void TANFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::TAN, Float64VectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::TAN, Float64VectorTests::strictTAN); } @@ -3768,7 +3768,7 @@ static void SINHFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::SINH, Float64VectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::SINH, Float64VectorTests::strictSINH); } @@ -3792,7 +3792,7 @@ static void COSHFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::COSH, Float64VectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::COSH, Float64VectorTests::strictCOSH); } @@ -3816,7 +3816,7 @@ static void TANHFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::TANH, Float64VectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::TANH, Float64VectorTests::strictTANH); } @@ -3840,7 +3840,7 @@ static void ASINFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::ASIN, Float64VectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::ASIN, Float64VectorTests::strictASIN); } @@ -3864,7 +3864,7 @@ static void ACOSFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::ACOS, Float64VectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::ACOS, Float64VectorTests::strictACOS); } @@ -3888,7 +3888,7 @@ static void ATANFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::ATAN, Float64VectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::ATAN, Float64VectorTests::strictATAN); } @@ -3912,7 +3912,7 @@ static void CBRTFloat64VectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, Float64VectorTests::CBRT, Float64VectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, Float64VectorTests::CBRT, Float64VectorTests::strictCBRT); } @@ -3938,7 +3938,7 @@ static void HYPOTFloat64VectorTests(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float64VectorTests::POW, Float64VectorTests::strictPOW); + assertArraysEqualsWithinOneUlp(r, a, b, Float64VectorTests::POW, Float64VectorTests::strictPOW); } static float pow(float a, float b) { @@ -3990,7 +3990,7 @@ static void powFloat64VectorTests(IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, Float64VectorTests::pow, Float64VectorTests::strictpow); + assertArraysEqualsWithinOneUlp(r, a, b, Float64VectorTests::pow, Float64VectorTests::strictpow); } @@ -4017,7 +4017,7 @@ static void ATAN2Float64VectorTests(IntFunction fa, IntFunction fa, Int av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float64VectorTests::POW, Float64VectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float64VectorTests::POW, Float64VectorTests::strictPOW); } @Test(dataProvider = "floatBinaryOpProvider") @@ -4047,7 +4047,7 @@ static void powFloat64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, Float64VectorTests::pow, Float64VectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, Float64VectorTests::pow, Float64VectorTests::strictpow); } @@ -4076,7 +4076,7 @@ static void FMAFloat64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, Float64VectorTests::FMA); + assertArraysEquals(r, a, b, c, Float64VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat64VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4092,7 +4092,7 @@ static void fmaFloat64VectorTests(IntFunction fa, IntFunction av.fma(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Float64VectorTests::fma); + assertArraysEquals(r, a, b, c, Float64VectorTests::fma); } @@ -4115,7 +4115,7 @@ static void FMAFloat64VectorTestsMasked(IntFunction fa, IntFunction fa, Int FloatVector bv = FloatVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Float64VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, Float64VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") @@ -4149,7 +4149,7 @@ static void FMAFloat64VectorTestsAltBroadcastSmokeTest(IntFunction fa, FloatVector cv = FloatVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Float64VectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, Float64VectorTests::FMA); } @@ -4169,7 +4169,7 @@ static void FMAFloat64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, Float64VectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, Float64VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpMaskProvider") @@ -4188,7 +4188,7 @@ static void FMAFloat64VectorTestsAltBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float64VectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float64VectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloat64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4220,7 +4220,7 @@ static void fmaFloat64VectorTestsDoubleBroadcastSmokeTest(IntFunction f av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Float64VectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, Float64VectorTests::fma); } @@ -4239,7 +4239,7 @@ static void FMAFloat64VectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::NEG); + assertArraysEquals(r, a, Float64VectorTests::NEG); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4280,7 +4280,7 @@ static void negFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::neg); + assertArraysEquals(r, a, Float64VectorTests::neg); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4298,7 +4298,7 @@ static void NEGMaskedFloat64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float64VectorTests::NEG); + assertArraysEquals(r, a, mask, Float64VectorTests::NEG); } static float ABS(float a) { @@ -4321,7 +4321,7 @@ static void ABSFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::ABS); + assertArraysEquals(r, a, Float64VectorTests::ABS); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4336,7 +4336,7 @@ static void absFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::abs); + assertArraysEquals(r, a, Float64VectorTests::abs); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4354,7 +4354,7 @@ static void ABSMaskedFloat64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float64VectorTests::ABS); + assertArraysEquals(r, a, mask, Float64VectorTests::ABS); } @@ -4386,7 +4386,7 @@ static void SQRTFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::SQRT); + assertArraysEquals(r, a, Float64VectorTests::SQRT); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4401,7 +4401,7 @@ static void sqrtFloat64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Float64VectorTests::sqrt); + assertArraysEquals(r, a, Float64VectorTests::sqrt); } @@ -4421,7 +4421,7 @@ static void SQRTMaskedFloat64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Float64VectorTests::SQRT); + assertArraysEquals(r, a, mask, Float64VectorTests::SQRT); } static float[] gather(float a[], int ix, int[] b, int iy) { @@ -4446,7 +4446,7 @@ static void gatherFloat64VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Float64VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Float64VectorTests::scatterMasked); } @@ -4579,8 +4579,8 @@ static void toIntArrayFloat64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4590,8 +4590,8 @@ static void toLongArrayFloat64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4601,8 +4601,8 @@ static void toDoubleArrayFloat64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4668,7 +4668,7 @@ static void ADDReduceLongFloat64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Float64VectorTests::ADDReduceLong, Float64VectorTests::ADDReduceAllLong); } @@ -4709,7 +4709,7 @@ static void ADDReduceLongFloat64VectorTestsMasked(IntFunction fa, IntFu ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Float64VectorTests::ADDReduceLongMasked, Float64VectorTests::ADDReduceAllLongMasked); } @@ -4721,7 +4721,7 @@ static void BroadcastLongFloat64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -4739,7 +4739,7 @@ static void blendFloat64VectorTestsBroadcastLongSmokeTest(IntFunction f av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Float64VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Float64VectorTests::blend); } @@ -4756,7 +4756,7 @@ static void SelectFromFloat64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpSelectFromMaskProvider") @@ -4775,7 +4775,7 @@ static void SelectFromFloat64VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4852,7 +4852,7 @@ static void maskEqFloat64VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Float64VectorTests::beq); + assertArraysEquals(r, a, b, Float64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java index d94ddd88906ad..ed32c12a778af 100644 --- a/test/jdk/jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -67,47 +67,25 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(float[] a, float[] r, boolean[] mask) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (float) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (float) 0, "at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(float[] a, float[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (float) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -410,7 +388,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "floatProviderForIOOBE") @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new float[a.length]; @@ -492,7 +470,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatMaskProviderForIOOBE") @@ -565,7 +543,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -589,7 +567,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -676,7 +654,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -691,7 +669,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -807,7 +785,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "floatByteProviderForIOOBE") @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -899,7 +877,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "floatByteMaskProviderForIOOBE") @@ -976,7 +954,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -987,7 +965,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java b/test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java index 8f4723f1493e4..842c4f930753b 100644 --- a/test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { float apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { float[] apply(float a); } - static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(float[] a, float[] r, FUnArrayOp f) { } catch (AssertionError e) { float[] ref = f.apply(a[i]); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(float[] a, float[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(float[] r, float[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { float apply(float[] a); } - static void assertReductionArraysEquals(float[] a, float[] b, float c, + static void assertReductionArraysEquals(float[] r, float rc, float[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { float apply(float[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(float[] a, float[] b, float c, boolean[] mask, + static void assertReductionArraysEqualsMasked(float[] r, float rc, float[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -167,17 +167,17 @@ interface FReductionAllOpLong { long apply(float[] a); } - static void assertReductionLongArraysEquals(float[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, float[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -189,17 +189,17 @@ interface FReductionAllMaskedOpLong { long apply(float[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(float[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, float[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -207,37 +207,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(float[] a, float[] b, float element, int index) { + static void assertInsertArraysEquals(float[] r, float[] a, float element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -251,7 +251,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -265,7 +265,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, in } } - static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(float[] r, float[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -285,7 +285,7 @@ static void assertRearrangeArraysEquals(float[] a, float[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(float[] r, float[] a, float[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -305,7 +305,7 @@ static void assertSelectFromArraysEquals(float[] a, float[] r, float[] order, bo } } - static void assertBroadcastArraysEquals(float[]a, float[]r) { + static void assertBroadcastArraysEquals(float[] r, float[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -334,7 +334,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -345,7 +345,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -357,7 +357,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -369,11 +369,11 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, FBi } } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -384,11 +384,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -402,11 +402,11 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] r, boolean } } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -420,7 +420,7 @@ static void assertBroadcastLongArraysEquals(float[] a, float[] b, float[] r, boo } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -434,11 +434,11 @@ static void assertShiftArraysEquals(float[] a, float[] b, float[] r, FBinOp f) { } } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(float[] a, float[] b, float[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(float[] r, float[] a, float[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -464,7 +464,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -475,11 +475,11 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, FTern } } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -491,7 +491,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] c, float[] r, boole } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -504,7 +504,7 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,12 +517,12 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -538,12 +538,12 @@ static void assertBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] } } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ static void assertAltBroadcastArraysEquals(float[] a, float[] b, float[] c, floa } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,12 +574,12 @@ static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, f } } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(float[] a, float[] b, float[] c, float[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(float[] r, float[] a, float[] b, float[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -618,7 +618,7 @@ static boolean isWithin1Ulp(float actual, float expected) { return true; } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -632,7 +632,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] r, FUnOp mathf, FU } } - static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -646,7 +646,7 @@ static void assertArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, FBin } } - static void assertBroadcastArraysEqualsWithinOneUlp(float[] a, float[] b, float[] r, + static void assertBroadcastArraysEqualsWithinOneUlp(float[] r, float[] a, float[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -676,7 +676,7 @@ interface FBinArrayOp { float apply(float[] a, int b); } - static void assertArraysEquals(float[] a, float[] r, FBinArrayOp f) { + static void assertArraysEquals(float[] r, float[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -691,7 +691,7 @@ interface FGatherScatterOp { float[] apply(float[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, FGatherScatterOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -718,7 +718,7 @@ interface FScatterMaskedOp { float[] apply(float[] r, float[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -728,7 +728,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } catch (AssertionError e) { float[] ref = f.apply(a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -739,7 +739,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FG } } - static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(float[] r, float[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -749,7 +749,7 @@ static void assertArraysEquals(float[] a, int[] b, float[] r, boolean[] mask, FS } catch (AssertionError e) { float[] ref = f.apply(r, a, i, mask, b, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -766,7 +766,7 @@ interface FLaneOp { float[] apply(float[] a, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { + static void assertArraysEquals(float[] r, float[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -776,7 +776,7 @@ static void assertArraysEquals(float[] a, float[] r, int origin, FLaneOp f) { } catch (AssertionError e) { float[] ref = f.apply(a, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -786,7 +786,7 @@ interface FLaneBop { float[] apply(float[] a, float[] b, int origin, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLaneBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -796,7 +796,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, FLan } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -807,7 +807,7 @@ interface FLaneMaskedBop { float[] apply(float[] a, float[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -817,7 +817,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, bool } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -828,7 +828,7 @@ interface FLanePartBop { float[] apply(float[] a, float[] b, int origin, int part, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -838,7 +838,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -850,7 +850,7 @@ interface FLanePartMaskedBop { float[] apply(float[] a, float[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(float[] r, float[] a, float[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -860,7 +860,7 @@ static void assertArraysEquals(float[] a, float[] b, float[] r, int origin, int } catch (AssertionError e) { float[] ref = f.apply(a, b, origin, part, mask, i); float[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -902,7 +902,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(float[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -948,7 +948,7 @@ static long longCornerCaseValue(int i) { ); - static void assertArraysEquals(float[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -959,7 +959,7 @@ static void assertArraysEquals(float[] a, long[] r, int offs) { } } - static void assertArraysEquals(float[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, float[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1411,7 +1411,7 @@ static void ADDFloatMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::ADD); + assertArraysEquals(r, a, b, FloatMaxVectorTests::ADD); } static float add(float a, float b) { return (float)(a + b); @@ -1429,7 +1429,7 @@ static void addFloatMaxVectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::add); + assertArraysEquals(r, a, b, FloatMaxVectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1449,7 +1449,7 @@ static void ADDFloatMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::SUB); + assertArraysEquals(r, a, b, FloatMaxVectorTests::SUB); } static float sub(float a, float b) { return (float)(a - b); @@ -1505,7 +1505,7 @@ static void subFloatMaxVectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::sub); + assertArraysEquals(r, a, b, FloatMaxVectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1525,7 +1525,7 @@ static void SUBFloatMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::MUL); + assertArraysEquals(r, a, b, FloatMaxVectorTests::MUL); } static float mul(float a, float b) { return (float)(a * b); @@ -1581,7 +1581,7 @@ static void mulFloatMaxVectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::mul); + assertArraysEquals(r, a, b, FloatMaxVectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1601,7 +1601,7 @@ static void MULFloatMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::DIV); + assertArraysEquals(r, a, b, FloatMaxVectorTests::DIV); } static float div(float a, float b) { return (float)(a / b); @@ -1658,7 +1658,7 @@ static void divFloatMaxVectorTests(IntFunction fa, IntFunction av.div(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::div); + assertArraysEquals(r, a, b, FloatMaxVectorTests::div); } @@ -1680,7 +1680,7 @@ static void DIVFloatMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, FloatMaxVectorTests::FIRST_NONZERO); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1741,7 +1741,7 @@ static void FIRST_NONZEROFloatMaxVectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, FloatMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, FloatMaxVectorTests::FIRST_NONZERO); } @@ -1763,7 +1763,7 @@ static void addFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::add); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1780,7 +1780,7 @@ static void addFloatMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, FloatMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, FloatMaxVectorTests::add); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1794,7 +1794,7 @@ static void subFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::sub); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1811,7 +1811,7 @@ static void subFloatMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, FloatMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, FloatMaxVectorTests::sub); } @Test(dataProvider = "floatBinaryOpProvider") @@ -1825,7 +1825,7 @@ static void mulFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::mul); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1842,7 +1842,7 @@ static void mulFloatMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, FloatMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, FloatMaxVectorTests::mul); } @@ -1857,7 +1857,7 @@ static void divFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::div); } @@ -1876,7 +1876,7 @@ static void divFloatMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, FloatMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, FloatMaxVectorTests::div); } @@ -1899,7 +1899,7 @@ static void ADDFloatMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, FloatMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, FloatMaxVectorTests::ADD); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -1916,7 +1916,7 @@ static void ADDFloatMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::MIN); + assertArraysEquals(r, a, b, FloatMaxVectorTests::MIN); } static float min(float a, float b) { return (float)(Math.min(a, b)); @@ -1990,7 +1990,7 @@ static void minFloatMaxVectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::min); + assertArraysEquals(r, a, b, FloatMaxVectorTests::min); } static float MAX(float a, float b) { return (float)(Math.max(a, b)); @@ -2010,7 +2010,7 @@ static void MAXFloatMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, FloatMaxVectorTests::MAX); + assertArraysEquals(r, a, b, FloatMaxVectorTests::MAX); } static float max(float a, float b) { return (float)(Math.max(a, b)); @@ -2028,7 +2028,7 @@ static void maxFloatMaxVectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::max); + assertArraysEquals(r, a, b, FloatMaxVectorTests::max); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2042,7 +2042,7 @@ static void MINFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::MIN); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2056,7 +2056,7 @@ static void minFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::min); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2070,7 +2070,7 @@ static void MAXFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::MAX); } @Test(dataProvider = "floatBinaryOpProvider") @@ -2084,7 +2084,7 @@ static void maxFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, FloatMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, FloatMaxVectorTests::max); } @@ -2136,7 +2136,7 @@ static void ADDReduceFloatMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, FloatMaxVectorTests::ADDReduce, FloatMaxVectorTests::ADDReduceAll); } static float ADDReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2180,7 +2180,7 @@ static void ADDReduceFloatMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, FloatMaxVectorTests::ADDReduceMasked, FloatMaxVectorTests::ADDReduceAllMasked); } static float MULReduce(float[] a, int idx) { @@ -2221,7 +2221,7 @@ static void MULReduceFloatMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, FloatMaxVectorTests::MULReduce, FloatMaxVectorTests::MULReduceAll); } static float MULReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2265,7 +2265,7 @@ static void MULReduceFloatMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, FloatMaxVectorTests::MULReduceMasked, FloatMaxVectorTests::MULReduceAllMasked); } static float MINReduce(float[] a, int idx) { @@ -2306,7 +2306,7 @@ static void MINReduceFloatMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, FloatMaxVectorTests::MINReduce, FloatMaxVectorTests::MINReduceAll); } static float MINReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2351,7 +2351,7 @@ static void MINReduceFloatMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, FloatMaxVectorTests::MINReduceMasked, FloatMaxVectorTests::MINReduceAllMasked); } static float MAXReduce(float[] a, int idx) { @@ -2392,7 +2392,7 @@ static void MAXReduceFloatMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, FloatMaxVectorTests::MAXReduce, FloatMaxVectorTests::MAXReduceAll); } static float MAXReduceMasked(float[] a, int idx, boolean[] mask) { @@ -2437,7 +2437,7 @@ static void MAXReduceFloatMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, FloatMaxVectorTests::MAXReduceMasked, FloatMaxVectorTests::MAXReduceAllMasked); } @@ -2457,7 +2457,7 @@ static void withFloatMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (float)4, 0); + assertInsertArraysEquals(r, a, (float)4, 0); } static boolean testIS_DEFAULT(float a) { return bits(a)==0; @@ -3123,7 +3123,7 @@ static void blendFloatMaxVectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpShuffleMaskProvider") @@ -3158,7 +3158,7 @@ static void RearrangeFloatMaxVectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpProvider") static void getFloatMaxVectorTests(IntFunction fa) { @@ -3313,7 +3313,7 @@ static void getFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::get); + assertArraysEquals(r, a, FloatMaxVectorTests::get); } @Test(dataProvider = "floatUnaryOpProvider") @@ -3327,7 +3327,7 @@ static void BroadcastFloatMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3374,7 +3374,7 @@ static void sliceUnaryFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, FloatMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, FloatMaxVectorTests::sliceUnary); } static float[] sliceBinary(float[] a, float[] b, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3403,7 +3403,7 @@ static void sliceBinaryFloatMaxVectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, FloatMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, FloatMaxVectorTests::sliceBinary); } static float[] slice(float[] a, float[] b, int origin, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3436,7 +3436,7 @@ static void sliceFloatMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, FloatMaxVectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, FloatMaxVectorTests::slice); } static float[] unsliceUnary(float[] a, int origin, int idx) { float[] res = new float[SPECIES.length()]; @@ -3463,7 +3463,7 @@ static void unsliceUnaryFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, FloatMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, FloatMaxVectorTests::unsliceUnary); } static float[] unsliceBinary(float[] a, float[] b, int origin, int part, int idx) { float[] res = new float[SPECIES.length()]; @@ -3502,7 +3502,7 @@ static void unsliceBinaryFloatMaxVectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, FloatMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, FloatMaxVectorTests::unsliceBinary); } static float[] unslice(float[] a, float[] b, int origin, int part, boolean[] mask, int idx) { float[] res = new float[SPECIES.length()]; @@ -3558,7 +3558,7 @@ static void unsliceFloatMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, FloatMaxVectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, FloatMaxVectorTests::unslice); } static float SIN(float a) { @@ -3581,7 +3581,7 @@ static void SINFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::SIN, FloatMaxVectorTests::strictSIN); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::SIN, FloatMaxVectorTests::strictSIN); } @@ -3605,7 +3605,7 @@ static void EXPFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::EXP, FloatMaxVectorTests::strictEXP); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::EXP, FloatMaxVectorTests::strictEXP); } @@ -3629,7 +3629,7 @@ static void LOG1PFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::LOG1P, FloatMaxVectorTests::strictLOG1P); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::LOG1P, FloatMaxVectorTests::strictLOG1P); } @@ -3653,7 +3653,7 @@ static void LOGFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::LOG, FloatMaxVectorTests::strictLOG); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::LOG, FloatMaxVectorTests::strictLOG); } @@ -3677,7 +3677,7 @@ static void LOG10FloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::LOG10, FloatMaxVectorTests::strictLOG10); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::LOG10, FloatMaxVectorTests::strictLOG10); } @@ -3701,7 +3701,7 @@ static void EXPM1FloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::EXPM1, FloatMaxVectorTests::strictEXPM1); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::EXPM1, FloatMaxVectorTests::strictEXPM1); } @@ -3725,7 +3725,7 @@ static void COSFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::COS, FloatMaxVectorTests::strictCOS); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::COS, FloatMaxVectorTests::strictCOS); } @@ -3749,7 +3749,7 @@ static void TANFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::TAN, FloatMaxVectorTests::strictTAN); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::TAN, FloatMaxVectorTests::strictTAN); } @@ -3773,7 +3773,7 @@ static void SINHFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::SINH, FloatMaxVectorTests::strictSINH); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::SINH, FloatMaxVectorTests::strictSINH); } @@ -3797,7 +3797,7 @@ static void COSHFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::COSH, FloatMaxVectorTests::strictCOSH); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::COSH, FloatMaxVectorTests::strictCOSH); } @@ -3821,7 +3821,7 @@ static void TANHFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::TANH, FloatMaxVectorTests::strictTANH); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::TANH, FloatMaxVectorTests::strictTANH); } @@ -3845,7 +3845,7 @@ static void ASINFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::ASIN, FloatMaxVectorTests::strictASIN); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::ASIN, FloatMaxVectorTests::strictASIN); } @@ -3869,7 +3869,7 @@ static void ACOSFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::ACOS, FloatMaxVectorTests::strictACOS); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::ACOS, FloatMaxVectorTests::strictACOS); } @@ -3893,7 +3893,7 @@ static void ATANFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::ATAN, FloatMaxVectorTests::strictATAN); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::ATAN, FloatMaxVectorTests::strictATAN); } @@ -3917,7 +3917,7 @@ static void CBRTFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEqualsWithinOneUlp(a, r, FloatMaxVectorTests::CBRT, FloatMaxVectorTests::strictCBRT); + assertArraysEqualsWithinOneUlp(r, a, FloatMaxVectorTests::CBRT, FloatMaxVectorTests::strictCBRT); } @@ -3943,7 +3943,7 @@ static void HYPOTFloatMaxVectorTests(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, FloatMaxVectorTests::POW, FloatMaxVectorTests::strictPOW); + assertArraysEqualsWithinOneUlp(r, a, b, FloatMaxVectorTests::POW, FloatMaxVectorTests::strictPOW); } static float pow(float a, float b) { @@ -3995,7 +3995,7 @@ static void powFloatMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEqualsWithinOneUlp(a, b, r, FloatMaxVectorTests::pow, FloatMaxVectorTests::strictpow); + assertArraysEqualsWithinOneUlp(r, a, b, FloatMaxVectorTests::pow, FloatMaxVectorTests::strictpow); } @@ -4022,7 +4022,7 @@ static void ATAN2FloatMaxVectorTests(IntFunction fa, IntFunction fa, In av.lanewise(VectorOperators.POW, b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, FloatMaxVectorTests::POW, FloatMaxVectorTests::strictPOW); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, FloatMaxVectorTests::POW, FloatMaxVectorTests::strictPOW); } @Test(dataProvider = "floatBinaryOpProvider") @@ -4052,7 +4052,7 @@ static void powFloatMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.pow(b[i]).intoArray(r, i); } - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, FloatMaxVectorTests::pow, FloatMaxVectorTests::strictpow); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, FloatMaxVectorTests::pow, FloatMaxVectorTests::strictpow); } @@ -4081,7 +4081,7 @@ static void FMAFloatMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, FloatMaxVectorTests::FMA); + assertArraysEquals(r, a, b, c, FloatMaxVectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloatMaxVectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4097,7 +4097,7 @@ static void fmaFloatMaxVectorTests(IntFunction fa, IntFunction av.fma(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, FloatMaxVectorTests::fma); + assertArraysEquals(r, a, b, c, FloatMaxVectorTests::fma); } @@ -4120,7 +4120,7 @@ static void FMAFloatMaxVectorTestsMasked(IntFunction fa, IntFunction fa, In FloatVector bv = FloatVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.FMA, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, FloatMaxVectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, FloatMaxVectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") @@ -4154,7 +4154,7 @@ static void FMAFloatMaxVectorTestsAltBroadcastSmokeTest(IntFunction fa, FloatVector cv = FloatVector.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.FMA, b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, FloatMaxVectorTests::FMA); + assertAltBroadcastArraysEquals(r, a, b, c, FloatMaxVectorTests::FMA); } @@ -4174,7 +4174,7 @@ static void FMAFloatMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, FloatMaxVectorTests::FMA); + assertBroadcastArraysEquals(r, a, b, c, mask, FloatMaxVectorTests::FMA); } @Test(dataProvider = "floatTernaryOpMaskProvider") @@ -4193,7 +4193,7 @@ static void FMAFloatMaxVectorTestsAltBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.FMA, b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, FloatMaxVectorTests::FMA); + assertDoubleBroadcastArraysEquals(r, a, b, c, FloatMaxVectorTests::FMA); } @Test(dataProvider = "floatTernaryOpProvider") static void fmaFloatMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4225,7 +4225,7 @@ static void fmaFloatMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction av.fma(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, FloatMaxVectorTests::fma); + assertDoubleBroadcastArraysEquals(r, a, b, c, FloatMaxVectorTests::fma); } @@ -4244,7 +4244,7 @@ static void FMAFloatMaxVectorTestsDoubleBroadcastMaskedSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::NEG); + assertArraysEquals(r, a, FloatMaxVectorTests::NEG); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4285,7 +4285,7 @@ static void negFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::neg); + assertArraysEquals(r, a, FloatMaxVectorTests::neg); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4303,7 +4303,7 @@ static void NEGMaskedFloatMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, FloatMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, FloatMaxVectorTests::NEG); } static float ABS(float a) { @@ -4326,7 +4326,7 @@ static void ABSFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::ABS); + assertArraysEquals(r, a, FloatMaxVectorTests::ABS); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4341,7 +4341,7 @@ static void absFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::abs); + assertArraysEquals(r, a, FloatMaxVectorTests::abs); } @Test(dataProvider = "floatUnaryOpMaskProvider") @@ -4359,7 +4359,7 @@ static void ABSMaskedFloatMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, FloatMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, FloatMaxVectorTests::ABS); } @@ -4391,7 +4391,7 @@ static void SQRTFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::SQRT); + assertArraysEquals(r, a, FloatMaxVectorTests::SQRT); } @Test(dataProvider = "floatUnaryOpProvider") @@ -4406,7 +4406,7 @@ static void sqrtFloatMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, FloatMaxVectorTests::sqrt); + assertArraysEquals(r, a, FloatMaxVectorTests::sqrt); } @@ -4426,7 +4426,7 @@ static void SQRTMaskedFloatMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, FloatMaxVectorTests::SQRT); + assertArraysEquals(r, a, mask, FloatMaxVectorTests::SQRT); } static float[] gather(float a[], int ix, int[] b, int iy) { @@ -4451,7 +4451,7 @@ static void gatherFloatMaxVectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, FloatMaxVectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, FloatMaxVectorTests::gatherMasked); } static float[] scatter(float a[], int ix, int[] b, int iy) { @@ -4504,7 +4504,7 @@ static void scatterFloatMaxVectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, FloatMaxVectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, FloatMaxVectorTests::scatterMasked); } @@ -4584,8 +4584,8 @@ static void toIntArrayFloatMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4595,8 +4595,8 @@ static void toLongArrayFloatMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4606,8 +4606,8 @@ static void toDoubleArrayFloatMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector av = FloatVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4673,7 +4673,7 @@ static void ADDReduceLongFloatMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, FloatMaxVectorTests::ADDReduceLong, FloatMaxVectorTests::ADDReduceAllLong); } @@ -4714,7 +4714,7 @@ static void ADDReduceLongFloatMaxVectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, FloatMaxVectorTests::ADDReduceLongMasked, FloatMaxVectorTests::ADDReduceAllLongMasked); } @@ -4726,7 +4726,7 @@ static void BroadcastLongFloatMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { FloatVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "floatBinaryOpMaskProvider") @@ -4744,7 +4744,7 @@ static void blendFloatMaxVectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, FloatMaxVectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, FloatMaxVectorTests::blend); } @@ -4761,7 +4761,7 @@ static void SelectFromFloatMaxVectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "floatUnaryOpSelectFromMaskProvider") @@ -4780,7 +4780,7 @@ static void SelectFromFloatMaxVectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4857,7 +4857,7 @@ static void maskEqFloatMaxVectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, FloatMaxVectorTests::beq); + assertArraysEquals(r, a, b, FloatMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Int128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Int128VectorLoadStoreTests.java index 8975e91e892c3..92bf7df4d1188 100644 --- a/test/jdk/jdk/incubator/vector/Int128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Int128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Int128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(int[] a, int[] r, boolean[] mask) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0, "at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(int[] a, int[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "intProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new int[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Int128VectorTests.java b/test/jdk/jdk/incubator/vector/Int128VectorTests.java index cc88f6b284b22..5139c08801d28 100644 --- a/test/jdk/jdk/incubator/vector/Int128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Int128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { int apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { int[] apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { } catch (AssertionError e) { int[] ref = f.apply(a[i]); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { int apply(int[] a); } - static void assertReductionArraysEquals(int[] a, int[] b, int c, + static void assertReductionArraysEquals(int[] r, int rc, int[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { int apply(int[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(int[] a, int[] b, int c, boolean[] mask, + static void assertReductionArraysEqualsMasked(int[] r, int rc, int[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(int[] a); } - static void assertReductionLongArraysEquals(int[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, int[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(int[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(int[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, int[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(int[] a, int[] b, int element, int index) { + static void assertInsertArraysEquals(int[] r, int[] a, int element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vecto } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vect } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[ } } - static void assertBroadcastArraysEquals(int[]a, int[]r) { + static void assertBroadcastArraysEquals(int[] r, int[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMa } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mas } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTer } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, F } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, bool } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, b } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { int apply(int[] a, int b); } - static void assertArraysEquals(int[] a, int[] r, FBinArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { int[] apply(int[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, FGatherScatterOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { int[] apply(int[] r, int[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } catch (AssertionError e) { int[] ref = f.apply(a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatt } catch (AssertionError e) { int[] ref = f.apply(r, a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { int[] apply(int[] a, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { + static void assertArraysEquals(int[] r, int[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { } catch (AssertionError e) { int[] ref = f.apply(a, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { int[] apply(int[] a, int[] b, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { int[] apply(int[] a, int[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { int[] apply(int[] a, int[] b, int origin, int part, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { int[] apply(int[] a, int[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } - static void assertArraysEquals(int[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(int[] a, int[] r, int offs) { - static void assertArraysEquals(int[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(int[] a, long[] r, int offs) { } } - static void assertArraysEquals(int[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1254,7 +1254,7 @@ static void ADDInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::ADD); + assertArraysEquals(r, a, b, Int128VectorTests::ADD); } static int add(int a, int b) { return (int)(a + b); @@ -1272,7 +1272,7 @@ static void addInt128VectorTests(IntFunction fa, IntFunction fb) { av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::add); + assertArraysEquals(r, a, b, Int128VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1292,7 +1292,7 @@ static void ADDInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Int128VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1310,7 +1310,7 @@ static void addInt128VectorTestsMasked(IntFunction fa, IntFunction av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int128VectorTests::add); + assertArraysEquals(r, a, b, mask, Int128VectorTests::add); } static int SUB(int a, int b) { return (int)(a - b); @@ -1330,7 +1330,7 @@ static void SUBInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::SUB); + assertArraysEquals(r, a, b, Int128VectorTests::SUB); } static int sub(int a, int b) { return (int)(a - b); @@ -1348,7 +1348,7 @@ static void subInt128VectorTests(IntFunction fa, IntFunction fb) { av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::sub); + assertArraysEquals(r, a, b, Int128VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1368,7 +1368,7 @@ static void SUBInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Int128VectorTests::SUB); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1386,7 +1386,7 @@ static void subInt128VectorTestsMasked(IntFunction fa, IntFunction av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int128VectorTests::sub); + assertArraysEquals(r, a, b, mask, Int128VectorTests::sub); } static int MUL(int a, int b) { return (int)(a * b); @@ -1406,7 +1406,7 @@ static void MULInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::MUL); + assertArraysEquals(r, a, b, Int128VectorTests::MUL); } static int mul(int a, int b) { return (int)(a * b); @@ -1424,7 +1424,7 @@ static void mulInt128VectorTests(IntFunction fa, IntFunction fb) { av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::mul); + assertArraysEquals(r, a, b, Int128VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void MULInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Int128VectorTests::MUL); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1462,7 +1462,7 @@ static void mulInt128VectorTestsMasked(IntFunction fa, IntFunction av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int128VectorTests::mul); + assertArraysEquals(r, a, b, mask, Int128VectorTests::mul); } @@ -1487,7 +1487,7 @@ static void DIVInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::DIV); + assertArraysEquals(r, a, b, Int128VectorTests::DIV); } static int div(int a, int b) { return (int)(a / b); @@ -1509,7 +1509,7 @@ static void divInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::div); + assertArraysEquals(r, a, b, Int128VectorTests::div); } @@ -1533,7 +1533,7 @@ static void DIVInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Int128VectorTests::DIV); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1555,7 +1555,7 @@ static void divInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::div); + assertArraysEquals(r, a, b, mask, Int128VectorTests::div); } static int FIRST_NONZERO(int a, int b) { @@ -1576,7 +1576,7 @@ static void FIRST_NONZEROInt128VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Int128VectorTests::FIRST_NONZERO); } static int AND(int a, int b) { @@ -1617,7 +1617,7 @@ static void ANDInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::AND); + assertArraysEquals(r, a, b, Int128VectorTests::AND); } static int and(int a, int b) { return (int)(a & b); @@ -1635,7 +1635,7 @@ static void andInt128VectorTests(IntFunction fa, IntFunction fb) { av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::and); + assertArraysEquals(r, a, b, Int128VectorTests::and); } @@ -1657,7 +1657,7 @@ static void ANDInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::AND); + assertArraysEquals(r, a, b, mask, Int128VectorTests::AND); } @@ -1679,7 +1679,7 @@ static void AND_NOTInt128VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Int128VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Int128VectorTests::AND_NOT); } @@ -1701,7 +1701,7 @@ static void AND_NOTInt128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::OR); + assertArraysEquals(r, a, b, Int128VectorTests::OR); } static int or(int a, int b) { return (int)(a | b); @@ -1741,7 +1741,7 @@ static void orInt128VectorTests(IntFunction fa, IntFunction fb) { av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::or); + assertArraysEquals(r, a, b, Int128VectorTests::or); } @@ -1763,7 +1763,7 @@ static void ORInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::OR); + assertArraysEquals(r, a, b, mask, Int128VectorTests::OR); } @@ -1785,7 +1785,7 @@ static void XORInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::XOR); + assertArraysEquals(r, a, b, Int128VectorTests::XOR); } @@ -1807,7 +1807,7 @@ static void XORInt128VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::XOR); + assertArraysEquals(r, a, b, mask, Int128VectorTests::XOR); } @@ -1822,7 +1822,7 @@ static void addInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1839,7 +1839,7 @@ static void addInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::add); } @Test(dataProvider = "intBinaryOpProvider") @@ -1853,7 +1853,7 @@ static void subInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1870,7 +1870,7 @@ static void subInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::sub); } @Test(dataProvider = "intBinaryOpProvider") @@ -1884,7 +1884,7 @@ static void mulInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void mulInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::mul); } @@ -1920,7 +1920,7 @@ static void divInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::div); } @@ -1941,7 +1941,7 @@ static void divInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::div); } @@ -1957,7 +1957,7 @@ static void ORInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::OR); } @Test(dataProvider = "intBinaryOpProvider") @@ -1971,7 +1971,7 @@ static void orInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::or); } @@ -1990,7 +1990,7 @@ static void ORInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::OR); } @@ -2006,7 +2006,7 @@ static void ANDInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::AND); } @Test(dataProvider = "intBinaryOpProvider") @@ -2020,7 +2020,7 @@ static void andInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::and); } @@ -2039,7 +2039,7 @@ static void ANDInt128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Int128VectorTests::AND); } @@ -2055,7 +2055,7 @@ static void ORInt128VectorTestsBroadcastLongSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Int128VectorTests::OR); } @@ -2074,7 +2074,7 @@ static void ORInt128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Int128VectorTests::OR); } @@ -2089,7 +2089,7 @@ static void ADDInt128VectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Int128VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -2106,7 +2106,7 @@ static void ADDInt128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Int128VectorTests::ADD); } static int LSHL(int a, int b) { @@ -2127,7 +2127,7 @@ static void LSHLInt128VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int128VectorTests::LSHL); + assertArraysEquals(r, a, b, Int128VectorTests::LSHL); } @@ -2149,7 +2149,7 @@ static void LSHLInt128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int128VectorTests::ASHR); + assertArraysEquals(r, a, b, Int128VectorTests::ASHR); } @@ -2197,7 +2197,7 @@ static void ASHRInt128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int128VectorTests::LSHR); + assertArraysEquals(r, a, b, Int128VectorTests::LSHR); } @@ -2245,7 +2245,7 @@ static void LSHRInt128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int128VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, Int128VectorTests::LSHL_unary); } @@ -2291,7 +2291,7 @@ static void LSHLInt128VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int128VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, mask, Int128VectorTests::LSHL_unary); } @@ -2316,7 +2316,7 @@ static void LSHRInt128VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int128VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, Int128VectorTests::LSHR_unary); } @@ -2337,7 +2337,7 @@ static void LSHRInt128VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int128VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int128VectorTests::LSHR_unary); } @@ -2362,7 +2362,7 @@ static void ASHRInt128VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int128VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, Int128VectorTests::ASHR_unary); } @@ -2383,7 +2383,7 @@ static void ASHRInt128VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int128VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int128VectorTests::ASHR_unary); } @@ -2408,7 +2408,7 @@ static void MINInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::MIN); + assertArraysEquals(r, a, b, Int128VectorTests::MIN); } static int min(int a, int b) { return (int)(Math.min(a, b)); @@ -2426,7 +2426,7 @@ static void minInt128VectorTests(IntFunction fa, IntFunction fb) { av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::min); + assertArraysEquals(r, a, b, Int128VectorTests::min); } static int MAX(int a, int b) { return (int)(Math.max(a, b)); @@ -2446,7 +2446,7 @@ static void MAXInt128VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int128VectorTests::MAX); + assertArraysEquals(r, a, b, Int128VectorTests::MAX); } static int max(int a, int b) { return (int)(Math.max(a, b)); @@ -2464,7 +2464,7 @@ static void maxInt128VectorTests(IntFunction fa, IntFunction fb) { av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::max); + assertArraysEquals(r, a, b, Int128VectorTests::max); } @Test(dataProvider = "intBinaryOpProvider") @@ -2478,7 +2478,7 @@ static void MINInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::MIN); } @Test(dataProvider = "intBinaryOpProvider") @@ -2492,7 +2492,7 @@ static void minInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::min); } @Test(dataProvider = "intBinaryOpProvider") @@ -2506,7 +2506,7 @@ static void MAXInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::MAX); } @Test(dataProvider = "intBinaryOpProvider") @@ -2520,7 +2520,7 @@ static void maxInt128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Int128VectorTests::max); } static int ANDReduce(int[] a, int idx) { @@ -2563,7 +2563,7 @@ static void ANDReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::ANDReduce, Int128VectorTests::ANDReduceAll); } @@ -2611,7 +2611,7 @@ static void ANDReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::ANDReduceMasked, Int128VectorTests::ANDReduceAllMasked); } @@ -2656,7 +2656,7 @@ static void ORReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::ORReduce, Int128VectorTests::ORReduceAll); } @@ -2704,7 +2704,7 @@ static void ORReduceInt128VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::XORReduce, Int128VectorTests::XORReduceAll); } @@ -2797,7 +2797,7 @@ static void XORReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::XORReduceMasked, Int128VectorTests::XORReduceAllMasked); } @@ -2839,7 +2839,7 @@ static void ADDReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::ADDReduce, Int128VectorTests::ADDReduceAll); } static int ADDReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2883,7 +2883,7 @@ static void ADDReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::ADDReduceMasked, Int128VectorTests::ADDReduceAllMasked); } static int MULReduce(int[] a, int idx) { @@ -2924,7 +2924,7 @@ static void MULReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::MULReduce, Int128VectorTests::MULReduceAll); } static int MULReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2968,7 +2968,7 @@ static void MULReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::MULReduceMasked, Int128VectorTests::MULReduceAllMasked); } static int MINReduce(int[] a, int idx) { @@ -3009,7 +3009,7 @@ static void MINReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::MINReduce, Int128VectorTests::MINReduceAll); } static int MINReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3054,7 +3054,7 @@ static void MINReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::MINReduceMasked, Int128VectorTests::MINReduceAllMasked); } static int MAXReduce(int[] a, int idx) { @@ -3095,7 +3095,7 @@ static void MAXReduceInt128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int128VectorTests::MAXReduce, Int128VectorTests::MAXReduceAll); } static int MAXReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3140,7 +3140,7 @@ static void MAXReduceInt128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::MAXReduceMasked, Int128VectorTests::MAXReduceAllMasked); } @@ -3166,7 +3166,7 @@ static void anyTrueInt128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int128VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Int128VectorTests::anyTrue); } @@ -3192,7 +3192,7 @@ static void allTrueInt128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int128VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Int128VectorTests::allTrue); } @@ -3208,7 +3208,7 @@ static void withInt128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (int)4, 0); + assertInsertArraysEquals(r, a, (int)4, 0); } static boolean testIS_DEFAULT(int a) { return bits(a)==0; @@ -3757,7 +3757,7 @@ static void blendInt128VectorTests(IntFunction fa, IntFunction fb, } } - assertArraysEquals(a, b, r, mask, Int128VectorTests::blend); + assertArraysEquals(r, a, b, mask, Int128VectorTests::blend); } @Test(dataProvider = "intUnaryOpShuffleProvider") @@ -3774,7 +3774,7 @@ static void RearrangeInt128VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -3792,7 +3792,7 @@ static void RearrangeInt128VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "intUnaryOpProvider") static void getInt128VectorTests(IntFunction fa) { @@ -3947,7 +3947,7 @@ static void getInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::get); + assertArraysEquals(r, a, Int128VectorTests::get); } @Test(dataProvider = "intUnaryOpProvider") @@ -3961,7 +3961,7 @@ static void BroadcastInt128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4008,7 +4008,7 @@ static void sliceUnaryInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Int128VectorTests::sliceUnary); } static int[] sliceBinary(int[] a, int[] b, int origin, int idx) { int[] res = new int[SPECIES.length()]; @@ -4037,7 +4037,7 @@ static void sliceBinaryInt128VectorTestsBinary(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, Int128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Int128VectorTests::sliceBinary); } static int[] slice(int[] a, int[] b, int origin, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4070,7 +4070,7 @@ static void sliceInt128VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Int128VectorTests::unsliceUnary); } static int[] unsliceBinary(int[] a, int[] b, int origin, int part, int idx) { int[] res = new int[SPECIES.length()]; @@ -4136,7 +4136,7 @@ static void unsliceBinaryInt128VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, Int128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Int128VectorTests::unsliceBinary); } static int[] unslice(int[] a, int[] b, int origin, int part, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4192,7 +4192,7 @@ static void unsliceInt128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4257,7 +4257,7 @@ static void bitwiseBlendInt128VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, c, r, mask, Int128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Int128VectorTests::BITWISE_BLEND); } @@ -4298,7 +4298,7 @@ static void BITWISE_BLENDInt128VectorTestsBroadcastSmokeTest(IntFunction IntVector bv = IntVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int128VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Int128VectorTests::BITWISE_BLEND); } @Test(dataProvider = "intTernaryOpProvider") @@ -4313,7 +4313,7 @@ static void BITWISE_BLENDInt128VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4327,7 +4327,7 @@ static void bitwiseBlendInt128VectorTestsBroadcastSmokeTest(IntFunction f IntVector bv = IntVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int128VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Int128VectorTests::bitwiseBlend); } @Test(dataProvider = "intTernaryOpProvider") @@ -4342,7 +4342,7 @@ static void bitwiseBlendInt128VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4413,7 +4413,7 @@ static void bitwiseBlendInt128VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::NEG); + assertArraysEquals(r, a, Int128VectorTests::NEG); } @Test(dataProvider = "intUnaryOpProvider") @@ -4471,7 +4471,7 @@ static void negInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::neg); + assertArraysEquals(r, a, Int128VectorTests::neg); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4489,7 +4489,7 @@ static void NEGMaskedInt128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int128VectorTests::NEG); + assertArraysEquals(r, a, mask, Int128VectorTests::NEG); } static int ABS(int a) { @@ -4512,7 +4512,7 @@ static void ABSInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::ABS); + assertArraysEquals(r, a, Int128VectorTests::ABS); } @Test(dataProvider = "intUnaryOpProvider") @@ -4527,7 +4527,7 @@ static void absInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::abs); + assertArraysEquals(r, a, Int128VectorTests::abs); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4545,7 +4545,7 @@ static void ABSMaskedInt128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int128VectorTests::ABS); + assertArraysEquals(r, a, mask, Int128VectorTests::ABS); } @@ -4571,7 +4571,7 @@ static void NOTInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::NOT); + assertArraysEquals(r, a, Int128VectorTests::NOT); } @Test(dataProvider = "intUnaryOpProvider") @@ -4586,7 +4586,7 @@ static void notInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::not); + assertArraysEquals(r, a, Int128VectorTests::not); } @@ -4606,7 +4606,7 @@ static void NOTMaskedInt128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int128VectorTests::NOT); + assertArraysEquals(r, a, mask, Int128VectorTests::NOT); } @@ -4629,7 +4629,7 @@ static void ZOMOInt128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int128VectorTests::ZOMO); + assertArraysEquals(r, a, Int128VectorTests::ZOMO); } @@ -4649,7 +4649,7 @@ static void ZOMOMaskedInt128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int128VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Int128VectorTests::ZOMO); } @@ -4677,7 +4677,7 @@ static void gatherInt128VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4821,8 +4821,8 @@ static void toLongArrayInt128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4832,8 +4832,8 @@ static void toDoubleArrayInt128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4899,7 +4899,7 @@ static void ADDReduceLongInt128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Int128VectorTests::ADDReduceLong, Int128VectorTests::ADDReduceAllLong); } @@ -4940,7 +4940,7 @@ static void ADDReduceLongInt128VectorTestsMasked(IntFunction fa, IntFunct ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Int128VectorTests::ADDReduceLongMasked, Int128VectorTests::ADDReduceAllLongMasked); } @@ -4952,7 +4952,7 @@ static void BroadcastLongInt128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -4970,7 +4970,7 @@ static void blendInt128VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Int128VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Int128VectorTests::blend); } @@ -4987,7 +4987,7 @@ static void SelectFromInt128VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -5006,7 +5006,7 @@ static void SelectFromInt128VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5083,7 +5083,7 @@ static void maskEqInt128VectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Int128VectorTests::beq); + assertArraysEquals(r, a, b, Int128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Int256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Int256VectorLoadStoreTests.java index 145d89ca6b7dc..6f43ed2f0f28b 100644 --- a/test/jdk/jdk/incubator/vector/Int256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Int256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Int256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(int[] a, int[] r, boolean[] mask) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0, "at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(int[] a, int[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "intProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new int[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Int256VectorTests.java b/test/jdk/jdk/incubator/vector/Int256VectorTests.java index a2343b08f062c..37e44fa3f3df9 100644 --- a/test/jdk/jdk/incubator/vector/Int256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Int256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { int apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { int[] apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { } catch (AssertionError e) { int[] ref = f.apply(a[i]); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { int apply(int[] a); } - static void assertReductionArraysEquals(int[] a, int[] b, int c, + static void assertReductionArraysEquals(int[] r, int rc, int[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { int apply(int[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(int[] a, int[] b, int c, boolean[] mask, + static void assertReductionArraysEqualsMasked(int[] r, int rc, int[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(int[] a); } - static void assertReductionLongArraysEquals(int[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, int[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(int[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(int[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, int[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(int[] a, int[] b, int element, int index) { + static void assertInsertArraysEquals(int[] r, int[] a, int element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vecto } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vect } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[ } } - static void assertBroadcastArraysEquals(int[]a, int[]r) { + static void assertBroadcastArraysEquals(int[] r, int[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMa } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mas } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTer } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, F } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, bool } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, b } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { int apply(int[] a, int b); } - static void assertArraysEquals(int[] a, int[] r, FBinArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { int[] apply(int[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, FGatherScatterOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { int[] apply(int[] r, int[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } catch (AssertionError e) { int[] ref = f.apply(a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatt } catch (AssertionError e) { int[] ref = f.apply(r, a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { int[] apply(int[] a, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { + static void assertArraysEquals(int[] r, int[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { } catch (AssertionError e) { int[] ref = f.apply(a, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { int[] apply(int[] a, int[] b, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { int[] apply(int[] a, int[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { int[] apply(int[] a, int[] b, int origin, int part, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { int[] apply(int[] a, int[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } - static void assertArraysEquals(int[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(int[] a, int[] r, int offs) { - static void assertArraysEquals(int[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(int[] a, long[] r, int offs) { } } - static void assertArraysEquals(int[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1254,7 +1254,7 @@ static void ADDInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::ADD); + assertArraysEquals(r, a, b, Int256VectorTests::ADD); } static int add(int a, int b) { return (int)(a + b); @@ -1272,7 +1272,7 @@ static void addInt256VectorTests(IntFunction fa, IntFunction fb) { av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::add); + assertArraysEquals(r, a, b, Int256VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1292,7 +1292,7 @@ static void ADDInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Int256VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1310,7 +1310,7 @@ static void addInt256VectorTestsMasked(IntFunction fa, IntFunction av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int256VectorTests::add); + assertArraysEquals(r, a, b, mask, Int256VectorTests::add); } static int SUB(int a, int b) { return (int)(a - b); @@ -1330,7 +1330,7 @@ static void SUBInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::SUB); + assertArraysEquals(r, a, b, Int256VectorTests::SUB); } static int sub(int a, int b) { return (int)(a - b); @@ -1348,7 +1348,7 @@ static void subInt256VectorTests(IntFunction fa, IntFunction fb) { av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::sub); + assertArraysEquals(r, a, b, Int256VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1368,7 +1368,7 @@ static void SUBInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Int256VectorTests::SUB); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1386,7 +1386,7 @@ static void subInt256VectorTestsMasked(IntFunction fa, IntFunction av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int256VectorTests::sub); + assertArraysEquals(r, a, b, mask, Int256VectorTests::sub); } static int MUL(int a, int b) { return (int)(a * b); @@ -1406,7 +1406,7 @@ static void MULInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::MUL); + assertArraysEquals(r, a, b, Int256VectorTests::MUL); } static int mul(int a, int b) { return (int)(a * b); @@ -1424,7 +1424,7 @@ static void mulInt256VectorTests(IntFunction fa, IntFunction fb) { av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::mul); + assertArraysEquals(r, a, b, Int256VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void MULInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Int256VectorTests::MUL); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1462,7 +1462,7 @@ static void mulInt256VectorTestsMasked(IntFunction fa, IntFunction av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int256VectorTests::mul); + assertArraysEquals(r, a, b, mask, Int256VectorTests::mul); } @@ -1487,7 +1487,7 @@ static void DIVInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::DIV); + assertArraysEquals(r, a, b, Int256VectorTests::DIV); } static int div(int a, int b) { return (int)(a / b); @@ -1509,7 +1509,7 @@ static void divInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::div); + assertArraysEquals(r, a, b, Int256VectorTests::div); } @@ -1533,7 +1533,7 @@ static void DIVInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Int256VectorTests::DIV); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1555,7 +1555,7 @@ static void divInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::div); + assertArraysEquals(r, a, b, mask, Int256VectorTests::div); } static int FIRST_NONZERO(int a, int b) { @@ -1576,7 +1576,7 @@ static void FIRST_NONZEROInt256VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Int256VectorTests::FIRST_NONZERO); } static int AND(int a, int b) { @@ -1617,7 +1617,7 @@ static void ANDInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::AND); + assertArraysEquals(r, a, b, Int256VectorTests::AND); } static int and(int a, int b) { return (int)(a & b); @@ -1635,7 +1635,7 @@ static void andInt256VectorTests(IntFunction fa, IntFunction fb) { av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::and); + assertArraysEquals(r, a, b, Int256VectorTests::and); } @@ -1657,7 +1657,7 @@ static void ANDInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::AND); + assertArraysEquals(r, a, b, mask, Int256VectorTests::AND); } @@ -1679,7 +1679,7 @@ static void AND_NOTInt256VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Int256VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Int256VectorTests::AND_NOT); } @@ -1701,7 +1701,7 @@ static void AND_NOTInt256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::OR); + assertArraysEquals(r, a, b, Int256VectorTests::OR); } static int or(int a, int b) { return (int)(a | b); @@ -1741,7 +1741,7 @@ static void orInt256VectorTests(IntFunction fa, IntFunction fb) { av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::or); + assertArraysEquals(r, a, b, Int256VectorTests::or); } @@ -1763,7 +1763,7 @@ static void ORInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::OR); + assertArraysEquals(r, a, b, mask, Int256VectorTests::OR); } @@ -1785,7 +1785,7 @@ static void XORInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::XOR); + assertArraysEquals(r, a, b, Int256VectorTests::XOR); } @@ -1807,7 +1807,7 @@ static void XORInt256VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::XOR); + assertArraysEquals(r, a, b, mask, Int256VectorTests::XOR); } @@ -1822,7 +1822,7 @@ static void addInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1839,7 +1839,7 @@ static void addInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::add); } @Test(dataProvider = "intBinaryOpProvider") @@ -1853,7 +1853,7 @@ static void subInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1870,7 +1870,7 @@ static void subInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::sub); } @Test(dataProvider = "intBinaryOpProvider") @@ -1884,7 +1884,7 @@ static void mulInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void mulInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::mul); } @@ -1920,7 +1920,7 @@ static void divInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::div); } @@ -1941,7 +1941,7 @@ static void divInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::div); } @@ -1957,7 +1957,7 @@ static void ORInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::OR); } @Test(dataProvider = "intBinaryOpProvider") @@ -1971,7 +1971,7 @@ static void orInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::or); } @@ -1990,7 +1990,7 @@ static void ORInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::OR); } @@ -2006,7 +2006,7 @@ static void ANDInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::AND); } @Test(dataProvider = "intBinaryOpProvider") @@ -2020,7 +2020,7 @@ static void andInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::and); } @@ -2039,7 +2039,7 @@ static void ANDInt256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Int256VectorTests::AND); } @@ -2055,7 +2055,7 @@ static void ORInt256VectorTestsBroadcastLongSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Int256VectorTests::OR); } @@ -2074,7 +2074,7 @@ static void ORInt256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Int256VectorTests::OR); } @@ -2089,7 +2089,7 @@ static void ADDInt256VectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Int256VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -2106,7 +2106,7 @@ static void ADDInt256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Int256VectorTests::ADD); } static int LSHL(int a, int b) { @@ -2127,7 +2127,7 @@ static void LSHLInt256VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int256VectorTests::LSHL); + assertArraysEquals(r, a, b, Int256VectorTests::LSHL); } @@ -2149,7 +2149,7 @@ static void LSHLInt256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int256VectorTests::ASHR); + assertArraysEquals(r, a, b, Int256VectorTests::ASHR); } @@ -2197,7 +2197,7 @@ static void ASHRInt256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int256VectorTests::LSHR); + assertArraysEquals(r, a, b, Int256VectorTests::LSHR); } @@ -2245,7 +2245,7 @@ static void LSHRInt256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int256VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, Int256VectorTests::LSHL_unary); } @@ -2291,7 +2291,7 @@ static void LSHLInt256VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int256VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, mask, Int256VectorTests::LSHL_unary); } @@ -2316,7 +2316,7 @@ static void LSHRInt256VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int256VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, Int256VectorTests::LSHR_unary); } @@ -2337,7 +2337,7 @@ static void LSHRInt256VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int256VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int256VectorTests::LSHR_unary); } @@ -2362,7 +2362,7 @@ static void ASHRInt256VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int256VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, Int256VectorTests::ASHR_unary); } @@ -2383,7 +2383,7 @@ static void ASHRInt256VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int256VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int256VectorTests::ASHR_unary); } @@ -2408,7 +2408,7 @@ static void MINInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::MIN); + assertArraysEquals(r, a, b, Int256VectorTests::MIN); } static int min(int a, int b) { return (int)(Math.min(a, b)); @@ -2426,7 +2426,7 @@ static void minInt256VectorTests(IntFunction fa, IntFunction fb) { av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::min); + assertArraysEquals(r, a, b, Int256VectorTests::min); } static int MAX(int a, int b) { return (int)(Math.max(a, b)); @@ -2446,7 +2446,7 @@ static void MAXInt256VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int256VectorTests::MAX); + assertArraysEquals(r, a, b, Int256VectorTests::MAX); } static int max(int a, int b) { return (int)(Math.max(a, b)); @@ -2464,7 +2464,7 @@ static void maxInt256VectorTests(IntFunction fa, IntFunction fb) { av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::max); + assertArraysEquals(r, a, b, Int256VectorTests::max); } @Test(dataProvider = "intBinaryOpProvider") @@ -2478,7 +2478,7 @@ static void MINInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::MIN); } @Test(dataProvider = "intBinaryOpProvider") @@ -2492,7 +2492,7 @@ static void minInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::min); } @Test(dataProvider = "intBinaryOpProvider") @@ -2506,7 +2506,7 @@ static void MAXInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::MAX); } @Test(dataProvider = "intBinaryOpProvider") @@ -2520,7 +2520,7 @@ static void maxInt256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Int256VectorTests::max); } static int ANDReduce(int[] a, int idx) { @@ -2563,7 +2563,7 @@ static void ANDReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::ANDReduce, Int256VectorTests::ANDReduceAll); } @@ -2611,7 +2611,7 @@ static void ANDReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::ANDReduceMasked, Int256VectorTests::ANDReduceAllMasked); } @@ -2656,7 +2656,7 @@ static void ORReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::ORReduce, Int256VectorTests::ORReduceAll); } @@ -2704,7 +2704,7 @@ static void ORReduceInt256VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::XORReduce, Int256VectorTests::XORReduceAll); } @@ -2797,7 +2797,7 @@ static void XORReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::XORReduceMasked, Int256VectorTests::XORReduceAllMasked); } @@ -2839,7 +2839,7 @@ static void ADDReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::ADDReduce, Int256VectorTests::ADDReduceAll); } static int ADDReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2883,7 +2883,7 @@ static void ADDReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::ADDReduceMasked, Int256VectorTests::ADDReduceAllMasked); } static int MULReduce(int[] a, int idx) { @@ -2924,7 +2924,7 @@ static void MULReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::MULReduce, Int256VectorTests::MULReduceAll); } static int MULReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2968,7 +2968,7 @@ static void MULReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::MULReduceMasked, Int256VectorTests::MULReduceAllMasked); } static int MINReduce(int[] a, int idx) { @@ -3009,7 +3009,7 @@ static void MINReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::MINReduce, Int256VectorTests::MINReduceAll); } static int MINReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3054,7 +3054,7 @@ static void MINReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::MINReduceMasked, Int256VectorTests::MINReduceAllMasked); } static int MAXReduce(int[] a, int idx) { @@ -3095,7 +3095,7 @@ static void MAXReduceInt256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int256VectorTests::MAXReduce, Int256VectorTests::MAXReduceAll); } static int MAXReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3140,7 +3140,7 @@ static void MAXReduceInt256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::MAXReduceMasked, Int256VectorTests::MAXReduceAllMasked); } @@ -3166,7 +3166,7 @@ static void anyTrueInt256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int256VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Int256VectorTests::anyTrue); } @@ -3192,7 +3192,7 @@ static void allTrueInt256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int256VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Int256VectorTests::allTrue); } @@ -3208,7 +3208,7 @@ static void withInt256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (int)4, 0); + assertInsertArraysEquals(r, a, (int)4, 0); } static boolean testIS_DEFAULT(int a) { return bits(a)==0; @@ -3757,7 +3757,7 @@ static void blendInt256VectorTests(IntFunction fa, IntFunction fb, } } - assertArraysEquals(a, b, r, mask, Int256VectorTests::blend); + assertArraysEquals(r, a, b, mask, Int256VectorTests::blend); } @Test(dataProvider = "intUnaryOpShuffleProvider") @@ -3774,7 +3774,7 @@ static void RearrangeInt256VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -3792,7 +3792,7 @@ static void RearrangeInt256VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "intUnaryOpProvider") static void getInt256VectorTests(IntFunction fa) { @@ -3947,7 +3947,7 @@ static void getInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::get); + assertArraysEquals(r, a, Int256VectorTests::get); } @Test(dataProvider = "intUnaryOpProvider") @@ -3961,7 +3961,7 @@ static void BroadcastInt256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4008,7 +4008,7 @@ static void sliceUnaryInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Int256VectorTests::sliceUnary); } static int[] sliceBinary(int[] a, int[] b, int origin, int idx) { int[] res = new int[SPECIES.length()]; @@ -4037,7 +4037,7 @@ static void sliceBinaryInt256VectorTestsBinary(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, Int256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Int256VectorTests::sliceBinary); } static int[] slice(int[] a, int[] b, int origin, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4070,7 +4070,7 @@ static void sliceInt256VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Int256VectorTests::unsliceUnary); } static int[] unsliceBinary(int[] a, int[] b, int origin, int part, int idx) { int[] res = new int[SPECIES.length()]; @@ -4136,7 +4136,7 @@ static void unsliceBinaryInt256VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, Int256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Int256VectorTests::unsliceBinary); } static int[] unslice(int[] a, int[] b, int origin, int part, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4192,7 +4192,7 @@ static void unsliceInt256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4257,7 +4257,7 @@ static void bitwiseBlendInt256VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, c, r, mask, Int256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Int256VectorTests::BITWISE_BLEND); } @@ -4298,7 +4298,7 @@ static void BITWISE_BLENDInt256VectorTestsBroadcastSmokeTest(IntFunction IntVector bv = IntVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int256VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Int256VectorTests::BITWISE_BLEND); } @Test(dataProvider = "intTernaryOpProvider") @@ -4313,7 +4313,7 @@ static void BITWISE_BLENDInt256VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4327,7 +4327,7 @@ static void bitwiseBlendInt256VectorTestsBroadcastSmokeTest(IntFunction f IntVector bv = IntVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int256VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Int256VectorTests::bitwiseBlend); } @Test(dataProvider = "intTernaryOpProvider") @@ -4342,7 +4342,7 @@ static void bitwiseBlendInt256VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4413,7 +4413,7 @@ static void bitwiseBlendInt256VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::NEG); + assertArraysEquals(r, a, Int256VectorTests::NEG); } @Test(dataProvider = "intUnaryOpProvider") @@ -4471,7 +4471,7 @@ static void negInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::neg); + assertArraysEquals(r, a, Int256VectorTests::neg); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4489,7 +4489,7 @@ static void NEGMaskedInt256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int256VectorTests::NEG); + assertArraysEquals(r, a, mask, Int256VectorTests::NEG); } static int ABS(int a) { @@ -4512,7 +4512,7 @@ static void ABSInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::ABS); + assertArraysEquals(r, a, Int256VectorTests::ABS); } @Test(dataProvider = "intUnaryOpProvider") @@ -4527,7 +4527,7 @@ static void absInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::abs); + assertArraysEquals(r, a, Int256VectorTests::abs); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4545,7 +4545,7 @@ static void ABSMaskedInt256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int256VectorTests::ABS); + assertArraysEquals(r, a, mask, Int256VectorTests::ABS); } @@ -4571,7 +4571,7 @@ static void NOTInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::NOT); + assertArraysEquals(r, a, Int256VectorTests::NOT); } @Test(dataProvider = "intUnaryOpProvider") @@ -4586,7 +4586,7 @@ static void notInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::not); + assertArraysEquals(r, a, Int256VectorTests::not); } @@ -4606,7 +4606,7 @@ static void NOTMaskedInt256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int256VectorTests::NOT); + assertArraysEquals(r, a, mask, Int256VectorTests::NOT); } @@ -4629,7 +4629,7 @@ static void ZOMOInt256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int256VectorTests::ZOMO); + assertArraysEquals(r, a, Int256VectorTests::ZOMO); } @@ -4649,7 +4649,7 @@ static void ZOMOMaskedInt256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int256VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Int256VectorTests::ZOMO); } @@ -4677,7 +4677,7 @@ static void gatherInt256VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4821,8 +4821,8 @@ static void toLongArrayInt256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4832,8 +4832,8 @@ static void toDoubleArrayInt256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4899,7 +4899,7 @@ static void ADDReduceLongInt256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Int256VectorTests::ADDReduceLong, Int256VectorTests::ADDReduceAllLong); } @@ -4940,7 +4940,7 @@ static void ADDReduceLongInt256VectorTestsMasked(IntFunction fa, IntFunct ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Int256VectorTests::ADDReduceLongMasked, Int256VectorTests::ADDReduceAllLongMasked); } @@ -4952,7 +4952,7 @@ static void BroadcastLongInt256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -4970,7 +4970,7 @@ static void blendInt256VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Int256VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Int256VectorTests::blend); } @@ -4987,7 +4987,7 @@ static void SelectFromInt256VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -5006,7 +5006,7 @@ static void SelectFromInt256VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5083,7 +5083,7 @@ static void maskEqInt256VectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Int256VectorTests::beq); + assertArraysEquals(r, a, b, Int256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Int512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Int512VectorLoadStoreTests.java index 1c1b076d0e864..d0ed4682c1dc5 100644 --- a/test/jdk/jdk/incubator/vector/Int512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Int512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Int512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(int[] a, int[] r, boolean[] mask) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0, "at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(int[] a, int[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "intProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new int[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Int512VectorTests.java b/test/jdk/jdk/incubator/vector/Int512VectorTests.java index 3033460ed8f88..943cb444ec5aa 100644 --- a/test/jdk/jdk/incubator/vector/Int512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Int512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { int apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { int[] apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { } catch (AssertionError e) { int[] ref = f.apply(a[i]); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { int apply(int[] a); } - static void assertReductionArraysEquals(int[] a, int[] b, int c, + static void assertReductionArraysEquals(int[] r, int rc, int[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { int apply(int[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(int[] a, int[] b, int c, boolean[] mask, + static void assertReductionArraysEqualsMasked(int[] r, int rc, int[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(int[] a); } - static void assertReductionLongArraysEquals(int[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, int[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(int[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(int[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, int[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(int[] a, int[] b, int element, int index) { + static void assertInsertArraysEquals(int[] r, int[] a, int element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vecto } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vect } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[ } } - static void assertBroadcastArraysEquals(int[]a, int[]r) { + static void assertBroadcastArraysEquals(int[] r, int[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMa } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mas } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTer } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, F } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, bool } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, b } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { int apply(int[] a, int b); } - static void assertArraysEquals(int[] a, int[] r, FBinArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { int[] apply(int[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, FGatherScatterOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { int[] apply(int[] r, int[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } catch (AssertionError e) { int[] ref = f.apply(a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatt } catch (AssertionError e) { int[] ref = f.apply(r, a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { int[] apply(int[] a, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { + static void assertArraysEquals(int[] r, int[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { } catch (AssertionError e) { int[] ref = f.apply(a, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { int[] apply(int[] a, int[] b, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { int[] apply(int[] a, int[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { int[] apply(int[] a, int[] b, int origin, int part, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { int[] apply(int[] a, int[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } - static void assertArraysEquals(int[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(int[] a, int[] r, int offs) { - static void assertArraysEquals(int[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(int[] a, long[] r, int offs) { } } - static void assertArraysEquals(int[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1254,7 +1254,7 @@ static void ADDInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::ADD); + assertArraysEquals(r, a, b, Int512VectorTests::ADD); } static int add(int a, int b) { return (int)(a + b); @@ -1272,7 +1272,7 @@ static void addInt512VectorTests(IntFunction fa, IntFunction fb) { av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::add); + assertArraysEquals(r, a, b, Int512VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1292,7 +1292,7 @@ static void ADDInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Int512VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1310,7 +1310,7 @@ static void addInt512VectorTestsMasked(IntFunction fa, IntFunction av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int512VectorTests::add); + assertArraysEquals(r, a, b, mask, Int512VectorTests::add); } static int SUB(int a, int b) { return (int)(a - b); @@ -1330,7 +1330,7 @@ static void SUBInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::SUB); + assertArraysEquals(r, a, b, Int512VectorTests::SUB); } static int sub(int a, int b) { return (int)(a - b); @@ -1348,7 +1348,7 @@ static void subInt512VectorTests(IntFunction fa, IntFunction fb) { av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::sub); + assertArraysEquals(r, a, b, Int512VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1368,7 +1368,7 @@ static void SUBInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Int512VectorTests::SUB); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1386,7 +1386,7 @@ static void subInt512VectorTestsMasked(IntFunction fa, IntFunction av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int512VectorTests::sub); + assertArraysEquals(r, a, b, mask, Int512VectorTests::sub); } static int MUL(int a, int b) { return (int)(a * b); @@ -1406,7 +1406,7 @@ static void MULInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::MUL); + assertArraysEquals(r, a, b, Int512VectorTests::MUL); } static int mul(int a, int b) { return (int)(a * b); @@ -1424,7 +1424,7 @@ static void mulInt512VectorTests(IntFunction fa, IntFunction fb) { av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::mul); + assertArraysEquals(r, a, b, Int512VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void MULInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Int512VectorTests::MUL); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1462,7 +1462,7 @@ static void mulInt512VectorTestsMasked(IntFunction fa, IntFunction av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int512VectorTests::mul); + assertArraysEquals(r, a, b, mask, Int512VectorTests::mul); } @@ -1487,7 +1487,7 @@ static void DIVInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::DIV); + assertArraysEquals(r, a, b, Int512VectorTests::DIV); } static int div(int a, int b) { return (int)(a / b); @@ -1509,7 +1509,7 @@ static void divInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::div); + assertArraysEquals(r, a, b, Int512VectorTests::div); } @@ -1533,7 +1533,7 @@ static void DIVInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Int512VectorTests::DIV); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1555,7 +1555,7 @@ static void divInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::div); + assertArraysEquals(r, a, b, mask, Int512VectorTests::div); } static int FIRST_NONZERO(int a, int b) { @@ -1576,7 +1576,7 @@ static void FIRST_NONZEROInt512VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Int512VectorTests::FIRST_NONZERO); } static int AND(int a, int b) { @@ -1617,7 +1617,7 @@ static void ANDInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::AND); + assertArraysEquals(r, a, b, Int512VectorTests::AND); } static int and(int a, int b) { return (int)(a & b); @@ -1635,7 +1635,7 @@ static void andInt512VectorTests(IntFunction fa, IntFunction fb) { av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::and); + assertArraysEquals(r, a, b, Int512VectorTests::and); } @@ -1657,7 +1657,7 @@ static void ANDInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::AND); + assertArraysEquals(r, a, b, mask, Int512VectorTests::AND); } @@ -1679,7 +1679,7 @@ static void AND_NOTInt512VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Int512VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Int512VectorTests::AND_NOT); } @@ -1701,7 +1701,7 @@ static void AND_NOTInt512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::OR); + assertArraysEquals(r, a, b, Int512VectorTests::OR); } static int or(int a, int b) { return (int)(a | b); @@ -1741,7 +1741,7 @@ static void orInt512VectorTests(IntFunction fa, IntFunction fb) { av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::or); + assertArraysEquals(r, a, b, Int512VectorTests::or); } @@ -1763,7 +1763,7 @@ static void ORInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::OR); + assertArraysEquals(r, a, b, mask, Int512VectorTests::OR); } @@ -1785,7 +1785,7 @@ static void XORInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::XOR); + assertArraysEquals(r, a, b, Int512VectorTests::XOR); } @@ -1807,7 +1807,7 @@ static void XORInt512VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::XOR); + assertArraysEquals(r, a, b, mask, Int512VectorTests::XOR); } @@ -1822,7 +1822,7 @@ static void addInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1839,7 +1839,7 @@ static void addInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::add); } @Test(dataProvider = "intBinaryOpProvider") @@ -1853,7 +1853,7 @@ static void subInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1870,7 +1870,7 @@ static void subInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::sub); } @Test(dataProvider = "intBinaryOpProvider") @@ -1884,7 +1884,7 @@ static void mulInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void mulInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::mul); } @@ -1920,7 +1920,7 @@ static void divInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::div); } @@ -1941,7 +1941,7 @@ static void divInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::div); } @@ -1957,7 +1957,7 @@ static void ORInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::OR); } @Test(dataProvider = "intBinaryOpProvider") @@ -1971,7 +1971,7 @@ static void orInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::or); } @@ -1990,7 +1990,7 @@ static void ORInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::OR); } @@ -2006,7 +2006,7 @@ static void ANDInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::AND); } @Test(dataProvider = "intBinaryOpProvider") @@ -2020,7 +2020,7 @@ static void andInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::and); } @@ -2039,7 +2039,7 @@ static void ANDInt512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Int512VectorTests::AND); } @@ -2055,7 +2055,7 @@ static void ORInt512VectorTestsBroadcastLongSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Int512VectorTests::OR); } @@ -2074,7 +2074,7 @@ static void ORInt512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Int512VectorTests::OR); } @@ -2089,7 +2089,7 @@ static void ADDInt512VectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Int512VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -2106,7 +2106,7 @@ static void ADDInt512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Int512VectorTests::ADD); } static int LSHL(int a, int b) { @@ -2127,7 +2127,7 @@ static void LSHLInt512VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int512VectorTests::LSHL); + assertArraysEquals(r, a, b, Int512VectorTests::LSHL); } @@ -2149,7 +2149,7 @@ static void LSHLInt512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int512VectorTests::ASHR); + assertArraysEquals(r, a, b, Int512VectorTests::ASHR); } @@ -2197,7 +2197,7 @@ static void ASHRInt512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Int512VectorTests::LSHR); + assertArraysEquals(r, a, b, Int512VectorTests::LSHR); } @@ -2245,7 +2245,7 @@ static void LSHRInt512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int512VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, Int512VectorTests::LSHL_unary); } @@ -2291,7 +2291,7 @@ static void LSHLInt512VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int512VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, mask, Int512VectorTests::LSHL_unary); } @@ -2316,7 +2316,7 @@ static void LSHRInt512VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int512VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, Int512VectorTests::LSHR_unary); } @@ -2337,7 +2337,7 @@ static void LSHRInt512VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int512VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int512VectorTests::LSHR_unary); } @@ -2362,7 +2362,7 @@ static void ASHRInt512VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int512VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, Int512VectorTests::ASHR_unary); } @@ -2383,7 +2383,7 @@ static void ASHRInt512VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int512VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int512VectorTests::ASHR_unary); } @@ -2408,7 +2408,7 @@ static void MINInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::MIN); + assertArraysEquals(r, a, b, Int512VectorTests::MIN); } static int min(int a, int b) { return (int)(Math.min(a, b)); @@ -2426,7 +2426,7 @@ static void minInt512VectorTests(IntFunction fa, IntFunction fb) { av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::min); + assertArraysEquals(r, a, b, Int512VectorTests::min); } static int MAX(int a, int b) { return (int)(Math.max(a, b)); @@ -2446,7 +2446,7 @@ static void MAXInt512VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int512VectorTests::MAX); + assertArraysEquals(r, a, b, Int512VectorTests::MAX); } static int max(int a, int b) { return (int)(Math.max(a, b)); @@ -2464,7 +2464,7 @@ static void maxInt512VectorTests(IntFunction fa, IntFunction fb) { av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::max); + assertArraysEquals(r, a, b, Int512VectorTests::max); } @Test(dataProvider = "intBinaryOpProvider") @@ -2478,7 +2478,7 @@ static void MINInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::MIN); } @Test(dataProvider = "intBinaryOpProvider") @@ -2492,7 +2492,7 @@ static void minInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::min); } @Test(dataProvider = "intBinaryOpProvider") @@ -2506,7 +2506,7 @@ static void MAXInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::MAX); } @Test(dataProvider = "intBinaryOpProvider") @@ -2520,7 +2520,7 @@ static void maxInt512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Int512VectorTests::max); } static int ANDReduce(int[] a, int idx) { @@ -2563,7 +2563,7 @@ static void ANDReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::ANDReduce, Int512VectorTests::ANDReduceAll); } @@ -2611,7 +2611,7 @@ static void ANDReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::ANDReduceMasked, Int512VectorTests::ANDReduceAllMasked); } @@ -2656,7 +2656,7 @@ static void ORReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::ORReduce, Int512VectorTests::ORReduceAll); } @@ -2704,7 +2704,7 @@ static void ORReduceInt512VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::XORReduce, Int512VectorTests::XORReduceAll); } @@ -2797,7 +2797,7 @@ static void XORReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::XORReduceMasked, Int512VectorTests::XORReduceAllMasked); } @@ -2839,7 +2839,7 @@ static void ADDReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::ADDReduce, Int512VectorTests::ADDReduceAll); } static int ADDReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2883,7 +2883,7 @@ static void ADDReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::ADDReduceMasked, Int512VectorTests::ADDReduceAllMasked); } static int MULReduce(int[] a, int idx) { @@ -2924,7 +2924,7 @@ static void MULReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::MULReduce, Int512VectorTests::MULReduceAll); } static int MULReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2968,7 +2968,7 @@ static void MULReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::MULReduceMasked, Int512VectorTests::MULReduceAllMasked); } static int MINReduce(int[] a, int idx) { @@ -3009,7 +3009,7 @@ static void MINReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::MINReduce, Int512VectorTests::MINReduceAll); } static int MINReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3054,7 +3054,7 @@ static void MINReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::MINReduceMasked, Int512VectorTests::MINReduceAllMasked); } static int MAXReduce(int[] a, int idx) { @@ -3095,7 +3095,7 @@ static void MAXReduceInt512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int512VectorTests::MAXReduce, Int512VectorTests::MAXReduceAll); } static int MAXReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3140,7 +3140,7 @@ static void MAXReduceInt512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::MAXReduceMasked, Int512VectorTests::MAXReduceAllMasked); } @@ -3166,7 +3166,7 @@ static void anyTrueInt512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int512VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Int512VectorTests::anyTrue); } @@ -3192,7 +3192,7 @@ static void allTrueInt512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int512VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Int512VectorTests::allTrue); } @@ -3208,7 +3208,7 @@ static void withInt512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (int)4, 0); + assertInsertArraysEquals(r, a, (int)4, 0); } static boolean testIS_DEFAULT(int a) { return bits(a)==0; @@ -3757,7 +3757,7 @@ static void blendInt512VectorTests(IntFunction fa, IntFunction fb, } } - assertArraysEquals(a, b, r, mask, Int512VectorTests::blend); + assertArraysEquals(r, a, b, mask, Int512VectorTests::blend); } @Test(dataProvider = "intUnaryOpShuffleProvider") @@ -3774,7 +3774,7 @@ static void RearrangeInt512VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -3792,7 +3792,7 @@ static void RearrangeInt512VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "intUnaryOpProvider") static void getInt512VectorTests(IntFunction fa) { @@ -3947,7 +3947,7 @@ static void getInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::get); + assertArraysEquals(r, a, Int512VectorTests::get); } @Test(dataProvider = "intUnaryOpProvider") @@ -3961,7 +3961,7 @@ static void BroadcastInt512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4008,7 +4008,7 @@ static void sliceUnaryInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Int512VectorTests::sliceUnary); } static int[] sliceBinary(int[] a, int[] b, int origin, int idx) { int[] res = new int[SPECIES.length()]; @@ -4037,7 +4037,7 @@ static void sliceBinaryInt512VectorTestsBinary(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, Int512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Int512VectorTests::sliceBinary); } static int[] slice(int[] a, int[] b, int origin, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4070,7 +4070,7 @@ static void sliceInt512VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Int512VectorTests::unsliceUnary); } static int[] unsliceBinary(int[] a, int[] b, int origin, int part, int idx) { int[] res = new int[SPECIES.length()]; @@ -4136,7 +4136,7 @@ static void unsliceBinaryInt512VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, Int512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Int512VectorTests::unsliceBinary); } static int[] unslice(int[] a, int[] b, int origin, int part, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4192,7 +4192,7 @@ static void unsliceInt512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4257,7 +4257,7 @@ static void bitwiseBlendInt512VectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, c, r, mask, Int512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Int512VectorTests::BITWISE_BLEND); } @@ -4298,7 +4298,7 @@ static void BITWISE_BLENDInt512VectorTestsBroadcastSmokeTest(IntFunction IntVector bv = IntVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int512VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Int512VectorTests::BITWISE_BLEND); } @Test(dataProvider = "intTernaryOpProvider") @@ -4313,7 +4313,7 @@ static void BITWISE_BLENDInt512VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4327,7 +4327,7 @@ static void bitwiseBlendInt512VectorTestsBroadcastSmokeTest(IntFunction f IntVector bv = IntVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int512VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Int512VectorTests::bitwiseBlend); } @Test(dataProvider = "intTernaryOpProvider") @@ -4342,7 +4342,7 @@ static void bitwiseBlendInt512VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4413,7 +4413,7 @@ static void bitwiseBlendInt512VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::NEG); + assertArraysEquals(r, a, Int512VectorTests::NEG); } @Test(dataProvider = "intUnaryOpProvider") @@ -4471,7 +4471,7 @@ static void negInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::neg); + assertArraysEquals(r, a, Int512VectorTests::neg); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4489,7 +4489,7 @@ static void NEGMaskedInt512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int512VectorTests::NEG); + assertArraysEquals(r, a, mask, Int512VectorTests::NEG); } static int ABS(int a) { @@ -4512,7 +4512,7 @@ static void ABSInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::ABS); + assertArraysEquals(r, a, Int512VectorTests::ABS); } @Test(dataProvider = "intUnaryOpProvider") @@ -4527,7 +4527,7 @@ static void absInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::abs); + assertArraysEquals(r, a, Int512VectorTests::abs); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4545,7 +4545,7 @@ static void ABSMaskedInt512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int512VectorTests::ABS); + assertArraysEquals(r, a, mask, Int512VectorTests::ABS); } @@ -4571,7 +4571,7 @@ static void NOTInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::NOT); + assertArraysEquals(r, a, Int512VectorTests::NOT); } @Test(dataProvider = "intUnaryOpProvider") @@ -4586,7 +4586,7 @@ static void notInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::not); + assertArraysEquals(r, a, Int512VectorTests::not); } @@ -4606,7 +4606,7 @@ static void NOTMaskedInt512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int512VectorTests::NOT); + assertArraysEquals(r, a, mask, Int512VectorTests::NOT); } @@ -4629,7 +4629,7 @@ static void ZOMOInt512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int512VectorTests::ZOMO); + assertArraysEquals(r, a, Int512VectorTests::ZOMO); } @@ -4649,7 +4649,7 @@ static void ZOMOMaskedInt512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int512VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Int512VectorTests::ZOMO); } @@ -4677,7 +4677,7 @@ static void gatherInt512VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4821,8 +4821,8 @@ static void toLongArrayInt512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4832,8 +4832,8 @@ static void toDoubleArrayInt512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4899,7 +4899,7 @@ static void ADDReduceLongInt512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Int512VectorTests::ADDReduceLong, Int512VectorTests::ADDReduceAllLong); } @@ -4940,7 +4940,7 @@ static void ADDReduceLongInt512VectorTestsMasked(IntFunction fa, IntFunct ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Int512VectorTests::ADDReduceLongMasked, Int512VectorTests::ADDReduceAllLongMasked); } @@ -4952,7 +4952,7 @@ static void BroadcastLongInt512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -4970,7 +4970,7 @@ static void blendInt512VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Int512VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Int512VectorTests::blend); } @@ -4987,7 +4987,7 @@ static void SelectFromInt512VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -5006,7 +5006,7 @@ static void SelectFromInt512VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5083,7 +5083,7 @@ static void maskEqInt512VectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Int512VectorTests::beq); + assertArraysEquals(r, a, b, Int512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Int64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Int64VectorLoadStoreTests.java index 8878425b25d25..c17b8591dd328 100644 --- a/test/jdk/jdk/incubator/vector/Int64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Int64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Int64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(int[] a, int[] r, boolean[] mask) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0, "at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(int[] a, int[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "intProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new int[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Int64VectorTests.java b/test/jdk/jdk/incubator/vector/Int64VectorTests.java index 5861a039da195..9a3a9541423a0 100644 --- a/test/jdk/jdk/incubator/vector/Int64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Int64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { int apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { int[] apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { } catch (AssertionError e) { int[] ref = f.apply(a[i]); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { int apply(int[] a); } - static void assertReductionArraysEquals(int[] a, int[] b, int c, + static void assertReductionArraysEquals(int[] r, int rc, int[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { int apply(int[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(int[] a, int[] b, int c, boolean[] mask, + static void assertReductionArraysEqualsMasked(int[] r, int rc, int[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(int[] a); } - static void assertReductionLongArraysEquals(int[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, int[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(int[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(int[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, int[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(int[] a, int[] b, int element, int index) { + static void assertInsertArraysEquals(int[] r, int[] a, int element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vecto } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vect } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[ } } - static void assertBroadcastArraysEquals(int[]a, int[]r) { + static void assertBroadcastArraysEquals(int[] r, int[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMa } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mas } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTer } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, F } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, bool } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, b } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { int apply(int[] a, int b); } - static void assertArraysEquals(int[] a, int[] r, FBinArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { int[] apply(int[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, FGatherScatterOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { int[] apply(int[] r, int[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } catch (AssertionError e) { int[] ref = f.apply(a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatt } catch (AssertionError e) { int[] ref = f.apply(r, a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { int[] apply(int[] a, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { + static void assertArraysEquals(int[] r, int[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { } catch (AssertionError e) { int[] ref = f.apply(a, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { int[] apply(int[] a, int[] b, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { int[] apply(int[] a, int[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { int[] apply(int[] a, int[] b, int origin, int part, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { int[] apply(int[] a, int[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } - static void assertArraysEquals(int[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(int[] a, int[] r, int offs) { - static void assertArraysEquals(int[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(int[] a, long[] r, int offs) { } } - static void assertArraysEquals(int[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1254,7 +1254,7 @@ static void ADDInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::ADD); + assertArraysEquals(r, a, b, Int64VectorTests::ADD); } static int add(int a, int b) { return (int)(a + b); @@ -1272,7 +1272,7 @@ static void addInt64VectorTests(IntFunction fa, IntFunction fb) { av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::add); + assertArraysEquals(r, a, b, Int64VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1292,7 +1292,7 @@ static void ADDInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::ADD); + assertArraysEquals(r, a, b, mask, Int64VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1310,7 +1310,7 @@ static void addInt64VectorTestsMasked(IntFunction fa, IntFunction av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int64VectorTests::add); + assertArraysEquals(r, a, b, mask, Int64VectorTests::add); } static int SUB(int a, int b) { return (int)(a - b); @@ -1330,7 +1330,7 @@ static void SUBInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::SUB); + assertArraysEquals(r, a, b, Int64VectorTests::SUB); } static int sub(int a, int b) { return (int)(a - b); @@ -1348,7 +1348,7 @@ static void subInt64VectorTests(IntFunction fa, IntFunction fb) { av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::sub); + assertArraysEquals(r, a, b, Int64VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1368,7 +1368,7 @@ static void SUBInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::SUB); + assertArraysEquals(r, a, b, mask, Int64VectorTests::SUB); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1386,7 +1386,7 @@ static void subInt64VectorTestsMasked(IntFunction fa, IntFunction av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int64VectorTests::sub); + assertArraysEquals(r, a, b, mask, Int64VectorTests::sub); } static int MUL(int a, int b) { return (int)(a * b); @@ -1406,7 +1406,7 @@ static void MULInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::MUL); + assertArraysEquals(r, a, b, Int64VectorTests::MUL); } static int mul(int a, int b) { return (int)(a * b); @@ -1424,7 +1424,7 @@ static void mulInt64VectorTests(IntFunction fa, IntFunction fb) { av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::mul); + assertArraysEquals(r, a, b, Int64VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1444,7 +1444,7 @@ static void MULInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::MUL); + assertArraysEquals(r, a, b, mask, Int64VectorTests::MUL); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1462,7 +1462,7 @@ static void mulInt64VectorTestsMasked(IntFunction fa, IntFunction av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, Int64VectorTests::mul); + assertArraysEquals(r, a, b, mask, Int64VectorTests::mul); } @@ -1487,7 +1487,7 @@ static void DIVInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::DIV); + assertArraysEquals(r, a, b, Int64VectorTests::DIV); } static int div(int a, int b) { return (int)(a / b); @@ -1509,7 +1509,7 @@ static void divInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::div); + assertArraysEquals(r, a, b, Int64VectorTests::div); } @@ -1533,7 +1533,7 @@ static void DIVInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::DIV); + assertArraysEquals(r, a, b, mask, Int64VectorTests::DIV); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1555,7 +1555,7 @@ static void divInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::div); + assertArraysEquals(r, a, b, mask, Int64VectorTests::div); } static int FIRST_NONZERO(int a, int b) { @@ -1576,7 +1576,7 @@ static void FIRST_NONZEROInt64VectorTests(IntFunction fa, IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Int64VectorTests::FIRST_NONZERO); } static int AND(int a, int b) { @@ -1617,7 +1617,7 @@ static void ANDInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::AND); + assertArraysEquals(r, a, b, Int64VectorTests::AND); } static int and(int a, int b) { return (int)(a & b); @@ -1635,7 +1635,7 @@ static void andInt64VectorTests(IntFunction fa, IntFunction fb) { av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::and); + assertArraysEquals(r, a, b, Int64VectorTests::and); } @@ -1657,7 +1657,7 @@ static void ANDInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::AND); + assertArraysEquals(r, a, b, mask, Int64VectorTests::AND); } @@ -1679,7 +1679,7 @@ static void AND_NOTInt64VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Int64VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Int64VectorTests::AND_NOT); } @@ -1701,7 +1701,7 @@ static void AND_NOTInt64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::OR); + assertArraysEquals(r, a, b, Int64VectorTests::OR); } static int or(int a, int b) { return (int)(a | b); @@ -1741,7 +1741,7 @@ static void orInt64VectorTests(IntFunction fa, IntFunction fb) { av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::or); + assertArraysEquals(r, a, b, Int64VectorTests::or); } @@ -1763,7 +1763,7 @@ static void ORInt64VectorTestsMasked(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::OR); + assertArraysEquals(r, a, b, mask, Int64VectorTests::OR); } @@ -1785,7 +1785,7 @@ static void XORInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::XOR); + assertArraysEquals(r, a, b, Int64VectorTests::XOR); } @@ -1807,7 +1807,7 @@ static void XORInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::XOR); + assertArraysEquals(r, a, b, mask, Int64VectorTests::XOR); } @@ -1822,7 +1822,7 @@ static void addInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1839,7 +1839,7 @@ static void addInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::add); } @Test(dataProvider = "intBinaryOpProvider") @@ -1853,7 +1853,7 @@ static void subInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1870,7 +1870,7 @@ static void subInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::sub); } @Test(dataProvider = "intBinaryOpProvider") @@ -1884,7 +1884,7 @@ static void mulInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1901,7 +1901,7 @@ static void mulInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::mul); } @@ -1920,7 +1920,7 @@ static void divInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::div); } @@ -1941,7 +1941,7 @@ static void divInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::div); } @@ -1957,7 +1957,7 @@ static void ORInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunct av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::OR); } @Test(dataProvider = "intBinaryOpProvider") @@ -1971,7 +1971,7 @@ static void orInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunct av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::or); } @@ -1990,7 +1990,7 @@ static void ORInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::OR); } @@ -2006,7 +2006,7 @@ static void ANDInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::AND); } @Test(dataProvider = "intBinaryOpProvider") @@ -2020,7 +2020,7 @@ static void andInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::and); } @@ -2039,7 +2039,7 @@ static void ANDInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Int64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Int64VectorTests::AND); } @@ -2055,7 +2055,7 @@ static void ORInt64VectorTestsBroadcastLongSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Int64VectorTests::OR); } @@ -2074,7 +2074,7 @@ static void ORInt64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Int64VectorTests::OR); } @@ -2089,7 +2089,7 @@ static void ADDInt64VectorTestsBroadcastLongSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Int64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Int64VectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -2106,7 +2106,7 @@ static void ADDInt64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction f av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Int64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Int64VectorTests::ADD); } static int LSHL(int a, int b) { @@ -2127,7 +2127,7 @@ static void LSHLInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::LSHL); + assertArraysEquals(r, a, b, Int64VectorTests::LSHL); } @@ -2149,7 +2149,7 @@ static void LSHLInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::LSHL); + assertArraysEquals(r, a, b, mask, Int64VectorTests::LSHL); } @@ -2175,7 +2175,7 @@ static void ASHRInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::ASHR); + assertArraysEquals(r, a, b, Int64VectorTests::ASHR); } @@ -2197,7 +2197,7 @@ static void ASHRInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::ASHR); + assertArraysEquals(r, a, b, mask, Int64VectorTests::ASHR); } @@ -2223,7 +2223,7 @@ static void LSHRInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::LSHR); + assertArraysEquals(r, a, b, Int64VectorTests::LSHR); } @@ -2245,7 +2245,7 @@ static void LSHRInt64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::LSHR); + assertArraysEquals(r, a, b, mask, Int64VectorTests::LSHR); } @@ -2270,7 +2270,7 @@ static void LSHLInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int64VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, Int64VectorTests::LSHL_unary); } @@ -2291,7 +2291,7 @@ static void LSHLInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int64VectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, mask, Int64VectorTests::LSHL_unary); } @@ -2316,7 +2316,7 @@ static void LSHRInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int64VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, Int64VectorTests::LSHR_unary); } @@ -2337,7 +2337,7 @@ static void LSHRInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int64VectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int64VectorTests::LSHR_unary); } @@ -2362,7 +2362,7 @@ static void ASHRInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, Int64VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, Int64VectorTests::ASHR_unary); } @@ -2383,7 +2383,7 @@ static void ASHRInt64VectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, Int64VectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, mask, Int64VectorTests::ASHR_unary); } @@ -2408,7 +2408,7 @@ static void MINInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::MIN); + assertArraysEquals(r, a, b, Int64VectorTests::MIN); } static int min(int a, int b) { return (int)(Math.min(a, b)); @@ -2426,7 +2426,7 @@ static void minInt64VectorTests(IntFunction fa, IntFunction fb) { av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::min); + assertArraysEquals(r, a, b, Int64VectorTests::min); } static int MAX(int a, int b) { return (int)(Math.max(a, b)); @@ -2446,7 +2446,7 @@ static void MAXInt64VectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, Int64VectorTests::MAX); + assertArraysEquals(r, a, b, Int64VectorTests::MAX); } static int max(int a, int b) { return (int)(Math.max(a, b)); @@ -2464,7 +2464,7 @@ static void maxInt64VectorTests(IntFunction fa, IntFunction fb) { av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::max); + assertArraysEquals(r, a, b, Int64VectorTests::max); } @Test(dataProvider = "intBinaryOpProvider") @@ -2478,7 +2478,7 @@ static void MINInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::MIN); } @Test(dataProvider = "intBinaryOpProvider") @@ -2492,7 +2492,7 @@ static void minInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::min); } @Test(dataProvider = "intBinaryOpProvider") @@ -2506,7 +2506,7 @@ static void MAXInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::MAX); } @Test(dataProvider = "intBinaryOpProvider") @@ -2520,7 +2520,7 @@ static void maxInt64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Int64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Int64VectorTests::max); } static int ANDReduce(int[] a, int idx) { @@ -2563,7 +2563,7 @@ static void ANDReduceInt64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::ANDReduce, Int64VectorTests::ANDReduceAll); } @@ -2611,7 +2611,7 @@ static void ANDReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::ORReduce, Int64VectorTests::ORReduceAll); } @@ -2704,7 +2704,7 @@ static void ORReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::XORReduce, Int64VectorTests::XORReduceAll); } @@ -2797,7 +2797,7 @@ static void XORReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::ADDReduce, Int64VectorTests::ADDReduceAll); } static int ADDReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2883,7 +2883,7 @@ static void ADDReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::MULReduce, Int64VectorTests::MULReduceAll); } static int MULReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2968,7 +2968,7 @@ static void MULReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::MINReduce, Int64VectorTests::MINReduceAll); } static int MINReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3054,7 +3054,7 @@ static void MINReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Int64VectorTests::MAXReduce, Int64VectorTests::MAXReduceAll); } static int MAXReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3140,7 +3140,7 @@ static void MAXReduceInt64VectorTestsMasked(IntFunction fa, IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int64VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Int64VectorTests::anyTrue); } @@ -3192,7 +3192,7 @@ static void allTrueInt64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Int64VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Int64VectorTests::allTrue); } @@ -3208,7 +3208,7 @@ static void withInt64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (int)4, 0); + assertInsertArraysEquals(r, a, (int)4, 0); } static boolean testIS_DEFAULT(int a) { return bits(a)==0; @@ -3757,7 +3757,7 @@ static void blendInt64VectorTests(IntFunction fa, IntFunction fb, } } - assertArraysEquals(a, b, r, mask, Int64VectorTests::blend); + assertArraysEquals(r, a, b, mask, Int64VectorTests::blend); } @Test(dataProvider = "intUnaryOpShuffleProvider") @@ -3774,7 +3774,7 @@ static void RearrangeInt64VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -3792,7 +3792,7 @@ static void RearrangeInt64VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "intUnaryOpProvider") static void getInt64VectorTests(IntFunction fa) { @@ -3947,7 +3947,7 @@ static void getInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::get); + assertArraysEquals(r, a, Int64VectorTests::get); } @Test(dataProvider = "intUnaryOpProvider") @@ -3961,7 +3961,7 @@ static void BroadcastInt64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4008,7 +4008,7 @@ static void sliceUnaryInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Int64VectorTests::sliceUnary); } static int[] sliceBinary(int[] a, int[] b, int origin, int idx) { int[] res = new int[SPECIES.length()]; @@ -4037,7 +4037,7 @@ static void sliceBinaryInt64VectorTestsBinary(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, origin, Int64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Int64VectorTests::sliceBinary); } static int[] slice(int[] a, int[] b, int origin, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4070,7 +4070,7 @@ static void sliceInt64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Int64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Int64VectorTests::unsliceUnary); } static int[] unsliceBinary(int[] a, int[] b, int origin, int part, int idx) { int[] res = new int[SPECIES.length()]; @@ -4136,7 +4136,7 @@ static void unsliceBinaryInt64VectorTestsBinary(IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, origin, part, Int64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Int64VectorTests::unsliceBinary); } static int[] unslice(int[] a, int[] b, int origin, int part, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4192,7 +4192,7 @@ static void unsliceInt64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4257,7 +4257,7 @@ static void bitwiseBlendInt64VectorTests(IntFunction fa, IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, c, r, mask, Int64VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Int64VectorTests::BITWISE_BLEND); } @@ -4298,7 +4298,7 @@ static void BITWISE_BLENDInt64VectorTestsBroadcastSmokeTest(IntFunction f IntVector bv = IntVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int64VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Int64VectorTests::BITWISE_BLEND); } @Test(dataProvider = "intTernaryOpProvider") @@ -4313,7 +4313,7 @@ static void BITWISE_BLENDInt64VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4327,7 +4327,7 @@ static void bitwiseBlendInt64VectorTestsBroadcastSmokeTest(IntFunction fa IntVector bv = IntVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Int64VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Int64VectorTests::bitwiseBlend); } @Test(dataProvider = "intTernaryOpProvider") @@ -4342,7 +4342,7 @@ static void bitwiseBlendInt64VectorTestsAltBroadcastSmokeTest(IntFunction IntVector cv = IntVector.fromArray(SPECIES, c, i); av.bitwiseBlend(b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, Int64VectorTests::bitwiseBlend); + assertAltBroadcastArraysEquals(r, a, b, c, Int64VectorTests::bitwiseBlend); } @@ -4362,7 +4362,7 @@ static void BITWISE_BLENDInt64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4413,7 +4413,7 @@ static void bitwiseBlendInt64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::NEG); + assertArraysEquals(r, a, Int64VectorTests::NEG); } @Test(dataProvider = "intUnaryOpProvider") @@ -4471,7 +4471,7 @@ static void negInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::neg); + assertArraysEquals(r, a, Int64VectorTests::neg); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4489,7 +4489,7 @@ static void NEGMaskedInt64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int64VectorTests::NEG); + assertArraysEquals(r, a, mask, Int64VectorTests::NEG); } static int ABS(int a) { @@ -4512,7 +4512,7 @@ static void ABSInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::ABS); + assertArraysEquals(r, a, Int64VectorTests::ABS); } @Test(dataProvider = "intUnaryOpProvider") @@ -4527,7 +4527,7 @@ static void absInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::abs); + assertArraysEquals(r, a, Int64VectorTests::abs); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4545,7 +4545,7 @@ static void ABSMaskedInt64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int64VectorTests::ABS); + assertArraysEquals(r, a, mask, Int64VectorTests::ABS); } @@ -4571,7 +4571,7 @@ static void NOTInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::NOT); + assertArraysEquals(r, a, Int64VectorTests::NOT); } @Test(dataProvider = "intUnaryOpProvider") @@ -4586,7 +4586,7 @@ static void notInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::not); + assertArraysEquals(r, a, Int64VectorTests::not); } @@ -4606,7 +4606,7 @@ static void NOTMaskedInt64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int64VectorTests::NOT); + assertArraysEquals(r, a, mask, Int64VectorTests::NOT); } @@ -4629,7 +4629,7 @@ static void ZOMOInt64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Int64VectorTests::ZOMO); + assertArraysEquals(r, a, Int64VectorTests::ZOMO); } @@ -4649,7 +4649,7 @@ static void ZOMOMaskedInt64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Int64VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Int64VectorTests::ZOMO); } @@ -4677,7 +4677,7 @@ static void gatherInt64VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4821,8 +4821,8 @@ static void toLongArrayInt64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4832,8 +4832,8 @@ static void toDoubleArrayInt64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4899,7 +4899,7 @@ static void ADDReduceLongInt64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Int64VectorTests::ADDReduceLong, Int64VectorTests::ADDReduceAllLong); } @@ -4940,7 +4940,7 @@ static void ADDReduceLongInt64VectorTestsMasked(IntFunction fa, IntFuncti ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Int64VectorTests::ADDReduceLongMasked, Int64VectorTests::ADDReduceAllLongMasked); } @@ -4952,7 +4952,7 @@ static void BroadcastLongInt64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -4970,7 +4970,7 @@ static void blendInt64VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Int64VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Int64VectorTests::blend); } @@ -4987,7 +4987,7 @@ static void SelectFromInt64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -5006,7 +5006,7 @@ static void SelectFromInt64VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5083,7 +5083,7 @@ static void maskEqInt64VectorTestsSmokeTest(IntFunction fa, IntFuncti var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Int64VectorTests::beq); + assertArraysEquals(r, a, b, Int64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/IntMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/IntMaxVectorLoadStoreTests.java index 3c615afebafb8..7d89b2c2ae058 100644 --- a/test/jdk/jdk/incubator/vector/IntMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/IntMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -67,47 +67,25 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(int[] a, int[] r, boolean[] mask) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (int) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (int) 0, "at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(int[] a, int[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (int) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -410,7 +388,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "intProviderForIOOBE") @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new int[a.length]; @@ -492,7 +470,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intMaskProviderForIOOBE") @@ -565,7 +543,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -589,7 +567,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -676,7 +654,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -691,7 +669,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -807,7 +785,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "intByteProviderForIOOBE") @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -899,7 +877,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "intByteMaskProviderForIOOBE") @@ -976,7 +954,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -987,7 +965,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/IntMaxVectorTests.java b/test/jdk/jdk/incubator/vector/IntMaxVectorTests.java index 0fc95639cb0d7..1db67b4b2dea7 100644 --- a/test/jdk/jdk/incubator/vector/IntMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/IntMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { int apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { int[] apply(int a); } - static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(int[] a, int[] r, FUnArrayOp f) { } catch (AssertionError e) { int[] ref = f.apply(a[i]); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(int[] a, int[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(int[] r, int[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { int apply(int[] a); } - static void assertReductionArraysEquals(int[] a, int[] b, int c, + static void assertReductionArraysEquals(int[] r, int rc, int[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { int apply(int[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(int[] a, int[] b, int c, boolean[] mask, + static void assertReductionArraysEqualsMasked(int[] r, int rc, int[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -167,17 +167,17 @@ interface FReductionAllOpLong { long apply(int[] a); } - static void assertReductionLongArraysEquals(int[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, int[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -189,17 +189,17 @@ interface FReductionAllMaskedOpLong { long apply(int[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(int[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, int[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -207,37 +207,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(int[] a, int[] b, int element, int index) { + static void assertInsertArraysEquals(int[] r, int[] a, int element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -251,7 +251,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, int vecto } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -265,7 +265,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, int vect } } - static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -285,7 +285,7 @@ static void assertRearrangeArraysEquals(int[] a, int[] r, int[] order, boolean[] } } - static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(int[] r, int[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -305,7 +305,7 @@ static void assertSelectFromArraysEquals(int[] a, int[] r, int[] order, boolean[ } } - static void assertBroadcastArraysEquals(int[]a, int[]r) { + static void assertBroadcastArraysEquals(int[] r, int[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -334,7 +334,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -345,7 +345,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -357,7 +357,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -369,11 +369,11 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, FBinOp f) } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -384,11 +384,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMa } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -402,11 +402,11 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] r, boolean[] mas } } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -420,7 +420,7 @@ static void assertBroadcastLongArraysEquals(int[] a, int[] b, int[] r, boolean[] } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -434,11 +434,11 @@ static void assertShiftArraysEquals(int[] a, int[] b, int[] r, FBinOp f) { } } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -464,7 +464,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -475,11 +475,11 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { } } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -491,7 +491,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mas } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -504,7 +504,7 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTer } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,12 +517,12 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, F } } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -538,12 +538,12 @@ static void assertBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, bool } } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ static void assertAltBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, b } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,12 +574,12 @@ static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r } } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(int[] a, int[] b, int[] c, int[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(int[] r, int[] a, int[] b, int[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -602,7 +602,7 @@ interface FBinArrayOp { int apply(int[] a, int b); } - static void assertArraysEquals(int[] a, int[] r, FBinArrayOp f) { + static void assertArraysEquals(int[] r, int[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -617,7 +617,7 @@ interface FGatherScatterOp { int[] apply(int[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, FGatherScatterOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -644,7 +644,7 @@ interface FScatterMaskedOp { int[] apply(int[] r, int[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } catch (AssertionError e) { int[] ref = f.apply(a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -665,7 +665,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FGathe } } - static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -675,7 +675,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, boolean[] mask, FScatt } catch (AssertionError e) { int[] ref = f.apply(r, a, i, mask, b, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -692,7 +692,7 @@ interface FLaneOp { int[] apply(int[] a, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { + static void assertArraysEquals(int[] r, int[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -702,7 +702,7 @@ static void assertArraysEquals(int[] a, int[] r, int origin, FLaneOp f) { } catch (AssertionError e) { int[] ref = f.apply(a, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -712,7 +712,7 @@ interface FLaneBop { int[] apply(int[] a, int[] b, int origin, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -722,7 +722,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, FLaneBop f } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -733,7 +733,7 @@ interface FLaneMaskedBop { int[] apply(int[] a, int[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -743,7 +743,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, boolean[] } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -754,7 +754,7 @@ interface FLanePartBop { int[] apply(int[] a, int[] b, int origin, int part, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -764,7 +764,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -776,7 +776,7 @@ interface FLanePartMaskedBop { int[] apply(int[] a, int[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(int[] r, int[] a, int[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -786,7 +786,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } catch (AssertionError e) { int[] ref = f.apply(a, b, origin, part, mask, i); int[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -795,7 +795,7 @@ static void assertArraysEquals(int[] a, int[] b, int[] r, int origin, int part, } - static void assertArraysEquals(int[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -808,7 +808,7 @@ static void assertArraysEquals(int[] a, int[] r, int offs) { - static void assertArraysEquals(int[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -819,7 +819,7 @@ static void assertArraysEquals(int[] a, long[] r, int offs) { } } - static void assertArraysEquals(int[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, int[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1259,7 +1259,7 @@ static void ADDIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::ADD); + assertArraysEquals(r, a, b, IntMaxVectorTests::ADD); } static int add(int a, int b) { return (int)(a + b); @@ -1277,7 +1277,7 @@ static void addIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::add); + assertArraysEquals(r, a, b, IntMaxVectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1297,7 +1297,7 @@ static void ADDIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::ADD); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1315,7 +1315,7 @@ static void addIntMaxVectorTestsMasked(IntFunction fa, IntFunction av.add(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::add); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::add); } static int SUB(int a, int b) { return (int)(a - b); @@ -1335,7 +1335,7 @@ static void SUBIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::SUB); + assertArraysEquals(r, a, b, IntMaxVectorTests::SUB); } static int sub(int a, int b) { return (int)(a - b); @@ -1353,7 +1353,7 @@ static void subIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::sub); + assertArraysEquals(r, a, b, IntMaxVectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1373,7 +1373,7 @@ static void SUBIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::SUB); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::SUB); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1391,7 +1391,7 @@ static void subIntMaxVectorTestsMasked(IntFunction fa, IntFunction av.sub(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::sub); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::sub); } static int MUL(int a, int b) { return (int)(a * b); @@ -1411,7 +1411,7 @@ static void MULIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::MUL); + assertArraysEquals(r, a, b, IntMaxVectorTests::MUL); } static int mul(int a, int b) { return (int)(a * b); @@ -1429,7 +1429,7 @@ static void mulIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::mul); + assertArraysEquals(r, a, b, IntMaxVectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1449,7 +1449,7 @@ static void MULIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::MUL); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::MUL); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1467,7 +1467,7 @@ static void mulIntMaxVectorTestsMasked(IntFunction fa, IntFunction av.mul(bv, vmask).intoArray(r, i); } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::mul); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::mul); } @@ -1492,7 +1492,7 @@ static void DIVIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::DIV); + assertArraysEquals(r, a, b, IntMaxVectorTests::DIV); } static int div(int a, int b) { return (int)(a / b); @@ -1514,7 +1514,7 @@ static void divIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::div); + assertArraysEquals(r, a, b, IntMaxVectorTests::div); } @@ -1538,7 +1538,7 @@ static void DIVIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::DIV); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::DIV); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1560,7 +1560,7 @@ static void divIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::div); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::div); } static int FIRST_NONZERO(int a, int b) { @@ -1581,7 +1581,7 @@ static void FIRST_NONZEROIntMaxVectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::FIRST_NONZERO); } static int AND(int a, int b) { @@ -1622,7 +1622,7 @@ static void ANDIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::AND); + assertArraysEquals(r, a, b, IntMaxVectorTests::AND); } static int and(int a, int b) { return (int)(a & b); @@ -1640,7 +1640,7 @@ static void andIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::and); + assertArraysEquals(r, a, b, IntMaxVectorTests::and); } @@ -1662,7 +1662,7 @@ static void ANDIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::AND); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::AND); } @@ -1684,7 +1684,7 @@ static void AND_NOTIntMaxVectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, IntMaxVectorTests::AND_NOT); + assertArraysEquals(r, a, b, IntMaxVectorTests::AND_NOT); } @@ -1706,7 +1706,7 @@ static void AND_NOTIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::OR); + assertArraysEquals(r, a, b, IntMaxVectorTests::OR); } static int or(int a, int b) { return (int)(a | b); @@ -1746,7 +1746,7 @@ static void orIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::or); + assertArraysEquals(r, a, b, IntMaxVectorTests::or); } @@ -1768,7 +1768,7 @@ static void ORIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::OR); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::OR); } @@ -1790,7 +1790,7 @@ static void XORIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::XOR); + assertArraysEquals(r, a, b, IntMaxVectorTests::XOR); } @@ -1812,7 +1812,7 @@ static void XORIntMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::XOR); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::XOR); } @@ -1827,7 +1827,7 @@ static void addIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::add); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1844,7 +1844,7 @@ static void addIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::add); } @Test(dataProvider = "intBinaryOpProvider") @@ -1858,7 +1858,7 @@ static void subIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::sub); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1875,7 +1875,7 @@ static void subIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::sub); } @Test(dataProvider = "intBinaryOpProvider") @@ -1889,7 +1889,7 @@ static void mulIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::mul); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -1906,7 +1906,7 @@ static void mulIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::mul); } @@ -1925,7 +1925,7 @@ static void divIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::div); } @@ -1946,7 +1946,7 @@ static void divIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::div); } @@ -1962,7 +1962,7 @@ static void ORIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::OR); } @Test(dataProvider = "intBinaryOpProvider") @@ -1976,7 +1976,7 @@ static void orIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunc av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::or); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::or); } @@ -1995,7 +1995,7 @@ static void ORIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::OR); } @@ -2011,7 +2011,7 @@ static void ANDIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::AND); } @Test(dataProvider = "intBinaryOpProvider") @@ -2025,7 +2025,7 @@ static void andIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::and); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::and); } @@ -2044,7 +2044,7 @@ static void ANDIntMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, IntMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, IntMaxVectorTests::AND); } @@ -2060,7 +2060,7 @@ static void ORIntMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, IntMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, IntMaxVectorTests::OR); } @@ -2079,7 +2079,7 @@ static void ORIntMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, IntMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, IntMaxVectorTests::OR); } @@ -2094,7 +2094,7 @@ static void ADDIntMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, IntMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, IntMaxVectorTests::ADD); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -2111,7 +2111,7 @@ static void ADDIntMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, IntMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, IntMaxVectorTests::ADD); } static int LSHL(int a, int b) { @@ -2132,7 +2132,7 @@ static void LSHLIntMaxVectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, IntMaxVectorTests::LSHL); + assertArraysEquals(r, a, b, IntMaxVectorTests::LSHL); } @@ -2154,7 +2154,7 @@ static void LSHLIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, IntMaxVectorTests::ASHR); + assertArraysEquals(r, a, b, IntMaxVectorTests::ASHR); } @@ -2202,7 +2202,7 @@ static void ASHRIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, IntMaxVectorTests::LSHR); + assertArraysEquals(r, a, b, IntMaxVectorTests::LSHR); } @@ -2250,7 +2250,7 @@ static void LSHRIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, IntMaxVectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, IntMaxVectorTests::LSHL_unary); } @@ -2296,7 +2296,7 @@ static void LSHLIntMaxVectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, IntMaxVectorTests::LSHL_unary); + assertShiftArraysEquals(r, a, b, mask, IntMaxVectorTests::LSHL_unary); } @@ -2321,7 +2321,7 @@ static void LSHRIntMaxVectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, IntMaxVectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, IntMaxVectorTests::LSHR_unary); } @@ -2342,7 +2342,7 @@ static void LSHRIntMaxVectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, IntMaxVectorTests::LSHR_unary); + assertShiftArraysEquals(r, a, b, mask, IntMaxVectorTests::LSHR_unary); } @@ -2367,7 +2367,7 @@ static void ASHRIntMaxVectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, IntMaxVectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, IntMaxVectorTests::ASHR_unary); } @@ -2388,7 +2388,7 @@ static void ASHRIntMaxVectorTestsShift(IntFunction fa, IntFunction } } - assertShiftArraysEquals(a, b, r, mask, IntMaxVectorTests::ASHR_unary); + assertShiftArraysEquals(r, a, b, mask, IntMaxVectorTests::ASHR_unary); } @@ -2413,7 +2413,7 @@ static void MINIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::MIN); + assertArraysEquals(r, a, b, IntMaxVectorTests::MIN); } static int min(int a, int b) { return (int)(Math.min(a, b)); @@ -2431,7 +2431,7 @@ static void minIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::min); + assertArraysEquals(r, a, b, IntMaxVectorTests::min); } static int MAX(int a, int b) { return (int)(Math.max(a, b)); @@ -2451,7 +2451,7 @@ static void MAXIntMaxVectorTests(IntFunction fa, IntFunction fb) { } } - assertArraysEquals(a, b, r, IntMaxVectorTests::MAX); + assertArraysEquals(r, a, b, IntMaxVectorTests::MAX); } static int max(int a, int b) { return (int)(Math.max(a, b)); @@ -2469,7 +2469,7 @@ static void maxIntMaxVectorTests(IntFunction fa, IntFunction fb) { av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::max); + assertArraysEquals(r, a, b, IntMaxVectorTests::max); } @Test(dataProvider = "intBinaryOpProvider") @@ -2483,7 +2483,7 @@ static void MINIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::MIN); } @Test(dataProvider = "intBinaryOpProvider") @@ -2497,7 +2497,7 @@ static void minIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::min); } @Test(dataProvider = "intBinaryOpProvider") @@ -2511,7 +2511,7 @@ static void MAXIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::MAX); } @Test(dataProvider = "intBinaryOpProvider") @@ -2525,7 +2525,7 @@ static void maxIntMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, IntMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, IntMaxVectorTests::max); } static int ANDReduce(int[] a, int idx) { @@ -2568,7 +2568,7 @@ static void ANDReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::ANDReduce, IntMaxVectorTests::ANDReduceAll); } @@ -2616,7 +2616,7 @@ static void ANDReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::ANDReduceMasked, IntMaxVectorTests::ANDReduceAllMasked); } @@ -2661,7 +2661,7 @@ static void ORReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::ORReduce, IntMaxVectorTests::ORReduceAll); } @@ -2709,7 +2709,7 @@ static void ORReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::XORReduce, IntMaxVectorTests::XORReduceAll); } @@ -2802,7 +2802,7 @@ static void XORReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::XORReduceMasked, IntMaxVectorTests::XORReduceAllMasked); } @@ -2844,7 +2844,7 @@ static void ADDReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::ADDReduce, IntMaxVectorTests::ADDReduceAll); } static int ADDReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2888,7 +2888,7 @@ static void ADDReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::ADDReduceMasked, IntMaxVectorTests::ADDReduceAllMasked); } static int MULReduce(int[] a, int idx) { @@ -2929,7 +2929,7 @@ static void MULReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::MULReduce, IntMaxVectorTests::MULReduceAll); } static int MULReduceMasked(int[] a, int idx, boolean[] mask) { @@ -2973,7 +2973,7 @@ static void MULReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::MULReduceMasked, IntMaxVectorTests::MULReduceAllMasked); } static int MINReduce(int[] a, int idx) { @@ -3014,7 +3014,7 @@ static void MINReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::MINReduce, IntMaxVectorTests::MINReduceAll); } static int MINReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3059,7 +3059,7 @@ static void MINReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::MINReduceMasked, IntMaxVectorTests::MINReduceAllMasked); } static int MAXReduce(int[] a, int idx) { @@ -3100,7 +3100,7 @@ static void MAXReduceIntMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, IntMaxVectorTests::MAXReduce, IntMaxVectorTests::MAXReduceAll); } static int MAXReduceMasked(int[] a, int idx, boolean[] mask) { @@ -3145,7 +3145,7 @@ static void MAXReduceIntMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::MAXReduceMasked, IntMaxVectorTests::MAXReduceAllMasked); } @@ -3171,7 +3171,7 @@ static void anyTrueIntMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, IntMaxVectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, IntMaxVectorTests::anyTrue); } @@ -3197,7 +3197,7 @@ static void allTrueIntMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, IntMaxVectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, IntMaxVectorTests::allTrue); } @@ -3213,7 +3213,7 @@ static void withIntMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (int)4, 0); + assertInsertArraysEquals(r, a, (int)4, 0); } static boolean testIS_DEFAULT(int a) { return bits(a)==0; @@ -3762,7 +3762,7 @@ static void blendIntMaxVectorTests(IntFunction fa, IntFunction fb, } } - assertArraysEquals(a, b, r, mask, IntMaxVectorTests::blend); + assertArraysEquals(r, a, b, mask, IntMaxVectorTests::blend); } @Test(dataProvider = "intUnaryOpShuffleProvider") @@ -3779,7 +3779,7 @@ static void RearrangeIntMaxVectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -3797,7 +3797,7 @@ static void RearrangeIntMaxVectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "intUnaryOpProvider") static void getIntMaxVectorTests(IntFunction fa) { @@ -3952,7 +3952,7 @@ static void getIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::get); + assertArraysEquals(r, a, IntMaxVectorTests::get); } @Test(dataProvider = "intUnaryOpProvider") @@ -3966,7 +3966,7 @@ static void BroadcastIntMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4013,7 +4013,7 @@ static void sliceUnaryIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, IntMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, IntMaxVectorTests::sliceUnary); } static int[] sliceBinary(int[] a, int[] b, int origin, int idx) { int[] res = new int[SPECIES.length()]; @@ -4042,7 +4042,7 @@ static void sliceBinaryIntMaxVectorTestsBinary(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, IntMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, IntMaxVectorTests::sliceBinary); } static int[] slice(int[] a, int[] b, int origin, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4075,7 +4075,7 @@ static void sliceIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, IntMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, IntMaxVectorTests::unsliceUnary); } static int[] unsliceBinary(int[] a, int[] b, int origin, int part, int idx) { int[] res = new int[SPECIES.length()]; @@ -4141,7 +4141,7 @@ static void unsliceBinaryIntMaxVectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, part, IntMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, IntMaxVectorTests::unsliceBinary); } static int[] unslice(int[] a, int[] b, int origin, int part, boolean[] mask, int idx) { int[] res = new int[SPECIES.length()]; @@ -4197,7 +4197,7 @@ static void unsliceIntMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4262,7 +4262,7 @@ static void bitwiseBlendIntMaxVectorTests(IntFunction fa, IntFunction fa, IntFunct } } - assertArraysEquals(a, b, c, r, mask, IntMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, IntMaxVectorTests::BITWISE_BLEND); } @@ -4303,7 +4303,7 @@ static void BITWISE_BLENDIntMaxVectorTestsBroadcastSmokeTest(IntFunction IntVector bv = IntVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, IntMaxVectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, IntMaxVectorTests::BITWISE_BLEND); } @Test(dataProvider = "intTernaryOpProvider") @@ -4318,7 +4318,7 @@ static void BITWISE_BLENDIntMaxVectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4332,7 +4332,7 @@ static void bitwiseBlendIntMaxVectorTestsBroadcastSmokeTest(IntFunction f IntVector bv = IntVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, IntMaxVectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, IntMaxVectorTests::bitwiseBlend); } @Test(dataProvider = "intTernaryOpProvider") @@ -4347,7 +4347,7 @@ static void bitwiseBlendIntMaxVectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4418,7 +4418,7 @@ static void bitwiseBlendIntMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::NEG); + assertArraysEquals(r, a, IntMaxVectorTests::NEG); } @Test(dataProvider = "intUnaryOpProvider") @@ -4476,7 +4476,7 @@ static void negIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::neg); + assertArraysEquals(r, a, IntMaxVectorTests::neg); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4494,7 +4494,7 @@ static void NEGMaskedIntMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, IntMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, IntMaxVectorTests::NEG); } static int ABS(int a) { @@ -4517,7 +4517,7 @@ static void ABSIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::ABS); + assertArraysEquals(r, a, IntMaxVectorTests::ABS); } @Test(dataProvider = "intUnaryOpProvider") @@ -4532,7 +4532,7 @@ static void absIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::abs); + assertArraysEquals(r, a, IntMaxVectorTests::abs); } @Test(dataProvider = "intUnaryOpMaskProvider") @@ -4550,7 +4550,7 @@ static void ABSMaskedIntMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, IntMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, IntMaxVectorTests::ABS); } @@ -4576,7 +4576,7 @@ static void NOTIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::NOT); + assertArraysEquals(r, a, IntMaxVectorTests::NOT); } @Test(dataProvider = "intUnaryOpProvider") @@ -4591,7 +4591,7 @@ static void notIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::not); + assertArraysEquals(r, a, IntMaxVectorTests::not); } @@ -4611,7 +4611,7 @@ static void NOTMaskedIntMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, IntMaxVectorTests::NOT); + assertArraysEquals(r, a, mask, IntMaxVectorTests::NOT); } @@ -4634,7 +4634,7 @@ static void ZOMOIntMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, IntMaxVectorTests::ZOMO); + assertArraysEquals(r, a, IntMaxVectorTests::ZOMO); } @@ -4654,7 +4654,7 @@ static void ZOMOMaskedIntMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, IntMaxVectorTests::ZOMO); + assertArraysEquals(r, a, mask, IntMaxVectorTests::ZOMO); } @@ -4682,7 +4682,7 @@ static void gatherIntMaxVectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4826,8 +4826,8 @@ static void toLongArrayIntMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4837,8 +4837,8 @@ static void toDoubleArrayIntMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector av = IntVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4904,7 +4904,7 @@ static void ADDReduceLongIntMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, IntMaxVectorTests::ADDReduceLong, IntMaxVectorTests::ADDReduceAllLong); } @@ -4945,7 +4945,7 @@ static void ADDReduceLongIntMaxVectorTestsMasked(IntFunction fa, IntFunct ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, IntMaxVectorTests::ADDReduceLongMasked, IntMaxVectorTests::ADDReduceAllLongMasked); } @@ -4957,7 +4957,7 @@ static void BroadcastLongIntMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { IntVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "intBinaryOpMaskProvider") @@ -4975,7 +4975,7 @@ static void blendIntMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, IntMaxVectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, IntMaxVectorTests::blend); } @@ -4992,7 +4992,7 @@ static void SelectFromIntMaxVectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "intUnaryOpShuffleMaskProvider") @@ -5011,7 +5011,7 @@ static void SelectFromIntMaxVectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5088,7 +5088,7 @@ static void maskEqIntMaxVectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, IntMaxVectorTests::beq); + assertArraysEquals(r, a, b, IntMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Long128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Long128VectorLoadStoreTests.java index f26817404bc21..54c337cee33e6 100644 --- a/test/jdk/jdk/incubator/vector/Long128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Long128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Long128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(long[] a, long[] r, boolean[] mask) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0, "at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(long[] a, long[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "longProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new long[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Long128VectorTests.java b/test/jdk/jdk/incubator/vector/Long128VectorTests.java index db6db4833415c..19ce3554e8801 100644 --- a/test/jdk/jdk/incubator/vector/Long128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Long128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { long apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { long[] apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { } catch (AssertionError e) { long[] ref = f.apply(a[i]); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { long apply(long[] a); } - static void assertReductionArraysEquals(long[] a, long[] b, long c, + static void assertReductionArraysEquals(long[] r, long rc, long[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { long apply(long[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(long[] a, long[] b, long c, boolean[] mask, + static void assertReductionArraysEqualsMasked(long[] r, long rc, long[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -159,37 +159,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(long[] a, long[] b, long element, int index) { + static void assertInsertArraysEquals(long[] r, long[] a, long element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -203,7 +203,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -217,7 +217,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int v } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -237,7 +237,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -257,7 +257,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boole } } - static void assertBroadcastArraysEquals(long[]a, long[]r) { + static void assertBroadcastArraysEquals(long[] r, long[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -286,7 +286,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -297,7 +297,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -309,7 +309,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -321,11 +321,11 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp } } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -336,11 +336,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -354,11 +354,11 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -372,7 +372,7 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolea } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -386,11 +386,11 @@ static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -416,7 +416,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -427,11 +427,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -443,7 +443,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -456,7 +456,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -469,12 +469,12 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -490,12 +490,12 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -511,7 +511,7 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -526,12 +526,12 @@ static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ interface FBinArrayOp { long apply(long[] a, int b); } - static void assertArraysEquals(long[] a, long[] r, FBinArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,7 +569,7 @@ interface FGatherScatterOp { long[] apply(long[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, FGatherScatterOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -596,7 +596,7 @@ interface FScatterMaskedOp { long[] apply(long[] r, long[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -606,7 +606,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } catch (AssertionError e) { long[] ref = f.apply(a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -617,7 +617,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -627,7 +627,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FSca } catch (AssertionError e) { long[] ref = f.apply(r, a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -644,7 +644,7 @@ interface FLaneOp { long[] apply(long[] a, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { + static void assertArraysEquals(long[] r, long[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { } catch (AssertionError e) { long[] ref = f.apply(a, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -664,7 +664,7 @@ interface FLaneBop { long[] apply(long[] a, long[] b, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -674,7 +674,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBo } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -685,7 +685,7 @@ interface FLaneMaskedBop { long[] apply(long[] a, long[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -695,7 +695,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -706,7 +706,7 @@ interface FLanePartBop { long[] apply(long[] a, long[] b, int origin, int part, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -716,7 +716,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -728,7 +728,7 @@ interface FLanePartMaskedBop { long[] apply(long[] a, long[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -780,7 +780,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(long[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -793,7 +793,7 @@ static void assertArraysEquals(long[] a, int[] r, int offs) { - static void assertArraysEquals(long[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -804,7 +804,7 @@ static void assertArraysEquals(long[] a, long[] r, int offs) { } } - static void assertArraysEquals(long[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1275,7 +1275,7 @@ static void ADDLong128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::ADD); + assertArraysEquals(r, a, b, Long128VectorTests::ADD); } static long add(long a, long b) { return (long)(a + b); @@ -1293,7 +1293,7 @@ static void addLong128VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::add); + assertArraysEquals(r, a, b, Long128VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1313,7 +1313,7 @@ static void ADDLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::SUB); + assertArraysEquals(r, a, b, Long128VectorTests::SUB); } static long sub(long a, long b) { return (long)(a - b); @@ -1369,7 +1369,7 @@ static void subLong128VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::sub); + assertArraysEquals(r, a, b, Long128VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1389,7 +1389,7 @@ static void SUBLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::MUL); + assertArraysEquals(r, a, b, Long128VectorTests::MUL); } static long mul(long a, long b) { return (long)(a * b); @@ -1445,7 +1445,7 @@ static void mulLong128VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::mul); + assertArraysEquals(r, a, b, Long128VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1465,7 +1465,7 @@ static void MULLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::DIV); + assertArraysEquals(r, a, b, Long128VectorTests::DIV); } static long div(long a, long b) { return (long)(a / b); @@ -1530,7 +1530,7 @@ static void divLong128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::div); + assertArraysEquals(r, a, b, Long128VectorTests::div); } @@ -1554,7 +1554,7 @@ static void DIVLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Long128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Long128VectorTests::FIRST_NONZERO); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1617,7 +1617,7 @@ static void FIRST_NONZEROLong128VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Long128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Long128VectorTests::FIRST_NONZERO); } static long AND(long a, long b) { @@ -1638,7 +1638,7 @@ static void ANDLong128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::AND); + assertArraysEquals(r, a, b, Long128VectorTests::AND); } static long and(long a, long b) { return (long)(a & b); @@ -1656,7 +1656,7 @@ static void andLong128VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::and); + assertArraysEquals(r, a, b, Long128VectorTests::and); } @@ -1678,7 +1678,7 @@ static void ANDLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long128VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Long128VectorTests::AND_NOT); } @@ -1744,7 +1744,7 @@ static void ORLong128VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long128VectorTests::OR); + assertArraysEquals(r, a, b, Long128VectorTests::OR); } static long or(long a, long b) { return (long)(a | b); @@ -1762,7 +1762,7 @@ static void orLong128VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::or); + assertArraysEquals(r, a, b, Long128VectorTests::or); } @@ -1784,7 +1784,7 @@ static void ORLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::XOR); + assertArraysEquals(r, a, b, Long128VectorTests::XOR); } @@ -1828,7 +1828,7 @@ static void XORLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1860,7 +1860,7 @@ static void addLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::add); } @Test(dataProvider = "longBinaryOpProvider") @@ -1874,7 +1874,7 @@ static void subLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1891,7 +1891,7 @@ static void subLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::sub); } @Test(dataProvider = "longBinaryOpProvider") @@ -1905,7 +1905,7 @@ static void mulLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1922,7 +1922,7 @@ static void mulLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::mul); } @@ -1941,7 +1941,7 @@ static void divLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::div); } @@ -1962,7 +1962,7 @@ static void divLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::div); } @@ -1978,7 +1978,7 @@ static void ORLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::OR); } @Test(dataProvider = "longBinaryOpProvider") @@ -1992,7 +1992,7 @@ static void orLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::or); } @@ -2011,7 +2011,7 @@ static void ORLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::OR); } @@ -2027,7 +2027,7 @@ static void ANDLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::AND); } @Test(dataProvider = "longBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void andLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::and); } @@ -2060,7 +2060,7 @@ static void ANDLong128VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Long128VectorTests::AND); } @@ -2076,7 +2076,7 @@ static void ORLong128VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Long128VectorTests::OR); } @@ -2095,7 +2095,7 @@ static void ORLong128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Long128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Long128VectorTests::OR); } @@ -2110,7 +2110,7 @@ static void ADDLong128VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Long128VectorTests::ADD); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -2127,7 +2127,7 @@ static void ADDLong128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long128VectorTests::LSHL); + assertArraysEquals(r, a, b, Long128VectorTests::LSHL); } @@ -2170,7 +2170,7 @@ static void LSHLLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long128VectorTests::ASHR); + assertArraysEquals(r, a, b, Long128VectorTests::ASHR); } @@ -2218,7 +2218,7 @@ static void ASHRLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long128VectorTests::LSHR); + assertArraysEquals(r, a, b, Long128VectorTests::LSHR); } @@ -2266,7 +2266,7 @@ static void LSHRLong128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::MIN); + assertArraysEquals(r, a, b, Long128VectorTests::MIN); } static long min(long a, long b) { return (long)(Math.min(a, b)); @@ -2447,7 +2447,7 @@ static void minLong128VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::min); + assertArraysEquals(r, a, b, Long128VectorTests::min); } static long MAX(long a, long b) { return (long)(Math.max(a, b)); @@ -2467,7 +2467,7 @@ static void MAXLong128VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long128VectorTests::MAX); + assertArraysEquals(r, a, b, Long128VectorTests::MAX); } static long max(long a, long b) { return (long)(Math.max(a, b)); @@ -2485,7 +2485,7 @@ static void maxLong128VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::max); + assertArraysEquals(r, a, b, Long128VectorTests::max); } @Test(dataProvider = "longBinaryOpProvider") @@ -2499,7 +2499,7 @@ static void MINLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::MIN); } @Test(dataProvider = "longBinaryOpProvider") @@ -2513,7 +2513,7 @@ static void minLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::min); } @Test(dataProvider = "longBinaryOpProvider") @@ -2527,7 +2527,7 @@ static void MAXLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::MAX); } @Test(dataProvider = "longBinaryOpProvider") @@ -2541,7 +2541,7 @@ static void maxLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Long128VectorTests::max); } static long ANDReduce(long[] a, int idx) { @@ -2584,7 +2584,7 @@ static void ANDReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::ANDReduce, Long128VectorTests::ANDReduceAll); } @@ -2632,7 +2632,7 @@ static void ANDReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::ANDReduceMasked, Long128VectorTests::ANDReduceAllMasked); } @@ -2677,7 +2677,7 @@ static void ORReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::ORReduce, Long128VectorTests::ORReduceAll); } @@ -2725,7 +2725,7 @@ static void ORReduceLong128VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::ORReduceMasked, Long128VectorTests::ORReduceAllMasked); } @@ -2770,7 +2770,7 @@ static void XORReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::XORReduce, Long128VectorTests::XORReduceAll); } @@ -2818,7 +2818,7 @@ static void XORReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::XORReduceMasked, Long128VectorTests::XORReduceAllMasked); } @@ -2860,7 +2860,7 @@ static void ADDReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::ADDReduce, Long128VectorTests::ADDReduceAll); } static long ADDReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2904,7 +2904,7 @@ static void ADDReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::ADDReduceMasked, Long128VectorTests::ADDReduceAllMasked); } static long MULReduce(long[] a, int idx) { @@ -2945,7 +2945,7 @@ static void MULReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::MULReduce, Long128VectorTests::MULReduceAll); } static long MULReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2989,7 +2989,7 @@ static void MULReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::MULReduceMasked, Long128VectorTests::MULReduceAllMasked); } static long MINReduce(long[] a, int idx) { @@ -3030,7 +3030,7 @@ static void MINReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::MINReduce, Long128VectorTests::MINReduceAll); } static long MINReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3075,7 +3075,7 @@ static void MINReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::MINReduceMasked, Long128VectorTests::MINReduceAllMasked); } static long MAXReduce(long[] a, int idx) { @@ -3116,7 +3116,7 @@ static void MAXReduceLong128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::MAXReduce, Long128VectorTests::MAXReduceAll); } static long MAXReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3161,7 +3161,7 @@ static void MAXReduceLong128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::MAXReduceMasked, Long128VectorTests::MAXReduceAllMasked); } @@ -3187,7 +3187,7 @@ static void anyTrueLong128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long128VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Long128VectorTests::anyTrue); } @@ -3213,7 +3213,7 @@ static void allTrueLong128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long128VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Long128VectorTests::allTrue); } @@ -3229,7 +3229,7 @@ static void withLong128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (long)4, 0); + assertInsertArraysEquals(r, a, (long)4, 0); } static boolean testIS_DEFAULT(long a) { return bits(a)==0; @@ -3706,7 +3706,7 @@ static void blendLong128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Long128VectorTests::blend); + assertArraysEquals(r, a, b, mask, Long128VectorTests::blend); } @Test(dataProvider = "longUnaryOpShuffleProvider") @@ -3723,7 +3723,7 @@ static void RearrangeLong128VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpShuffleMaskProvider") @@ -3741,7 +3741,7 @@ static void RearrangeLong128VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "longUnaryOpProvider") static void getLong128VectorTests(IntFunction fa) { @@ -3896,7 +3896,7 @@ static void getLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::get); + assertArraysEquals(r, a, Long128VectorTests::get); } @Test(dataProvider = "longUnaryOpProvider") @@ -3910,7 +3910,7 @@ static void BroadcastLong128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3957,7 +3957,7 @@ static void sliceUnaryLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Long128VectorTests::sliceUnary); } static long[] sliceBinary(long[] a, long[] b, int origin, int idx) { long[] res = new long[SPECIES.length()]; @@ -3986,7 +3986,7 @@ static void sliceBinaryLong128VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Long128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Long128VectorTests::sliceBinary); } static long[] slice(long[] a, long[] b, int origin, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4019,7 +4019,7 @@ static void sliceLong128VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Long128VectorTests::unsliceUnary); } static long[] unsliceBinary(long[] a, long[] b, int origin, int part, int idx) { long[] res = new long[SPECIES.length()]; @@ -4085,7 +4085,7 @@ static void unsliceBinaryLong128VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Long128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Long128VectorTests::unsliceBinary); } static long[] unslice(long[] a, long[] b, int origin, int part, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4141,7 +4141,7 @@ static void unsliceLong128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Long128VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Long128VectorTests::unslice); } @@ -4190,7 +4190,7 @@ static void BITWISE_BLENDLong128VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Long128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Long128VectorTests::BITWISE_BLEND); } @Test(dataProvider = "longTernaryOpProvider") static void bitwiseBlendLong128VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4206,7 +4206,7 @@ static void bitwiseBlendLong128VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Long128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Long128VectorTests::BITWISE_BLEND); } @@ -4247,7 +4247,7 @@ static void BITWISE_BLENDLong128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4276,7 +4276,7 @@ static void bitwiseBlendLong128VectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Long128VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Long128VectorTests::bitwiseBlend); } @Test(dataProvider = "longTernaryOpProvider") @@ -4291,7 +4291,7 @@ static void bitwiseBlendLong128VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4362,7 +4362,7 @@ static void bitwiseBlendLong128VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::NEG); + assertArraysEquals(r, a, Long128VectorTests::NEG); } @Test(dataProvider = "longUnaryOpProvider") @@ -4420,7 +4420,7 @@ static void negLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::neg); + assertArraysEquals(r, a, Long128VectorTests::neg); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4438,7 +4438,7 @@ static void NEGMaskedLong128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long128VectorTests::NEG); + assertArraysEquals(r, a, mask, Long128VectorTests::NEG); } static long ABS(long a) { @@ -4461,7 +4461,7 @@ static void ABSLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::ABS); + assertArraysEquals(r, a, Long128VectorTests::ABS); } @Test(dataProvider = "longUnaryOpProvider") @@ -4476,7 +4476,7 @@ static void absLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::abs); + assertArraysEquals(r, a, Long128VectorTests::abs); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4494,7 +4494,7 @@ static void ABSMaskedLong128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long128VectorTests::ABS); + assertArraysEquals(r, a, mask, Long128VectorTests::ABS); } @@ -4520,7 +4520,7 @@ static void NOTLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::NOT); + assertArraysEquals(r, a, Long128VectorTests::NOT); } @Test(dataProvider = "longUnaryOpProvider") @@ -4535,7 +4535,7 @@ static void notLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::not); + assertArraysEquals(r, a, Long128VectorTests::not); } @@ -4555,7 +4555,7 @@ static void NOTMaskedLong128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long128VectorTests::NOT); + assertArraysEquals(r, a, mask, Long128VectorTests::NOT); } @@ -4578,7 +4578,7 @@ static void ZOMOLong128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long128VectorTests::ZOMO); + assertArraysEquals(r, a, Long128VectorTests::ZOMO); } @@ -4598,7 +4598,7 @@ static void ZOMOMaskedLong128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long128VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Long128VectorTests::ZOMO); } @@ -4626,7 +4626,7 @@ static void gatherLong128VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long128VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Long128VectorTests::scatterMasked); } @@ -4759,8 +4759,8 @@ static void toIntArrayLong128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4770,8 +4770,8 @@ static void toLongArrayLong128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4781,8 +4781,8 @@ static void toDoubleArrayLong128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4831,7 +4831,7 @@ static void ADDReduceLongLong128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long128VectorTests::ADDReduce, Long128VectorTests::ADDReduceAll); } @@ -4853,7 +4853,7 @@ static void ADDReduceLongLong128VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long128VectorTests::ADDReduceMasked, Long128VectorTests::ADDReduceAllMasked); } @@ -4870,7 +4870,7 @@ static void SelectFromLong128VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpSelectFromMaskProvider") @@ -4889,7 +4889,7 @@ static void SelectFromLong128VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4966,7 +4966,7 @@ static void maskEqLong128VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Long128VectorTests::beq); + assertArraysEquals(r, a, b, Long128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Long256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Long256VectorLoadStoreTests.java index 3eb2c4eb359d9..3433fd0239b70 100644 --- a/test/jdk/jdk/incubator/vector/Long256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Long256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Long256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(long[] a, long[] r, boolean[] mask) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0, "at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(long[] a, long[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "longProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new long[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Long256VectorTests.java b/test/jdk/jdk/incubator/vector/Long256VectorTests.java index 8794a134430f8..6bd614f5a7c7d 100644 --- a/test/jdk/jdk/incubator/vector/Long256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Long256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { long apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { long[] apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { } catch (AssertionError e) { long[] ref = f.apply(a[i]); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { long apply(long[] a); } - static void assertReductionArraysEquals(long[] a, long[] b, long c, + static void assertReductionArraysEquals(long[] r, long rc, long[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { long apply(long[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(long[] a, long[] b, long c, boolean[] mask, + static void assertReductionArraysEqualsMasked(long[] r, long rc, long[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -159,37 +159,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(long[] a, long[] b, long element, int index) { + static void assertInsertArraysEquals(long[] r, long[] a, long element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -203,7 +203,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -217,7 +217,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int v } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -237,7 +237,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -257,7 +257,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boole } } - static void assertBroadcastArraysEquals(long[]a, long[]r) { + static void assertBroadcastArraysEquals(long[] r, long[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -286,7 +286,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -297,7 +297,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -309,7 +309,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -321,11 +321,11 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp } } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -336,11 +336,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -354,11 +354,11 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -372,7 +372,7 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolea } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -386,11 +386,11 @@ static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -416,7 +416,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -427,11 +427,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -443,7 +443,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -456,7 +456,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -469,12 +469,12 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -490,12 +490,12 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -511,7 +511,7 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -526,12 +526,12 @@ static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ interface FBinArrayOp { long apply(long[] a, int b); } - static void assertArraysEquals(long[] a, long[] r, FBinArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,7 +569,7 @@ interface FGatherScatterOp { long[] apply(long[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, FGatherScatterOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -596,7 +596,7 @@ interface FScatterMaskedOp { long[] apply(long[] r, long[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -606,7 +606,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } catch (AssertionError e) { long[] ref = f.apply(a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -617,7 +617,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -627,7 +627,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FSca } catch (AssertionError e) { long[] ref = f.apply(r, a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -644,7 +644,7 @@ interface FLaneOp { long[] apply(long[] a, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { + static void assertArraysEquals(long[] r, long[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { } catch (AssertionError e) { long[] ref = f.apply(a, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -664,7 +664,7 @@ interface FLaneBop { long[] apply(long[] a, long[] b, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -674,7 +674,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBo } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -685,7 +685,7 @@ interface FLaneMaskedBop { long[] apply(long[] a, long[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -695,7 +695,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -706,7 +706,7 @@ interface FLanePartBop { long[] apply(long[] a, long[] b, int origin, int part, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -716,7 +716,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -728,7 +728,7 @@ interface FLanePartMaskedBop { long[] apply(long[] a, long[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -780,7 +780,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(long[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -793,7 +793,7 @@ static void assertArraysEquals(long[] a, int[] r, int offs) { - static void assertArraysEquals(long[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -804,7 +804,7 @@ static void assertArraysEquals(long[] a, long[] r, int offs) { } } - static void assertArraysEquals(long[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1275,7 +1275,7 @@ static void ADDLong256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::ADD); + assertArraysEquals(r, a, b, Long256VectorTests::ADD); } static long add(long a, long b) { return (long)(a + b); @@ -1293,7 +1293,7 @@ static void addLong256VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::add); + assertArraysEquals(r, a, b, Long256VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1313,7 +1313,7 @@ static void ADDLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::SUB); + assertArraysEquals(r, a, b, Long256VectorTests::SUB); } static long sub(long a, long b) { return (long)(a - b); @@ -1369,7 +1369,7 @@ static void subLong256VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::sub); + assertArraysEquals(r, a, b, Long256VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1389,7 +1389,7 @@ static void SUBLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::MUL); + assertArraysEquals(r, a, b, Long256VectorTests::MUL); } static long mul(long a, long b) { return (long)(a * b); @@ -1445,7 +1445,7 @@ static void mulLong256VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::mul); + assertArraysEquals(r, a, b, Long256VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1465,7 +1465,7 @@ static void MULLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::DIV); + assertArraysEquals(r, a, b, Long256VectorTests::DIV); } static long div(long a, long b) { return (long)(a / b); @@ -1530,7 +1530,7 @@ static void divLong256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::div); + assertArraysEquals(r, a, b, Long256VectorTests::div); } @@ -1554,7 +1554,7 @@ static void DIVLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Long256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Long256VectorTests::FIRST_NONZERO); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1617,7 +1617,7 @@ static void FIRST_NONZEROLong256VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Long256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Long256VectorTests::FIRST_NONZERO); } static long AND(long a, long b) { @@ -1638,7 +1638,7 @@ static void ANDLong256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::AND); + assertArraysEquals(r, a, b, Long256VectorTests::AND); } static long and(long a, long b) { return (long)(a & b); @@ -1656,7 +1656,7 @@ static void andLong256VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::and); + assertArraysEquals(r, a, b, Long256VectorTests::and); } @@ -1678,7 +1678,7 @@ static void ANDLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long256VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Long256VectorTests::AND_NOT); } @@ -1744,7 +1744,7 @@ static void ORLong256VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long256VectorTests::OR); + assertArraysEquals(r, a, b, Long256VectorTests::OR); } static long or(long a, long b) { return (long)(a | b); @@ -1762,7 +1762,7 @@ static void orLong256VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::or); + assertArraysEquals(r, a, b, Long256VectorTests::or); } @@ -1784,7 +1784,7 @@ static void ORLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::XOR); + assertArraysEquals(r, a, b, Long256VectorTests::XOR); } @@ -1828,7 +1828,7 @@ static void XORLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1860,7 +1860,7 @@ static void addLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::add); } @Test(dataProvider = "longBinaryOpProvider") @@ -1874,7 +1874,7 @@ static void subLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1891,7 +1891,7 @@ static void subLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::sub); } @Test(dataProvider = "longBinaryOpProvider") @@ -1905,7 +1905,7 @@ static void mulLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1922,7 +1922,7 @@ static void mulLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::mul); } @@ -1941,7 +1941,7 @@ static void divLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::div); } @@ -1962,7 +1962,7 @@ static void divLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::div); } @@ -1978,7 +1978,7 @@ static void ORLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::OR); } @Test(dataProvider = "longBinaryOpProvider") @@ -1992,7 +1992,7 @@ static void orLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::or); } @@ -2011,7 +2011,7 @@ static void ORLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::OR); } @@ -2027,7 +2027,7 @@ static void ANDLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::AND); } @Test(dataProvider = "longBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void andLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::and); } @@ -2060,7 +2060,7 @@ static void ANDLong256VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Long256VectorTests::AND); } @@ -2076,7 +2076,7 @@ static void ORLong256VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Long256VectorTests::OR); } @@ -2095,7 +2095,7 @@ static void ORLong256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Long256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Long256VectorTests::OR); } @@ -2110,7 +2110,7 @@ static void ADDLong256VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Long256VectorTests::ADD); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -2127,7 +2127,7 @@ static void ADDLong256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long256VectorTests::LSHL); + assertArraysEquals(r, a, b, Long256VectorTests::LSHL); } @@ -2170,7 +2170,7 @@ static void LSHLLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long256VectorTests::ASHR); + assertArraysEquals(r, a, b, Long256VectorTests::ASHR); } @@ -2218,7 +2218,7 @@ static void ASHRLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long256VectorTests::LSHR); + assertArraysEquals(r, a, b, Long256VectorTests::LSHR); } @@ -2266,7 +2266,7 @@ static void LSHRLong256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::MIN); + assertArraysEquals(r, a, b, Long256VectorTests::MIN); } static long min(long a, long b) { return (long)(Math.min(a, b)); @@ -2447,7 +2447,7 @@ static void minLong256VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::min); + assertArraysEquals(r, a, b, Long256VectorTests::min); } static long MAX(long a, long b) { return (long)(Math.max(a, b)); @@ -2467,7 +2467,7 @@ static void MAXLong256VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long256VectorTests::MAX); + assertArraysEquals(r, a, b, Long256VectorTests::MAX); } static long max(long a, long b) { return (long)(Math.max(a, b)); @@ -2485,7 +2485,7 @@ static void maxLong256VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::max); + assertArraysEquals(r, a, b, Long256VectorTests::max); } @Test(dataProvider = "longBinaryOpProvider") @@ -2499,7 +2499,7 @@ static void MINLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::MIN); } @Test(dataProvider = "longBinaryOpProvider") @@ -2513,7 +2513,7 @@ static void minLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::min); } @Test(dataProvider = "longBinaryOpProvider") @@ -2527,7 +2527,7 @@ static void MAXLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::MAX); } @Test(dataProvider = "longBinaryOpProvider") @@ -2541,7 +2541,7 @@ static void maxLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Long256VectorTests::max); } static long ANDReduce(long[] a, int idx) { @@ -2584,7 +2584,7 @@ static void ANDReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::ANDReduce, Long256VectorTests::ANDReduceAll); } @@ -2632,7 +2632,7 @@ static void ANDReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::ANDReduceMasked, Long256VectorTests::ANDReduceAllMasked); } @@ -2677,7 +2677,7 @@ static void ORReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::ORReduce, Long256VectorTests::ORReduceAll); } @@ -2725,7 +2725,7 @@ static void ORReduceLong256VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::ORReduceMasked, Long256VectorTests::ORReduceAllMasked); } @@ -2770,7 +2770,7 @@ static void XORReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::XORReduce, Long256VectorTests::XORReduceAll); } @@ -2818,7 +2818,7 @@ static void XORReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::XORReduceMasked, Long256VectorTests::XORReduceAllMasked); } @@ -2860,7 +2860,7 @@ static void ADDReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::ADDReduce, Long256VectorTests::ADDReduceAll); } static long ADDReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2904,7 +2904,7 @@ static void ADDReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::ADDReduceMasked, Long256VectorTests::ADDReduceAllMasked); } static long MULReduce(long[] a, int idx) { @@ -2945,7 +2945,7 @@ static void MULReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::MULReduce, Long256VectorTests::MULReduceAll); } static long MULReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2989,7 +2989,7 @@ static void MULReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::MULReduceMasked, Long256VectorTests::MULReduceAllMasked); } static long MINReduce(long[] a, int idx) { @@ -3030,7 +3030,7 @@ static void MINReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::MINReduce, Long256VectorTests::MINReduceAll); } static long MINReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3075,7 +3075,7 @@ static void MINReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::MINReduceMasked, Long256VectorTests::MINReduceAllMasked); } static long MAXReduce(long[] a, int idx) { @@ -3116,7 +3116,7 @@ static void MAXReduceLong256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::MAXReduce, Long256VectorTests::MAXReduceAll); } static long MAXReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3161,7 +3161,7 @@ static void MAXReduceLong256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::MAXReduceMasked, Long256VectorTests::MAXReduceAllMasked); } @@ -3187,7 +3187,7 @@ static void anyTrueLong256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long256VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Long256VectorTests::anyTrue); } @@ -3213,7 +3213,7 @@ static void allTrueLong256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long256VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Long256VectorTests::allTrue); } @@ -3229,7 +3229,7 @@ static void withLong256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (long)4, 0); + assertInsertArraysEquals(r, a, (long)4, 0); } static boolean testIS_DEFAULT(long a) { return bits(a)==0; @@ -3706,7 +3706,7 @@ static void blendLong256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Long256VectorTests::blend); + assertArraysEquals(r, a, b, mask, Long256VectorTests::blend); } @Test(dataProvider = "longUnaryOpShuffleProvider") @@ -3723,7 +3723,7 @@ static void RearrangeLong256VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpShuffleMaskProvider") @@ -3741,7 +3741,7 @@ static void RearrangeLong256VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "longUnaryOpProvider") static void getLong256VectorTests(IntFunction fa) { @@ -3896,7 +3896,7 @@ static void getLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::get); + assertArraysEquals(r, a, Long256VectorTests::get); } @Test(dataProvider = "longUnaryOpProvider") @@ -3910,7 +3910,7 @@ static void BroadcastLong256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3957,7 +3957,7 @@ static void sliceUnaryLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Long256VectorTests::sliceUnary); } static long[] sliceBinary(long[] a, long[] b, int origin, int idx) { long[] res = new long[SPECIES.length()]; @@ -3986,7 +3986,7 @@ static void sliceBinaryLong256VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Long256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Long256VectorTests::sliceBinary); } static long[] slice(long[] a, long[] b, int origin, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4019,7 +4019,7 @@ static void sliceLong256VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Long256VectorTests::unsliceUnary); } static long[] unsliceBinary(long[] a, long[] b, int origin, int part, int idx) { long[] res = new long[SPECIES.length()]; @@ -4085,7 +4085,7 @@ static void unsliceBinaryLong256VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Long256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Long256VectorTests::unsliceBinary); } static long[] unslice(long[] a, long[] b, int origin, int part, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4141,7 +4141,7 @@ static void unsliceLong256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Long256VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Long256VectorTests::unslice); } @@ -4190,7 +4190,7 @@ static void BITWISE_BLENDLong256VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Long256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Long256VectorTests::BITWISE_BLEND); } @Test(dataProvider = "longTernaryOpProvider") static void bitwiseBlendLong256VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4206,7 +4206,7 @@ static void bitwiseBlendLong256VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Long256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Long256VectorTests::BITWISE_BLEND); } @@ -4247,7 +4247,7 @@ static void BITWISE_BLENDLong256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4276,7 +4276,7 @@ static void bitwiseBlendLong256VectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Long256VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Long256VectorTests::bitwiseBlend); } @Test(dataProvider = "longTernaryOpProvider") @@ -4291,7 +4291,7 @@ static void bitwiseBlendLong256VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4362,7 +4362,7 @@ static void bitwiseBlendLong256VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::NEG); + assertArraysEquals(r, a, Long256VectorTests::NEG); } @Test(dataProvider = "longUnaryOpProvider") @@ -4420,7 +4420,7 @@ static void negLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::neg); + assertArraysEquals(r, a, Long256VectorTests::neg); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4438,7 +4438,7 @@ static void NEGMaskedLong256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long256VectorTests::NEG); + assertArraysEquals(r, a, mask, Long256VectorTests::NEG); } static long ABS(long a) { @@ -4461,7 +4461,7 @@ static void ABSLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::ABS); + assertArraysEquals(r, a, Long256VectorTests::ABS); } @Test(dataProvider = "longUnaryOpProvider") @@ -4476,7 +4476,7 @@ static void absLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::abs); + assertArraysEquals(r, a, Long256VectorTests::abs); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4494,7 +4494,7 @@ static void ABSMaskedLong256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long256VectorTests::ABS); + assertArraysEquals(r, a, mask, Long256VectorTests::ABS); } @@ -4520,7 +4520,7 @@ static void NOTLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::NOT); + assertArraysEquals(r, a, Long256VectorTests::NOT); } @Test(dataProvider = "longUnaryOpProvider") @@ -4535,7 +4535,7 @@ static void notLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::not); + assertArraysEquals(r, a, Long256VectorTests::not); } @@ -4555,7 +4555,7 @@ static void NOTMaskedLong256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long256VectorTests::NOT); + assertArraysEquals(r, a, mask, Long256VectorTests::NOT); } @@ -4578,7 +4578,7 @@ static void ZOMOLong256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long256VectorTests::ZOMO); + assertArraysEquals(r, a, Long256VectorTests::ZOMO); } @@ -4598,7 +4598,7 @@ static void ZOMOMaskedLong256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long256VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Long256VectorTests::ZOMO); } @@ -4626,7 +4626,7 @@ static void gatherLong256VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long256VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Long256VectorTests::scatterMasked); } @@ -4759,8 +4759,8 @@ static void toIntArrayLong256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4770,8 +4770,8 @@ static void toLongArrayLong256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4781,8 +4781,8 @@ static void toDoubleArrayLong256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4831,7 +4831,7 @@ static void ADDReduceLongLong256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long256VectorTests::ADDReduce, Long256VectorTests::ADDReduceAll); } @@ -4853,7 +4853,7 @@ static void ADDReduceLongLong256VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long256VectorTests::ADDReduceMasked, Long256VectorTests::ADDReduceAllMasked); } @@ -4870,7 +4870,7 @@ static void SelectFromLong256VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpSelectFromMaskProvider") @@ -4889,7 +4889,7 @@ static void SelectFromLong256VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4966,7 +4966,7 @@ static void maskEqLong256VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Long256VectorTests::beq); + assertArraysEquals(r, a, b, Long256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Long512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Long512VectorLoadStoreTests.java index b9da57a4ba6b0..c5724f854e429 100644 --- a/test/jdk/jdk/incubator/vector/Long512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Long512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Long512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(long[] a, long[] r, boolean[] mask) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0, "at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(long[] a, long[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "longProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new long[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Long512VectorTests.java b/test/jdk/jdk/incubator/vector/Long512VectorTests.java index fce11aa298a20..ca02ac5b7261d 100644 --- a/test/jdk/jdk/incubator/vector/Long512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Long512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { long apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { long[] apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { } catch (AssertionError e) { long[] ref = f.apply(a[i]); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { long apply(long[] a); } - static void assertReductionArraysEquals(long[] a, long[] b, long c, + static void assertReductionArraysEquals(long[] r, long rc, long[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { long apply(long[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(long[] a, long[] b, long c, boolean[] mask, + static void assertReductionArraysEqualsMasked(long[] r, long rc, long[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -159,37 +159,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(long[] a, long[] b, long element, int index) { + static void assertInsertArraysEquals(long[] r, long[] a, long element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -203,7 +203,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -217,7 +217,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int v } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -237,7 +237,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -257,7 +257,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boole } } - static void assertBroadcastArraysEquals(long[]a, long[]r) { + static void assertBroadcastArraysEquals(long[] r, long[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -286,7 +286,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -297,7 +297,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -309,7 +309,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -321,11 +321,11 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp } } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -336,11 +336,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -354,11 +354,11 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -372,7 +372,7 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolea } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -386,11 +386,11 @@ static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -416,7 +416,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -427,11 +427,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -443,7 +443,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -456,7 +456,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -469,12 +469,12 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -490,12 +490,12 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -511,7 +511,7 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -526,12 +526,12 @@ static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ interface FBinArrayOp { long apply(long[] a, int b); } - static void assertArraysEquals(long[] a, long[] r, FBinArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,7 +569,7 @@ interface FGatherScatterOp { long[] apply(long[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, FGatherScatterOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -596,7 +596,7 @@ interface FScatterMaskedOp { long[] apply(long[] r, long[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -606,7 +606,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } catch (AssertionError e) { long[] ref = f.apply(a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -617,7 +617,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -627,7 +627,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FSca } catch (AssertionError e) { long[] ref = f.apply(r, a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -644,7 +644,7 @@ interface FLaneOp { long[] apply(long[] a, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { + static void assertArraysEquals(long[] r, long[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { } catch (AssertionError e) { long[] ref = f.apply(a, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -664,7 +664,7 @@ interface FLaneBop { long[] apply(long[] a, long[] b, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -674,7 +674,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBo } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -685,7 +685,7 @@ interface FLaneMaskedBop { long[] apply(long[] a, long[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -695,7 +695,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -706,7 +706,7 @@ interface FLanePartBop { long[] apply(long[] a, long[] b, int origin, int part, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -716,7 +716,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -728,7 +728,7 @@ interface FLanePartMaskedBop { long[] apply(long[] a, long[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -780,7 +780,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(long[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -793,7 +793,7 @@ static void assertArraysEquals(long[] a, int[] r, int offs) { - static void assertArraysEquals(long[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -804,7 +804,7 @@ static void assertArraysEquals(long[] a, long[] r, int offs) { } } - static void assertArraysEquals(long[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1275,7 +1275,7 @@ static void ADDLong512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::ADD); + assertArraysEquals(r, a, b, Long512VectorTests::ADD); } static long add(long a, long b) { return (long)(a + b); @@ -1293,7 +1293,7 @@ static void addLong512VectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::add); + assertArraysEquals(r, a, b, Long512VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1313,7 +1313,7 @@ static void ADDLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::SUB); + assertArraysEquals(r, a, b, Long512VectorTests::SUB); } static long sub(long a, long b) { return (long)(a - b); @@ -1369,7 +1369,7 @@ static void subLong512VectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::sub); + assertArraysEquals(r, a, b, Long512VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1389,7 +1389,7 @@ static void SUBLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::MUL); + assertArraysEquals(r, a, b, Long512VectorTests::MUL); } static long mul(long a, long b) { return (long)(a * b); @@ -1445,7 +1445,7 @@ static void mulLong512VectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::mul); + assertArraysEquals(r, a, b, Long512VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1465,7 +1465,7 @@ static void MULLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::DIV); + assertArraysEquals(r, a, b, Long512VectorTests::DIV); } static long div(long a, long b) { return (long)(a / b); @@ -1530,7 +1530,7 @@ static void divLong512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::div); + assertArraysEquals(r, a, b, Long512VectorTests::div); } @@ -1554,7 +1554,7 @@ static void DIVLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, Long512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Long512VectorTests::FIRST_NONZERO); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1617,7 +1617,7 @@ static void FIRST_NONZEROLong512VectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, Long512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Long512VectorTests::FIRST_NONZERO); } static long AND(long a, long b) { @@ -1638,7 +1638,7 @@ static void ANDLong512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::AND); + assertArraysEquals(r, a, b, Long512VectorTests::AND); } static long and(long a, long b) { return (long)(a & b); @@ -1656,7 +1656,7 @@ static void andLong512VectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::and); + assertArraysEquals(r, a, b, Long512VectorTests::and); } @@ -1678,7 +1678,7 @@ static void ANDLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long512VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Long512VectorTests::AND_NOT); } @@ -1744,7 +1744,7 @@ static void ORLong512VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long512VectorTests::OR); + assertArraysEquals(r, a, b, Long512VectorTests::OR); } static long or(long a, long b) { return (long)(a | b); @@ -1762,7 +1762,7 @@ static void orLong512VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::or); + assertArraysEquals(r, a, b, Long512VectorTests::or); } @@ -1784,7 +1784,7 @@ static void ORLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::XOR); + assertArraysEquals(r, a, b, Long512VectorTests::XOR); } @@ -1828,7 +1828,7 @@ static void XORLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1860,7 +1860,7 @@ static void addLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::add); } @Test(dataProvider = "longBinaryOpProvider") @@ -1874,7 +1874,7 @@ static void subLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1891,7 +1891,7 @@ static void subLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::sub); } @Test(dataProvider = "longBinaryOpProvider") @@ -1905,7 +1905,7 @@ static void mulLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1922,7 +1922,7 @@ static void mulLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::mul); } @@ -1941,7 +1941,7 @@ static void divLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::div); } @@ -1962,7 +1962,7 @@ static void divLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::div); } @@ -1978,7 +1978,7 @@ static void ORLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::OR); } @Test(dataProvider = "longBinaryOpProvider") @@ -1992,7 +1992,7 @@ static void orLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::or); } @@ -2011,7 +2011,7 @@ static void ORLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::OR); } @@ -2027,7 +2027,7 @@ static void ANDLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::AND); } @Test(dataProvider = "longBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void andLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::and); } @@ -2060,7 +2060,7 @@ static void ANDLong512VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Long512VectorTests::AND); } @@ -2076,7 +2076,7 @@ static void ORLong512VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Long512VectorTests::OR); } @@ -2095,7 +2095,7 @@ static void ORLong512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Long512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Long512VectorTests::OR); } @@ -2110,7 +2110,7 @@ static void ADDLong512VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Long512VectorTests::ADD); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -2127,7 +2127,7 @@ static void ADDLong512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long512VectorTests::LSHL); + assertArraysEquals(r, a, b, Long512VectorTests::LSHL); } @@ -2170,7 +2170,7 @@ static void LSHLLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long512VectorTests::ASHR); + assertArraysEquals(r, a, b, Long512VectorTests::ASHR); } @@ -2218,7 +2218,7 @@ static void ASHRLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Long512VectorTests::LSHR); + assertArraysEquals(r, a, b, Long512VectorTests::LSHR); } @@ -2266,7 +2266,7 @@ static void LSHRLong512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::MIN); + assertArraysEquals(r, a, b, Long512VectorTests::MIN); } static long min(long a, long b) { return (long)(Math.min(a, b)); @@ -2447,7 +2447,7 @@ static void minLong512VectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::min); + assertArraysEquals(r, a, b, Long512VectorTests::min); } static long MAX(long a, long b) { return (long)(Math.max(a, b)); @@ -2467,7 +2467,7 @@ static void MAXLong512VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long512VectorTests::MAX); + assertArraysEquals(r, a, b, Long512VectorTests::MAX); } static long max(long a, long b) { return (long)(Math.max(a, b)); @@ -2485,7 +2485,7 @@ static void maxLong512VectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::max); + assertArraysEquals(r, a, b, Long512VectorTests::max); } @Test(dataProvider = "longBinaryOpProvider") @@ -2499,7 +2499,7 @@ static void MINLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::MIN); } @Test(dataProvider = "longBinaryOpProvider") @@ -2513,7 +2513,7 @@ static void minLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::min); } @Test(dataProvider = "longBinaryOpProvider") @@ -2527,7 +2527,7 @@ static void MAXLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::MAX); } @Test(dataProvider = "longBinaryOpProvider") @@ -2541,7 +2541,7 @@ static void maxLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Long512VectorTests::max); } static long ANDReduce(long[] a, int idx) { @@ -2584,7 +2584,7 @@ static void ANDReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::ANDReduce, Long512VectorTests::ANDReduceAll); } @@ -2632,7 +2632,7 @@ static void ANDReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::ANDReduceMasked, Long512VectorTests::ANDReduceAllMasked); } @@ -2677,7 +2677,7 @@ static void ORReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::ORReduce, Long512VectorTests::ORReduceAll); } @@ -2725,7 +2725,7 @@ static void ORReduceLong512VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::ORReduceMasked, Long512VectorTests::ORReduceAllMasked); } @@ -2770,7 +2770,7 @@ static void XORReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::XORReduce, Long512VectorTests::XORReduceAll); } @@ -2818,7 +2818,7 @@ static void XORReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::XORReduceMasked, Long512VectorTests::XORReduceAllMasked); } @@ -2860,7 +2860,7 @@ static void ADDReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::ADDReduce, Long512VectorTests::ADDReduceAll); } static long ADDReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2904,7 +2904,7 @@ static void ADDReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::ADDReduceMasked, Long512VectorTests::ADDReduceAllMasked); } static long MULReduce(long[] a, int idx) { @@ -2945,7 +2945,7 @@ static void MULReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::MULReduce, Long512VectorTests::MULReduceAll); } static long MULReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2989,7 +2989,7 @@ static void MULReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::MULReduceMasked, Long512VectorTests::MULReduceAllMasked); } static long MINReduce(long[] a, int idx) { @@ -3030,7 +3030,7 @@ static void MINReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::MINReduce, Long512VectorTests::MINReduceAll); } static long MINReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3075,7 +3075,7 @@ static void MINReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::MINReduceMasked, Long512VectorTests::MINReduceAllMasked); } static long MAXReduce(long[] a, int idx) { @@ -3116,7 +3116,7 @@ static void MAXReduceLong512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::MAXReduce, Long512VectorTests::MAXReduceAll); } static long MAXReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3161,7 +3161,7 @@ static void MAXReduceLong512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::MAXReduceMasked, Long512VectorTests::MAXReduceAllMasked); } @@ -3187,7 +3187,7 @@ static void anyTrueLong512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long512VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Long512VectorTests::anyTrue); } @@ -3213,7 +3213,7 @@ static void allTrueLong512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long512VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Long512VectorTests::allTrue); } @@ -3229,7 +3229,7 @@ static void withLong512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (long)4, 0); + assertInsertArraysEquals(r, a, (long)4, 0); } static boolean testIS_DEFAULT(long a) { return bits(a)==0; @@ -3706,7 +3706,7 @@ static void blendLong512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Long512VectorTests::blend); + assertArraysEquals(r, a, b, mask, Long512VectorTests::blend); } @Test(dataProvider = "longUnaryOpShuffleProvider") @@ -3723,7 +3723,7 @@ static void RearrangeLong512VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpShuffleMaskProvider") @@ -3741,7 +3741,7 @@ static void RearrangeLong512VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "longUnaryOpProvider") static void getLong512VectorTests(IntFunction fa) { @@ -3896,7 +3896,7 @@ static void getLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::get); + assertArraysEquals(r, a, Long512VectorTests::get); } @Test(dataProvider = "longUnaryOpProvider") @@ -3910,7 +3910,7 @@ static void BroadcastLong512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3957,7 +3957,7 @@ static void sliceUnaryLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Long512VectorTests::sliceUnary); } static long[] sliceBinary(long[] a, long[] b, int origin, int idx) { long[] res = new long[SPECIES.length()]; @@ -3986,7 +3986,7 @@ static void sliceBinaryLong512VectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, Long512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Long512VectorTests::sliceBinary); } static long[] slice(long[] a, long[] b, int origin, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4019,7 +4019,7 @@ static void sliceLong512VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Long512VectorTests::unsliceUnary); } static long[] unsliceBinary(long[] a, long[] b, int origin, int part, int idx) { long[] res = new long[SPECIES.length()]; @@ -4085,7 +4085,7 @@ static void unsliceBinaryLong512VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, Long512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Long512VectorTests::unsliceBinary); } static long[] unslice(long[] a, long[] b, int origin, int part, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4141,7 +4141,7 @@ static void unsliceLong512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, Long512VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Long512VectorTests::unslice); } @@ -4190,7 +4190,7 @@ static void BITWISE_BLENDLong512VectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, Long512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Long512VectorTests::BITWISE_BLEND); } @Test(dataProvider = "longTernaryOpProvider") static void bitwiseBlendLong512VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4206,7 +4206,7 @@ static void bitwiseBlendLong512VectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, Long512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Long512VectorTests::BITWISE_BLEND); } @@ -4247,7 +4247,7 @@ static void BITWISE_BLENDLong512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4276,7 +4276,7 @@ static void bitwiseBlendLong512VectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Long512VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Long512VectorTests::bitwiseBlend); } @Test(dataProvider = "longTernaryOpProvider") @@ -4291,7 +4291,7 @@ static void bitwiseBlendLong512VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4362,7 +4362,7 @@ static void bitwiseBlendLong512VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::NEG); + assertArraysEquals(r, a, Long512VectorTests::NEG); } @Test(dataProvider = "longUnaryOpProvider") @@ -4420,7 +4420,7 @@ static void negLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::neg); + assertArraysEquals(r, a, Long512VectorTests::neg); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4438,7 +4438,7 @@ static void NEGMaskedLong512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long512VectorTests::NEG); + assertArraysEquals(r, a, mask, Long512VectorTests::NEG); } static long ABS(long a) { @@ -4461,7 +4461,7 @@ static void ABSLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::ABS); + assertArraysEquals(r, a, Long512VectorTests::ABS); } @Test(dataProvider = "longUnaryOpProvider") @@ -4476,7 +4476,7 @@ static void absLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::abs); + assertArraysEquals(r, a, Long512VectorTests::abs); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4494,7 +4494,7 @@ static void ABSMaskedLong512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long512VectorTests::ABS); + assertArraysEquals(r, a, mask, Long512VectorTests::ABS); } @@ -4520,7 +4520,7 @@ static void NOTLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::NOT); + assertArraysEquals(r, a, Long512VectorTests::NOT); } @Test(dataProvider = "longUnaryOpProvider") @@ -4535,7 +4535,7 @@ static void notLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::not); + assertArraysEquals(r, a, Long512VectorTests::not); } @@ -4555,7 +4555,7 @@ static void NOTMaskedLong512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long512VectorTests::NOT); + assertArraysEquals(r, a, mask, Long512VectorTests::NOT); } @@ -4578,7 +4578,7 @@ static void ZOMOLong512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long512VectorTests::ZOMO); + assertArraysEquals(r, a, Long512VectorTests::ZOMO); } @@ -4598,7 +4598,7 @@ static void ZOMOMaskedLong512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long512VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Long512VectorTests::ZOMO); } @@ -4626,7 +4626,7 @@ static void gatherLong512VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, Long512VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Long512VectorTests::scatterMasked); } @@ -4759,8 +4759,8 @@ static void toIntArrayLong512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4770,8 +4770,8 @@ static void toLongArrayLong512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4781,8 +4781,8 @@ static void toDoubleArrayLong512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4831,7 +4831,7 @@ static void ADDReduceLongLong512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long512VectorTests::ADDReduce, Long512VectorTests::ADDReduceAll); } @@ -4853,7 +4853,7 @@ static void ADDReduceLongLong512VectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long512VectorTests::ADDReduceMasked, Long512VectorTests::ADDReduceAllMasked); } @@ -4870,7 +4870,7 @@ static void SelectFromLong512VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpSelectFromMaskProvider") @@ -4889,7 +4889,7 @@ static void SelectFromLong512VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4966,7 +4966,7 @@ static void maskEqLong512VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Long512VectorTests::beq); + assertArraysEquals(r, a, b, Long512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Long64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Long64VectorLoadStoreTests.java index f832bc0e1544a..c0764c57196b0 100644 --- a/test/jdk/jdk/incubator/vector/Long64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Long64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Long64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(long[] a, long[] r, boolean[] mask) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0, "at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(long[] a, long[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "longProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new long[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Long64VectorTests.java b/test/jdk/jdk/incubator/vector/Long64VectorTests.java index 1df5de54d4067..2ba810968c04b 100644 --- a/test/jdk/jdk/incubator/vector/Long64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Long64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { long apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { long[] apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { } catch (AssertionError e) { long[] ref = f.apply(a[i]); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { long apply(long[] a); } - static void assertReductionArraysEquals(long[] a, long[] b, long c, + static void assertReductionArraysEquals(long[] r, long rc, long[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { long apply(long[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(long[] a, long[] b, long c, boolean[] mask, + static void assertReductionArraysEqualsMasked(long[] r, long rc, long[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -159,37 +159,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(long[] a, long[] b, long element, int index) { + static void assertInsertArraysEquals(long[] r, long[] a, long element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -203,7 +203,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -217,7 +217,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int v } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -237,7 +237,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -257,7 +257,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boole } } - static void assertBroadcastArraysEquals(long[]a, long[]r) { + static void assertBroadcastArraysEquals(long[] r, long[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -286,7 +286,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -297,7 +297,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -309,7 +309,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -321,11 +321,11 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp } } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -336,11 +336,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -354,11 +354,11 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -372,7 +372,7 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolea } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -386,11 +386,11 @@ static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -416,7 +416,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -427,11 +427,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -443,7 +443,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -456,7 +456,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -469,12 +469,12 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -490,12 +490,12 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -511,7 +511,7 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -526,12 +526,12 @@ static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ interface FBinArrayOp { long apply(long[] a, int b); } - static void assertArraysEquals(long[] a, long[] r, FBinArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,7 +569,7 @@ interface FGatherScatterOp { long[] apply(long[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, FGatherScatterOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -596,7 +596,7 @@ interface FScatterMaskedOp { long[] apply(long[] r, long[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -606,7 +606,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } catch (AssertionError e) { long[] ref = f.apply(a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -617,7 +617,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -627,7 +627,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FSca } catch (AssertionError e) { long[] ref = f.apply(r, a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -644,7 +644,7 @@ interface FLaneOp { long[] apply(long[] a, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { + static void assertArraysEquals(long[] r, long[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { } catch (AssertionError e) { long[] ref = f.apply(a, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -664,7 +664,7 @@ interface FLaneBop { long[] apply(long[] a, long[] b, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -674,7 +674,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBo } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -685,7 +685,7 @@ interface FLaneMaskedBop { long[] apply(long[] a, long[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -695,7 +695,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -706,7 +706,7 @@ interface FLanePartBop { long[] apply(long[] a, long[] b, int origin, int part, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -716,7 +716,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -728,7 +728,7 @@ interface FLanePartMaskedBop { long[] apply(long[] a, long[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -780,7 +780,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(long[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -793,7 +793,7 @@ static void assertArraysEquals(long[] a, int[] r, int offs) { - static void assertArraysEquals(long[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -804,7 +804,7 @@ static void assertArraysEquals(long[] a, long[] r, int offs) { } } - static void assertArraysEquals(long[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1275,7 +1275,7 @@ static void ADDLong64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::ADD); + assertArraysEquals(r, a, b, Long64VectorTests::ADD); } static long add(long a, long b) { return (long)(a + b); @@ -1293,7 +1293,7 @@ static void addLong64VectorTests(IntFunction fa, IntFunction fb) av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::add); + assertArraysEquals(r, a, b, Long64VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1313,7 +1313,7 @@ static void ADDLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::SUB); + assertArraysEquals(r, a, b, Long64VectorTests::SUB); } static long sub(long a, long b) { return (long)(a - b); @@ -1369,7 +1369,7 @@ static void subLong64VectorTests(IntFunction fa, IntFunction fb) av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::sub); + assertArraysEquals(r, a, b, Long64VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1389,7 +1389,7 @@ static void SUBLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::MUL); + assertArraysEquals(r, a, b, Long64VectorTests::MUL); } static long mul(long a, long b) { return (long)(a * b); @@ -1445,7 +1445,7 @@ static void mulLong64VectorTests(IntFunction fa, IntFunction fb) av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::mul); + assertArraysEquals(r, a, b, Long64VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1465,7 +1465,7 @@ static void MULLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::DIV); + assertArraysEquals(r, a, b, Long64VectorTests::DIV); } static long div(long a, long b) { return (long)(a / b); @@ -1530,7 +1530,7 @@ static void divLong64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::div); + assertArraysEquals(r, a, b, Long64VectorTests::div); } @@ -1554,7 +1554,7 @@ static void DIVLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, mask, Long64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Long64VectorTests::FIRST_NONZERO); } static long AND(long a, long b) { @@ -1638,7 +1638,7 @@ static void ANDLong64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::AND); + assertArraysEquals(r, a, b, Long64VectorTests::AND); } static long and(long a, long b) { return (long)(a & b); @@ -1656,7 +1656,7 @@ static void andLong64VectorTests(IntFunction fa, IntFunction fb) av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::and); + assertArraysEquals(r, a, b, Long64VectorTests::and); } @@ -1678,7 +1678,7 @@ static void ANDLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Long64VectorTests::AND_NOT); + assertArraysEquals(r, a, b, Long64VectorTests::AND_NOT); } @@ -1722,7 +1722,7 @@ static void AND_NOTLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::OR); + assertArraysEquals(r, a, b, Long64VectorTests::OR); } static long or(long a, long b) { return (long)(a | b); @@ -1762,7 +1762,7 @@ static void orLong64VectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::or); + assertArraysEquals(r, a, b, Long64VectorTests::or); } @@ -1784,7 +1784,7 @@ static void ORLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::XOR); + assertArraysEquals(r, a, b, Long64VectorTests::XOR); } @@ -1828,7 +1828,7 @@ static void XORLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFu av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1860,7 +1860,7 @@ static void addLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::add); } @Test(dataProvider = "longBinaryOpProvider") @@ -1874,7 +1874,7 @@ static void subLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1891,7 +1891,7 @@ static void subLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::sub); } @Test(dataProvider = "longBinaryOpProvider") @@ -1905,7 +1905,7 @@ static void mulLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1922,7 +1922,7 @@ static void mulLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::mul); } @@ -1941,7 +1941,7 @@ static void divLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::div); } @@ -1962,7 +1962,7 @@ static void divLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::div); } @@ -1978,7 +1978,7 @@ static void ORLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::OR); } @Test(dataProvider = "longBinaryOpProvider") @@ -1992,7 +1992,7 @@ static void orLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFun av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::or); } @@ -2011,7 +2011,7 @@ static void ORLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::OR); } @@ -2027,7 +2027,7 @@ static void ANDLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::AND); } @Test(dataProvider = "longBinaryOpProvider") @@ -2041,7 +2041,7 @@ static void andLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::and); } @@ -2060,7 +2060,7 @@ static void ANDLong64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Long64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Long64VectorTests::AND); } @@ -2076,7 +2076,7 @@ static void ORLong64VectorTestsBroadcastLongSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Long64VectorTests::OR); } @@ -2095,7 +2095,7 @@ static void ORLong64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Long64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, Long64VectorTests::OR); } @@ -2110,7 +2110,7 @@ static void ADDLong64VectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Long64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Long64VectorTests::ADD); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -2127,7 +2127,7 @@ static void ADDLong64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.ADD, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, Long64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, mask, Long64VectorTests::ADD); } static long LSHL(long a, long b) { @@ -2148,7 +2148,7 @@ static void LSHLLong64VectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long64VectorTests::LSHL); + assertArraysEquals(r, a, b, Long64VectorTests::LSHL); } @@ -2170,7 +2170,7 @@ static void LSHLLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long64VectorTests::ASHR); + assertArraysEquals(r, a, b, Long64VectorTests::ASHR); } @@ -2218,7 +2218,7 @@ static void ASHRLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, Long64VectorTests::LSHR); + assertArraysEquals(r, a, b, Long64VectorTests::LSHR); } @@ -2266,7 +2266,7 @@ static void LSHRLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::MIN); + assertArraysEquals(r, a, b, Long64VectorTests::MIN); } static long min(long a, long b) { return (long)(Math.min(a, b)); @@ -2447,7 +2447,7 @@ static void minLong64VectorTests(IntFunction fa, IntFunction fb) av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::min); + assertArraysEquals(r, a, b, Long64VectorTests::min); } static long MAX(long a, long b) { return (long)(Math.max(a, b)); @@ -2467,7 +2467,7 @@ static void MAXLong64VectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, Long64VectorTests::MAX); + assertArraysEquals(r, a, b, Long64VectorTests::MAX); } static long max(long a, long b) { return (long)(Math.max(a, b)); @@ -2485,7 +2485,7 @@ static void maxLong64VectorTests(IntFunction fa, IntFunction fb) av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::max); + assertArraysEquals(r, a, b, Long64VectorTests::max); } @Test(dataProvider = "longBinaryOpProvider") @@ -2499,7 +2499,7 @@ static void MINLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::MIN); } @Test(dataProvider = "longBinaryOpProvider") @@ -2513,7 +2513,7 @@ static void minLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::min); } @Test(dataProvider = "longBinaryOpProvider") @@ -2527,7 +2527,7 @@ static void MAXLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::MAX); } @Test(dataProvider = "longBinaryOpProvider") @@ -2541,7 +2541,7 @@ static void maxLong64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Long64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Long64VectorTests::max); } static long ANDReduce(long[] a, int idx) { @@ -2584,7 +2584,7 @@ static void ANDReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::ANDReduce, Long64VectorTests::ANDReduceAll); } @@ -2632,7 +2632,7 @@ static void ANDReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::ANDReduceMasked, Long64VectorTests::ANDReduceAllMasked); } @@ -2677,7 +2677,7 @@ static void ORReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::ORReduce, Long64VectorTests::ORReduceAll); } @@ -2725,7 +2725,7 @@ static void ORReduceLong64VectorTestsMasked(IntFunction fa, IntFunction< } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::ORReduceMasked, Long64VectorTests::ORReduceAllMasked); } @@ -2770,7 +2770,7 @@ static void XORReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::XORReduce, Long64VectorTests::XORReduceAll); } @@ -2818,7 +2818,7 @@ static void XORReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::XORReduceMasked, Long64VectorTests::XORReduceAllMasked); } @@ -2860,7 +2860,7 @@ static void ADDReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::ADDReduce, Long64VectorTests::ADDReduceAll); } static long ADDReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2904,7 +2904,7 @@ static void ADDReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::ADDReduceMasked, Long64VectorTests::ADDReduceAllMasked); } static long MULReduce(long[] a, int idx) { @@ -2945,7 +2945,7 @@ static void MULReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::MULReduce, Long64VectorTests::MULReduceAll); } static long MULReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2989,7 +2989,7 @@ static void MULReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::MULReduceMasked, Long64VectorTests::MULReduceAllMasked); } static long MINReduce(long[] a, int idx) { @@ -3030,7 +3030,7 @@ static void MINReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::MINReduce, Long64VectorTests::MINReduceAll); } static long MINReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3075,7 +3075,7 @@ static void MINReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::MINReduceMasked, Long64VectorTests::MINReduceAllMasked); } static long MAXReduce(long[] a, int idx) { @@ -3116,7 +3116,7 @@ static void MAXReduceLong64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::MAXReduce, Long64VectorTests::MAXReduceAll); } static long MAXReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3161,7 +3161,7 @@ static void MAXReduceLong64VectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::MAXReduceMasked, Long64VectorTests::MAXReduceAllMasked); } @@ -3187,7 +3187,7 @@ static void anyTrueLong64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long64VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Long64VectorTests::anyTrue); } @@ -3213,7 +3213,7 @@ static void allTrueLong64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Long64VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Long64VectorTests::allTrue); } @@ -3229,7 +3229,7 @@ static void withLong64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (long)4, 0); + assertInsertArraysEquals(r, a, (long)4, 0); } static boolean testIS_DEFAULT(long a) { return bits(a)==0; @@ -3706,7 +3706,7 @@ static void blendLong64VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, mask, Long64VectorTests::blend); + assertArraysEquals(r, a, b, mask, Long64VectorTests::blend); } @Test(dataProvider = "longUnaryOpShuffleProvider") @@ -3723,7 +3723,7 @@ static void RearrangeLong64VectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpShuffleMaskProvider") @@ -3741,7 +3741,7 @@ static void RearrangeLong64VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "longUnaryOpProvider") static void getLong64VectorTests(IntFunction fa) { @@ -3896,7 +3896,7 @@ static void getLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::get); + assertArraysEquals(r, a, Long64VectorTests::get); } @Test(dataProvider = "longUnaryOpProvider") @@ -3910,7 +3910,7 @@ static void BroadcastLong64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3957,7 +3957,7 @@ static void sliceUnaryLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Long64VectorTests::sliceUnary); } static long[] sliceBinary(long[] a, long[] b, int origin, int idx) { long[] res = new long[SPECIES.length()]; @@ -3986,7 +3986,7 @@ static void sliceBinaryLong64VectorTestsBinary(IntFunction fa, IntFuncti } } - assertArraysEquals(a, b, r, origin, Long64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Long64VectorTests::sliceBinary); } static long[] slice(long[] a, long[] b, int origin, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4019,7 +4019,7 @@ static void sliceLong64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Long64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Long64VectorTests::unsliceUnary); } static long[] unsliceBinary(long[] a, long[] b, int origin, int part, int idx) { long[] res = new long[SPECIES.length()]; @@ -4085,7 +4085,7 @@ static void unsliceBinaryLong64VectorTestsBinary(IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, origin, part, Long64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Long64VectorTests::unsliceBinary); } static long[] unslice(long[] a, long[] b, int origin, int part, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4141,7 +4141,7 @@ static void unsliceLong64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4206,7 +4206,7 @@ static void bitwiseBlendLong64VectorTests(IntFunction fa, IntFunction fa, IntFunc } } - assertArraysEquals(a, b, c, r, mask, Long64VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Long64VectorTests::BITWISE_BLEND); } @@ -4247,7 +4247,7 @@ static void BITWISE_BLENDLong64VectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.BITWISE_BLEND, bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Long64VectorTests::BITWISE_BLEND); + assertBroadcastArraysEquals(r, a, b, c, Long64VectorTests::BITWISE_BLEND); } @Test(dataProvider = "longTernaryOpProvider") @@ -4262,7 +4262,7 @@ static void BITWISE_BLENDLong64VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4276,7 +4276,7 @@ static void bitwiseBlendLong64VectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, Long64VectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, Long64VectorTests::bitwiseBlend); } @Test(dataProvider = "longTernaryOpProvider") @@ -4291,7 +4291,7 @@ static void bitwiseBlendLong64VectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4362,7 +4362,7 @@ static void bitwiseBlendLong64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::NEG); + assertArraysEquals(r, a, Long64VectorTests::NEG); } @Test(dataProvider = "longUnaryOpProvider") @@ -4420,7 +4420,7 @@ static void negLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::neg); + assertArraysEquals(r, a, Long64VectorTests::neg); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4438,7 +4438,7 @@ static void NEGMaskedLong64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long64VectorTests::NEG); + assertArraysEquals(r, a, mask, Long64VectorTests::NEG); } static long ABS(long a) { @@ -4461,7 +4461,7 @@ static void ABSLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::ABS); + assertArraysEquals(r, a, Long64VectorTests::ABS); } @Test(dataProvider = "longUnaryOpProvider") @@ -4476,7 +4476,7 @@ static void absLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::abs); + assertArraysEquals(r, a, Long64VectorTests::abs); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4494,7 +4494,7 @@ static void ABSMaskedLong64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long64VectorTests::ABS); + assertArraysEquals(r, a, mask, Long64VectorTests::ABS); } @@ -4520,7 +4520,7 @@ static void NOTLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::NOT); + assertArraysEquals(r, a, Long64VectorTests::NOT); } @Test(dataProvider = "longUnaryOpProvider") @@ -4535,7 +4535,7 @@ static void notLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::not); + assertArraysEquals(r, a, Long64VectorTests::not); } @@ -4555,7 +4555,7 @@ static void NOTMaskedLong64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long64VectorTests::NOT); + assertArraysEquals(r, a, mask, Long64VectorTests::NOT); } @@ -4578,7 +4578,7 @@ static void ZOMOLong64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Long64VectorTests::ZOMO); + assertArraysEquals(r, a, Long64VectorTests::ZOMO); } @@ -4598,7 +4598,7 @@ static void ZOMOMaskedLong64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Long64VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Long64VectorTests::ZOMO); } @@ -4626,7 +4626,7 @@ static void gatherLong64VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4770,8 +4770,8 @@ static void toLongArrayLong64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4781,8 +4781,8 @@ static void toDoubleArrayLong64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4831,7 +4831,7 @@ static void ADDReduceLongLong64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Long64VectorTests::ADDReduce, Long64VectorTests::ADDReduceAll); } @@ -4853,7 +4853,7 @@ static void ADDReduceLongLong64VectorTestsMasked(IntFunction fa, IntFunc ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Long64VectorTests::ADDReduceMasked, Long64VectorTests::ADDReduceAllMasked); } @@ -4870,7 +4870,7 @@ static void SelectFromLong64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpSelectFromMaskProvider") @@ -4889,7 +4889,7 @@ static void SelectFromLong64VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4966,7 +4966,7 @@ static void maskEqLong64VectorTestsSmokeTest(IntFunction fa, IntFunct var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Long64VectorTests::beq); + assertArraysEquals(r, a, b, Long64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/LongMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/LongMaxVectorLoadStoreTests.java index a48bd7452d70d..4f092652734c0 100644 --- a/test/jdk/jdk/incubator/vector/LongMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/LongMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -67,47 +67,25 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(long[] a, long[] r, boolean[] mask) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (long) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (long) 0, "at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(long[] a, long[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (long) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -410,7 +388,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "longProviderForIOOBE") @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new long[a.length]; @@ -492,7 +470,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longMaskProviderForIOOBE") @@ -565,7 +543,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -589,7 +567,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -676,7 +654,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -691,7 +669,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -807,7 +785,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "longByteProviderForIOOBE") @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -899,7 +877,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "longByteMaskProviderForIOOBE") @@ -976,7 +954,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -987,7 +965,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/LongMaxVectorTests.java b/test/jdk/jdk/incubator/vector/LongMaxVectorTests.java index 9c878b3529ef6..364ae80ddc50a 100644 --- a/test/jdk/jdk/incubator/vector/LongMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/LongMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { long apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { long[] apply(long a); } - static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(long[] a, long[] r, FUnArrayOp f) { } catch (AssertionError e) { long[] ref = f.apply(a[i]); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(long[] a, long[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(long[] r, long[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { long apply(long[] a); } - static void assertReductionArraysEquals(long[] a, long[] b, long c, + static void assertReductionArraysEquals(long[] r, long rc, long[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { long apply(long[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(long[] a, long[] b, long c, boolean[] mask, + static void assertReductionArraysEqualsMasked(long[] r, long rc, long[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -164,37 +164,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(long[] a, long[] b, long element, int index) { + static void assertInsertArraysEquals(long[] r, long[] a, long element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -208,7 +208,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, int vec } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -222,7 +222,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, int v } } - static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(long[] r, long[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -242,7 +242,7 @@ static void assertRearrangeArraysEquals(long[] a, long[] r, int[] order, boolean } } - static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(long[] r, long[] a, long[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -262,7 +262,7 @@ static void assertSelectFromArraysEquals(long[] a, long[] r, long[] order, boole } } - static void assertBroadcastArraysEquals(long[]a, long[]r) { + static void assertBroadcastArraysEquals(long[] r, long[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -291,7 +291,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -302,7 +302,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -314,7 +314,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, FBinOp f) } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -326,11 +326,11 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, FBinOp } } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -341,11 +341,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBi } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -359,11 +359,11 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] r, boolean[] } } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -377,7 +377,7 @@ static void assertBroadcastLongArraysEquals(long[] a, long[] b, long[] r, boolea } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -391,11 +391,11 @@ static void assertShiftArraysEquals(long[] a, long[] b, long[] r, FBinOp f) { } } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(long[] a, long[] b, long[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(long[] r, long[] a, long[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -421,7 +421,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -432,11 +432,11 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f } } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -448,7 +448,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -461,7 +461,7 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -474,12 +474,12 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -495,12 +495,12 @@ static void assertBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, } } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -516,7 +516,7 @@ static void assertAltBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -531,12 +531,12 @@ static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long } } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(long[] a, long[] b, long[] c, long[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(long[] r, long[] a, long[] b, long[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ interface FBinArrayOp { long apply(long[] a, int b); } - static void assertArraysEquals(long[] a, long[] r, FBinArrayOp f) { + static void assertArraysEquals(long[] r, long[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,7 +574,7 @@ interface FGatherScatterOp { long[] apply(long[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, FGatherScatterOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -601,7 +601,7 @@ interface FScatterMaskedOp { long[] apply(long[] r, long[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -611,7 +611,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } catch (AssertionError e) { long[] ref = f.apply(a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -622,7 +622,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FGat } } - static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(long[] r, long[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -632,7 +632,7 @@ static void assertArraysEquals(long[] a, int[] b, long[] r, boolean[] mask, FSca } catch (AssertionError e) { long[] ref = f.apply(r, a, i, mask, b, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -649,7 +649,7 @@ interface FLaneOp { long[] apply(long[] a, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { + static void assertArraysEquals(long[] r, long[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -659,7 +659,7 @@ static void assertArraysEquals(long[] a, long[] r, int origin, FLaneOp f) { } catch (AssertionError e) { long[] ref = f.apply(a, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -669,7 +669,7 @@ interface FLaneBop { long[] apply(long[] a, long[] b, int origin, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -679,7 +679,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, FLaneBo } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -690,7 +690,7 @@ interface FLaneMaskedBop { long[] apply(long[] a, long[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -700,7 +700,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, boolean } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -711,7 +711,7 @@ interface FLanePartBop { long[] apply(long[] a, long[] b, int origin, int part, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -721,7 +721,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -733,7 +733,7 @@ interface FLanePartMaskedBop { long[] apply(long[] a, long[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(long[] r, long[] a, long[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -743,7 +743,7 @@ static void assertArraysEquals(long[] a, long[] b, long[] r, int origin, int par } catch (AssertionError e) { long[] ref = f.apply(a, b, origin, part, mask, i); long[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -785,7 +785,7 @@ static int intCornerCaseValue(int i) { }) ); - static void assertArraysEquals(long[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -798,7 +798,7 @@ static void assertArraysEquals(long[] a, int[] r, int offs) { - static void assertArraysEquals(long[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -809,7 +809,7 @@ static void assertArraysEquals(long[] a, long[] r, int offs) { } } - static void assertArraysEquals(long[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, long[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1280,7 +1280,7 @@ static void ADDLongMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::ADD); + assertArraysEquals(r, a, b, LongMaxVectorTests::ADD); } static long add(long a, long b) { return (long)(a + b); @@ -1298,7 +1298,7 @@ static void addLongMaxVectorTests(IntFunction fa, IntFunction fb av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::add); + assertArraysEquals(r, a, b, LongMaxVectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1318,7 +1318,7 @@ static void ADDLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::SUB); + assertArraysEquals(r, a, b, LongMaxVectorTests::SUB); } static long sub(long a, long b) { return (long)(a - b); @@ -1374,7 +1374,7 @@ static void subLongMaxVectorTests(IntFunction fa, IntFunction fb av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::sub); + assertArraysEquals(r, a, b, LongMaxVectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1394,7 +1394,7 @@ static void SUBLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::MUL); + assertArraysEquals(r, a, b, LongMaxVectorTests::MUL); } static long mul(long a, long b) { return (long)(a * b); @@ -1450,7 +1450,7 @@ static void mulLongMaxVectorTests(IntFunction fa, IntFunction fb av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::mul); + assertArraysEquals(r, a, b, LongMaxVectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1470,7 +1470,7 @@ static void MULLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::DIV); + assertArraysEquals(r, a, b, LongMaxVectorTests::DIV); } static long div(long a, long b) { return (long)(a / b); @@ -1535,7 +1535,7 @@ static void divLongMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::div); + assertArraysEquals(r, a, b, LongMaxVectorTests::div); } @@ -1559,7 +1559,7 @@ static void DIVLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, LongMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, LongMaxVectorTests::FIRST_NONZERO); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1622,7 +1622,7 @@ static void FIRST_NONZEROLongMaxVectorTestsMasked(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, mask, LongMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, LongMaxVectorTests::FIRST_NONZERO); } static long AND(long a, long b) { @@ -1643,7 +1643,7 @@ static void ANDLongMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::AND); + assertArraysEquals(r, a, b, LongMaxVectorTests::AND); } static long and(long a, long b) { return (long)(a & b); @@ -1661,7 +1661,7 @@ static void andLongMaxVectorTests(IntFunction fa, IntFunction fb av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::and); + assertArraysEquals(r, a, b, LongMaxVectorTests::and); } @@ -1683,7 +1683,7 @@ static void ANDLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, LongMaxVectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, LongMaxVectorTests::AND_NOT); } @@ -1749,7 +1749,7 @@ static void ORLongMaxVectorTests(IntFunction fa, IntFunction fb) } } - assertArraysEquals(a, b, r, LongMaxVectorTests::OR); + assertArraysEquals(r, a, b, LongMaxVectorTests::OR); } static long or(long a, long b) { return (long)(a | b); @@ -1767,7 +1767,7 @@ static void orLongMaxVectorTests(IntFunction fa, IntFunction fb) av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::or); + assertArraysEquals(r, a, b, LongMaxVectorTests::or); } @@ -1789,7 +1789,7 @@ static void ORLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::XOR); + assertArraysEquals(r, a, b, LongMaxVectorTests::XOR); } @@ -1833,7 +1833,7 @@ static void XORLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntF av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::add); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1865,7 +1865,7 @@ static void addLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::add); } @Test(dataProvider = "longBinaryOpProvider") @@ -1879,7 +1879,7 @@ static void subLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::sub); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1896,7 +1896,7 @@ static void subLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::sub); } @Test(dataProvider = "longBinaryOpProvider") @@ -1910,7 +1910,7 @@ static void mulLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::mul); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -1927,7 +1927,7 @@ static void mulLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::mul); } @@ -1946,7 +1946,7 @@ static void divLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::div); } @@ -1967,7 +1967,7 @@ static void divLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::div); } @@ -1983,7 +1983,7 @@ static void ORLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::OR); } @Test(dataProvider = "longBinaryOpProvider") @@ -1997,7 +1997,7 @@ static void orLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFu av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::or); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::or); } @@ -2016,7 +2016,7 @@ static void ORLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::OR); } @@ -2032,7 +2032,7 @@ static void ANDLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::AND); } @Test(dataProvider = "longBinaryOpProvider") @@ -2046,7 +2046,7 @@ static void andLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::and); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::and); } @@ -2065,7 +2065,7 @@ static void ANDLongMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, LongMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, LongMaxVectorTests::AND); } @@ -2081,7 +2081,7 @@ static void ORLongMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, I av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, LongMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, LongMaxVectorTests::OR); } @@ -2100,7 +2100,7 @@ static void ORLongMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction av.lanewise(VectorOperators.OR, (long)b[i], vmask).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, mask, LongMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, mask, LongMaxVectorTests::OR); } @@ -2115,7 +2115,7 @@ static void ADDLongMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, LongMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, LongMaxVectorTests::ADD); } @Test(dataProvider = "longBinaryOpMaskProvider") @@ -2132,7 +2132,7 @@ static void ADDLongMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, LongMaxVectorTests::LSHL); + assertArraysEquals(r, a, b, LongMaxVectorTests::LSHL); } @@ -2175,7 +2175,7 @@ static void LSHLLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, LongMaxVectorTests::ASHR); + assertArraysEquals(r, a, b, LongMaxVectorTests::ASHR); } @@ -2223,7 +2223,7 @@ static void ASHRLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, LongMaxVectorTests::LSHR); + assertArraysEquals(r, a, b, LongMaxVectorTests::LSHR); } @@ -2271,7 +2271,7 @@ static void LSHRLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::MIN); + assertArraysEquals(r, a, b, LongMaxVectorTests::MIN); } static long min(long a, long b) { return (long)(Math.min(a, b)); @@ -2452,7 +2452,7 @@ static void minLongMaxVectorTests(IntFunction fa, IntFunction fb av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::min); + assertArraysEquals(r, a, b, LongMaxVectorTests::min); } static long MAX(long a, long b) { return (long)(Math.max(a, b)); @@ -2472,7 +2472,7 @@ static void MAXLongMaxVectorTests(IntFunction fa, IntFunction fb } } - assertArraysEquals(a, b, r, LongMaxVectorTests::MAX); + assertArraysEquals(r, a, b, LongMaxVectorTests::MAX); } static long max(long a, long b) { return (long)(Math.max(a, b)); @@ -2490,7 +2490,7 @@ static void maxLongMaxVectorTests(IntFunction fa, IntFunction fb av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::max); + assertArraysEquals(r, a, b, LongMaxVectorTests::max); } @Test(dataProvider = "longBinaryOpProvider") @@ -2504,7 +2504,7 @@ static void MINLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::MIN); } @Test(dataProvider = "longBinaryOpProvider") @@ -2518,7 +2518,7 @@ static void minLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::min); } @Test(dataProvider = "longBinaryOpProvider") @@ -2532,7 +2532,7 @@ static void MAXLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::MAX); } @Test(dataProvider = "longBinaryOpProvider") @@ -2546,7 +2546,7 @@ static void maxLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, LongMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, LongMaxVectorTests::max); } static long ANDReduce(long[] a, int idx) { @@ -2589,7 +2589,7 @@ static void ANDReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::ANDReduce, LongMaxVectorTests::ANDReduceAll); } @@ -2637,7 +2637,7 @@ static void ANDReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::ANDReduceMasked, LongMaxVectorTests::ANDReduceAllMasked); } @@ -2682,7 +2682,7 @@ static void ORReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::ORReduce, LongMaxVectorTests::ORReduceAll); } @@ -2730,7 +2730,7 @@ static void ORReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunction } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::ORReduceMasked, LongMaxVectorTests::ORReduceAllMasked); } @@ -2775,7 +2775,7 @@ static void XORReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::XORReduce, LongMaxVectorTests::XORReduceAll); } @@ -2823,7 +2823,7 @@ static void XORReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::XORReduceMasked, LongMaxVectorTests::XORReduceAllMasked); } @@ -2865,7 +2865,7 @@ static void ADDReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::ADDReduce, LongMaxVectorTests::ADDReduceAll); } static long ADDReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2909,7 +2909,7 @@ static void ADDReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::ADDReduceMasked, LongMaxVectorTests::ADDReduceAllMasked); } static long MULReduce(long[] a, int idx) { @@ -2950,7 +2950,7 @@ static void MULReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::MULReduce, LongMaxVectorTests::MULReduceAll); } static long MULReduceMasked(long[] a, int idx, boolean[] mask) { @@ -2994,7 +2994,7 @@ static void MULReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::MULReduceMasked, LongMaxVectorTests::MULReduceAllMasked); } static long MINReduce(long[] a, int idx) { @@ -3035,7 +3035,7 @@ static void MINReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::MINReduce, LongMaxVectorTests::MINReduceAll); } static long MINReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3080,7 +3080,7 @@ static void MINReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::MINReduceMasked, LongMaxVectorTests::MINReduceAllMasked); } static long MAXReduce(long[] a, int idx) { @@ -3121,7 +3121,7 @@ static void MAXReduceLongMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::MAXReduce, LongMaxVectorTests::MAXReduceAll); } static long MAXReduceMasked(long[] a, int idx, boolean[] mask) { @@ -3166,7 +3166,7 @@ static void MAXReduceLongMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::MAXReduceMasked, LongMaxVectorTests::MAXReduceAllMasked); } @@ -3192,7 +3192,7 @@ static void anyTrueLongMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, LongMaxVectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, LongMaxVectorTests::anyTrue); } @@ -3218,7 +3218,7 @@ static void allTrueLongMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, LongMaxVectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, LongMaxVectorTests::allTrue); } @@ -3234,7 +3234,7 @@ static void withLongMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (long)4, 0); + assertInsertArraysEquals(r, a, (long)4, 0); } static boolean testIS_DEFAULT(long a) { return bits(a)==0; @@ -3711,7 +3711,7 @@ static void blendLongMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, LongMaxVectorTests::blend); + assertArraysEquals(r, a, b, mask, LongMaxVectorTests::blend); } @Test(dataProvider = "longUnaryOpShuffleProvider") @@ -3728,7 +3728,7 @@ static void RearrangeLongMaxVectorTests(IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpShuffleMaskProvider") @@ -3746,7 +3746,7 @@ static void RearrangeLongMaxVectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "longUnaryOpProvider") static void getLongMaxVectorTests(IntFunction fa) { @@ -3901,7 +3901,7 @@ static void getLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::get); + assertArraysEquals(r, a, LongMaxVectorTests::get); } @Test(dataProvider = "longUnaryOpProvider") @@ -3915,7 +3915,7 @@ static void BroadcastLongMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -3962,7 +3962,7 @@ static void sliceUnaryLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, LongMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, LongMaxVectorTests::sliceUnary); } static long[] sliceBinary(long[] a, long[] b, int origin, int idx) { long[] res = new long[SPECIES.length()]; @@ -3991,7 +3991,7 @@ static void sliceBinaryLongMaxVectorTestsBinary(IntFunction fa, IntFunct } } - assertArraysEquals(a, b, r, origin, LongMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, LongMaxVectorTests::sliceBinary); } static long[] slice(long[] a, long[] b, int origin, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4024,7 +4024,7 @@ static void sliceLongMaxVectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, LongMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, LongMaxVectorTests::unsliceUnary); } static long[] unsliceBinary(long[] a, long[] b, int origin, int part, int idx) { long[] res = new long[SPECIES.length()]; @@ -4090,7 +4090,7 @@ static void unsliceBinaryLongMaxVectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, part, LongMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, LongMaxVectorTests::unsliceBinary); } static long[] unslice(long[] a, long[] b, int origin, int part, boolean[] mask, int idx) { long[] res = new long[SPECIES.length()]; @@ -4146,7 +4146,7 @@ static void unsliceLongMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, part, mask, LongMaxVectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, LongMaxVectorTests::unslice); } @@ -4195,7 +4195,7 @@ static void BITWISE_BLENDLongMaxVectorTests(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, c, r, LongMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, LongMaxVectorTests::BITWISE_BLEND); } @Test(dataProvider = "longTernaryOpProvider") static void bitwiseBlendLongMaxVectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4211,7 +4211,7 @@ static void bitwiseBlendLongMaxVectorTests(IntFunction fa, IntFunction fa, IntFun } } - assertArraysEquals(a, b, c, r, mask, LongMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, LongMaxVectorTests::BITWISE_BLEND); } @@ -4252,7 +4252,7 @@ static void BITWISE_BLENDLongMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4281,7 +4281,7 @@ static void bitwiseBlendLongMaxVectorTestsBroadcastSmokeTest(IntFunction LongVector bv = LongVector.fromArray(SPECIES, b, i); av.bitwiseBlend(bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, LongMaxVectorTests::bitwiseBlend); + assertBroadcastArraysEquals(r, a, b, c, LongMaxVectorTests::bitwiseBlend); } @Test(dataProvider = "longTernaryOpProvider") @@ -4296,7 +4296,7 @@ static void bitwiseBlendLongMaxVectorTestsAltBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4367,7 +4367,7 @@ static void bitwiseBlendLongMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::NEG); + assertArraysEquals(r, a, LongMaxVectorTests::NEG); } @Test(dataProvider = "longUnaryOpProvider") @@ -4425,7 +4425,7 @@ static void negLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::neg); + assertArraysEquals(r, a, LongMaxVectorTests::neg); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4443,7 +4443,7 @@ static void NEGMaskedLongMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, LongMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, LongMaxVectorTests::NEG); } static long ABS(long a) { @@ -4466,7 +4466,7 @@ static void ABSLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::ABS); + assertArraysEquals(r, a, LongMaxVectorTests::ABS); } @Test(dataProvider = "longUnaryOpProvider") @@ -4481,7 +4481,7 @@ static void absLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::abs); + assertArraysEquals(r, a, LongMaxVectorTests::abs); } @Test(dataProvider = "longUnaryOpMaskProvider") @@ -4499,7 +4499,7 @@ static void ABSMaskedLongMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, LongMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, LongMaxVectorTests::ABS); } @@ -4525,7 +4525,7 @@ static void NOTLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::NOT); + assertArraysEquals(r, a, LongMaxVectorTests::NOT); } @Test(dataProvider = "longUnaryOpProvider") @@ -4540,7 +4540,7 @@ static void notLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::not); + assertArraysEquals(r, a, LongMaxVectorTests::not); } @@ -4560,7 +4560,7 @@ static void NOTMaskedLongMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, LongMaxVectorTests::NOT); + assertArraysEquals(r, a, mask, LongMaxVectorTests::NOT); } @@ -4583,7 +4583,7 @@ static void ZOMOLongMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, LongMaxVectorTests::ZOMO); + assertArraysEquals(r, a, LongMaxVectorTests::ZOMO); } @@ -4603,7 +4603,7 @@ static void ZOMOMaskedLongMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, LongMaxVectorTests::ZOMO); + assertArraysEquals(r, a, mask, LongMaxVectorTests::ZOMO); } @@ -4631,7 +4631,7 @@ static void gatherLongMaxVectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, mask, LongMaxVectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, LongMaxVectorTests::scatterMasked); } @@ -4764,8 +4764,8 @@ static void toIntArrayLongMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4775,8 +4775,8 @@ static void toLongArrayLongMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4786,8 +4786,8 @@ static void toDoubleArrayLongMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { LongVector av = LongVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4836,7 +4836,7 @@ static void ADDReduceLongLongMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, LongMaxVectorTests::ADDReduce, LongMaxVectorTests::ADDReduceAll); } @@ -4858,7 +4858,7 @@ static void ADDReduceLongLongMaxVectorTestsMasked(IntFunction fa, IntFun ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, LongMaxVectorTests::ADDReduceMasked, LongMaxVectorTests::ADDReduceAllMasked); } @@ -4875,7 +4875,7 @@ static void SelectFromLongMaxVectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "longUnaryOpSelectFromMaskProvider") @@ -4894,7 +4894,7 @@ static void SelectFromLongMaxVectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -4971,7 +4971,7 @@ static void maskEqLongMaxVectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, LongMaxVectorTests::beq); + assertArraysEquals(r, a, b, LongMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Short128VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Short128VectorLoadStoreTests.java index f0455261a4158..0b723fd38270d 100644 --- a/test/jdk/jdk/incubator/vector/Short128VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Short128VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Short128VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (128 / 8)); - static void assertArraysEquals(short[] a, short[] r, boolean[] mask) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0, "at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(short[] a, short[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "shortProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new short[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Short128VectorTests.java b/test/jdk/jdk/incubator/vector/Short128VectorTests.java index df4ca39096838..91f3e215759ea 100644 --- a/test/jdk/jdk/incubator/vector/Short128VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Short128VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { short apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { short[] apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { } catch (AssertionError e) { short[] ref = f.apply(a[i]); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { short apply(short[] a); } - static void assertReductionArraysEquals(short[] a, short[] b, short c, + static void assertReductionArraysEquals(short[] r, short rc, short[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { short apply(short[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(short[] a, short[] b, short c, boolean[] mask, + static void assertReductionArraysEqualsMasked(short[] r, short rc, short[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(short[] a); } - static void assertReductionLongArraysEquals(short[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, short[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(short[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(short[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, short[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(short[] a, short[] b, short element, int index) { + static void assertInsertArraysEquals(short[] r, short[] a, short element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, in } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, bo } } - static void assertBroadcastArraysEquals(short[]a, short[]r) { + static void assertBroadcastArraysEquals(short[] r, short[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBi } } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boo } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTern } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boole } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, s } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { short apply(short[] a, int b); } - static void assertArraysEquals(short[] a, short[] r, FBinArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { short[] apply(short[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, FGatherScatterOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { short[] apply(short[] r, short[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } catch (AssertionError e) { short[] ref = f.apply(a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FS } catch (AssertionError e) { short[] ref = f.apply(r, a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { short[] apply(short[] a, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { + static void assertArraysEquals(short[] r, short[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { } catch (AssertionError e) { short[] ref = f.apply(a, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { short[] apply(short[] a, short[] b, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLaneBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLan } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { short[] apply(short[] a, short[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, bool } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { short[] apply(short[] a, short[] b, int origin, int part, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { short[] apply(short[] a, short[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } - static void assertArraysEquals(short[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(short[] a, int[] r, int offs) { - static void assertArraysEquals(short[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(short[] a, long[] r, int offs) { } } - static void assertArraysEquals(short[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1278,7 +1278,7 @@ static void ADDShort128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::ADD); + assertArraysEquals(r, a, b, Short128VectorTests::ADD); } static short add(short a, short b) { return (short)(a + b); @@ -1296,7 +1296,7 @@ static void addShort128VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::add); + assertArraysEquals(r, a, b, Short128VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1316,7 +1316,7 @@ static void ADDShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::SUB); + assertArraysEquals(r, a, b, Short128VectorTests::SUB); } static short sub(short a, short b) { return (short)(a - b); @@ -1372,7 +1372,7 @@ static void subShort128VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::sub); + assertArraysEquals(r, a, b, Short128VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1392,7 +1392,7 @@ static void SUBShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::MUL); + assertArraysEquals(r, a, b, Short128VectorTests::MUL); } static short mul(short a, short b) { return (short)(a * b); @@ -1448,7 +1448,7 @@ static void mulShort128VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::mul); + assertArraysEquals(r, a, b, Short128VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1468,7 +1468,7 @@ static void MULShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::DIV); + assertArraysEquals(r, a, b, Short128VectorTests::DIV); } static short div(short a, short b) { return (short)(a / b); @@ -1533,7 +1533,7 @@ static void divShort128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::div); + assertArraysEquals(r, a, b, Short128VectorTests::div); } @@ -1557,7 +1557,7 @@ static void DIVShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Short128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Short128VectorTests::FIRST_NONZERO); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1620,7 +1620,7 @@ static void FIRST_NONZEROShort128VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Short128VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Short128VectorTests::FIRST_NONZERO); } static short AND(short a, short b) { @@ -1641,7 +1641,7 @@ static void ANDShort128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::AND); + assertArraysEquals(r, a, b, Short128VectorTests::AND); } static short and(short a, short b) { return (short)(a & b); @@ -1659,7 +1659,7 @@ static void andShort128VectorTests(IntFunction fa, IntFunction av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::and); + assertArraysEquals(r, a, b, Short128VectorTests::and); } @@ -1681,7 +1681,7 @@ static void ANDShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short128VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Short128VectorTests::AND_NOT); } @@ -1747,7 +1747,7 @@ static void ORShort128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::OR); + assertArraysEquals(r, a, b, Short128VectorTests::OR); } static short or(short a, short b) { return (short)(a | b); @@ -1765,7 +1765,7 @@ static void orShort128VectorTests(IntFunction fa, IntFunction av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::or); + assertArraysEquals(r, a, b, Short128VectorTests::or); } @@ -1787,7 +1787,7 @@ static void ORShort128VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::XOR); + assertArraysEquals(r, a, b, Short128VectorTests::XOR); } @@ -1831,7 +1831,7 @@ static void XORShort128VectorTestsMasked(IntFunction fa, IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1863,7 +1863,7 @@ static void addShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::add); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1877,7 +1877,7 @@ static void subShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1894,7 +1894,7 @@ static void subShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::sub); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1908,7 +1908,7 @@ static void mulShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1925,7 +1925,7 @@ static void mulShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::mul); } @@ -1944,7 +1944,7 @@ static void divShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::div); } @@ -1965,7 +1965,7 @@ static void divShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::div); } @@ -1981,7 +1981,7 @@ static void ORShort128VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::OR); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1995,7 +1995,7 @@ static void orShort128VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::or); } @@ -2014,7 +2014,7 @@ static void ORShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::OR); } @@ -2030,7 +2030,7 @@ static void ANDShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::AND); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2044,7 +2044,7 @@ static void andShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::and); } @@ -2063,7 +2063,7 @@ static void ANDShort128VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short128VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Short128VectorTests::AND); } @@ -2079,7 +2079,7 @@ static void ORShort128VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short128VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Short128VectorTests::OR); } @@ -2098,7 +2098,7 @@ static void ORShort128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short128VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Short128VectorTests::ADD); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -2130,7 +2130,7 @@ static void ADDShort128VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::MIN); + assertArraysEquals(r, a, b, Short128VectorTests::MIN); } static short min(short a, short b) { return (short)(Math.min(a, b)); @@ -2450,7 +2450,7 @@ static void minShort128VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::min); + assertArraysEquals(r, a, b, Short128VectorTests::min); } static short MAX(short a, short b) { return (short)(Math.max(a, b)); @@ -2470,7 +2470,7 @@ static void MAXShort128VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short128VectorTests::MAX); + assertArraysEquals(r, a, b, Short128VectorTests::MAX); } static short max(short a, short b) { return (short)(Math.max(a, b)); @@ -2488,7 +2488,7 @@ static void maxShort128VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::max); + assertArraysEquals(r, a, b, Short128VectorTests::max); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2502,7 +2502,7 @@ static void MINShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::MIN); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2516,7 +2516,7 @@ static void minShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::min); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2530,7 +2530,7 @@ static void MAXShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::MAX); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2544,7 +2544,7 @@ static void maxShort128VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short128VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Short128VectorTests::max); } static short ANDReduce(short[] a, int idx) { @@ -2587,7 +2587,7 @@ static void ANDReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::ANDReduce, Short128VectorTests::ANDReduceAll); } @@ -2635,7 +2635,7 @@ static void ANDReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::ANDReduceMasked, Short128VectorTests::ANDReduceAllMasked); } @@ -2680,7 +2680,7 @@ static void ORReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::ORReduce, Short128VectorTests::ORReduceAll); } @@ -2728,7 +2728,7 @@ static void ORReduceShort128VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::ORReduceMasked, Short128VectorTests::ORReduceAllMasked); } @@ -2773,7 +2773,7 @@ static void XORReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::XORReduce, Short128VectorTests::XORReduceAll); } @@ -2821,7 +2821,7 @@ static void XORReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::XORReduceMasked, Short128VectorTests::XORReduceAllMasked); } @@ -2863,7 +2863,7 @@ static void ADDReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::ADDReduce, Short128VectorTests::ADDReduceAll); } static short ADDReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2907,7 +2907,7 @@ static void ADDReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::ADDReduceMasked, Short128VectorTests::ADDReduceAllMasked); } static short MULReduce(short[] a, int idx) { @@ -2948,7 +2948,7 @@ static void MULReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::MULReduce, Short128VectorTests::MULReduceAll); } static short MULReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2992,7 +2992,7 @@ static void MULReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::MULReduceMasked, Short128VectorTests::MULReduceAllMasked); } static short MINReduce(short[] a, int idx) { @@ -3033,7 +3033,7 @@ static void MINReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::MINReduce, Short128VectorTests::MINReduceAll); } static short MINReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3078,7 +3078,7 @@ static void MINReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::MINReduceMasked, Short128VectorTests::MINReduceAllMasked); } static short MAXReduce(short[] a, int idx) { @@ -3119,7 +3119,7 @@ static void MAXReduceShort128VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short128VectorTests::MAXReduce, Short128VectorTests::MAXReduceAll); } static short MAXReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3164,7 +3164,7 @@ static void MAXReduceShort128VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::MAXReduceMasked, Short128VectorTests::MAXReduceAllMasked); } @@ -3190,7 +3190,7 @@ static void anyTrueShort128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short128VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Short128VectorTests::anyTrue); } @@ -3216,7 +3216,7 @@ static void allTrueShort128VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short128VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Short128VectorTests::allTrue); } @@ -3232,7 +3232,7 @@ static void withShort128VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (short)4, 0); + assertInsertArraysEquals(r, a, (short)4, 0); } static boolean testIS_DEFAULT(short a) { return bits(a)==0; @@ -3781,7 +3781,7 @@ static void blendShort128VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpShuffleMaskProvider") @@ -3816,7 +3816,7 @@ static void RearrangeShort128VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpProvider") static void getShort128VectorTests(IntFunction fa) { @@ -3971,7 +3971,7 @@ static void getShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::get); + assertArraysEquals(r, a, Short128VectorTests::get); } @Test(dataProvider = "shortUnaryOpProvider") @@ -3985,7 +3985,7 @@ static void BroadcastShort128VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4032,7 +4032,7 @@ static void sliceUnaryShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short128VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Short128VectorTests::sliceUnary); } static short[] sliceBinary(short[] a, short[] b, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4061,7 +4061,7 @@ static void sliceBinaryShort128VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Short128VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Short128VectorTests::sliceBinary); } static short[] slice(short[] a, short[] b, int origin, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4094,7 +4094,7 @@ static void sliceShort128VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Short128VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Short128VectorTests::slice); } static short[] unsliceUnary(short[] a, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4121,7 +4121,7 @@ static void unsliceUnaryShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short128VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Short128VectorTests::unsliceUnary); } static short[] unsliceBinary(short[] a, short[] b, int origin, int part, int idx) { short[] res = new short[SPECIES.length()]; @@ -4160,7 +4160,7 @@ static void unsliceBinaryShort128VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Short128VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Short128VectorTests::unsliceBinary); } static short[] unslice(short[] a, short[] b, int origin, int part, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4216,7 +4216,7 @@ static void unsliceShort128VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Short128VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Short128VectorTests::unslice); } @@ -4265,7 +4265,7 @@ static void BITWISE_BLENDShort128VectorTests(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, c, r, Short128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Short128VectorTests::BITWISE_BLEND); } @Test(dataProvider = "shortTernaryOpProvider") static void bitwiseBlendShort128VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4281,7 +4281,7 @@ static void bitwiseBlendShort128VectorTests(IntFunction fa, IntFunction av.bitwiseBlend(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Short128VectorTests::bitwiseBlend); + assertArraysEquals(r, a, b, c, Short128VectorTests::bitwiseBlend); } @@ -4304,7 +4304,7 @@ static void BITWISE_BLENDShort128VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, c, r, mask, Short128VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Short128VectorTests::BITWISE_BLEND); } @@ -4322,7 +4322,7 @@ static void BITWISE_BLENDShort128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4351,7 +4351,7 @@ static void bitwiseBlendShort128VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4437,7 +4437,7 @@ static void bitwiseBlendShort128VectorTestsDoubleBroadcastSmokeTest(IntFunction< av.bitwiseBlend(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Short128VectorTests::bitwiseBlend); + assertDoubleBroadcastArraysEquals(r, a, b, c, Short128VectorTests::bitwiseBlend); } @@ -4456,7 +4456,7 @@ static void BITWISE_BLENDShort128VectorTestsDoubleBroadcastMaskedSmokeTest(IntFu av.lanewise(VectorOperators.BITWISE_BLEND, b[i], c[i], vmask).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, Short128VectorTests::BITWISE_BLEND); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, Short128VectorTests::BITWISE_BLEND); } @@ -4480,7 +4480,7 @@ static void NEGShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::NEG); + assertArraysEquals(r, a, Short128VectorTests::NEG); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4495,7 +4495,7 @@ static void negShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::neg); + assertArraysEquals(r, a, Short128VectorTests::neg); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4513,7 +4513,7 @@ static void NEGMaskedShort128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short128VectorTests::NEG); + assertArraysEquals(r, a, mask, Short128VectorTests::NEG); } static short ABS(short a) { @@ -4536,7 +4536,7 @@ static void ABSShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::ABS); + assertArraysEquals(r, a, Short128VectorTests::ABS); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4551,7 +4551,7 @@ static void absShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::abs); + assertArraysEquals(r, a, Short128VectorTests::abs); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4569,7 +4569,7 @@ static void ABSMaskedShort128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short128VectorTests::ABS); + assertArraysEquals(r, a, mask, Short128VectorTests::ABS); } @@ -4595,7 +4595,7 @@ static void NOTShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::NOT); + assertArraysEquals(r, a, Short128VectorTests::NOT); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4610,7 +4610,7 @@ static void notShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::not); + assertArraysEquals(r, a, Short128VectorTests::not); } @@ -4630,7 +4630,7 @@ static void NOTMaskedShort128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short128VectorTests::NOT); + assertArraysEquals(r, a, mask, Short128VectorTests::NOT); } @@ -4653,7 +4653,7 @@ static void ZOMOShort128VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short128VectorTests::ZOMO); + assertArraysEquals(r, a, Short128VectorTests::ZOMO); } @@ -4673,7 +4673,7 @@ static void ZOMOMaskedShort128VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short128VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Short128VectorTests::ZOMO); } @@ -4701,7 +4701,7 @@ static void gatherShort128VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Short128VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Short128VectorTests::gatherMasked); } static short[] scatter(short a[], int ix, int[] b, int iy) { @@ -4754,7 +4754,7 @@ static void scatterShort128VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short128VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Short128VectorTests::scatterMasked); } @@ -4834,8 +4834,8 @@ static void toIntArrayShort128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4845,8 +4845,8 @@ static void toLongArrayShort128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4856,8 +4856,8 @@ static void toDoubleArrayShort128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4923,7 +4923,7 @@ static void ADDReduceLongShort128VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Short128VectorTests::ADDReduceLong, Short128VectorTests::ADDReduceAllLong); } @@ -4964,7 +4964,7 @@ static void ADDReduceLongShort128VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Short128VectorTests::ADDReduceLongMasked, Short128VectorTests::ADDReduceAllLongMasked); } @@ -4976,7 +4976,7 @@ static void BroadcastLongShort128VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -4994,7 +4994,7 @@ static void blendShort128VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Short128VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Short128VectorTests::blend); } @@ -5011,7 +5011,7 @@ static void SelectFromShort128VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpSelectFromMaskProvider") @@ -5030,7 +5030,7 @@ static void SelectFromShort128VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5107,7 +5107,7 @@ static void maskEqShort128VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Short128VectorTests::beq); + assertArraysEquals(r, a, b, Short128VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Short256VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Short256VectorLoadStoreTests.java index 3828368c354de..567ae6c74864c 100644 --- a/test/jdk/jdk/incubator/vector/Short256VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Short256VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Short256VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (256 / 8)); - static void assertArraysEquals(short[] a, short[] r, boolean[] mask) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0, "at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(short[] a, short[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "shortProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new short[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Short256VectorTests.java b/test/jdk/jdk/incubator/vector/Short256VectorTests.java index 20b5ea4f7f55c..efbde094120bd 100644 --- a/test/jdk/jdk/incubator/vector/Short256VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Short256VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { short apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { short[] apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { } catch (AssertionError e) { short[] ref = f.apply(a[i]); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { short apply(short[] a); } - static void assertReductionArraysEquals(short[] a, short[] b, short c, + static void assertReductionArraysEquals(short[] r, short rc, short[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { short apply(short[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(short[] a, short[] b, short c, boolean[] mask, + static void assertReductionArraysEqualsMasked(short[] r, short rc, short[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(short[] a); } - static void assertReductionLongArraysEquals(short[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, short[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(short[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(short[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, short[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(short[] a, short[] b, short element, int index) { + static void assertInsertArraysEquals(short[] r, short[] a, short element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, in } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, bo } } - static void assertBroadcastArraysEquals(short[]a, short[]r) { + static void assertBroadcastArraysEquals(short[] r, short[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBi } } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boo } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTern } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boole } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, s } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { short apply(short[] a, int b); } - static void assertArraysEquals(short[] a, short[] r, FBinArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { short[] apply(short[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, FGatherScatterOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { short[] apply(short[] r, short[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } catch (AssertionError e) { short[] ref = f.apply(a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FS } catch (AssertionError e) { short[] ref = f.apply(r, a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { short[] apply(short[] a, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { + static void assertArraysEquals(short[] r, short[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { } catch (AssertionError e) { short[] ref = f.apply(a, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { short[] apply(short[] a, short[] b, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLaneBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLan } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { short[] apply(short[] a, short[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, bool } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { short[] apply(short[] a, short[] b, int origin, int part, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { short[] apply(short[] a, short[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } - static void assertArraysEquals(short[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(short[] a, int[] r, int offs) { - static void assertArraysEquals(short[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(short[] a, long[] r, int offs) { } } - static void assertArraysEquals(short[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1278,7 +1278,7 @@ static void ADDShort256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::ADD); + assertArraysEquals(r, a, b, Short256VectorTests::ADD); } static short add(short a, short b) { return (short)(a + b); @@ -1296,7 +1296,7 @@ static void addShort256VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::add); + assertArraysEquals(r, a, b, Short256VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1316,7 +1316,7 @@ static void ADDShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::SUB); + assertArraysEquals(r, a, b, Short256VectorTests::SUB); } static short sub(short a, short b) { return (short)(a - b); @@ -1372,7 +1372,7 @@ static void subShort256VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::sub); + assertArraysEquals(r, a, b, Short256VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1392,7 +1392,7 @@ static void SUBShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::MUL); + assertArraysEquals(r, a, b, Short256VectorTests::MUL); } static short mul(short a, short b) { return (short)(a * b); @@ -1448,7 +1448,7 @@ static void mulShort256VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::mul); + assertArraysEquals(r, a, b, Short256VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1468,7 +1468,7 @@ static void MULShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::DIV); + assertArraysEquals(r, a, b, Short256VectorTests::DIV); } static short div(short a, short b) { return (short)(a / b); @@ -1533,7 +1533,7 @@ static void divShort256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::div); + assertArraysEquals(r, a, b, Short256VectorTests::div); } @@ -1557,7 +1557,7 @@ static void DIVShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Short256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Short256VectorTests::FIRST_NONZERO); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1620,7 +1620,7 @@ static void FIRST_NONZEROShort256VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Short256VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Short256VectorTests::FIRST_NONZERO); } static short AND(short a, short b) { @@ -1641,7 +1641,7 @@ static void ANDShort256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::AND); + assertArraysEquals(r, a, b, Short256VectorTests::AND); } static short and(short a, short b) { return (short)(a & b); @@ -1659,7 +1659,7 @@ static void andShort256VectorTests(IntFunction fa, IntFunction av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::and); + assertArraysEquals(r, a, b, Short256VectorTests::and); } @@ -1681,7 +1681,7 @@ static void ANDShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short256VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Short256VectorTests::AND_NOT); } @@ -1747,7 +1747,7 @@ static void ORShort256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::OR); + assertArraysEquals(r, a, b, Short256VectorTests::OR); } static short or(short a, short b) { return (short)(a | b); @@ -1765,7 +1765,7 @@ static void orShort256VectorTests(IntFunction fa, IntFunction av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::or); + assertArraysEquals(r, a, b, Short256VectorTests::or); } @@ -1787,7 +1787,7 @@ static void ORShort256VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::XOR); + assertArraysEquals(r, a, b, Short256VectorTests::XOR); } @@ -1831,7 +1831,7 @@ static void XORShort256VectorTestsMasked(IntFunction fa, IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1863,7 +1863,7 @@ static void addShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::add); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1877,7 +1877,7 @@ static void subShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1894,7 +1894,7 @@ static void subShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::sub); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1908,7 +1908,7 @@ static void mulShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1925,7 +1925,7 @@ static void mulShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::mul); } @@ -1944,7 +1944,7 @@ static void divShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::div); } @@ -1965,7 +1965,7 @@ static void divShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::div); } @@ -1981,7 +1981,7 @@ static void ORShort256VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::OR); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1995,7 +1995,7 @@ static void orShort256VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::or); } @@ -2014,7 +2014,7 @@ static void ORShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::OR); } @@ -2030,7 +2030,7 @@ static void ANDShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::AND); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2044,7 +2044,7 @@ static void andShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::and); } @@ -2063,7 +2063,7 @@ static void ANDShort256VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short256VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Short256VectorTests::AND); } @@ -2079,7 +2079,7 @@ static void ORShort256VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short256VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Short256VectorTests::OR); } @@ -2098,7 +2098,7 @@ static void ORShort256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short256VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Short256VectorTests::ADD); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -2130,7 +2130,7 @@ static void ADDShort256VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::MIN); + assertArraysEquals(r, a, b, Short256VectorTests::MIN); } static short min(short a, short b) { return (short)(Math.min(a, b)); @@ -2450,7 +2450,7 @@ static void minShort256VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::min); + assertArraysEquals(r, a, b, Short256VectorTests::min); } static short MAX(short a, short b) { return (short)(Math.max(a, b)); @@ -2470,7 +2470,7 @@ static void MAXShort256VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short256VectorTests::MAX); + assertArraysEquals(r, a, b, Short256VectorTests::MAX); } static short max(short a, short b) { return (short)(Math.max(a, b)); @@ -2488,7 +2488,7 @@ static void maxShort256VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::max); + assertArraysEquals(r, a, b, Short256VectorTests::max); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2502,7 +2502,7 @@ static void MINShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::MIN); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2516,7 +2516,7 @@ static void minShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::min); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2530,7 +2530,7 @@ static void MAXShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::MAX); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2544,7 +2544,7 @@ static void maxShort256VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short256VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Short256VectorTests::max); } static short ANDReduce(short[] a, int idx) { @@ -2587,7 +2587,7 @@ static void ANDReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::ANDReduce, Short256VectorTests::ANDReduceAll); } @@ -2635,7 +2635,7 @@ static void ANDReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::ANDReduceMasked, Short256VectorTests::ANDReduceAllMasked); } @@ -2680,7 +2680,7 @@ static void ORReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::ORReduce, Short256VectorTests::ORReduceAll); } @@ -2728,7 +2728,7 @@ static void ORReduceShort256VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::ORReduceMasked, Short256VectorTests::ORReduceAllMasked); } @@ -2773,7 +2773,7 @@ static void XORReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::XORReduce, Short256VectorTests::XORReduceAll); } @@ -2821,7 +2821,7 @@ static void XORReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::XORReduceMasked, Short256VectorTests::XORReduceAllMasked); } @@ -2863,7 +2863,7 @@ static void ADDReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::ADDReduce, Short256VectorTests::ADDReduceAll); } static short ADDReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2907,7 +2907,7 @@ static void ADDReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::ADDReduceMasked, Short256VectorTests::ADDReduceAllMasked); } static short MULReduce(short[] a, int idx) { @@ -2948,7 +2948,7 @@ static void MULReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::MULReduce, Short256VectorTests::MULReduceAll); } static short MULReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2992,7 +2992,7 @@ static void MULReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::MULReduceMasked, Short256VectorTests::MULReduceAllMasked); } static short MINReduce(short[] a, int idx) { @@ -3033,7 +3033,7 @@ static void MINReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::MINReduce, Short256VectorTests::MINReduceAll); } static short MINReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3078,7 +3078,7 @@ static void MINReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::MINReduceMasked, Short256VectorTests::MINReduceAllMasked); } static short MAXReduce(short[] a, int idx) { @@ -3119,7 +3119,7 @@ static void MAXReduceShort256VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short256VectorTests::MAXReduce, Short256VectorTests::MAXReduceAll); } static short MAXReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3164,7 +3164,7 @@ static void MAXReduceShort256VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::MAXReduceMasked, Short256VectorTests::MAXReduceAllMasked); } @@ -3190,7 +3190,7 @@ static void anyTrueShort256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short256VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Short256VectorTests::anyTrue); } @@ -3216,7 +3216,7 @@ static void allTrueShort256VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short256VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Short256VectorTests::allTrue); } @@ -3232,7 +3232,7 @@ static void withShort256VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (short)4, 0); + assertInsertArraysEquals(r, a, (short)4, 0); } static boolean testIS_DEFAULT(short a) { return bits(a)==0; @@ -3781,7 +3781,7 @@ static void blendShort256VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpShuffleMaskProvider") @@ -3816,7 +3816,7 @@ static void RearrangeShort256VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpProvider") static void getShort256VectorTests(IntFunction fa) { @@ -3971,7 +3971,7 @@ static void getShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::get); + assertArraysEquals(r, a, Short256VectorTests::get); } @Test(dataProvider = "shortUnaryOpProvider") @@ -3985,7 +3985,7 @@ static void BroadcastShort256VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4032,7 +4032,7 @@ static void sliceUnaryShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short256VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Short256VectorTests::sliceUnary); } static short[] sliceBinary(short[] a, short[] b, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4061,7 +4061,7 @@ static void sliceBinaryShort256VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Short256VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Short256VectorTests::sliceBinary); } static short[] slice(short[] a, short[] b, int origin, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4094,7 +4094,7 @@ static void sliceShort256VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Short256VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Short256VectorTests::slice); } static short[] unsliceUnary(short[] a, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4121,7 +4121,7 @@ static void unsliceUnaryShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short256VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Short256VectorTests::unsliceUnary); } static short[] unsliceBinary(short[] a, short[] b, int origin, int part, int idx) { short[] res = new short[SPECIES.length()]; @@ -4160,7 +4160,7 @@ static void unsliceBinaryShort256VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Short256VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Short256VectorTests::unsliceBinary); } static short[] unslice(short[] a, short[] b, int origin, int part, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4216,7 +4216,7 @@ static void unsliceShort256VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Short256VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Short256VectorTests::unslice); } @@ -4265,7 +4265,7 @@ static void BITWISE_BLENDShort256VectorTests(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, c, r, Short256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Short256VectorTests::BITWISE_BLEND); } @Test(dataProvider = "shortTernaryOpProvider") static void bitwiseBlendShort256VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4281,7 +4281,7 @@ static void bitwiseBlendShort256VectorTests(IntFunction fa, IntFunction av.bitwiseBlend(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Short256VectorTests::bitwiseBlend); + assertArraysEquals(r, a, b, c, Short256VectorTests::bitwiseBlend); } @@ -4304,7 +4304,7 @@ static void BITWISE_BLENDShort256VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, c, r, mask, Short256VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Short256VectorTests::BITWISE_BLEND); } @@ -4322,7 +4322,7 @@ static void BITWISE_BLENDShort256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4351,7 +4351,7 @@ static void bitwiseBlendShort256VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4437,7 +4437,7 @@ static void bitwiseBlendShort256VectorTestsDoubleBroadcastSmokeTest(IntFunction< av.bitwiseBlend(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Short256VectorTests::bitwiseBlend); + assertDoubleBroadcastArraysEquals(r, a, b, c, Short256VectorTests::bitwiseBlend); } @@ -4456,7 +4456,7 @@ static void BITWISE_BLENDShort256VectorTestsDoubleBroadcastMaskedSmokeTest(IntFu av.lanewise(VectorOperators.BITWISE_BLEND, b[i], c[i], vmask).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, Short256VectorTests::BITWISE_BLEND); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, Short256VectorTests::BITWISE_BLEND); } @@ -4480,7 +4480,7 @@ static void NEGShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::NEG); + assertArraysEquals(r, a, Short256VectorTests::NEG); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4495,7 +4495,7 @@ static void negShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::neg); + assertArraysEquals(r, a, Short256VectorTests::neg); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4513,7 +4513,7 @@ static void NEGMaskedShort256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short256VectorTests::NEG); + assertArraysEquals(r, a, mask, Short256VectorTests::NEG); } static short ABS(short a) { @@ -4536,7 +4536,7 @@ static void ABSShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::ABS); + assertArraysEquals(r, a, Short256VectorTests::ABS); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4551,7 +4551,7 @@ static void absShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::abs); + assertArraysEquals(r, a, Short256VectorTests::abs); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4569,7 +4569,7 @@ static void ABSMaskedShort256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short256VectorTests::ABS); + assertArraysEquals(r, a, mask, Short256VectorTests::ABS); } @@ -4595,7 +4595,7 @@ static void NOTShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::NOT); + assertArraysEquals(r, a, Short256VectorTests::NOT); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4610,7 +4610,7 @@ static void notShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::not); + assertArraysEquals(r, a, Short256VectorTests::not); } @@ -4630,7 +4630,7 @@ static void NOTMaskedShort256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short256VectorTests::NOT); + assertArraysEquals(r, a, mask, Short256VectorTests::NOT); } @@ -4653,7 +4653,7 @@ static void ZOMOShort256VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short256VectorTests::ZOMO); + assertArraysEquals(r, a, Short256VectorTests::ZOMO); } @@ -4673,7 +4673,7 @@ static void ZOMOMaskedShort256VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short256VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Short256VectorTests::ZOMO); } @@ -4701,7 +4701,7 @@ static void gatherShort256VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Short256VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Short256VectorTests::gatherMasked); } static short[] scatter(short a[], int ix, int[] b, int iy) { @@ -4754,7 +4754,7 @@ static void scatterShort256VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short256VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Short256VectorTests::scatterMasked); } @@ -4834,8 +4834,8 @@ static void toIntArrayShort256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4845,8 +4845,8 @@ static void toLongArrayShort256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4856,8 +4856,8 @@ static void toDoubleArrayShort256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4923,7 +4923,7 @@ static void ADDReduceLongShort256VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Short256VectorTests::ADDReduceLong, Short256VectorTests::ADDReduceAllLong); } @@ -4964,7 +4964,7 @@ static void ADDReduceLongShort256VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Short256VectorTests::ADDReduceLongMasked, Short256VectorTests::ADDReduceAllLongMasked); } @@ -4976,7 +4976,7 @@ static void BroadcastLongShort256VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -4994,7 +4994,7 @@ static void blendShort256VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Short256VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Short256VectorTests::blend); } @@ -5011,7 +5011,7 @@ static void SelectFromShort256VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpSelectFromMaskProvider") @@ -5030,7 +5030,7 @@ static void SelectFromShort256VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5107,7 +5107,7 @@ static void maskEqShort256VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Short256VectorTests::beq); + assertArraysEquals(r, a, b, Short256VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Short512VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Short512VectorLoadStoreTests.java index 30392650e8a34..ae9d392d75ffc 100644 --- a/test/jdk/jdk/incubator/vector/Short512VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Short512VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Short512VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (512 / 8)); - static void assertArraysEquals(short[] a, short[] r, boolean[] mask) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0, "at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(short[] a, short[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "shortProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new short[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Short512VectorTests.java b/test/jdk/jdk/incubator/vector/Short512VectorTests.java index 29a1388d82b82..16463ba45d8a9 100644 --- a/test/jdk/jdk/incubator/vector/Short512VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Short512VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { short apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { short[] apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { } catch (AssertionError e) { short[] ref = f.apply(a[i]); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { short apply(short[] a); } - static void assertReductionArraysEquals(short[] a, short[] b, short c, + static void assertReductionArraysEquals(short[] r, short rc, short[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { short apply(short[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(short[] a, short[] b, short c, boolean[] mask, + static void assertReductionArraysEqualsMasked(short[] r, short rc, short[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(short[] a); } - static void assertReductionLongArraysEquals(short[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, short[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(short[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(short[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, short[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(short[] a, short[] b, short element, int index) { + static void assertInsertArraysEquals(short[] r, short[] a, short element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, in } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, bo } } - static void assertBroadcastArraysEquals(short[]a, short[]r) { + static void assertBroadcastArraysEquals(short[] r, short[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBi } } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boo } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTern } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boole } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, s } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { short apply(short[] a, int b); } - static void assertArraysEquals(short[] a, short[] r, FBinArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { short[] apply(short[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, FGatherScatterOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { short[] apply(short[] r, short[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } catch (AssertionError e) { short[] ref = f.apply(a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FS } catch (AssertionError e) { short[] ref = f.apply(r, a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { short[] apply(short[] a, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { + static void assertArraysEquals(short[] r, short[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { } catch (AssertionError e) { short[] ref = f.apply(a, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { short[] apply(short[] a, short[] b, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLaneBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLan } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { short[] apply(short[] a, short[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, bool } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { short[] apply(short[] a, short[] b, int origin, int part, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { short[] apply(short[] a, short[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } - static void assertArraysEquals(short[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(short[] a, int[] r, int offs) { - static void assertArraysEquals(short[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(short[] a, long[] r, int offs) { } } - static void assertArraysEquals(short[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1278,7 +1278,7 @@ static void ADDShort512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::ADD); + assertArraysEquals(r, a, b, Short512VectorTests::ADD); } static short add(short a, short b) { return (short)(a + b); @@ -1296,7 +1296,7 @@ static void addShort512VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::add); + assertArraysEquals(r, a, b, Short512VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1316,7 +1316,7 @@ static void ADDShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::SUB); + assertArraysEquals(r, a, b, Short512VectorTests::SUB); } static short sub(short a, short b) { return (short)(a - b); @@ -1372,7 +1372,7 @@ static void subShort512VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::sub); + assertArraysEquals(r, a, b, Short512VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1392,7 +1392,7 @@ static void SUBShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::MUL); + assertArraysEquals(r, a, b, Short512VectorTests::MUL); } static short mul(short a, short b) { return (short)(a * b); @@ -1448,7 +1448,7 @@ static void mulShort512VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::mul); + assertArraysEquals(r, a, b, Short512VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1468,7 +1468,7 @@ static void MULShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::DIV); + assertArraysEquals(r, a, b, Short512VectorTests::DIV); } static short div(short a, short b) { return (short)(a / b); @@ -1533,7 +1533,7 @@ static void divShort512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::div); + assertArraysEquals(r, a, b, Short512VectorTests::div); } @@ -1557,7 +1557,7 @@ static void DIVShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, Short512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Short512VectorTests::FIRST_NONZERO); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1620,7 +1620,7 @@ static void FIRST_NONZEROShort512VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, Short512VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Short512VectorTests::FIRST_NONZERO); } static short AND(short a, short b) { @@ -1641,7 +1641,7 @@ static void ANDShort512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::AND); + assertArraysEquals(r, a, b, Short512VectorTests::AND); } static short and(short a, short b) { return (short)(a & b); @@ -1659,7 +1659,7 @@ static void andShort512VectorTests(IntFunction fa, IntFunction av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::and); + assertArraysEquals(r, a, b, Short512VectorTests::and); } @@ -1681,7 +1681,7 @@ static void ANDShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short512VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Short512VectorTests::AND_NOT); } @@ -1747,7 +1747,7 @@ static void ORShort512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::OR); + assertArraysEquals(r, a, b, Short512VectorTests::OR); } static short or(short a, short b) { return (short)(a | b); @@ -1765,7 +1765,7 @@ static void orShort512VectorTests(IntFunction fa, IntFunction av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::or); + assertArraysEquals(r, a, b, Short512VectorTests::or); } @@ -1787,7 +1787,7 @@ static void ORShort512VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::XOR); + assertArraysEquals(r, a, b, Short512VectorTests::XOR); } @@ -1831,7 +1831,7 @@ static void XORShort512VectorTestsMasked(IntFunction fa, IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1863,7 +1863,7 @@ static void addShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::add); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1877,7 +1877,7 @@ static void subShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1894,7 +1894,7 @@ static void subShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::sub); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1908,7 +1908,7 @@ static void mulShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1925,7 +1925,7 @@ static void mulShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::mul); } @@ -1944,7 +1944,7 @@ static void divShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::div); } @@ -1965,7 +1965,7 @@ static void divShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::div); } @@ -1981,7 +1981,7 @@ static void ORShort512VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::OR); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1995,7 +1995,7 @@ static void orShort512VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::or); } @@ -2014,7 +2014,7 @@ static void ORShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::OR); } @@ -2030,7 +2030,7 @@ static void ANDShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::AND); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2044,7 +2044,7 @@ static void andShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::and); } @@ -2063,7 +2063,7 @@ static void ANDShort512VectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short512VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Short512VectorTests::AND); } @@ -2079,7 +2079,7 @@ static void ORShort512VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short512VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Short512VectorTests::OR); } @@ -2098,7 +2098,7 @@ static void ORShort512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short512VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Short512VectorTests::ADD); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -2130,7 +2130,7 @@ static void ADDShort512VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::MIN); + assertArraysEquals(r, a, b, Short512VectorTests::MIN); } static short min(short a, short b) { return (short)(Math.min(a, b)); @@ -2450,7 +2450,7 @@ static void minShort512VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::min); + assertArraysEquals(r, a, b, Short512VectorTests::min); } static short MAX(short a, short b) { return (short)(Math.max(a, b)); @@ -2470,7 +2470,7 @@ static void MAXShort512VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short512VectorTests::MAX); + assertArraysEquals(r, a, b, Short512VectorTests::MAX); } static short max(short a, short b) { return (short)(Math.max(a, b)); @@ -2488,7 +2488,7 @@ static void maxShort512VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::max); + assertArraysEquals(r, a, b, Short512VectorTests::max); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2502,7 +2502,7 @@ static void MINShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::MIN); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2516,7 +2516,7 @@ static void minShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::min); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2530,7 +2530,7 @@ static void MAXShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::MAX); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2544,7 +2544,7 @@ static void maxShort512VectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short512VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Short512VectorTests::max); } static short ANDReduce(short[] a, int idx) { @@ -2587,7 +2587,7 @@ static void ANDReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::ANDReduce, Short512VectorTests::ANDReduceAll); } @@ -2635,7 +2635,7 @@ static void ANDReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::ANDReduceMasked, Short512VectorTests::ANDReduceAllMasked); } @@ -2680,7 +2680,7 @@ static void ORReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::ORReduce, Short512VectorTests::ORReduceAll); } @@ -2728,7 +2728,7 @@ static void ORReduceShort512VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::ORReduceMasked, Short512VectorTests::ORReduceAllMasked); } @@ -2773,7 +2773,7 @@ static void XORReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::XORReduce, Short512VectorTests::XORReduceAll); } @@ -2821,7 +2821,7 @@ static void XORReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::XORReduceMasked, Short512VectorTests::XORReduceAllMasked); } @@ -2863,7 +2863,7 @@ static void ADDReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::ADDReduce, Short512VectorTests::ADDReduceAll); } static short ADDReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2907,7 +2907,7 @@ static void ADDReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::ADDReduceMasked, Short512VectorTests::ADDReduceAllMasked); } static short MULReduce(short[] a, int idx) { @@ -2948,7 +2948,7 @@ static void MULReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::MULReduce, Short512VectorTests::MULReduceAll); } static short MULReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2992,7 +2992,7 @@ static void MULReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::MULReduceMasked, Short512VectorTests::MULReduceAllMasked); } static short MINReduce(short[] a, int idx) { @@ -3033,7 +3033,7 @@ static void MINReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::MINReduce, Short512VectorTests::MINReduceAll); } static short MINReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3078,7 +3078,7 @@ static void MINReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::MINReduceMasked, Short512VectorTests::MINReduceAllMasked); } static short MAXReduce(short[] a, int idx) { @@ -3119,7 +3119,7 @@ static void MAXReduceShort512VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short512VectorTests::MAXReduce, Short512VectorTests::MAXReduceAll); } static short MAXReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3164,7 +3164,7 @@ static void MAXReduceShort512VectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::MAXReduceMasked, Short512VectorTests::MAXReduceAllMasked); } @@ -3190,7 +3190,7 @@ static void anyTrueShort512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short512VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Short512VectorTests::anyTrue); } @@ -3216,7 +3216,7 @@ static void allTrueShort512VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short512VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Short512VectorTests::allTrue); } @@ -3232,7 +3232,7 @@ static void withShort512VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (short)4, 0); + assertInsertArraysEquals(r, a, (short)4, 0); } static boolean testIS_DEFAULT(short a) { return bits(a)==0; @@ -3781,7 +3781,7 @@ static void blendShort512VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpShuffleMaskProvider") @@ -3816,7 +3816,7 @@ static void RearrangeShort512VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpProvider") static void getShort512VectorTests(IntFunction fa) { @@ -3971,7 +3971,7 @@ static void getShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::get); + assertArraysEquals(r, a, Short512VectorTests::get); } @Test(dataProvider = "shortUnaryOpProvider") @@ -3985,7 +3985,7 @@ static void BroadcastShort512VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4032,7 +4032,7 @@ static void sliceUnaryShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short512VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Short512VectorTests::sliceUnary); } static short[] sliceBinary(short[] a, short[] b, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4061,7 +4061,7 @@ static void sliceBinaryShort512VectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, Short512VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Short512VectorTests::sliceBinary); } static short[] slice(short[] a, short[] b, int origin, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4094,7 +4094,7 @@ static void sliceShort512VectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, Short512VectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, Short512VectorTests::slice); } static short[] unsliceUnary(short[] a, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4121,7 +4121,7 @@ static void unsliceUnaryShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short512VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Short512VectorTests::unsliceUnary); } static short[] unsliceBinary(short[] a, short[] b, int origin, int part, int idx) { short[] res = new short[SPECIES.length()]; @@ -4160,7 +4160,7 @@ static void unsliceBinaryShort512VectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, Short512VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Short512VectorTests::unsliceBinary); } static short[] unslice(short[] a, short[] b, int origin, int part, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4216,7 +4216,7 @@ static void unsliceShort512VectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, Short512VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Short512VectorTests::unslice); } @@ -4265,7 +4265,7 @@ static void BITWISE_BLENDShort512VectorTests(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, c, r, Short512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Short512VectorTests::BITWISE_BLEND); } @Test(dataProvider = "shortTernaryOpProvider") static void bitwiseBlendShort512VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4281,7 +4281,7 @@ static void bitwiseBlendShort512VectorTests(IntFunction fa, IntFunction av.bitwiseBlend(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Short512VectorTests::bitwiseBlend); + assertArraysEquals(r, a, b, c, Short512VectorTests::bitwiseBlend); } @@ -4304,7 +4304,7 @@ static void BITWISE_BLENDShort512VectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, c, r, mask, Short512VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Short512VectorTests::BITWISE_BLEND); } @@ -4322,7 +4322,7 @@ static void BITWISE_BLENDShort512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4351,7 +4351,7 @@ static void bitwiseBlendShort512VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4437,7 +4437,7 @@ static void bitwiseBlendShort512VectorTestsDoubleBroadcastSmokeTest(IntFunction< av.bitwiseBlend(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, Short512VectorTests::bitwiseBlend); + assertDoubleBroadcastArraysEquals(r, a, b, c, Short512VectorTests::bitwiseBlend); } @@ -4456,7 +4456,7 @@ static void BITWISE_BLENDShort512VectorTestsDoubleBroadcastMaskedSmokeTest(IntFu av.lanewise(VectorOperators.BITWISE_BLEND, b[i], c[i], vmask).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, Short512VectorTests::BITWISE_BLEND); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, Short512VectorTests::BITWISE_BLEND); } @@ -4480,7 +4480,7 @@ static void NEGShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::NEG); + assertArraysEquals(r, a, Short512VectorTests::NEG); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4495,7 +4495,7 @@ static void negShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::neg); + assertArraysEquals(r, a, Short512VectorTests::neg); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4513,7 +4513,7 @@ static void NEGMaskedShort512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short512VectorTests::NEG); + assertArraysEquals(r, a, mask, Short512VectorTests::NEG); } static short ABS(short a) { @@ -4536,7 +4536,7 @@ static void ABSShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::ABS); + assertArraysEquals(r, a, Short512VectorTests::ABS); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4551,7 +4551,7 @@ static void absShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::abs); + assertArraysEquals(r, a, Short512VectorTests::abs); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4569,7 +4569,7 @@ static void ABSMaskedShort512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short512VectorTests::ABS); + assertArraysEquals(r, a, mask, Short512VectorTests::ABS); } @@ -4595,7 +4595,7 @@ static void NOTShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::NOT); + assertArraysEquals(r, a, Short512VectorTests::NOT); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4610,7 +4610,7 @@ static void notShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::not); + assertArraysEquals(r, a, Short512VectorTests::not); } @@ -4630,7 +4630,7 @@ static void NOTMaskedShort512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short512VectorTests::NOT); + assertArraysEquals(r, a, mask, Short512VectorTests::NOT); } @@ -4653,7 +4653,7 @@ static void ZOMOShort512VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short512VectorTests::ZOMO); + assertArraysEquals(r, a, Short512VectorTests::ZOMO); } @@ -4673,7 +4673,7 @@ static void ZOMOMaskedShort512VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short512VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Short512VectorTests::ZOMO); } @@ -4701,7 +4701,7 @@ static void gatherShort512VectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, Short512VectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, Short512VectorTests::gatherMasked); } static short[] scatter(short a[], int ix, int[] b, int iy) { @@ -4754,7 +4754,7 @@ static void scatterShort512VectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, Short512VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Short512VectorTests::scatterMasked); } @@ -4834,8 +4834,8 @@ static void toIntArrayShort512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4845,8 +4845,8 @@ static void toLongArrayShort512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4856,8 +4856,8 @@ static void toDoubleArrayShort512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4923,7 +4923,7 @@ static void ADDReduceLongShort512VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Short512VectorTests::ADDReduceLong, Short512VectorTests::ADDReduceAllLong); } @@ -4964,7 +4964,7 @@ static void ADDReduceLongShort512VectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Short512VectorTests::ADDReduceLongMasked, Short512VectorTests::ADDReduceAllLongMasked); } @@ -4976,7 +4976,7 @@ static void BroadcastLongShort512VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -4994,7 +4994,7 @@ static void blendShort512VectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Short512VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Short512VectorTests::blend); } @@ -5011,7 +5011,7 @@ static void SelectFromShort512VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpSelectFromMaskProvider") @@ -5030,7 +5030,7 @@ static void SelectFromShort512VectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5107,7 +5107,7 @@ static void maskEqShort512VectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Short512VectorTests::beq); + assertArraysEquals(r, a, b, Short512VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/Short64VectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/Short64VectorLoadStoreTests.java index 425fc0c37e2ec..c42913ae31197 100644 --- a/test/jdk/jdk/incubator/vector/Short64VectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/Short64VectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -58,47 +58,25 @@ public class Short64VectorLoadStoreTests extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (64 / 8)); - static void assertArraysEquals(short[] a, short[] r, boolean[] mask) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0, "at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(short[] a, short[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -401,7 +379,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "shortProviderForIOOBE") @@ -472,7 +450,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new short[a.length]; @@ -483,7 +461,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortMaskProviderForIOOBE") @@ -556,7 +534,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -580,7 +558,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -667,7 +645,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -682,7 +660,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -798,7 +776,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -879,7 +857,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -890,7 +868,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -967,7 +945,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -978,7 +956,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/Short64VectorTests.java b/test/jdk/jdk/incubator/vector/Short64VectorTests.java index 885e39012385f..adc10b3b4b9cd 100644 --- a/test/jdk/jdk/incubator/vector/Short64VectorTests.java +++ b/test/jdk/jdk/incubator/vector/Short64VectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -68,7 +68,7 @@ interface FUnOp { short apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -83,7 +83,7 @@ interface FUnArrayOp { short[] apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -93,13 +93,13 @@ static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { } catch (AssertionError e) { short[] ref = f.apply(a[i]); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -118,17 +118,17 @@ interface FReductionAllOp { short apply(short[] a); } - static void assertReductionArraysEquals(short[] a, short[] b, short c, + static void assertReductionArraysEquals(short[] r, short rc, short[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -140,17 +140,17 @@ interface FReductionAllMaskedOp { short apply(short[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(short[] a, short[] b, short c, boolean[] mask, + static void assertReductionArraysEqualsMasked(short[] r, short rc, short[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -162,17 +162,17 @@ interface FReductionAllOpLong { long apply(short[] a); } - static void assertReductionLongArraysEquals(short[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, short[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -184,17 +184,17 @@ interface FReductionAllMaskedOpLong { long apply(short[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(short[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, short[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -202,37 +202,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(short[] a, short[] b, short element, int index) { + static void assertInsertArraysEquals(short[] r, short[] a, short element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -246,7 +246,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -260,7 +260,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, in } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -280,7 +280,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -300,7 +300,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, bo } } - static void assertBroadcastArraysEquals(short[]a, short[]r) { + static void assertBroadcastArraysEquals(short[] r, short[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -329,7 +329,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -340,7 +340,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -352,7 +352,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -364,11 +364,11 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBi } } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -379,11 +379,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -397,11 +397,11 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -415,7 +415,7 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boo } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -429,11 +429,11 @@ static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -459,7 +459,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -470,11 +470,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTern } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -486,7 +486,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boole } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -499,7 +499,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -512,12 +512,12 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -533,12 +533,12 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -554,7 +554,7 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -569,12 +569,12 @@ static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, s } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -597,7 +597,7 @@ interface FBinArrayOp { short apply(short[] a, int b); } - static void assertArraysEquals(short[] a, short[] r, FBinArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -612,7 +612,7 @@ interface FGatherScatterOp { short[] apply(short[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, FGatherScatterOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -639,7 +639,7 @@ interface FScatterMaskedOp { short[] apply(short[] r, short[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -649,7 +649,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } catch (AssertionError e) { short[] ref = f.apply(a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -660,7 +660,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -670,7 +670,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FS } catch (AssertionError e) { short[] ref = f.apply(r, a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -687,7 +687,7 @@ interface FLaneOp { short[] apply(short[] a, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { + static void assertArraysEquals(short[] r, short[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -697,7 +697,7 @@ static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { } catch (AssertionError e) { short[] ref = f.apply(a, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -707,7 +707,7 @@ interface FLaneBop { short[] apply(short[] a, short[] b, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLaneBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -717,7 +717,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLan } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -728,7 +728,7 @@ interface FLaneMaskedBop { short[] apply(short[] a, short[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -738,7 +738,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, bool } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -749,7 +749,7 @@ interface FLanePartBop { short[] apply(short[] a, short[] b, int origin, int part, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -759,7 +759,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -771,7 +771,7 @@ interface FLanePartMaskedBop { short[] apply(short[] a, short[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -781,7 +781,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -790,7 +790,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } - static void assertArraysEquals(short[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -803,7 +803,7 @@ static void assertArraysEquals(short[] a, int[] r, int offs) { - static void assertArraysEquals(short[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -814,7 +814,7 @@ static void assertArraysEquals(short[] a, long[] r, int offs) { } } - static void assertArraysEquals(short[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1278,7 +1278,7 @@ static void ADDShort64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::ADD); + assertArraysEquals(r, a, b, Short64VectorTests::ADD); } static short add(short a, short b) { return (short)(a + b); @@ -1296,7 +1296,7 @@ static void addShort64VectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::add); + assertArraysEquals(r, a, b, Short64VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1316,7 +1316,7 @@ static void ADDShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::SUB); + assertArraysEquals(r, a, b, Short64VectorTests::SUB); } static short sub(short a, short b) { return (short)(a - b); @@ -1372,7 +1372,7 @@ static void subShort64VectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::sub); + assertArraysEquals(r, a, b, Short64VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1392,7 +1392,7 @@ static void SUBShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::MUL); + assertArraysEquals(r, a, b, Short64VectorTests::MUL); } static short mul(short a, short b) { return (short)(a * b); @@ -1448,7 +1448,7 @@ static void mulShort64VectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::mul); + assertArraysEquals(r, a, b, Short64VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1468,7 +1468,7 @@ static void MULShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::DIV); + assertArraysEquals(r, a, b, Short64VectorTests::DIV); } static short div(short a, short b) { return (short)(a / b); @@ -1533,7 +1533,7 @@ static void divShort64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::div); + assertArraysEquals(r, a, b, Short64VectorTests::div); } @@ -1557,7 +1557,7 @@ static void DIVShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, Short64VectorTests::FIRST_NONZERO); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1620,7 +1620,7 @@ static void FIRST_NONZEROShort64VectorTestsMasked(IntFunction fa, IntFu } } - assertArraysEquals(a, b, r, mask, Short64VectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, Short64VectorTests::FIRST_NONZERO); } static short AND(short a, short b) { @@ -1641,7 +1641,7 @@ static void ANDShort64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::AND); + assertArraysEquals(r, a, b, Short64VectorTests::AND); } static short and(short a, short b) { return (short)(a & b); @@ -1659,7 +1659,7 @@ static void andShort64VectorTests(IntFunction fa, IntFunction av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::and); + assertArraysEquals(r, a, b, Short64VectorTests::and); } @@ -1681,7 +1681,7 @@ static void ANDShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Short64VectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, Short64VectorTests::AND_NOT); } @@ -1747,7 +1747,7 @@ static void ORShort64VectorTests(IntFunction fa, IntFunction f } } - assertArraysEquals(a, b, r, Short64VectorTests::OR); + assertArraysEquals(r, a, b, Short64VectorTests::OR); } static short or(short a, short b) { return (short)(a | b); @@ -1765,7 +1765,7 @@ static void orShort64VectorTests(IntFunction fa, IntFunction f av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::or); + assertArraysEquals(r, a, b, Short64VectorTests::or); } @@ -1787,7 +1787,7 @@ static void ORShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::XOR); + assertArraysEquals(r, a, b, Short64VectorTests::XOR); } @@ -1831,7 +1831,7 @@ static void XORShort64VectorTestsMasked(IntFunction fa, IntFunction fa, Int av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1863,7 +1863,7 @@ static void addShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::add); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1877,7 +1877,7 @@ static void subShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1894,7 +1894,7 @@ static void subShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::sub); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1908,7 +1908,7 @@ static void mulShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1925,7 +1925,7 @@ static void mulShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::mul); } @@ -1944,7 +1944,7 @@ static void divShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::div); } @@ -1965,7 +1965,7 @@ static void divShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::div); } @@ -1981,7 +1981,7 @@ static void ORShort64VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::OR); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1995,7 +1995,7 @@ static void orShort64VectorTestsBroadcastSmokeTest(IntFunction fa, IntF av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::or); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::or); } @@ -2014,7 +2014,7 @@ static void ORShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction fa av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::OR); } @@ -2030,7 +2030,7 @@ static void ANDShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::AND); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2044,7 +2044,7 @@ static void andShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::and); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::and); } @@ -2063,7 +2063,7 @@ static void ANDShort64VectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, Short64VectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, Short64VectorTests::AND); } @@ -2079,7 +2079,7 @@ static void ORShort64VectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short64VectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, Short64VectorTests::OR); } @@ -2098,7 +2098,7 @@ static void ORShort64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, Short64VectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, Short64VectorTests::ADD); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -2130,7 +2130,7 @@ static void ADDShort64VectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::LSHL); + assertArraysEquals(r, a, b, Short64VectorTests::LSHL); } @@ -2177,7 +2177,7 @@ static void LSHLShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::ASHR); + assertArraysEquals(r, a, b, Short64VectorTests::ASHR); } @@ -2225,7 +2225,7 @@ static void ASHRShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::LSHR); + assertArraysEquals(r, a, b, Short64VectorTests::LSHR); } @@ -2273,7 +2273,7 @@ static void LSHRShort64VectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::MIN); + assertArraysEquals(r, a, b, Short64VectorTests::MIN); } static short min(short a, short b) { return (short)(Math.min(a, b)); @@ -2450,7 +2450,7 @@ static void minShort64VectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::min); + assertArraysEquals(r, a, b, Short64VectorTests::min); } static short MAX(short a, short b) { return (short)(Math.max(a, b)); @@ -2470,7 +2470,7 @@ static void MAXShort64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, Short64VectorTests::MAX); + assertArraysEquals(r, a, b, Short64VectorTests::MAX); } static short max(short a, short b) { return (short)(Math.max(a, b)); @@ -2488,7 +2488,7 @@ static void maxShort64VectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::max); + assertArraysEquals(r, a, b, Short64VectorTests::max); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2502,7 +2502,7 @@ static void MINShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::MIN); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2516,7 +2516,7 @@ static void minShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::min); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::min); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2530,7 +2530,7 @@ static void MAXShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::MAX); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2544,7 +2544,7 @@ static void maxShort64VectorTestsBroadcastSmokeTest(IntFunction fa, Int av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, Short64VectorTests::max); + assertBroadcastArraysEquals(r, a, b, Short64VectorTests::max); } static short ANDReduce(short[] a, int idx) { @@ -2587,7 +2587,7 @@ static void ANDReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::ANDReduce, Short64VectorTests::ANDReduceAll); } @@ -2635,7 +2635,7 @@ static void ANDReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::ANDReduceMasked, Short64VectorTests::ANDReduceAllMasked); } @@ -2680,7 +2680,7 @@ static void ORReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::ORReduce, Short64VectorTests::ORReduceAll); } @@ -2728,7 +2728,7 @@ static void ORReduceShort64VectorTestsMasked(IntFunction fa, IntFunctio } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::ORReduceMasked, Short64VectorTests::ORReduceAllMasked); } @@ -2773,7 +2773,7 @@ static void XORReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::XORReduce, Short64VectorTests::XORReduceAll); } @@ -2821,7 +2821,7 @@ static void XORReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::XORReduceMasked, Short64VectorTests::XORReduceAllMasked); } @@ -2863,7 +2863,7 @@ static void ADDReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::ADDReduce, Short64VectorTests::ADDReduceAll); } static short ADDReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2907,7 +2907,7 @@ static void ADDReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::ADDReduceMasked, Short64VectorTests::ADDReduceAllMasked); } static short MULReduce(short[] a, int idx) { @@ -2948,7 +2948,7 @@ static void MULReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::MULReduce, Short64VectorTests::MULReduceAll); } static short MULReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2992,7 +2992,7 @@ static void MULReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::MULReduceMasked, Short64VectorTests::MULReduceAllMasked); } static short MINReduce(short[] a, int idx) { @@ -3033,7 +3033,7 @@ static void MINReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::MINReduce, Short64VectorTests::MINReduceAll); } static short MINReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3078,7 +3078,7 @@ static void MINReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::MINReduceMasked, Short64VectorTests::MINReduceAllMasked); } static short MAXReduce(short[] a, int idx) { @@ -3119,7 +3119,7 @@ static void MAXReduceShort64VectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, Short64VectorTests::MAXReduce, Short64VectorTests::MAXReduceAll); } static short MAXReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3164,7 +3164,7 @@ static void MAXReduceShort64VectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::MAXReduceMasked, Short64VectorTests::MAXReduceAllMasked); } @@ -3190,7 +3190,7 @@ static void anyTrueShort64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short64VectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, Short64VectorTests::anyTrue); } @@ -3216,7 +3216,7 @@ static void allTrueShort64VectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, Short64VectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, Short64VectorTests::allTrue); } @@ -3232,7 +3232,7 @@ static void withShort64VectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (short)4, 0); + assertInsertArraysEquals(r, a, (short)4, 0); } static boolean testIS_DEFAULT(short a) { return bits(a)==0; @@ -3781,7 +3781,7 @@ static void blendShort64VectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpShuffleMaskProvider") @@ -3816,7 +3816,7 @@ static void RearrangeShort64VectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpProvider") static void getShort64VectorTests(IntFunction fa) { @@ -3971,7 +3971,7 @@ static void getShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::get); + assertArraysEquals(r, a, Short64VectorTests::get); } @Test(dataProvider = "shortUnaryOpProvider") @@ -3985,7 +3985,7 @@ static void BroadcastShort64VectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4032,7 +4032,7 @@ static void sliceUnaryShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short64VectorTests::sliceUnary); + assertArraysEquals(r, a, origin, Short64VectorTests::sliceUnary); } static short[] sliceBinary(short[] a, short[] b, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4061,7 +4061,7 @@ static void sliceBinaryShort64VectorTestsBinary(IntFunction fa, IntFunc } } - assertArraysEquals(a, b, r, origin, Short64VectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, Short64VectorTests::sliceBinary); } static short[] slice(short[] a, short[] b, int origin, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4094,7 +4094,7 @@ static void sliceShort64VectorTestsMasked(IntFunction fa, IntFunction fa) { } } - assertArraysEquals(a, r, origin, Short64VectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, Short64VectorTests::unsliceUnary); } static short[] unsliceBinary(short[] a, short[] b, int origin, int part, int idx) { short[] res = new short[SPECIES.length()]; @@ -4160,7 +4160,7 @@ static void unsliceBinaryShort64VectorTestsBinary(IntFunction fa, IntFu } } - assertArraysEquals(a, b, r, origin, part, Short64VectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, Short64VectorTests::unsliceBinary); } static short[] unslice(short[] a, short[] b, int origin, int part, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4216,7 +4216,7 @@ static void unsliceShort64VectorTestsMasked(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, origin, part, mask, Short64VectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, Short64VectorTests::unslice); } @@ -4265,7 +4265,7 @@ static void BITWISE_BLENDShort64VectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, c, r, Short64VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, Short64VectorTests::BITWISE_BLEND); } @Test(dataProvider = "shortTernaryOpProvider") static void bitwiseBlendShort64VectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4281,7 +4281,7 @@ static void bitwiseBlendShort64VectorTests(IntFunction fa, IntFunction< av.bitwiseBlend(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, Short64VectorTests::bitwiseBlend); + assertArraysEquals(r, a, b, c, Short64VectorTests::bitwiseBlend); } @@ -4304,7 +4304,7 @@ static void BITWISE_BLENDShort64VectorTestsMasked(IntFunction fa, IntFu } } - assertArraysEquals(a, b, c, r, mask, Short64VectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, Short64VectorTests::BITWISE_BLEND); } @@ -4322,7 +4322,7 @@ static void BITWISE_BLENDShort64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4351,7 +4351,7 @@ static void bitwiseBlendShort64VectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4437,7 +4437,7 @@ static void bitwiseBlendShort64VectorTestsDoubleBroadcastSmokeTest(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::NEG); + assertArraysEquals(r, a, Short64VectorTests::NEG); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4495,7 +4495,7 @@ static void negShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::neg); + assertArraysEquals(r, a, Short64VectorTests::neg); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4513,7 +4513,7 @@ static void NEGMaskedShort64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short64VectorTests::NEG); + assertArraysEquals(r, a, mask, Short64VectorTests::NEG); } static short ABS(short a) { @@ -4536,7 +4536,7 @@ static void ABSShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::ABS); + assertArraysEquals(r, a, Short64VectorTests::ABS); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4551,7 +4551,7 @@ static void absShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::abs); + assertArraysEquals(r, a, Short64VectorTests::abs); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4569,7 +4569,7 @@ static void ABSMaskedShort64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short64VectorTests::ABS); + assertArraysEquals(r, a, mask, Short64VectorTests::ABS); } @@ -4595,7 +4595,7 @@ static void NOTShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::NOT); + assertArraysEquals(r, a, Short64VectorTests::NOT); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4610,7 +4610,7 @@ static void notShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::not); + assertArraysEquals(r, a, Short64VectorTests::not); } @@ -4630,7 +4630,7 @@ static void NOTMaskedShort64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short64VectorTests::NOT); + assertArraysEquals(r, a, mask, Short64VectorTests::NOT); } @@ -4653,7 +4653,7 @@ static void ZOMOShort64VectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, Short64VectorTests::ZOMO); + assertArraysEquals(r, a, Short64VectorTests::ZOMO); } @@ -4673,7 +4673,7 @@ static void ZOMOMaskedShort64VectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, Short64VectorTests::ZOMO); + assertArraysEquals(r, a, mask, Short64VectorTests::ZOMO); } @@ -4701,7 +4701,7 @@ static void gatherShort64VectorTests(IntFunction fa, BiFunction fa, BiFunction fa, BiFunction fa, IntFunction } } - assertArraysEquals(a, b, r, mask, Short64VectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, Short64VectorTests::scatterMasked); } @@ -4834,8 +4834,8 @@ static void toIntArrayShort64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4845,8 +4845,8 @@ static void toLongArrayShort64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4856,8 +4856,8 @@ static void toDoubleArrayShort64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4923,7 +4923,7 @@ static void ADDReduceLongShort64VectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, Short64VectorTests::ADDReduceLong, Short64VectorTests::ADDReduceAllLong); } @@ -4964,7 +4964,7 @@ static void ADDReduceLongShort64VectorTestsMasked(IntFunction fa, IntFu ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, Short64VectorTests::ADDReduceLongMasked, Short64VectorTests::ADDReduceAllLongMasked); } @@ -4976,7 +4976,7 @@ static void BroadcastLongShort64VectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -4994,7 +4994,7 @@ static void blendShort64VectorTestsBroadcastLongSmokeTest(IntFunction f av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, Short64VectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, Short64VectorTests::blend); } @@ -5011,7 +5011,7 @@ static void SelectFromShort64VectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpSelectFromMaskProvider") @@ -5030,7 +5030,7 @@ static void SelectFromShort64VectorTestsMaskedSmokeTest(IntFunction fa, bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5107,7 +5107,7 @@ static void maskEqShort64VectorTestsSmokeTest(IntFunction fa, IntFunc var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, Short64VectorTests::beq); + assertArraysEquals(r, a, b, Short64VectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java b/test/jdk/jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java index 9770eae468e0f..98429a4f088be 100644 --- a/test/jdk/jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java +++ b/test/jdk/jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -67,47 +67,25 @@ static VectorShape getMaxBit() { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * (Max / 8)); - static void assertArraysEquals(short[] a, short[] r, boolean[] mask) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : (short) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : (short) 0, "at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, int[] im) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals(short[] a, short[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : (short) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } @@ -410,7 +388,7 @@ static void loadStoreArray(IntFunction fa) { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "shortProviderForIOOBE") @@ -481,7 +459,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new short[a.length]; @@ -492,7 +470,7 @@ static void loadStoreMaskArray(IntFunction fa, av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortMaskProviderForIOOBE") @@ -565,7 +543,7 @@ static void loadStoreMask(IntFunction fa, vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -589,7 +567,7 @@ static void loadStoreByteBuffer(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -676,7 +654,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -691,7 +669,7 @@ static void loadStoreByteBufferMask(IntFunction fa, Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -807,7 +785,7 @@ static void loadStoreByteArray(IntFunction fa, av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "shortByteProviderForIOOBE") @@ -888,7 +866,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -899,7 +877,7 @@ static void loadStoreByteArrayMask(IntFunction fa, av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "shortByteMaskProviderForIOOBE") @@ -976,7 +954,7 @@ static void loadStoreMask(IntFunction fm) { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -987,7 +965,7 @@ static void loadStoreShuffle() { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } diff --git a/test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java b/test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java index f5b497bfa4376..7e4d7e3fa09fd 100644 --- a/test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java +++ b/test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -73,7 +73,7 @@ interface FUnOp { short apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -88,7 +88,7 @@ interface FUnArrayOp { short[] apply(short a); } - static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -98,13 +98,13 @@ static void assertArraysEquals(short[] a, short[] r, FUnArrayOp f) { } catch (AssertionError e) { short[] ref = f.apply(a[i]); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals(short[] a, short[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals(short[] r, short[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -123,17 +123,17 @@ interface FReductionAllOp { short apply(short[] a); } - static void assertReductionArraysEquals(short[] a, short[] b, short c, + static void assertReductionArraysEquals(short[] r, short rc, short[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -145,17 +145,17 @@ interface FReductionAllMaskedOp { short apply(short[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked(short[] a, short[] b, short c, boolean[] mask, + static void assertReductionArraysEqualsMasked(short[] r, short rc, short[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -167,17 +167,17 @@ interface FReductionAllOpLong { long apply(short[] a); } - static void assertReductionLongArraysEquals(short[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, short[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -189,17 +189,17 @@ interface FReductionAllMaskedOpLong { long apply(short[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked(short[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, short[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -207,37 +207,37 @@ interface FBoolReductionOp { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals(short[] a, short[] b, short element, int index) { + static void assertInsertArraysEquals(short[] r, short[] a, short element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -251,7 +251,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, int v } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -265,7 +265,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, in } } - static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals(short[] r, short[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -285,7 +285,7 @@ static void assertRearrangeArraysEquals(short[] a, short[] r, int[] order, boole } } - static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals(short[] r, short[] a, short[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -305,7 +305,7 @@ static void assertSelectFromArraysEquals(short[] a, short[] r, short[] order, bo } } - static void assertBroadcastArraysEquals(short[]a, short[]r) { + static void assertBroadcastArraysEquals(short[] r, short[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -334,7 +334,7 @@ static FBinMaskOp lift(FBinOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -345,7 +345,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -357,7 +357,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, FBinOp } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -369,11 +369,11 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, FBi } } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -384,11 +384,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -402,11 +402,11 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] r, boolean } } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -420,7 +420,7 @@ static void assertBroadcastLongArraysEquals(short[] a, short[] b, short[] r, boo } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -434,11 +434,11 @@ static void assertShiftArraysEquals(short[] a, short[] b, short[] r, FBinOp f) { } } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals(short[] a, short[] b, short[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals(short[] r, short[] a, short[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -464,7 +464,7 @@ static FTernMaskOp lift(FTernOp f) { } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -475,11 +475,11 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, FTern } } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -491,7 +491,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] c, short[] r, boole } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -504,7 +504,7 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,12 +517,12 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -538,12 +538,12 @@ static void assertBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] } } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -559,7 +559,7 @@ static void assertAltBroadcastArraysEquals(short[] a, short[] b, short[] c, shor } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -574,12 +574,12 @@ static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, s } } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals(short[] a, short[] b, short[] c, short[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals(short[] r, short[] a, short[] b, short[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -602,7 +602,7 @@ interface FBinArrayOp { short apply(short[] a, int b); } - static void assertArraysEquals(short[] a, short[] r, FBinArrayOp f) { + static void assertArraysEquals(short[] r, short[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -617,7 +617,7 @@ interface FGatherScatterOp { short[] apply(short[] a, int ix, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, FGatherScatterOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -644,7 +644,7 @@ interface FScatterMaskedOp { short[] apply(short[] r, short[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -654,7 +654,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } catch (AssertionError e) { short[] ref = f.apply(a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -665,7 +665,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FG } } - static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals(short[] r, short[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -675,7 +675,7 @@ static void assertArraysEquals(short[] a, int[] b, short[] r, boolean[] mask, FS } catch (AssertionError e) { short[] ref = f.apply(r, a, i, mask, b, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -692,7 +692,7 @@ interface FLaneOp { short[] apply(short[] a, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { + static void assertArraysEquals(short[] r, short[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -702,7 +702,7 @@ static void assertArraysEquals(short[] a, short[] r, int origin, FLaneOp f) { } catch (AssertionError e) { short[] ref = f.apply(a, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -712,7 +712,7 @@ interface FLaneBop { short[] apply(short[] a, short[] b, int origin, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLaneBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -722,7 +722,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, FLan } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -733,7 +733,7 @@ interface FLaneMaskedBop { short[] apply(short[] a, short[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -743,7 +743,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, bool } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -754,7 +754,7 @@ interface FLanePartBop { short[] apply(short[] a, short[] b, int origin, int part, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -764,7 +764,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -776,7 +776,7 @@ interface FLanePartMaskedBop { short[] apply(short[] a, short[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals(short[] r, short[] a, short[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -786,7 +786,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } catch (AssertionError e) { short[] ref = f.apply(a, b, origin, part, mask, i); short[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -795,7 +795,7 @@ static void assertArraysEquals(short[] a, short[] b, short[] r, int origin, int } - static void assertArraysEquals(short[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -808,7 +808,7 @@ static void assertArraysEquals(short[] a, int[] r, int offs) { - static void assertArraysEquals(short[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -819,7 +819,7 @@ static void assertArraysEquals(short[] a, long[] r, int offs) { } } - static void assertArraysEquals(short[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, short[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1283,7 +1283,7 @@ static void ADDShortMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::ADD); + assertArraysEquals(r, a, b, ShortMaxVectorTests::ADD); } static short add(short a, short b) { return (short)(a + b); @@ -1301,7 +1301,7 @@ static void addShortMaxVectorTests(IntFunction fa, IntFunction av.add(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::add); + assertArraysEquals(r, a, b, ShortMaxVectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1321,7 +1321,7 @@ static void ADDShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::SUB); + assertArraysEquals(r, a, b, ShortMaxVectorTests::SUB); } static short sub(short a, short b) { return (short)(a - b); @@ -1377,7 +1377,7 @@ static void subShortMaxVectorTests(IntFunction fa, IntFunction av.sub(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::sub); + assertArraysEquals(r, a, b, ShortMaxVectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1397,7 +1397,7 @@ static void SUBShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::MUL); + assertArraysEquals(r, a, b, ShortMaxVectorTests::MUL); } static short mul(short a, short b) { return (short)(a * b); @@ -1453,7 +1453,7 @@ static void mulShortMaxVectorTests(IntFunction fa, IntFunction av.mul(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::mul); + assertArraysEquals(r, a, b, ShortMaxVectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1473,7 +1473,7 @@ static void MULShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::DIV); + assertArraysEquals(r, a, b, ShortMaxVectorTests::DIV); } static short div(short a, short b) { return (short)(a / b); @@ -1538,7 +1538,7 @@ static void divShortMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::div); + assertArraysEquals(r, a, b, ShortMaxVectorTests::div); } @@ -1562,7 +1562,7 @@ static void DIVShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, ShortMaxVectorTests::FIRST_NONZERO); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1625,7 +1625,7 @@ static void FIRST_NONZEROShortMaxVectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, mask, ShortMaxVectorTests::FIRST_NONZERO); + assertArraysEquals(r, a, b, mask, ShortMaxVectorTests::FIRST_NONZERO); } static short AND(short a, short b) { @@ -1646,7 +1646,7 @@ static void ANDShortMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::AND); + assertArraysEquals(r, a, b, ShortMaxVectorTests::AND); } static short and(short a, short b) { return (short)(a & b); @@ -1664,7 +1664,7 @@ static void andShortMaxVectorTests(IntFunction fa, IntFunction av.and(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::and); + assertArraysEquals(r, a, b, ShortMaxVectorTests::and); } @@ -1686,7 +1686,7 @@ static void ANDShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, ShortMaxVectorTests::AND_NOT); + assertArraysEquals(r, a, b, mask, ShortMaxVectorTests::AND_NOT); } @@ -1752,7 +1752,7 @@ static void ORShortMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::OR); + assertArraysEquals(r, a, b, ShortMaxVectorTests::OR); } static short or(short a, short b) { return (short)(a | b); @@ -1770,7 +1770,7 @@ static void orShortMaxVectorTests(IntFunction fa, IntFunction av.or(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::or); + assertArraysEquals(r, a, b, ShortMaxVectorTests::or); } @@ -1792,7 +1792,7 @@ static void ORShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::XOR); + assertArraysEquals(r, a, b, ShortMaxVectorTests::XOR); } @@ -1836,7 +1836,7 @@ static void XORShortMaxVectorTestsMasked(IntFunction fa, IntFunction fa, In av.add(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::add); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1868,7 +1868,7 @@ static void addShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.add(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::add); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::add); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1882,7 +1882,7 @@ static void subShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.sub(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::sub); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1899,7 +1899,7 @@ static void subShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.sub(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::sub); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::sub); } @Test(dataProvider = "shortBinaryOpProvider") @@ -1913,7 +1913,7 @@ static void mulShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.mul(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::mul); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -1930,7 +1930,7 @@ static void mulShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.mul(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::mul); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::mul); } @@ -1949,7 +1949,7 @@ static void divShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.div(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::div); } @@ -1970,7 +1970,7 @@ static void divShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.div(b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::div); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::div); } @@ -1986,7 +1986,7 @@ static void ORShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, Int av.lanewise(VectorOperators.OR, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::OR); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2000,7 +2000,7 @@ static void orShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, Int av.or(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::or); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::or); } @@ -2019,7 +2019,7 @@ static void ORShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction f av.lanewise(VectorOperators.OR, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::OR); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::OR); } @@ -2035,7 +2035,7 @@ static void ANDShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.AND, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::AND); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2049,7 +2049,7 @@ static void andShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.and(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::and); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::and); } @@ -2068,7 +2068,7 @@ static void ANDShortMaxVectorTestsBroadcastMaskedSmokeTest(IntFunction av.lanewise(VectorOperators.AND, b[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, mask, ShortMaxVectorTests::AND); + assertBroadcastArraysEquals(r, a, b, mask, ShortMaxVectorTests::AND); } @@ -2084,7 +2084,7 @@ static void ORShortMaxVectorTestsBroadcastLongSmokeTest(IntFunction fa, av.lanewise(VectorOperators.OR, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, ShortMaxVectorTests::OR); + assertBroadcastLongArraysEquals(r, a, b, ShortMaxVectorTests::OR); } @@ -2103,7 +2103,7 @@ static void ORShortMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa av.lanewise(VectorOperators.ADD, (long)b[i]).intoArray(r, i); } - assertBroadcastLongArraysEquals(a, b, r, ShortMaxVectorTests::ADD); + assertBroadcastLongArraysEquals(r, a, b, ShortMaxVectorTests::ADD); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -2135,7 +2135,7 @@ static void ADDShortMaxVectorTestsBroadcastMaskedLongSmokeTest(IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::MIN); + assertArraysEquals(r, a, b, ShortMaxVectorTests::MIN); } static short min(short a, short b) { return (short)(Math.min(a, b)); @@ -2455,7 +2455,7 @@ static void minShortMaxVectorTests(IntFunction fa, IntFunction av.min(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::min); + assertArraysEquals(r, a, b, ShortMaxVectorTests::min); } static short MAX(short a, short b) { return (short)(Math.max(a, b)); @@ -2475,7 +2475,7 @@ static void MAXShortMaxVectorTests(IntFunction fa, IntFunction } } - assertArraysEquals(a, b, r, ShortMaxVectorTests::MAX); + assertArraysEquals(r, a, b, ShortMaxVectorTests::MAX); } static short max(short a, short b) { return (short)(Math.max(a, b)); @@ -2493,7 +2493,7 @@ static void maxShortMaxVectorTests(IntFunction fa, IntFunction av.max(bv).intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::max); + assertArraysEquals(r, a, b, ShortMaxVectorTests::max); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2507,7 +2507,7 @@ static void MINShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MIN, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::MIN); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::MIN); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2521,7 +2521,7 @@ static void minShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.min(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::min); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::min); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2535,7 +2535,7 @@ static void MAXShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.lanewise(VectorOperators.MAX, b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::MAX); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::MAX); } @Test(dataProvider = "shortBinaryOpProvider") @@ -2549,7 +2549,7 @@ static void maxShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, In av.max(b[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, r, ShortMaxVectorTests::max); + assertBroadcastArraysEquals(r, a, b, ShortMaxVectorTests::max); } static short ANDReduce(short[] a, int idx) { @@ -2592,7 +2592,7 @@ static void ANDReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::ANDReduce, ShortMaxVectorTests::ANDReduceAll); } @@ -2640,7 +2640,7 @@ static void ANDReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::ANDReduceMasked, ShortMaxVectorTests::ANDReduceAllMasked); } @@ -2685,7 +2685,7 @@ static void ORReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::ORReduce, ShortMaxVectorTests::ORReduceAll); } @@ -2733,7 +2733,7 @@ static void ORReduceShortMaxVectorTestsMasked(IntFunction fa, IntFuncti } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::ORReduceMasked, ShortMaxVectorTests::ORReduceAllMasked); } @@ -2778,7 +2778,7 @@ static void XORReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::XORReduce, ShortMaxVectorTests::XORReduceAll); } @@ -2826,7 +2826,7 @@ static void XORReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::XORReduceMasked, ShortMaxVectorTests::XORReduceAllMasked); } @@ -2868,7 +2868,7 @@ static void ADDReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::ADDReduce, ShortMaxVectorTests::ADDReduceAll); } static short ADDReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2912,7 +2912,7 @@ static void ADDReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::ADDReduceMasked, ShortMaxVectorTests::ADDReduceAllMasked); } static short MULReduce(short[] a, int idx) { @@ -2953,7 +2953,7 @@ static void MULReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::MULReduce, ShortMaxVectorTests::MULReduceAll); } static short MULReduceMasked(short[] a, int idx, boolean[] mask) { @@ -2997,7 +2997,7 @@ static void MULReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::MULReduceMasked, ShortMaxVectorTests::MULReduceAllMasked); } static short MINReduce(short[] a, int idx) { @@ -3038,7 +3038,7 @@ static void MINReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::MINReduce, ShortMaxVectorTests::MINReduceAll); } static short MINReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3083,7 +3083,7 @@ static void MINReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::MINReduceMasked, ShortMaxVectorTests::MINReduceAllMasked); } static short MAXReduce(short[] a, int idx) { @@ -3124,7 +3124,7 @@ static void MAXReduceShortMaxVectorTests(IntFunction fa) { } } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, ShortMaxVectorTests::MAXReduce, ShortMaxVectorTests::MAXReduceAll); } static short MAXReduceMasked(short[] a, int idx, boolean[] mask) { @@ -3169,7 +3169,7 @@ static void MAXReduceShortMaxVectorTestsMasked(IntFunction fa, IntFunct } } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::MAXReduceMasked, ShortMaxVectorTests::MAXReduceAllMasked); } @@ -3195,7 +3195,7 @@ static void anyTrueShortMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, ShortMaxVectorTests::anyTrue); + assertReductionBoolArraysEquals(r, mask, ShortMaxVectorTests::anyTrue); } @@ -3221,7 +3221,7 @@ static void allTrueShortMaxVectorTests(IntFunction fm) { } } - assertReductionBoolArraysEquals(mask, r, ShortMaxVectorTests::allTrue); + assertReductionBoolArraysEquals(r, mask, ShortMaxVectorTests::allTrue); } @@ -3237,7 +3237,7 @@ static void withShortMaxVectorTests(IntFunction fa) { } } - assertInsertArraysEquals(a, r, (short)4, 0); + assertInsertArraysEquals(r, a, (short)4, 0); } static boolean testIS_DEFAULT(short a) { return bits(a)==0; @@ -3786,7 +3786,7 @@ static void blendShortMaxVectorTests(IntFunction fa, IntFunction fa, } } - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpShuffleMaskProvider") @@ -3821,7 +3821,7 @@ static void RearrangeShortMaxVectorTestsMaskedSmokeTest(IntFunction fa, av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpProvider") static void getShortMaxVectorTests(IntFunction fa) { @@ -3976,7 +3976,7 @@ static void getShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::get); + assertArraysEquals(r, a, ShortMaxVectorTests::get); } @Test(dataProvider = "shortUnaryOpProvider") @@ -3990,7 +3990,7 @@ static void BroadcastShortMaxVectorTests(IntFunction fa) { } } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @@ -4037,7 +4037,7 @@ static void sliceUnaryShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, ShortMaxVectorTests::sliceUnary); + assertArraysEquals(r, a, origin, ShortMaxVectorTests::sliceUnary); } static short[] sliceBinary(short[] a, short[] b, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4066,7 +4066,7 @@ static void sliceBinaryShortMaxVectorTestsBinary(IntFunction fa, IntFun } } - assertArraysEquals(a, b, r, origin, ShortMaxVectorTests::sliceBinary); + assertArraysEquals(r, a, b, origin, ShortMaxVectorTests::sliceBinary); } static short[] slice(short[] a, short[] b, int origin, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4099,7 +4099,7 @@ static void sliceShortMaxVectorTestsMasked(IntFunction fa, IntFunction< } } - assertArraysEquals(a, b, r, origin, mask, ShortMaxVectorTests::slice); + assertArraysEquals(r, a, b, origin, mask, ShortMaxVectorTests::slice); } static short[] unsliceUnary(short[] a, int origin, int idx) { short[] res = new short[SPECIES.length()]; @@ -4126,7 +4126,7 @@ static void unsliceUnaryShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, origin, ShortMaxVectorTests::unsliceUnary); + assertArraysEquals(r, a, origin, ShortMaxVectorTests::unsliceUnary); } static short[] unsliceBinary(short[] a, short[] b, int origin, int part, int idx) { short[] res = new short[SPECIES.length()]; @@ -4165,7 +4165,7 @@ static void unsliceBinaryShortMaxVectorTestsBinary(IntFunction fa, IntF } } - assertArraysEquals(a, b, r, origin, part, ShortMaxVectorTests::unsliceBinary); + assertArraysEquals(r, a, b, origin, part, ShortMaxVectorTests::unsliceBinary); } static short[] unslice(short[] a, short[] b, int origin, int part, boolean[] mask, int idx) { short[] res = new short[SPECIES.length()]; @@ -4221,7 +4221,7 @@ static void unsliceShortMaxVectorTestsMasked(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, origin, part, mask, ShortMaxVectorTests::unslice); + assertArraysEquals(r, a, b, origin, part, mask, ShortMaxVectorTests::unslice); } @@ -4270,7 +4270,7 @@ static void BITWISE_BLENDShortMaxVectorTests(IntFunction fa, IntFunctio } } - assertArraysEquals(a, b, c, r, ShortMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, ShortMaxVectorTests::BITWISE_BLEND); } @Test(dataProvider = "shortTernaryOpProvider") static void bitwiseBlendShortMaxVectorTests(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4286,7 +4286,7 @@ static void bitwiseBlendShortMaxVectorTests(IntFunction fa, IntFunction av.bitwiseBlend(bv, cv).intoArray(r, i); } - assertArraysEquals(a, b, c, r, ShortMaxVectorTests::bitwiseBlend); + assertArraysEquals(r, a, b, c, ShortMaxVectorTests::bitwiseBlend); } @@ -4309,7 +4309,7 @@ static void BITWISE_BLENDShortMaxVectorTestsMasked(IntFunction fa, IntF } } - assertArraysEquals(a, b, c, r, mask, ShortMaxVectorTests::BITWISE_BLEND); + assertArraysEquals(r, a, b, c, mask, ShortMaxVectorTests::BITWISE_BLEND); } @@ -4327,7 +4327,7 @@ static void BITWISE_BLENDShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4356,7 +4356,7 @@ static void bitwiseBlendShortMaxVectorTestsBroadcastSmokeTest(IntFunction fa, IntFunction fb, IntFunction fc) { @@ -4442,7 +4442,7 @@ static void bitwiseBlendShortMaxVectorTestsDoubleBroadcastSmokeTest(IntFunction< av.bitwiseBlend(b[i], c[i]).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, ShortMaxVectorTests::bitwiseBlend); + assertDoubleBroadcastArraysEquals(r, a, b, c, ShortMaxVectorTests::bitwiseBlend); } @@ -4461,7 +4461,7 @@ static void BITWISE_BLENDShortMaxVectorTestsDoubleBroadcastMaskedSmokeTest(IntFu av.lanewise(VectorOperators.BITWISE_BLEND, b[i], c[i], vmask).intoArray(r, i); } - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, ShortMaxVectorTests::BITWISE_BLEND); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, ShortMaxVectorTests::BITWISE_BLEND); } @@ -4485,7 +4485,7 @@ static void NEGShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::NEG); + assertArraysEquals(r, a, ShortMaxVectorTests::NEG); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4500,7 +4500,7 @@ static void negShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::neg); + assertArraysEquals(r, a, ShortMaxVectorTests::neg); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4518,7 +4518,7 @@ static void NEGMaskedShortMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ShortMaxVectorTests::NEG); + assertArraysEquals(r, a, mask, ShortMaxVectorTests::NEG); } static short ABS(short a) { @@ -4541,7 +4541,7 @@ static void ABSShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::ABS); + assertArraysEquals(r, a, ShortMaxVectorTests::ABS); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4556,7 +4556,7 @@ static void absShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::abs); + assertArraysEquals(r, a, ShortMaxVectorTests::abs); } @Test(dataProvider = "shortUnaryOpMaskProvider") @@ -4574,7 +4574,7 @@ static void ABSMaskedShortMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ShortMaxVectorTests::ABS); + assertArraysEquals(r, a, mask, ShortMaxVectorTests::ABS); } @@ -4600,7 +4600,7 @@ static void NOTShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::NOT); + assertArraysEquals(r, a, ShortMaxVectorTests::NOT); } @Test(dataProvider = "shortUnaryOpProvider") @@ -4615,7 +4615,7 @@ static void notShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::not); + assertArraysEquals(r, a, ShortMaxVectorTests::not); } @@ -4635,7 +4635,7 @@ static void NOTMaskedShortMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ShortMaxVectorTests::NOT); + assertArraysEquals(r, a, mask, ShortMaxVectorTests::NOT); } @@ -4658,7 +4658,7 @@ static void ZOMOShortMaxVectorTests(IntFunction fa) { } } - assertArraysEquals(a, r, ShortMaxVectorTests::ZOMO); + assertArraysEquals(r, a, ShortMaxVectorTests::ZOMO); } @@ -4678,7 +4678,7 @@ static void ZOMOMaskedShortMaxVectorTests(IntFunction fa, } } - assertArraysEquals(a, r, mask, ShortMaxVectorTests::ZOMO); + assertArraysEquals(r, a, mask, ShortMaxVectorTests::ZOMO); } @@ -4706,7 +4706,7 @@ static void gatherShortMaxVectorTests(IntFunction fa, BiFunction fa, BiFunction< } } - assertArraysEquals(a, b, r, mask, ShortMaxVectorTests::gatherMasked); + assertArraysEquals(r, a, b, mask, ShortMaxVectorTests::gatherMasked); } static short[] scatter(short a[], int ix, int[] b, int iy) { @@ -4759,7 +4759,7 @@ static void scatterShortMaxVectorTests(IntFunction fa, BiFunction fa, IntFunctio } } - assertArraysEquals(a, b, r, mask, ShortMaxVectorTests::scatterMasked); + assertArraysEquals(r, a, b, mask, ShortMaxVectorTests::scatterMasked); } @@ -4839,8 +4839,8 @@ static void toIntArrayShortMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -4850,8 +4850,8 @@ static void toLongArrayShortMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -4861,8 +4861,8 @@ static void toDoubleArrayShortMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector av = ShortVector.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } @@ -4928,7 +4928,7 @@ static void ADDReduceLongShortMaxVectorTests(IntFunction fa) { ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, ShortMaxVectorTests::ADDReduceLong, ShortMaxVectorTests::ADDReduceAllLong); } @@ -4969,7 +4969,7 @@ static void ADDReduceLongShortMaxVectorTestsMasked(IntFunction fa, IntF ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, ShortMaxVectorTests::ADDReduceLongMasked, ShortMaxVectorTests::ADDReduceAllLongMasked); } @@ -4981,7 +4981,7 @@ static void BroadcastLongShortMaxVectorTestsSmokeTest(IntFunction fa) { for (int i = 0; i < a.length; i += SPECIES.length()) { ShortVector.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "shortBinaryOpMaskProvider") @@ -4999,7 +4999,7 @@ static void blendShortMaxVectorTestsBroadcastLongSmokeTest(IntFunction av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, ShortMaxVectorTests::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, ShortMaxVectorTests::blend); } @@ -5016,7 +5016,7 @@ static void SelectFromShortMaxVectorTests(IntFunction fa, bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "shortUnaryOpSelectFromMaskProvider") @@ -5035,7 +5035,7 @@ static void SelectFromShortMaxVectorTestsMaskedSmokeTest(IntFunction fa bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -5112,7 +5112,7 @@ static void maskEqShortMaxVectorTestsSmokeTest(IntFunction fa, IntFun var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, ShortMaxVectorTests::beq); + assertArraysEquals(r, a, b, ShortMaxVectorTests::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/VectorReshapeTests.java b/test/jdk/jdk/incubator/vector/VectorReshapeTests.java index 422b6f702bf55..01dcc4caf85a0 100644 --- a/test/jdk/jdk/incubator/vector/VectorReshapeTests.java +++ b/test/jdk/jdk/incubator/vector/VectorReshapeTests.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -416,7 +416,7 @@ else if (partLimit >= 0) ", origin=" + origin); System.out.println("expect: "+Arrays.toString(expected)); System.out.println("output: "+Arrays.toString(output)); - Assert.assertEquals(expected, output); + Assert.assertEquals(output, expected); } @Test(dataProvider = "byteUnaryOpProvider") diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Long-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Long-op.template index 42626dee5967f..364742220cc9f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Long-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Long-op.template @@ -2,5 +2,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$BroadcastLongSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertBroadcastLongArraysEquals(a, b, r, $vectorteststype$::[[TEST]]); + assertBroadcastLongArraysEquals(r, a, b, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-Long-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-Long-op.template index b80ec25be8cda..4e207dafc6408 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-Long-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-Long-op.template @@ -3,5 +3,5 @@ static void [[TEST]]$vectorteststype$BroadcastMaskedLongSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertBroadcastLongArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]]); + assertBroadcastLongArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-op.template index 0c79d51ba329a..887e2e5698204 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-Masked-op.template @@ -3,5 +3,5 @@ static void [[TEST]]$vectorteststype$BroadcastMaskedSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertBroadcastArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]]); + assertBroadcastArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op-math.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op-math.template index 5abbf1feac3d0..7964661ece795 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op-math.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op-math.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$BroadcastSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertBroadcastArraysEqualsWithinOneUlp(a, b, r, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); + assertBroadcastArraysEqualsWithinOneUlp(r, a, b, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op.template index 64c74455b94eb..737d282a62ab5 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Broadcast-op.template @@ -2,5 +2,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$BroadcastSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertBroadcastArraysEquals(a, b, r, $vectorteststype$::[[TEST]]); + assertBroadcastArraysEquals(r, a, b, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Masked-op.template index fe3af3e1fd111..df0a1d55131aa 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-Masked-op.template @@ -3,5 +3,5 @@ static void [[TEST]]$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op-math.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op-math.template index 82c141fc32a03..6d845a652e959 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op-math.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op-math.template @@ -9,6 +9,6 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertArraysEqualsWithinOneUlp(a, b, r, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); + assertArraysEqualsWithinOneUlp(r, a, b, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op.template index 9fff3c0751c4a..aa7dc156cfe08 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Binary-op.template @@ -5,5 +5,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertArraysEquals(a, b, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Blend-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Blend-op.template index c048c9c56430b..519ea524ff804 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Blend-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Blend-op.template @@ -7,5 +7,5 @@ static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, mask, $vectorteststype$::blend); + assertArraysEquals(r, a, b, mask, $vectorteststype$::blend); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-BoolReduction-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-BoolReduction-op.template index 2c92614fd4bae..b3127c1383c57 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-BoolReduction-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-BoolReduction-op.template @@ -1,5 +1,5 @@ @Test(dataProvider = "boolUnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction fm) { [[KERNEL]] - assertReductionBoolArraysEquals(mask, r, $vectorteststype$::[[TEST]]); + assertReductionBoolArraysEquals(r, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Broadcast.template b/test/jdk/jdk/incubator/vector/templates/Unit-Broadcast.template index 5c3d22ab2b446..a5748c3f8ae03 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Broadcast.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Broadcast.template @@ -2,7 +2,7 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void Broadcast$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Gather-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Gather-Masked-op.template index 9f25e4edd99b6..1f106214601c3 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Gather-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Gather-Masked-op.template @@ -12,6 +12,6 @@ @Test(dataProvider = "$type$UnaryMaskedOpIndexProvider") static void [[TEST]][[TEST_TYPE]]$vectorteststype$(IntFunction<$type$[]> fa, BiFunction fs, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]][[TEST_TYPE]]); + assertArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]][[TEST_TYPE]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Gather-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Gather-op.template index a44602eb9b6f0..b16472f8a1c3f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Gather-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Gather-op.template @@ -10,5 +10,5 @@ @Test(dataProvider = "$type$UnaryOpIndexProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa, BiFunction fs) { [[KERNEL]] - assertArraysEquals(a, b, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Get-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Get-op.template index 00f1a8300c06f..9feb403171c76 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Get-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Get-op.template @@ -1,5 +1,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void get$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEquals(a, r, $vectorteststype$::get); + assertArraysEquals(r, a, $vectorteststype$::get); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Masked-op.template index c6a97475bca46..551d99d7c83b1 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Masked-op.template @@ -3,5 +3,5 @@ static void [[TEST]]Masked$vectorteststype$(IntFunction<$type$[]> fa, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, r, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Miscellaneous.template b/test/jdk/jdk/incubator/vector/templates/Unit-Miscellaneous.template index 059bb42b9390d..6e97d1517d7c9 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Miscellaneous.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Miscellaneous.template @@ -45,8 +45,8 @@ for (int i = 0; i < a.length; i += SPECIES.length()) { $abstractvectortype$ av = $abstractvectortype$.fromArray(SPECIES, a, i); - int [] r = av.toIntArray(); - assertArraysEquals(a, r, i); + int[] r = av.toIntArray(); + assertArraysEquals(r, a, i); } } @@ -60,8 +60,8 @@ for (int i = 0; i < a.length; i += SPECIES.length()) { $abstractvectortype$ av = $abstractvectortype$.fromArray(SPECIES, a, i); - long [] r = av.toLongArray(); - assertArraysEquals(a, r, i); + long[] r = av.toLongArray(); + assertArraysEquals(r, a, i); } } @@ -72,8 +72,8 @@ for (int i = 0; i < a.length; i += SPECIES.length()) { $abstractvectortype$ av = $abstractvectortype$.fromArray(SPECIES, a, i); - double [] r = av.toDoubleArray(); - assertArraysEquals(a, r, i); + double[] r = av.toDoubleArray(); + assertArraysEquals(r, a, i); } } #end[!Double] @@ -115,7 +115,7 @@ $abstractvectortype$ av = $abstractvectortype$.fromArray(SPECIES, a, i); av.reinterpretAsBytes().intoArray(r, i); } - assertArraysEquals(a, r, 0); + assertArraysEquals(r, a, 0); } #end[byte] @@ -154,7 +154,7 @@ ra += r[i]; } - assertReductionLongArraysEquals(a, r, ra, + assertReductionLongArraysEquals(r, ra, a, $vectorteststype$::ADDReduceLong, $vectorteststype$::ADDReduceAllLong); } @@ -195,7 +195,7 @@ ra += r[i]; } - assertReductionLongArraysEqualsMasked(a, r, ra, mask, + assertReductionLongArraysEqualsMasked(r, ra, a, mask, $vectorteststype$::ADDReduceLongMasked, $vectorteststype$::ADDReduceAllLongMasked); } @@ -211,7 +211,7 @@ for (int i = 0; i < a.length; i += SPECIES.length()) { $abstractvectortype$.broadcast(SPECIES, (long)a[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, r); + assertBroadcastArraysEquals(r, a); } @Test(dataProvider = "$type$BinaryOpMaskProvider") @@ -229,7 +229,7 @@ av.blend((long)b[i], vmask).intoArray(r, i); } } - assertBroadcastLongArraysEquals(a, b, r, mask, $vectorteststype$::blend); + assertBroadcastLongArraysEquals(r, a, b, mask, $vectorteststype$::blend); } #end[!Long] @@ -250,7 +250,7 @@ ra += r[i]; } - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, $vectorteststype$::ADDReduce, $vectorteststype$::ADDReduceAll); } @@ -272,7 +272,7 @@ ra += r[i]; } - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, $vectorteststype$::ADDReduceMasked, $vectorteststype$::ADDReduceAllMasked); } #end[Long] @@ -294,7 +294,7 @@ bv.selectFrom(av).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, SPECIES.length()); } #if[Int] @@ -317,7 +317,7 @@ bv.selectFrom(av, vmask).intoArray(r, i); } - assertSelectFromArraysEquals(a, r, order, mask, SPECIES.length()); + assertSelectFromArraysEquals(r, a, order, mask, SPECIES.length()); } @Test(dataProvider = "shuffleProvider") @@ -394,7 +394,7 @@ var cv = av.eq(bv); cv.intoArray(r, i); } - assertArraysEquals(a, b, r, $vectorteststype$::beq); + assertArraysEquals(r, a, b, $vectorteststype$::beq); } @Test(dataProvider = "maskProvider") diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Rearrange.template b/test/jdk/jdk/incubator/vector/templates/Unit-Rearrange.template index f4feba0efa847..de66f1ae23424 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Rearrange.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Rearrange.template @@ -3,7 +3,7 @@ static void Rearrange$vectorteststype$(IntFunction<$type$[]> fa, BiFunction fs) { [[KERNEL]] - assertRearrangeArraysEquals(a, r, order, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, SPECIES.length()); } @Test(dataProvider = "$type$UnaryOpShuffleMaskProvider") @@ -21,5 +21,5 @@ av.rearrange(VectorShuffle.fromArray(SPECIES, order, i), vmask).intoArray(r, i); } - assertRearrangeArraysEquals(a, r, order, mask, SPECIES.length()); + assertRearrangeArraysEquals(r, a, order, mask, SPECIES.length()); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Max-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Max-op.template index 892b99ae92334..70ffa79bf6fbd 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Max-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Max-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpMaskProvider") static void [[TEST]]Reduce$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction fm) { [[KERNEL]] - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, $vectorteststype$::[[TEST]]ReduceMasked, $vectorteststype$::[[TEST]]ReduceAllMasked); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Min-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Min-op.template index 892b99ae92334..70ffa79bf6fbd 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Min-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-Min-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpMaskProvider") static void [[TEST]]Reduce$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction fm) { [[KERNEL]] - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, $vectorteststype$::[[TEST]]ReduceMasked, $vectorteststype$::[[TEST]]ReduceAllMasked); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-op.template index 892b99ae92334..70ffa79bf6fbd 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Masked-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpMaskProvider") static void [[TEST]]Reduce$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction fm) { [[KERNEL]] - assertReductionArraysEqualsMasked(a, r, ra, mask, + assertReductionArraysEqualsMasked(r, ra, a, mask, $vectorteststype$::[[TEST]]ReduceMasked, $vectorteststype$::[[TEST]]ReduceAllMasked); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Max-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Max-op.template index 9bd17186aa6a6..b86248f3f09f6 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Max-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Max-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]Reduce$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, $vectorteststype$::[[TEST]]Reduce, $vectorteststype$::[[TEST]]ReduceAll); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Min-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Min-op.template index 9bd17186aa6a6..b86248f3f09f6 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Min-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-Min-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]Reduce$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, $vectorteststype$::[[TEST]]Reduce, $vectorteststype$::[[TEST]]ReduceAll); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-op.template index 9bd17186aa6a6..b86248f3f09f6 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Reduction-op.template @@ -1,6 +1,6 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]Reduce$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertReductionArraysEquals(a, r, ra, + assertReductionArraysEquals(r, ra, a, $vectorteststype$::[[TEST]]Reduce, $vectorteststype$::[[TEST]]ReduceAll); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-Masked-op.template index d08ba62dba09f..e40018bbdfd29 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-Masked-op.template @@ -21,6 +21,6 @@ @Test(dataProvider = "scatterMaskedOpIndexProvider") static void [[TEST]][[TEST_TYPE]]$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, BiFunction fs, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]][[TEST_TYPE]]); + assertArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]][[TEST_TYPE]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-op.template index 2cfda9f730cff..db04500e3e7b6 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Scatter-op.template @@ -10,6 +10,6 @@ @Test(dataProvider = "$type$UnaryOpIndexProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa, BiFunction fs) { [[KERNEL]] - assertArraysEquals(a, b, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Shift-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Shift-Masked-op.template index 5787ea68e6828..608217c3571f9 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Shift-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Shift-Masked-op.template @@ -3,5 +3,5 @@ static void [[TEST]]$vectorteststype$Shift(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertShiftArraysEquals(a, b, r, mask, $vectorteststype$::[[TEST]]_unary); + assertShiftArraysEquals(r, a, b, mask, $vectorteststype$::[[TEST]]_unary); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Shift-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Shift-op.template index e958c459375cc..b225da4b22bbd 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Shift-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Shift-op.template @@ -5,5 +5,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$Shift(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertShiftArraysEquals(a, b, r, $vectorteststype$::[[TEST]]_unary); + assertShiftArraysEquals(r, a, b, $vectorteststype$::[[TEST]]_unary); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Single-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Single-op.template index 95ebdd12a6843..5c60e43c4ed5b 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Single-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Single-op.template @@ -8,5 +8,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEquals(a, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-Masked-bop.template b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-Masked-bop.template index bb4a5f41e28f2..08ef495038b6f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-Masked-bop.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-Masked-bop.template @@ -15,5 +15,5 @@ static void [[TEST]]$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, origin, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, origin, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-bop.template b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-bop.template index 51c9f4ec025dc..7382e86c0467f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-bop.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-bop.template @@ -14,5 +14,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$Binary(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertArraysEquals(a, b, r, origin, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, origin, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-op.template index 57357bbae2912..6ee07f388b9b8 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Slice-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Slice-op.template @@ -12,5 +12,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEquals(a, r, origin, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, origin, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-Masked-op.template index 6ea50407f9f29..2bd267d574ee7 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-Masked-op.template @@ -14,7 +14,7 @@ av.lanewise(VectorOperators.[[TEST]], bv, c[i], vmask).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, mask, $vectorteststype$::[[TEST]]); + assertBroadcastArraysEquals(r, a, b, c, mask, $vectorteststype$::[[TEST]]); } @Test(dataProvider = "$type$TernaryOpMaskProvider") @@ -33,5 +33,5 @@ av.lanewise(VectorOperators.[[TEST]], b[i], cv, vmask).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, mask, $vectorteststype$::[[TEST]]); + assertAltBroadcastArraysEquals(r, a, b, c, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-op.template index 7a64b4331c7d3..0815e57c50f62 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Broadcast-op.template @@ -10,7 +10,7 @@ $abstractvectortype$ bv = $abstractvectortype$.fromArray(SPECIES, b, i); av.lanewise(VectorOperators.[[TEST]], bv, c[i]).intoArray(r, i); } - assertBroadcastArraysEquals(a, b, c, r, $vectorteststype$::[[TEST]]); + assertBroadcastArraysEquals(r, a, b, c, $vectorteststype$::[[TEST]]); } @Test(dataProvider = "$type$TernaryOpProvider") @@ -25,5 +25,5 @@ $abstractvectortype$ cv = $abstractvectortype$.fromArray(SPECIES, c, i); av.lanewise(VectorOperators.[[TEST]], b[i], cv).intoArray(r, i); } - assertAltBroadcastArraysEquals(a, b, c, r, $vectorteststype$::[[TEST]]); + assertAltBroadcastArraysEquals(r, a, b, c, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-Masked-op.template index 5dc2d9c2c3809..706a39d616a7f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-Masked-op.template @@ -11,5 +11,5 @@ final int INVOC_COUNT = count; #end[double] [[KERNEL]] - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, $vectorteststype$::[[TEST]]); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-op.template index e828078db06c7..9c2fd9312b42b 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Double-Broadcast-op.template @@ -10,5 +10,5 @@ final int INVOC_COUNT = count; #end[double] [[KERNEL]] - assertDoubleBroadcastArraysEquals(a, b, c, r, $vectorteststype$::[[TEST]]); + assertDoubleBroadcastArraysEquals(r, a, b, c, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Masked-op.template index e852234fbde03..1b079e965d49f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-Masked-op.template @@ -11,5 +11,5 @@ final int INVOC_COUNT = count; #end[double] [[KERNEL]] - assertArraysEquals(a, b, c, r, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, c, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-op.template index d60d65b6ee260..386ceff6a341f 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Ternary-op.template @@ -10,5 +10,5 @@ final int INVOC_COUNT = count; #end[double] [[KERNEL]] - assertArraysEquals(a, b, c, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, c, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-Masked-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-Masked-op.template index c6a97475bca46..551d99d7c83b1 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-Masked-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-Masked-op.template @@ -3,5 +3,5 @@ static void [[TEST]]Masked$vectorteststype$(IntFunction<$type$[]> fa, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, r, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op-math.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op-math.template index 9f282f714765d..543ba9a77152b 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op-math.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op-math.template @@ -9,5 +9,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEqualsWithinOneUlp(a, r, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); + assertArraysEqualsWithinOneUlp(r, a, $vectorteststype$::[[TEST]], $vectorteststype$::strict[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op.template index fe7b6ef7bdd43..b662fe81c3590 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unary-op.template @@ -2,5 +2,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEquals(a, r, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-Masked-bop.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-Masked-bop.template index fbe1599694477..760a5393a1111 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-Masked-bop.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-Masked-bop.template @@ -38,5 +38,5 @@ static void [[TEST]]$vectorteststype$Masked(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb, IntFunction fm) { [[KERNEL]] - assertArraysEquals(a, b, r, origin, part, mask, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, origin, part, mask, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-bop.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-bop.template index b162bcfa9b859..e723cfd341c8b 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-bop.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-bop.template @@ -23,5 +23,5 @@ @Test(dataProvider = "$type$BinaryOpProvider") static void [[TEST]]$vectorteststype$Binary(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) { [[KERNEL]] - assertArraysEquals(a, b, r, origin, part, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, b, origin, part, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-op.template b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-op.template index 78cb4c07bb77a..60e7bba21b6f3 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-Unslice-op.template @@ -14,5 +14,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void [[TEST]]$vectorteststype$(IntFunction<$type$[]> fa) { [[KERNEL]] - assertArraysEquals(a, r, origin, $vectorteststype$::[[TEST]]); + assertArraysEquals(r, a, origin, $vectorteststype$::[[TEST]]); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-With-Op.template b/test/jdk/jdk/incubator/vector/templates/Unit-With-Op.template index fda74a19e35e1..cb44361c094a7 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-With-Op.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-With-Op.template @@ -2,5 +2,5 @@ @Test(dataProvider = "$type$UnaryOpProvider") static void with$vectorteststype$(IntFunction<$type$ []> fa) { [[KERNEL]] - assertInsertArraysEquals(a, r, ($type$)4, 0); + assertInsertArraysEquals(r, a, ($type$)4, 0); } diff --git a/test/jdk/jdk/incubator/vector/templates/Unit-header.template b/test/jdk/jdk/incubator/vector/templates/Unit-header.template index 656cd3c763127..d7c428fce1203 100644 --- a/test/jdk/jdk/incubator/vector/templates/Unit-header.template +++ b/test/jdk/jdk/incubator/vector/templates/Unit-header.template @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -97,7 +97,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$ apply($type$ a); } - static void assertArraysEquals($type$[] a, $type$[] r, FUnOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -112,7 +112,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$ a); } - static void assertArraysEquals($type$[] a, $type$[] r, FUnArrayOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, FUnArrayOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -122,13 +122,13 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a[i]); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } } - static void assertArraysEquals($type$[] a, $type$[] r, boolean[] mask, FUnOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, boolean[] mask, FUnOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -147,17 +147,17 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$ apply($type$[] a); } - static void assertReductionArraysEquals($type$[] a, $type$[] b, $type$ c, + static void assertReductionArraysEquals($type$[] r, $type$ rc, $type$[] a, FReductionOp f, FReductionAllOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -169,17 +169,17 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$ apply($type$[] a, boolean[] mask); } - static void assertReductionArraysEqualsMasked($type$[] a, $type$[] b, $type$ c, boolean[] mask, + static void assertReductionArraysEqualsMasked($type$[] r, $type$ rc, $type$[] a, boolean[] mask, FReductionMaskedOp f, FReductionAllMaskedOp fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } @@ -192,17 +192,17 @@ public class $vectorteststype$ extends AbstractVectorTest { long apply($type$[] a); } - static void assertReductionLongArraysEquals($type$[] a, long[] b, long c, + static void assertReductionLongArraysEquals(long[] r, long rc, $type$[] a, FReductionOpLong f, FReductionAllOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a)); + Assert.assertEquals(rc, fa.apply(a)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } @@ -214,17 +214,17 @@ public class $vectorteststype$ extends AbstractVectorTest { long apply($type$[] a, boolean[] mask); } - static void assertReductionLongArraysEqualsMasked($type$[] a, long[] b, long c, boolean[] mask, + static void assertReductionLongArraysEqualsMasked(long[] r, long rc, $type$[] a, boolean[] mask, FReductionMaskedOpLong f, FReductionAllMaskedOpLong fa) { int i = 0; try { - Assert.assertEquals(c, fa.apply(a, mask)); + Assert.assertEquals(rc, fa.apply(a, mask)); for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i, mask)); + Assert.assertEquals(r[i], f.apply(a, i, mask)); } } catch (AssertionError e) { - Assert.assertEquals(c, fa.apply(a, mask), "Final result is incorrect!"); - Assert.assertEquals(b[i], f.apply(a, i, mask), "at index #" + i); + Assert.assertEquals(rc, fa.apply(a, mask), "Final result is incorrect!"); + Assert.assertEquals(r[i], f.apply(a, i, mask), "at index #" + i); } } #end[!Long] @@ -233,37 +233,37 @@ public class $vectorteststype$ extends AbstractVectorTest { boolean apply(boolean[] a, int idx); } - static void assertReductionBoolArraysEquals(boolean[] a, boolean[] b, FBoolReductionOp f) { + static void assertReductionBoolArraysEquals(boolean[] r, boolean[] a, FBoolReductionOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { - Assert.assertEquals(b[i], f.apply(a, i)); + Assert.assertEquals(r[i], f.apply(a, i)); } } catch (AssertionError e) { - Assert.assertEquals(b[i], f.apply(a, i), "at index #" + i); + Assert.assertEquals(r[i], f.apply(a, i), "at index #" + i); } } - static void assertInsertArraysEquals($type$[] a, $type$[] b, $type$ element, int index) { + static void assertInsertArraysEquals($type$[] r, $type$[] a, $type$ element, int index) { int i = 0; try { for (; i < a.length; i += 1) { if(i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element); + Assert.assertEquals(r[i], element); } else { - Assert.assertEquals(b[i], a[i]); + Assert.assertEquals(r[i], a[i]); } } } catch (AssertionError e) { if (i%SPECIES.length() == index) { - Assert.assertEquals(b[i], element, "at index #" + i); + Assert.assertEquals(r[i], element, "at index #" + i); } else { - Assert.assertEquals(b[i], a[i], "at index #" + i); + Assert.assertEquals(r[i], a[i], "at index #" + i); } } } - static void assertRearrangeArraysEquals($type$[] a, $type$[] r, int[] order, int vector_len) { + static void assertRearrangeArraysEquals($type$[] r, $type$[] a, int[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -277,7 +277,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertSelectFromArraysEquals($type$[] a, $type$[] r, $type$[] order, int vector_len) { + static void assertSelectFromArraysEquals($type$[] r, $type$[] a, $type$[] order, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -291,7 +291,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertRearrangeArraysEquals($type$[] a, $type$[] r, int[] order, boolean[] mask, int vector_len) { + static void assertRearrangeArraysEquals($type$[] r, $type$[] a, int[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -311,7 +311,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertSelectFromArraysEquals($type$[] a, $type$[] r, $type$[] order, boolean[] mask, int vector_len) { + static void assertSelectFromArraysEquals($type$[] r, $type$[] a, $type$[] order, boolean[] mask, int vector_len) { int i = 0, j = 0; try { for (; i < a.length; i += vector_len) { @@ -331,7 +331,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEquals($type$[]a, $type$[]r) { + static void assertBroadcastArraysEquals($type$[] r, $type$[] a) { int i = 0; for (; i < a.length; i += SPECIES.length()) { int idx = i; @@ -360,7 +360,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, FBinOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -371,7 +371,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] r, FBinOp f) { + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -383,7 +383,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastLongArraysEquals($type$[] a, $type$[] b, $type$[] r, FBinOp f) { + static void assertBroadcastLongArraysEquals($type$[] r, $type$[] a, $type$[] b, FBinOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -395,11 +395,11 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinOp f) { - assertArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinOp f) { + assertArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinMaskOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -410,11 +410,11 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinOp f) { - assertBroadcastArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinOp f) { + assertBroadcastArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -428,11 +428,11 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastLongArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinOp f) { - assertBroadcastLongArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertBroadcastLongArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinOp f) { + assertBroadcastLongArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertBroadcastLongArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinMaskOp f) { + static void assertBroadcastLongArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -446,7 +446,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertShiftArraysEquals($type$[] a, $type$[] b, $type$[] r, FBinOp f) { + static void assertShiftArraysEquals($type$[] r, $type$[] a, $type$[] b, FBinOp f) { int i = 0; int j = 0; try { @@ -460,11 +460,11 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertShiftArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinOp f) { - assertShiftArraysEquals(a, b, r, mask, FBinMaskOp.lift(f)); + static void assertShiftArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinOp f) { + assertShiftArraysEquals(r, a, b, mask, FBinMaskOp.lift(f)); } - static void assertShiftArraysEquals($type$[] a, $type$[] b, $type$[] r, boolean[] mask, FBinMaskOp f) { + static void assertShiftArraysEquals($type$[] r, $type$[] a, $type$[] b, boolean[] mask, FBinMaskOp f) { int i = 0; int j = 0; try { @@ -490,7 +490,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, FTernOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -501,11 +501,11 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, FTernOp f) { - assertArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernOp f) { + assertArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, FTernMaskOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -517,7 +517,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, FTernOp f) { + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -530,7 +530,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertAltBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, FTernOp f) { + static void assertAltBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -543,12 +543,12 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernOp f) { - assertBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -564,12 +564,12 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertAltBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernOp f) { - assertAltBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertAltBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertAltBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertAltBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -585,7 +585,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertDoubleBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, FTernOp f) { + static void assertDoubleBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, FTernOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -600,12 +600,12 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertDoubleBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernOp f) { - assertDoubleBroadcastArraysEquals(a, b, c, r, mask, FTernMaskOp.lift(f)); + assertDoubleBroadcastArraysEquals(r, a, b, c, mask, FTernMaskOp.lift(f)); } - static void assertDoubleBroadcastArraysEquals($type$[] a, $type$[] b, $type$[] c, $type$[] r, boolean[] mask, + static void assertDoubleBroadcastArraysEquals($type$[] r, $type$[] a, $type$[] b, $type$[] c, boolean[] mask, FTernMaskOp f) { int i = 0; try { @@ -645,7 +645,7 @@ public class $vectorteststype$ extends AbstractVectorTest { return true; } - static void assertArraysEqualsWithinOneUlp($type$[] a, $type$[] r, FUnOp mathf, FUnOp strictmathf) { + static void assertArraysEqualsWithinOneUlp($type$[] r, $type$[] a, FUnOp mathf, FUnOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -659,7 +659,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEqualsWithinOneUlp($type$[] a, $type$[] b, $type$[] r, FBinOp mathf, FBinOp strictmathf) { + static void assertArraysEqualsWithinOneUlp($type$[] r, $type$[] a, $type$[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { // Check that result is within 1 ulp of strict math or equivalent to math implementation. @@ -673,7 +673,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertBroadcastArraysEqualsWithinOneUlp($type$[] a, $type$[] b, $type$[] r, + static void assertBroadcastArraysEqualsWithinOneUlp($type$[] r, $type$[] a, $type$[] b, FBinOp mathf, FBinOp strictmathf) { int i = 0; try { @@ -704,7 +704,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$ apply($type$[] a, int b); } - static void assertArraysEquals($type$[] a, $type$[] r, FBinArrayOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, FBinArrayOp f) { int i = 0; try { for (; i < a.length; i++) { @@ -719,7 +719,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, int ix, int[] b, int iy); } - static void assertArraysEquals($type$[] a, int[] b, $type$[] r, FGatherScatterOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, int[] b, FGatherScatterOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -746,7 +746,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] r, $type$[] a, int ix, boolean[] mask, int[] b, int iy); } - static void assertArraysEquals($type$[] a, int[] b, $type$[] r, boolean[] mask, FGatherMaskedOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, int[] b, boolean[] mask, FGatherMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -756,7 +756,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, i, mask, b, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -767,7 +767,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } } - static void assertArraysEquals($type$[] a, int[] b, $type$[] r, boolean[] mask, FScatterMaskedOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, int[] b, boolean[] mask, FScatterMaskedOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -777,7 +777,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(r, a, i, mask, b, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + ", a: " + Arrays.toString(Arrays.copyOfRange(a, i, i+SPECIES.length())) + ", b: " @@ -794,7 +794,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, int origin, int idx); } - static void assertArraysEquals($type$[] a, $type$[] r, int origin, FLaneOp f) { + static void assertArraysEquals($type$[] r, $type$[] a, int origin, FLaneOp f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -804,7 +804,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, origin, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i); } @@ -814,7 +814,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, $type$[] b, int origin, int idx); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, int origin, FLaneBop f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, int origin, FLaneBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -824,7 +824,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, b, origin, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -835,7 +835,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, $type$[] b, int origin, boolean[] mask, int idx); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, int origin, boolean[] mask, FLaneMaskedBop f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, int origin, boolean[] mask, FLaneMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -845,7 +845,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, b, origin, mask, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin); @@ -856,7 +856,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, $type$[] b, int origin, int part, int idx); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, int origin, int part, FLanePartBop f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, int origin, int part, FLanePartBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -866,7 +866,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, b, origin, part, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -878,7 +878,7 @@ public class $vectorteststype$ extends AbstractVectorTest { $type$[] apply($type$[] a, $type$[] b, int origin, int part, boolean[] mask, int idx); } - static void assertArraysEquals($type$[] a, $type$[] b, $type$[] r, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { + static void assertArraysEquals($type$[] r, $type$[] a, $type$[] b, int origin, int part, boolean[] mask, FLanePartMaskedBop f) { int i = 0; try { for (; i < a.length; i += SPECIES.length()) { @@ -888,7 +888,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } catch (AssertionError e) { $type$[] ref = f.apply(a, b, origin, part, mask, i); $type$[] res = Arrays.copyOfRange(r, i, i+SPECIES.length()); - Assert.assertEquals(ref, res, "(ref: " + Arrays.toString(ref) + Assert.assertEquals(res, ref, "(ref: " + Arrays.toString(ref) + ", res: " + Arrays.toString(res) + "), at index #" + i + ", at origin #" + origin @@ -934,7 +934,7 @@ public class $vectorteststype$ extends AbstractVectorTest { #end[!byteOrShort] #end[!Int] - static void assertArraysEquals($type$[] a, int[] r, int offs) { + static void assertArraysEquals(int[] r, $type$[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -984,7 +984,7 @@ public class $vectorteststype$ extends AbstractVectorTest { #end[!Long] #if[byte] - static void assertArraysEquals($type$[] a, $type$[] r, int offs) { + static void assertArraysEquals($type$[] r, $type$[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -996,7 +996,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } #end[byte] - static void assertArraysEquals($type$[] a, long[] r, int offs) { + static void assertArraysEquals(long[] r, $type$[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { @@ -1008,7 +1008,7 @@ public class $vectorteststype$ extends AbstractVectorTest { } #if[!Double] - static void assertArraysEquals($type$[] a, double[] r, int offs) { + static void assertArraysEquals(double[] r, $type$[] a, int offs) { int i = 0; try { for (; i < r.length; i++) { diff --git a/test/jdk/jdk/incubator/vector/templates/X-LoadStoreTest.java.template b/test/jdk/jdk/incubator/vector/templates/X-LoadStoreTest.java.template index 1b44e8fc7504b..5596ac33a2dd1 100644 --- a/test/jdk/jdk/incubator/vector/templates/X-LoadStoreTest.java.template +++ b/test/jdk/jdk/incubator/vector/templates/X-LoadStoreTest.java.template @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -84,48 +84,26 @@ public class $vectorteststype$ extends AbstractVectorTest { static final int BUFFER_SIZE = Integer.getInteger("jdk.incubator.vector.test.buffer-size", BUFFER_REPS * ($bits$ / 8)); - static void assertArraysEquals($type$[] a, $type$[] r, boolean[] mask) { + static void assertArraysEquals($type$[] r, $type$[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : ($type$) 0, r[i]); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : ($type$) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[i] : ($type$) 0, r[i], "at index #" + i); - } - } - - static void assertArraysEquals($type$[] a, $type$[] r, int[] im) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(a[im[i]], r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(a[im[i]], r[i], "at index #" + i); - } - } - - static void assertArraysEquals($type$[] a, $type$[] r, int[] im, boolean[] mask) { - int i = 0; - try { - for (; i < a.length; i++) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : ($type$) 0, r[i]); - } - } catch (AssertionError e) { - Assert.assertEquals(mask[i % SPECIES.length()] ? a[im[i]] : ($type$) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[i % SPECIES.length()] ? a[i] : ($type$) 0, "at index #" + i); } } #if[!byte] - static void assertArraysEquals(byte[] a, byte[] r, boolean[] mask) { + static void assertArraysEquals(byte[] r, byte[] a, boolean[] mask) { int i = 0; try { for (; i < a.length; i++) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i]); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0); } } catch (AssertionError e) { - Assert.assertEquals(mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, r[i], "at index #" + i); + Assert.assertEquals(r[i], mask[(i*8/SPECIES.elementSize()) % SPECIES.length()] ? a[i] : (byte) 0, "at index #" + i); } } #end[!byte] @@ -433,7 +411,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test(dataProvider = "$type$ProviderForIOOBE") @@ -504,7 +482,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoArray(r, i); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new $type$[a.length]; @@ -515,7 +493,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoArray(r, i, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "$type$MaskProviderForIOOBE") @@ -588,7 +566,7 @@ public class $vectorteststype$ extends AbstractVectorTest { vmask.intoArray(r, i); } } - Assert.assertEquals(mask, r); + Assert.assertEquals(r, mask); } @@ -612,7 +590,7 @@ public class $vectorteststype$ extends AbstractVectorTest { Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - Assert.assertEquals(a, r, "Buffers not equal"); + Assert.assertEquals(r, a, "Buffers not equal"); } @Test(dataProvider = "$type$ByteProviderForIOOBE") @@ -699,7 +677,7 @@ public class $vectorteststype$ extends AbstractVectorTest { Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); r = fb.apply(a.limit()); @@ -714,7 +692,7 @@ public class $vectorteststype$ extends AbstractVectorTest { Assert.assertEquals(a.limit(), l, "Input buffer limit changed"); Assert.assertEquals(r.position(), 0, "Result buffer position changed"); Assert.assertEquals(r.limit(), l, "Result buffer limit changed"); - assertArraysEquals(_a, bufferToArray(r), mask); + assertArraysEquals(bufferToArray(r), _a, mask); } @Test(dataProvider = "$type$ByteMaskProviderForIOOBE") @@ -830,7 +808,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoByteArray(r, i, bo); } } - Assert.assertEquals(a, r, "Byte arrays not equal"); + Assert.assertEquals(r, a, "Byte arrays not equal"); } @Test(dataProvider = "$type$ByteProviderForIOOBE") @@ -911,7 +889,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoByteArray(r, i, bo); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); r = new byte[a.length]; @@ -922,7 +900,7 @@ public class $vectorteststype$ extends AbstractVectorTest { av.intoByteArray(r, i, bo, vmask); } } - assertArraysEquals(a, r, mask); + assertArraysEquals(r, a, mask); } @Test(dataProvider = "$type$ByteMaskProviderForIOOBE") @@ -999,7 +977,7 @@ public class $vectorteststype$ extends AbstractVectorTest { vmask.intoArray(r, i); } } - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } @Test @@ -1010,7 +988,7 @@ public class $vectorteststype$ extends AbstractVectorTest { int [] r = shuffle.toArray(); int [] a = expectedShuffle(SPECIES.length(), fn); - Assert.assertEquals(a, r); + Assert.assertEquals(r, a); } } } From 554e60c400746746bb55469e61fad84af365dbf5 Mon Sep 17 00:00:00 2001 From: Wang Huang Date: Wed, 6 Jan 2021 01:49:15 +0000 Subject: [PATCH 034/129] 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert Co-authored-by: He Xuejin Reviewed-by: vlivanov, thartmann --- src/hotspot/share/opto/vectorIntrinsics.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hotspot/share/opto/vectorIntrinsics.cpp b/src/hotspot/share/opto/vectorIntrinsics.cpp index 07036d2ca7b7e..bf6db23e1b9eb 100644 --- a/src/hotspot/share/opto/vectorIntrinsics.cpp +++ b/src/hotspot/share/opto/vectorIntrinsics.cpp @@ -1435,7 +1435,7 @@ bool LibraryCallKit::inline_vector_convert() { } else if (num_elem_from > num_elem_to) { // Since number elements from input is larger than output, simply reduce size of input (we are supposed to // drop top elements anyway). - int num_elem_for_resize = MAX2(num_elem_to, Matcher::min_vector_size(elem_bt_to)); + int num_elem_for_resize = MAX2(num_elem_to, Matcher::min_vector_size(elem_bt_from)); // It is possible that arch does not support this intermediate vector size // TODO More complex logic required here to handle this corner case for the sizes. From 80110dac91767b01de35c583af7b370a36a03c18 Mon Sep 17 00:00:00 2001 From: Prasanta Sadhukhan Date: Wed, 6 Jan 2021 06:36:29 +0000 Subject: [PATCH 035/129] 8259007: This test printed a blank page Reviewed-by: prr, serb --- .../sun/awt/windows/WPathGraphics.java | 4 +- .../classes/sun/awt/windows/WPrinterJob.java | 118 +------- .../native/libawt/windows/awt_PrintJob.cpp | 105 -------- .../PathPrecisionScaleFactorTest.java | 254 ------------------ 4 files changed, 11 insertions(+), 470 deletions(-) delete mode 100644 test/jdk/java/awt/print/PathPrecisionScaleFactor/PathPrecisionScaleFactorTest.java diff --git a/src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java b/src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java index d642f73143383..6de773eb52e42 100644 --- a/src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java +++ b/src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java @@ -1760,8 +1760,8 @@ private void convertToWPath(PathIterator pathIter) { /* Convert the quad path to a bezier. */ case PathIterator.SEG_QUADTO: - float lastX = wPrinterJob.getPenX(); - float lastY = wPrinterJob.getPenY(); + int lastX = wPrinterJob.getPenX(); + int lastY = wPrinterJob.getPenY(); float c1x = lastX + (segment[0] - lastX) * 2 / 3; float c1y = lastY + (segment[1] - lastY) * 2 / 3; float c2x = segment[2] - (segment[2] - segment[0]) * 2/ 3; diff --git a/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java b/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java index 403f960ffe730..c0f5bba3d210a 100644 --- a/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java +++ b/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java @@ -362,10 +362,6 @@ public void dispose() { private java.awt.peer.ComponentPeer dialogOwnerPeer = null; - private static final float precisionScale = 1000.0f; - private int graphicsMode; - private double[] worldTransform = new double[6]; - /* Static Initializations */ static { @@ -957,33 +953,11 @@ private void setDevNames(long mPrintHDevNames) { } protected void beginPath() { - precisionScaleBegin(); beginPath(getPrintDC()); } protected void endPath() { endPath(getPrintDC()); - precisionScaleEnd(); - } - - protected float precisionScaleUp(float value) { - return value * precisionScale; - } - - protected float precisionScaleDown(float value) { - return value / precisionScale; - } - - protected void precisionScaleBegin() { - graphicsMode = setAdvancedGraphicsMode(); - getWorldTransform(worldTransform); - float invPrecisionScale = 1.0f / precisionScale; - scale(invPrecisionScale, invPrecisionScale); - } - - protected void precisionScaleEnd() { - setWorldTransform(worldTransform); - setGraphicsMode(graphicsMode); } protected void closeFigure() { @@ -995,23 +969,20 @@ protected void fillPath() { } protected void moveTo(float x, float y) { - moveTo(getPrintDC(), - precisionScaleUp(x), precisionScaleUp(y)); + moveTo(getPrintDC(), x, y); } protected void lineTo(float x, float y) { - lineTo(getPrintDC(), - precisionScaleUp(x), precisionScaleUp(y)); + lineTo(getPrintDC(), x, y); } protected void polyBezierTo(float control1x, float control1y, float control2x, float control2y, float endX, float endY) { - polyBezierTo(getPrintDC(), - precisionScaleUp(control1x), precisionScaleUp(control1y), - precisionScaleUp(control2x), precisionScaleUp(control2y), - precisionScaleUp(endX), precisionScaleUp(endY)); + polyBezierTo(getPrintDC(), control1x, control1y, + control2x, control2y, + endX, endY); } /** @@ -1024,44 +995,6 @@ protected void setPolyFillMode(int fillRule) { setPolyFillMode(getPrintDC(), fillRule); } - /** - * Set the GDI graphics mode to {@code GM_ADVANCED}. - */ - private int setAdvancedGraphicsMode() { - return setAdvancedGraphicsMode(getPrintDC()); - } - - /** - * Set the GDI graphics mode. - * The {@code mode} should - * be one of the following Windows constants: - * {@code GM_COMPATIBLE} or {@code GM_ADVANCED}. - */ - private int setGraphicsMode(int mode) { - return setGraphicsMode(getPrintDC(), mode); - } - - /** - * Scale the GDI World Transform. - */ - private void scale(double scaleX, double scaleY) { - scale(getPrintDC(), scaleX, scaleY); - } - - /** - * Get the GDI World Transform. - */ - private void getWorldTransform(double[] transform) { - getWorldTransform(getPrintDC(), transform); - } - - /** - * Set the GDI World Transform. - */ - private void setWorldTransform(double[] transform) { - setWorldTransform(getPrintDC(), transform); - } - /* * Create a Window's solid brush for the color specified * by {@code (red, green, blue)}. Once the brush @@ -1087,9 +1020,9 @@ protected void selectSolidBrush(Color color) { * Return the x coordinate of the current pen * position in the print device context. */ - protected float getPenX() { + protected int getPenX() { - return precisionScaleDown(getPenX(getPrintDC())); + return getPenX(getPrintDC()); } @@ -1097,9 +1030,9 @@ protected float getPenX() { * Return the y coordinate of the current pen * position in the print device context. */ - protected float getPenY() { + protected int getPenY() { - return precisionScaleDown(getPenY(getPrintDC())); + return getPenY(getPrintDC()); } /** @@ -1537,39 +1470,6 @@ protected native void polyBezierTo(long printDC, */ protected native void setPolyFillMode(long printDC, int fillRule); - /** - * Set the GDI graphics mode to {@code GM_ADVANCED} - * into the device context {@code printDC}. - */ - protected native int setAdvancedGraphicsMode(long printDC); - - /** - * Set the GDI graphics mode to {@code GM_ADVANCED} - * into the device context {@code printDC}. - * The {@code mode} should - * be one of the following Windows constants: - * {@code GM_COMPATIBLE} or {@code GM_ADVANCED}. - */ - protected native int setGraphicsMode(long printDC, int mode); - - /** - * Scale the GDI World Transform - * of the device context {@code printDC}. - */ - protected native void scale(long printDC, double scaleX, double scaleY); - - /** - * Get the GDI World Transform - * from the device context {@code printDC}. - */ - protected native void getWorldTransform(long printDC, double[] transform); - - /** - * Set the GDI World Transform - * into the device context {@code printDC}. - */ - protected native void setWorldTransform(long printDC, double[] transform); - /** * Create a Window's solid brush for the color specified * by {@code (red, green, blue)}. Once the brush diff --git a/src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp b/src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp index 925000c256b0e..618ae9e1a827a 100644 --- a/src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp +++ b/src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp @@ -1932,111 +1932,6 @@ JNIEXPORT void JNICALL Java_sun_awt_windows_WPrinterJob_setPolyFillMode CATCH_BAD_ALLOC; } -/* - * Class: sun_awt_windows_WPrinterJob - * Method: setAdvancedGraphicsMode - * Signature: (J)I - */ -JNIEXPORT jint JNICALL Java_sun_awt_windows_WPrinterJob_setAdvancedGraphicsMode -(JNIEnv *env, jobject self, jlong printDC) { - TRY; - - return (jint) ::SetGraphicsMode((HDC)printDC, GM_ADVANCED); - - CATCH_BAD_ALLOC_RET(0); -} - -/* - * Class: sun_awt_windows_WPrinterJob - * Method: setGraphicsMode - * Signature: (JI)I - */ -JNIEXPORT jint JNICALL Java_sun_awt_windows_WPrinterJob_setGraphicsMode -(JNIEnv *env, jobject self, jlong printDC, jint mode) { - TRY; - - return (jint) ::SetGraphicsMode((HDC)printDC, mode); - - CATCH_BAD_ALLOC_RET(0); -} - -/* - * Class: sun_awt_windows_WPrinterJob - * Method: scale - * Signature: (JDD)V - */ -JNIEXPORT void JNICALL Java_sun_awt_windows_WPrinterJob_scale -(JNIEnv *env, jobject self, jlong printDC, jdouble scaleX, jdouble scaleY) { - TRY; - - XFORM xForm; - - xForm.eM11 = (FLOAT) scaleX; - xForm.eM12 = (FLOAT) 0; - xForm.eM21 = (FLOAT) 0; - xForm.eM22 = (FLOAT) scaleY; - xForm.eDx = (FLOAT) 0; - xForm.eDy = (FLOAT) 0; - - ::ModifyWorldTransform((HDC)printDC, &xForm, MWT_RIGHTMULTIPLY); - - CATCH_BAD_ALLOC; -} - -/* - * Class: sun_awt_windows_WPrinterJob - * Method: getWorldTransform - * Signature: (J[D)V - */ -JNIEXPORT void JNICALL Java_sun_awt_windows_WPrinterJob_getWorldTransform -(JNIEnv* env, jobject self, jlong printDC, jdoubleArray transform) { - TRY; - - double elems[6]; - XFORM xForm; - - ::GetWorldTransform((HDC)printDC, &xForm); - - elems[0] = (double) xForm.eM11; - elems[1] = (double) xForm.eM12; - elems[2] = (double) xForm.eM21; - elems[3] = (double) xForm.eM22; - elems[4] = (double) xForm.eDx; - elems[5] = (double) xForm.eDy; - - env->SetDoubleArrayRegion(transform, 0, 6, elems); - - CATCH_BAD_ALLOC; -} - -/* - * Class: sun_awt_windows_WPrinterJob - * Method: setWorldTransform - * Signature: (J[D)V - */ -JNIEXPORT void JNICALL Java_sun_awt_windows_WPrinterJob_setWorldTransform -(JNIEnv* env, jobject self, jlong printDC, jdoubleArray transform) { - TRY; - - double *elems; - XFORM xForm; - - elems = env->GetDoubleArrayElements(transform, 0); - - xForm.eM11 = (FLOAT) elems[0]; - xForm.eM12 = (FLOAT) elems[1]; - xForm.eM21 = (FLOAT) elems[2]; - xForm.eM22 = (FLOAT) elems[3]; - xForm.eDx = (FLOAT) elems[4]; - xForm.eDy = (FLOAT) elems[5]; - - ::SetWorldTransform((HDC)printDC, &xForm); - - env->ReleaseDoubleArrayElements(transform, elems, 0); - - CATCH_BAD_ALLOC; -} - /* * Class: sun_awt_windows_WPrinterJob * Method: selectSolidBrush diff --git a/test/jdk/java/awt/print/PathPrecisionScaleFactor/PathPrecisionScaleFactorTest.java b/test/jdk/java/awt/print/PathPrecisionScaleFactor/PathPrecisionScaleFactorTest.java deleted file mode 100644 index 2bf2e8e391ec2..0000000000000 --- a/test/jdk/java/awt/print/PathPrecisionScaleFactor/PathPrecisionScaleFactorTest.java +++ /dev/null @@ -1,254 +0,0 @@ -/* - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. - * Copyright (c) 2020, BELLSOFT. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test - * @bug 8256264 - * @requires (os.family == "windows") - * @summary Check that a GlyphVector outline is printed with good quility on low dpi printers - * @run main/othervm/manual PathPrecisionScaleFactorTest - */ - -import javax.print.PrintServiceLookup; -import javax.swing.*; -import java.awt.*; -import java.awt.event.WindowAdapter; -import java.awt.event.WindowEvent; -import java.awt.font.FontRenderContext; -import java.awt.font.GlyphVector; -import java.awt.geom.AffineTransform; -import java.awt.geom.Rectangle2D; -import java.awt.print.PageFormat; -import java.awt.print.Printable; -import java.awt.print.PrinterException; -import java.awt.print.PrinterJob; -import java.util.concurrent.CountDownLatch; -import java.util.concurrent.TimeUnit; - -public class PathPrecisionScaleFactorTest { - - private static final String DESCRIPTION = - " 1. Setup 'Microsoft Print to PDF' printer on Windows.\n" + - " 2. Press Print button to print the text to PDF.\n" + - " 3. Choose 'Microsoft Print to PDF' on the print dialog and press OK\n" + - " Two strings should be printed." + - " The first line is printed using drawString() method" + - " and the second line is printed using filling glyph vector outline.\n" + - " 3. Open the PDF file, zoom in the text and check that chars on the second line " + - " (especially 'a' and 's') are not distorted and have the similar quality" + - " as on the first line.\n" + - " 4. If so, press PASS button, otherwise press FAIL button.\n"; - - private static final CountDownLatch testEndedSignal = new CountDownLatch(1); - private static final int testTimeout = 300000; - private static volatile String testFailureMsg; - private static volatile boolean testPassed; - private static volatile boolean testFinished; - - public static void main(String[] args) throws Exception { - - SwingUtilities.invokeLater(() -> createAndShowTestDialog()); - - try { - if (!testEndedSignal.await(testTimeout, TimeUnit.MILLISECONDS)) { - throw new RuntimeException(String.format( - "Test timeout '%d ms' elapsed.", testTimeout)); - } - if (!testPassed) { - String failureMsg = testFailureMsg; - if ((failureMsg != null) && (!failureMsg.trim().isEmpty())) { - throw new RuntimeException(failureMsg); - } else { - throw new RuntimeException("Test failed."); - } - } - } catch (InterruptedException ie) { - throw new RuntimeException(ie); - } finally { - testFinished = true; - } - } - - private static void pass() { - testPassed = true; - testEndedSignal.countDown(); - } - - private static void fail(String failureMsg) { - testFailureMsg = failureMsg; - testPassed = false; - testEndedSignal.countDown(); - } - - private static String convertMillisToTimeStr(int millis) { - if (millis < 0) { - return "00:00:00"; - } - int hours = millis / 3600000; - int minutes = (millis - hours * 3600000) / 60000; - int seconds = (millis - hours * 3600000 - minutes * 60000) / 1000; - return String.format("%02d:%02d:%02d", hours, minutes, seconds); - } - - private static void createAndShowTestDialog() { - - final JDialog dialog = new JDialog(); - dialog.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); - dialog.addWindowListener(new WindowAdapter() { - @Override - public void windowClosing(WindowEvent e) { - dialog.dispose(); - fail("Main dialog was closed."); - } - }); - - final JLabel testTimeoutLabel = new JLabel(String.format( - "Test timeout: %s", convertMillisToTimeStr(testTimeout))); - final long startTime = System.currentTimeMillis(); - final Timer timer = new Timer(0, null); - timer.setDelay(1000); - timer.addActionListener((e) -> { - int leftTime = testTimeout - (int) (System.currentTimeMillis() - startTime); - if ((leftTime < 0) || testFinished) { - timer.stop(); - dialog.dispose(); - } - testTimeoutLabel.setText(String.format( - "Test timeout: %s", convertMillisToTimeStr(leftTime))); - }); - timer.start(); - - JTextArea textArea = new JTextArea(DESCRIPTION); - textArea.setEditable(false); - - final JButton testButton = new JButton("Print"); - final JButton passButton = new JButton("PASS"); - final JButton failButton = new JButton("FAIL"); - testButton.addActionListener((e) -> { - testButton.setEnabled(false); - new Thread(() -> { - try { - doTest(); - - SwingUtilities.invokeLater(() -> { - passButton.setEnabled(true); - failButton.setEnabled(true); - }); - } catch (Throwable t) { - t.printStackTrace(); - dialog.dispose(); - fail("Exception occurred in a thread executing the test."); - } - }).start(); - }); - passButton.setEnabled(false); - passButton.addActionListener((e) -> { - dialog.dispose(); - pass(); - }); - failButton.setEnabled(false); - failButton.addActionListener((e) -> { - dialog.dispose(); - fail("TitledBorder label is cut off"); - }); - - JPanel mainPanel = new JPanel(new BorderLayout()); - JPanel labelPanel = new JPanel(new FlowLayout()); - labelPanel.add(testTimeoutLabel); - mainPanel.add(labelPanel, BorderLayout.NORTH); - mainPanel.add(textArea, BorderLayout.CENTER); - JPanel buttonPanel = new JPanel(new FlowLayout()); - buttonPanel.add(testButton); - buttonPanel.add(passButton); - buttonPanel.add(failButton); - mainPanel.add(buttonPanel, BorderLayout.SOUTH); - dialog.add(mainPanel); - - dialog.pack(); - dialog.setVisible(true); - } - - private static void doTest() throws Exception { - SwingUtilities.invokeAndWait(() -> { - try { - new PathPrecisionScaleFactorPrintable(); - } catch (PrinterException e) { - throw new RuntimeException(e); - } - }); - } - - private static class PathPrecisionScaleFactorPrintable implements Printable { - - PathPrecisionScaleFactorPrintable() throws PrinterException { - PrinterJob job = PrinterJob.getPrinterJob(); - job.setPrintService(PrintServiceLookup.lookupDefaultPrintService()); - job.setPrintable(this); - - if (job.printDialog()) { - job.print(); - } else { - throw new RuntimeException("Printing was canceled!"); - } - } - - void paint(Graphics2D g) { - - String text = "abcdefghijklmnopqrstuvwxyz"; - Font font = new Font("Times New Roman", Font.PLAIN, 8); - drawText(g, font, text); - } - - private static void drawText(Graphics2D g, Font font, String text) { - - g.setFont(font); - FontRenderContext frc = new FontRenderContext(new AffineTransform(), false, true); - - Rectangle clip = g.getClipBounds(); - int cx = (int) clip.getCenterX(); - int cy = (int) clip.getCenterY(); - - FontMetrics metrics = g.getFontMetrics(); - int w = metrics.stringWidth(text); - int h = metrics.getHeight(); - - int x = cx - w / 2; - int y = cy - h / 2; - - g.drawString(text + " [draw string]", x, y); - GlyphVector gv = font.createGlyphVector(frc, text + " [glyph vector]"); - g.fill(gv.getOutline(x, y + h)); - } - - @Override - public int print(Graphics graphics, PageFormat pageFormat, int index) { - if (index == 0) { - paint((Graphics2D) graphics); - return PAGE_EXISTS; - } else { - return NO_SUCH_PAGE; - } - } - } -} From 32538b5b1d403b5d6b0e48bceef97a47cf9ddbe7 Mon Sep 17 00:00:00 2001 From: Prasanta Sadhukhan Date: Wed, 6 Jan 2021 06:45:48 +0000 Subject: [PATCH 036/129] 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails Reviewed-by: serb --- test/jdk/ProblemList.txt | 1 - .../swing/JFrame/8175301/ScaledFrameBackgroundTest.java | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt index 269b7162070a4..bb51afe42a133 100644 --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -740,7 +740,6 @@ javax/swing/JTree/4633594/JTreeFocusTest.java 8173125 macosx-all javax/swing/AbstractButton/6711682/bug6711682.java 8060765 windows-all,macosx-all javax/swing/JFileChooser/4524490/bug4524490.java 8042380 generic-all javax/swing/JFileChooser/6396844/TwentyThousandTest.java 8198003 generic-all -javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java 8193942 generic-all javax/swing/JPopupMenu/6580930/bug6580930.java 7124313 macosx-all javax/swing/JPopupMenu/6800513/bug6800513.java 7184956 macosx-all javax/swing/JTabbedPane/8007563/Test8007563.java 8051591 generic-all diff --git a/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java b/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java index 1eb664130e38e..806f247a3ea0a 100644 --- a/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java +++ b/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java @@ -44,7 +44,7 @@ public class ScaledFrameBackgroundTest { public static void main(String[] args) throws Exception { try { Robot robot = new Robot(); - robot.setAutoDelay(50); + robot.setAutoDelay(100); SwingUtilities.invokeAndWait(() -> { frame = new JFrame(); @@ -54,10 +54,11 @@ public static void main(String[] args) throws Exception { panel.setBackground(BACKGROUND); frame.getContentPane().add(panel); frame.setVisible(true); + frame.setLocationRelativeTo(null); }); robot.waitForIdle(); - Thread.sleep(200); + robot.delay(1000); Rectangle[] rects = new Rectangle[1]; SwingUtilities.invokeAndWait(() -> { @@ -81,7 +82,7 @@ public static void main(String[] args) throws Exception { color = robot.getPixelColor(x, y); if (!BACKGROUND.equals(color)) { - throw new RuntimeException("Wrong backgound color!"); + throw new RuntimeException("Wrong backgound color!!"); } } finally { if (frame != null) SwingUtilities.invokeAndWait(() -> frame.dispose()); From e3b9da145645d10e10fa6d8c21590899a342cfc9 Mon Sep 17 00:00:00 2001 From: Xin Liu Date: Wed, 6 Jan 2021 09:51:18 +0000 Subject: [PATCH 037/129] 8259287: AbstractCompiler marks const in wrong position for is_c1/is_c2/is_jvmci Reviewed-by: thartmann, chagedorn, shade --- src/hotspot/share/compiler/abstractCompiler.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hotspot/share/compiler/abstractCompiler.hpp b/src/hotspot/share/compiler/abstractCompiler.hpp index f3ed18ec39731..5d900de39ba67 100644 --- a/src/hotspot/share/compiler/abstractCompiler.hpp +++ b/src/hotspot/share/compiler/abstractCompiler.hpp @@ -149,10 +149,10 @@ class AbstractCompiler : public CHeapObj { } // Compiler type queries. - const bool is_c1() { return _type == compiler_c1; } - const bool is_c2() { return _type == compiler_c2; } - const bool is_jvmci() { return _type == compiler_jvmci; } - const CompilerType type() { return _type; } + bool is_c1() const { return _type == compiler_c1; } + bool is_c2() const { return _type == compiler_c2; } + bool is_jvmci() const { return _type == compiler_jvmci; } + CompilerType type() const { return _type; } // Customization virtual void initialize () = 0; From 8a05d6053211549d15ba469a18b497a3f8ec2b8c Mon Sep 17 00:00:00 2001 From: Sergey Bylokhov Date: Wed, 6 Jan 2021 10:07:03 +0000 Subject: [PATCH 038/129] 8259042: Inconsistent use of general primitives loops Reviewed-by: prr --- .../share/classes/sun/java2d/loops/Blit.java | 10 ++--- .../classes/sun/java2d/loops/BlitBg.java | 19 ++++----- .../sun/java2d/loops/DrawGlyphList.java | 13 +++--- .../sun/java2d/loops/DrawGlyphListAA.java | 13 +++--- .../sun/java2d/loops/DrawGlyphListLCD.java | 22 +--------- .../classes/sun/java2d/loops/DrawLine.java | 12 +----- .../sun/java2d/loops/DrawParallelogram.java | 12 +----- .../classes/sun/java2d/loops/DrawPath.java | 14 ++----- .../sun/java2d/loops/DrawPolygons.java | 12 +----- .../classes/sun/java2d/loops/DrawRect.java | 12 +----- .../sun/java2d/loops/FillParallelogram.java | 12 +----- .../classes/sun/java2d/loops/FillPath.java | 14 ++----- .../classes/sun/java2d/loops/FillRect.java | 9 ++-- .../classes/sun/java2d/loops/FillSpans.java | 14 +------ .../sun/java2d/loops/GraphicsPrimitive.java | 42 +++++++++++-------- .../java2d/loops/GraphicsPrimitiveMgr.java | 6 +++ .../java2d/loops/GraphicsPrimitiveProxy.java | 9 +--- .../classes/sun/java2d/loops/MaskBlit.java | 10 ++--- .../classes/sun/java2d/loops/MaskFill.java | 10 ++--- .../classes/sun/java2d/loops/ScaledBlit.java | 21 +--------- .../sun/java2d/loops/TransformBlit.java | 23 +--------- .../sun/java2d/loops/TransformHelper.java | 11 +---- 22 files changed, 93 insertions(+), 227 deletions(-) diff --git a/src/java.desktop/share/classes/sun/java2d/loops/Blit.java b/src/java.desktop/share/classes/sun/java2d/loops/Blit.java index 516c162f30352..0d3a4ac4f2455 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/Blit.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/Blit.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -32,7 +32,7 @@ import java.awt.image.Raster; import java.awt.image.WritableRaster; import java.lang.ref.WeakReference; -import sun.java2d.loops.GraphicsPrimitive; + import sun.java2d.SurfaceData; import sun.java2d.pipe.Region; import sun.java2d.pipe.SpanIterator; @@ -114,9 +114,9 @@ public native void Blit(SurfaceData src, SurfaceData dst, GraphicsPrimitiveMgr.registerGeneral(new Blit(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { /* System.out.println("Constructing general blit for:"); diff --git a/src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java b/src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java index 427850aef5831..ffe5901a57dc8 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2008, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,18 +25,17 @@ package sun.java2d.loops; -import java.awt.Font; +import java.awt.AlphaComposite; import java.awt.Color; import java.awt.Composite; -import java.awt.AlphaComposite; -import java.awt.Transparency; +import java.awt.Font; +import java.awt.image.BufferedImage; import java.awt.image.ColorModel; import java.awt.image.WritableRaster; -import java.awt.image.BufferedImage; + import sun.awt.image.BufImgSurfaceData; -import sun.java2d.loops.GraphicsPrimitive; -import sun.java2d.SurfaceData; import sun.java2d.SunGraphics2D; +import sun.java2d.SurfaceData; import sun.java2d.pipe.Region; /** @@ -118,9 +117,9 @@ public native void BlitBg(SurfaceData src, SurfaceData dst, GraphicsPrimitiveMgr.registerGeneral(new BlitBg(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { /* System.out.println("Constructing general blitbg for:"); diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphList.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphList.java index e711b549b1fe9..42a1c947c3ac1 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphList.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphList.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,11 +25,10 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; -import sun.java2d.pipe.Region; +import sun.font.GlyphList; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; -import sun.font.GlyphList; +import sun.java2d.pipe.Region; /** * DrawGlyphList - loops for SolidTextRenderer pipe. @@ -77,9 +76,9 @@ public native void DrawGlyphList(SunGraphics2D sg2d, SurfaceData dest, new DrawGlyphList(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) { + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { return new General(srctype, comptype, dsttype); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java index ee22d1e45839e..9aa2fcbb26635 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,11 +25,10 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; -import sun.java2d.pipe.Region; +import sun.font.GlyphList; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; -import sun.font.GlyphList; +import sun.java2d.pipe.Region; /** * DrawGlyphListAA - loops for AATextRenderer pipe @@ -75,9 +74,9 @@ public native void DrawGlyphListAA(SunGraphics2D sg2d, SurfaceData dest, new DrawGlyphListAA(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) { + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { return new General(srctype, comptype, dsttype); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java index 89ed93ad59ba3..ac4dd7957ca32 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,10 +25,9 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; +import sun.font.GlyphList; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; -import sun.font.GlyphList; /** * DrawGlyphListLCD- loops for LCDTextRenderer pipe @@ -71,23 +70,6 @@ public DrawGlyphListLCD(long pNativePrim, public native void DrawGlyphListLCD(SunGraphics2D sg2d, SurfaceData dest, GlyphList srcData); - static { - GraphicsPrimitiveMgr.registerGeneral( - new DrawGlyphListLCD(null, null, null)); - } - - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) { - /* Do not return a General loop. SunGraphics2D determines whether - * to use LCD or standard AA text based on whether there is an - * installed loop. - * This can be uncommented once there is a General loop which can - * handle one byte per colour component masks properly. - */ - return null; - } - public GraphicsPrimitive traceWrap() { return new TraceDrawGlyphListLCD(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java index 684f2422a7176..8a47b36936d2a 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -74,15 +73,6 @@ public DrawLine(long pNativePrim, public native void DrawLine(SunGraphics2D sg2d, SurfaceData dest, int x1, int y1, int x2, int y2); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: use FillSpans or converter object? - throw new InternalError("DrawLine not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceDrawLine(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawParallelogram.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawParallelogram.java index 6d16e06794320..ca5899a06959b 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawParallelogram.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawParallelogram.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -82,15 +81,6 @@ public native void DrawParallelogram(SunGraphics2D sg, SurfaceData dest, double dx2, double dy2, double lw1, double lw2); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: iterate with a FillRect primitive? - throw new InternalError("DrawParallelogram not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceDrawParallelogram(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawPath.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawPath.java index 571a01a91f87c..192ea9277e647 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawPath.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawPath.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2006, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,10 +25,10 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; +import java.awt.geom.Path2D; + import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; -import java.awt.geom.Path2D; /** * DrawPath @@ -77,14 +77,6 @@ public native void DrawPath(SunGraphics2D sg2d, SurfaceData sData, int transX, int transY, Path2D.Float p2df); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - throw new InternalError("DrawPath not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceDrawPath(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawPolygons.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawPolygons.java index 54e12ed9a4ad9..577637c3dd2f7 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawPolygons.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawPolygons.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -78,15 +77,6 @@ public native void DrawPolygons(SunGraphics2D sg2d, SurfaceData sData, int transX, int transY, boolean close); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: use FillSpans or converter object? - throw new InternalError("DrawPolygons not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceDrawPolygons(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/DrawRect.java b/src/java.desktop/share/classes/sun/java2d/loops/DrawRect.java index 8dcf16edf06f4..67d275607dfc8 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/DrawRect.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/DrawRect.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -75,15 +74,6 @@ public DrawRect(long pNativePrim, public native void DrawRect(SunGraphics2D sg2d, SurfaceData dest, int x1, int y1, int w, int h); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: use FillSpans or converter object? - throw new InternalError("DrawRect not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceDrawRect(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java b/src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java index b895c0b8737de..a216fa4035664 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -79,15 +78,6 @@ public native void FillParallelogram(SunGraphics2D sg2d, SurfaceData dest, double dx1, double dy1, double dx2, double dy2); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: iterate with a FillRect primitive? - throw new InternalError("FillParallelogram not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceFillParallelogram(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/FillPath.java b/src/java.desktop/share/classes/sun/java2d/loops/FillPath.java index 524240ed4d1ae..93dea16de59af 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/FillPath.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/FillPath.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2005, 2006, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,10 +25,10 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; +import java.awt.geom.Path2D; + import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; -import java.awt.geom.Path2D; /** * FillPath @@ -77,14 +77,6 @@ public native void FillPath(SunGraphics2D sg2d, SurfaceData sData, int transX, int transY, Path2D.Float p2df); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - throw new InternalError("FillPath not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceFillPath(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/FillRect.java b/src/java.desktop/share/classes/sun/java2d/loops/FillRect.java index 2a12dda94e98b..e12a05da0abbc 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/FillRect.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/FillRect.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; @@ -79,9 +78,9 @@ public native void FillRect(SunGraphics2D sg2d, SurfaceData dest, GraphicsPrimitiveMgr.registerGeneral(new FillRect(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { return new General(srctype, comptype, dsttype); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java b/src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java index cb218f954f588..07686384204d5 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,10 +30,9 @@ package sun.java2d.loops; -import sun.java2d.loops.GraphicsPrimitive; -import sun.java2d.pipe.SpanIterator; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; +import sun.java2d.pipe.SpanIterator; /** * FillSpans @@ -82,15 +81,6 @@ public void FillSpans(SunGraphics2D sg2d, SurfaceData dest, FillSpans(sg2d, dest, sg2d.pixel, si.getNativeIterator(), si); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - // REMIND: iterate with a FillRect primitive? - throw new InternalError("FillSpans not implemented for "+ - srctype+" with "+comptype); - } - public GraphicsPrimitive traceWrap() { return new TraceFillSpans(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java index a71978a10ac38..de3ffc21b22d8 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,25 +29,24 @@ package sun.java2d.loops; -import java.awt.image.BufferedImage; import java.awt.AlphaComposite; import java.awt.Rectangle; -import sun.awt.image.BufImgSurfaceData; -import sun.awt.util.ThreadGroupUtils; -import sun.java2d.SurfaceData; -import sun.java2d.pipe.Region; -import java.lang.reflect.Field; -import java.util.StringTokenizer; -import java.util.Iterator; -import java.util.HashMap; -import java.util.Map; -import java.io.PrintStream; -import java.io.OutputStream; -import java.io.FileOutputStream; +import java.awt.image.BufferedImage; import java.io.FileNotFoundException; +import java.io.FileOutputStream; +import java.io.PrintStream; +import java.lang.reflect.Field; import java.security.AccessController; import java.security.PrivilegedAction; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Map; +import java.util.StringTokenizer; +import sun.awt.image.BufImgSurfaceData; +import sun.awt.util.ThreadGroupUtils; +import sun.java2d.SurfaceData; +import sun.java2d.pipe.Region; import sun.security.action.GetPropertyAction; /** @@ -312,9 +311,18 @@ final boolean satisfiesSameAs(GraphicsPrimitive other) { destType.equals(other.destType)); } - public abstract GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype); + /** + * Produces specific primitive loop if the current object is registered as a + * general loop, otherwise the {@code InternalError} is thrown. + * + * @see GraphicsPrimitiveMgr#registerGeneral + */ + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { + throw new InternalError("%s not implemented for %s, comp: %s, dst: %s". + formatted(getClass().getName(), srctype, comptype, dsttype)); + } public abstract GraphicsPrimitive traceWrap(); diff --git a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java index 66a8e7905be8c..dadfbeb540c0d 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java @@ -121,6 +121,12 @@ public static synchronized void register(GraphicsPrimitive[] newPrimitives) primitives = temp; } + /** + * Registers the general loop which will be used to produce specific + * primitives by the {@link GraphicsPrimitive#makePrimitive} function. + * + * @param gen the graphics primitive to be registered as the general loop + */ public static synchronized void registerGeneral(GraphicsPrimitive gen) { if (generalPrimitives == null) { generalPrimitives = new GraphicsPrimitive[] {gen}; diff --git a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java index 1644b8c3be7d8..cf416f747754d 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1998, 2003, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1998, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -65,13 +65,6 @@ public GraphicsPrimitiveProxy(Class owner, String relativeClassName, this.relativeClassName = relativeClassName; } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) { - // This should never happen. - throw new InternalError("makePrimitive called on a Proxy!"); - } - // // Come up with the real instance. Called from // GraphicsPrimitiveMgr.locate() diff --git a/src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java b/src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java index 99fbdf5eadcab..414e800dd1b95 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,7 +27,7 @@ import java.awt.Composite; import java.lang.ref.WeakReference; -import sun.java2d.loops.GraphicsPrimitive; + import sun.java2d.SurfaceData; import sun.java2d.pipe.Region; @@ -112,9 +112,9 @@ public native void MaskBlit(SurfaceData src, SurfaceData dst, GraphicsPrimitiveMgr.registerGeneral(new MaskBlit(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { /* new Throwable().printStackTrace(); diff --git a/src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java b/src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java index 561fa9bff5ba9..108b235d585d9 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,8 +27,8 @@ import java.awt.Composite; import java.awt.image.BufferedImage; + import sun.awt.image.BufImgSurfaceData; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.SunGraphics2D; import sun.java2d.SurfaceData; import sun.java2d.pipe.Region; @@ -144,9 +144,9 @@ public boolean canDoParallelograms() { GraphicsPrimitiveMgr.registerGeneral(new MaskFill(null, null, null)); } - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) + protected GraphicsPrimitive makePrimitive(SurfaceType srctype, + CompositeType comptype, + SurfaceType dsttype) { if (SurfaceType.OpaqueColor.equals(srctype) || SurfaceType.AnyColor.equals(srctype)) diff --git a/src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java b/src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java index 066b0a9b8f5d9..4717839e25da9 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,7 +26,7 @@ package sun.java2d.loops; import java.awt.Composite; -import sun.java2d.loops.GraphicsPrimitive; + import sun.java2d.SurfaceData; import sun.java2d.pipe.Region; @@ -104,23 +104,6 @@ public native void Scale(SurfaceData src, SurfaceData dst, double dx1, double dy1, double dx2, double dy2); - static { - GraphicsPrimitiveMgr.registerGeneral(new ScaledBlit(null, null, null)); - } - - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - /* - System.out.println("Constructing general blit for:"); - System.out.println("src: "+srctype); - System.out.println("comp: "+comptype); - System.out.println("dst: "+dsttype); - */ - return null; - } - public GraphicsPrimitive traceWrap() { return new TraceScaledBlit(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/TransformBlit.java b/src/java.desktop/share/classes/sun/java2d/loops/TransformBlit.java index 290596ff9ff8d..6b8ad98ad06e5 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/TransformBlit.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/TransformBlit.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,8 +27,8 @@ import java.awt.Composite; import java.awt.geom.AffineTransform; + import sun.java2d.SurfaceData; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.pipe.Region; /** @@ -105,25 +105,6 @@ public native void Transform(SurfaceData src, SurfaceData dst, int srcx, int srcy, int dstx, int dsty, int width, int height); - // REMIND: do we have a general loop? - static { - GraphicsPrimitiveMgr.registerGeneral(new TransformBlit(null, null, - null)); - } - - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - /* - System.out.println("Constructing general blit for:"); - System.out.println("src: "+srctype); - System.out.println("comp: "+comptype); - System.out.println("dst: "+dsttype); - */ - return null; - } - public GraphicsPrimitive traceWrap() { return new TraceTransformBlit(this); } diff --git a/src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java b/src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java index e00ac6d43dbca..450a76f241750 100644 --- a/src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java +++ b/src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2004, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,8 +27,8 @@ import java.awt.Composite; import java.awt.geom.AffineTransform; + import sun.java2d.SurfaceData; -import sun.java2d.loops.GraphicsPrimitive; import sun.java2d.pipe.Region; /** @@ -98,13 +98,6 @@ public native void Transform(MaskBlit output, int dx1, int dy1, int dx2, int dy2, int[] edges, int dxoff, int dyoff); - public GraphicsPrimitive makePrimitive(SurfaceType srctype, - CompositeType comptype, - SurfaceType dsttype) - { - return null; - } - public GraphicsPrimitive traceWrap() { return new TraceTransformHelper(this); } From 7e01bc967d00dce1791ef5cd31b8083751eb52e6 Mon Sep 17 00:00:00 2001 From: Mat Carter Date: Wed, 6 Jan 2021 10:39:07 +0000 Subject: [PATCH 039/129] 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows Reviewed-by: alanb --- .../windows/native/libnet/net_util_md.h | 28 +++++++++++-------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/java.base/windows/native/libnet/net_util_md.h b/src/java.base/windows/native/libnet/net_util_md.h index b76935db3de8e..2f873b6295e32 100644 --- a/src/java.base/windows/native/libnet/net_util_md.h +++ b/src/java.base/windows/native/libnet/net_util_md.h @@ -90,24 +90,30 @@ struct ipv6bind { /** * With dual socket implementation the * IPv4 addresseses might be mapped as IPv6. - * The IPv4 loopback adapter address will - * be mapped as the following IPv6 ::ffff:127.0.0.1. + * The IPv4 loopback adapter address ranges (127.0.0.0 through 127.255.255.255) will + * be mapped as the following IPv6 ::ffff:127.0.0.0 through ::ffff:127.255.255.255. * For example, this is done by NET_InetAddressToSockaddr. */ #define IN6_IS_ADDR_V4MAPPED_LOOPBACK(x) ( \ - (((x)->s6_words[0] == 0) && \ - ((x)->s6_words[1] == 0) && \ - ((x)->s6_words[2] == 0) && \ - ((x)->s6_words[3] == 0) && \ - ((x)->s6_words[4] == 0) && \ - ((x)->s6_words[5] == 0xFFFF) && \ - ((x)->s6_words[6] == 0x007F) && \ - ((x)->s6_words[7] == 0x0100)) \ + (((x)->s6_words[0] == 0) && \ + ((x)->s6_words[1] == 0) && \ + ((x)->s6_words[2] == 0) && \ + ((x)->s6_words[3] == 0) && \ + ((x)->s6_words[4] == 0) && \ + ((x)->s6_words[5] == 0xFFFF) && \ + (((x)->s6_words[6] & 0x00FF) == 0x007F)) \ +) + +/** + * Check for IPv4 loopback adapter address ranges (127.0.0.0 through 127.255.255.255) + */ +#define IN4_IS_ADDR_NETLONG_LOOPBACK(l) ( \ + ((l & 0xFF000000) == 0x7F000000) \ ) #define IS_LOOPBACK_ADDRESS(x) ( \ ((x)->sa.sa_family == AF_INET) ? \ - (ntohl((x)->sa4.sin_addr.s_addr) == INADDR_LOOPBACK) : \ + (IN4_IS_ADDR_NETLONG_LOOPBACK(ntohl((x)->sa4.sin_addr.s_addr))) : \ ((IN6_IS_ADDR_LOOPBACK(&(x)->sa6.sin6_addr)) || \ (IN6_IS_ADDR_V4MAPPED_LOOPBACK(&(x)->sa6.sin6_addr))) \ ) From e66187d885b6b6b29a812007d6b6283313954591 Mon Sep 17 00:00:00 2001 From: Maurizio Cimadamore Date: Wed, 6 Jan 2021 12:18:43 +0000 Subject: [PATCH 040/129] 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition Co-authored-by: Uwe Schindler Reviewed-by: alanb --- .../classes/sun/nio/ch/FileChannelImpl.java | 2 +- test/jdk/java/foreign/TestByteBuffer.java | 22 +++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java b/src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java index aee76b374a208..f19d4226c126a 100644 --- a/src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java +++ b/src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java @@ -889,7 +889,7 @@ private Unmapper(long address, long size, long cap, @Override public long address() { - return address; + return address + pagePosition; } @Override diff --git a/test/jdk/java/foreign/TestByteBuffer.java b/test/jdk/java/foreign/TestByteBuffer.java index 241a7eefed50a..46e288a2ece4c 100644 --- a/test/jdk/java/foreign/TestByteBuffer.java +++ b/test/jdk/java/foreign/TestByteBuffer.java @@ -464,6 +464,28 @@ public void testBadMapNegativeOffset() throws IOException { MemorySegment.mapFile(f.toPath(), -1, 1, FileChannel.MapMode.READ_WRITE); } + @Test + public void testMapOffset() throws IOException { + File f = new File("testMapOffset.out"); + f.createNewFile(); + f.deleteOnExit(); + + int SIZE = Byte.MAX_VALUE; + + try (MemorySegment segment = MemorySegment.mapFile(f.toPath(), 0, SIZE, FileChannel.MapMode.READ_WRITE)) { + for (byte offset = 0; offset < SIZE; offset++) { + MemoryAccess.setByteAtOffset(segment, offset, offset); + } + MappedMemorySegments.force(segment); + } + + for (int offset = 0 ; offset < SIZE ; offset++) { + try (MemorySegment segment = MemorySegment.mapFile(f.toPath(), offset, SIZE - offset, FileChannel.MapMode.READ_ONLY)) { + assertEquals(MemoryAccess.getByte(segment), offset); + } + } + } + @Test public void testMapZeroSize() throws IOException { File f = new File("testPos1.out"); From ad456787192c84e1a974394f2066dd7a2cd30900 Mon Sep 17 00:00:00 2001 From: Aleksey Shipilev Date: Wed, 6 Jan 2021 13:27:57 +0000 Subject: [PATCH 041/129] 8258558: Revert changes for JDK-8252505 and related issues Reviewed-by: kvn --- src/hotspot/share/c1/c1_Compiler.cpp | 2 - src/hotspot/share/c1/c1_GraphBuilder.cpp | 2 +- src/hotspot/share/c1/c1_LIRGenerator.cpp | 21 -- src/hotspot/share/c1/c1_LIRGenerator.hpp | 1 - src/hotspot/share/ci/ciMethod.cpp | 4 - src/hotspot/share/ci/ciMethod.hpp | 9 - .../share/classfile/classFileParser.cpp | 5 - src/hotspot/share/classfile/vmIntrinsics.cpp | 1 - src/hotspot/share/classfile/vmIntrinsics.hpp | 3 - src/hotspot/share/classfile/vmSymbols.hpp | 1 - src/hotspot/share/compiler/compilerOracle.cpp | 18 - src/hotspot/share/compiler/compilerOracle.hpp | 4 - src/hotspot/share/opto/c2compiler.cpp | 2 - src/hotspot/share/opto/classes.hpp | 1 - src/hotspot/share/opto/compile.cpp | 2 - src/hotspot/share/opto/library_call.cpp | 35 +- src/hotspot/share/opto/library_call.hpp | 2 - src/hotspot/share/opto/memnode.cpp | 23 -- src/hotspot/share/opto/memnode.hpp | 20 -- src/hotspot/share/opto/node.hpp | 1 - src/hotspot/share/opto/regmask.cpp | 7 - src/hotspot/share/opto/regmask.hpp | 1 - src/hotspot/share/runtime/vmStructs.cpp | 1 - test/hotspot/jtreg/ProblemList-Xcomp.txt | 23 -- test/hotspot/jtreg/TEST.groups | 1 - .../BlackholeDiagnosticUnlockTest.java | 109 ------ .../BlackholeInstanceReturnTest.java | 183 ---------- .../blackhole/BlackholeInstanceTest.java | 314 ------------------ .../BlackholeNonVoidWarningTest.java | 98 ------ .../blackhole/BlackholeNullCheckTest.java | 173 ---------- .../blackhole/BlackholeStaticReturnTest.java | 174 ---------- .../blackhole/BlackholeStaticTest.java | 287 ---------------- .../compiler/blackhole/BlackholeTarget.java | 136 -------- 33 files changed, 2 insertions(+), 1662 deletions(-) delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeDiagnosticUnlockTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceReturnTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarningTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeNullCheckTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeStaticReturnTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeStaticTest.java delete mode 100644 test/hotspot/jtreg/compiler/blackhole/BlackholeTarget.java diff --git a/src/hotspot/share/c1/c1_Compiler.cpp b/src/hotspot/share/c1/c1_Compiler.cpp index a3ffcdb785f92..f245594c5a689 100644 --- a/src/hotspot/share/c1/c1_Compiler.cpp +++ b/src/hotspot/share/c1/c1_Compiler.cpp @@ -230,8 +230,6 @@ bool Compiler::is_intrinsic_supported(const methodHandle& method) { break; case vmIntrinsics::_getObjectSize: break; - case vmIntrinsics::_blackhole: - break; default: return false; // Intrinsics not on the previous list are not available. } diff --git a/src/hotspot/share/c1/c1_GraphBuilder.cpp b/src/hotspot/share/c1/c1_GraphBuilder.cpp index a981c1fd461be..102333cea3244 100644 --- a/src/hotspot/share/c1/c1_GraphBuilder.cpp +++ b/src/hotspot/share/c1/c1_GraphBuilder.cpp @@ -3415,7 +3415,7 @@ bool GraphBuilder::try_inline(ciMethod* callee, bool holder_known, bool ignore_r // handle intrinsics if (callee->intrinsic_id() != vmIntrinsics::_none && - callee->check_intrinsic_candidate()) { + (CheckIntrinsics ? callee->intrinsic_candidate() : true)) { if (try_inline_intrinsics(callee, ignore_return)) { print_inlining(callee, "intrinsic"); if (callee->has_reserved_stack_access()) { diff --git a/src/hotspot/share/c1/c1_LIRGenerator.cpp b/src/hotspot/share/c1/c1_LIRGenerator.cpp index ef57876273dfe..c6e23d3ce17df 100644 --- a/src/hotspot/share/c1/c1_LIRGenerator.cpp +++ b/src/hotspot/share/c1/c1_LIRGenerator.cpp @@ -3206,10 +3206,6 @@ void LIRGenerator::do_Intrinsic(Intrinsic* x) { do_vectorizedMismatch(x); break; - case vmIntrinsics::_blackhole: - do_blackhole(x); - break; - default: ShouldNotReachHere(); break; } } @@ -3629,23 +3625,6 @@ void LIRGenerator::do_RangeCheckPredicate(RangeCheckPredicate *x) { } } -void LIRGenerator::do_blackhole(Intrinsic *x) { - // If we have a receiver, then null-check and handle it separately - bool handle_receiver = x->needs_null_check(); - if (handle_receiver) { - CodeEmitInfo* info = state_for(x); - LIRItem vitem(x->receiver(), this); - vitem.load_item(); - __ null_check(vitem.result(), info); - } - - for (int c = (handle_receiver ? 1 : 0); c < x->number_of_arguments(); c++) { - // Load the argument - LIRItem vitem(x->argument_at(c), this); - vitem.load_item(); - // ...and leave it unused. - } -} LIR_Opr LIRGenerator::call_runtime(Value arg1, address entry, ValueType* result_type, CodeEmitInfo* info) { LIRItemList args(1); diff --git a/src/hotspot/share/c1/c1_LIRGenerator.hpp b/src/hotspot/share/c1/c1_LIRGenerator.hpp index 8817efc148c7a..f1b89e542fc02 100644 --- a/src/hotspot/share/c1/c1_LIRGenerator.hpp +++ b/src/hotspot/share/c1/c1_LIRGenerator.hpp @@ -265,7 +265,6 @@ class LIRGenerator: public InstructionVisitor, public BlockClosure { void do_update_CRC32(Intrinsic* x); void do_update_CRC32C(Intrinsic* x); void do_vectorizedMismatch(Intrinsic* x); - void do_blackhole(Intrinsic* x); public: LIR_Opr call_runtime(BasicTypeArray* signature, LIRItemList* args, address entry, ValueType* result_type, CodeEmitInfo* info); diff --git a/src/hotspot/share/ci/ciMethod.cpp b/src/hotspot/share/ci/ciMethod.cpp index bdfe57a8b81be..7c60456f7019b 100644 --- a/src/hotspot/share/ci/ciMethod.cpp +++ b/src/hotspot/share/ci/ciMethod.cpp @@ -155,10 +155,6 @@ ciMethod::ciMethod(const methodHandle& h_m, ciInstanceKlass* holder) : ciReplay::initialize(this); } #endif - - if (CompilerOracle::should_blackhole(h_m)) { - h_m->set_intrinsic_id(vmIntrinsics::_blackhole); - } } diff --git a/src/hotspot/share/ci/ciMethod.hpp b/src/hotspot/share/ci/ciMethod.hpp index ae79a4e0e8d21..4507598afbf24 100644 --- a/src/hotspot/share/ci/ciMethod.hpp +++ b/src/hotspot/share/ci/ciMethod.hpp @@ -201,15 +201,6 @@ class ciMethod : public ciMetadata { bool intrinsic_candidate() const { return get_Method()->intrinsic_candidate(); } bool is_static_initializer() const { return get_Method()->is_static_initializer(); } - bool check_intrinsic_candidate() const { - if (intrinsic_id() == vmIntrinsics::_blackhole) { - // This is the intrinsic without an associated method, so no intrinsic_candidate - // flag is set. The intrinsic is still correct. - return true; - } - return (CheckIntrinsics ? intrinsic_candidate() : true); - } - int highest_osr_comp_level(); Bytecodes::Code java_code_at_bci(int bci) { diff --git a/src/hotspot/share/classfile/classFileParser.cpp b/src/hotspot/share/classfile/classFileParser.cpp index 1282b373f06e4..d4de4c7ca1ffd 100644 --- a/src/hotspot/share/classfile/classFileParser.cpp +++ b/src/hotspot/share/classfile/classFileParser.cpp @@ -5308,11 +5308,6 @@ static void check_methods_for_intrinsics(const InstanceKlass* ik, // is defined for it. continue; } - if (vmIntrinsics::_blackhole == id) { - // The _blackhole intrinsic is a special marker. No explicit method - // is defined for it. - continue; - } if (vmIntrinsics::class_for(id) == klass_id) { // Check if the current class contains a method with the same diff --git a/src/hotspot/share/classfile/vmIntrinsics.cpp b/src/hotspot/share/classfile/vmIntrinsics.cpp index a686c05022463..ae1e5249fa358 100644 --- a/src/hotspot/share/classfile/vmIntrinsics.cpp +++ b/src/hotspot/share/classfile/vmIntrinsics.cpp @@ -151,7 +151,6 @@ bool vmIntrinsics::should_be_pinned(vmIntrinsics::ID id) { #endif case vmIntrinsics::_currentTimeMillis: case vmIntrinsics::_nanoTime: - case vmIntrinsics::_blackhole: return true; default: return false; diff --git a/src/hotspot/share/classfile/vmIntrinsics.hpp b/src/hotspot/share/classfile/vmIntrinsics.hpp index d36b3867a885c..f3523d1620b9f 100644 --- a/src/hotspot/share/classfile/vmIntrinsics.hpp +++ b/src/hotspot/share/classfile/vmIntrinsics.hpp @@ -534,9 +534,6 @@ class methodHandle; do_name( getObjectSize_name, "getObjectSize0") \ do_alias( getObjectSize_signature, long_object_long_signature) \ \ - /* special marker for blackholed methods: */ \ - do_intrinsic(_blackhole, java_lang_Object, blackhole_name, star_name, F_S) \ - \ /* unsafe memory references (there are a lot of them...) */ \ do_signature(getReference_signature, "(Ljava/lang/Object;J)Ljava/lang/Object;") \ do_signature(putReference_signature, "(Ljava/lang/Object;JLjava/lang/Object;)V") \ diff --git a/src/hotspot/share/classfile/vmSymbols.hpp b/src/hotspot/share/classfile/vmSymbols.hpp index 4fe2054390ffb..88502d04ca344 100644 --- a/src/hotspot/share/classfile/vmSymbols.hpp +++ b/src/hotspot/share/classfile/vmSymbols.hpp @@ -283,7 +283,6 @@ template(signature_name, "signature") \ template(slot_name, "slot") \ template(trusted_final_name, "trustedFinal") \ - template(blackhole_name, "") /*fake name*/ \ \ /* Support for annotations (JDK 1.5 and above) */ \ \ diff --git a/src/hotspot/share/compiler/compilerOracle.cpp b/src/hotspot/share/compiler/compilerOracle.cpp index e0d7b2883780c..193c791df7457 100644 --- a/src/hotspot/share/compiler/compilerOracle.cpp +++ b/src/hotspot/share/compiler/compilerOracle.cpp @@ -286,11 +286,6 @@ static void register_command(TypedMethodOptionMatcher* matcher, } assert(CompilerOracle::option_matches_type(option, value), "Value must match option type"); - if (option == CompileCommand::Blackhole && !UnlockDiagnosticVMOptions) { - warning("Blackhole compile option is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions"); - return; - } - matcher->init(option, option_list); matcher->set_value(value); option_list = matcher; @@ -414,19 +409,6 @@ bool CompilerOracle::should_break_at(const methodHandle& method) { return check_predicate(CompileCommand::Break, method); } -bool CompilerOracle::should_blackhole(const methodHandle& method) { - if (!check_predicate(CompileCommand::Blackhole, method)) { - return false; - } - guarantee(UnlockDiagnosticVMOptions, "Checked during initial parsing"); - if (method->result_type() != T_VOID) { - warning("Blackhole compile option only works for methods with void type: %s", - method->name_and_sig_as_C_string()); - return false; - } - return true; -} - static enum CompileCommand parse_option_name(const char* line, int* bytes_read, char* errorbuf, int bufsize) { assert(ARRAY_SIZE(option_names) == static_cast(CompileCommand::Count), "option_names size mismatch"); diff --git a/src/hotspot/share/compiler/compilerOracle.hpp b/src/hotspot/share/compiler/compilerOracle.hpp index 0ca960d9eba52..23cfde6f0625b 100644 --- a/src/hotspot/share/compiler/compilerOracle.hpp +++ b/src/hotspot/share/compiler/compilerOracle.hpp @@ -51,7 +51,6 @@ class methodHandle; option(Print, "print", Bool) \ option(Inline, "inline", Bool) \ option(DontInline, "dontinline", Bool) \ - option(Blackhole, "blackhole", Bool) \ option(CompileOnly, "compileonly", Bool)\ option(Exclude, "exclude", Bool) \ option(Break, "break", Bool) \ @@ -142,9 +141,6 @@ class CompilerOracle : AllStatic { // Tells whether to break when compiling method static bool should_break_at(const methodHandle& method); - // Tells whether to blackhole when compiling method - static bool should_blackhole(const methodHandle& method); - // Tells whether there are any methods to print for print_method_statistics() static bool should_print_methods(); diff --git a/src/hotspot/share/opto/c2compiler.cpp b/src/hotspot/share/opto/c2compiler.cpp index 4becb5bedc169..36ab93124d99e 100644 --- a/src/hotspot/share/opto/c2compiler.cpp +++ b/src/hotspot/share/opto/c2compiler.cpp @@ -675,8 +675,6 @@ bool C2Compiler::is_intrinsic_supported(const methodHandle& method, bool is_virt case vmIntrinsics::_VectorInsert: case vmIntrinsics::_VectorExtract: return EnableVectorSupport; - case vmIntrinsics::_blackhole: - break; default: return false; diff --git a/src/hotspot/share/opto/classes.hpp b/src/hotspot/share/opto/classes.hpp index 74be3d0e08c38..7359df5689515 100644 --- a/src/hotspot/share/opto/classes.hpp +++ b/src/hotspot/share/opto/classes.hpp @@ -44,7 +44,6 @@ macro(ArrayCopy) macro(AryEq) macro(AtanD) macro(Binary) -macro(Blackhole) macro(Bool) macro(BoxLock) macro(ReverseBytesI) diff --git a/src/hotspot/share/opto/compile.cpp b/src/hotspot/share/opto/compile.cpp index 3468593932499..1d997b1e206d2 100644 --- a/src/hotspot/share/opto/compile.cpp +++ b/src/hotspot/share/opto/compile.cpp @@ -3561,8 +3561,6 @@ void Compile::final_graph_reshaping_main_switch(Node* n, Final_Reshape_Counts& f } break; } - case Op_Blackhole: - break; case Op_RangeCheck: { RangeCheckNode* rc = n->as_RangeCheck(); Node* iff = new IfNode(rc->in(0), rc->in(1), rc->_prob, rc->_fcnt); diff --git a/src/hotspot/share/opto/library_call.cpp b/src/hotspot/share/opto/library_call.cpp index e51fa2c76852b..77363b1592b70 100644 --- a/src/hotspot/share/opto/library_call.cpp +++ b/src/hotspot/share/opto/library_call.cpp @@ -110,7 +110,7 @@ JVMState* LibraryIntrinsic::generate(JVMState* jvms) { const int bci = kit.bci(); // Try to inline the intrinsic. - if (callee->check_intrinsic_candidate() && + if ((CheckIntrinsics ? callee->intrinsic_candidate() : true) && kit.try_to_inline(_last_predicate)) { const char *inline_msg = is_virtual() ? "(intrinsic, virtual)" : "(intrinsic)"; @@ -667,9 +667,6 @@ bool LibraryCallKit::try_to_inline(int predicate) { case vmIntrinsics::_getObjectSize: return inline_getObjectSize(); - case vmIntrinsics::_blackhole: - return inline_blackhole(); - default: // If you get here, it may be that someone has added a new intrinsic // to the list in vmSymbols.hpp without implementing it here. @@ -6851,33 +6848,3 @@ bool LibraryCallKit::inline_getObjectSize() { return true; } - -//------------------------------- inline_blackhole -------------------------------------- -// -// Make sure all arguments to this node are alive. -// This matches methods that were requested to be blackholed through compile commands. -// -bool LibraryCallKit::inline_blackhole() { - // To preserve the semantics of Java call, we need to null-check the receiver, - // if present. Shortcut if receiver is unconditionally null. - Node* receiver = NULL; - bool has_receiver = !callee()->is_static(); - if (has_receiver) { - receiver = null_check_receiver(); - if (stopped()) { - return true; - } - } - - // Bind call arguments as blackhole arguments to keep them alive - Node* bh = insert_mem_bar(Op_Blackhole); - if (has_receiver) { - bh->add_req(receiver); - } - uint nargs = callee()->arg_size(); - for (uint i = has_receiver ? 1 : 0; i < nargs; i++) { - bh->add_req(argument(i)); - } - - return true; -} diff --git a/src/hotspot/share/opto/library_call.hpp b/src/hotspot/share/opto/library_call.hpp index 6395a29f38e4b..021f7dd79d0a6 100644 --- a/src/hotspot/share/opto/library_call.hpp +++ b/src/hotspot/share/opto/library_call.hpp @@ -344,7 +344,5 @@ class LibraryCallKit : public GraphKit { } bool inline_getObjectSize(); - - bool inline_blackhole(); }; diff --git a/src/hotspot/share/opto/memnode.cpp b/src/hotspot/share/opto/memnode.cpp index dbec14a171dc0..90d221964cd34 100644 --- a/src/hotspot/share/opto/memnode.cpp +++ b/src/hotspot/share/opto/memnode.cpp @@ -33,7 +33,6 @@ #include "opto/addnode.hpp" #include "opto/arraycopynode.hpp" #include "opto/cfgnode.hpp" -#include "opto/regalloc.hpp" #include "opto/compile.hpp" #include "opto/connode.hpp" #include "opto/convertnode.hpp" @@ -3222,7 +3221,6 @@ MemBarNode* MemBarNode::make(Compile* C, int opcode, int atp, Node* pn) { case Op_OnSpinWait: return new OnSpinWaitNode(C, atp, pn); case Op_Initialize: return new InitializeNode(C, atp, pn); case Op_MemBarStoreStore: return new MemBarStoreStoreNode(C, atp, pn); - case Op_Blackhole: return new BlackholeNode(C, atp, pn); default: ShouldNotReachHere(); return NULL; } } @@ -3457,27 +3455,6 @@ MemBarNode* MemBarNode::leading_membar() const { return mb; } -#ifndef PRODUCT -void BlackholeNode::format(PhaseRegAlloc* ra, outputStream* st) const { - st->print("blackhole "); - bool first = true; - for (uint i = 0; i < req(); i++) { - Node* n = in(i); - if (n != NULL && OptoReg::is_valid(ra->get_reg_first(n))) { - if (first) { - first = false; - } else { - st->print(", "); - } - char buf[128]; - ra->dump_register(n, buf); - st->print("%s", buf); - } - } - st->cr(); -} -#endif - //===========================InitializeNode==================================== // SUMMARY: // This node acts as a memory barrier on raw memory, after some raw stores. diff --git a/src/hotspot/share/opto/memnode.hpp b/src/hotspot/share/opto/memnode.hpp index 275165c75f046..b9ee30fe30c55 100644 --- a/src/hotspot/share/opto/memnode.hpp +++ b/src/hotspot/share/opto/memnode.hpp @@ -1335,26 +1335,6 @@ class OnSpinWaitNode: public MemBarNode { virtual int Opcode() const; }; -//------------------------------BlackholeNode---------------------------- -// Blackhole all arguments. This node would survive through the compiler -// the effects on its arguments, and would be finally matched to nothing. -class BlackholeNode : public MemBarNode { -public: - BlackholeNode(Compile* C, int alias_idx, Node* precedent) - : MemBarNode(C, alias_idx, precedent) {} - virtual int Opcode() const; - virtual uint ideal_reg() const { return 0; } // not matched in the AD file - const RegMask &in_RegMask(uint idx) const { - // Fake the incoming arguments mask for blackholes: accept all registers - // and all stack slots. This would avoid moving the arguments for the - // call that never happens. - return RegMask::All; - } -#ifndef PRODUCT - virtual void format(PhaseRegAlloc* ra, outputStream* st) const; -#endif -}; - // Isolation of object setup after an AllocateNode and before next safepoint. // (See comment in memnode.cpp near InitializeNode::InitializeNode for semantics.) class InitializeNode: public MemBarNode { diff --git a/src/hotspot/share/opto/node.hpp b/src/hotspot/share/opto/node.hpp index 32f1cc02cadce..35192e27f7005 100644 --- a/src/hotspot/share/opto/node.hpp +++ b/src/hotspot/share/opto/node.hpp @@ -44,7 +44,6 @@ class AllocateNode; class ArrayCopyNode; class BaseCountedLoopNode; class BaseCountedLoopEndNode; -class BlackholeNode; class Block; class BoolNode; class BoxLockNode; diff --git a/src/hotspot/share/opto/regmask.cpp b/src/hotspot/share/opto/regmask.cpp index 9710ed3cb22c9..88a744f9f7f30 100644 --- a/src/hotspot/share/opto/regmask.cpp +++ b/src/hotspot/share/opto/regmask.cpp @@ -51,13 +51,6 @@ void OptoReg::dump(int r, outputStream *st) { //============================================================================= const RegMask RegMask::Empty; -const RegMask RegMask::All( -# define BODY(I) -1, - FORALL_BODY -# undef BODY - 0 -); - //============================================================================= bool RegMask::is_vector(uint ireg) { return (ireg == Op_VecA || ireg == Op_VecS || ireg == Op_VecD || diff --git a/src/hotspot/share/opto/regmask.hpp b/src/hotspot/share/opto/regmask.hpp index 8d862eb128cf0..2d4d19caf107a 100644 --- a/src/hotspot/share/opto/regmask.hpp +++ b/src/hotspot/share/opto/regmask.hpp @@ -356,7 +356,6 @@ class RegMask { #endif static const RegMask Empty; // Common empty mask - static const RegMask All; // Common all mask static bool can_represent(OptoReg::Name reg) { // NOTE: -1 in computation reflects the usage of the last diff --git a/src/hotspot/share/runtime/vmStructs.cpp b/src/hotspot/share/runtime/vmStructs.cpp index 9956cc40e8e4b..384977e107a02 100644 --- a/src/hotspot/share/runtime/vmStructs.cpp +++ b/src/hotspot/share/runtime/vmStructs.cpp @@ -1596,7 +1596,6 @@ typedef HashtableEntry KlassHashtableEntry; declare_c2_type(MemBarVolatileNode, MemBarNode) \ declare_c2_type(MemBarCPUOrderNode, MemBarNode) \ declare_c2_type(OnSpinWaitNode, MemBarNode) \ - declare_c2_type(BlackholeNode, MemBarNode) \ declare_c2_type(InitializeNode, MemBarNode) \ declare_c2_type(ThreadLocalNode, Node) \ declare_c2_type(Opaque1Node, Node) \ diff --git a/test/hotspot/jtreg/ProblemList-Xcomp.txt b/test/hotspot/jtreg/ProblemList-Xcomp.txt index d69c9d02eb4ff..35cc36d97e0ac 100644 --- a/test/hotspot/jtreg/ProblemList-Xcomp.txt +++ b/test/hotspot/jtreg/ProblemList-Xcomp.txt @@ -28,26 +28,3 @@ ############################################################################# vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java 8205957 generic-all - -compiler/blackhole/BlackholeDiagnosticUnlockTest.java 8258101 generic-all -compiler/blackhole/BlackholeInstanceReturnTest.java#c1 8258101 generic-all -compiler/blackhole/BlackholeInstanceReturnTest.java#c1-no-coops 8258101 generic-all -compiler/blackhole/BlackholeInstanceReturnTest.java#c2 8258101 generic-all -compiler/blackhole/BlackholeInstanceReturnTest.java#c2-no-coops 8258101 generic-all -compiler/blackhole/BlackholeInstanceTest.java#c1 8258101 generic-all -compiler/blackhole/BlackholeInstanceTest.java#c1-no-coops 8258101 generic-all -compiler/blackhole/BlackholeInstanceTest.java#c2 8258101 generic-all -compiler/blackhole/BlackholeInstanceTest.java#c2-no-coops 8258101 generic-all -compiler/blackhole/BlackholeNonVoidWarningTest.java 8258101 generic-all -compiler/blackhole/BlackholeNullCheckTest.java#c1 8258101 generic-all -compiler/blackhole/BlackholeNullCheckTest.java#c1-no-coops 8258101 generic-all -compiler/blackhole/BlackholeNullCheckTest.java#c2 8258101 generic-all -compiler/blackhole/BlackholeNullCheckTest.java#c2-no-coops 8258101 generic-all -compiler/blackhole/BlackholeStaticReturnTest.java#c1 8258101 generic-all -compiler/blackhole/BlackholeStaticReturnTest.java#c1-no-coops 8258101 generic-all -compiler/blackhole/BlackholeStaticReturnTest.java#c2 8258101 generic-all -compiler/blackhole/BlackholeStaticReturnTest.java#c2-no-coops 8258101 generic-all -compiler/blackhole/BlackholeStaticTest.java#c1 8258101 generic-all -compiler/blackhole/BlackholeStaticTest.java#c1-no-coops 8258101 generic-all -compiler/blackhole/BlackholeStaticTest.java#c2 8258101 generic-all -compiler/blackhole/BlackholeStaticTest.java#c2-no-coops 8258101 generic-all diff --git a/test/hotspot/jtreg/TEST.groups b/test/hotspot/jtreg/TEST.groups index a2b4b409c7c6a..1cd45d79eeb66 100644 --- a/test/hotspot/jtreg/TEST.groups +++ b/test/hotspot/jtreg/TEST.groups @@ -97,7 +97,6 @@ hotspot_slow_compiler = \ tier1_compiler_1 = \ compiler/arraycopy/ \ - compiler/blackhole/ \ compiler/c1/ \ compiler/c2/ \ -compiler/c2/Test6850611.java \ diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeDiagnosticUnlockTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeDiagnosticUnlockTest.java deleted file mode 100644 index 45eb8022fcf97..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeDiagnosticUnlockTest.java +++ /dev/null @@ -1,109 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test - * @library /test/lib - * @build compiler.blackhole.BlackholeTarget - * @run driver compiler.blackhole.BlackholeDiagnosticUnlockTest - */ - -package compiler.blackhole; - -import java.io.IOException; -import jdk.test.lib.Platform; -import jdk.test.lib.process.ProcessTools; -import jdk.test.lib.process.OutputAnalyzer; - -public class BlackholeDiagnosticUnlockTest { - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void main(String[] args) throws IOException { - if (args.length == 0) { - driver(); - } else { - runner(); - } - } - - public static void driver() throws IOException { - final String msg = "Blackhole compile option is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions"; - - if (!Platform.isDebugBuild()) { // UnlockDiagnosticVMOptions is true in debug - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( - "-Xmx128m", - "-Xbatch", - "-XX:CompileCommand=quiet", - "-XX:CompileCommand=option,compiler/blackhole/BlackholeTarget.bh_*,Blackhole", - "compiler.blackhole.BlackholeDiagnosticUnlockTest", - "run" - ); - OutputAnalyzer output = new OutputAnalyzer(pb.start()); - output.shouldHaveExitValue(0); - output.shouldContain(msg); - } - - { - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( - "-Xmx128m", - "-XX:-PrintWarnings", - "-XX:CompileCommand=quiet", - "-XX:CompileCommand=option,compiler/blackhole/BlackholeTarget.bh_*,Blackhole", - "compiler.blackhole.BlackholeDiagnosticUnlockTest", - "run" - ); - OutputAnalyzer output = new OutputAnalyzer(pb.start()); - output.shouldHaveExitValue(0); - output.shouldNotContain(msg); - } - - { - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( - "-Xmx128m", - "-XX:+UnlockDiagnosticVMOptions", - "-XX:CompileCommand=quiet", - "-XX:CompileCommand=option,compiler/blackhole/BlackholeTarget.bh_*,Blackhole", - "compiler.blackhole.BlackholeDiagnosticUnlockTest", - "run" - ); - OutputAnalyzer output = new OutputAnalyzer(pb.start()); - output.shouldHaveExitValue(0); - output.shouldNotContain(msg); - } - } - - public static void runner() { - for (int t = 0; t < TRIES; t++) { - run(); - } - } - - public static void run() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_int_1(c); - } - } - -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceReturnTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceReturnTest.java deleted file mode 100644 index 35cb7b467e884..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceReturnTest.java +++ /dev/null @@ -1,183 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test id=c1 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceReturnTest - */ - -/** - * @test id=c2 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceReturnTest - */ - -/** - * @test id=c1-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceReturnTest - */ - -/** - * @test id=c2-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceReturnTest - */ - -package compiler.blackhole; - -public class BlackholeInstanceReturnTest { - - public static void main(String[] args) { - runTries(BlackholeInstanceReturnTest::test_boolean); - runTries(BlackholeInstanceReturnTest::test_byte); - runTries(BlackholeInstanceReturnTest::test_char); - runTries(BlackholeInstanceReturnTest::test_short); - runTries(BlackholeInstanceReturnTest::test_int); - runTries(BlackholeInstanceReturnTest::test_float); - runTries(BlackholeInstanceReturnTest::test_long); - runTries(BlackholeInstanceReturnTest::test_double); - runTries(BlackholeInstanceReturnTest::test_Object); - } - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void runTries(Runnable r) { - for (int t = 0; t < TRIES; t++) { - BlackholeTarget.clear(); - r.run(); - BlackholeTarget.shouldBeEntered(); - } - } - - private static void test_boolean() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_boolean((c & 0x1) == 0) != false) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_byte() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_byte((byte)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_char() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_char((char)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_short() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_short((short)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_int() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_int(c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_float() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_float(c) != 0F) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_long() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_long(c) != 0L) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_double() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - if (t.bh_ir_double(c) != 0D) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_Object() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - Object o = new Object(); - if (t.bh_ir_Object(o) != null) { - throw new AssertionError("Return value error"); - } - } - } - -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceTest.java deleted file mode 100644 index b832ae15c75e2..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeInstanceTest.java +++ /dev/null @@ -1,314 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test id=c1 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceTest - */ - -/** - * @test id=c2 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceTest - */ - -/** - * @test id=c1-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceTest - */ - -/** - * @test id=c2-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeInstanceTest - */ - -package compiler.blackhole; - -public class BlackholeInstanceTest { - - public static void main(String[] args) { - runTries(BlackholeInstanceTest::test_boolean_0); - runTries(BlackholeInstanceTest::test_byte_0); - runTries(BlackholeInstanceTest::test_char_0); - runTries(BlackholeInstanceTest::test_short_0); - runTries(BlackholeInstanceTest::test_int_0); - runTries(BlackholeInstanceTest::test_float_0); - runTries(BlackholeInstanceTest::test_long_0); - runTries(BlackholeInstanceTest::test_double_0); - runTries(BlackholeInstanceTest::test_Object_0); - - runTries(BlackholeInstanceTest::test_boolean_1); - runTries(BlackholeInstanceTest::test_byte_1); - runTries(BlackholeInstanceTest::test_char_1); - runTries(BlackholeInstanceTest::test_short_1); - runTries(BlackholeInstanceTest::test_int_1); - runTries(BlackholeInstanceTest::test_float_1); - runTries(BlackholeInstanceTest::test_long_1); - runTries(BlackholeInstanceTest::test_double_1); - runTries(BlackholeInstanceTest::test_Object_1); - - runTries(BlackholeInstanceTest::test_boolean_2); - runTries(BlackholeInstanceTest::test_byte_2); - runTries(BlackholeInstanceTest::test_char_2); - runTries(BlackholeInstanceTest::test_short_2); - runTries(BlackholeInstanceTest::test_int_2); - runTries(BlackholeInstanceTest::test_float_2); - runTries(BlackholeInstanceTest::test_long_2); - runTries(BlackholeInstanceTest::test_double_2); - runTries(BlackholeInstanceTest::test_Object_2); - } - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void runTries(Runnable r) { - for (int t = 0; t < TRIES; t++) { - BlackholeTarget.clear(); - r.run(); - if (t == TRIES - 1) { - BlackholeTarget.shouldNotBeEntered(); - } - } - } - - private static void test_boolean_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_boolean_0(); - } - } - - private static void test_byte_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_byte_0(); - } - } - - private static void test_char_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_char_0(); - } - } - - private static void test_short_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_short_0(); - } - } - - private static void test_int_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_int_0(); - } - } - - private static void test_float_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_float_0(); - } - } - - private static void test_long_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_long_0(); - } - } - - private static void test_double_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_double_0(); - } - } - - private static void test_Object_0() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_Object_0(); - } - } - - private static void test_boolean_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_boolean_1((c & 0x1) == 0); - } - } - - private static void test_byte_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_byte_1((byte)c); - } - } - - private static void test_char_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_char_1((char)c); - } - } - - private static void test_short_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_short_1((short)c); - } - } - - private static void test_int_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_int_1(c); - } - } - - private static void test_float_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_float_1(c); - } - } - - private static void test_long_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_long_1(c); - } - } - - private static void test_double_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_double_1(c); - } - } - - private static void test_Object_1() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - Object o = new Object(); - t.bh_i_Object_1(o); - } - } - - private static void test_boolean_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_boolean_2((c & 0x1) == 0, (c & 0x2) == 0); - } - } - - private static void test_byte_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_byte_2((byte)c, (byte)(c + 1)); - } - } - - private static void test_char_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_char_2((char)c, (char)(c + 1)); - } - } - - private static void test_short_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_short_2((short)c, (short)(c + 1)); - } - } - - private static void test_int_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_int_2(c, c + 1); - } - } - - private static void test_float_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_float_2(c, c + 1); - } - } - - private static void test_long_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_long_2(c, c + 1); - } - } - - private static void test_double_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - t.bh_i_double_2(c, c + 1); - } - } - - private static void test_Object_2() { - BlackholeTarget t = new BlackholeTarget(); - for (int c = 0; c < CYCLES; c++) { - Object o1 = new Object(); - Object o2 = new Object(); - t.bh_i_Object_2(o1, o2); - } - } -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarningTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarningTest.java deleted file mode 100644 index 671ab705234ca..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeNonVoidWarningTest.java +++ /dev/null @@ -1,98 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test - * @library /test/lib - * @build compiler.blackhole.BlackholeTarget - * @run driver compiler.blackhole.BlackholeNonVoidWarningTest - */ - -package compiler.blackhole; - -import java.io.IOException; -import jdk.test.lib.process.ProcessTools; -import jdk.test.lib.process.OutputAnalyzer; - -public class BlackholeNonVoidWarningTest { - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void main(String[] args) throws IOException { - if (args.length == 0) { - driver(); - } else { - runner(); - } - } - - public static void driver() throws IOException { - final String msg = "Blackhole compile option only works for methods with void type: compiler.blackhole.BlackholeTarget.bh_sr_int(I)I"; - - { - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( - "-Xmx128m", - "-Xbatch", - "-XX:+UnlockDiagnosticVMOptions", - "-XX:CompileCommand=quiet", - "-XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_*", - "compiler.blackhole.BlackholeNonVoidWarningTest", - "run" - ); - OutputAnalyzer output = new OutputAnalyzer(pb.start()); - output.shouldHaveExitValue(0); - output.shouldContain(msg); - } - - { - ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( - "-Xmx128m", - "-XX:-PrintWarnings", - "-XX:+UnlockDiagnosticVMOptions", - "-XX:CompileCommand=quiet", - "-XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_*", - "compiler.blackhole.BlackholeNonVoidWarningTest", - "run" - ); - OutputAnalyzer output = new OutputAnalyzer(pb.start()); - output.shouldHaveExitValue(0); - output.shouldNotContain(msg); - } - } - - public static void runner() { - for (int t = 0; t < TRIES; t++) { - run(); - } - } - - public static void run() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_int(c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeNullCheckTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeNullCheckTest.java deleted file mode 100644 index 645fcd61dfc8b..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeNullCheckTest.java +++ /dev/null @@ -1,173 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test id=c1 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeNullCheckTest - */ - -/** - * @test id=c2 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeNullCheckTest - */ - -/** - * @test id=c1-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeNullCheckTest - */ - -/** - * @test id=c2-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeNullCheckTest - */ - -package compiler.blackhole; - -public class BlackholeNullCheckTest { - - public static void main(String[] args) { - BlackholeNullCheckTest t = new BlackholeNullCheckTest(); - runTries(t::test_local_sf); - runTries(t::test_local_s); - runTries(t::test_local); - runTries(t::test_field_sf); - runTries(t::test_field_s); - runTries(t::test_field); - } - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void runTries(Runnable r) { - for (int t = 0; t < TRIES; t++) { - r.run(); - } - } - - static final BlackholeTarget BH_SF_TARGET = null; - static BlackholeTarget BH_S_TARGET = null; - BlackholeTarget BH_TARGET = null; - - private void test_local_sf() { - test_with(BH_SF_TARGET); - } - - private void test_local_s() { - test_with(BH_S_TARGET); - } - - private void test_local() { - test_with(BH_TARGET); - } - - private void test_with(BlackholeTarget t) { - try { - t.bh_i_boolean_1(false); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - } - - try { - t.call_for_null_check(); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - // Expected - } - } - - private void test_field_sf() { - try { - BH_SF_TARGET.bh_i_boolean_1(false); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - } - - try { - BH_SF_TARGET.call_for_null_check(); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - // Expected - } - } - - private void test_field_s() { - try { - BH_S_TARGET.bh_i_boolean_1(false); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - } - - try { - BH_S_TARGET.call_for_null_check(); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - // Expected - } - } - - private void test_field() { - try { - BH_TARGET.bh_i_boolean_1(false); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - } - - try { - BH_TARGET.call_for_null_check(); - throw new IllegalStateException("Expected NPE"); - } catch (NullPointerException npe) { - // Expected - } - } - -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticReturnTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticReturnTest.java deleted file mode 100644 index 722ba0b327908..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticReturnTest.java +++ /dev/null @@ -1,174 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test id=c1 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticReturnTest - */ - -/** - * @test id=c2 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticReturnTest - */ - -/** - * @test id=c1-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticReturnTest - */ - -/** - * @test id=c2-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticReturnTest - */ - -package compiler.blackhole; - -public class BlackholeStaticReturnTest { - - public static void main(String[] args) { - runTries(BlackholeStaticReturnTest::test_boolean); - runTries(BlackholeStaticReturnTest::test_byte); - runTries(BlackholeStaticReturnTest::test_char); - runTries(BlackholeStaticReturnTest::test_short); - runTries(BlackholeStaticReturnTest::test_int); - runTries(BlackholeStaticReturnTest::test_float); - runTries(BlackholeStaticReturnTest::test_long); - runTries(BlackholeStaticReturnTest::test_double); - runTries(BlackholeStaticReturnTest::test_Object); - } - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void runTries(Runnable r) { - for (int t = 0; t < TRIES; t++) { - BlackholeTarget.clear(); - r.run(); - BlackholeTarget.shouldBeEntered(); - } - } - - private static void test_boolean() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_boolean((c & 0x1) == 0) != false) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_byte() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_byte((byte)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_char() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_char((char)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_short() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_short((short)c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_int() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_int(c) != 0) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_float() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_float(c) != 0F) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_long() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_long(c) != 0L) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_double() { - for (int c = 0; c < CYCLES; c++) { - if (BlackholeTarget.bh_sr_double(c) != 0D) { - throw new AssertionError("Return value error"); - } - } - } - - private static void test_Object() { - for (int c = 0; c < CYCLES; c++) { - Object o = new Object(); - if (BlackholeTarget.bh_sr_Object(o) != null) { - throw new AssertionError("Return value error"); - } - } - } - -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticTest.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticTest.java deleted file mode 100644 index 9ef4d3923371c..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeStaticTest.java +++ /dev/null @@ -1,287 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/** - * @test id=c1 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticTest - */ - -/** - * @test id=c2 - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticTest - */ - -/** - * @test id=c1-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:TieredStopAtLevel=1 - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticTest - */ - -/** - * @test id=c2-no-coops - * @requires vm.bits == "64" - * @build compiler.blackhole.BlackholeTarget - * - * @run main/othervm - * -Xmx1g -XX:-UseCompressedOops - * -Xbatch -XX:-TieredCompilation - * -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure - * -XX:CompileCommand=blackhole,compiler/blackhole/BlackholeTarget.bh_* - * compiler.blackhole.BlackholeStaticTest - */ - -package compiler.blackhole; - -public class BlackholeStaticTest { - - public static void main(String[] args) { - runTries(BlackholeStaticTest::test_boolean_0); - runTries(BlackholeStaticTest::test_byte_0); - runTries(BlackholeStaticTest::test_char_0); - runTries(BlackholeStaticTest::test_short_0); - runTries(BlackholeStaticTest::test_int_0); - runTries(BlackholeStaticTest::test_float_0); - runTries(BlackholeStaticTest::test_long_0); - runTries(BlackholeStaticTest::test_double_0); - runTries(BlackholeStaticTest::test_Object_0); - - runTries(BlackholeStaticTest::test_boolean_1); - runTries(BlackholeStaticTest::test_byte_1); - runTries(BlackholeStaticTest::test_char_1); - runTries(BlackholeStaticTest::test_short_1); - runTries(BlackholeStaticTest::test_int_1); - runTries(BlackholeStaticTest::test_float_1); - runTries(BlackholeStaticTest::test_long_1); - runTries(BlackholeStaticTest::test_double_1); - runTries(BlackholeStaticTest::test_Object_1); - - runTries(BlackholeStaticTest::test_boolean_2); - runTries(BlackholeStaticTest::test_byte_2); - runTries(BlackholeStaticTest::test_char_2); - runTries(BlackholeStaticTest::test_short_2); - runTries(BlackholeStaticTest::test_int_2); - runTries(BlackholeStaticTest::test_float_2); - runTries(BlackholeStaticTest::test_long_2); - runTries(BlackholeStaticTest::test_double_2); - runTries(BlackholeStaticTest::test_Object_2); - } - - private static final int CYCLES = 1_000_000; - private static final int TRIES = 10; - - public static void runTries(Runnable r) { - for (int t = 0; t < TRIES; t++) { - BlackholeTarget.clear(); - r.run(); - if (t == TRIES - 1) { - BlackholeTarget.shouldNotBeEntered(); - } - } - } - - private static void test_boolean_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_boolean_0(); - } - } - - private static void test_byte_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_byte_0(); - } - } - - private static void test_char_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_char_0(); - } - } - - private static void test_short_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_short_0(); - } - } - - private static void test_int_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_int_0(); - } - } - - private static void test_float_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_float_0(); - } - } - - private static void test_long_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_long_0(); - } - } - - private static void test_double_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_double_0(); - } - } - - private static void test_Object_0() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_Object_0(); - } - } - - private static void test_boolean_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_boolean_1((c & 0x1) == 0); - } - } - - private static void test_byte_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_byte_1((byte)c); - } - } - - private static void test_char_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_char_1((char)c); - } - } - - private static void test_short_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_short_1((short)c); - } - } - - private static void test_int_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_int_1(c); - } - } - - private static void test_float_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_float_1(c); - } - } - - private static void test_long_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_long_1(c); - } - } - - private static void test_double_1() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_double_1(c); - } - } - - private static void test_Object_1() { - for (int c = 0; c < CYCLES; c++) { - Object o = new Object(); - BlackholeTarget.bh_s_Object_1(o); - } - } - - private static void test_boolean_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_boolean_2((c & 0x1) == 0, (c & 0x2) == 0); - } - } - - private static void test_byte_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_byte_2((byte)c, (byte)(c + 1)); - } - } - - private static void test_char_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_char_2((char)c, (char)(c + 1)); - } - } - - private static void test_short_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_short_2((short)c, (short)(c + 1)); - } - } - - private static void test_int_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_int_2(c, c + 1); - } - } - - private static void test_float_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_float_2(c, c + 1); - } - } - - private static void test_long_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_long_2(c, c + 1); - } - } - - private static void test_double_2() { - for (int c = 0; c < CYCLES; c++) { - BlackholeTarget.bh_s_double_2(c, c + 1); - } - } - - private static void test_Object_2() { - for (int c = 0; c < CYCLES; c++) { - Object o1 = new Object(); - Object o2 = new Object(); - BlackholeTarget.bh_s_Object_2(o1, o2); - } - } -} diff --git a/test/hotspot/jtreg/compiler/blackhole/BlackholeTarget.java b/test/hotspot/jtreg/compiler/blackhole/BlackholeTarget.java deleted file mode 100644 index 3d2c888210239..0000000000000 --- a/test/hotspot/jtreg/compiler/blackhole/BlackholeTarget.java +++ /dev/null @@ -1,136 +0,0 @@ -/* - * Copyright (c) 2020, Red Hat, Inc. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -package compiler.blackhole; - -import java.lang.reflect.*; - -public class BlackholeTarget { - private static String entered; - - private static void registerEntered(String label) { - if (entered == null) { - entered = label; - } else if (!entered.equals(label)) { - throw new IllegalStateException("Trying to register enter with overwrite: " + entered + " -> " + label); - } - } - - public static void clear() { - entered = null; - } - - public static void shouldBeEntered() { - if (entered == null) { - throw new IllegalStateException("Should have been entered"); - } - } - - public static void shouldNotBeEntered() { - if (entered != null) { - throw new IllegalStateException("Should not have been entered: " + entered); - } - } - - public void call_for_null_check() {} - - public static void bh_s_boolean_0() { registerEntered("bh_s_boolean_0"); } - public static void bh_s_byte_0() { registerEntered("bh_s_byte_0"); } - public static void bh_s_short_0() { registerEntered("bh_s_short_0"); } - public static void bh_s_char_0() { registerEntered("bh_s_char_0"); } - public static void bh_s_int_0() { registerEntered("bh_s_int_0"); } - public static void bh_s_float_0() { registerEntered("bh_s_float_0"); } - public static void bh_s_long_0() { registerEntered("bh_s_long_0"); } - public static void bh_s_double_0() { registerEntered("bh_s_double_0"); } - public static void bh_s_Object_0() { registerEntered("bh_s_Object_0"); } - - public void bh_i_boolean_0() { registerEntered("bh_i_boolean_0"); } - public void bh_i_byte_0() { registerEntered("bh_i_byte_0"); } - public void bh_i_short_0() { registerEntered("bh_i_short_0"); } - public void bh_i_char_0() { registerEntered("bh_i_char_0"); } - public void bh_i_int_0() { registerEntered("bh_i_int_0"); } - public void bh_i_float_0() { registerEntered("bh_i_float_0"); } - public void bh_i_long_0() { registerEntered("bh_i_long_0"); } - public void bh_i_double_0() { registerEntered("bh_i_double_0"); } - public void bh_i_Object_0() { registerEntered("bh_i_Object_0"); } - - public static void bh_s_boolean_1(boolean v) { registerEntered("bh_s_boolean_1"); } - public static void bh_s_byte_1(byte v) { registerEntered("bh_s_byte_1"); } - public static void bh_s_short_1(short v) { registerEntered("bh_s_short_1"); } - public static void bh_s_char_1(char v) { registerEntered("bh_s_char_1"); } - public static void bh_s_int_1(int v) { registerEntered("bh_s_int_1"); } - public static void bh_s_float_1(float v) { registerEntered("bh_s_float_1"); } - public static void bh_s_long_1(long v) { registerEntered("bh_s_long_1"); } - public static void bh_s_double_1(double v) { registerEntered("bh_s_double_1"); } - public static void bh_s_Object_1(Object v) { registerEntered("bh_s_Object_1"); } - - public void bh_i_boolean_1(boolean v) { registerEntered("bh_i_boolean_1"); } - public void bh_i_byte_1(byte v) { registerEntered("bh_i_byte_1"); } - public void bh_i_short_1(short v) { registerEntered("bh_i_short_1"); } - public void bh_i_char_1(char v) { registerEntered("bh_i_char_1"); } - public void bh_i_int_1(int v) { registerEntered("bh_i_int_1"); } - public void bh_i_float_1(float v) { registerEntered("bh_i_float_1"); } - public void bh_i_long_1(long v) { registerEntered("bh_i_long_1"); } - public void bh_i_double_1(double v) { registerEntered("bh_i_double_1"); } - public void bh_i_Object_1(Object v) { registerEntered("bh_i_Object_1"); } - - public static void bh_s_boolean_2(boolean v1, boolean v2) { registerEntered("bh_s_boolean_2"); } - public static void bh_s_byte_2(byte v1, byte v2) { registerEntered("bh_s_byte_2"); } - public static void bh_s_short_2(short v1, short v2) { registerEntered("bh_s_short_2"); } - public static void bh_s_char_2(char v1, char v2) { registerEntered("bh_s_char_2"); } - public static void bh_s_int_2(int v1, int v2) { registerEntered("bh_s_int_2"); } - public static void bh_s_float_2(float v1, float v2) { registerEntered("bh_s_float_2"); } - public static void bh_s_long_2(long v1, long v2) { registerEntered("bh_s_long_2"); } - public static void bh_s_double_2(double v1, double v2) { registerEntered("bh_s_double_2"); } - public static void bh_s_Object_2(Object v1, Object v2) { registerEntered("bh_s_Object_2"); } - - public void bh_i_boolean_2(boolean v1, boolean v2) { registerEntered("bh_i_boolean_2"); } - public void bh_i_byte_2(byte v1, byte v2) { registerEntered("bh_i_byte_2"); } - public void bh_i_short_2(short v1, short v2) { registerEntered("bh_i_short_2"); } - public void bh_i_char_2(char v1, char v2) { registerEntered("bh_i_char_2"); } - public void bh_i_int_2(int v1, int v2) { registerEntered("bh_i_int_2"); } - public void bh_i_float_2(float v1, float v2) { registerEntered("bh_i_float_2"); } - public void bh_i_long_2(long v1, long v2) { registerEntered("bh_i_long_2"); } - public void bh_i_double_2(double v1, double v2) { registerEntered("bh_i_double_2"); } - public void bh_i_Object_2(Object v1, Object v2) { registerEntered("bh_i_Object_2"); } - - public static boolean bh_sr_boolean(boolean v) { registerEntered("bh_sr_boolean"); return false; } - public static byte bh_sr_byte(byte v) { registerEntered("bh_sr_byte"); return 0; } - public static short bh_sr_short(short v) { registerEntered("bh_sr_short"); return 0; } - public static char bh_sr_char(char v) { registerEntered("bh_sr_char"); return 0; } - public static int bh_sr_int(int v) { registerEntered("bh_sr_int"); return 0; } - public static float bh_sr_float(float v) { registerEntered("bh_sr_float"); return 0; } - public static long bh_sr_long(long v) { registerEntered("bh_sr_long"); return 0; } - public static double bh_sr_double(double v) { registerEntered("bh_sr_double"); return 0; } - public static Object bh_sr_Object(Object v) { registerEntered("bh_sr_Object"); return null; } - - public boolean bh_ir_boolean(boolean v) { registerEntered("bh_ir_boolean"); return false; } - public byte bh_ir_byte(byte v) { registerEntered("bh_ir_byte"); return 0; } - public short bh_ir_short(short v) { registerEntered("bh_ir_short"); return 0; } - public char bh_ir_char(char v) { registerEntered("bh_ir_char"); return 0; } - public int bh_ir_int(int v) { registerEntered("bh_ir_int"); return 0; } - public float bh_ir_float(float v) { registerEntered("bh_ir_float"); return 0; } - public long bh_ir_long(long v) { registerEntered("bh_ir_long"); return 0; } - public double bh_ir_double(double v) { registerEntered("bh_ir_double"); return 0; } - public Object bh_ir_Object(Object v) { registerEntered("bh_ir_Object"); return null; } -} From c0540ffda9c0afe6d890ddef10cfca90d64eb433 Mon Sep 17 00:00:00 2001 From: "Daniel D. Daugherty" Date: Wed, 6 Jan 2021 14:34:55 +0000 Subject: [PATCH 042/129] 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads Reviewed-by: eosterlund, coleenp, pchilanomate, sspitsyn --- src/hotspot/share/runtime/threadSMR.cpp | 135 ++++++++++-------- ...dThreadsListHandleInErrorHandlingTest.java | 8 +- .../ThreadsListHandleInErrorHandlingTest.java | 6 +- 3 files changed, 86 insertions(+), 63 deletions(-) diff --git a/src/hotspot/share/runtime/threadSMR.cpp b/src/hotspot/share/runtime/threadSMR.cpp index fa420e8e412d0..9b70bdf753c90 100644 --- a/src/hotspot/share/runtime/threadSMR.cpp +++ b/src/hotspot/share/runtime/threadSMR.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -1106,70 +1106,87 @@ void ThreadsSMRSupport::print_info_on(const Thread* thread, outputStream* st) { // Print Threads class SMR info. void ThreadsSMRSupport::print_info_on(outputStream* st) { - // Only grab the Threads_lock if we don't already own it and if we - // are not reporting an error. - // Note: Not grabbing the Threads_lock during error reporting is - // dangerous because the data structures we want to print can be - // freed concurrently. However, grabbing the Threads_lock during - // error reporting can be equally dangerous since this thread might - // block during error reporting or a nested error could leave the - // Threads_lock held. The classic no win scenario. - // - MutexLocker ml((Threads_lock->owned_by_self() || VMError::is_error_reported()) ? NULL : Threads_lock); - - st->print_cr("Threads class SMR info:"); - st->print_cr("_java_thread_list=" INTPTR_FORMAT ", length=%u, " - "elements={", p2i(_java_thread_list), - _java_thread_list->length()); - print_info_elements_on(st, _java_thread_list); - st->print_cr("}"); - if (_to_delete_list != NULL) { - st->print_cr("_to_delete_list=" INTPTR_FORMAT ", length=%u, " - "elements={", p2i(_to_delete_list), - _to_delete_list->length()); - print_info_elements_on(st, _to_delete_list); + bool needs_unlock = false; + if (Threads_lock->try_lock()) { + // We were able to grab the Threads_lock which makes things safe for + // this call, but if we are error reporting, then a nested error + // could happen with the Threads_lock held. + needs_unlock = true; + } + + ThreadsList* saved_threads_list = NULL; + { + ThreadsListHandle tlh; // make the current ThreadsList safe for reporting + saved_threads_list = tlh.list(); // save for later comparison + + st->print_cr("Threads class SMR info:"); + st->print_cr("_java_thread_list=" INTPTR_FORMAT ", length=%u, elements={", + p2i(saved_threads_list), saved_threads_list->length()); + print_info_elements_on(st, saved_threads_list); st->print_cr("}"); - for (ThreadsList *t_list = _to_delete_list->next_list(); - t_list != NULL; t_list = t_list->next_list()) { - st->print("next-> " INTPTR_FORMAT ", length=%u, " - "elements={", p2i(t_list), t_list->length()); - print_info_elements_on(st, t_list); + } + + if (_to_delete_list != NULL) { + if (Threads_lock->owned_by_self()) { + // Only safe if we have the Threads_lock. + st->print_cr("_to_delete_list=" INTPTR_FORMAT ", length=%u, elements={", + p2i(_to_delete_list), _to_delete_list->length()); + print_info_elements_on(st, _to_delete_list); st->print_cr("}"); + for (ThreadsList *t_list = _to_delete_list->next_list(); + t_list != NULL; t_list = t_list->next_list()) { + st->print("next-> " INTPTR_FORMAT ", length=%u, elements={", + p2i(t_list), t_list->length()); + print_info_elements_on(st, t_list); + st->print_cr("}"); + } + } else { + st->print_cr("_to_delete_list=" INTPTR_FORMAT, p2i(_to_delete_list)); + st->print_cr("Skipping _to_delete_list fields and contents for safety."); } } - if (!EnableThreadSMRStatistics) { - return; - } - st->print_cr("_java_thread_list_alloc_cnt=" UINT64_FORMAT ", " - "_java_thread_list_free_cnt=" UINT64_FORMAT ", " - "_java_thread_list_max=%u, " - "_nested_thread_list_max=%u", - _java_thread_list_alloc_cnt, - _java_thread_list_free_cnt, - _java_thread_list_max, - _nested_thread_list_max); - if (_tlh_cnt > 0) { - st->print_cr("_tlh_cnt=%u" - ", _tlh_times=%u" - ", avg_tlh_time=%0.2f" - ", _tlh_time_max=%u", - _tlh_cnt, _tlh_times, - ((double) _tlh_times / _tlh_cnt), - _tlh_time_max); + if (EnableThreadSMRStatistics) { + st->print_cr("_java_thread_list_alloc_cnt=" UINT64_FORMAT ", " + "_java_thread_list_free_cnt=" UINT64_FORMAT ", " + "_java_thread_list_max=%u, " + "_nested_thread_list_max=%u", + _java_thread_list_alloc_cnt, + _java_thread_list_free_cnt, + _java_thread_list_max, + _nested_thread_list_max); + if (_tlh_cnt > 0) { + st->print_cr("_tlh_cnt=%u" + ", _tlh_times=%u" + ", avg_tlh_time=%0.2f" + ", _tlh_time_max=%u", + _tlh_cnt, _tlh_times, + ((double) _tlh_times / _tlh_cnt), + _tlh_time_max); + } + if (_deleted_thread_cnt > 0) { + st->print_cr("_deleted_thread_cnt=%u" + ", _deleted_thread_times=%u" + ", avg_deleted_thread_time=%0.2f" + ", _deleted_thread_time_max=%u", + _deleted_thread_cnt, _deleted_thread_times, + ((double) _deleted_thread_times / _deleted_thread_cnt), + _deleted_thread_time_max); + } + st->print_cr("_delete_lock_wait_cnt=%u, _delete_lock_wait_max=%u", + _delete_lock_wait_cnt, _delete_lock_wait_max); + st->print_cr("_to_delete_list_cnt=%u, _to_delete_list_max=%u", + _to_delete_list_cnt, _to_delete_list_max); } - if (_deleted_thread_cnt > 0) { - st->print_cr("_deleted_thread_cnt=%u" - ", _deleted_thread_times=%u" - ", avg_deleted_thread_time=%0.2f" - ", _deleted_thread_time_max=%u", - _deleted_thread_cnt, _deleted_thread_times, - ((double) _deleted_thread_times / _deleted_thread_cnt), - _deleted_thread_time_max); + if (needs_unlock) { + Threads_lock->unlock(); + } else { + if (_java_thread_list != saved_threads_list) { + st->print_cr("The _java_thread_list has changed from " INTPTR_FORMAT + " to " INTPTR_FORMAT + " so some of the above information may be stale.", + p2i(saved_threads_list), p2i(_java_thread_list)); + } } - st->print_cr("_delete_lock_wait_cnt=%u, _delete_lock_wait_max=%u", - _delete_lock_wait_cnt, _delete_lock_wait_max); - st->print_cr("_to_delete_list_cnt=%u, _to_delete_list_max=%u", - _to_delete_list_cnt, _to_delete_list_max); } // Print ThreadsList elements (4 per line). diff --git a/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java b/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java index 6c99215128fc9..23c133e4952fd 100644 --- a/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java +++ b/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -93,8 +93,10 @@ public static void main(String[] args) throws Exception { Pattern.compile("Current thread .* _threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*, _nested_threads_hazard_ptr_cnt=1, _nested_threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*.*"), // We should have a section of Threads class SMR info: Pattern.compile("Threads class SMR info:"), - // We should have one nested ThreadsListHandle: - Pattern.compile(".*, _nested_thread_list_max=1"), + // We should have had a double nested ThreadsListHandle since + // ThreadsSMRSupport::print_info_on() now protects itself with + // a ThreadsListHandle in addition to what the test creates: + Pattern.compile(".*, _nested_thread_list_max=2"), // The current thread (marked with '=>') in the threads list // should show a hazard ptr and a nested hazard ptr: Pattern.compile("=>.* JavaThread \"main\" .* _threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*, _nested_threads_hazard_ptr_cnt=1, _nested_threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*.*"), diff --git a/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java b/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java index 5bf766389b09c..ceadd67afecbb 100644 --- a/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java +++ b/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -93,6 +93,10 @@ public static void main(String[] args) throws Exception { Pattern.compile("Current thread .* _threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*, _nested_threads_hazard_ptr_cnt=0.*"), // We should have a section of Threads class SMR info: Pattern.compile("Threads class SMR info:"), + // We should have had a single nested ThreadsListHandle since + // ThreadsSMRSupport::print_info_on() now protects itself with + // a ThreadsListHandle: + Pattern.compile(".*, _nested_thread_list_max=1"), // The current thread (marked with '=>') in the threads list // should show a hazard ptr and no nested hazard ptrs: Pattern.compile("=>.* JavaThread \"main\" .* _threads_hazard_ptr=0x[0-9A-Fa-f][0-9A-Fa-f]*, _nested_threads_hazard_ptr_cnt=0.*"), From f6cb8c558b03dcd7dfa4261406eac7317ed9ed53 Mon Sep 17 00:00:00 2001 From: Harold Seigel Date: Wed, 6 Jan 2021 15:11:52 +0000 Subject: [PATCH 043/129] 8258908: Remove JVM option CleanChunkPoolAsync Reviewed-by: coleenp --- src/hotspot/share/gc/serial/defNewGeneration.cpp | 6 +----- src/hotspot/share/gc/shared/genCollectedHeap.cpp | 6 +----- src/hotspot/share/memory/arena.cpp | 7 +------ src/hotspot/share/memory/arena.hpp | 4 +--- src/hotspot/share/runtime/globals.hpp | 3 --- src/hotspot/share/runtime/thread.cpp | 4 +--- 6 files changed, 5 insertions(+), 25 deletions(-) diff --git a/src/hotspot/share/gc/serial/defNewGeneration.cpp b/src/hotspot/share/gc/serial/defNewGeneration.cpp index 296415542ad67..227f00fa916a3 100644 --- a/src/hotspot/share/gc/serial/defNewGeneration.cpp +++ b/src/hotspot/share/gc/serial/defNewGeneration.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2001, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -864,10 +864,6 @@ void DefNewGeneration::gc_epilogue(bool full) { to()->check_mangled_unused_area_complete(); } - if (!CleanChunkPoolAsync) { - Chunk::clean_chunk_pool(); - } - // update the generation and space performance counters update_counters(); gch->counters()->update_counters(); diff --git a/src/hotspot/share/gc/shared/genCollectedHeap.cpp b/src/hotspot/share/gc/shared/genCollectedHeap.cpp index 884a5bf89026a..4a7f03203c202 100644 --- a/src/hotspot/share/gc/shared/genCollectedHeap.cpp +++ b/src/hotspot/share/gc/shared/genCollectedHeap.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -1267,10 +1267,6 @@ void GenCollectedHeap::gc_epilogue(bool full) { GenGCEpilogueClosure blk(full); generation_iterate(&blk, false); // not old-to-young. - if (!CleanChunkPoolAsync) { - Chunk::clean_chunk_pool(); - } - MetaspaceCounters::update_performance_counters(); CompressedClassSpaceCounters::update_performance_counters(); }; diff --git a/src/hotspot/share/memory/arena.cpp b/src/hotspot/share/memory/arena.cpp index 504a1e5214a96..e7939d6f29e3a 100644 --- a/src/hotspot/share/memory/arena.cpp +++ b/src/hotspot/share/memory/arena.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -154,11 +154,6 @@ void chunkpool_init() { ChunkPool::initialize(); } -void -Chunk::clean_chunk_pool() { - ChunkPool::clean(); -} - //-------------------------------------------------------------------------------------- // ChunkPoolCleaner implementation diff --git a/src/hotspot/share/memory/arena.hpp b/src/hotspot/share/memory/arena.hpp index 621ce54e40cf8..89493b5f86399 100644 --- a/src/hotspot/share/memory/arena.hpp +++ b/src/hotspot/share/memory/arena.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2017, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -85,8 +85,6 @@ class Chunk: CHeapObj { // Start the chunk_pool cleaner task static void start_chunk_pool_cleaner_task(); - - static void clean_chunk_pool(); }; //------------------------------Arena------------------------------------------ diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp index 096f1943d6f32..7a9419ca9d5b1 100644 --- a/src/hotspot/share/runtime/globals.hpp +++ b/src/hotspot/share/runtime/globals.hpp @@ -167,9 +167,6 @@ const intx ObjectAlignmentInBytes = 8; "region.") \ range(1, max_uintx) \ \ - develop(bool, CleanChunkPoolAsync, true, \ - "Clean the chunk pool asynchronously") \ - \ product(uint, HandshakeTimeout, 0, DIAGNOSTIC, \ "If nonzero set a timeout in milliseconds for handshakes") \ \ diff --git a/src/hotspot/share/runtime/thread.cpp b/src/hotspot/share/runtime/thread.cpp index 980cd730afad3..b245926d6cf4b 100644 --- a/src/hotspot/share/runtime/thread.cpp +++ b/src/hotspot/share/runtime/thread.cpp @@ -3676,9 +3676,7 @@ jint Threads::create_vm(JavaVMInitArgs* args, bool* canTryAgain) { create_vm_init_libraries(); } - if (CleanChunkPoolAsync) { - Chunk::start_chunk_pool_cleaner_task(); - } + Chunk::start_chunk_pool_cleaner_task(); // Start the service thread // The service thread enqueues JVMTI deferred events and does various hashtable From 722f23610e128991e21ba1b56ddf2b7eec99e5c2 Mon Sep 17 00:00:00 2001 From: Lehua Ding Date: Wed, 6 Jan 2021 15:36:57 +0000 Subject: [PATCH 044/129] 8259231: Epsilon: improve performance under contention during virtual space expansion Reviewed-by: shade --- src/hotspot/share/gc/epsilon/epsilonHeap.cpp | 57 ++++++++++++-------- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/src/hotspot/share/gc/epsilon/epsilonHeap.cpp b/src/hotspot/share/gc/epsilon/epsilonHeap.cpp index 7e77026ac5a1b..bd937cffca474 100644 --- a/src/hotspot/share/gc/epsilon/epsilonHeap.cpp +++ b/src/hotspot/share/gc/epsilon/epsilonHeap.cpp @@ -106,31 +106,44 @@ EpsilonHeap* EpsilonHeap::heap() { HeapWord* EpsilonHeap::allocate_work(size_t size) { assert(is_object_aligned(size), "Allocation size should be aligned: " SIZE_FORMAT, size); - HeapWord* res = _space->par_allocate(size); + HeapWord* res = NULL; + while (true) { + // Try to allocate, assume space is available + res = _space->par_allocate(size); + if (res != NULL) { + break; + } - while (res == NULL) { // Allocation failed, attempt expansion, and retry: - MutexLocker ml(Heap_lock); - - size_t space_left = max_capacity() - capacity(); - size_t want_space = MAX2(size, EpsilonMinHeapExpand); - - if (want_space < space_left) { - // Enough space to expand in bulk: - bool expand = _virtual_space.expand_by(want_space); - assert(expand, "Should be able to expand"); - } else if (size < space_left) { - // No space to expand in bulk, and this allocation is still possible, - // take all the remaining space: - bool expand = _virtual_space.expand_by(space_left); - assert(expand, "Should be able to expand"); - } else { - // No space left: - return NULL; - } + { + MutexLocker ml(Heap_lock); - _space->set_end((HeapWord *) _virtual_space.high()); - res = _space->par_allocate(size); + // Try to allocate under the lock, assume another thread was able to expand + res = _space->par_allocate(size); + if (res != NULL) { + break; + } + + // Expand and loop back if space is available + size_t space_left = max_capacity() - capacity(); + size_t want_space = MAX2(size, EpsilonMinHeapExpand); + + if (want_space < space_left) { + // Enough space to expand in bulk: + bool expand = _virtual_space.expand_by(want_space); + assert(expand, "Should be able to expand"); + } else if (size < space_left) { + // No space to expand in bulk, and this allocation is still possible, + // take all the remaining space: + bool expand = _virtual_space.expand_by(space_left); + assert(expand, "Should be able to expand"); + } else { + // No space left: + return NULL; + } + + _space->set_end((HeapWord *) _virtual_space.high()); + } } size_t used = _space->used(); From d25a1bed5636bf983a3d464e16f06e1867d8fd12 Mon Sep 17 00:00:00 2001 From: Rafael Winterhalter Date: Wed, 6 Jan 2021 15:46:33 +0000 Subject: [PATCH 045/129] 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes Reviewed-by: jfranck --- .../classes/java/lang/reflect/Executable.java | 4 +- .../TestReceiverTypeOwnerType.java | 67 +++++++++++++++++++ 2 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 test/jdk/java/lang/annotation/typeAnnotations/TestReceiverTypeOwnerType.java diff --git a/src/java.base/share/classes/java/lang/reflect/Executable.java b/src/java.base/share/classes/java/lang/reflect/Executable.java index 3c4be628983ba..9375aa18fe734 100644 --- a/src/java.base/share/classes/java/lang/reflect/Executable.java +++ b/src/java.base/share/classes/java/lang/reflect/Executable.java @@ -707,7 +707,9 @@ Type parameterize(Class c) { Class ownerClass = c.getDeclaringClass(); TypeVariable[] typeVars = c.getTypeParameters(); - if (ownerClass == null) { // base case + // base case, static nested classes, according to JLS 8.1.3, has no + // enclosing instance, therefore its owner is not generified. + if (ownerClass == null || Modifier.isStatic(c.getModifiers())) { if (typeVars.length == 0) return c; else diff --git a/test/jdk/java/lang/annotation/typeAnnotations/TestReceiverTypeOwnerType.java b/test/jdk/java/lang/annotation/typeAnnotations/TestReceiverTypeOwnerType.java new file mode 100644 index 0000000000000..964d9ac5eaf65 --- /dev/null +++ b/test/jdk/java/lang/annotation/typeAnnotations/TestReceiverTypeOwnerType.java @@ -0,0 +1,67 @@ +/* + * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8259224 + * @summary A receiver type's owner type is of the correct type for nested classes. + */ + +import java.lang.reflect.AnnotatedParameterizedType; +import java.lang.reflect.AnnotatedType; + +public class TestReceiverTypeOwnerType { + + public static void main(String[] args) throws Exception { + AnnotatedType nested = Class.forName(TestReceiverTypeOwnerType.class.getTypeName() + "$Nested").getMethod("method").getAnnotatedReceiverType(); + if (!(nested instanceof AnnotatedParameterizedType)) { + throw new AssertionError(); + } else if (!(nested.getAnnotatedOwnerType() instanceof AnnotatedParameterizedType)) { + throw new AssertionError(); + } + AnnotatedType inner = Inner.class.getMethod("method").getAnnotatedReceiverType(); + if (inner instanceof AnnotatedParameterizedType) { + throw new AssertionError(); + } else if (inner.getAnnotatedOwnerType() instanceof AnnotatedParameterizedType) { + throw new AssertionError(); + } + AnnotatedType nestedInner = GenericInner.class.getMethod("method").getAnnotatedReceiverType(); + if (!(nestedInner instanceof AnnotatedParameterizedType)) { + throw new AssertionError(); + } else if (nestedInner.getAnnotatedOwnerType() instanceof AnnotatedParameterizedType) { + throw new AssertionError(); + } + } + + public class Nested { + public void method(TestReceiverTypeOwnerType.Nested this) { } + } + + public static class Inner { + public void method(TestReceiverTypeOwnerType.Inner this) { } + } + + public static class GenericInner { + public void method(TestReceiverTypeOwnerType.GenericInner this) { } + } +} From 3be6e06958c4304cafee707a29d06d6b2cc5b76b Mon Sep 17 00:00:00 2001 From: Rajan Halade Date: Wed, 6 Jan 2021 16:20:24 +0000 Subject: [PATCH 046/129] 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days Reviewed-by: mullan --- test/jdk/sun/security/lib/cacerts/VerifyCACerts.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java b/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java index 9178e5047ad51..814ded8a4f856 100644 --- a/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java +++ b/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java @@ -27,7 +27,7 @@ * @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923 8195774 8199779 * 8209452 8209506 8210432 8195793 8216577 8222089 8222133 8222137 8222136 * 8223499 8225392 8232019 8234245 8233223 8225068 8225069 8243321 8243320 - * 8243559 8225072 8258630 + * 8243559 8225072 8258630 8259312 * @summary Check root CA entries in cacerts file */ import java.io.ByteArrayInputStream; @@ -262,6 +262,8 @@ public class VerifyCACerts { add("luxtrustglobalrootca [jdk]"); // Valid until: Wed Mar 17 11:33:33 PDT 2021 add("quovadisrootca [jdk]"); + // Valid until: Tue Apr 06 00:29:40 PDT 2021 + add("soneraclass2ca [jdk]"); } }; From d20d2fa957fb1a4a0655dd3d2357cb34d97ab021 Mon Sep 17 00:00:00 2001 From: Joe Darcy Date: Wed, 6 Jan 2021 16:26:23 +0000 Subject: [PATCH 047/129] 8258143: Update --release 16 symbol information for JDK 16 build 30 or later Reviewed-by: iris, erikj --- make/data/symbols/java.desktop-G.sym.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/make/data/symbols/java.desktop-G.sym.txt b/make/data/symbols/java.desktop-G.sym.txt index 5b20574914328..186b90ac482ae 100644 --- a/make/data/symbols/java.desktop-G.sym.txt +++ b/make/data/symbols/java.desktop-G.sym.txt @@ -1,5 +1,5 @@ # -# Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -769,6 +769,9 @@ class name javax/swing/JList$AccessibleJList$AccessibleJListChild -method name getAccessibleAction descriptor ()Ljavax/accessibility/AccessibleAction; method name getAccessibleAction descriptor ()Ljavax/accessibility/AccessibleAction; flags 1 +class name javax/swing/JPasswordField +method name setText descriptor (Ljava/lang/String;)V flags 1 runtimeAnnotations @Ljava/beans/BeanProperty;(bound=Zfalse,description="the\u005C;u0020;text\u005C;u0020;of\u005C;u0020;this\u005C;u0020;component") + class name javax/swing/JSlider$AccessibleJSlider header extends javax/swing/JComponent$AccessibleJComponent implements javax/accessibility/AccessibleValue,javax/swing/event/ChangeListener nestHost javax/swing/JSlider flags 21 innerclass innerClass javax/swing/JSlider$AccessibleJSlider outerClass javax/swing/JSlider innerClassName AccessibleJSlider flags 4 From 4a5786b5532782e80c4f769bab9b127e261bade3 Mon Sep 17 00:00:00 2001 From: Naoto Sato Date: Wed, 6 Jan 2021 16:30:30 +0000 Subject: [PATCH 048/129] 8259075: Update the copyright notice in the files generated by CLDR Converter tool Reviewed-by: joehw --- .../tools/cldrconverter/CopyrightHeaders.java | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/make/jdk/src/classes/build/tools/cldrconverter/CopyrightHeaders.java b/make/jdk/src/classes/build/tools/cldrconverter/CopyrightHeaders.java index 89c7e0f41aa02..16062de116fc1 100644 --- a/make/jdk/src/classes/build/tools/cldrconverter/CopyrightHeaders.java +++ b/make/jdk/src/classes/build/tools/cldrconverter/CopyrightHeaders.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -41,14 +41,13 @@ class CopyrightHeaders { " * Copyright (c) 2012, %d, Oracle and/or its affiliates. All rights reserved.\n" + " */\n"; - // Last updated: - 6/06/2016, 1:42:31 PM + // Last updated: - 1/04/2021 private static final String UNICODE = "/*\n" + " * COPYRIGHT AND PERMISSION NOTICE\n" + " *\n" + - " * Copyright (C) 1991-2016 Unicode, Inc. All rights reserved.\n" + - " * Distributed under the Terms of Use in \n" + - " * http://www.unicode.org/copyright.html.\n" + + " * Copyright (c) 1991-2020 Unicode, Inc. All rights reserved.\n" + + " * Distributed under the Terms of Use in https://www.unicode.org/copyright.html.\n" + " *\n" + " * Permission is hereby granted, free of charge, to any person obtaining\n" + " * a copy of the Unicode data files and any associated documentation\n" + @@ -57,14 +56,11 @@ class CopyrightHeaders { " * without restriction, including without limitation the rights to use,\n" + " * copy, modify, merge, publish, distribute, and/or sell copies of\n" + " * the Data Files or Software, and to permit persons to whom the Data Files\n" + - " * or Software are furnished to do so, provided that\n" + - " * (a) this copyright and permission notice appear with all copies \n" + - " * of the Data Files or Software,\n" + - " * (b) this copyright and permission notice appear in associated \n" + - " * documentation, and\n" + - " * (c) there is clear notice in each modified Data File or in the Software\n" + - " * as well as in the documentation associated with the Data File(s) or\n" + - " * Software that the data or software has been modified.\n" + + " * or Software are furnished to do so, provided that either\n" + + " * (a) this copyright and permission notice appear with all copies\n" + + " * of the Data Files or Software, or\n" + + " * (b) this copyright and permission notice appear in associated\n" + + " * Documentation.\n" + " *\n" + " * THE DATA FILES AND SOFTWARE ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF\n" + " * ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE\n" + From f1bc4e05a44b9054f2387977c6f362ccb304df1c Mon Sep 17 00:00:00 2001 From: Rajan Halade Date: Wed, 6 Jan 2021 16:39:08 +0000 Subject: [PATCH 049/129] 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days Backport-of: 3be6e06958c4304cafee707a29d06d6b2cc5b76b --- test/jdk/sun/security/lib/cacerts/VerifyCACerts.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java b/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java index 9178e5047ad51..814ded8a4f856 100644 --- a/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java +++ b/test/jdk/sun/security/lib/cacerts/VerifyCACerts.java @@ -27,7 +27,7 @@ * @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923 8195774 8199779 * 8209452 8209506 8210432 8195793 8216577 8222089 8222133 8222137 8222136 * 8223499 8225392 8232019 8234245 8233223 8225068 8225069 8243321 8243320 - * 8243559 8225072 8258630 + * 8243559 8225072 8258630 8259312 * @summary Check root CA entries in cacerts file */ import java.io.ByteArrayInputStream; @@ -262,6 +262,8 @@ public class VerifyCACerts { add("luxtrustglobalrootca [jdk]"); // Valid until: Wed Mar 17 11:33:33 PDT 2021 add("quovadisrootca [jdk]"); + // Valid until: Tue Apr 06 00:29:40 PDT 2021 + add("soneraclass2ca [jdk]"); } }; From df721f0c69d143e13ff025ec9c305fcce2e0b925 Mon Sep 17 00:00:00 2001 From: Xue-Lei Andrew Fan Date: Wed, 6 Jan 2021 16:57:17 +0000 Subject: [PATCH 050/129] 8259291: Cleanup unnecessary local variables Reviewed-by: mullan --- .../share/classes/sun/security/ssl/Finished.java | 6 ++---- .../share/classes/sun/security/ssl/OutputRecord.java | 7 +++---- .../share/classes/sun/security/ssl/SSLExtension.java | 5 ++--- .../classes/sun/security/ssl/SSLSocketOutputRecord.java | 8 +++----- .../classes/sun/security/ssl/ServerNameExtension.java | 3 +-- .../sun/security/ssl/SignatureAlgorithmsExtension.java | 3 +-- 6 files changed, 12 insertions(+), 20 deletions(-) diff --git a/src/java.base/share/classes/sun/security/ssl/Finished.java b/src/java.base/share/classes/sun/security/ssl/Finished.java index 01fdf4766415e..2e52d30992cf3 100644 --- a/src/java.base/share/classes/sun/security/ssl/Finished.java +++ b/src/java.base/share/classes/sun/security/ssl/Finished.java @@ -265,8 +265,7 @@ public byte[] createVerifyData(HandshakeContext context, "Invalid PRF output, format must be RAW. " + "Format received: " + prfKey.getFormat()); } - byte[] finished = prfKey.getEncoded(); - return finished; + return prfKey.getEncoded(); } catch (GeneralSecurityException e) { throw new RuntimeException("PRF failed", e); } @@ -317,8 +316,7 @@ public byte[] createVerifyData(HandshakeContext context, "Invalid PRF output, format must be RAW. " + "Format received: " + prfKey.getFormat()); } - byte[] finished = prfKey.getEncoded(); - return finished; + return prfKey.getEncoded(); } catch (GeneralSecurityException e) { throw new RuntimeException("PRF failed", e); } diff --git a/src/java.base/share/classes/sun/security/ssl/OutputRecord.java b/src/java.base/share/classes/sun/security/ssl/OutputRecord.java index 41cf0bc24129b..9aa7f95876591 100644 --- a/src/java.base/share/classes/sun/security/ssl/OutputRecord.java +++ b/src/java.base/share/classes/sun/security/ssl/OutputRecord.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -474,8 +474,7 @@ private long t13Encrypt( } byte[] sequenceNumber = encCipher.authenticator.sequenceNumber(); - int position = headerSize; - int contentLen = count - position; + int contentLen = count - headerSize; // ensure the capacity int requiredPacketSize = @@ -495,7 +494,7 @@ private long t13Encrypt( pv = ProtocolVersion.TLS12; } - ByteBuffer destination = ByteBuffer.wrap(buf, position, contentLen); + ByteBuffer destination = ByteBuffer.wrap(buf, headerSize, contentLen); count = headerSize + encCipher.encrypt(contentType, destination); // Fill out the header, write it and the message. diff --git a/src/java.base/share/classes/sun/security/ssl/SSLExtension.java b/src/java.base/share/classes/sun/security/ssl/SSLExtension.java index 05ee5ff399fbf..fe4a1f77e4469 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLExtension.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLExtension.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -674,8 +674,7 @@ public String toString( String extData; if (stringizer == null) { HexDumpEncoder hexEncoder = new HexDumpEncoder(); - String encoded = hexEncoder.encode(byteBuffer.duplicate()); - extData = encoded; + extData = hexEncoder.encode(byteBuffer.duplicate()); } else { extData = stringizer.toString(handshakeContext, byteBuffer); } diff --git a/src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java b/src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java index 97a65ba987d72..db8b7ad84d93c 100644 --- a/src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java +++ b/src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -63,8 +63,7 @@ void encodeAlert(byte level, byte description) throws IOException { } // use the buf of ByteArrayOutputStream - int position = headerSize + writeCipher.getExplicitNonceSize(); - count = position; + count = headerSize + writeCipher.getExplicitNonceSize(); write(level); write(description); @@ -221,8 +220,7 @@ void encodeChangeCipherSpec() throws IOException { } // use the buf of ByteArrayOutputStream - int position = headerSize + writeCipher.getExplicitNonceSize(); - count = position; + count = headerSize + writeCipher.getExplicitNonceSize(); write((byte)1); // byte 1: change_cipher_spec( diff --git a/src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java b/src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java index 7acc3a9911e0b..74f38bf5b56c4 100644 --- a/src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java +++ b/src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,7 +30,6 @@ import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.Collection; -import java.util.Collections; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; diff --git a/src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java b/src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java index f0bd183aff0ac..9c451baa12b23 100644 --- a/src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java +++ b/src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2020, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -29,7 +29,6 @@ import java.nio.ByteBuffer; import java.text.MessageFormat; import java.util.Arrays; -import java.util.LinkedList; import java.util.List; import java.util.Locale; import javax.net.ssl.SSLProtocolException; From 940b053065de788e44ef0d7f6fab901f8f0dfb40 Mon Sep 17 00:00:00 2001 From: Phil Race Date: Wed, 6 Jan 2021 17:34:15 +0000 Subject: [PATCH 051/129] 8259232: Bad JNI lookup during printing Reviewed-by: psadhukhan --- src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m | 2 +- test/jdk/java/awt/print/bug8023392/bug8023392.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m b/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m index 201ec6db56410..e8246be951c67 100644 --- a/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m +++ b/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m @@ -58,7 +58,7 @@ #define GET_CPRINTERDIALOG_METHOD_RETURN(ret) \ GET_CPRINTERDIALOG_CLASS_RETURN(ret); \ - GET_METHOD_RETURN(sjm_printerJob, sjc_CPrinterDialog, "fPrinterJob", "Lsun/lwawt/macosx/CPrinterJob;", ret); + GET_FIELD_RETURN(sjm_printerJob, sjc_CPrinterDialog, "fPrinterJob", "Lsun/lwawt/macosx/CPrinterJob;", ret); static NSPrintInfo* createDefaultNSPrintInfo(); diff --git a/test/jdk/java/awt/print/bug8023392/bug8023392.java b/test/jdk/java/awt/print/bug8023392/bug8023392.java index 440de96a06186..071c9021ddffb 100644 --- a/test/jdk/java/awt/print/bug8023392/bug8023392.java +++ b/test/jdk/java/awt/print/bug8023392/bug8023392.java @@ -23,7 +23,7 @@ /* test - @bug 8023392 + @bug 8023392 8259232 @summary Swing text components printed with spaces between chars @author Anton Nashatyrev @run applet/manual=yesno bug8023392.html From 80544e4d5f402f67171eb5aca11897f1c5c3d431 Mon Sep 17 00:00:00 2001 From: Joe Darcy Date: Wed, 6 Jan 2021 18:05:33 +0000 Subject: [PATCH 052/129] 8250564: Remove terminally deprecated constructor in GSSUtil 8250565: Remove terminally deprecated constructor in java.net.URLDecoder Reviewed-by: bpb, smarks, alanb, mullan --- src/java.base/share/classes/java/net/URLDecoder.java | 3 +-- .../share/classes/com/sun/security/jgss/GSSUtil.java | 3 +-- test/jdk/java/net/URLDecoder/B6463990.java | 5 ++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/java.base/share/classes/java/net/URLDecoder.java b/src/java.base/share/classes/java/net/URLDecoder.java index 511e74022b190..0003778860a18 100644 --- a/src/java.base/share/classes/java/net/URLDecoder.java +++ b/src/java.base/share/classes/java/net/URLDecoder.java @@ -84,8 +84,7 @@ public class URLDecoder { /** * Do not call. */ - @Deprecated(since="16", forRemoval=true) - public URLDecoder() {} + private URLDecoder() {} // The platform default encoding static String dfltEncName = URLEncoder.dfltEncName; diff --git a/src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java b/src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java index 0669596800d12..b94e2877f0800 100644 --- a/src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java +++ b/src/jdk.security.jgss/share/classes/com/sun/security/jgss/GSSUtil.java @@ -37,8 +37,7 @@ public class GSSUtil { /** * Do not call. */ - @Deprecated(since="16", forRemoval=true) - public GSSUtil() {} + private GSSUtil() {} /** * Use this method to convert a GSSName and GSSCredential into a diff --git a/test/jdk/java/net/URLDecoder/B6463990.java b/test/jdk/java/net/URLDecoder/B6463990.java index c49f9d6404551..76f78b05772e7 100644 --- a/test/jdk/java/net/URLDecoder/B6463990.java +++ b/test/jdk/java/net/URLDecoder/B6463990.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -32,8 +32,7 @@ public class B6463990 { public static void main(String[] args) { boolean except = false; try { - URLDecoder ud = new java.net.URLDecoder(); - String s = ud.decode("%-1", "iso-8859-1"); + String s = URLDecoder.decode("%-1", "iso-8859-1"); System.out.println((int) s.charAt(0)); } catch (Exception e) { except = true; From eef43be71ce84514c733e0889317009d2ca11de7 Mon Sep 17 00:00:00 2001 From: Jonathan Gibbons Date: Wed, 6 Jan 2021 18:52:59 +0000 Subject: [PATCH 053/129] 8251200: False positive messages about missing comments for serialization Reviewed-by: hannesw --- .../builders/SerializedFormBuilder.java | 2 +- .../internal/doclets/toolkit/util/Utils.java | 60 ++++++++------ .../testSerialMissing/TestSerialMissing.java | 78 +++++++++++++++++++ 3 files changed, 117 insertions(+), 23 deletions(-) create mode 100644 test/langtools/jdk/javadoc/doclet/testSerialMissing/TestSerialMissing.java diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java index 2516073ee5b03..cabc48511ff59 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java @@ -550,7 +550,7 @@ private static boolean serialClassInclude(Utils utils, TypeElement te) { return false; } if (utils.isSerializable(te)) { - if (!utils.getSerialTrees(te).isEmpty()) { + if (utils.hasDocCommentTree(te) && !utils.getSerialTrees(te).isEmpty()) { return serialDocInclude(utils, te); } else if (utils.isPublic(te) || utils.isProtected(te)) { return true; diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java index 28824ad72052b..9987570d922e5 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java @@ -2685,6 +2685,16 @@ public TreePath getTreePath(Element e) { */ private final Map dcTreeCache = new LinkedHashMap<>(); + /** + * Checks whether an element has an associated doc comment. + * @param element the element + * @return {@code true} if the element has a comment, and false otherwise + */ + public boolean hasDocCommentTree(Element element) { + DocCommentInfo info = getDocCommentInfo(element); + return info != null && info.dcTree != null; + } + /** * Retrieves the doc comments for a given element. * @param element @@ -2692,28 +2702,7 @@ public TreePath getTreePath(Element e) { */ public DocCommentTree getDocCommentTree0(Element element) { - DocCommentInfo info = null; - - ElementKind kind = element.getKind(); - if (kind == ElementKind.PACKAGE || kind == ElementKind.OTHER) { - info = dcTreeCache.get(element); // local cache - if (info == null && kind == ElementKind.PACKAGE) { - // package-info.java - info = getDocCommentInfo(element); - } - if (info == null) { - // package.html or overview.html - info = configuration.cmtUtils.getHtmlCommentInfo(element); // html source - } - } else { - info = configuration.cmtUtils.getSyntheticCommentInfo(element); - if (info == null) { - info = dcTreeCache.get(element); // local cache - } - if (info == null) { - info = getDocCommentInfo(element); // get the real mccoy - } - } + DocCommentInfo info = getDocCommentInfo(element); DocCommentTree docCommentTree = info == null ? null : info.dcTree; if (!dcTreeCache.containsKey(element)) { @@ -2738,6 +2727,33 @@ public DocCommentTree getDocCommentTree0(Element element) { } private DocCommentInfo getDocCommentInfo(Element element) { + DocCommentInfo info = null; + + ElementKind kind = element.getKind(); + if (kind == ElementKind.PACKAGE || kind == ElementKind.OTHER) { + info = dcTreeCache.get(element); // local cache + if (info == null && kind == ElementKind.PACKAGE) { + // package-info.java + info = getDocCommentInfo0(element); + } + if (info == null) { + // package.html or overview.html + info = configuration.cmtUtils.getHtmlCommentInfo(element); // html source + } + } else { + info = configuration.cmtUtils.getSyntheticCommentInfo(element); + if (info == null) { + info = dcTreeCache.get(element); // local cache + } + if (info == null) { + info = getDocCommentInfo0(element); // get the real mccoy + } + } + + return info; + } + + private DocCommentInfo getDocCommentInfo0(Element element) { // prevent nasty things downstream with overview element if (element.getKind() != ElementKind.OTHER) { TreePath path = getTreePath(element); diff --git a/test/langtools/jdk/javadoc/doclet/testSerialMissing/TestSerialMissing.java b/test/langtools/jdk/javadoc/doclet/testSerialMissing/TestSerialMissing.java new file mode 100644 index 0000000000000..b0210468dc56c --- /dev/null +++ b/test/langtools/jdk/javadoc/doclet/testSerialMissing/TestSerialMissing.java @@ -0,0 +1,78 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8251200 + * @summary False positive messages about missing comments for serialization + * @library /tools/lib ../../lib/ + * @modules jdk.javadoc/jdk.javadoc.internal.api + * jdk.javadoc/jdk.javadoc.internal.tool + * @build javadoc.tester.* + * @build toolbox.ToolBox javadoc.tester.* + * @run main TestSerialMissing + */ + +import java.io.IOException; +import java.nio.file.Path; + +import javadoc.tester.JavadocTester; +import toolbox.ToolBox; + +public class TestSerialMissing extends JavadocTester { + public static void main(String... args) throws Exception { + TestSerialMissing tester = new TestSerialMissing(); + tester.runTests(m -> new Object[] { Path.of(m.getName()) } ); + } + + ToolBox tb = new ToolBox(); + + @Test + public void testPackagePrivate(Path base) throws IOException { + Path src = base.resolve("src"); + tb.writeJavaFiles(src, + """ + /** Module m. */ + module m { exports p; } + """, + """ + package p; + /** PUBLIC class. */ + public class PUBLIC extends Exception { } + """, + """ + package p; + // no comment: class should not be documented + class PACKAGE_PRIVATE extends Exception { } + """); + + javadoc("-d", base.resolve("api").toString(), + "-sourcepath", src.toString(), + "--module", "m"); + checkExit(Exit.OK); + + // should not be any reference to PACKAGE_PRIVATE.java, such as for no comment + checkOutput(Output.OUT, false, + "PACKAGE_PRIVATE"); + } +} \ No newline at end of file From 4f914e21c4b9447b3a32820a23fed49d2719316c Mon Sep 17 00:00:00 2001 From: Jonathan Gibbons Date: Wed, 6 Jan 2021 19:26:17 +0000 Subject: [PATCH 054/129] 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description Reviewed-by: hannesw --- .../builders/MemberSummaryBuilder.java | 6 +- .../internal/doclets/toolkit/util/Utils.java | 18 +++--- .../javadoc/doclet/testJavaFX/TestJavaFX.java | 58 ++++++++++++++++++- 3 files changed, 72 insertions(+), 10 deletions(-) diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java index 2e593830faf04..2c6641d9a6e5f 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java @@ -46,6 +46,7 @@ import jdk.javadoc.internal.doclets.toolkit.WriterFactory; import jdk.javadoc.internal.doclets.toolkit.util.CommentHelper; import jdk.javadoc.internal.doclets.toolkit.util.DocFinder; +import jdk.javadoc.internal.doclets.toolkit.util.Utils; import jdk.javadoc.internal.doclets.toolkit.util.VisibleMemberTable; import jdk.javadoc.internal.doclets.toolkit.CommentUtils; @@ -507,7 +508,10 @@ private void addToPropertiesMap(Element propertyMethod, if (null == propertyMethod || null == commentSource) { return; } - DocCommentTree docTree = builder.utils.getDocCommentTree(propertyMethod); + Utils utils = builder.utils; + DocCommentTree docTree = utils.hasDocCommentTree(propertyMethod) + ? utils.getDocCommentTree(propertyMethod) + : null; /* The second condition is required for the property buckets. In * this case the comment is at the property method (not at the field) diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java index 9987570d922e5..7bf29be9df0e4 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java @@ -2637,14 +2637,16 @@ public boolean hasBlockTag(Element element, DocTree.Kind kind) { } public boolean hasBlockTag(Element element, DocTree.Kind kind, final String tagName) { - CommentHelper ch = getCommentHelper(element); - String tname = tagName != null && tagName.startsWith("@") - ? tagName.substring(1) - : tagName; - for (DocTree dt : getBlockTags(element, kind)) { - if (dt.getKind() == kind) { - if (tname == null || ch.getTagName(dt).equals(tname)) { - return true; + if (hasDocCommentTree(element)) { + CommentHelper ch = getCommentHelper(element); + String tname = tagName != null && tagName.startsWith("@") + ? tagName.substring(1) + : tagName; + for (DocTree dt : getBlockTags(element, kind)) { + if (dt.getKind() == kind) { + if (tname == null || ch.getTagName(dt).equals(tname)) { + return true; + } } } } diff --git a/test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java b/test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java index 2ac83d830b17c..652d8893f4d10 100644 --- a/test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java +++ b/test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java @@ -25,7 +25,7 @@ * @test * @bug 7112427 8012295 8025633 8026567 8061305 8081854 8150130 8162363 * 8167967 8172528 8175200 8178830 8182257 8186332 8182765 8025091 - * 8203791 8184205 + * 8203791 8184205 8249633 * @summary Test of the JavaFX doclet features. * @library ../../lib * @modules jdk.javadoc/jdk.javadoc.internal.tool @@ -33,6 +33,10 @@ * @run main TestJavaFX */ +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; + import javadoc.tester.JavadocTester; public class TestJavaFX extends JavadocTester { @@ -366,4 +370,56 @@ public void test4() { // make sure the doclet indeed emits the warning checkOutput(Output.OUT, true, "C.java:0: warning - invalid usage of tag <"); } + + /* + * Verify that no warnings are produced on methods that may have synthesized comments. + */ + @Test + public void test5() throws IOException { + Path src5 = Files.createDirectories(Path.of("src5").resolve("pkg")); + Files.writeString(src5.resolve("MyClass.java"), + """ + package pkg; + + // The following import not required with --disable-javafx-strict-checks + // import javafx.beans.property.*; + + /** + * This is my class. + */ + public class MyClass { + /** + * This is my property that enables something + */ + private BooleanProperty something = new SimpleBooleanProperty(false); + + public final boolean isSomething() { + return something.get(); + } + + public final void setSomething(boolean val) { + something.set(val); + } + + public final BooleanProperty somethingProperty() { + return something; + } + + /** Dummy declaration. */ + public class BooleanProperty { } + } + """); + + javadoc("-d", "out5", + "--javafx", + "--disable-javafx-strict-checks", + "-Xdoclint:all", + "--source-path", "src5", + "pkg"); + checkExit(Exit.OK); + + checkOutput(Output.OUT, false, + "warning", + "no comment"); + } } From 28e1f4d9eebd148c4a7e5c83a5141e8acc7ccced Mon Sep 17 00:00:00 2001 From: Yoshiki Sato Date: Wed, 6 Jan 2021 22:48:00 +0000 Subject: [PATCH 055/129] 8247957: remove doclint support for HTML 4 8257204: Remove usage of -Xhtmlversion option from javac 8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option 8258460: Remove --doclint-format option from javac 8256312: Valid anchor 'id' value not allowed Reviewed-by: jjg, ihse --- make/common/JavaCompilation.gmk | 2 +- .../com/sun/tools/doclint/DocLint.java | 1 - .../com/sun/tools/javac/main/Arguments.java | 5 - .../com/sun/tools/javac/main/Option.java | 2 - .../tools/javac/resources/javac.properties | 3 - .../doclets/toolkit/BaseConfiguration.java | 2 - .../jdk/javadoc/internal/doclint/Checker.java | 97 +++----- .../jdk/javadoc/internal/doclint/DocLint.java | 17 -- .../jdk/javadoc/internal/doclint/Env.java | 8 +- .../jdk/javadoc/internal/doclint/HtmlTag.java | 199 ++++++++-------- .../javadoc/internal/doclint/HtmlVersion.java | 49 ---- .../doclint/resources/doclint.properties | 11 +- .../doclint/resources/doclint_ja.properties | 8 +- .../resources/doclint_zh_CN.properties | 8 +- .../TestHtmlTableStyles.java | 2 +- .../tools/doclint/AccessibilityTest.java | 15 +- .../tools/doclint/AccessibilityTest.out | 2 +- .../tools/doclint/AccessibilityTest5.java | 30 --- .../tools/doclint/AccessibilityTest5.out | 4 - test/langtools/tools/doclint/AnchorTest.java | 35 +-- test/langtools/tools/doclint/AnchorTest.out | 44 ++-- test/langtools/tools/doclint/AnchorTest2.java | 8 +- test/langtools/tools/doclint/AnchorTest2.out | 2 +- .../langtools/tools/doclint/AnchorTest2a.java | 2 +- test/langtools/tools/doclint/EndTagsTest.java | 6 +- .../tools/doclint/HtmlAttrsTest.java | 2 +- .../langtools/tools/doclint/HtmlAttrsTest.out | 9 +- .../langtools/tools/doclint/HtmlTagsTest.java | 2 +- test/langtools/tools/doclint/HtmlTagsTest.out | 5 +- .../tools/doclint/HtmlVersionTest.java | 41 ---- .../tools/doclint/anchorTests/p/Test.java | 38 +-- .../tools/doclint/anchorTests/p/Test.out | 12 +- .../doclint/anchorTests/p/package-info.java | 8 +- .../anchorTests/p/package-info.javac.out | 4 +- .../doclint/anchorTests/p/package-info.out | 10 +- .../html/HtmlVersionTagsAttrsTest.java | 13 +- ...Html5.out => HtmlVersionTagsAttrsTest.out} | 219 ++++++++++-------- .../html/HtmlVersionTagsAttrsTestHtml4.out | 212 ----------------- .../tools/doclint/html/InlineTagTest.out | 10 + .../tools/doclint/html/InlineTagsTest.java | 4 +- .../tools/doclint/html/OtherTagsTest.java | 2 +- .../tools/doclint/html/OtherTagsTest.out | 11 +- .../tools/doclint/html/TableTagTest.out | 22 ++ .../tools/doclint/html/TableTagsTest.java | 4 +- .../tools/doclint/html/TagNotAllowed.java | 2 +- .../tools/doclint/html/TagNotAllowed.out | 19 +- .../tools/doclint/html/TextNotAllowed.java | 22 +- .../tools/doclint/html/TextNotAllowed.out | 40 ++-- .../doclint/tidy/AnchorAlreadyDefined.java | 6 +- .../doclint/tidy/AnchorAlreadyDefined.out | 2 +- test/langtools/tools/doclint/tidy/BadEnd.java | 4 +- test/langtools/tools/doclint/tidy/BadEnd.out | 6 +- .../tools/doclint/tidy/InvalidName.java | 11 +- .../tools/doclint/tidy/InvalidName.out | 4 +- .../tools/doclint/tidy/TextNotAllowed.java | 8 +- .../tools/doclint/tidy/TextNotAllowed.out | 12 +- .../tools/doclint/tidy/TrimmingEmptyTag.java | 5 +- .../tools/doclint/tidy/TrimmingEmptyTag.out | 37 ++- .../javac/doclint/DocLintFormatTest.java | 17 +- 59 files changed, 494 insertions(+), 891 deletions(-) delete mode 100644 src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlVersion.java delete mode 100644 test/langtools/tools/doclint/AccessibilityTest5.java delete mode 100644 test/langtools/tools/doclint/AccessibilityTest5.out delete mode 100644 test/langtools/tools/doclint/HtmlVersionTest.java rename test/langtools/tools/doclint/html/{HtmlVersionTagsAttrsTestHtml5.out => HtmlVersionTagsAttrsTest.out} (65%) delete mode 100644 test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTestHtml4.out create mode 100644 test/langtools/tools/doclint/html/InlineTagTest.out create mode 100644 test/langtools/tools/doclint/html/TableTagTest.out diff --git a/make/common/JavaCompilation.gmk b/make/common/JavaCompilation.gmk index 1d25dc6dbeba3..cb93131a124ee 100644 --- a/make/common/JavaCompilation.gmk +++ b/make/common/JavaCompilation.gmk @@ -269,7 +269,7 @@ define SetupJavaCompilationBody # Tell javac to do exactly as told and no more PARANOIA_FLAGS := -implicit:none -Xprefer:source -XDignore.symbol.file=true -encoding ascii - $1_FLAGS += -g -Xlint:all --doclint-format html5 $$($1_TARGET_RELEASE) $$(PARANOIA_FLAGS) $$(JAVA_WARNINGS_ARE_ERRORS) + $1_FLAGS += -g -Xlint:all $$($1_TARGET_RELEASE) $$(PARANOIA_FLAGS) $$(JAVA_WARNINGS_ARE_ERRORS) $1_FLAGS += $$($1_JAVAC_FLAGS) ifneq ($$($1_DISABLED_WARNINGS), ) diff --git a/src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java b/src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java index f4e6e241bbe7b..0a52e70169aca 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java @@ -41,7 +41,6 @@ public abstract class DocLint implements Plugin { public static final String XMSGS_OPTION = "-Xmsgs"; public static final String XMSGS_CUSTOM_PREFIX = "-Xmsgs:"; - public static final String XHTML_VERSION_PREFIX = "-XhtmlVersion:"; public static final String XCHECK_PACKAGE = "-XcheckPackage:"; private static ServiceLoader.Provider docLintProvider; diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java index 00e2d435ddc18..2c67eb1b8193f 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java @@ -853,11 +853,6 @@ public List getDocLintOpts() { doclintOpts.add(DocLint.XCHECK_PACKAGE + checkPackages); } - String format = options.get(Option.DOCLINT_FORMAT); - if (format != null) { - doclintOpts.add(DocLint.XHTML_VERSION_PREFIX + format); - } - return List.from(doclintOpts.toArray(new String[doclintOpts.size()])); } diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java index a12db6ce668b3..2eae5da0b6c74 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java @@ -159,8 +159,6 @@ public void process(OptionHelper helper, String option, String arg) { } }, - DOCLINT_FORMAT("--doclint-format", "opt.doclint.format", EXTENDED, BASIC, ONEOF, "html5"), - // -nowarn is retained for command-line backward compatibility NOWARN("-nowarn", "opt.nowarn", STANDARD, BASIC) { @Override diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties b/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties index 4bb02bd8a5d73..4264a2e12a554 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties @@ -286,9 +286,6 @@ javac.opt.Xdoclint.package.desc=\ expands to all sub-packages of the given package. Each can be prefixed\n\ with '-' to disable checks for the specified package or packages. -javac.opt.doclint.format=\ - Specify the format for documentation comments - javac.opt.Xstdout=\ Redirect standard output javac.opt.X=\ diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java index ef785603a5e8d..f65462eb92d78 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java @@ -798,8 +798,6 @@ public void initDocLint(List opts, Set customTagNames) { doclintOpts.add(DocLint.XCUSTOM_TAGS_PREFIX + customTags); } - doclintOpts.add(DocLint.XHTML_VERSION_PREFIX + "html5"); - doclint = new DocLint(); doclint.init(docEnv.getDocTrees(), docEnv.getElementUtils(), docEnv.getTypeUtils(), doclintOpts.toArray(new String[0])); diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java index f9286d532ce99..2cbb48518ad94 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java @@ -91,6 +91,7 @@ import com.sun.tools.javac.util.DefinedBy.Api; import jdk.javadoc.internal.doclint.HtmlTag.AttrKind; +import jdk.javadoc.internal.doclint.HtmlTag.ElemKind; import static jdk.javadoc.internal.doclint.Messages.Group.*; @@ -324,8 +325,8 @@ public Void visitStartElement(StartElementTree tree, Void ignore) { final HtmlTag t = HtmlTag.get(treeName); if (t == null) { env.messages.error(HTML, tree, "dc.tag.unknown", treeName); - } else if (t.allowedVersion != HtmlVersion.ALL && t.allowedVersion != env.htmlVersion) { - env.messages.error(HTML, tree, "dc.tag.not.supported", treeName); + } else if (t.elemKind == ElemKind.HTML4) { + env.messages.error(HTML, tree, "dc.tag.not.supported.html5", treeName); } else { boolean done = false; for (TagStackItem tsi: tagStack) { @@ -413,8 +414,7 @@ public Void visitStartElement(StartElementTree tree, Void ignore) { // so-called "self-closing" tags are only permitted in HTML 5, for void elements // https://html.spec.whatwg.org/multipage/syntax.html#start-tags private boolean isSelfClosingAllowed(HtmlTag tag) { - return env.htmlVersion == HtmlVersion.HTML5 - && tag.endKind == HtmlTag.EndKind.NONE; + return tag.endKind == HtmlTag.EndKind.NONE; } private void checkStructure(StartElementTree tree, HtmlTag t) { @@ -535,7 +535,7 @@ public Void visitEndElement(EndElementTree tree, Void ignore) { case SECTION: case ARTICLE: - if (env.htmlVersion == HtmlVersion.HTML5 && !top.flags.contains(Flag.HAS_HEADING)) { + if (!top.flags.contains(Flag.HAS_HEADING)) { env.messages.error(HTML, tree, "dc.tag.requires.heading", treeName); } break; @@ -579,7 +579,8 @@ void warnIfEmpty(TagStackItem tsi, DocTree endTree) { if (tsi.tag.flags.contains(HtmlTag.Flag.EXPECT_CONTENT) && !tsi.flags.contains(Flag.HAS_TEXT) && !tsi.flags.contains(Flag.HAS_ELEMENT) - && !tsi.flags.contains(Flag.HAS_INLINE_TAG)) { + && !tsi.flags.contains(Flag.HAS_INLINE_TAG) + && !(tsi.tag.elemKind == ElemKind.HTML4)) { DocTree tree = (endTree != null) ? endTree : tsi.tree; Name treeName = ((StartElementTree) tsi.tree).getName(); env.messages.warning(HTML, tree, "dc.tag.empty", treeName); @@ -594,13 +595,10 @@ void warnIfEmpty(TagStackItem tsi, DocTree endTree) { @Override @DefinedBy(Api.COMPILER_TREE) @SuppressWarnings("fallthrough") public Void visitAttribute(AttributeTree tree, Void ignore) { HtmlTag currTag = tagStack.peek().tag; - if (currTag != null) { + if (currTag != null && currTag.elemKind != ElemKind.HTML4) { Name name = tree.getName(); HtmlTag.Attr attr = currTag.getAttr(name); if (attr != null) { - if (env.htmlVersion == HtmlVersion.HTML4 && attr.name().contains("-")) { - env.messages.error(HTML, tree, "dc.attr.not.supported.html4", name); - } boolean first = tagStack.peek().attrs.add(attr); if (!first) env.messages.error(HTML, tree, "dc.attr.repeated", name); @@ -609,30 +607,29 @@ public Void visitAttribute(AttributeTree tree, Void ignore) { // without checking the validity or applicability of the name if (!name.toString().startsWith("on")) { AttrKind k = currTag.getAttrKind(name); - switch (env.htmlVersion) { + switch (k) { + case OK: + break; + case OBSOLETE: + env.messages.warning(HTML, tree, "dc.attr.obsolete", name); + break; case HTML4: - validateHtml4Attrs(tree, name, k); + env.messages.error(HTML, tree, "dc.attr.not.supported.html5", name); break; - - case HTML5: - validateHtml5Attrs(tree, name, k); + case INVALID: + env.messages.error(HTML, tree, "dc.attr.unknown", name); break; } } if (attr != null) { switch (attr) { - case NAME: - if (currTag != HtmlTag.A) { - break; - } - // fallthrough case ID: String value = getAttrValue(tree); if (value == null) { env.messages.error(HTML, tree, "dc.anchor.value.missing"); } else { - if (!validName.matcher(value).matches()) { + if (!validId.matcher(value).matches()) { env.messages.error(HTML, tree, "dc.invalid.anchor", value); } if (!checkAnchor(value)) { @@ -674,12 +671,20 @@ public Void visitAttribute(AttributeTree tree, Void ignore) { if (currTag == HtmlTag.TABLE) { String v = getAttrValue(tree); try { - if (env.htmlVersion == HtmlVersion.HTML5 - && (v == null || (!v.isEmpty() && Integer.parseInt(v) != 1))) { - env.messages.error(HTML, tree, "dc.attr.table.border.html5", attr); + if (v == null || (!v.isEmpty() && Integer.parseInt(v) != 1)) { + env.messages.error(HTML, tree, "dc.attr.table.border.not.valid", attr); + } + } catch (NumberFormatException ex) { + env.messages.error(HTML, tree, "dc.attr.table.border.not.number", attr); + } + } else if (currTag == HtmlTag.IMG) { + String v = getAttrValue(tree); + try { + if (v == null || (!v.isEmpty() && Integer.parseInt(v) != 0)) { + env.messages.error(HTML, tree, "dc.attr.img.border.not.valid", attr); } } catch (NumberFormatException ex) { - env.messages.error(HTML, tree, "dc.attr.table.border.html5", attr); + env.messages.error(HTML, tree, "dc.attr.img.border.not.number", attr); } } break; @@ -701,44 +706,6 @@ public Void visitAttribute(AttributeTree tree, Void ignore) { return null; } - private void validateHtml4Attrs(AttributeTree tree, Name name, AttrKind k) { - switch (k) { - case ALL: - case HTML4: - break; - - case INVALID: - env.messages.error(HTML, tree, "dc.attr.unknown", name); - break; - - case OBSOLETE: - env.messages.warning(HTML, tree, "dc.attr.obsolete", name); - break; - - case USE_CSS: - env.messages.warning(HTML, tree, "dc.attr.obsolete.use.css", name); - break; - - case HTML5: - env.messages.error(HTML, tree, "dc.attr.not.supported.html4", name); - break; - } - } - - private void validateHtml5Attrs(AttributeTree tree, Name name, AttrKind k) { - switch (k) { - case ALL: - case HTML5: - break; - - case INVALID: - case OBSOLETE: - case USE_CSS: - case HTML4: - env.messages.error(HTML, tree, "dc.attr.not.supported.html5", name); - break; - } - } private boolean checkAnchor(String name) { Element e = getEnclosingPackageOrClass(env.currElement); @@ -765,8 +732,8 @@ private Element getEnclosingPackageOrClass(Element e) { return e; } - // http://www.w3.org/TR/html401/types.html#type-name - private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*"); + // https://html.spec.whatwg.org/#the-id-attribute + private static final Pattern validId = Pattern.compile("[^\\s]+"); private static final Pattern validNumber = Pattern.compile("-?[0-9]+"); diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java index a7c5f8df8fd78..5ef7c1ada2b99 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java @@ -83,7 +83,6 @@ public class DocLint extends com.sun.tools.doclint.DocLint { public static final String XMSGS_CUSTOM_PREFIX = "-Xmsgs:"; private static final String STATS = "-stats"; public static final String XCUSTOM_TAGS_PREFIX = "-XcustomTags:"; - public static final String XHTML_VERSION_PREFIX = "-XhtmlVersion:"; public static final String XCHECK_PACKAGE = "-XcheckPackage:"; public static final String SEPARATOR = ","; @@ -223,14 +222,6 @@ void processArgs(String... args) throws BadArgs { env.messages.setOptions(arg.substring(arg.indexOf(":") + 1)); } else if (arg.startsWith(XCUSTOM_TAGS_PREFIX)) { env.setCustomTags(arg.substring(arg.indexOf(":") + 1)); - } else if (arg.startsWith(XHTML_VERSION_PREFIX)) { - String argsVersion = arg.substring(arg.indexOf(":") + 1); - HtmlVersion htmlVersion = HtmlVersion.getHtmlVersion(argsVersion); - if (htmlVersion != null) { - env.setHtmlVersion(htmlVersion); - } else { - throw new BadArgs("dc.bad.value.for.option", arg, argsVersion); - } } else if (arg.equals("-h") || arg.equals("-help") || arg.equals("--help") || arg.equals("-?") || arg.equals("-usage")) { needHelp = true; @@ -345,14 +336,6 @@ private void processArgs(Env env, String... args) { env.messages.setOptions(arg.substring(arg.indexOf(":") + 1)); } else if (arg.startsWith(XCUSTOM_TAGS_PREFIX)) { env.setCustomTags(arg.substring(arg.indexOf(":") + 1)); - } else if (arg.startsWith(XHTML_VERSION_PREFIX)) { - String argsVersion = arg.substring(arg.indexOf(":") + 1); - HtmlVersion htmlVersion = HtmlVersion.getHtmlVersion(argsVersion); - if (htmlVersion != null) { - env.setHtmlVersion(htmlVersion); - } else { - throw new IllegalArgumentException(argsVersion); - } } else if (arg.startsWith(XCHECK_PACKAGE)) { env.setCheckPackages(arg.substring(arg.indexOf(":") + 1)); } else diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java index 321cd708043a1..a822f4f157e3e 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -98,8 +98,6 @@ else if (mods.contains(Modifier.PRIVATE)) Set includePackages; Set excludePackages; - HtmlVersion htmlVersion = HtmlVersion.HTML4; - // Utility classes DocTrees trees; Elements elements; @@ -190,10 +188,6 @@ static boolean validatePackages(String packages) { return true; } - void setHtmlVersion(HtmlVersion version) { - htmlVersion = version; - } - /** Set the current declaration and its doc comment. */ void setCurrent(TreePath path, DocCommentTree comment) { currPath = path; diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java index a5107017da772..da1bc22b1affe 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2010, 2020, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -57,30 +57,30 @@ */ public enum HtmlTag { A(BlockType.INLINE, EndKind.REQUIRED, - attrs(AttrKind.ALL, HREF, TARGET, ID), + attrs(AttrKind.OK, HREF, TARGET, ID), attrs(AttrKind.HTML4, REV, CHARSET, SHAPE, COORDS, NAME)), ABBR(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), - ACRONYM(HtmlVersion.HTML4, BlockType.INLINE, EndKind.REQUIRED, + ACRONYM(ElemKind.HTML4, BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), ADDRESS(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), - ARTICLE(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + ARTICLE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), - ASIDE(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + ASIDE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), B(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), - BDI(HtmlVersion.HTML5, BlockType.INLINE, EndKind.REQUIRED), + BDI(BlockType.INLINE, EndKind.REQUIRED), - BIG(HtmlVersion.HTML4, BlockType.INLINE, EndKind.REQUIRED, + BIG(ElemKind.HTML4, BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT)), BLOCKQUOTE(BlockType.BLOCK, EndKind.REQUIRED, @@ -89,13 +89,13 @@ public enum HtmlTag { BODY(BlockType.OTHER, EndKind.REQUIRED), BR(BlockType.INLINE, EndKind.NONE, - attrs(AttrKind.USE_CSS, CLEAR)), + attrs(AttrKind.HTML4, CLEAR)), CAPTION(BlockType.TABLE_ITEM, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_INLINE, Flag.EXPECT_CONTENT), - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), - CENTER(HtmlVersion.HTML4, BlockType.BLOCK, EndKind.REQUIRED, + CENTER(ElemKind.HTML4, BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), CITE(BlockType.INLINE, EndKind.REQUIRED, @@ -120,18 +120,18 @@ public boolean accepts(HtmlTag t) { DEL(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST), - attrs(AttrKind.ALL, Attr.CITE, Attr.DATETIME)), + attrs(AttrKind.OK, Attr.CITE, Attr.DATETIME)), DFN(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), DIV(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE), - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), DL(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.USE_CSS, COMPACT)) { + attrs(AttrKind.HTML4, COMPACT)) { @Override public boolean accepts(HtmlTag t) { return (t == DT) || (t == DD); @@ -144,11 +144,11 @@ public boolean accepts(HtmlTag t) { EM(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.NO_NEST)), - FONT(HtmlVersion.HTML4, BlockType.INLINE, EndKind.REQUIRED, // tag itself is deprecated + FONT(ElemKind.HTML4, BlockType.INLINE, EndKind.REQUIRED, // tag itself is deprecated EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.USE_CSS, SIZE, COLOR, FACE)), + attrs(AttrKind.HTML4, SIZE, COLOR, FACE)), - FOOTER(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + FOOTER(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)) { @Override public boolean accepts(HtmlTag t) { @@ -161,31 +161,31 @@ public boolean accepts(HtmlTag t) { } }, - FIGURE(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + FIGURE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), - FIGCAPTION(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED), + FIGCAPTION(BlockType.BLOCK, EndKind.REQUIRED), - FRAME(HtmlVersion.HTML4, BlockType.OTHER, EndKind.NONE), + FRAME(ElemKind.HTML4, BlockType.OTHER, EndKind.NONE), - FRAMESET(HtmlVersion.HTML4, BlockType.OTHER, EndKind.REQUIRED), + FRAMESET(ElemKind.HTML4, BlockType.OTHER, EndKind.REQUIRED), H1(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), H2(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), H3(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), H4(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), H5(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), H6(BlockType.BLOCK, EndKind.REQUIRED, - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), HEAD(BlockType.OTHER, EndKind.REQUIRED), - HEADER(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + HEADER(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)) { @Override public boolean accepts(HtmlTag t) { @@ -199,8 +199,7 @@ public boolean accepts(HtmlTag t) { }, HR(BlockType.BLOCK, EndKind.NONE, - attrs(AttrKind.HTML4, WIDTH), - attrs(AttrKind.USE_CSS, ALIGN, NOSHADE, SIZE)), + attrs(AttrKind.HTML4, WIDTH, ALIGN, NOSHADE, SIZE)), HTML(BlockType.OTHER, EndKind.REQUIRED), @@ -210,28 +209,26 @@ public boolean accepts(HtmlTag t) { IFRAME(BlockType.OTHER, EndKind.REQUIRED), IMG(BlockType.INLINE, EndKind.NONE, - attrs(AttrKind.ALL, SRC, ALT, HEIGHT, WIDTH), - attrs(AttrKind.HTML5, CROSSORIGIN), - attrs(AttrKind.OBSOLETE, NAME), - attrs(AttrKind.USE_CSS, ALIGN, HSPACE, VSPACE, BORDER)), + attrs(AttrKind.OK, SRC, ALT, HEIGHT, WIDTH, CROSSORIGIN), + attrs(AttrKind.HTML4, NAME, ALIGN, HSPACE, VSPACE, BORDER)), INS(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST), - attrs(AttrKind.ALL, Attr.CITE, Attr.DATETIME)), + attrs(AttrKind.OK, Attr.CITE, Attr.DATETIME)), KBD(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), LI(BlockType.LIST_ITEM, EndKind.OPTIONAL, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE), - attrs(AttrKind.ALL, VALUE), - attrs(AttrKind.USE_CSS, TYPE)), + attrs(AttrKind.OK, VALUE), + attrs(AttrKind.HTML4, TYPE)), LINK(BlockType.OTHER, EndKind.NONE), - MAIN(HtmlVersion.HTML5, BlockType.OTHER, EndKind.REQUIRED), + MAIN(BlockType.OTHER, EndKind.REQUIRED), - MARK(HtmlVersion.HTML5, BlockType.INLINE, EndKind.REQUIRED), + MARK(BlockType.INLINE, EndKind.REQUIRED), MENU(BlockType.BLOCK, EndKind.REQUIRED) { @Override @@ -242,18 +239,17 @@ public boolean accepts(HtmlTag t) { META(BlockType.OTHER, EndKind.NONE), - NAV(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + NAV(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), - NOFRAMES(HtmlVersion.HTML4, BlockType.OTHER, EndKind.REQUIRED), + NOFRAMES(ElemKind.HTML4, BlockType.OTHER, EndKind.REQUIRED), NOSCRIPT(BlockType.BLOCK, EndKind.REQUIRED), OL(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.ALL, START, TYPE), - attrs(AttrKind.HTML5, REVERSED), - attrs(AttrKind.USE_CSS, COMPACT)) { + attrs(AttrKind.OK, START, TYPE, REVERSED), + attrs(AttrKind.HTML4, COMPACT)) { @Override public boolean accepts(HtmlTag t) { return (t == LI); @@ -262,11 +258,11 @@ public boolean accepts(HtmlTag t) { P(BlockType.BLOCK, EndKind.OPTIONAL, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.USE_CSS, ALIGN)), + attrs(AttrKind.HTML4, ALIGN)), PRE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.USE_CSS, WIDTH)) { + attrs(AttrKind.HTML4, WIDTH)) { @Override public boolean accepts(HtmlTag t) { switch (t) { @@ -288,9 +284,9 @@ public boolean accepts(HtmlTag t) { EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), SCRIPT(BlockType.OTHER, EndKind.REQUIRED, - attrs(AttrKind.ALL, SRC)), + attrs(AttrKind.OK, SRC)), - SECTION(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + SECTION(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), SMALL(BlockType.INLINE, EndKind.REQUIRED, @@ -299,7 +295,7 @@ public boolean accepts(HtmlTag t) { SPAN(BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT)), - STRIKE(HtmlVersion.HTML4, BlockType.INLINE, EndKind.REQUIRED, + STRIKE(ElemKind.HTML4, BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT)), STRONG(BlockType.INLINE, EndKind.REQUIRED, @@ -315,9 +311,9 @@ public boolean accepts(HtmlTag t) { TABLE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.ALL, BORDER), - attrs(AttrKind.HTML4, SUMMARY, CELLPADDING, CELLSPACING, Attr.FRAME, RULES, WIDTH), - attrs(AttrKind.USE_CSS, ALIGN, BGCOLOR)) { + attrs(AttrKind.OK, BORDER), + attrs(AttrKind.HTML4, SUMMARY, CELLPADDING, CELLSPACING, + Attr.FRAME, RULES, WIDTH, ALIGN, BGCOLOR)) { @Override public boolean accepts(HtmlTag t) { switch (t) { @@ -334,8 +330,7 @@ public boolean accepts(HtmlTag t) { TBODY(BlockType.TABLE_ITEM, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT), - attrs(AttrKind.ALL, VALIGN), - attrs(AttrKind.HTML4, ALIGN, CHAR, CHAROFF)) { + attrs(AttrKind.HTML4, ALIGN, VALIGN, CHAR, CHAROFF)) { @Override public boolean accepts(HtmlTag t) { return (t == TR); @@ -344,16 +339,15 @@ public boolean accepts(HtmlTag t) { TD(BlockType.TABLE_ITEM, EndKind.OPTIONAL, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE), - attrs(AttrKind.ALL, COLSPAN, ROWSPAN, HEADERS, VALIGN), - attrs(AttrKind.HTML4, AXIS, Attr.ABBR, SCOPE, ALIGN, CHAR, CHAROFF), - attrs(AttrKind.USE_CSS, WIDTH, BGCOLOR, HEIGHT, NOWRAP)), + attrs(AttrKind.OK, COLSPAN, ROWSPAN, HEADERS), + attrs(AttrKind.HTML4, AXIS, Attr.ABBR, SCOPE, ALIGN, VALIGN, CHAR, CHAROFF, + WIDTH, BGCOLOR, HEIGHT, NOWRAP)), - TEMPLATE(HtmlVersion.HTML5, BlockType.BLOCK, EndKind.REQUIRED, + TEMPLATE(BlockType.BLOCK, EndKind.REQUIRED, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE)), TFOOT(BlockType.TABLE_ITEM, EndKind.REQUIRED, - attrs(AttrKind.ALL, VALIGN), - attrs(AttrKind.HTML4, ALIGN, CHAR, CHAROFF)) { + attrs(AttrKind.HTML4, ALIGN, VALIGN, CHAR, CHAROFF)) { @Override public boolean accepts(HtmlTag t) { return (t == TR); @@ -362,35 +356,30 @@ public boolean accepts(HtmlTag t) { TH(BlockType.TABLE_ITEM, EndKind.OPTIONAL, EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE), - attrs(AttrKind.ALL, COLSPAN, ROWSPAN, HEADERS, SCOPE, Attr.ABBR, - VALIGN), - attrs(AttrKind.HTML4, AXIS, ALIGN, CHAR, CHAROFF), - attrs(AttrKind.USE_CSS, WIDTH, BGCOLOR, HEIGHT, NOWRAP)), + attrs(AttrKind.OK, COLSPAN, ROWSPAN, HEADERS, SCOPE, Attr.ABBR), + attrs(AttrKind.HTML4, WIDTH, BGCOLOR, HEIGHT, NOWRAP, AXIS, ALIGN, CHAR, CHAROFF, VALIGN)), THEAD(BlockType.TABLE_ITEM, EndKind.REQUIRED, - attrs(AttrKind.ALL, VALIGN), - attrs(AttrKind.HTML4, ALIGN, CHAR, CHAROFF)) { + attrs(AttrKind.HTML4, ALIGN, VALIGN, CHAR, CHAROFF)) { @Override public boolean accepts(HtmlTag t) { return (t == TR); } }, - TIME(HtmlVersion.HTML5, BlockType.INLINE, EndKind.REQUIRED), + TIME(BlockType.INLINE, EndKind.REQUIRED), TITLE(BlockType.OTHER, EndKind.REQUIRED), TR(BlockType.TABLE_ITEM, EndKind.OPTIONAL, - attrs(AttrKind.ALL, VALIGN), - attrs(AttrKind.HTML4, ALIGN, CHAR, CHAROFF), - attrs(AttrKind.USE_CSS, BGCOLOR)) { + attrs(AttrKind.HTML4, ALIGN, CHAR, CHAROFF, BGCOLOR, VALIGN)) { @Override public boolean accepts(HtmlTag t) { return (t == TH) || (t == TD); } }, - TT(HtmlVersion.HTML4, BlockType.INLINE, EndKind.REQUIRED, + TT(ElemKind.HTML4, BlockType.INLINE, EndKind.REQUIRED, EnumSet.of(Flag.EXPECT_CONTENT, Flag.NO_NEST)), U(BlockType.INLINE, EndKind.REQUIRED, @@ -405,10 +394,20 @@ public boolean accepts(HtmlTag t) { } }, - WBR(HtmlVersion.HTML5, BlockType.INLINE, EndKind.REQUIRED), + WBR(BlockType.INLINE, EndKind.REQUIRED), VAR(BlockType.INLINE, EndKind.REQUIRED); + /** + * Enum representing the supportability of HTML element. + */ + public static enum ElemKind { + OK, + INVALID, + OBSOLETE, + HTML4 + } + /** * Enum representing the type of HTML element. */ @@ -534,12 +533,10 @@ public String getText() { } public static enum AttrKind { - HTML4, - HTML5, + OK, INVALID, OBSOLETE, - USE_CSS, - ALL + HTML4 } // This class exists to avoid warnings from using parameterized vararg type @@ -552,52 +549,52 @@ private static class AttrMap extends EnumMap { } - public final HtmlVersion allowedVersion; + public final ElemKind elemKind; public final BlockType blockType; public final EndKind endKind; public final Set flags; private final Map attrs; HtmlTag(BlockType blockType, EndKind endKind, AttrMap... attrMaps) { - this(HtmlVersion.ALL, blockType, endKind, Collections.emptySet(), attrMaps); + this(ElemKind.OK, blockType, endKind, Collections.emptySet(), attrMaps); } - HtmlTag(HtmlVersion allowedVersion, BlockType blockType, EndKind endKind, AttrMap... attrMaps) { - this(allowedVersion, blockType, endKind, Collections.emptySet(), attrMaps); + HtmlTag(ElemKind elemKind, BlockType blockType, EndKind endKind, AttrMap... attrMaps) { + this(elemKind, blockType, endKind, Collections.emptySet(), attrMaps); } HtmlTag(BlockType blockType, EndKind endKind, Set flags, AttrMap... attrMaps) { - this(HtmlVersion.ALL, blockType, endKind, flags, attrMaps); + this(ElemKind.OK, blockType, endKind, flags, attrMaps); } - HtmlTag(HtmlVersion allowedVersion, BlockType blockType, EndKind endKind, Set flags, AttrMap... attrMaps) { - this.allowedVersion = allowedVersion; + HtmlTag(ElemKind elemKind, BlockType blockType, EndKind endKind, Set flags, AttrMap... attrMaps) { + this.elemKind = elemKind; this.blockType = blockType; this.endKind = endKind; this.flags = flags; this.attrs = new EnumMap<>(Attr.class); for (Map m: attrMaps) this.attrs.putAll(m); - attrs.put(Attr.CLASS, AttrKind.ALL); - attrs.put(Attr.ID, AttrKind.ALL); - attrs.put(Attr.STYLE, AttrKind.ALL); - attrs.put(Attr.ROLE, AttrKind.HTML5); + attrs.put(Attr.CLASS, AttrKind.OK); + attrs.put(Attr.ID, AttrKind.OK); + attrs.put(Attr.STYLE, AttrKind.OK); + attrs.put(Attr.ROLE, AttrKind.OK); // for now, assume that all ARIA attributes are allowed on all tags. - attrs.put(Attr.ARIA_ACTIVEDESCENDANT, AttrKind.HTML5); - attrs.put(Attr.ARIA_CONTROLS, AttrKind.HTML5); - attrs.put(Attr.ARIA_DESCRIBEDBY, AttrKind.HTML5); - attrs.put(Attr.ARIA_EXPANDED, AttrKind.HTML5); - attrs.put(Attr.ARIA_LABEL, AttrKind.HTML5); - attrs.put(Attr.ARIA_LABELLEDBY, AttrKind.HTML5); - attrs.put(Attr.ARIA_LEVEL, AttrKind.HTML5); - attrs.put(Attr.ARIA_MULTISELECTABLE, AttrKind.HTML5); - attrs.put(Attr.ARIA_OWNS, AttrKind.HTML5); - attrs.put(Attr.ARIA_POSINSET, AttrKind.HTML5); - attrs.put(Attr.ARIA_READONLY, AttrKind.HTML5); - attrs.put(Attr.ARIA_REQUIRED, AttrKind.HTML5); - attrs.put(Attr.ARIA_SELECTED, AttrKind.HTML5); - attrs.put(Attr.ARIA_SETSIZE, AttrKind.HTML5); - attrs.put(Attr.ARIA_SORT, AttrKind.HTML5); + attrs.put(Attr.ARIA_ACTIVEDESCENDANT, AttrKind.OK); + attrs.put(Attr.ARIA_CONTROLS, AttrKind.OK); + attrs.put(Attr.ARIA_DESCRIBEDBY, AttrKind.OK); + attrs.put(Attr.ARIA_EXPANDED, AttrKind.OK); + attrs.put(Attr.ARIA_LABEL, AttrKind.OK); + attrs.put(Attr.ARIA_LABELLEDBY, AttrKind.OK); + attrs.put(Attr.ARIA_LEVEL, AttrKind.OK); + attrs.put(Attr.ARIA_MULTISELECTABLE, AttrKind.OK); + attrs.put(Attr.ARIA_OWNS, AttrKind.OK); + attrs.put(Attr.ARIA_POSINSET, AttrKind.OK); + attrs.put(Attr.ARIA_READONLY, AttrKind.OK); + attrs.put(Attr.ARIA_REQUIRED, AttrKind.OK); + attrs.put(Attr.ARIA_SELECTED, AttrKind.OK); + attrs.put(Attr.ARIA_SETSIZE, AttrKind.OK); + attrs.put(Attr.ARIA_SORT, AttrKind.OK); } public boolean accepts(HtmlTag t) { diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlVersion.java b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlVersion.java deleted file mode 100644 index 6fadc3ccfd571..0000000000000 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlVersion.java +++ /dev/null @@ -1,49 +0,0 @@ -/* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. Oracle designates this - * particular file as subject to the "Classpath" exception as provided - * by Oracle in the LICENSE file that accompanied this code. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -package jdk.javadoc.internal.doclint; - -/** - * Enum representing HTML version of the documentation comment. - * - * @author Bhavesh Patel - */ -public enum HtmlVersion { - - HTML4, - HTML5, - ALL; - - public static HtmlVersion getHtmlVersion(String argsVersion) { - switch (argsVersion) { - case "html4": - return HtmlVersion.HTML4; - case "html5": - return HtmlVersion.HTML5; - default: - return null; - } - } -} diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties index aa0881e502e8a..5704c581fd6b8 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties @@ -27,12 +27,13 @@ dc.anchor.already.defined = anchor already defined: "{0}" dc.anchor.value.missing = no value given for anchor dc.attr.lacks.value = attribute lacks value dc.attr.not.number = attribute value is not a number -dc.attr.not.supported.html4 = attribute not supported in HTML4: {0} dc.attr.not.supported.html5 = attribute not supported in HTML5: {0} dc.attr.obsolete = attribute obsolete: {0} -dc.attr.obsolete.use.css = attribute obsolete, use CSS instead: {0} dc.attr.repeated = repeated attribute: {0} -dc.attr.table.border.html5 = attribute border for table only accepts "" or "1", use CSS instead: {0} +dc.attr.img.border.not.valid = attribute "border" for img only accepts "0": {0} +dc.attr.img.border.not.number = invalid value for attribute "border": {0} +dc.attr.table.border.not.valid = attribute "border" for table only accepts "" or "1": {0} +dc.attr.table.border.not.number = invalid value for attribute "border": {0} dc.attr.unknown = unknown attribute: {0} dc.bad.option = bad option: {0} dc.bad.value.for.option = bad value for option: {0} {1} @@ -54,7 +55,7 @@ dc.missing.param = no @param for {0} dc.missing.return = no @return dc.missing.throws = no @throws for {0} dc.no.alt.attr.for.image = no "alt" attribute for image -dc.no.summary.or.caption.for.table=no summary or caption for table +dc.no.summary.or.caption.for.table=no caption for table dc.param.name.not.found = @param name not found dc.ref.not.found = reference not found dc.return.not.first = '{@return} not at beginning of description @@ -79,7 +80,7 @@ dc.tag.requires.heading = heading not found for dc.tag.self.closing = self-closing element not allowed dc.tag.start.unmatched = end tag missing: dc.tag.unknown = unknown tag: {0} -dc.tag.not.supported = tag not supported in the generated HTML version: {0} +dc.tag.not.supported.html5 = tag not supported in HTML5: {0} dc.text.not.allowed = text not allowed in <{0}> element dc.unexpected.comment=documentation comment not expected here dc.value.not.allowed.here='{@value} not allowed here diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_ja.properties b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_ja.properties index 03f7f10d10dc1..581ce27e66e58 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_ja.properties +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_ja.properties @@ -1,5 +1,5 @@ # -# Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -27,12 +27,12 @@ dc.anchor.already.defined = \u30A2\u30F3\u30AB\u30FC\u304C\u3059\u3067\u306B\u5B dc.anchor.value.missing = \u30A2\u30F3\u30AB\u30FC\u306B\u5024\u304C\u6307\u5B9A\u3055\u308C\u3066\u3044\u307E\u305B\u3093 dc.attr.lacks.value = \u5C5E\u6027\u306B\u5024\u304C\u3042\u308A\u307E\u305B\u3093 dc.attr.not.number = \u5C5E\u6027\u5024\u304C\u6570\u5B57\u3067\u306F\u3042\u308A\u307E\u305B\u3093 -dc.attr.not.supported.html4 = \u5C5E\u6027\u306FHTML4\u3067\u306F\u30B5\u30DD\u30FC\u30C8\u3055\u308C\u3066\u3044\u307E\u305B\u3093: {0} dc.attr.not.supported.html5 = \u5C5E\u6027\u306FHTML5\u3067\u306F\u30B5\u30DD\u30FC\u30C8\u3055\u308C\u3066\u3044\u307E\u305B\u3093: {0} dc.attr.obsolete = \u5C5E\u6027\u306F\u5EC3\u6B62\u3055\u308C\u3066\u3044\u307E\u3059: {0} dc.attr.obsolete.use.css = \u5C5E\u6027\u306F\u5EC3\u6B62\u3055\u308C\u3066\u3044\u307E\u3059\u3002\u304B\u308F\u308A\u306BCSS\u3092\u4F7F\u7528\u3057\u3066\u304F\u3060\u3055\u3044: {0} dc.attr.repeated = \u7E70\u308A\u8FD4\u3055\u308C\u305F\u5C5E\u6027: {0} -dc.attr.table.border.html5 = \u8868\u306E\u5C5E\u6027\u30DC\u30FC\u30C0\u30FC\u306F""\u307E\u305F\u306F"1"\u306E\u307F\u53D7\u3051\u5165\u308C\u307E\u3059\u3002\u304B\u308F\u308A\u306BCSS\u3092\u4F7F\u7528\u3057\u3066\u304F\u3060\u3055\u3044: {0} +dc.attr.img.border = \u753b\u50cf\u306e\u5c5e\u6027\u30DC\u30FC\u30C0\u30FC\u306F""\u307E\u305F\u306F"1"\u306E\u307F\u53D7\u3051\u5165\u308C\u307E\u3059\u3002\u304B\u308F\u308A\u306BCSS\u3092\u4F7F\u7528\u3057\u3066\u304F\u3060\u3055\u3044: {0} +dc.attr.table.border = \u8868\u306E\u5C5E\u6027\u30DC\u30FC\u30C0\u30FC\u306F""\u307E\u305F\u306F"1"\u306E\u307F\u53D7\u3051\u5165\u308C\u307E\u3059\u3002\u304B\u308F\u308A\u306BCSS\u3092\u4F7F\u7528\u3057\u3066\u304F\u3060\u3055\u3044: {0} dc.attr.unknown = \u4E0D\u660E\u306A\u5C5E\u6027: {0} dc.bad.option = \u7121\u52B9\u306A\u30AA\u30D7\u30B7\u30E7\u30F3: {0} dc.bad.value.for.option = \u30AA\u30D7\u30B7\u30E7\u30F3\u306E\u5024\u304C\u4E0D\u6B63\u3067\u3059: {0} {1} @@ -78,7 +78,7 @@ dc.tag.requires.heading = \u306E\u898B\u51FA\u3057\u304C\u898B\u3064\u304B dc.tag.self.closing = \u81EA\u5DF1\u7D42\u4E86\u8981\u7D20\u306F\u4F7F\u7528\u3067\u304D\u307E\u305B\u3093 dc.tag.start.unmatched = \u7D42\u4E86\u30BF\u30B0\u304C\u3042\u308A\u307E\u305B\u3093: dc.tag.unknown = \u4E0D\u660E\u306A\u30BF\u30B0: {0} -dc.tag.not.supported = \u30BF\u30B0\u306F\u3001\u751F\u6210\u6E08HTML\u30D0\u30FC\u30B8\u30E7\u30F3\u3067\u306F\u30B5\u30DD\u30FC\u30C8\u3055\u308C\u3066\u3044\u307E\u305B\u3093: {0} +dc.tag.not.supported.html5 = \u30bf\u30b0\u306fHTML5\u3067\u306f\u30b5\u30dd\u30fc\u30c8\u3055\u308c\u3066\u3044\u307e\u305b\u3093: {0} dc.text.not.allowed = <{0}>\u8981\u7D20\u3067\u306F\u30C6\u30AD\u30B9\u30C8\u3092\u4F7F\u7528\u3067\u304D\u307E\u305B\u3093 dc.type.arg.not.allowed = \u578B\u5F15\u6570\u306F\u3053\u3053\u3067\u306F\u4F7F\u7528\u3067\u304D\u307E\u305B\u3093 dc.unexpected.comment=\u30C9\u30AD\u30E5\u30E1\u30F3\u30C8\u30FB\u30B3\u30E1\u30F3\u30C8\u306F\u3053\u3053\u3067\u306F\u5FC5\u8981\u3042\u308A\u307E\u305B\u3093 diff --git a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_zh_CN.properties b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_zh_CN.properties index 4790ce7ed0cee..50b6ad80bfdfe 100644 --- a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_zh_CN.properties +++ b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint_zh_CN.properties @@ -1,5 +1,5 @@ # -# Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -27,12 +27,12 @@ dc.anchor.already.defined = \u951A\u5B9A\u70B9\u5DF2\u5B9A\u4E49: "{0}" dc.anchor.value.missing = \u6CA1\u6709\u4E3A\u951A\u5B9A\u70B9\u6307\u5B9A\u503C dc.attr.lacks.value = \u5C5E\u6027\u7F3A\u5C11\u503C dc.attr.not.number = \u5C5E\u6027\u503C\u4E0D\u662F\u6570\u5B57 -dc.attr.not.supported.html4 = \u5C5E\u6027\u5728 HTML4 \u4E2D\u4E0D\u53D7\u652F\u6301: {0} dc.attr.not.supported.html5 = \u5C5E\u6027\u5728 HTML5 \u4E2D\u4E0D\u53D7\u652F\u6301: {0} dc.attr.obsolete = \u5C5E\u6027\u5DF2\u8FC7\u65F6: {0} dc.attr.obsolete.use.css = \u5C5E\u6027\u5DF2\u8FC7\u65F6, \u8BF7\u6539\u7528 CSS: {0} dc.attr.repeated = \u5C5E\u6027\u91CD\u590D: {0} -dc.attr.table.border.html5 = \u8868\u7684\u5C5E\u6027\u8FB9\u6846\u53EA\u63A5\u53D7 "" \u6216 "1", \u6539\u4E3A\u4F7F\u7528 CSS: {0} +dc.attr.img.border = \u56FE\u50CF\u6027\u8FB9\u6846\u53EA\u63A5\u53D7 "" \u6216 "1", \u6539\u4E3A\u4F7F\u7528 CSS: {0} +dc.attr.table.border = \u8868\u7684\u5C5E\u6027\u8FB9\u6846\u53EA\u63A5\u53D7 "" \u6216 "1", \u6539\u4E3A\u4F7F\u7528 CSS: {0} dc.attr.unknown = \u672A\u77E5\u5C5E\u6027: {0} dc.bad.option = \u9009\u9879\u9519\u8BEF: {0} dc.bad.value.for.option = \u9009\u9879\u7684\u503C\u9519\u8BEF: {0} {1} @@ -78,7 +78,7 @@ dc.tag.requires.heading = \u672A\u627E\u5230 \u7684\u6807\u9898 dc.tag.self.closing = \u4E0D\u5141\u8BB8\u4F7F\u7528\u81EA\u5173\u95ED\u5143\u7D20 dc.tag.start.unmatched = \u7F3A\u5C11\u7ED3\u675F\u6807\u8BB0: dc.tag.unknown = \u672A\u77E5\u6807\u8BB0: {0} -dc.tag.not.supported = \u6807\u8BB0\u5728\u751F\u6210\u7684 HTML \u7248\u672C\u4E2D\u4E0D\u53D7\u652F\u6301: {0} +dc.tag.not.supported.html5 = \u6807\u8BB0\u5728\u751F\u6210\u7684 HTML \u7248\u672C\u4E2D\u4E0D\u53D7\u652F\u6301: {0} dc.text.not.allowed = <{0}> \u5143\u7D20\u4E2D\u4E0D\u5141\u8BB8\u4F7F\u7528\u6587\u672C dc.type.arg.not.allowed = \u6B64\u5904\u4E0D\u5141\u8BB8\u4F7F\u7528\u7C7B\u578B\u53C2\u6570 dc.unexpected.comment=\u6B64\u5904\u672A\u9884\u671F\u6587\u6863\u6CE8\u91CA diff --git a/test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java b/test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java index 248edc2607a01..34cc2e5944a1c 100644 --- a/test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java +++ b/test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java @@ -50,7 +50,7 @@ public void test() { checkOutput(Output.OUT, true, "attribute not supported in HTML5: summary", """ - attribute border for table only accepts "" or "1", use CSS instead: BORDER""", + attribute "border" for table only accepts "" or "1": BORDER""", "attribute not supported in HTML5: cellpadding", "attribute not supported in HTML5: cellspacing", "attribute not supported in HTML5: align"); diff --git a/test/langtools/tools/doclint/AccessibilityTest.java b/test/langtools/tools/doclint/AccessibilityTest.java index 5d7e34fe00da4..17e9c9aa48c59 100644 --- a/test/langtools/tools/doclint/AccessibilityTest.java +++ b/test/langtools/tools/doclint/AccessibilityTest.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8004832 + * @bug 8004832 8247955 8247957 * @summary Add new doclint package * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester @@ -47,11 +47,6 @@ public void missing_h4() { } */ public void missing_alt() { } - /** - *
head
data
- */ - public void table_with_summary() { } - /** *
ok
head
data
*/ @@ -60,6 +55,12 @@ public void table_with_caption() { } /** *
head
data
*/ - public void table_without_summary_and_caption() { } + public void table_without_caption() { } + + /** + *
head
data
+ */ + public void table_presentation() { } + } diff --git a/test/langtools/tools/doclint/AccessibilityTest.out b/test/langtools/tools/doclint/AccessibilityTest.out index 94c7611232a6b..b3497ce8185cd 100644 --- a/test/langtools/tools/doclint/AccessibilityTest.out +++ b/test/langtools/tools/doclint/AccessibilityTest.out @@ -19,7 +19,7 @@ AccessibilityTest.java:41: error: heading used out of sequence:
, compared t AccessibilityTest.java:46: error: no "alt" attribute for image * ^ -AccessibilityTest.java:61: error: no summary or caption for table +AccessibilityTest.java:56: error: no caption for table *
head
data
^ 8 errors diff --git a/test/langtools/tools/doclint/AccessibilityTest5.java b/test/langtools/tools/doclint/AccessibilityTest5.java deleted file mode 100644 index a5393b3d54483..0000000000000 --- a/test/langtools/tools/doclint/AccessibilityTest5.java +++ /dev/null @@ -1,30 +0,0 @@ -/* - * @test /nodynamiccopyright/ - * @bug 8247955 - * @summary Add new doclint package - * @modules jdk.javadoc/jdk.javadoc.internal.doclint - * @build DocLintTester - * @run main DocLintTester -XhtmlVersion:html5 -Xmsgs:-accessibility AccessibilityTest5.java - * @run main DocLintTester -XhtmlVersion:html5 -ref AccessibilityTest5.out AccessibilityTest5.java - */ - -// This test should be merged into AccessibilityTest.java when we drop support for html4. - -/** */ -public class AccessibilityTest5 { - /** - *
ok
head
data
- */ - public void table_with_caption() { } - - /** - *
head
data
- */ - public void table_without_caption() { } - - /** - *
head
data
- */ - public void table_presentation() { } -} - diff --git a/test/langtools/tools/doclint/AccessibilityTest5.out b/test/langtools/tools/doclint/AccessibilityTest5.out deleted file mode 100644 index 23ccfda6681e2..0000000000000 --- a/test/langtools/tools/doclint/AccessibilityTest5.out +++ /dev/null @@ -1,4 +0,0 @@ -AccessibilityTest5.java:21: error: no summary or caption for table - *
head
data
- ^ -1 error diff --git a/test/langtools/tools/doclint/AnchorTest.java b/test/langtools/tools/doclint/AnchorTest.java index d2d9324189d6b..7bce8a51966b1 100644 --- a/test/langtools/tools/doclint/AnchorTest.java +++ b/test/langtools/tools/doclint/AnchorTest.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8004832 + * @bug 8004832 8247957 * @summary Add new doclint package * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester @@ -9,37 +9,10 @@ /** */ public class AnchorTest { - // tests for - - /** - * - */ - public void a_name_foo() { } - - /** - * - */ - public void a_name_already_defined() { } - - /** - * - */ - public void a_name_empty() { } - - /** - * - */ - public void a_name_invalid() { } - - /** - * - */ - public void a_name_missing() { } - // tests for /** - * + * */ public void a_id_foo() { } @@ -54,7 +27,7 @@ public void a_id_already_defined() { } public void a_id_empty() { } /** - * + * */ public void a_id_invalid() { } @@ -81,7 +54,7 @@ public void p_id_already_defined() { } public void p_id_empty() { } /** - *

text

+ *

text

*/ public void p_id_invalid() { } diff --git a/test/langtools/tools/doclint/AnchorTest.out b/test/langtools/tools/doclint/AnchorTest.out index 70bb1383ee31b..72c062e4acbd7 100644 --- a/test/langtools/tools/doclint/AnchorTest.out +++ b/test/langtools/tools/doclint/AnchorTest.out @@ -1,49 +1,31 @@ AnchorTest.java:20: error: anchor already defined: "foo" - * - ^ -AnchorTest.java:25: error: invalid name for anchor: "" - * - ^ -AnchorTest.java:30: error: invalid name for anchor: "123" - * - ^ -AnchorTest.java:35: error: no value given for anchor - * - ^ -AnchorTest.java:47: error: anchor already defined: "foo" * ^ -AnchorTest.java:52: error: invalid name for anchor: "" - * - ^ -AnchorTest.java:52: error: anchor already defined: "" +AnchorTest.java:25: error: invalid name for anchor: "" * ^ -AnchorTest.java:57: error: invalid name for anchor: "123" - * - ^ -AnchorTest.java:57: error: anchor already defined: "123" - * +AnchorTest.java:30: error: invalid name for anchor: "123 " + * ^ -AnchorTest.java:62: error: no value given for anchor +AnchorTest.java:35: error: no value given for anchor * ^ -AnchorTest.java:74: error: anchor already defined: "foo" +AnchorTest.java:47: error: anchor already defined: "foo" *

text

^ -AnchorTest.java:79: error: invalid name for anchor: "" +AnchorTest.java:52: error: invalid name for anchor: "" *

text

^ -AnchorTest.java:79: error: anchor already defined: "" +AnchorTest.java:52: error: anchor already defined: "" *

text

^ -AnchorTest.java:84: error: invalid name for anchor: "123" - *

text

+AnchorTest.java:57: error: invalid name for anchor: "123 " + *

text

^ -AnchorTest.java:84: error: anchor already defined: "123" - *

text

+AnchorTest.java:57: error: anchor already defined: "123 " + *

text

^ -AnchorTest.java:89: error: no value given for anchor +AnchorTest.java:62: error: no value given for anchor *

text

^ -16 errors +10 errors diff --git a/test/langtools/tools/doclint/AnchorTest2.java b/test/langtools/tools/doclint/AnchorTest2.java index 79b668677f1be..ac8270322137a 100644 --- a/test/langtools/tools/doclint/AnchorTest2.java +++ b/test/langtools/tools/doclint/AnchorTest2.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8020313 + * @bug 8020313 8247957 * @summary doclint doesn't reset HTML anchors correctly * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester @@ -10,12 +10,12 @@ /** */ public class AnchorTest2 { - /** */ + /** */ public void a_name_AnchorTest2() { } - /** */ + /** */ public void a_name_AnchorTest2_already_defined() { } - /** */ + /** */ public void a_name_AnchorTest2a_defined_in_other_file() { } } diff --git a/test/langtools/tools/doclint/AnchorTest2.out b/test/langtools/tools/doclint/AnchorTest2.out index 755e6073eb635..b74020b560add 100644 --- a/test/langtools/tools/doclint/AnchorTest2.out +++ b/test/langtools/tools/doclint/AnchorTest2.out @@ -1,4 +1,4 @@ AnchorTest2.java:16: error: anchor already defined: "AnchorTest2" - /** */ + /** */ ^ 1 error diff --git a/test/langtools/tools/doclint/AnchorTest2a.java b/test/langtools/tools/doclint/AnchorTest2a.java index 3a19713893146..984f60d7e0fca 100644 --- a/test/langtools/tools/doclint/AnchorTest2a.java +++ b/test/langtools/tools/doclint/AnchorTest2a.java @@ -1,7 +1,7 @@ /* /nodynamiccopyright/ */ /** - * + * */ public class AnchorTest2a { } diff --git a/test/langtools/tools/doclint/EndTagsTest.java b/test/langtools/tools/doclint/EndTagsTest.java index ad2d1cebc68b3..ef5ca8bf40069 100644 --- a/test/langtools/tools/doclint/EndTagsTest.java +++ b/test/langtools/tools/doclint/EndTagsTest.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8006236 + * @bug 8006236 8247957 * @summary doclint: structural issue hidden * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester @@ -10,10 +10,10 @@ /** */ public class EndTagsTest { - /**

text image

*/ + /**

text image

*/ public void valid_all() { } - /**

text image */ + /**

text image */ public void valid_omit_optional_close() { } /** */ diff --git a/test/langtools/tools/doclint/HtmlAttrsTest.java b/test/langtools/tools/doclint/HtmlAttrsTest.java index 5d31702f0c441..f90b3f8461ba9 100644 --- a/test/langtools/tools/doclint/HtmlAttrsTest.java +++ b/test/langtools/tools/doclint/HtmlAttrsTest.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8004832 8258916 + * @bug 8004832 8258916 8247957 * @summary Add new doclint package * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester diff --git a/test/langtools/tools/doclint/HtmlAttrsTest.out b/test/langtools/tools/doclint/HtmlAttrsTest.out index 889d99ed4466a..59b3294a00fcf 100644 --- a/test/langtools/tools/doclint/HtmlAttrsTest.out +++ b/test/langtools/tools/doclint/HtmlAttrsTest.out @@ -1,12 +1,11 @@ HtmlAttrsTest.java:14: error: unknown attribute: xyz *

text

^ -HtmlAttrsTest.java:19: warning: attribute obsolete: name +HtmlAttrsTest.java:19: error: attribute not supported in HTML5: name * alt ^ -HtmlAttrsTest.java:24: warning: attribute obsolete, use CSS instead: size +HtmlAttrsTest.java:24: error: tag not supported in HTML5: font * text - ^ -1 error -2 warnings + ^ +3 errors diff --git a/test/langtools/tools/doclint/HtmlTagsTest.java b/test/langtools/tools/doclint/HtmlTagsTest.java index 8f1926cf17a6d..d8b033d2fbbd4 100644 --- a/test/langtools/tools/doclint/HtmlTagsTest.java +++ b/test/langtools/tools/doclint/HtmlTagsTest.java @@ -1,6 +1,6 @@ /* * @test /nodynamiccopyright/ - * @bug 8004832 + * @bug 8004832 8247957 * @summary Add new doclint package * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester diff --git a/test/langtools/tools/doclint/HtmlTagsTest.out b/test/langtools/tools/doclint/HtmlTagsTest.out index 9e0b22de3dc6c..66d80e365e66c 100644 --- a/test/langtools/tools/doclint/HtmlTagsTest.out +++ b/test/langtools/tools/doclint/HtmlTagsTest.out @@ -7,9 +7,6 @@ HtmlTagsTest.java:14: error: unknown tag: xyz HtmlTagsTest.java:19: error: unknown tag: xyz *
^ -HtmlTagsTest.java:24: error: self-closing element not allowed - *
- ^ HtmlTagsTest.java:29: error: element not allowed in documentation comments: * ^ @@ -43,5 +40,5 @@ HtmlTagsTest.java:60: error: text not allowed in
    element HtmlTagsTest.java:65: error: tag not allowed here: *
      text
    • ...
    ^ -14 errors +13 errors 1 warning diff --git a/test/langtools/tools/doclint/HtmlVersionTest.java b/test/langtools/tools/doclint/HtmlVersionTest.java deleted file mode 100644 index 04ea2af3bd16b..0000000000000 --- a/test/langtools/tools/doclint/HtmlVersionTest.java +++ /dev/null @@ -1,41 +0,0 @@ -/* - * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA - * or visit www.oracle.com if you need additional information or have any - * questions. - */ - -/* - * @test - * @bug 8072945 - * @summary test HTML version - * @library .. - * @modules jdk.javadoc/jdk.javadoc.internal.doclint - * @build DocLintTester - * @run main DocLintTester -XhtmlVersion:html5 HtmlVersionTest.java - * @run main DocLintTester -XhtmlVersion:html4 HtmlVersionTest.java - * @run main DocLintTester -badargs -XhtmlVersion: HtmlVersionTest.java - * @run main DocLintTester HtmlVersionTest.java - */ - -/** - * Test HTML version option. - */ -public class HtmlVersionTest { -} diff --git a/test/langtools/tools/doclint/anchorTests/p/Test.java b/test/langtools/tools/doclint/anchorTests/p/Test.java index bc734c9eb5b24..a46f994cce18f 100644 --- a/test/langtools/tools/doclint/anchorTests/p/Test.java +++ b/test/langtools/tools/doclint/anchorTests/p/Test.java @@ -1,5 +1,5 @@ /* @test /nodynamiccopyright/ - * @bug 8025246 + * @bug 8025246 8247957 * @summary doclint is showing error on anchor already defined when it's not * @library ../.. * @modules jdk.javadoc/jdk.javadoc.internal.doclint @@ -11,43 +11,43 @@ package p; /** - * dupTest - * dupTest again + * dupTest + * dupTest again * - * dupTestField - * dupTestMethod + * dupTestField + * dupTestMethod - * okClass - * okField - * okMethod + * okClass + * okField + * okMethod */ public class Test { - /** dupTestField again */ + /** dupTestField again */ public int f; - /** dupTestMethod again */ + /** dupTestMethod again */ public void m() { } /** - * dupNested - * dupNested again - * dupNestedField - * dupNestedMethod + * dupNested + * dupNested again + * dupNestedField + * dupNestedMethod * - * okClass again + * okClass again */ public class Nested { /** - * dupNestedField + * dupNestedField * - * okField again + * okField again */ public int f; /** - * dupNestedMethod + * dupNestedMethod * - * okMethod again + * okMethod again */ public void m() { } } diff --git a/test/langtools/tools/doclint/anchorTests/p/Test.out b/test/langtools/tools/doclint/anchorTests/p/Test.out index 3448c423e98f3..e55d25aaf3d09 100644 --- a/test/langtools/tools/doclint/anchorTests/p/Test.out +++ b/test/langtools/tools/doclint/anchorTests/p/Test.out @@ -1,19 +1,19 @@ Test.java:15: error: anchor already defined: "dupTest" - * dupTest again + * dupTest again ^ Test.java:25: error: anchor already defined: "dupTestField" - /** dupTestField again */ + /** dupTestField again */ ^ Test.java:28: error: anchor already defined: "dupTestMethod" - /** dupTestMethod again */ + /** dupTestMethod again */ ^ Test.java:33: error: anchor already defined: "dupNested" - * dupNested again + * dupNested again ^ Test.java:41: error: anchor already defined: "dupNestedField" - * dupNestedField + * dupNestedField ^ Test.java:48: error: anchor already defined: "dupNestedMethod" - * dupNestedMethod + * dupNestedMethod ^ 6 errors diff --git a/test/langtools/tools/doclint/anchorTests/p/package-info.java b/test/langtools/tools/doclint/anchorTests/p/package-info.java index 9a586ad6af0e3..75915015506d3 100644 --- a/test/langtools/tools/doclint/anchorTests/p/package-info.java +++ b/test/langtools/tools/doclint/anchorTests/p/package-info.java @@ -1,5 +1,5 @@ /* @test /nodynamiccopyright/ - * @bug 8025246 + * @bug 8025246 8247957 * @summary doclint is showing error on anchor already defined when it's not * @library ../.. * @modules jdk.javadoc/jdk.javadoc.internal.doclint @@ -9,8 +9,10 @@ */ /** - * here - * here again + * here + * here again + * obsolete anchor + * obsolete anchor again */ package p; diff --git a/test/langtools/tools/doclint/anchorTests/p/package-info.javac.out b/test/langtools/tools/doclint/anchorTests/p/package-info.javac.out index f6b8948560d9a..6edee352de817 100644 --- a/test/langtools/tools/doclint/anchorTests/p/package-info.javac.out +++ b/test/langtools/tools/doclint/anchorTests/p/package-info.javac.out @@ -1,2 +1,4 @@ package-info.java:13:7: compiler.err.proc.messager: anchor already defined: "here" -1 error +package-info.java:14:7: compiler.err.proc.messager: attribute not supported in HTML5: name +package-info.java:15:7: compiler.err.proc.messager: attribute not supported in HTML5: name +3 errors diff --git a/test/langtools/tools/doclint/anchorTests/p/package-info.out b/test/langtools/tools/doclint/anchorTests/p/package-info.out index 4eaa98adc9c05..1594f46653857 100644 --- a/test/langtools/tools/doclint/anchorTests/p/package-info.out +++ b/test/langtools/tools/doclint/anchorTests/p/package-info.out @@ -1,4 +1,10 @@ package-info.java:13: error: anchor already defined: "here" - * here again + * here again ^ -1 error +package-info.java:14: error: attribute not supported in HTML5: name + * obsolete anchor + ^ +package-info.java:15: error: attribute not supported in HTML5: name + * obsolete anchor again + ^ +3 errors diff --git a/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java b/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java index 21da610ff310d..4e699232de26c 100644 --- a/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java +++ b/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java @@ -1,14 +1,11 @@ /* * @test /nodynamiccopyright/ - * @bug 8072945 + * @bug 8072945 8247957 * @summary test tags and attributes specific to the output HTML version * @library .. * @modules jdk.javadoc/jdk.javadoc.internal.doclint * @build DocLintTester - * @run main DocLintTester -XhtmlVersion:html5 -ref HtmlVersionTagsAttrsTestHtml5.out HtmlVersionTagsAttrsTest.java - * @run main DocLintTester -XhtmlVersion:html4 -ref HtmlVersionTagsAttrsTestHtml4.out HtmlVersionTagsAttrsTest.java - * @run main DocLintTester -badargs -XhtmlVersion: HtmlVersionTagsAttrsTest.java - * @run main DocLintTester -ref HtmlVersionTagsAttrsTestHtml4.out HtmlVersionTagsAttrsTest.java + * @run main DocLintTester -Xmaxerrs 200 -ref HtmlVersionTagsAttrsTest.out HtmlVersionTagsAttrsTest.java */ /** @@ -73,7 +70,7 @@ public class HtmlVersionTagsAttrsTest { * Test border * */ - public void SupportedAttrs_in_html4_not_in_html5() { } + public void notSupportedAttrs_html5() { } /** *
      @@ -88,7 +85,7 @@ public void SupportedAttrs_in_html4_not_in_html5() { } *

      Label test

      * */ - public void SupportedAttrs_in_html5_not_in_html4() { } + public void SupportedAttrs_html5() { } /** *

      Bigger text test

      @@ -156,7 +153,7 @@ public void notSupportedTags_html5() { } *

      Test current time is at night

      *

      Test WBR text

      */ - public void SupportedTags_in_html5_not_in_html4() { } + public void SupportedTags_html5() { } /** *
      diff --git a/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTestHtml5.out b/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.out similarity index 65% rename from test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTestHtml5.out rename to test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.out index 9c51141bd5a19..69b31d53831f4 100644 --- a/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTestHtml5.out +++ b/test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.out @@ -1,299 +1,314 @@ -HtmlVersionTagsAttrsTest.java:19: error: attribute not supported in HTML5: rev +HtmlVersionTagsAttrsTest.java:16: error: attribute not supported in HTML5: rev * Help Page ^ -HtmlVersionTagsAttrsTest.java:20: error: attribute not supported in HTML5: charset +HtmlVersionTagsAttrsTest.java:17: error: attribute not supported in HTML5: charset * Test page ^ -HtmlVersionTagsAttrsTest.java:21: error: attribute not supported in HTML5: shape +HtmlVersionTagsAttrsTest.java:18: error: attribute not supported in HTML5: shape * Location ^ -HtmlVersionTagsAttrsTest.java:21: error: attribute not supported in HTML5: coords +HtmlVersionTagsAttrsTest.java:18: error: attribute not supported in HTML5: coords * Location ^ -HtmlVersionTagsAttrsTest.java:22: error: attribute not supported in HTML5: name +HtmlVersionTagsAttrsTest.java:19: error: attribute not supported in HTML5: name * alt ^ -HtmlVersionTagsAttrsTest.java:24: error: attribute not supported in HTML5: axis +HtmlVersionTagsAttrsTest.java:21: error: attribute not supported in HTML5: axis * Description ^ -HtmlVersionTagsAttrsTest.java:25: error: attribute not supported in HTML5: axis +HtmlVersionTagsAttrsTest.java:22: error: attribute not supported in HTML5: axis * Axis_Test ^ -HtmlVersionTagsAttrsTest.java:25: error: attribute not supported in HTML5: abbr +HtmlVersionTagsAttrsTest.java:22: error: attribute not supported in HTML5: abbr * Axis_Test ^ -HtmlVersionTagsAttrsTest.java:25: error: attribute not supported in HTML5: scope +HtmlVersionTagsAttrsTest.java:22: error: attribute not supported in HTML5: scope * Axis_Test ^ -HtmlVersionTagsAttrsTest.java:26: error: no summary or caption for table +HtmlVersionTagsAttrsTest.java:23: error: no caption for table * ^ -HtmlVersionTagsAttrsTest.java:27: error: attribute not supported in HTML5: summary +HtmlVersionTagsAttrsTest.java:24: error: attribute not supported in HTML5: summary *
      Test Row
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: bgcolor +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: bgcolor *
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: cellpadding +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: cellpadding *
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: cellspacing +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: cellspacing *
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: frame +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: frame *
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: rules +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: rules *
      ^ -HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:26: error: attribute not supported in HTML5: width *
      ^ -HtmlVersionTagsAttrsTest.java:30: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:27: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:32: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:32: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:32: error: attribute not supported in HTML5: valign +HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: valign * ^ -HtmlVersionTagsAttrsTest.java:32: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: width * ^ -HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:30: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: valign +HtmlVersionTagsAttrsTest.java:30: error: attribute not supported in HTML5: valign * ^ -HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:30: error: attribute not supported in HTML5: width * ^ -HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:31: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:31: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:31: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:36: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:36: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:36: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:37: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:33: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:37: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:37: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:37: error: attribute not supported in HTML5: bgcolor +HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: bgcolor * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:34: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: bgcolor +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: bgcolor * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: height +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: height * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: width * ^ -HtmlVersionTagsAttrsTest.java:38: error: attribute not supported in HTML5: nowrap +HtmlVersionTagsAttrsTest.java:35: error: attribute not supported in HTML5: nowrap * ^ -HtmlVersionTagsAttrsTest.java:42: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:39: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:42: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:39: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:42: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:39: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:48: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:39: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:45: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:48: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:45: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:48: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:45: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:45: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: align * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: char +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: char * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: charoff +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: charoff * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: bgcolor +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: bgcolor * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: height +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: height * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: valign + * + ^ +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: width * ^ -HtmlVersionTagsAttrsTest.java:50: error: attribute not supported in HTML5: nowrap +HtmlVersionTagsAttrsTest.java:47: error: attribute not supported in HTML5: nowrap * ^ -HtmlVersionTagsAttrsTest.java:55: error: attribute not supported in HTML5: clear +HtmlVersionTagsAttrsTest.java:52: error: attribute not supported in HTML5: clear *
      ^ -HtmlVersionTagsAttrsTest.java:56: error: attribute not supported in HTML5: compact +HtmlVersionTagsAttrsTest.java:53: error: attribute not supported in HTML5: compact *
        ^ -HtmlVersionTagsAttrsTest.java:60: error: attribute not supported in HTML5: type +HtmlVersionTagsAttrsTest.java:57: error: attribute not supported in HTML5: type *
          ^ -HtmlVersionTagsAttrsTest.java:60: error: attribute not supported in HTML5: compact +HtmlVersionTagsAttrsTest.java:57: error: attribute not supported in HTML5: compact *
            ^ -HtmlVersionTagsAttrsTest.java:61: error: attribute not supported in HTML5: type +HtmlVersionTagsAttrsTest.java:58: error: attribute not supported in HTML5: type *
          • Test list
          • ^ -HtmlVersionTagsAttrsTest.java:64: error: attribute not supported in HTML5: compact +HtmlVersionTagsAttrsTest.java:61: error: attribute not supported in HTML5: compact *
            ^ -HtmlVersionTagsAttrsTest.java:68: error: attribute not supported in HTML5: hspace +HtmlVersionTagsAttrsTest.java:65: error: attribute not supported in HTML5: hspace * imgTest ^ -HtmlVersionTagsAttrsTest.java:68: error: attribute not supported in HTML5: vspace +HtmlVersionTagsAttrsTest.java:65: error: attribute not supported in HTML5: vspace * imgTest ^ -HtmlVersionTagsAttrsTest.java:68: error: attribute not supported in HTML5: border +HtmlVersionTagsAttrsTest.java:65: error: attribute not supported in HTML5: border * imgTest ^ -HtmlVersionTagsAttrsTest.java:69: error: attribute not supported in HTML5: size +HtmlVersionTagsAttrsTest.java:66: error: attribute not supported in HTML5: size *
            ^ -HtmlVersionTagsAttrsTest.java:69: error: attribute not supported in HTML5: noshade +HtmlVersionTagsAttrsTest.java:66: error: attribute not supported in HTML5: noshade *
            ^ -HtmlVersionTagsAttrsTest.java:70: error: attribute not supported in HTML5: width +HtmlVersionTagsAttrsTest.java:67: error: attribute not supported in HTML5: width *
            Test Pre
            ^ -HtmlVersionTagsAttrsTest.java:71: error: attribute not supported in HTML5: name +HtmlVersionTagsAttrsTest.java:68: error: attribute not supported in HTML5: name * Anchor Test ^ -HtmlVersionTagsAttrsTest.java:72: error: attribute border for table only accepts "" or "1", use CSS instead: BORDER +HtmlVersionTagsAttrsTest.java:69: error: attribute "border" for table only accepts "" or "1": BORDER *
      Test table, caption, col, colgroup, tbody, ^ -HtmlVersionTagsAttrsTest.java:32: error: attribute not supported in HTML5: align +HtmlVersionTagsAttrsTest.java:29: error: attribute not supported in HTML5: align *
      HeadCol1HeadCol1HeadCol1HeadCol1HeadCol1HeadCol1HeadCol1HeadCol1
      BodyCol1BodyCol1BodyCol1BodyCol1BodyCol1BodyCol1BodyCol1BodyCol1
      ^ -HtmlVersionTagsAttrsTest.java:74: error: no summary or caption for table +HtmlVersionTagsAttrsTest.java:71: error: no caption for table *
      ^ -HtmlVersionTagsAttrsTest.java:94: error: tag not supported in the generated HTML version: big +HtmlVersionTagsAttrsTest.java:91: error: tag not supported in HTML5: big *

      Bigger text test

      ^ -HtmlVersionTagsAttrsTest.java:94: warning: empty

      tag +HtmlVersionTagsAttrsTest.java:91: warning: empty

      tag *

      Bigger text test

      ^ -HtmlVersionTagsAttrsTest.java:95: error: tag not supported in the generated HTML version: center +HtmlVersionTagsAttrsTest.java:92: error: tag not supported in HTML5: center *
      Center text test
      ^ -HtmlVersionTagsAttrsTest.java:96: error: tag not supported in the generated HTML version: font +HtmlVersionTagsAttrsTest.java:93: error: tag not supported in HTML5: font * Font test ^ -HtmlVersionTagsAttrsTest.java:96: error: attribute not supported in HTML5: size - * Font test - ^ -HtmlVersionTagsAttrsTest.java:97: error: tag not supported in the generated HTML version: strike +HtmlVersionTagsAttrsTest.java:94: error: tag not supported in HTML5: strike *

      Text strike

      ^ -HtmlVersionTagsAttrsTest.java:98: error: tag not supported in the generated HTML version: tt +HtmlVersionTagsAttrsTest.java:95: error: tag not supported in HTML5: tt *

      Teletype text

      ^ -HtmlVersionTagsAttrsTest.java:98: warning: empty

      tag +HtmlVersionTagsAttrsTest.java:95: warning: empty

      tag *

      Teletype text

      ^ -HtmlVersionTagsAttrsTest.java:100: error: unknown tag: hgroup +HtmlVersionTagsAttrsTest.java:97: error: unknown tag: hgroup *
      ^ -HtmlVersionTagsAttrsTest.java:103: error: unknown tag: hgroup +HtmlVersionTagsAttrsTest.java:100: error: unknown tag: hgroup *
      ^ -HtmlVersionTagsAttrsTest.java:106: error: unknown tag: details +HtmlVersionTagsAttrsTest.java:103: error: unknown tag: details *
      ^ -HtmlVersionTagsAttrsTest.java:107: error: unknown tag: summary +HtmlVersionTagsAttrsTest.java:104: error: unknown tag: summary * Summary ^ -HtmlVersionTagsAttrsTest.java:107: error: unknown tag: summary +HtmlVersionTagsAttrsTest.java:104: error: unknown tag: summary * Summary ^ -HtmlVersionTagsAttrsTest.java:109: error: unknown tag: details +HtmlVersionTagsAttrsTest.java:106: error: unknown tag: details *
      ^ -HtmlVersionTagsAttrsTest.java:132: error: element not allowed in documentation comments:
      +HtmlVersionTagsAttrsTest.java:129: error: element not allowed in documentation comments:
      *
      ^ -HtmlVersionTagsAttrsTest.java:164: error: heading not found for
      +HtmlVersionTagsAttrsTest.java:161: error: heading not found for * ^ -HtmlVersionTagsAttrsTest.java:167: error: heading not found for +HtmlVersionTagsAttrsTest.java:164: error: heading not found for * ^ -HtmlVersionTagsAttrsTest.java:169: error: tag not allowed here:
      +HtmlVersionTagsAttrsTest.java:166: error: tag not allowed here:
      *
      ^ -HtmlVersionTagsAttrsTest.java:172: error: tag not allowed here: