Skip to content
Permalink
Browse files
8258058: improve description of OutOfMemoryError relevant flags
OutOfMemoryError thrown out of JVM doesn't notify hotspot, so debug.cpp::report_java_out_out_memory does not handle it. ie. Some options don't respect OOMEs from Java libraries.  We need to make the description more clear to users.

Reviewed-by: dholmes, jiefu
  • Loading branch information
Xin Liu authored and DamonFool committed Dec 16, 2020
1 parent cdb5342 commit 0c8cc2cde47bed3d5c3edc203869068a0676812b
Showing 1 changed file with 7 additions and 4 deletions.
@@ -541,7 +541,8 @@ const intx ObjectAlignmentInBytes = 8;
"for examples") \
\
product(ccstrlist, OnOutOfMemoryError, "", \
"Run user-defined commands on first java.lang.OutOfMemoryError") \
"Run user-defined commands on first java.lang.OutOfMemoryError " \
"thrown from JVM") \
\
product(bool, HeapDumpBeforeFullGC, false, MANAGEABLE, \
"Dump heap to file before any major stop-the-world GC") \
@@ -550,7 +551,8 @@ const intx ObjectAlignmentInBytes = 8;
"Dump heap to file after any major stop-the-world GC") \
\
product(bool, HeapDumpOnOutOfMemoryError, false, MANAGEABLE, \
"Dump heap to file when java.lang.OutOfMemoryError is thrown") \
"Dump heap to file when java.lang.OutOfMemoryError is thrown " \
"from JVM") \
\
product(ccstr, HeapDumpPath, NULL, MANAGEABLE, \
"When HeapDumpOnOutOfMemoryError is on, the path (filename or " \
@@ -867,11 +869,12 @@ const intx ObjectAlignmentInBytes = 8;
range(0, 2) \
\
product(bool, ExitOnOutOfMemoryError, false, \
"JVM exits on the first occurrence of an out-of-memory error") \
"JVM exits on the first occurrence of an out-of-memory error " \
"thrown from JVM") \
\
product(bool, CrashOnOutOfMemoryError, false, \
"JVM aborts, producing an error log and core/mini dump, on the " \
"first occurrence of an out-of-memory error") \
"first occurrence of an out-of-memory error thrown from JVM") \
\
/* tracing */ \
\

1 comment on commit 0c8cc2c

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 0c8cc2c Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.