Skip to content

Commit

Permalink
8318479: [jmh] the test security.CacheBench failed for multiple threa…
Browse files Browse the repository at this point in the history
…ds run

Reviewed-by: redestad
  • Loading branch information
djelinski committed Nov 14, 2023
1 parent 95bd92a commit 1535528
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/micro/org/openjdk/bench/java/security/CacheBench.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@Fork(value = 3, jvmArgsAppend = {"--add-exports", "java.base/sun.security.util=ALL-UNNAMED", "-Xmx1g"})
@Fork(value = 3, jvmArgsAppend = {"--add-exports", "java.base/sun.security.util=ALL-UNNAMED"})
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
public class CacheBench {
Expand Down

7 comments on commit 1535528

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 1535528 May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-1535528c in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1535528c from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jeliński on 14 Nov 2023 and was reviewed by Claes Redestad.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-1535528c:backport-sendaoYan-1535528c
$ git checkout backport-sendaoYan-1535528c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-1535528c

@openjdk
Copy link

@openjdk openjdk bot commented on 1535528 May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan Could not automatically backport 1535528c to openjdk/jdk17u-dev due to conflicts in the following files:

  • test/micro/org/openjdk/bench/java/security/CacheBench.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk17u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-sendaoYan-1535528c

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 1535528cb119195b44244e8ee6bc0f913caa9270

# Backport the commit
$ git cherry-pick --no-commit 1535528cb119195b44244e8ee6bc0f913caa9270
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 1535528cb119195b44244e8ee6bc0f913caa9270'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Backport 1535528cb119195b44244e8ee6bc0f913caa9270.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1535528c from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jeliński on 14 Nov 2023 and was reviewed by Claes Redestad.

Thanks!

@sendaoYan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 1535528 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-1535528c in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1535528c from the openjdk/jdk repository.

The commit being backported was authored by Daniel Jeliński on 14 Nov 2023 and was reviewed by Claes Redestad.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-sendaoYan-1535528c:backport-sendaoYan-1535528c
$ git checkout backport-sendaoYan-1535528c
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-sendaoYan-1535528c

Please sign in to comment.