Skip to content

Commit 154b8cf

Browse files
author
Kim Barrett
committed
8253014: OopStorage bulk release logs entries multiple times
Remove excess logging. Reviewed-by: shade, tschatzl
1 parent ba174af commit 154b8cf

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/hotspot/share/gc/shared/oopStorage.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ void OopStorage::release(const oop* ptr) {
697697
check_release_entry(ptr);
698698
Block* block = find_block_or_null(ptr);
699699
assert(block != NULL, "%s: invalid release " PTR_FORMAT, name(), p2i(ptr));
700-
log_trace(oopstorage, ref)("%s: released " PTR_FORMAT, name(), p2i(ptr));
700+
log_trace(oopstorage, ref)("%s: releasing " PTR_FORMAT, name(), p2i(ptr));
701701
block->release_entries(block->bitmask_for_entry(ptr), this);
702702
Atomic::dec(&_allocation_count);
703703
}
@@ -708,7 +708,6 @@ void OopStorage::release(const oop* const* ptrs, size_t size) {
708708
check_release_entry(ptrs[i]);
709709
Block* block = find_block_or_null(ptrs[i]);
710710
assert(block != NULL, "%s: invalid release " PTR_FORMAT, name(), p2i(ptrs[i]));
711-
log_trace(oopstorage, ref)("%s: released " PTR_FORMAT, name(), p2i(ptrs[i]));
712711
size_t count = 0;
713712
uintx releasing = 0;
714713
for ( ; i < size; ++i) {
@@ -717,7 +716,7 @@ void OopStorage::release(const oop* const* ptrs, size_t size) {
717716
// If entry not in block, finish block and resume outer loop with entry.
718717
if (!block->contains(entry)) break;
719718
// Add entry to releasing bitmap.
720-
log_trace(oopstorage, ref)("%s: released " PTR_FORMAT, name(), p2i(entry));
719+
log_trace(oopstorage, ref)("%s: releasing " PTR_FORMAT, name(), p2i(entry));
721720
uintx entry_bitmask = block->bitmask_for_entry(entry);
722721
assert((releasing & entry_bitmask) == 0,
723722
"Duplicate entry: " PTR_FORMAT, p2i(entry));

0 commit comments

Comments
 (0)