Skip to content

Commit

Permalink
8297602: Compiler crash with type annotation and generic record durin…
Browse files Browse the repository at this point in the history
…g pattern matching

Reviewed-by: jlahoda
  • Loading branch information
biboudis authored and lahodaj committed Dec 6, 2022
1 parent b0e5432 commit 1e46832
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,11 @@ private Attribute.TypeCompound toTypeCompound(Attribute.Compound a, TypeAnnotati
newPath, currentLambda,
outer_type_index, location);
}

case DECONSTRUCTION_PATTERN: {
// TODO: Treat case labels as full type contexts for complete type annotation support in Record Patterns
// https://bugs.openjdk.org/browse/JDK-8298154
return TypeAnnotationPosition.unknown;
}
default:
throw new AssertionError("Unresolved frame: " + frame +
" of kind: " + frame.getKind() +
Expand Down
52 changes: 52 additions & 0 deletions test/langtools/tools/javac/T8297602.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8297602
* @summary Compiler crash with type annotation and generic record during pattern matching
* @enablePreview
* @compile --enable-preview -source ${jdk.version} -XDrawDiagnostics T8297602.java
*/
import java.lang.annotation.ElementType;
import java.lang.annotation.Target;

public class T8297602
{
void meth(Foo<Integer> p) {
switch(p) {
case Foo<@Annot(field = "") Integer>(): {}
};

if (p instanceof Foo<@Annot(field = "") Integer>()) {

}
}

@Target({ElementType.TYPE_USE})
@interface Annot {
String field();
}

record Foo<T>() { }
}

1 comment on commit 1e46832

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.