Skip to content
Permalink
Browse files
8272720: Fix the implementation of loop unrolling heuristic with Loop…
…PercentProfileLimit

Reviewed-by: thartmann, rbackman
  • Loading branch information
DamonFool committed Aug 20, 2021
1 parent 86add21 commit 1ea437a4b87381b558cf8157ac52fc03e37ac507
Showing 1 changed file with 1 addition and 1 deletion.
@@ -905,7 +905,7 @@ bool IdealLoopTree::policy_unroll(PhaseIdealLoop *phase) {
// Progress defined as current size less than 20% larger than previous size.
if (UseSuperWord && cl->node_count_before_unroll() > 0 &&
future_unroll_cnt > LoopUnrollMin &&
(future_unroll_cnt - 1) * (100 / LoopPercentProfileLimit) > cl->profile_trip_cnt() &&
(future_unroll_cnt - 1) * (100.0 / LoopPercentProfileLimit) > cl->profile_trip_cnt() &&
1.2 * cl->node_count_before_unroll() < (double)_body.size()) {
return false;
}

3 comments on commit 1ea437a

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 1ea437a Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented on 1ea437a Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 1ea437a Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DamonFool @DamonFool the backport was successfully created on the branch DamonFool-backport-1ea437a4 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit 1ea437a4 from the openjdk/jdk repository.

The commit being backported was authored by Jie Fu on 20 Aug 2021 and was reviewed by Tobias Hartmann and Rickard Bäckman.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev DamonFool-backport-1ea437a4:DamonFool-backport-1ea437a4
$ git checkout DamonFool-backport-1ea437a4
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev DamonFool-backport-1ea437a4

Please sign in to comment.