Skip to content

Commit

Permalink
8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:Shared…
Browse files Browse the repository at this point in the history
…ArchiveFile options are specified

Reviewed-by: iklam, ccheung
  • Loading branch information
yminqi committed Apr 23, 2021
1 parent 6803ab2 commit 20a373a
Show file tree
Hide file tree
Showing 6 changed files with 506 additions and 363 deletions.
8 changes: 8 additions & 0 deletions src/hotspot/os/posix/os_posix.cpp
Expand Up @@ -852,6 +852,14 @@ char * os::native_path(char *path) {
}

bool os::same_files(const char* file1, const char* file2) {
if (file1 == nullptr && file2 == nullptr) {
return true;
}

if (file1 == nullptr || file2 == nullptr) {
return false;
}

if (strcmp(file1, file2) == 0) {
return true;
}
Expand Down
3 changes: 2 additions & 1 deletion test/hotspot/jtreg/TEST.groups
Expand Up @@ -324,7 +324,8 @@ hotspot_appcds_dynamic = \
-runtime/cds/appcds/javaldr/GCSharedStringsDuringDump.java \
-runtime/cds/appcds/javaldr/HumongousDuringDump.java \
-runtime/cds/appcds/javaldr/LockDuringDump.java \
-runtime/cds/appcds/jcmd/JCmdTest.java \
-runtime/cds/appcds/jcmd/JCmdTestStaticDump.java \
-runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java \
-runtime/cds/appcds/methodHandles \
-runtime/cds/appcds/sharedStrings \
-runtime/cds/appcds/ArchiveRelocationTest.java \
Expand Down
362 changes: 0 additions & 362 deletions test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTest.java

This file was deleted.

1 comment on commit 20a373a

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.