Skip to content

Commit

Permalink
6244831: JFileChooser does not have tooltip for Desktop, Recent etc T…
Browse files Browse the repository at this point in the history
…oggleButton on Windows Look and feel

Reviewed-by: psadhukhan
  • Loading branch information
Tejesh R committed Oct 27, 2022
1 parent c2d7a35 commit 210fe49
Show file tree
Hide file tree
Showing 2 changed files with 112 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public WindowsPlacesBar(JFileChooser fc, boolean isXPStyle) {
buttons[i].setPreferredSize(buttonSize);
buttons[i].setMaximumSize(buttonSize);
buttons[i].addActionListener(this);
buttons[i].setToolTipText(folderName);
add(buttons[i]);
if (i < files.length-1 && isXPStyle) {
add(Box.createRigidArea(new Dimension(1, 1)));
Expand Down
111 changes: 111 additions & 0 deletions test/jdk/javax/swing/JFileChooser/FileChooserToolTipTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.awt.BorderLayout;
import java.awt.Dimension;
import java.awt.Point;
import java.awt.Robot;

import javax.swing.JFrame;
import javax.swing.JFileChooser;
import javax.swing.JToolTip;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.WindowConstants;

/*
* @test
* @bug 6616245
* @key headful
* @requires (os.family == "windows")
* @library ../regtesthelpers
* @build Util
* @summary Test to check if ToolTip is shown for shell folders
* @run main FileChooserToolTipTest
*/
public class FileChooserToolTipTest {
static Robot robot;
static JFrame frame;
public static void main(String[] args) throws Exception {
UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
robot = new Robot();
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
initialize();
}
});
robot.delay(1000);
robot.waitForIdle();
Point movePoint = getFramePoint(frame);
robot.mouseMove(movePoint.x, movePoint.y);
robot.delay(2000);
robot.waitForIdle();
handleToolTip();
System.out.println("Test Pass");
}

static void initialize() {
JFileChooser jfc;
frame = new JFrame("JFileChooser ToolTip test");
jfc = new JFileChooser();
frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
frame.add(jfc, BorderLayout.CENTER);
frame.pack();
frame.setVisible(true);
}

static Point getFramePoint(JFrame frame) throws Exception {
final Point[] result = new Point[1];

SwingUtilities.invokeAndWait(new Runnable() {
@Override
public void run() {
Point p = frame.getLocationOnScreen();
Dimension size = frame.getSize();
result[0] = new Point(p.x + size.width / 10, p.y + size.height / 2);
}
});
return result[0];
}

static void handleToolTip() throws Exception {
SwingUtilities.invokeAndWait(new Runnable() {
@Override
public void run() {
try {
JToolTip tooltip = (JToolTip) Util.findSubComponent(
JFrame.getFrames()[0], "JToolTip");

if (tooltip == null) {
throw new RuntimeException("Basic Tooltip not been found");
}
System.out.println("ToolTp :"+tooltip.getTipText());

} catch (Exception e) {
throw new RuntimeException(e);
} finally {
frame.dispose();
}
}
});
}
}

1 comment on commit 210fe49

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.