Skip to content
Permalink
Browse files
8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find t…
…oo_many string in output

Reviewed-by: dholmes
  • Loading branch information
Daniel D. Daugherty committed Nov 25, 2021
1 parent a81e4fc commit 21e302a0f4cbf3ace907c36d871a2f2cf6277188
Showing 1 changed file with 10 additions and 2 deletions.
@@ -81,6 +81,11 @@ public static void main(String[] args) throws Exception {
// of monitors for threads that call Object.wait().
"-XX:+UnlockDiagnosticVMOptions",
"-XX:AvgMonitorsPerThreadEstimate=1",
// MonitorUsedDeflationThreshold == 10 means we'll request
// deflations when 10% of monitors are used rather than the
// default 90%. This should allow the test to tolerate a burst
// of used monitors by threads not under this test's control.
"-XX:MonitorUsedDeflationThreshold=10",
// Enable monitorinflation logging so we can see that
// MonitorUsedDeflationThreshold and
// NoAsyncDeflationProgressMaxoption are working.
@@ -89,8 +94,9 @@ public static void main(String[] args) throws Exception {
"-Xlog:safepoint+cleanup=info",
"-Xlog:safepoint+stats=debug",
// Run the test with inflate_count == 33 since that
// reproduced the bug with JDK13. Anything above the
// in_use_list_ceiling will do the trick.
// reproduced the bug with JDK13. With inflate_count == 33, an
// initial ceiling == 12 and MonitorUsedDeflationThreshold == 10,
// we should hit NoAsyncDeflationProgressMax at least 3 times.
"MonitorUsedDeflationThresholdTest", "33");

OutputAnalyzer output_detail = new OutputAnalyzer(pb.start());
@@ -111,6 +117,8 @@ public static void main(String[] args) throws Exception {
throw new RuntimeException("Did not find too_many string in output.\n");
}
System.out.println("too_many='" + too_many + "'");
// Uncomment the following line for dumping test output in passing runs:
// output_detail.reportDiagnosticSummary();

System.out.println("PASSED.");
return;

3 comments on commit 21e302a

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 21e302a Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 21e302a Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 21e302a Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-21e302a0 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 21e302a0 from the openjdk/jdk repository.

The commit being backported was authored by Daniel D. Daugherty on 25 Nov 2021 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-21e302a0:GoeLin-backport-21e302a0
$ git checkout GoeLin-backport-21e302a0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-21e302a0

Please sign in to comment.