Skip to content

Commit

Permalink
8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PRO…
Browse files Browse the repository at this point in the history
…C_ROOT (after JDK-8327114)

Reviewed-by: kevinw
  • Loading branch information
jerboaa committed Oct 3, 2024
1 parent 7d524d7 commit 21f8ccf
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.file.Paths;
import java.util.Arrays;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.EnumSet;
import java.util.List;
Expand All @@ -52,7 +52,9 @@
import java.util.function.Consumer;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

import jdk.test.lib.Container;
import jdk.test.lib.Platform;
import jdk.test.lib.Utils;
import jdk.test.lib.containers.docker.Common;
import jdk.test.lib.containers.docker.DockerRunOptions;
Expand Down Expand Up @@ -108,6 +110,11 @@ public static void main(String[] args) throws Exception {
mainContainer.waitForMainMethodStart(TIME_TO_WAIT_FOR_MAIN_METHOD_START);

for (AttachStrategy attachStrategy : EnumSet.allOf(AttachStrategy.class)) {
if (attachStrategy == AttachStrategy.ACCESS_TMP_VIA_PROC_ROOT &&
elevated && !Platform.isRoot()) {
// Elevated attach via proc/root not yet supported.
continue;
}
long mainProcPid = testCase01(attachStrategy, elevated);

// Excluding the test case below until JDK-8228850 is fixed
Expand Down

1 comment on commit 21f8ccf

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.