Skip to content

Commit

Permalink
8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
Browse files Browse the repository at this point in the history 
Reviewed-by: mdoerr, clanger
  • Loading branch information
@MBaesken
MBaesken committed Apr 19, 2024
1 parent 32946e1 commit 252c62a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2021 SAP SE. All rights reserved.
* Copyright (c) 2012, 2024 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -254,7 +254,7 @@ bool PosixSignals::pd_hotspot_signal_handler(int sig, siginfo_t* info,
stub = SharedRuntime::get_handle_wrong_method_stub();
}

else if ((sig == USE_POLL_BIT_ONLY ? SIGTRAP : SIGSEGV) &&
else if ((sig == (USE_POLL_BIT_ONLY ? SIGTRAP : SIGSEGV)) &&
// A linux-ppc64 kernel before 2.6.6 doesn't set si_addr on some segfaults
// in 64bit mode (cf. http://www.kernel.org/pub/linux/kernel/v2.6/ChangeLog-2.6.6),
// especially when we try to read from the safepoint polling page. So the check
Expand Down

5 comments on commit 252c62a

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 252c62a May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken Could not automatically backport 252c62a6 to openjdk/jdk21u-dev due to conflicts in the following files:

  • src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-MBaesken-252c62a6

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 252c62a66dd955a5d22f307544f38cc0dd4f2550

# Backport the commit
$ git cherry-pick --no-commit 252c62a66dd955a5d22f307544f38cc0dd4f2550
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 252c62a6 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 19 Apr 2024 and was reviewed by Martin Doerr and Christoph Langer.

Thanks!

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on 252c62a May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken Could not automatically backport 252c62a6 to openjdk/jdk22u due to conflicts in the following files:

  • src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk22u. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk22u.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-MBaesken-252c62a6

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 252c62a66dd955a5d22f307544f38cc0dd4f2550

# Backport the commit
$ git cherry-pick --no-commit 252c62a66dd955a5d22f307544f38cc0dd4f2550
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk22u with the title Backport 252c62a66dd955a5d22f307544f38cc0dd4f2550.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 252c62a6 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 19 Apr 2024 and was reviewed by Martin Doerr and Christoph Langer.

Thanks!

Please sign in to comment.