Skip to content

Commit 27c58c0

Browse files
author
Thomas Schatzl
committed
8362271: G1: Improve G1CollectorState::clearing_bitmap name
Reviewed-by: sangheki
1 parent cbb3d23 commit 27c58c0

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/hotspot/share/gc/g1/g1CollectorState.hpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -65,7 +65,7 @@ class G1CollectorState {
6565
bool _mark_or_rebuild_in_progress;
6666

6767
// The marking bitmap is currently being cleared or about to be cleared.
68-
bool _clearing_bitmap;
68+
bool _clear_bitmap_in_progress;
6969

7070
// Set during a full gc pause.
7171
bool _in_full_gc;
@@ -79,7 +79,7 @@ class G1CollectorState {
7979
_initiate_conc_mark_if_possible(false),
8080

8181
_mark_or_rebuild_in_progress(false),
82-
_clearing_bitmap(false),
82+
_clear_bitmap_in_progress(false),
8383
_in_full_gc(false) { }
8484

8585
// Phase setters
@@ -93,7 +93,7 @@ class G1CollectorState {
9393
void set_initiate_conc_mark_if_possible(bool v) { _initiate_conc_mark_if_possible = v; }
9494

9595
void set_mark_or_rebuild_in_progress(bool v) { _mark_or_rebuild_in_progress = v; }
96-
void set_clearing_bitmap(bool v) { _clearing_bitmap = v; }
96+
void set_clear_bitmap_in_progress(bool v) { _clear_bitmap_in_progress = v; }
9797

9898
// Phase getters
9999
bool in_young_only_phase() const { return _in_young_only_phase && !_in_full_gc; }
@@ -107,7 +107,7 @@ class G1CollectorState {
107107
bool initiate_conc_mark_if_possible() const { return _initiate_conc_mark_if_possible; }
108108

109109
bool mark_or_rebuild_in_progress() const { return _mark_or_rebuild_in_progress; }
110-
bool clearing_bitmap() const { return _clearing_bitmap; }
110+
bool clear_bitmap_in_progress() const { return _clear_bitmap_in_progress; }
111111

112112
// Calculate GC Pause Type from internal state.
113113
G1GCPauseType young_gc_pause_type(bool concurrent_operation_is_full_mark) const;

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1113,7 +1113,7 @@ uint G1ConcurrentMark::completed_mark_cycles() const {
11131113
}
11141114

11151115
void G1ConcurrentMark::concurrent_cycle_end(bool mark_cycle_completed) {
1116-
_g1h->collector_state()->set_clearing_bitmap(false);
1116+
_g1h->collector_state()->set_clear_bitmap_in_progress(false);
11171117

11181118
_g1h->trace_heap_after_gc(_gc_tracer_cm);
11191119

src/hotspot/share/gc/g1/g1Policy.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ void G1Policy::record_full_collection_end() {
594594
collector_state()->set_initiate_conc_mark_if_possible(need_to_start_conc_mark("end of Full GC"));
595595
collector_state()->set_in_concurrent_start_gc(false);
596596
collector_state()->set_mark_or_rebuild_in_progress(false);
597-
collector_state()->set_clearing_bitmap(false);
597+
collector_state()->set_clear_bitmap_in_progress(false);
598598

599599
_eden_surv_rate_group->start_adding_regions();
600600
// also call this on any additional surv rate groups
@@ -1318,7 +1318,7 @@ void G1Policy::record_concurrent_mark_cleanup_end(bool has_rebuilt_remembered_se
13181318
}
13191319
collector_state()->set_in_young_gc_before_mixed(mixed_gc_pending);
13201320
collector_state()->set_mark_or_rebuild_in_progress(false);
1321-
collector_state()->set_clearing_bitmap(true);
1321+
collector_state()->set_clear_bitmap_in_progress(true);
13221322

13231323
double end_sec = os::elapsedTime();
13241324
double elapsed_time_ms = (end_sec - _mark_cleanup_start_sec) * 1000.0;

src/hotspot/share/gc/g1/g1RemSet.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,7 @@ class G1MergeHeapRootsTask : public WorkerTask {
11381138
// Mark phase midway, which might have also left stale marks in old generation regions.
11391139
// There might actually have been scheduled multiple collections, but at that point we do
11401140
// not care that much about performance and just do the work multiple times if needed.
1141-
return (_g1h->collector_state()->clearing_bitmap() ||
1141+
return (_g1h->collector_state()->clear_bitmap_in_progress() ||
11421142
_g1h->concurrent_mark_is_terminating()) &&
11431143
hr->is_old();
11441144
}

0 commit comments

Comments
 (0)