Skip to content

Commit 28f5250

Browse files
committed
8302127: Remove unused arg in write_ref_field_post
Reviewed-by: phh, kbarrett
1 parent 0c96584 commit 28f5250

6 files changed

+8
-8
lines changed

src/hotspot/share/gc/g1/g1BarrierSet.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class G1BarrierSet: public CardTableBarrierSet {
7878
void write_ref_array_work(MemRegion mr) { invalidate(mr); }
7979

8080
template <DecoratorSet decorators, typename T>
81-
void write_ref_field_post(T* field, oop new_val);
81+
void write_ref_field_post(T* field);
8282
void write_ref_field_post_slow(volatile CardValue* byte);
8383

8484
virtual void on_thread_create(Thread* thread);

src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ inline void G1BarrierSet::write_ref_field_pre(T* field) {
6868
}
6969

7070
template <DecoratorSet decorators, typename T>
71-
inline void G1BarrierSet::write_ref_field_post(T* field, oop new_val) {
71+
inline void G1BarrierSet::write_ref_field_post(T* field) {
7272
volatile CardValue* byte = _card_table->byte_for(field);
7373
if (*byte != G1CardTable::g1_young_card_val()) {
7474
// Take a slow path for cards in old

src/hotspot/share/gc/shared/cardTableBarrierSet.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class CardTableBarrierSet: public ModRefBarrierSet {
8080
// either precise or imprecise. We make non-virtual inline variants of
8181
// these functions here for performance.
8282
template <DecoratorSet decorators, typename T>
83-
void write_ref_field_post(T* field, oop newVal);
83+
void write_ref_field_post(T* field);
8484

8585
virtual void invalidate(MemRegion mr);
8686

src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#include "runtime/atomic.hpp"
3232

3333
template <DecoratorSet decorators, typename T>
34-
inline void CardTableBarrierSet::write_ref_field_post(T* field, oop newVal) {
34+
inline void CardTableBarrierSet::write_ref_field_post(T* field) {
3535
volatile CardValue* byte = _card_table->byte_for(field);
3636
*byte = CardTable::dirty_card_val();
3737
}

src/hotspot/share/gc/shared/modRefBarrierSet.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class ModRefBarrierSet: public BarrierSet {
4949
inline void write_ref_field_pre(T* addr) {}
5050

5151
template <DecoratorSet decorators, typename T>
52-
inline void write_ref_field_post(T *addr, oop new_value) {}
52+
inline void write_ref_field_post(T *addr) {}
5353

5454
// Causes all refs in "mr" to be assumed to be modified.
5555
virtual void invalidate(MemRegion mr) = 0;

src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ oop_store_in_heap(T* addr, oop value) {
6363
BarrierSetT *bs = barrier_set_cast<BarrierSetT>(barrier_set());
6464
bs->template write_ref_field_pre<decorators>(addr);
6565
Raw::oop_store(addr, value);
66-
bs->template write_ref_field_post<decorators>(addr, value);
66+
bs->template write_ref_field_post<decorators>(addr);
6767
}
6868

6969
template <DecoratorSet decorators, typename BarrierSetT>
@@ -74,7 +74,7 @@ oop_atomic_cmpxchg_in_heap(T* addr, oop compare_value, oop new_value) {
7474
bs->template write_ref_field_pre<decorators>(addr);
7575
oop result = Raw::oop_atomic_cmpxchg(addr, compare_value, new_value);
7676
if (result == compare_value) {
77-
bs->template write_ref_field_post<decorators>(addr, new_value);
77+
bs->template write_ref_field_post<decorators>(addr);
7878
}
7979
return result;
8080
}
@@ -86,7 +86,7 @@ oop_atomic_xchg_in_heap(T* addr, oop new_value) {
8686
BarrierSetT *bs = barrier_set_cast<BarrierSetT>(barrier_set());
8787
bs->template write_ref_field_pre<decorators>(addr);
8888
oop result = Raw::oop_atomic_xchg(addr, new_value);
89-
bs->template write_ref_field_post<decorators>(addr, new_value);
89+
bs->template write_ref_field_post<decorators>(addr);
9090
return result;
9191
}
9292

0 commit comments

Comments
 (0)