Skip to content

Commit

Permalink
8314837: 5 compiled/codecache tests ignore VM flags
Browse files Browse the repository at this point in the history
Reviewed-by: kvn, lmesnik
  • Loading branch information
Yi-Fan Tsai authored and lmesnik committed Sep 1, 2023
1 parent 2f7c65e commit 2a11bc4
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
10 changes: 4 additions & 6 deletions test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@
* @library /test/lib
* @requires vm.debug
*
* @run driver jdk.test.lib.helpers.ClassFileInstaller
* @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions
* compiler.codecache.CheckCodeCacheInfo
* @run driver compiler.codecache.CheckCodeCacheInfo
*/

package compiler.codecache;
Expand Down Expand Up @@ -68,9 +66,9 @@ public class CheckCodeCacheInfo {
public static void main(String[] args) throws Exception {
ProcessBuilder pb;

pb = ProcessTools.createJavaProcessBuilder("-XX:+PrintCodeCache",
"-XX:+Verbose",
"-version");
pb = ProcessTools.createTestJvm("-XX:+PrintCodeCache",
"-XX:+Verbose",
"-version");
OutputAnalyzer out = new OutputAnalyzer(pb.start());
out.shouldHaveExitValue(0);
out.stdoutShouldMatch(VERBOSE_REGEXP);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
* @test
* @bug 8276036 8277213 8277441
* @summary test for the value of full_count in the message of insufficient codecache
* @requires vm.compMode != "Xint"
* @library /test/lib
*/
public class CodeCacheFullCountTest {
Expand All @@ -54,7 +55,7 @@ public static void wasteCodeCache() throws Exception {
}

public static void runTest() throws Throwable {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
ProcessBuilder pb = ProcessTools.createTestJvm(
"-XX:ReservedCodeCacheSize=2496k", "-XX:-UseCodeCacheFlushing", "-XX:-MethodFlushing", "CodeCacheFullCountTest", "WasteCodeCache");
OutputAnalyzer oa = ProcessTools.executeProcess(pb);
// Ignore adapter creation failures
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* @test
* @bug 8015774
* @summary Verify SegmentedCodeCache option's processing
* @requires vm.flagless
* @library /test/lib /
* @modules java.base/jdk.internal.misc
* java.compiler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* @key randomness
* @bug 8015774
* @summary Verify processing of options related to code heaps sizing.
* @requires vm.flagless
* @library /test/lib /
* @modules java.base/jdk.internal.misc
* java.compiler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* @test
* @bug 8015774
* @summary Verify that PrintCodeCache option print correct information.
* @requires vm.flagless
* @library /test/lib /
* @modules java.base/jdk.internal.misc
* java.compiler
Expand Down

3 comments on commit 2a11bc4

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 2a11bc4 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 2a11bc4 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-2a11bc41 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2a11bc41 from the openjdk/jdk repository.

The commit being backported was authored by Yi-Fan Tsai on 1 Sep 2023 and was reviewed by Vladimir Kozlov and Leonid Mesnik.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-2a11bc41:backport-GoeLin-2a11bc41
$ git checkout backport-GoeLin-2a11bc41
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-2a11bc41

Please sign in to comment.