8272520: Inline GenericTaskQueue::initialize() to the constructor

Reviewed-by: kbarrett, iwalulya

Author: albertnetymk

src/hotspot/share/gc/g1/g1CollectedHeap.cpp

@@ -1511,7 +1511,6 @@ G1CollectedHeap::G1CollectedHeap() :
 
   for (uint i = 0; i < n_queues; i++) {
     G1ScannerTasksQueue* q = new G1ScannerTasksQueue();
-    q->initialize();
     _task_queues->register_queue(i, q);
     ::new (&_evacuation_failed_info_array[i]) EvacuationFailedInfo();
   }

src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

@@ -445,7 +445,6 @@ G1ConcurrentMark::G1ConcurrentMark(G1CollectedHeap* g1h,
 
   for (uint i = 0; i < _max_num_tasks; ++i) {
     G1CMTaskQueue* task_queue = new G1CMTaskQueue();
-    task_queue->initialize();
     _task_queues->register_queue(i, task_queue);
 
     _tasks[i] = new G1CMTask(i, this, task_queue, _region_mark_stats);

src/hotspot/share/gc/g1/g1FullGCMarker.cpp

@@ -46,8 +46,6 @@ G1FullGCMarker::G1FullGCMarker(G1FullCollector* collector,
     _cld_closure(mark_closure(), ClassLoaderData::_claim_strong),
     _mark_stats_cache(mark_stats, G1RegionMarkStatsCache::RegionMarkStatsCacheSize) {
   _mark_stats_cache.reset();
-  _oop_stack.initialize();
-  _objarray_stack.initialize();
 }
 
 G1FullGCMarker::~G1FullGCMarker() {

src/hotspot/share/gc/parallel/psCompactionManager.cpp

@@ -58,10 +58,6 @@ ParCompactionManager::ParCompactionManager() {
   _old_gen = heap->old_gen();
   _start_array = old_gen()->start_array();
 
-  marking_stack()->initialize();
-  _objarray_stack.initialize();
-  _region_stack.initialize();
-
   reset_bitmap_query_cache();
 }
 

src/hotspot/share/gc/parallel/psPromotionManager.cpp

@@ -190,7 +190,6 @@ PSPromotionManager::PSPromotionManager() {
   _old_lab.set_start_array(old_gen()->start_array());
 
   uint queue_size;
-  claimed_stack_depth()->initialize();
   queue_size = claimed_stack_depth()->max_elems();
 
   _totally_drain = (ParallelGCThreads == 1) || (GCDrainStackTargetSize == 0);

src/hotspot/share/gc/shared/taskqueue.hpp

@@ -345,8 +345,6 @@ class GenericTaskQueue: public TaskQueueSuper<N, F> {
   // Initializes the queue to empty.
   GenericTaskQueue();
 
-  void initialize();
-
   // Push the task "t" on the queue.  Returns "false" iff the queue is full.
   inline bool push(E t);
 
@@ -392,11 +390,6 @@ class GenericTaskQueue: public TaskQueueSuper<N, F> {
   void invalidate_last_stolen_queue_id()     { _last_stolen_queue_id = InvalidQueueId; }
 };
 
-template<class E, MEMFLAGS F, unsigned int N>
-GenericTaskQueue<E, F, N>::GenericTaskQueue() : _last_stolen_queue_id(InvalidQueueId), _seed(17 /* random number */) {
-  assert(sizeof(Age) == sizeof(size_t), "Depends on this.");
-}
-
 // OverflowTaskQueue is a TaskQueue that also includes an overflow stack for
 // elements that do not fit in the TaskQueue.
 //

src/hotspot/share/gc/shared/taskqueue.inline.hpp

@@ -49,9 +49,10 @@ inline GenericTaskQueueSet<T, F>::~GenericTaskQueueSet() {
 }
 
 template<class E, MEMFLAGS F, unsigned int N>
-inline void GenericTaskQueue<E, F, N>::initialize() {
-  _elems = ArrayAllocator<E>::allocate(N, F);
-}
+inline GenericTaskQueue<E, F, N>::GenericTaskQueue() :
+  _elems(ArrayAllocator<E>::allocate(N, F)),
+  _last_stolen_queue_id(InvalidQueueId),
+  _seed(17 /* random number */) {}
 
 template<class E, MEMFLAGS F, unsigned int N>
 inline GenericTaskQueue<E, F, N>::~GenericTaskQueue() {

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

@@ -1425,7 +1425,6 @@ class ShenandoahParallelObjectIterator : public ParallelObjectIterator {
     // Initialize queues for every workers
     for (uint i = 0; i < _num_workers; ++i) {
       ShenandoahObjToScanQueue* task_queue = new ShenandoahObjToScanQueue();
-      task_queue->initialize();
       _task_queues->register_queue(i, task_queue);
     }
     // Divide roots among the workers. Assume that object referencing distribution

src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.cpp

@@ -40,7 +40,6 @@ ShenandoahMarkingContext::ShenandoahMarkingContext(MemRegion heap_region, MemReg
   assert(max_queues > 0, "At least one queue");
   for (uint i = 0; i < max_queues; ++i) {
     ShenandoahObjToScanQueue* task_queue = new ShenandoahObjToScanQueue();
-    task_queue->initialize();
     _task_queues->register_queue(i, task_queue);
   }
 }

src/hotspot/share/gc/z/zHeapIterator.cpp

@@ -206,14 +206,12 @@ ZHeapIterator::ZHeapIterator(uint nworkers, bool visit_weaks) :
   // Create queues
   for (uint i = 0; i < _queues.size(); i++) {
     ZHeapIteratorQueue* const queue = new ZHeapIteratorQueue();
-    queue->initialize();
     _queues.register_queue(i, queue);
   }
 
   // Create array queues
   for (uint i = 0; i < _array_queues.size(); i++) {
     ZHeapIteratorArrayQueue* const array_queue = new ZHeapIteratorArrayQueue();
-    array_queue->initialize();
     _array_queues.register_queue(i, array_queue);
   }
 }