Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NUL…
…L check

Reviewed-by: jdv
  • Loading branch information
MBaesken committed Nov 24, 2022
1 parent abeddab commit 2f8a5c2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/java.desktop/share/native/libjavajpeg/imageioJPEG.c
Expand Up @@ -713,6 +713,7 @@ static int setQTables(JNIEnv *env,
CHECK_NULL_RETURN(table, 0);
qdata = (*env)->GetObjectField(env, table, JPEGQTable_tableID);
qdataBody = (*env)->GetPrimitiveArrayCritical(env, qdata, NULL);
CHECK_NULL_RETURN(qdataBody, 0);

if (cinfo->is_decompressor) {
decomp = (j_decompress_ptr) cinfo;
Expand Down

5 comments on commit 2f8a5c2

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 2f8a5c2 Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-2f8a5c2e in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2f8a5c2e from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 24 Nov 2022 and was reviewed by Jayathirth D V.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-2f8a5c2e:MBaesken-backport-2f8a5c2e
$ git checkout MBaesken-backport-2f8a5c2e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev MBaesken-backport-2f8a5c2e

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 2f8a5c2 Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch MBaesken-backport-2f8a5c2e in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2f8a5c2e from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 24 Nov 2022 and was reviewed by Jayathirth D V.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev MBaesken-backport-2f8a5c2e:MBaesken-backport-2f8a5c2e
$ git checkout MBaesken-backport-2f8a5c2e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev MBaesken-backport-2f8a5c2e

Please sign in to comment.