8340491: Thread stack-base assertion should report which thread has the un-set stack

Reviewed-by: shade, kevinw, stefank

Author: David Holmes

Diff for: src/hotspot/share/runtime/thread.cpp

@@ -145,6 +145,16 @@ Thread::Thread(MemTag mem_tag) {
   MACOS_AARCH64_ONLY(DEBUG_ONLY(_wx_init = false));
 }
 
+#ifdef ASSERT
+address Thread::stack_base() const {
+  // Note: can't report Thread::name() here as that can require a ResourceMark which we
+  // can't use because this gets called too early in the thread initialization.
+  assert(_stack_base != nullptr, "Stack base not yet set for thread id:%d (0 if not set)",
+         osthread() != nullptr ? osthread()->thread_id() : 0);
+  return _stack_base;
+}
+#endif
+
 void Thread::initialize_tlab() {
   if (UseTLAB) {
     tlab().initialize();

Diff for: src/hotspot/share/runtime/thread.hpp

@@ -532,7 +532,7 @@ class Thread: public ThreadShadow {
 
  public:
   // Stack overflow support
-  address stack_base() const           { assert(_stack_base != nullptr,"Sanity check"); return _stack_base; }
+  address stack_base() const DEBUG_ONLY(;) NOT_DEBUG({ return _stack_base; })
   void    set_stack_base(address base) { _stack_base = base; }
   size_t  stack_size() const           { return _stack_size; }
   void    set_stack_size(size_t size)  { _stack_size = size; }