Skip to content

Commit

Permalink
8304295: harfbuzz build fails with GCC 7 after JDK-8301998
Browse files Browse the repository at this point in the history
Reviewed-by: shade, erikj, serb, jwaters
  • Loading branch information
caojoshua authored and TheShermanTanker committed Apr 1, 2023
1 parent a19b28a commit 34e66ce
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion make/modules/java.desktop/lib/Awt2dLibraries.gmk
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,8 @@ else

HARFBUZZ_DISABLED_WARNINGS_gcc := missing-field-initializers strict-aliasing \
unused-result
HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess
# noexcept-type required for GCC 7 builds. Not required for GCC 8+.
HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type
HARFBUZZ_DISABLED_WARNINGS_clang := missing-field-initializers range-loop-analysis
HARFBUZZ_DISABLED_WARNINGS_microsoft := 4267 4244

Expand Down

3 comments on commit 34e66ce

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb
Copy link
Member

@mrserb mrserb commented on 34e66ce Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk20u

@openjdk
Copy link

@openjdk openjdk bot commented on 34e66ce Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrserb the backport was successfully created on the branch mrserb-backport-34e66ce1 in my personal fork of openjdk/jdk20u. To create a pull request with this backport targeting openjdk/jdk20u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 34e66ce1 from the openjdk/jdk repository.

The commit being backported was authored by Joshua Cao on 1 Apr 2023 and was reviewed by Aleksey Shipilev, Erik Joelsson, Sergey Bylokhov and Julian Waters.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk20u:

$ git fetch https://github.com/openjdk-bots/jdk20u.git mrserb-backport-34e66ce1:mrserb-backport-34e66ce1
$ git checkout mrserb-backport-34e66ce1
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk20u.git mrserb-backport-34e66ce1

Please sign in to comment.