Skip to content

Commit

Permalink
6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") …
Browse files Browse the repository at this point in the history
…is null

Reviewed-by: tr, aivanov
  • Loading branch information
prsadhuk committed Oct 7, 2022
1 parent d4c9a88 commit 37bd4fb
Show file tree
Hide file tree
Showing 3 changed files with 78 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,8 @@ public UIDefaults getDefaults() {
SwingUtilities2.getSystemMnemonicKeyMask())
});

table.put("PasswordField.echoChar", '*');

// enabled antialiasing depending on desktop settings
flushUnreferenced();
SwingUtilities2.putAATextInfo(useLAFConditions(), table);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,19 @@ protected String getPropertyPrefix() {
return "PasswordField";
}

/**
* Installs the necessary properties on the JPasswordField.
*/
@Override
protected void installDefaults() {
super.installDefaults();
String prefix = getPropertyPrefix();
Character echoChar = (Character)UIManager.getDefaults().get(prefix + ".echoChar");
if (echoChar != null) {
LookAndFeel.installProperty(getComponent(), "echoChar", echoChar);
}
}

/**
* Creates a view (PasswordView) for an element.
*
Expand Down
63 changes: 63 additions & 0 deletions test/jdk/javax/swing/plaf/nimbus/PasswordFieldTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 6852577
* @summary Verifies PasswordField.echoChar is not null for Nimbus L&F
* @run main PasswordFieldTest
*/

import javax.swing.UIManager;
import javax.swing.SwingUtilities;
import javax.swing.UnsupportedLookAndFeelException;

public class PasswordFieldTest {
private static void setLookAndFeel(UIManager.LookAndFeelInfo laf) {
try {
UIManager.setLookAndFeel(laf.getClassName());
} catch (UnsupportedLookAndFeelException ignored) {
System.out.println("Unsupported L&F: " + laf.getClassName());
} catch (ClassNotFoundException | InstantiationException
| IllegalAccessException e) {
throw new RuntimeException(e);
}
}

public static void main(String[] args) throws Exception {
SwingUtilities.invokeAndWait(() -> {
for (UIManager.LookAndFeelInfo laf :
UIManager.getInstalledLookAndFeels()) {
System.out.println("Testing L&F: " + laf.getClassName());
setLookAndFeel(laf);

System.out.println("Echo char: " +
UIManager.get("PasswordField.echoChar"));
if (UIManager.get("PasswordField.echoChar") == null) {
throw new RuntimeException(
"PasswordField.echoChar returns null for " +
laf.getClassName());
}
}
});
}
}

1 comment on commit 37bd4fb

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.