Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for … 
…hr_HR

Reviewed-by: naoto, lancea, jpai
  • Loading branch information
@justin-curtis-lu @naotoj
justin-curtis-lu authored and naotoj committed Jan 4, 2023
1 parent 7dcc689 commit 3b374c0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
3 changes: 2 additions & 1 deletion src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_hr_HR.properties
View file
@@ -1,5 +1,5 @@
#
# Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2005, 2023, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -35,4 +35,5 @@
# This notice and attribution to Taligent may not be removed.
# Taligent is a registered trademark of Taligent, Inc.

EUR=\u20AC
HRK=Kn
4 changes: 1 addition & 3 deletions test/jdk/ProblemList.txt
View file
@@ -1,6 +1,6 @@
###########################################################################
#
# Copyright (c) 2009, 2022, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2009, 2023, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -684,8 +684,6 @@ sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java 8265770 macosx-all

# jdk_text

java/text/Format/NumberFormat/CurrencyFormat.java 8299439 generic-all

############################################################################

# jdk_time
Expand Down
6 changes: 3 additions & 3 deletions test/jdk/java/text/Format/NumberFormat/CurrencySymbols.properties
View file
Expand Up @@ -79,7 +79,7 @@ fr_FR=\u20AC
fr_LU=\u20AC
hi_IN=\u0930\u0942
hr=\u00A4
hr_HR=Kn
hr_HR=\u20AC
hu=\u00A4
hu_HU=Ft
is=\u00A4
Expand All @@ -94,9 +94,9 @@ ja_JP=\uFFE5
ko=\u00A4
ko_KR=\uFFE6
lt=\u00A4
lt_LT=Lt;2014-12-31-22-00-00;\u20AC
lt_LT=\u20AC
lv=\u00A4
lv_LV=Ls;2013-12-31-22-00-00;\u20AC
lv_LV=\u20AC
mk=\u00A4
mk_MK=Den
nl=\u00A4
Expand Down

5 comments on commit 3b374c0

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@JesperIRL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag jdk-21+4

@openjdk
Copy link

@openjdk openjdk bot commented on 3b374c0 Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperIRL The tag jdk-21+4 was successfully created.

@RealCLanger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk20

@openjdk
Copy link

@openjdk openjdk bot commented on 3b374c0 Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RealCLanger the backport was successfully created on the branch RealCLanger-backport-3b374c01 in my personal fork of openjdk/jdk20. To create a pull request with this backport targeting openjdk/jdk20:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 3b374c01 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 4 Jan 2023 and was reviewed by Naoto Sato, Lance Andersen and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk20:

$ git fetch https://github.com/openjdk-bots/jdk20 RealCLanger-backport-3b374c01:RealCLanger-backport-3b374c01
$ git checkout RealCLanger-backport-3b374c01
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk20 RealCLanger-backport-3b374c01

Please sign in to comment.