Skip to content
Permalink
Browse files
8252830: Correct missing javadoc comments in java.rmi module
Reviewed-by: dfuchs, lancea, smarks, chegar
  • Loading branch information
Roger Riggs committed Sep 10, 2020
1 parent 41d29b7 commit 418e4a259c8ba02c5d7a3cc0124f9e8980dc9c8e
Showing 4 changed files with 38 additions and 1 deletion.
@@ -90,6 +90,7 @@ public final class ActivationGroupDesc implements Serializable {
private Properties props;

/** indicate compatibility with the Java 2 SDK v1.2 version of class */
@java.io.Serial
private static final long serialVersionUID = -4936225423168276595L;

/**
@@ -204,6 +205,7 @@ public CommandEnvironment getCommandEnvironment() {
* @since 1.2
*/
public static class CommandEnvironment implements Serializable {
@java.io.Serial
private static final long serialVersionUID = 6165754737887770191L;

/**
@@ -308,12 +310,17 @@ public int hashCode()
*
* <p>This method reads this object's serialized form for this
* class as follows:
*
* <p>This method first invokes <code>defaultReadObject</code> on
* the specified object input stream, and if <code>options</code>
* is <code>null</code>, then <code>options</code> is set to a
* zero-length array of <code>String</code>.
*
* @param in the {@code ObjectInputStream} from which data is read
* @throws IOException if an I/O error occurs
* @throws ClassNotFoundException if a serialized class cannot be loaded
*
*/
@java.io.Serial
private void readObject(ObjectInputStream in)
throws IOException, ClassNotFoundException
{
@@ -90,6 +90,7 @@ public class ActivationID implements Serializable {
private transient UID uid = new UID();

/** indicate compatibility with the Java 2 SDK v1.2 version of class */
@java.io.Serial
private static final long serialVersionUID = -4608673054848209235L;

/** an AccessControlContext with no permissions */
@@ -228,7 +229,11 @@ public boolean equals(Object obj) {
* java.rmi.server.RemoteObject RemoteObject}
* <code>writeObject</code> method <b>serialData</b>
* specification.
*
* @param out the {@code ObjectOutputStream} to which data is written
* @throws IOException if an I/O error occurs
**/
@java.io.Serial
private void writeObject(ObjectOutputStream out)
throws IOException
{
@@ -287,7 +292,13 @@ private void writeObject(ObjectOutputStream out)
* class corresponding to that external ref type name, in which
* case the <code>RemoteRef</code> will be an instance of
* that implementation-specific class.
*
* @param in the {@code ObjectInputStream} from which data is read
* @throws IOException if an I/O error occurs
* @throws ClassNotFoundException if a serialized class cannot be loaded
*
*/
@java.io.Serial
private void readObject(ObjectInputStream in)
throws IOException, ClassNotFoundException
{
@@ -25,6 +25,7 @@

package java.rmi.server;

import java.io.IOException;
import java.rmi.Remote;
import java.rmi.NoSuchObjectException;
import java.lang.reflect.Proxy;
@@ -47,6 +48,7 @@ public abstract class RemoteObject implements Remote, java.io.Serializable {
transient protected RemoteRef ref;

/** indicate compatibility with JDK 1.1.x version of class */
@java.io.Serial
private static final long serialVersionUID = -3215090123894869218L;

/**
@@ -357,7 +359,11 @@ public String toString() {
* <code>"UnicastServerRef2"</code>, no data is written by the
* <code>writeExternal</code> method or read by the
* <code>readExternal</code> method.
*
* @param out the {@code ObjectOutputStream} to which data is written
* @throws IOException if an I/O error occurs
*/
@java.io.Serial
private void writeObject(java.io.ObjectOutputStream out)
throws java.io.IOException
{
@@ -418,7 +424,12 @@ private void writeObject(java.io.ObjectOutputStream out)
* class corresponding to that external ref type name, in which
* case this object's <code>ref</code> field will be set to an
* instance of that implementation-specific class.
*
* @param in the {@code ObjectInputStream} from which data is read
* @throws IOException if an I/O error occurs
* @throws ClassNotFoundException if a serialized class cannot be loaded
*/
@java.io.Serial
private void readObject(java.io.ObjectInputStream in)
throws java.io.IOException, java.lang.ClassNotFoundException
{
@@ -24,6 +24,7 @@
*/
package java.rmi.server;

import java.io.IOException;
import java.io.ObjectInputFilter;
import java.rmi.*;
import sun.rmi.server.UnicastServerRef;
@@ -195,6 +196,7 @@ public class UnicastRemoteObject extends RemoteServer {
private RMIServerSocketFactory ssf = null;

/* indicate compatibility with JDK 1.1.x version of class */
@java.io.Serial
private static final long serialVersionUID = 4974527148936298033L;

/**
@@ -259,7 +261,13 @@ protected UnicastRemoteObject(int port,

/**
* Re-export the remote object when it is deserialized.
*
* @param in the {@code ObjectInputStream} from which data is read
* @throws IOException if an I/O error occurs
* @throws ClassNotFoundException if a serialized class cannot be loaded
*
*/
@java.io.Serial
private void readObject(java.io.ObjectInputStream in)
throws java.io.IOException, java.lang.ClassNotFoundException
{

1 comment on commit 418e4a2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented on 418e4a2 Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

Please sign in to comment.