Skip to content

Commit

Permalink
8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on …
Browse files Browse the repository at this point in the history
…UNIX

Reviewed-by: dholmes, stuefe, mdoerr
  • Loading branch information
Joachim Kern authored and TheRealMDoerr committed Nov 28, 2023
1 parent efc3922 commit 464dc3d
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,17 @@ public static void main(String[] args) throws Throwable {
if (args.length == 0) {

// Create a new java process for the TestPsig Java/JNI test.
// We run the VM in interpreted mode, because the JIT might mark
// a Java method as not-entrant, which means turning the first instruction
// into an illegal one. Calling such a method after establishing
// the new SIGILL signal handler with TestPosixSig.changeSigActionFor(4)
// below, but before the JNI checker noted and reacted on this signal handler
// modification, the JVM may crash or hang in an endless loop, where the
// illegal instruction will be continously executed, raising SIGILL, and
// the signal handler will return to the illegal instruction again...
ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
"-XX:+CheckJNICalls",
"-Xint",
"-Djava.library.path=" + libpath + ":.",
"TestPosixSig", "dummy");

Expand Down

9 comments on commit 464dc3d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKern65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u

@openjdk
Copy link

@openjdk openjdk bot commented on 464dc3d Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKern65 Could not automatically backport 464dc3da to openjdk/jdk21u due to conflicts in the following files:

  • test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b JoKern65-backport-464dc3da

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 464dc3dab540a36aeea76dbeea548c600df58763

# Backport the commit
$ git cherry-pick --no-commit 464dc3dab540a36aeea76dbeea548c600df58763
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 464dc3dab540a36aeea76dbeea548c600df58763'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u with the title Backport 464dc3dab540a36aeea76dbeea548c600df58763.

@JoKern65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close

@openjdk
Copy link

@openjdk openjdk bot commented on 464dc3d Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKern65 Unknown command close - for a list of valid commands use /help.

@JoKern65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/help

@openjdk
Copy link

@openjdk openjdk bot commented on 464dc3d Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKern65 Available commands:

  • backport - create a backport
  • help - shows this text
  • tag - create a tag

@JoKern65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 464dc3d Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKern65 Could not automatically backport 464dc3da to openjdk/jdk21u-dev due to conflicts in the following files:

  • test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk21u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk21u-dev.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-JoKern65-464dc3da

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 464dc3dab540a36aeea76dbeea548c600df58763

# Backport the commit
$ git cherry-pick --no-commit 464dc3dab540a36aeea76dbeea548c600df58763
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 464dc3dab540a36aeea76dbeea548c600df58763'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk21u-dev with the title Backport 464dc3dab540a36aeea76dbeea548c600df58763.

Please sign in to comment.