8333035: Parallel: Remove ParMarkBitMap::IterationStatus

Reviewed-by: tschatzl
openjdk · May 28, 2024 · 4754f05 · 4754f05 · openjdk-notifier · May 28, 2024
1 parent 87a06b6
commit 4754f05
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/src/hotspot/share/gc/parallel/parMarkBitMap.hpp b/src/hotspot/share/gc/parallel/parMarkBitMap.hpp
@@ -35,9 +35,6 @@ class ParMarkBitMap: public CHeapObj<mtGC> {
 public:
   typedef BitMap::idx_t idx_t;
 
-  // Values returned by the iterate() methods.
-  enum IterationStatus { incomplete, complete, full };
-
   inline ParMarkBitMap();
   bool initialize(MemRegion covered_region);
 

diff --git a/src/hotspot/share/gc/parallel/psParallelCompact.cpp b/src/hotspot/share/gc/parallel/psParallelCompact.cpp
@@ -2624,8 +2624,7 @@ void MoveAndUpdateClosure::complete_region(ParCompactionManager *cm, HeapWord *d
   region_ptr->set_completed();
 }
 
-MoveAndUpdateClosure::IterationStatus
-MoveAndUpdateClosure::do_addr(HeapWord* addr, size_t words) {
+void MoveAndUpdateClosure::do_addr(HeapWord* addr, size_t words) {
   assert(destination() != nullptr, "sanity");
   _source = addr;
 
@@ -2648,7 +2647,6 @@ MoveAndUpdateClosure::do_addr(HeapWord* addr, size_t words) {
   }
 
   update_state(words);
-  return is_full() ? ParMarkBitMap::full : ParMarkBitMap::incomplete;
 }
 
 void MoveAndUpdateShadowClosure::complete_region(ParCompactionManager *cm, HeapWord *dest_addr,

diff --git a/src/hotspot/share/gc/parallel/psParallelCompact.hpp b/src/hotspot/share/gc/parallel/psParallelCompact.hpp
@@ -904,7 +904,6 @@ class MoveAndUpdateClosure: public StackObj {
 
  public:
   typedef ParMarkBitMap::idx_t idx_t;
-  typedef ParMarkBitMap::IterationStatus IterationStatus;
 
   ParMarkBitMap*        bitmap() const { return _bitmap; }
 
@@ -914,10 +913,8 @@ class MoveAndUpdateClosure: public StackObj {
   void      set_source(HeapWord* addr) { _source = addr; }
 
   // If the object will fit (size <= words_remaining()), copy it to the current
-  // destination, update the interior oops and the start array and return either
-  // full (if the closure is full) or incomplete.  If the object will not fit,
-  // return would_overflow.
-  virtual IterationStatus do_addr(HeapWord* addr, size_t words);
+  // destination, update the interior oops and the start array.
+  void do_addr(HeapWord* addr, size_t words);
 
   inline MoveAndUpdateClosure(ParMarkBitMap* bitmap, size_t region);