Skip to content

Commit 48d8650

Browse files
Dan SmithRoger RiggsSrikanth AdayapalamLois Foltan
committed
8257845: Integrate JEP 390
8254047: [JEP 390] Revise "value-based class" & apply to wrappers 8252181: [JEP 390] Define & apply annotation jdk.internal.ValueBased 8252183: [JEP 390] Add 'lint' warning for @valuebased classes 8257027: [JEP 390] Diagnose synchronization on @valuebased classes 8252180: [JEP 390] Deprecate wrapper class constructors for removal Co-authored-by: Roger Riggs <rriggs@openjdk.org> Co-authored-by: Srikanth Adayapalam <sadayapalam@openjdk.org> Co-authored-by: Lois Foltan <lfoltan@openjdk.org> Reviewed-by: rriggs, hseigel, mchung, darcy
1 parent ed4c4ee commit 48d8650

File tree

113 files changed

+695
-327
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+695
-327
lines changed

src/hotspot/cpu/aarch64/aarch64.ad

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3893,10 +3893,10 @@ encode %{
38933893
// Load markWord from object into displaced_header.
38943894
__ ldr(disp_hdr, Address(oop, oopDesc::mark_offset_in_bytes()));
38953895

3896-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
3896+
if (DiagnoseSyncOnValueBasedClasses != 0) {
38973897
__ load_klass(tmp, oop);
38983898
__ ldrw(tmp, Address(tmp, Klass::access_flags_offset()));
3899-
__ tstw(tmp, JVM_ACC_IS_BOX_CLASS);
3899+
__ tstw(tmp, JVM_ACC_IS_VALUE_BASED_CLASS);
39003900
__ br(Assembler::NE, cont);
39013901
}
39023902

src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ int C1_MacroAssembler::lock_object(Register hdr, Register obj, Register disp_hdr
7575

7676
null_check_offset = offset();
7777

78-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
78+
if (DiagnoseSyncOnValueBasedClasses != 0) {
7979
load_klass(hdr, obj);
8080
ldrw(hdr, Address(hdr, Klass::access_flags_offset()));
81-
tstw(hdr, JVM_ACC_IS_BOX_CLASS);
81+
tstw(hdr, JVM_ACC_IS_VALUE_BASED_CLASS);
8282
br(Assembler::NE, slow_case);
8383
}
8484

src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -746,10 +746,10 @@ void InterpreterMacroAssembler::lock_object(Register lock_reg)
746746
// Load object pointer into obj_reg %c_rarg3
747747
ldr(obj_reg, Address(lock_reg, obj_offset));
748748

749-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
749+
if (DiagnoseSyncOnValueBasedClasses != 0) {
750750
load_klass(tmp, obj_reg);
751751
ldrw(tmp, Address(tmp, Klass::access_flags_offset()));
752-
tstw(tmp, JVM_ACC_IS_BOX_CLASS);
752+
tstw(tmp, JVM_ACC_IS_VALUE_BASED_CLASS);
753753
br(Assembler::NE, slow_case);
754754
}
755755

src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ int C1_MacroAssembler::lock_object(Register hdr, Register obj,
204204

205205
null_check_offset = offset();
206206

207-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
207+
if (DiagnoseSyncOnValueBasedClasses != 0) {
208208
load_klass(tmp1, obj);
209209
ldr_u32(tmp1, Address(tmp1, Klass::access_flags_offset()));
210-
tst(tmp1, JVM_ACC_IS_BOX_CLASS);
210+
tst(tmp1, JVM_ACC_IS_VALUE_BASED_CLASS);
211211
b(slow_case, ne);
212212
}
213213

src/hotspot/cpu/arm/c2_MacroAssembler_arm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ void C2_MacroAssembler::fast_lock(Register Roop, Register Rbox, Register Rscratc
9090

9191
Label fast_lock, done;
9292

93-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
93+
if (DiagnoseSyncOnValueBasedClasses != 0) {
9494
load_klass(Rscratch, Roop);
9595
ldr_u32(Rscratch, Address(Rscratch, Klass::access_flags_offset()));
96-
tst(Rscratch, JVM_ACC_IS_BOX_CLASS);
96+
tst(Rscratch, JVM_ACC_IS_VALUE_BASED_CLASS);
9797
b(done, ne);
9898
}
9999

src/hotspot/cpu/arm/interp_masm_arm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -883,10 +883,10 @@ void InterpreterMacroAssembler::lock_object(Register Rlock) {
883883
// Load object pointer
884884
ldr(Robj, Address(Rlock, obj_offset));
885885

886-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
886+
if (DiagnoseSyncOnValueBasedClasses != 0) {
887887
load_klass(R0, Robj);
888888
ldr_u32(R0, Address(R0, Klass::access_flags_offset()));
889-
tst(R0, JVM_ACC_IS_BOX_CLASS);
889+
tst(R0, JVM_ACC_IS_VALUE_BASED_CLASS);
890890
b(slow_case, ne);
891891
}
892892

src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ void C1_MacroAssembler::lock_object(Register Rmark, Register Roop, Register Rbox
105105
// Save object being locked into the BasicObjectLock...
106106
std(Roop, BasicObjectLock::obj_offset_in_bytes(), Rbox);
107107

108-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
108+
if (DiagnoseSyncOnValueBasedClasses != 0) {
109109
load_klass(Rscratch, Roop);
110110
lwz(Rscratch, in_bytes(Klass::access_flags_offset()), Rscratch);
111-
testbitdi(CCR0, R0, Rscratch, exact_log2(JVM_ACC_IS_BOX_CLASS));
111+
testbitdi(CCR0, R0, Rscratch, exact_log2(JVM_ACC_IS_VALUE_BASED_CLASS));
112112
bne(CCR0, slow_int);
113113
}
114114

src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -910,10 +910,10 @@ void InterpreterMacroAssembler::lock_object(Register monitor, Register object) {
910910
// Load markWord from object into displaced_header.
911911
ld(displaced_header, oopDesc::mark_offset_in_bytes(), object);
912912

913-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
913+
if (DiagnoseSyncOnValueBasedClasses != 0) {
914914
load_klass(tmp, object);
915915
lwz(tmp, in_bytes(Klass::access_flags_offset()), tmp);
916-
testbitdi(CCR0, R0, tmp, exact_log2(JVM_ACC_IS_BOX_CLASS));
916+
testbitdi(CCR0, R0, tmp, exact_log2(JVM_ACC_IS_VALUE_BASED_CLASS));
917917
bne(CCR0, slow_case);
918918
}
919919

src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2818,10 +2818,10 @@ void MacroAssembler::compiler_fast_lock_object(ConditionRegister flag, Register
28182818
// Load markWord from object into displaced_header.
28192819
ld(displaced_header, oopDesc::mark_offset_in_bytes(), oop);
28202820

2821-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
2821+
if (DiagnoseSyncOnValueBasedClasses != 0) {
28222822
load_klass(temp, oop);
28232823
lwz(temp, in_bytes(Klass::access_flags_offset()), temp);
2824-
testbitdi(flag, R0, temp, exact_log2(JVM_ACC_IS_BOX_CLASS));
2824+
testbitdi(flag, R0, temp, exact_log2(JVM_ACC_IS_VALUE_BASED_CLASS));
28252825
bne(flag, cont);
28262826
}
28272827

src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ void C1_MacroAssembler::lock_object(Register hdr, Register obj, Register disp_hd
9191
// Save object being locked into the BasicObjectLock...
9292
z_stg(obj, Address(disp_hdr, BasicObjectLock::obj_offset_in_bytes()));
9393

94-
if (DiagnoseSyncOnPrimitiveWrappers != 0) {
94+
if (DiagnoseSyncOnValueBasedClasses != 0) {
9595
load_klass(Z_R1_scratch, obj);
96-
testbit(Address(Z_R1_scratch, Klass::access_flags_offset()), exact_log2(JVM_ACC_IS_BOX_CLASS));
96+
testbit(Address(Z_R1_scratch, Klass::access_flags_offset()), exact_log2(JVM_ACC_IS_VALUE_BASED_CLASS));
9797
z_btrue(slow_case);
9898
}
9999

0 commit comments

Comments
 (0)