Skip to content
Permalink
Browse files
8270021: Incorrect log decorators in gc/g1/plab/TestPLABEvacuationFai…
…lure.java

Reviewed-by: tschatzl, iwalulya
  • Loading branch information
albertnetymk committed Jul 8, 2021
1 parent 30bba54 commit 4a45d95719bf68221e6843572511c2eb741ba69c
Showing 2 changed files with 12 additions and 8 deletions.
@@ -68,7 +68,7 @@ public class TestPLABEvacuationFailure {
"failure wasted"));

private static final String[] COMMON_OPTIONS = {
"-Xlog:gc=debug,gc+phases=trace",
"-Xlog:gc,gc+plab=debug",
"-XX:+UseG1GC",
"-XX:InitiatingHeapOccupancyPercent=100",
"-XX:-G1UseAdaptiveIHOP",
@@ -190,13 +190,17 @@ public Map<Long, PlabInfo> getExcludedSpecifiedStats(List<Long> specifiedGcIdFor
}

private Map<Long, PlabInfo> getSpecifiedStats(List<Long> gcIds, LogParser.ReportType type, List<String> fieldNames, boolean extractId) {
return new HashMap<>(
getEntries().entryStream()
.filter(gcLogItem -> extractId == gcIds.contains(gcLogItem.getKey()))
.collect(Collectors.toMap(gcLogItem -> gcLogItem.getKey(),
gcLogItem -> gcLogItem.getValue().get(type).filter(fieldNames)
var map = new HashMap<>(
getEntries().entryStream()
.filter(gcLogItem -> extractId == gcIds.contains(gcLogItem.getKey()))
.collect(Collectors.toMap(gcLogItem -> gcLogItem.getKey(),
gcLogItem -> gcLogItem.getValue().get(type).filter(fieldNames)
)
)
)
);
);
if (map.isEmpty()) {
throw new RuntimeException("Cannot find relevant PLAB statistics in the log");
}
return map;
}
}

3 comments on commit 4a45d95

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 4a45d95 Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 4a45d95 Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 4a45d95 Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-4a45d957 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4a45d957 from the openjdk/jdk repository.

The commit being backported was authored by Albert Mingkun Yang on 8 Jul 2021 and was reviewed by Thomas Schatzl and Ivan Walulya.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-4a45d957:GoeLin-backport-4a45d957
$ git checkout GoeLin-backport-4a45d957
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-4a45d957

Please sign in to comment.